firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
82,274 Commits 1 Branch 0 Tags
Commit Graph

82274 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jackson Gardner
1e9202e1ee
Normalize the translation column of the color matrix. (#161109) 
`dart:ui` specifies that the translation column of the color matrix
should be in the range 0..255. Skia expects a normalized range between 0
and 1. Skwasm was not normalizing this before passing it to Skia, but
CanvasKit was. After writing a unit test, it appears that the HTML
renderer has the same problem, so I also fixed that as well.

This addresses https://github.com/flutter/flutter/issues/159697
 2025-01-08 20:39:21 +00:00
Matan Lurey
132e298335
Rename native_driver to android_{driver_extensions|engine_test} (#161263) 
Towards https://github.com/flutter/flutter/issues/161261 (before I add
more tests).

This is a 1:1 move, with massaging of
`run_flutter_driver_android_tests.dart` to be more automated as tests
are added.

/cc @reidbaker
 2025-01-08 20:28:38 +00:00
Jonah Williams
04a60d6b27
[Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (#161326) 
Reland and forward fix for current tree breakage. GLES may optimize out
the shader binding in a way that behaves differently from Metal/Vulkan.
Don't treat this as an error.

This happens because certain combinations of porter duff constants
result in a 0 * texture lookup.
 2025-01-08 20:23:57 +00:00
jesswrd
f9a3747af0
Updating AVD Dependency for Android 28 Emulator (#160978) 
Emulators depending on Android 28 API are currently failing. Advancing
the AVD dependency to 8733065022087935185, the same version used in
other repos, should fix the errors.

Fixes b/379736755

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-08 19:57:45 +00:00
Mohammed CHAHBOUN
8cc303ef60
Adds onHover and onLongPress to IconButton widget (#160032) 
Adds `onHover` and `onLongPress` to `IconButton` widget

fix #159972 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-01-08 19:57:44 +00:00
Flutter GitHub Bot
603484f1bf
Marks Linux linux_desktop_impeller to be unflaky (#161302) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux linux_desktop_impeller"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20linux_desktop_impeller%22).
This test can be marked as unflaky.
 2025-01-08 19:56:25 +00:00
auto-submit[bot]
7b8c5d8ffd
Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (#161318) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#161273
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: tree broken:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8726329921123044593/+/u/run_new_gallery_opengles_impeller__transition_perf/stdout

```
[2025-01-07 23:23:30.242453] [STDOUT] stdout: [        ] signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------
[2025-01-07 23:23:30.242492] [STDOUT] stdout: [        ] Abort message: '[FATAL:flutter/impeller/renderer/backen
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Part of https://github.com/flutter/flutter/issues/161209

Many Adreno 6XX are having trouble compiling the PorterDuff and ConicalGradient Pipeline. This rewrites the former to use specialization constants to reduce runtime branches. From testing on an S9+, this is sufficient to get it to compile correctly.

As a bonus, this should be faster... though it adds more shaders.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
Co-authored-by: John McDole <codefu@google.com>
 2025-01-08 19:12:16 +00:00
Victor Sanni
9d7f6cc43b
Revert "fixed keyboardDismissBehavior on scroll without a drag" (#161277) 
Reverts https://github.com/flutter/flutter/pull/154675 as it regresses
`ScrollViewKeyboardDismissBehavior.onDrag`.

Fixes https://github.com/flutter/flutter/issues/160331
 2025-01-08 17:36:31 +00:00
Jia Hao
2b51318302
Revert "use uuid from package:uuid instead of from package:usage" (#161292) 
Reverts flutter/flutter#161102

This requires a non-trivial update to `package:uuid` internally - see
b/388416319 for more details.
 2025-01-08 17:11:29 +00:00
Jonah Williams
b5df29072d
[Impeller] porter duff workarounds for Adreno GPU. (#161273) 
Part of https://github.com/flutter/flutter/issues/161209

Many Adreno 6XX are having trouble compiling the PorterDuff and
ConicalGradient Pipeline. This rewrites the former to use specialization
constants to reduce runtime branches. From testing on an S9+, this is
sufficient to get it to compile correctly.

As a bonus, this should be faster... though it adds more shaders.
 2025-01-08 05:50:21 +00:00
Jonah Williams
5f2bf18183
[Impeller] disable input attachment / self dependency on Adreno 630 and older. (#161274) 
Part of https://github.com/flutter/flutter/issues/161209

The input attachment self dependency is broken on 6XX series Adreno, and
without this change advanced blends do not work.
 2025-01-08 01:48:30 +00:00
Flutter GitHub Bot
f3633a942d
Marks Mac_benchmark flutter_gallery_macos__compile to be flaky (#160496) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_benchmark flutter_gallery_macos__compile"
}
-->
Issue link: https://github.com/flutter/flutter/issues/160495

Co-authored-by: Chris Bracken <chris@bracken.jp>
 2025-01-08 00:53:17 +00:00
Elliott Brooks
322f7af5fb
Clear selection state when exiting select mode (#161267) 
Fixes https://github.com/flutter/devtools/issues/8654
 2025-01-07 23:40:11 +00:00
Bartek Pacia
4b23b81828
Remove support for imperative apply of Flutter Gradle Plugin (#160947) 
imperative apply has been deprecated since #139690

part of #121541

Doing this will make things easier for us during the conversion of
`flutter.groovy` into Kotlin.
 2025-01-07 21:51:59 +00:00
Jonah Williams
a3a4995607
[Impeller] disable runtime mipmap generation on Adreno. (#161257) 
I bypassed the ~compressor~ mip generation.

https://github.com/flutter/flutter/issues/160441
https://github.com/flutter/flutter/issues/159876
https://github.com/flutter/flutter/issues/160587

I have no idea how to get this to work. next thing to try is to force
mip generation to happen in a square power of 2 texture, and then blit
the individual mip regions onto the dest texture. For now, disable, as
the issue is quite severe.
 2025-01-07 21:51:54 +00:00
Devon Carew
ad5e1fe300
[deps] remove references to archived repos (#161248) 
- remove references to archived repos; test_reflective_loader, sse,
source_span, source_maps, pub_semver, pool and package_config

These have moved into the dart-lang/tools monorepo.

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

- done as part of https://github.com/dart-lang/sdk/issues/56591

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-07 21:49:48 +00:00
Robert Ancell
94c4d0568e
Allow async platform responses in FlMockBinaryMessenger (#160636) 
To help simplify the keyboard tests.
 2025-01-07 21:48:44 +00:00
Matan Lurey
9467677fef
Change timing of onSurfaceDestroyed to match onSurfaceCleanup (#161252) 
Follow-up to https://github.com/flutter/flutter/pull/160937
(https://github.com/flutter/flutter/issues/160933).

This more or less mirrors what we did already for `onSurfaceCreated` to
match `onSurfaceAvailable`.

With this approach, the master branch should immediately start seeing
better behavior in terms of being able to use the `onSurfaceDestroyed`
callback effectively (before the surface has been released). For
example, for a plugin that already uses `onSurfaceDestroyed`, [i.e
`camerax`](97ce56a68e/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/PreviewHostApiImpl.java):

```java
@Override
public void onSurfaceDestroyed() {
  // Invalidate the SurfaceRequest so that CameraX knows to to make a new request
  // for a surface.
  request.invalidate();
}
```

... the request is now invalidated _before_ the surface has been
destroyed, which is what (I believe) we wanted?

---

Folks that want to publish package updates that _definitely_ use the
correct timing will have to wait for the next stable.

/cc @hasali19 would be great to get your input here.
 2025-01-07 21:15:09 +00:00
Matan Lurey
13ae4cd8d8
Move validation logic for .ci.yaml to flutter/flutter. (#161249) 
Towards https://github.com/flutter/flutter/issues/160915 (future
cleanup: remove the validation from `flutter/cocoon`).

This PR effectively duplicates the logic in
https://github.com/flutter/cocoon/pull/4137, in `flutter/flutter`.

/cc @jtmcdole
 2025-01-07 20:52:28 +00:00
LongCatIsLooong
f6b9f937da
Extract analyze test expectations from test fixture (#161108) 
This allows analyze tests to interpret inline comments in a specific
format as error message expectations.
e.g.,:

Adding `// ERROR: this is bad because A, B, C, D` to line 50 in
`file.ext`

would match an error message that looks like `../path/path/file.ext: 50:
this is bad because A, B, C, D`

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-07 20:51:24 +00:00
engine-flutter-autoroll
4a4eb2a320
Roll Packages from 07ae98c5aff9 to 3fc6b7ace3ff (3 revisions) (#161244) 
07ae98c5af...3fc6b7ace3

2025-01-07 kevmoo@users.noreply.github.com go_router_builder: latest
dependencies (flutter/packages#8326)
2025-01-06 47866232+chunhtai@users.noreply.github.com [go_router]
Updates readme to reflect current status (flutter/packages#8374)
2025-01-06 louisehsu@google.com [in_app_purchase_storekit] fix finish()
not completing (flutter/packages#8324)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-01-07 19:50:00 +00:00
Loïc Sharma
e7a1b68086
[SwiftPM] Add separate feature flag for the app migration (#158897) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

### Overview

This splits the Swift Package Manager feature in two:

1. **SwiftPM feature**: This builds plugins using SwiftPM (if the app
supports it), and, uses the new app & plugin templates that support
SwiftPM
2. **SwiftPM app migration feature**: this updates an existing Flutter
iOS or macOS app to support Swift Package Manager. This feature requires
the SwiftPM feature - if SwiftPM is off, the app migration is also off.

For now, both features are off by default. We plan to turn on the first
feature in the next stable release. The app migration feature will be
stay off by default until we have higher confidence in the migration.

See this mini design doc:
https://github.com/flutter/flutter/issues/151567#issuecomment-2455941279

Here's the PR that updates the SwiftPM docs:
https://github.com/flutter/website/pull/11495

Part of https://github.com/flutter/flutter/issues/151567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
 2025-01-07 19:46:03 +00:00
Chinmay Garde
8273197bc7
[Impeller] Update README on preview status on Android. (#161253) 2025-01-07 19:43:53 +00:00
Matan Lurey
e3b301f23d
Stamp golden files to verify engine Skia Gold is WAI. (#161240) 
Auto-generated by `dart testing/skia_gold_client/tool/generate.dart`.

This is just to make sure that everything is working after the recent
configuration.
 2025-01-07 18:23:39 +00:00
Bartek Pacia
fc261a103b
Fix broken link to Hot Reload gif in README (#161113) 
Something looked off in the README.
 2025-01-07 18:20:21 +00:00
Matan Lurey
986fd14363
Fold _FlutterTestRunnerImpl into FlutterTestRunner. (#161188) 
Closes https://github.com/flutter/flutter/issues/160461.

This pattern is covered by `interface class { ... }` in modern Dart.

See <https://dart.dev/language/class-modifiers#interface>.
 2025-01-07 18:11:29 +00:00
Gray Mackall
f3d2204827
[Android] Add .cxx directories to app template .gitignore (#161069) 
Fixes (but I still need to write the draft of the blog section so don't
autoclose github 🙏 ) https://github.com/flutter/flutter/issues/160372.

-Module templates [already exclude the entire `.android`
directory](d9b7e56646/packages/flutter_tools/templates/module/common/.gitignore.tmpl (L40)).
-Plugin templates [already exclude
`.cxx`](d9b7e56646/packages/flutter_tools/templates/plugin_shared/android.tmpl/.gitignore).

Modified the existing gitignores with
```
nl=$'\n'
sed -i'' -e '/GeneratedPluginRegistrant.java/a\'$'\n''.cxx/'"\\${nl}"'' $(find . -path \*android/.gitignore)
```
(which was probably not the best way)

Fun fact: apparently the `.gitignore` files (including the ones we copy
to the template apps) aren't indexed for search (the `.gitignore.tmpl`
are, but not the ones that we copy exactly [such as this
one](27ba2f2790/packages/flutter_tools/templates/app/android.tmpl/.gitignore)).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com>
Co-authored-by: Greg Price <gnprice@gmail.com>
 2025-01-07 18:09:49 +00:00
jesswrd
481950d3a2
Improve Plugins That Reference V1 Embedding Error Message (#160890) 
Improved the error message that appears when using plugins that
reference v1 embedding. The new error message explains why the error
appears and how to fix it.

Fixes #160204

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
 2025-01-07 18:06:08 +00:00
Martin Anderson
e7e5b1c87a
Update PopInvokedCallback Deprecated message (#160324) 
I might be mistaken, but it seems like there's an error in the
`pop_scope.dart` file. Instead of `PopWithResultInvokedCallback`, it has
`PopInvokedWithResultCallback`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-01-07 18:06:08 +00:00
Jenn Magder
0cc590860d
Mark platform_channel_sample_test_macos unflaky (#160989) 
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/151883 was closed.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-07 17:56:06 +00:00
Jenn Magder
b71247dcab
Migrate engine labeler to top level (#161212) 
Hoist engine/src/flutter/.github/labeler.yml to top-level labeler.
 2025-01-07 17:56:05 +00:00
Jenn Magder
ff27e4a583
Mark analyzer_benchmark unflaky (#160991) 
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/158243 was closed.
 2025-01-07 17:56:05 +00:00
Devon Carew
e30bf85231
use uuid from package:uuid instead of from package:usage (#161102) 
- use uuid from package:uuid instead of from package:usage

`package:usage` is discontinued and no longer maintained; this removes
one use of it from the flutter_tools codebase.

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

See also:
- https://github.com/flutter/flutter/pull/152692
- https://github.com/dart-archive/usage

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-07 17:33:23 +00:00
Jackson Gardner
bb4628e0f0
Scale any clip path by 1 / DPR. (#161190) 
When applying a clip path, we need to scale it by the DPR in order for
it to be placed and sized correctly.

This addresses https://github.com/flutter/flutter/issues/157603
 2025-01-07 16:41:27 +00:00
Matan Lurey
e66e04f39f
Remove verbose: true from canvas_test.dart. (#161211) 
General cleanup after https://github.com/flutter/flutter/issues/157206.
 2025-01-07 16:23:52 +00:00
Reid Baker
b552906977
Set java 11 as expected java version in all templates (#160349) 
Bump templates from java 8 to java 11.

fixes https://github.com/flutter/flutter/issues/156111 

I want to talk to @gmackall before merging to talk through the
consequences.


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
 2025-01-07 15:27:23 +00:00
Matan Lurey
cda3515126
Use flutter repo for engine golds instead of flutter-engine. (#160556) 
Closes https://github.com/flutter/flutter/issues/157206.

I also added a `prefix` that will default to `engine.` to avoid
accidentally stomping on golden names across repos.

/cc @gaaclarke for visibility, @Piinks for visibility.

(I would love to get rid of this "engine copy" of the client as part of
longer-term mono repo deduplication).
 2025-01-07 03:37:36 +00:00
Matan Lurey
95c1bc1c3e
[Engine] Make SkiaGoldClient a NOP when the branch is not main or master. (#161187) 
Unblocks https://github.com/flutter/flutter/pull/160556.

Currently the merge queue runs in post-submit mode, which looks for (and
fails to find) digests for PRs that have not yet been submitted,
blocking the engine goldens from being enabled/checked in
https://github.com/flutter/flutter/pull/160556. This PR is a proposal to
fix that by skipping the tests.

We might decide instead that tests should not be running in the merge
queue at all, in which case we will _not_ merge this PR and will change
how the merge queue works instead. Otherwise this PR is a proof of
concept of [aligning implementations with the
framework](a9b3f6c042/packages/flutter_goldens/lib/flutter_goldens.dart (L338)).
 2025-01-07 01:38:52 +00:00
Matan Lurey
bb805fad1e
Rename shellPath to flutterTesterBinPath. (#161189) 
Closes https://github.com/flutter/flutter/issues/160462.

Maybe there are people who consider `flutter_tester` as the flutter
"shell", but this is more explicit.
 2025-01-07 00:52:45 +00:00
Jonah Williams
434ca754e3
[Impeller] dont generate final 1x1 mip level to work around Adreno GPU bug (#161192) 
Generating the final 1x1 mip level of a texture causes the entire
texture to become corrupted on some Adreno GPUs.

https://github.com/flutter/flutter/issues/160441
https://github.com/flutter/flutter/issues/159876
https://github.com/flutter/flutter/issues/160587
 2025-01-07 00:44:52 +00:00
Matan Lurey
16b9fe049d
TestCompiler emits why an error occurred, if applicable, and some refactors to do so (#160984) 
Closes https://github.com/flutter/flutter/issues/160218.

Basically, replaces `String?` with `sealed class TestCompilerResult {}`,
and ensures `errorMessage` is propogated.

We'll be using this path now for _all_ integration tests (not just for
web-specific things), so I'd like to get error messages.
 2025-01-07 00:20:50 +00:00
gaaclarke
4f35112363
Updated eglConfigChoose error message and error clause. (#161178) 
fixes https://github.com/flutter/flutter/issues/160806

- The error message will never say success anymore.
- The error clause is slightly more permissive. If this resolves the
issue though, the driver for the emulator has a bug in it since it
shouldn't return `success` and zero configs. It's probably just
indicating that it successfully found zero apropos configs.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-07 00:07:21 +00:00
Kate Lovett
7141c2a136
Update golden canary (#161183) 
Verifying the framework golden workflow
Part of resolving https://github.com/flutter/flutter/pull/160556

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-06 22:47:29 +00:00
Matan Lurey
5a23a2a3c4
Remove now-unnecessary command felt analyze. (#160986) 
Closes https://github.com/flutter/flutter/issues/154143.

The entire engine sub-repo is now checked for Dart analysis issues, so a
separate command is not needed.
 2025-01-06 21:43:47 +00:00
Jenn Magder
18163e3695
Mark flavors_test_macos unflaky (#160990) 
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/156943 was closed.
 2025-01-06 21:24:50 +00:00
Jenn Magder
8d60e7e74a
Update GitHub URL for failing android_semantics_integration_test bringup (#160993) 
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/124636 was fixed with
https://github.com/flutter/flutter/pull/127128. However it wasn't, and
is now failing on a legit behavior change the test caught.

The test is now failing due to
https://github.com/flutter/flutter/issues/153594, and if this test
hadn't been marked flaky the commit in question would closed the tree
and been reverted.
 2025-01-06 21:16:56 +00:00
Jenn Magder
938dcdadfd
Mark firebase_release_smoke_test unflaky (#161006) 
`firebase_release_smoke_test` was [marked
flaky](https://github.com/flutter/flutter/pull/147338) due to a firebase
outage in April.
`firebase_android_embedding_v2_smoke_test` was deleted with
https://github.com/flutter/flutter/pull/158223.
`firebase_abstract_method_smoke_test` was deleted with #159145

Closes https://github.com/flutter/flutter/issues/147335.
 2025-01-06 21:15:46 +00:00
Jenn Magder
fbb7807fb4
Update Create Pull Request GitHub workflow reviewers (#161005) 
Update reviewer.

I didn't know this existed until I saw
https://github.com/flutter/flutter/pull/161001.
Introduced https://github.com/flutter/flutter/pull/140363. Tested
credentials are used in the cherry-pick bot:

3762f2e973/.github/workflows/easy-cp.yml (L69)
 2025-01-06 21:15:43 +00:00
Jonah Williams
ffc7ced2a0
[Impeller] protect onscreen cmd buffer with render ready semaphore. (#161140) 
Ensures that the onscreen command buffer is blocked via the render ready
semaphore, instead of just the layout transition. I can confirm this
fixes the rendering artifacts on the Samsung a50 - which I suspect are
the same as the issues these other devices are having. Essentially,
without the semaphore protecting the onscreen pass we can end up writing
to the color attachment while it is still being read.

* https://github.com/flutter/flutter/issues/160522
* https://github.com/flutter/flutter/issues/160370
 2025-01-06 20:26:08 +00:00
Matan Lurey
a9b3f6c042
Update flutter_template_images to 5.0.0. (#161105) 
Closes https://github.com/flutter/flutter/issues/160692.

All references of `skeleton` and `app_shared` have been completely
removed, including in `flutter_template_images`.

See https://github.com/flutter/packages/pull/8360.
 2025-01-06 20:15:07 +00:00