In Dart 2, it is a compile-time error if a superinitializer
appears in an initializer list at any other position than at the end so this
rule is made redundant by the Dart analyzer's basic checks and is no longer
necessary.
This adds support for logical and physical key information inside of RawKeyEvent. This allows developers to differentiate keys in a platform-agnostic way. They are able to tell the physical location of a key (PhysicalKeyboardKey) and a logical meaning of the key (LogicalKeyboardKey), as well as get notified of the character generated by the keypress. All of which is useful for handling keyboard shortcuts.
This PR builds on the previous PR (#27620) which generated the key code mappings and definitions.
b8473cdee1...25c513c72a
git log b8473cdee13d4739afda6b171f4c84280584ab98..25c513c72a5a4b2ef3cf5c174a9541e7f327d2b8 --no-merges --oneline
25c513c72 Roll src/third_party/dart 246430bc8c..52f5e34dbf (5 commits)
b5892b6af Roll src/third_party/skia 44bffbfc1c3e..f2a3f5943e4c (3 commits) (flutter/engine#7749)
f20d8558d Roll src/third_party/skia 26490759e464..44bffbfc1c3e (1 commits) (flutter/engine#7748)
87d3f4281 Roll src/third_party/dart 9c0a73f943..246430bc8c (1 commits)
401d2e24f Roll src/third_party/skia 50e24d7d5f52..26490759e464 (3 commits) (flutter/engine#7745)
aa901fc84 [fuchsia] Update path to fuchsia.ui.scenic (flutter/engine#7731)
c5ab02766 use full git hash for version (flutter/engine#7741)
8c80b404d Roll src/third_party/skia d978b90d205d..50e24d7d5f52 (4 commits) (flutter/engine#7743)
168f92ddd Roll src/third_party/dart 6c680a0ebd..9c0a73f943 (31 commits)
929c8feec Roll src/third_party/skia 8619a34bb875..d978b90d205d (17 commits) (flutter/engine#7736)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
Now the sample analyzer can be run locally with:
dart dev/bots/analyze-sample-code.dart --temp=/tmp/samples
And it leaves /tmp/samples around so you can take a look at the code that was generated to see if it's the artificial environment that the samples are evaluated in that is the culprit for a failed analysis.
Before, you had to specify the whole path to the dart executable, and had to modify the code to keep the tempdir around.
* Update doc header in Opacity class to fix issue #23311
* Added slider with editable numerical value to gallery. Fixes flutter#1542
* Revert "Update doc header in Opacity class to fix issue #23311"
This reverts commit 2d3642bbda6e00389e78631360f8274e9bb7d675.
* Fix typo in slider description
* Increase TextField size to pass accessibility test
* Added Semantics widget to pass accessibility test
* Made description start with caps to match other examples
* Removed unnecessary spacing Container widget
* Update authors file
* Fix indent
* Removed decimal and replaced boundaries with .clamp
Signed-off-by: Martin Staadecker <machstg@gmail.com>
* Undo line wrap from previous commit
Signed-off-by: Martin Staadecker <machstg@gmail.com>
* Update onSubmitted to only call setState when value has changed
Signed-off-by: Martin Staadecker <machstg@gmail.com>
Try to detect Gradle error messages that hint at AndroidX problems, and
warn in the logs about the potential problem and point to documentation
on how to fix the issue.
Unfortunately the Gradle errors based on this root issue are varied and
project dependent. It's probably better to still leave the message
intact in case the problem is unrelated.
Also filters out the plugin warning message pending in
flutter/plugins#1138. It's still valuable to add that for people on
previous versions of Flutter, but this link should override that message
for anyone on an up to date version of Flutter.
#27106
fdc699b803...c40d6dacc7
git log fdc699b803478c7d90a40a51832a964f7da160ae..c40d6dacc78b8c25a2822ec8c6f47aa46f642c5f --no-merges --oneline
c40d6dacc [fuchsia] Update scenic include (flutter/engine#7708)
3c38dd342 Fix versions implementation (flutter/engine#7726)
d292ed6c2 Roll src/third_party/skia c19d81acc096..9564bf44e5fa (5 commits) (flutter/engine#7730)
473097b53 Roll src/third_party/skia 859db6b5a03c..c19d81acc096 (2 commits) (flutter/engine#7729)
d0fee9b28 Roll src/third_party/dart caa8747a37..6c680a0ebd (12 commits) 6c680a0ebd Update dartfix readme and update version numbers 33337cf8d0 Fix API breakage, reexport ConstantEvaluator. c2cdc1c639 Allow migration of multiple files at once. d68d8526f4 Allow nullabilty migration prepareInput/processInput to operate on different ASTs. 5ecf660b50 [dartdevc] skip co19 tests on linux bots ba9fbda83e Rework provisional migration API. a4b681b83a Update dartdoc to 0.28.1+2. fea5413d5a [ VM ] Fix hang of Flutter engine tests caused by global RuntimeEntry objects being destroyed when exit() is called when the VM hasn't finished shutting down. a5570bd995 [vm/compiler] Add optimization flag f0d5cb73a9 Guard the custom formatter for a Map against errors df779789f2 Support two more cases in the convert-to-spread assist (issue 35867) fd2225ab6c Adapt to the flow analysis spec v2.
168cabc97 Roll src/third_party/skia f36ad269e88a..859db6b5a03c (1 commits) (flutter/engine#7727)
ee0cf82c1 Correct libraries.yaml path for stub_ui, add brightness, copy dart2js_platform.dill files (flutter/engine#7725)
053f7a8fa Roll src/third_party/skia 2fc1474f9d62..f36ad269e88a (2 commits) (flutter/engine#7724)
211adeac3 Introduced a number of Java system channels in io/flutter/embedding/engine/systemchannels/ (flutter/engine#7500)
fdf57a64d Roll src/third_party/skia 429251513f71..2fc1474f9d62 (8 commits) (flutter/engine#7721)
77b318603 Roll src/third_party/dart adfa4791fc..caa8747a37 (2 commits) caa8747a37 Rework dartfix NNBD fix to use new NullabilityMigration engine ae5bd68570 Lower relevance of deprecated suggestion sets.
67831a3ed Roll buildroot to c82412bcdcd593f1385a478ae2c4b8eb9814f3b8 (flutter/engine#7718)
6585f334a Allow all entrypoints support by the command line VM. (flutter/engine#7717)
ce0739918 Add FlutterProjectArgs::root_isolate_create_callback (flutter/engine#7651)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
3c118b6c3b...fdc699b803
git log 3c118b6c3b42c89f4ef18fce4b27e328f2fd754d..fdc699b803478c7d90a40a51832a964f7da160ae --no-merges --oneline
fdc699b80 Roll src/third_party/dart 631c550ff9..adfa4791fc (20 commits) adfa4791fc Improve storage for available declarations. 392a869ee4 [infra] Skip all co19_2 tests that are timing out on dartdevc. 033cb7ffcc Issue 1438. Use expression function body for createState(). c3542cbc3b Set relevance for IncludedSuggestionSet. 661e91e30e Extract and migrate tests for ConstantEvaluator. cc74e20eee Make some fields on Interface private, and change the way InheritanceManager2 is tested. 512e2ef292 Extract FixCodeTask/Processor from main dartfix class e4755b34ba Extract FixLintTask/Processor from main dartfix class 1e8f9bf63a Extract FixErrorTask/Processor from main dartfix class 5ae156e055 Extract DartFixListener to record source changes and recommendations 1c0422735e Abstract type operations in flow analysis. efcf8b01b1 Move integration tests of migration API to analysis server. 8f821d408e Fix status files for dartkp 6b73a02937 Fix status files for simarm and simarm64 4fb220707e Hardcode SourceFileEdit.fileStamp to -1 in migration prototype. d972c2b7b7 [vm] Update raw_object_fields.cc after 7e81f56a. c2778062e7 Add UI as code status file entries for simarm 2b8560f4b2 [Fasta] Add spread and control-flow collection flags dc812e0921 [infra] Add third_party/requirejs to the fileset used by dartdevc testing 7e81f56ad7 Save Initializer for field and pass into debugger to enable breakpoint setting.
9f4b8e442 Roll src/third_party/skia 455c74797b46..429251513f71 (8 commits) (flutter/engine#7714)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
This adds a keycode generator that incorporates input from the Chromium and Android source trees, as well as some local tables, to generate static constants for the LogicalKeyboardKey and PhysicalKeyboardKey classes, as well as mappings from each of the platforms we support so far (currently only Android and Fuchsia).
This code generator parses the input files, generates an intermediate data structure (`key_data.json`) that is checked in, and then generates the Dart sources for these classes and some static maps that will also be checked in (but are not included in this PR).
The idea is that these codes don't change often, and so we don't need to generate them on every build, but we would like to be able to update them easily in the future if new data becomes available. If the existing data disappears or becomes unusable, we can maintain the checked-in data structure by hand if necessary, and still be able to generate the code.
This PR only contains the code generator, not the classes themselves. In another follow-on PR, I'll run the generator and check in the output of the generator.
For `fuchsia_compat.dart` Instead of using `runSync`, use `run` to avoid
deadlock when attempting to access specific resources like the Hub in Fuchsia.
The specific example is that in Fuchsia, the `find` command is
attempting to explore `out` which hasn't yet been serviced, as `find` is
blocking on it, causing a deadlock.
cc27cafb84...3c118b6c3b
git log cc27cafb840f6fd57b86a36a3e7ed5461575f10a..3c118b6c3b42c89f4ef18fce4b27e328f2fd754d --no-merges --oneline
3c118b6c3 Disable wuff on Windows (flutter/engine#7713)
ebd18a241 Roll src/third_party/skia 37b7d41d01cb..455c74797b46 (8 commits) (flutter/engine#7712)
00e0640c2 Roll src/third_party/skia 3abdd7a90e45..37b7d41d01cb (2 commits) (flutter/engine#7711)
47e4e1521 Roll src/third_party/dart c26bf54391..631c550ff9 (1 commits) 631c550ff9 Extract and migrate ExitDetector and its tests.
c6376e5b7 Roll src/third_party/skia fac1e367f428..3abdd7a90e45 (1 commits) (flutter/engine#7709)
9b3332392 Roll src/third_party/skia b26b8998fa9c..fac1e367f428 (6 commits) (flutter/engine#7707)
83d8529ff Roll src/third_party/dart 5823be65af..c26bf54391 (29 commits) c26bf54391 Add InheritanceManager2 APIs to access inherited interface/class maps. e83b309354 [vm] Remove single-stepping from PRODUCT 0a2de9238b Extract importLibraryElement() implementation, make it less pessimistic. ae72248770 Encapsulate dartfix name/description of each fix ceb7b89df1 Remove a fix that has now been replaced by an assist 336969538c [vm/bytecode] Revise representation of types, constants and calls in bytecode b5eb7d463e Extract and migrate ErrorReporter tests. db9e3f21c9 remove InconsistentAnalysisException guard code from dartfix 9afb65d7f1 [vm] Fixes for recursive class loading d6caaeeebb [vm] Have Dart_TimelineEvent respect SUPPORT_TIMELINE instead of PRODUCT. d236dca9d9 Add 'offset' to 'getSuggestionDetails'. 3395550962 Provisional nullability migration API in analysis_server. 0637a860f0 Revert "Create new template for breaking changes" 2d6afa04cb Create new template for breaking changes 102f3074d5 Enhance assist to convert invocation of LinkedHashMap to a map literal 3c1ffd23ba remove unneeded override 8d5b5bba41 Allow for non-function types in alias builders. 824598b17d Rename files related to type aliases d7d195283a Add missing type arguments 6efbd07145 Rename FunctionTypeAliasBuilder to TypeAliasBuilder f45d103d67 Finish implementing IsTypeParameterSubtypeOf 7213306aad [VM/Compiler] Do not use unboxed doubles if target CPU does not support VFP 52bd3d9159 Complain about use of deprecated members 0828d2c786 [Fasta] Implement exact types for Set literals 4b28312282 [vm] Remove reference to vm/flag_list.h in runtime/bin/main.cc. c6556dc1a3 [package:js] draft proposal to improve JS interop, see #35084 798123ddb7 add lint associations b59d5a2be9 [vm] Relax assertion about duplicated direct implementors 1f638607c2 Rework the ConstraintVariable.or constructor.
75d7f24fe Roll src/third_party/skia 0ec8ec27b81c..b26b8998fa9c (11 commits) (flutter/engine#7705)
affa62a34 Create stubbed dart:ui implementation, dart2js libraries file, copy rule (flutter/engine#7694)
68d9ac44e Revert "Lower the threshold to raster cache pictures (#7687)" (flutter/engine#7701)
3dbc37531 Update snapshot build rules to generate .o files instead of .S files on Windows (flutter/engine#7702)
351f5a35f Use the Wuffs GIF decoder (flutter/engine#7658)
0b014c4ac Roll src/third_party/skia 5f5e1d57a4ce..0ec8ec27b81c (6 commits) (flutter/engine#7703)
2f87713d4 Revert "Disable the persistent cache (#6835)" (flutter/engine#7689)
2c25936ec Roll src/third_party/skia 2462ca36c800..5f5e1d57a4ce (7 commits) (flutter/engine#7699)
ac003c483 Roll src/third_party/skia 0783aca7ba31..2462ca36c800 (2 commits) (flutter/engine#7698)
e26eab83a Roll src/third_party/skia bb60677d5244..0783aca7ba31 (1 commits) (flutter/engine#7697)
ad525410d Roll src/third_party/skia 2d35a1c87553..bb60677d5244 (1 commits) (flutter/engine#7696)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
Before this, we had several places where an isReleaseMode was defined, all with the same definition. This just makes it more broadly visible to allow our users to use it, as well as creating debug and profile versions, and adding a device lab test for it.
Since this is a const value, this makes it possible for a developer to easily mark blocks that can be removed at AOT compile time.
* Bugfix: Add platformBrightness to TestWindow.
* Manual engine roll:
cc27cafb8 Implemented Dark Mode for Android (#25525) ([flutter/engine#7488](https://github.com/flutter/engine/pull/7488))
9c05cbcfb Roll src/third_party/dart b53dceadaa..5823be65af (5 commits) 5823be65af [vm/compiler] Continued graph checker development (reland) 8231cdb7a3 [gardening] Update status for issue 35854 db7f848632 [vm] Remove dead BigInt code. 35ab1755f4 Support more type propagation for code-as-ui features 569ee07f91 [vm] Cleanup class finalization checks
ec5e6f6ef Ensure dart2js and kernel worker snapshots are copied out of gen dir ([flutter/engine#7692](https://github.com/flutter/engine/pull/7692))
8b5fa65c4 Roll src/third_party/skia 50ea3c06b80f..2d35a1c87553 (6 commits) ([flutter/engine#7693](https://github.com/flutter/engine/pull/7693))
