42523 Commits

Author SHA1 Message Date
Parker Lougheed
22570daa18
Misc docs cleanup and fixes (#155501) 2024-09-24 20:03:08 +00:00
engine-flutter-autoroll
35d57144ce
Roll Flutter Engine from dc44f95b7027 to 2a13c3a27e1f (1 revision) (#155619)
dc44f95b70...2a13c3a27e

2024-09-24 30870216+gaaclarke@users.noreply.github.com Added assert for host buffer allocation. (flutter/engine#55395)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 19:56:43 +00:00
engine-flutter-autoroll
f83b08495a
Roll Flutter Engine from 2745b8797025 to dc44f95b7027 (1 revision) (#155616)
2745b87970...dc44f95b70

2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 3cdb1850e24c to 6e5ff9253147 (1 revision) (flutter/engine#55394)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 18:23:26 +00:00
engine-flutter-autoroll
cf5c362bbe
Roll Flutter Engine from 8a54cc56d4b9 to 2745b8797025 (2 revisions) (#155610)
8a54cc56d4...2745b87970

2024-09-24 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove deprecated and unnecessary parameters from fuchsia*archive (flutter/engine#55324)
2024-09-24 mdebbar@google.com [web] Fix keyboard not showing up when iOS input has decoration text (flutter/engine#55152)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 17:27:25 +00:00
engine-flutter-autoroll
ecf1ad94d4
Roll Flutter Engine from c07812775255 to 8a54cc56d4b9 (2 revisions) (#155607)
c078127752...8a54cc56d4

2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from cffb3d74282a to 3cdb1850e24c (1 revision) (flutter/engine#55391)
2024-09-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 07fd0b51a4a6 to 24ed9af6a961 (1 revision) (flutter/engine#55390)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 16:28:27 +00:00
engine-flutter-autoroll
dc277b7789
Roll Packages from 9de72be7c750 to 4926c0f8bd99 (4 revisions) (#155605)
9de72be7c7...4926c0f8bd

2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686)
2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687)
2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631)
2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da67614 to 4ca51a1de597 (5 revisions) (flutter/packages#7685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 15:57:24 +00:00
Danny Tuppeny
9fcbcd4357
Fix some broken links in DAP readme (#155600)
The location of the DAP readme in the Dart SDK repo moved. Some of the links here got updated, but apparently not all.
2024-09-24 14:47:24 +00:00
engine-flutter-autoroll
b5749a7d65
Roll Flutter Engine from 22e4f015cc99 to c07812775255 (2 revisions) (#155599)
22e4f015cc...c078127752

2024-09-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 29dabfa9d635 to 07fd0b51a4a6 (1 revision) (flutter/engine#55387)
2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 80ea638c60a8 to cffb3d74282a (8 revisions) (flutter/engine#55386)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 11:56:08 +00:00
Danny Tuppeny
3f038aea0b
[flutter_tools] Fix encoded stderr in "dart.log" from debug adapter to client (#155249)
To aid debugging, debug adapter (DAP) clients can ask the debug adapters
to send verbose logs back to the client (so they can capture them in a
client-side log along with other things happening on the client).
Included in this log is the `stderr` output of the `flutter run` process
spawned by the debug adapter.

This output was not decoded correctly for these logs, so showed up like:

```
[Flutter] [stderr] [91, 32, 32, 43, 49, 52, 32, 109, 115, 93, 32, 67, 111, 117, 108, 100, 32, 110, 111, 116, 32, 102, 105, 110, 100, 32, 97, 110, 32, 111, 112, 116, 105, 111, 110, 32, 110, 97, 109, 101, 100, 32, 34, 105, 110, 118, 97, 108, 105, 100, 34, 46, 10, 10, 91, 32, 32, 32, 32, 32, 32, 32, 32, 93, 32, 82, 117, 110, 32, 39, 102, 108, 117, 116, 116, 101, 114, 32, 45, 104, 39, 32, 40, 111, 114, 32, 39, 102, 108, 117, 116, 116, 101, 114, 32, 60, 99, 111, 109, 109, 97, 110, 100, 62, 32, 45, 104, 39, 41, 32, 102, 111, 114, 32, 97, 118, 97, 105, 108, 97, 98, 108, 101, 32, 102, 108, 117, 116, 116, 101, 114, 32, 99, 111, 109, 109, 97, 110, 100, 115, 32, 97, 110, 100, 32, 111, 112, 116, 105, 111, 110, 115, 46, 10]
```

This change decodes the output before processing.

Fixes https://github.com/Dart-Code/Dart-Code/issues/5268

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-24 12:30:06 +01:00
engine-flutter-autoroll
5b5cfa2c80
Roll Flutter Engine from 309468cfd1bb to 22e4f015cc99 (2 revisions) (#155591)
309468cfd1...22e4f015cc

2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 7b0669f89aef to 80ea638c60a8 (1 revision) (flutter/engine#55383)
2024-09-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 419aef963b5a to 29dabfa9d635 (1 revision) (flutter/engine#55382)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 08:29:34 +00:00
Daco Harkes
aef2758716
[native assets] Roll dependencies (#155432)
Rolls native deps to the latest version, and cleans up deprecated field from template.

Tests:

* All the unit and integration tests for native assets. The template and dependencies are exercised in the integration test.

Since `package:native_assets_builder` already checks for having no static libraries as output, the custom check in flutter_tools is removed. The tests stubbing out the native assets builder exercising the custom check are also removed. (The integration tests now check for the error message from the native assets builder.)
2024-09-24 07:19:09 +00:00
engine-flutter-autoroll
b411047401
Roll Flutter Engine from 4013dc28a48b to 309468cfd1bb (2 revisions) (#155588)
4013dc28a4...309468cfd1

2024-09-24 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from ALNKvSVWQSpw1uxPy... to em2Jr5ylJrKKI86rU... (flutter/engine#55379)
2024-09-24 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 5dqcFlKzRjJb6V95W... to Itifj1g1iG3RWRIzM... (flutter/engine#55380)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 07:19:06 +00:00
engine-flutter-autoroll
6c8ca4cbd6
Roll Flutter Engine from 8a5af19a43f3 to 4013dc28a48b (1 revision) (#155585)
8a5af19a43...4013dc28a4

2024-09-24 robert.ancell@canonical.com Use GTask integer return APIs and fix documentation on return value on error. (flutter/engine#55353)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 02:57:25 +00:00
engine-flutter-autoroll
65317b86bf
Roll Flutter Engine from 95c5a0940ad9 to 8a5af19a43f3 (10 revisions) (#155583)
95c5a0940a...8a5af19a43

2024-09-23 skia-flutter-autoroll@skia.org Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371)
2024-09-23 jonahwilliams@google.com [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329)
2024-09-23 30870216+gaaclarke@users.noreply.github.com Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322)
2024-09-23 skia-flutter-autoroll@skia.org Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369)
2024-09-23 jonahwilliams@google.com [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236)
2024-09-23 jason-simmons@users.noreply.github.com Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158)
2024-09-23 jonahwilliams@google.com [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330)
2024-09-23 jonahwilliams@google.com [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235)
2024-09-23 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365)
2024-09-23 jonahwilliams@google.com [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-24 01:54:33 +00:00
Kostia Sokolovskyi
96ba3c555a
Add WidgetStateProperty example and tests for it. (#155315)
This PR contributes to https://github.com/flutter/flutter/issues/155313

### Description
- Adds example for `WidgetStateProperty`
- Adds tests for `examples/api/lib/widgets/widget_state/widget_state_property.0.dart`
2024-09-24 00:31:07 +00:00
gaaclarke
1ed8a0a0fd
Redo flutter engine flutter autoroll bd3d1990 485b 419c 8c55 b27e3eeb15ed 1727117767 (#155579)
fixes https://github.com/flutter/flutter/issues/155578
A manual roll for https://github.com/flutter/flutter/pull/155560
2024-09-24 00:21:06 +00:00
engine-flutter-autoroll
beaf1fe680
Roll Flutter Engine from 61f0a3fbabbe to 9bb0ece79ae2 (2 revisions) (#155549)
61f0a3fbab...9bb0ece79a

2024-09-23 magder@google.com Remove Linux orchestrator builds that only kick off one other build and wait (flutter/engine#55186)
2024-09-23 skia-flutter-autoroll@skia.org Roll Skia from a402d3c60c16 to c20cce6273fb (1 revision) (flutter/engine#55359)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-23 18:04:07 +00:00
Jenn Magder
8a07265a88
Assert macOS framework artifact contains xcprivacy manifest (#155189)
Add tool test to validate a built macOS app contains the FlutterMacOS framework xcprivacy manifest.

Blocked on https://github.com/flutter/engine/pull/55078 rolling in.
2024-09-23 17:12:31 +00:00
engine-flutter-autoroll
4d6d9f365c
Roll Packages from f54fe930753f to 9de72be7c750 (1 revision) (#155540)
f54fe93075...9de72be7c7

2024-09-21 engine-flutter-autoroll@skia.org Roll Flutter from 7fe82377f950 to 2f149da67614 (16 revisions) (flutter/packages#7676)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-23 15:53:24 +00:00
engine-flutter-autoroll
4ca51a1de5
Roll Flutter Engine from c1bcd87b44a3 to 61f0a3fbabbe (1 revision) (#155534)
c1bcd87b44...61f0a3fbab

2024-09-23 skia-flutter-autoroll@skia.org Roll Skia from 864aadba7862 to a402d3c60c16 (1 revision) (flutter/engine#55356)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-23 09:51:28 +00:00
engine-flutter-autoroll
cbdc387ef6
Roll Flutter Engine from c11e75b9842a to c1bcd87b44a3 (1 revision) (#155528)
c11e75b984...c1bcd87b44

2024-09-23 skia-flutter-autoroll@skia.org Roll Skia from ec0ed4afabf4 to 864aadba7862 (2 revisions) (flutter/engine#55354)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-23 08:44:14 +00:00
engine-flutter-autoroll
2c54a418a2
Roll Flutter Engine from 0155f8fc4569 to c11e75b9842a (9 revisions) (#155524)
0155f8fc45...c11e75b984

2024-09-23 skia-flutter-autoroll@skia.org Roll Skia from 8c44a27b32a8 to ec0ed4afabf4 (1 revision) (flutter/engine#55351)
2024-09-22 skia-flutter-autoroll@skia.org Roll Skia from 1d03ec881675 to 8c44a27b32a8 (1 revision) (flutter/engine#55342)
2024-09-22 skia-flutter-autoroll@skia.org Roll Skia from c01f89da7c38 to 1d03ec881675 (1 revision) (flutter/engine#55336)
2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from 1be7027570a0 to c01f89da7c38 (1 revision) (flutter/engine#55328)
2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from ca5731228de9 to 1be7027570a0 (1 revision) (flutter/engine#55327)
2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from bdbbdee1db8c to ca5731228de9 (1 revision) (flutter/engine#55326)
2024-09-20 30870216+gaaclarke@users.noreply.github.com Adds vscode workspace with impeller test runner (flutter/engine#55291)
2024-09-20 skia-flutter-autoroll@skia.org Roll Skia from 16f53694ec96 to bdbbdee1db8c (1 revision) (flutter/engine#55321)
2024-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 21402561f6d3 to 419aef963b5a (1 revision) (flutter/engine#55320)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-23 07:23:26 +00:00
engine-flutter-autoroll
101c8ae6c2
Roll Flutter Engine from 76b7abb5c853 to 0155f8fc4569 (1 revision) (#155472)
76b7abb5c8...0155f8fc45

2024-09-20 skia-flutter-autoroll@skia.org Roll Skia from cde3d60ab3fe to 16f53694ec96 (1 revision) (flutter/engine#55319)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-22 18:21:32 +00:00
Sam Rawlins
ec28b057f2
create_api_docs.dart: correct command logging (#155226)
The tool currently prints that the _dart_ command is run, and does not include the 'pub' sub-command. Something like:

```none
/private/var/folders/72/ltck4q353hsg3bn8kpkg7f84005w15/T/flutterzXpww6/bin/dart \
    global run --enable-asserts dartdoc
```

(newline mine)

But this is incorrect; the `runPubGet` function runs the _flutter_ command, and prepends `pub` to the list of arguments.
2024-09-22 16:01:41 +00:00
Dr. Artificial曾小健
2f149da676
Update README.md (#155206)
This PR changes

> libraries like Skia (that underpins Chrome and Android)

to:

> libraries like Skia (which underpins Chrome and Android)
2024-09-20 21:40:20 +00:00
engine-flutter-autoroll
38105edec4
Roll Flutter Engine from 3fbe87c088d3 to 76b7abb5c853 (3 revisions) (#155464)
3fbe87c088...76b7abb5c8

2024-09-20 skia-flutter-autoroll@skia.org Roll Skia from c79d632de004 to cde3d60ab3fe (2 revisions) (flutter/engine#55318)
2024-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 4f89df941fbc to 21402561f6d3 (1 revision) (flutter/engine#55317)
2024-09-20 skia-flutter-autoroll@skia.org Roll Skia from a1d882ec91e2 to c79d632de004 (3 revisions) (flutter/engine#55315)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-20 17:04:24 +00:00
engine-flutter-autoroll
609b603e4a
Roll Packages from d83d021f70d1 to f54fe930753f (1 revision) (#155459)
d83d021f70...f54fe93075

2024-09-19 tarrinneal@gmail.com [pigeon] Validates support for nested collections with generic types. (flutter/packages#7614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-20 15:47:07 +00:00
engine-flutter-autoroll
2528fa95eb
Roll Flutter Engine from f5310c2345cc to 3fbe87c088d3 (1 revision) (#155440)
f5310c2345...3fbe87c088

2024-09-20 skia-flutter-autoroll@skia.org Roll Skia from fa43a5f015f0 to a1d882ec91e2 (1 revision) (flutter/engine#55312)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-20 06:53:26 +00:00
engine-flutter-autoroll
1095351700
Roll Flutter Engine from 730f7124213f to f5310c2345cc (1 revision) (#155436)
730f712421...f5310c2345

2024-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from fb78ccd8c565 to 4f89df941fbc (1 revision) (flutter/engine#55311)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-20 03:50:24 +00:00
engine-flutter-autoroll
549ac74241
Roll Flutter Engine from 90630957b33e to 730f7124213f (1 revision) (#155431)
90630957b3...730f712421

2024-09-19 skia-flutter-autoroll@skia.org Roll Skia from 195cc3e2c740 to fa43a5f015f0 (1 revision) (flutter/engine#55308)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-20 00:05:39 +00:00
engine-flutter-autoroll
c35b2145a4
Roll Flutter Engine from d8ac05c3fb4f to 90630957b33e (1 revision) (#155428)
d8ac05c3fb...90630957b3

2024-09-19 skia-flutter-autoroll@skia.org Roll Skia from ca94a5369af5 to 195cc3e2c740 (1 revision) (flutter/engine#55304)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 21:23:06 +00:00
engine-flutter-autoroll
689a50e199
Roll Flutter Engine from 0ed8af4d6e5d to d8ac05c3fb4f (2 revisions) (#155425)
0ed8af4d6e...d8ac05c3fb

2024-09-19 skia-flutter-autoroll@skia.org Roll Skia from 9d16a74c860a to ca94a5369af5 (2 revisions) (flutter/engine#55302)
2024-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 6c85a403add7 to fb78ccd8c565 (1 revision) (flutter/engine#55303)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 20:19:40 +00:00
engine-flutter-autoroll
d92af93f14
Roll Packages from c7406b3c3276 to d83d021f70d1 (3 revisions) (#155421)
c7406b3c32...d83d021f70

2024-09-19 engine-flutter-autoroll@skia.org Manual roll Flutter from c4c9f47c479d to 7fe82377f950 (14 revisions) (flutter/packages#7663)
2024-09-18 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `AdsRenderingSettings` (flutter/packages#7660)
2024-09-18 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.34.0 to 3.35.0 in /packages/interactive_media_ads/android (flutter/packages#7562)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 18:57:41 +00:00
engine-flutter-autoroll
7937e2b209
Roll Flutter Engine from 1d889dd5acac to 0ed8af4d6e5d (1 revision) (#155419)
1d889dd5ac...0ed8af4d6e

2024-09-19 skia-flutter-autoroll@skia.org Roll Skia from 5e9aa3211d90 to 9d16a74c860a (1 revision) (flutter/engine#55301)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 18:42:29 +00:00
engine-flutter-autoroll
568ed33da9
Roll Flutter Engine from af3e63a638f7 to 1d889dd5acac (1 revision) (#155397)
af3e63a638...1d889dd5ac

2024-09-19 skia-flutter-autoroll@skia.org Roll Skia from 8a2f85d16b94 to 5e9aa3211d90 (4 revisions) (flutter/engine#55299)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 10:03:32 +00:00
engine-flutter-autoroll
410968290f
Roll Flutter Engine from bc7d519a332c to af3e63a638f7 (1 revision) (#155389)
bc7d519a33...af3e63a638

2024-09-19 skia-flutter-autoroll@skia.org Roll Skia from 8858f081d1e1 to 8a2f85d16b94 (1 revision) (flutter/engine#55294)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 05:33:20 +00:00
engine-flutter-autoroll
d5aa73ba34
Roll Flutter Engine from fe823a93f631 to bc7d519a332c (1 revision) (#155387)
fe823a93f6...bc7d519a33

2024-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 379f0145421f to 6c85a403add7 (1 revision) (flutter/engine#55293)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 04:32:23 +00:00
engine-flutter-autoroll
75ffa4ef8f
Roll Flutter Engine from 94f852d2348c to fe823a93f631 (5 revisions) (#155385)
94f852d234...fe823a93f6

2024-09-19 skia-flutter-autoroll@skia.org Roll Skia from 321d7750aa07 to 8858f081d1e1 (1 revision) (flutter/engine#55292)
2024-09-18 skia-flutter-autoroll@skia.org Roll Skia from a60a52a11763 to 321d7750aa07 (2 revisions) (flutter/engine#55290)
2024-09-18 smartercallum@gmail.com [ios] Update gesture position on every event (flutter/engine#55285)
2024-09-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 9164e2c0e994 to 379f0145421f (1 revision) (flutter/engine#55289)
2024-09-18 skia-flutter-autoroll@skia.org Roll Skia from 760e37059fde to a60a52a11763 (2 revisions) (flutter/engine#55287)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 03:36:38 +00:00
engine-flutter-autoroll
11566877d5
Roll Flutter Engine from 15e9e3153266 to 94f852d2348c (2 revisions) (#155376)
15e9e31532...94f852d234

2024-09-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 84f4d161ed50 to 9164e2c0e994 (1 revision) (flutter/engine#55284)
2024-09-18 skia-flutter-autoroll@skia.org Roll Skia from 178a30c1efcc to 760e37059fde (1 revision) (flutter/engine#55281)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-19 01:51:57 +00:00
dependabot[bot]
3c6f2131f5
Bump peter-evans/create-pull-request from 7.0.2 to 7.0.5 (#155378)
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.2 to 7.0.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v7.0.5</h2>
<p>⚙️ Fixes an issue with commit signing to allow it to support symlinks</p>
<h2>What's Changed</h2>
<ul>
<li>fix: support symlinks when commit signing by <a href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3359">peter-evans/create-pull-request#3359</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.4...v7.0.5">https://github.com/peter-evans/create-pull-request/compare/v7.0.4...v7.0.5</a></p>
<h2>Create Pull Request v7.0.4</h2>
<p>⚙️ Fixes an issue with commit signing to allow it to support submodules</p>
<h2>What's Changed</h2>
<ul>
<li>docs: correct suggestion for bot setup by <a href="https://github.com/henryiii"><code>@​henryiii</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3342">peter-evans/create-pull-request#3342</a></li>
<li>build(deps-dev): bump <code>@​types/jest</code> from 29.5.12 to 29.5.13 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3343">peter-evans/create-pull-request#3343</a></li>
<li>build(deps-dev): bump eslint from 8.57.0 to 8.57.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3344">peter-evans/create-pull-request#3344</a></li>
<li>fix: support submodules when commit signing by <a href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3354">peter-evans/create-pull-request#3354</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/henryiii"><code>@​henryiii</code></a> made their first contribution in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3342">peter-evans/create-pull-request#3342</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.3...v7.0.4">https://github.com/peter-evans/create-pull-request/compare/v7.0.3...v7.0.4</a></p>
<h2>Create Pull Request v7.0.3</h2>
<p>⚙️ Fixes an issue with commit signing where commit SHAs have variable lengths when abbreviated.</p>
<h2>What's Changed</h2>
<ul>
<li>fix: disable abbreviated commit shas in diff by <a href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3337">peter-evans/create-pull-request#3337</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.2...v7.0.3">https://github.com/peter-evans/create-pull-request/compare/v7.0.2...v7.0.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5e914681df"><code>5e91468</code></a> fix: support symlinks when commit signing (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3359">#3359</a>)</li>
<li><a href="2f38cd26bf"><code>2f38cd2</code></a> fix: support submodules when commit signing (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3354">#3354</a>)</li>
<li><a href="7a8aeac749"><code>7a8aeac</code></a> build(deps-dev): bump eslint from 8.57.0 to 8.57.1 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3344">#3344</a>)</li>
<li><a href="d39d596a77"><code>d39d596</code></a> build(deps-dev): bump <code>@​types/jest</code> from 29.5.12 to 29.5.13 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3343">#3343</a>)</li>
<li><a href="f6f978fd3d"><code>f6f978f</code></a> docs: correct suggestion for bot setup (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3342">#3342</a>)</li>
<li><a href="6cd32fd936"><code>6cd32fd</code></a> fix: disable abbreviated commit shas in diff (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3337">#3337</a>)</li>
<li>See full diff in <a href="d121e62763...5e914681df">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=7.0.2&new-version=7.0.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-09-19 01:51:54 +00:00
engine-flutter-autoroll
7fe82377f9
Roll Flutter Engine from 4bdcbf39c200 to 15e9e3153266 (1 revision) (#155371)
4bdcbf39c2...15e9e31532

2024-09-18 chinmaygarde@google.com [Impeller] Expose a single-header C API to Impellers Display-List layer. (flutter/engine#55238)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-18 18:52:23 +00:00
engine-flutter-autoroll
d4a9fa70a8
Roll Flutter Engine from fdf38910bad4 to 4bdcbf39c200 (5 revisions) (#155368)
fdf38910ba...4bdcbf39c2

2024-09-18 skia-flutter-autoroll@skia.org Roll Skia from e60181fbd809 to 178a30c1efcc (1 revision) (flutter/engine#55280)
2024-09-18 skia-flutter-autoroll@skia.org Roll Dart SDK from b4bfea33ab1d to 84f4d161ed50 (1 revision) (flutter/engine#55279)
2024-09-18 skia-flutter-autoroll@skia.org Roll Skia from ae4e7753fa9b to e60181fbd809 (1 revision) (flutter/engine#55278)
2024-09-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 089ef90b6680 to b4bfea33ab1d (1 revision) (flutter/engine#55276)
2024-09-18 skia-flutter-autoroll@skia.org Roll Skia from 86abf2391374 to ae4e7753fa9b (4 revisions) (flutter/engine#55275)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-18 17:54:30 +00:00
engine-flutter-autoroll
20ba964c90
Roll Packages from 4f2b9cd5b674 to c7406b3c3276 (1 revision) (#155362)
4f2b9cd5b6...c7406b3c32

2024-09-17 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for mid-roll ads (flutter/packages#7407)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-18 15:48:20 +00:00
engine-flutter-autoroll
1cd629fe19
Roll Flutter Engine from 4f2d866aef32 to fdf38910bad4 (1 revision) (#155339)
4f2d866aef...fdf38910ba

2024-09-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 50f697183f25 to 089ef90b6680 (1 revision) (flutter/engine#55271)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-18 04:27:35 +00:00
engine-flutter-autoroll
708f53c4e6
Roll Flutter Engine from 311ba971bb3a to 4f2d866aef32 (4 revisions) (#155329)
311ba971bb...4f2d866aef

2024-09-17 skia-flutter-autoroll@skia.org Roll Skia from b5cc234f229d to 86abf2391374 (1 revision) (flutter/engine#55269)
2024-09-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 84fac36df65a to 50f697183f25 (3 revisions) (flutter/engine#55268)
2024-09-17 bdero@google.com [Flutter GPU] Remove the redundant smoketest. (flutter/engine#55267)
2024-09-17 30870216+gaaclarke@users.noreply.github.com Fixed solid blur style math (flutter/engine#55194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-18 01:05:31 +00:00
Taha Tesser
d5e843eca3
Fix missing icon props in button styleFrom methods (#154821)
Fixes [Add missing icon props in button `styleFrom`  methods.](https://github.com/flutter/flutter/issues/154798)

### Description

Add missing icon propers in the following widgets:

- `ElevatedButton.styleFrom` (missing `iconSize`)
- `FilledButton.styleFrom` (missing `iconSize`)
- `OutlinedButton.styleFrom` (missing `iconSize`)
- `TextButton.styleFrom` (missing `iconSize`)
- `MenuItemButton.styleFrom` (missing `iconSize` and `disabledIconColor`)
- `SubmenuButton.styleFrom` (missing `iconSize` and `disabledIconColor`)
- `SegmentedButton.styleFrom` (missing `iconSize`, `iconColor`, and `disabledIconColor`)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

enum Calendar { day, week, month, year }

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  Calendar calendarView = Calendar.week;
  bool isEnabled = true;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Column(
            spacing: 10.0,
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              ElevatedButton.icon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('ElevatedButton'),
              ),
              FilledButton.icon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('FilledButton'),
              ),
              FilledButton.tonalIcon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('Add'),
              ),
              OutlinedButton.icon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('OutlinedButton'),
              ),
              TextButton.icon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('TextButton'),
              ),
              SizedBox(
                width: 200,
                child: MenuItemButton(
                  style: MenuItemButton.styleFrom(
                    iconSize: 30,
                    iconColor: Colors.red,
                    disabledIconColor: Colors.red.withValues(alpha: 0.5),
                  ),
                  trailingIcon: const Icon(Icons.arrow_forward_ios),
                  onPressed: isEnabled ? () {} : null,
                  child: const Text('MenuItemButton'),
                ),
              ),
              SizedBox(
                width: 200,
                child: SubmenuButton(
                  style: SubmenuButton.styleFrom(
                    iconSize: 30,
                    iconColor: Colors.red,
                    disabledIconColor: Colors.red.withValues(alpha: 0.5),
                  ),
                  trailingIcon: const Icon(Icons.arrow_forward_ios),
                  menuChildren: <Widget>[
                    if (isEnabled) const Text('Item'),
                  ],
                  child: const Text('SubmenuButton'),
                ),
              ),
              SegmentedButton<Calendar>(
                style: SegmentedButton.styleFrom(
                  iconColor: Colors.red,
                  iconSize: 30,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                segments: const <ButtonSegment<Calendar>>[
                  ButtonSegment<Calendar>(
                      value: Calendar.day,
                      label: Text('Day'),
                      icon: Icon(Icons.calendar_view_day)),
                  ButtonSegment<Calendar>(
                      value: Calendar.week,
                      label: Text('Week'),
                      icon: Icon(Icons.calendar_view_week)),
                  ButtonSegment<Calendar>(
                      value: Calendar.month,
                      label: Text('Month'),
                      icon: Icon(Icons.calendar_view_month)),
                  ButtonSegment<Calendar>(
                      value: Calendar.year,
                      label: Text('Year'),
                      icon: Icon(Icons.calendar_today)),
                ],
                selected: <Calendar>{calendarView},
                onSelectionChanged:
                    isEnabled ? (Set<Calendar> newSelection) {} : null,
              )
            ],
          ),
        ),
        floatingActionButton: FloatingActionButton.extended(
          onPressed: () {
            setState(() {
              isEnabled = !isEnabled;
            });
          },
          label: Text(isEnabled ? 'Enabled' : 'Disabled'),
        ),
      ),
    );
  }
}
```

</details>

### Preview (Customized using icon props in `styleFrom`  methods)

<img width="838" alt="Screenshot 2024-09-09 at 16 27 19" src="https://github.com/user-attachments/assets/551d328b-307f-4f63-b0e8-1358a12877f9">
2024-09-18 00:19:40 +00:00
engine-flutter-autoroll
d0a9e3be94
Roll Flutter Engine from 0ef18a3ef064 to 311ba971bb3a (8 revisions) (#155325)
0ef18a3ef0...311ba971bb

2024-09-17 skia-flutter-autoroll@skia.org Roll Skia from de3717fe550e to b5cc234f229d (1 revision) (flutter/engine#55266)
2024-09-17 bdero@google.com Remove tinygltf (flutter/engine#55264)
2024-09-17 bdero@google.com Update the Impeller Scene doc (flutter/engine#55265)
2024-09-17 bdero@google.com [Flutter GPU] Add DeviceBuffer.flush & GpuContext.getMinimumUniformByteAlignment. (flutter/engine#53620)
2024-09-17 bdero@google.com Remove scene GLB files (flutter/engine#55263)
2024-09-17 bdero@google.com [Flutter GPU] Add golden test for rendering a triangle. (flutter/engine#55262)
2024-09-17 skia-flutter-autoroll@skia.org Roll Dart SDK from de4a3d63671c to 84fac36df65a (2 revisions) (flutter/engine#55255)
2024-09-17 skia-flutter-autoroll@skia.org Roll Skia from ad08229fd016 to de3717fe550e (5 revisions) (flutter/engine#55261)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-17 23:05:22 +00:00
Tong Mu
c57f99e419
[CupertinoAlertDialog] Add tap-slide gesture (#154853)
This PR adds "sliding tap" to `CupertinoAlertDialog` and fixes https://github.com/flutter/flutter/issues/19786. 

Much of the needed infrastructure has been implemented in https://github.com/flutter/flutter/pull/150219, but this time with a new challenge to support disabled buttons, i.e. the button should not show tap highlight when pressed (https://github.com/flutter/flutter/issues/107371).
* Why? Because whether a button is disabled is assigned to `CupertinoDialogAction`, while the background is rendered by a private class that wraps the action widget and built by the dialog body. We need a way to pass the boolean "enabled" from the child to the parent when the action is pressed. After much experimentation, I think the best way is to propagate this boolean using the custom gesture callback.
* An alternative way is to make the wrapper widget use an inherited widget, which allows the child `CupertinoDialogAction` to place a `ValueGetter<bool> getEnabled` to the parent as soon as it's mounted. However, this is pretty ugly...

This PR also fixes https://github.com/flutter/flutter/issues/107371, i.e. disabled `CupertinoDialogAction` no longer triggers the pressing highlight. However, while legacy buttons (custom button classes that are implemented by `GestureDetector.onTap`) still functions (their `onPressed` continues to work), disabled legacy buttons will still show pressing highlight, and there's no plan (actually, no way) to fix it. 

All tests related to sliding taps in `CupertinoActionSheet` has been copied to `CupertinoAlertDialog`, with additional tests for disabled buttons.
2024-09-17 20:16:18 +00:00
John McDole
93eabf3558
Uninstall /can fail/ (#155314)
Error != Exception.

Fixes #149666
2024-09-17 19:17:06 +00:00
engine-flutter-autoroll
6fb9a19182
Roll Packages from df88c814248d to 4f2b9cd5b674 (3 revisions) (#155312)
df88c81424...4f2b9cd5b6

2024-09-17 engine-flutter-autoroll@skia.org Roll Flutter from 5d83a98331ac to c4c9f47c479d (15 revisions) (flutter/packages#7656)
2024-09-17 engine-flutter-autoroll@skia.org Roll Flutter from 2d30fe448cd4 to 5d83a98331ac (5 revisions) (flutter/packages#7650)
2024-09-17 stuartmorgan@google.com Revert "[webview_flutter] Improve flaky scroll tests" (flutter/packages#7652)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-17 19:02:26 +00:00