engine-flutter-autoroll
237b8981c2
Manual roll Flutter Engine from 6745955bb49e to 6cefbe183546 (6 revisions) ( #144996 )
...
Manual roll requested by zra@google.com
6745955bb4...6cefbe1835#51299 )" (flutter/engine#51330 )
2024-03-11 skia-flutter-autoroll@skia.org Roll Skia from ff1eb5af6ce4 to 6f10903e2d28 (3 revisions) (flutter/engine#51326 )
2024-03-11 matanlurey@users.noreply.github.com Conditionally run `golden_tests_harvester` for `run_impeller_golden_tests`. (flutter/engine#51325 )
2024-03-11 skia-flutter-autoroll@skia.org Roll Dart SDK from c3bd630e89bb to 09a1a1ede1c4 (1 revision) (flutter/engine#51324 )
2024-03-11 jacksongardner@google.com Move emscripten out of the buildroot into the flutter repo. (flutter/engine#51299 )
2024-03-11 skia-flutter-autoroll@skia.org Roll Skia from f8d5ecc7841d to ff1eb5af6ce4 (2 revisions) (flutter/engine#51322 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-12 16:13:24 +00:00
engine-flutter-autoroll
cb29b40693
Roll Packages from d489d84c359b to d1aeb26e1b43 (3 revisions) ( #144994 )
...
d489d84c35...d1aeb26e1bengine-flutter-autoroll@skia.org Manual roll Flutter from 3bb2e5948e7a to 1ca88730a0c1 (11 revisions) (flutter/packages#6304 )
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter from 7c89ec8bbc6d to 3bb2e5948e7a (31 revisions) (flutter/packages#6300 )
2024-03-11 engine-flutter-autoroll@skia.org Manual roll Flutter from 7c89ec8bbc6d to 3bb2e5948e7a (31 revisions) (flutter/packages#6299 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-12 15:53:06 +00:00
Nate
61812ca3eb
Add platform check to FocusManager app lifecycle listener ( #144718 )
...
This PR implements a temporary fix for the mobile device keyboard bug reported in [this comment](https://github.com/flutter/flutter/pull/142930#issuecomment-1981750069 ).
CC @gspencergoog
2024-03-12 15:43:06 +00:00
godofredoc
1ca88730a0
Update integration tests regexes. ( #144847 )
...
Some tests are assuming the flutter sdk code is being checked out to flutter and checking the code to a different repository makes them fail.
Bug: https://github.com/flutter/flutter/issues/144487
2024-03-12 01:31:25 +00:00
auto-submit[bot]
49f45d2095
Reverts "Fail tests on exceptions raised after test completed ( #144706 )" ( #144970 )
...
Reverts: flutter/flutter#144706
Initiated by: gspencergoog
Reason for reverting: This has broken the tree because some tests are still failing post completion. This particular one looks like it might have to do with a gold image not existing.
Original PR Author: goderbauer
Reviewed By: {Piinks}
This change reverts the following previous change:
A test was failing silently because of this (see https://github.com/flutter/flutter/issues/144353 and fixed in https://github.com/flutter/flutter/pull/144709 ). The failure went undetected for months. Ideally, this should have been a regular non-silent failure. This change makes that so. `package:test` can properly handle reported exceptions outside of test cases. With this change, the test fails as follows:
```
00:03 +82: Smoke test material/color_scheme/dynamic_content_color.0.dart
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test (but after the test had completed):
setState() called after dispose(): _DynamicColorExampleState#1cd37(lifecycle state: defunct, not
mounted)
This error happens if you call setState() on a State object for a widget that no longer appears in
the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error
can occur when code calls setState() from a timer or an animation callback.
The preferred solution is to cancel the timer or stop listening to the animation in the dispose()
callback. Another solution is to check the "mounted" property of this object before calling
setState() to ensure the object is still in the tree.
This error might indicate a memory leak if setState() is being called because another object is
retaining a reference to this State object after it has been removed from the tree. To avoid memory
leaks, consider breaking the reference to this object during dispose().
When the exception was thrown, this was the stack:
#0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9)
#1 State.setState (package:flutter/src/widgets/framework.dart:1202:6)
#2 _DynamicColorExampleState._updateImage (package:flutter_api_samples/material/color_scheme/dynamic_content_color.0.dart:191:5)
<asynchronous suspension>
════════════════════════════════════════════════════════════════════════════════════════════════════
00:03 +81 -1: Smoke test material/context_menu/context_menu_controller.0.dart
00:03 +81 -1: Smoke test material/color_scheme/dynamic_content_color.0.dart [E]
Test failed. See exception logs above.
The test description was: Smoke test material/color_scheme/dynamic_content_color.0.dart
This test failed after it had already completed.
Make sure to use a matching library which informs the test runner
of pending async work.
```
2024-03-11 23:31:18 +00:00
Polina Cherkasova
e66811ae04
Make TabController communicating creation in constructor. ( #144912 )
...
Contributes to https://github.com/flutter/flutter/issues/144910
2024-03-11 23:13:47 +00:00
Michael Goderbauer
91cccc8e6b
Fail tests on exceptions raised after test completed ( #144706 )
...
A test was failing silently because of this (see
https://github.com/flutter/flutter/issues/144353 and fixed in
https://github.com/flutter/flutter/pull/144709 ). The failure went
undetected for months. Ideally, this should have been a regular
non-silent failure. This change makes that so. `package:test` can
properly handle reported exceptions outside of test cases. With this
change, the test fails as follows:
```
00:03 +82: Smoke test material/color_scheme/dynamic_content_color.0.dart
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test (but after the test had completed):
setState() called after dispose(): _DynamicColorExampleState#1cd37(lifecycle state: defunct, not
mounted)
This error happens if you call setState() on a State object for a widget that no longer appears in
the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error
can occur when code calls setState() from a timer or an animation callback.
The preferred solution is to cancel the timer or stop listening to the animation in the dispose()
callback. Another solution is to check the "mounted" property of this object before calling
setState() to ensure the object is still in the tree.
This error might indicate a memory leak if setState() is being called because another object is
retaining a reference to this State object after it has been removed from the tree. To avoid memory
leaks, consider breaking the reference to this object during dispose().
When the exception was thrown, this was the stack:
#0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9)
#1 State.setState (package:flutter/src/widgets/framework.dart:1202:6)
#2 _DynamicColorExampleState._updateImage (package:flutter_api_samples/material/color_scheme/dynamic_content_color.0.dart:191:5)
<asynchronous suspension>
════════════════════════════════════════════════════════════════════════════════════════════════════
00:03 +81 -1: Smoke test material/context_menu/context_menu_controller.0.dart
00:03 +81 -1: Smoke test material/color_scheme/dynamic_content_color.0.dart [E]
Test failed. See exception logs above.
The test description was: Smoke test material/color_scheme/dynamic_content_color.0.dart
This test failed after it had already completed.
Make sure to use a matching library which informs the test runner
of pending async work.
```
2024-03-11 16:05:24 -07:00
Nate
26e379e0fc
Refactoring if chains into switch statements ( #144905 )
...
Based on issue #144903 , this PR aims to bring the codebase more in line with the [Flutter repo style guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-if-chains-or--or--with-enum-values ):
> #### Avoid using `if` chains or `?:` or `==` with enum values
<br>
This change unfortunately increases the total line length, but it also improves readability.
2024-03-11 23:04:57 +00:00
auto-submit[bot]
187ec75eb5
Reverts "Expose build mode in environment of asset transformer processes ( #144752 )" ( #144957 )
...
Reverts: flutter/flutter#144752
Initiated by: andrewkolos
Reason for reverting: compilation issue has turned the tree red
Original PR Author: andrewkolos
Reviewed By: {christopherfujino}
This change reverts the following previous change:
In service of https://github.com/flutter/flutter/issues/143348
When invoking a package to transform an asset, we set `FLUTTER_BUILD_MODE` to the CLI name of the build mode being used. Inspired by https://github.com/flutter/flutter/issues/101077#issuecomment-1890379501 :
> Do transformers know whether they get executed in debug or release mode? I kinda imagine that being useful. Ex: There's a transformer that optimizes the file size of images. Depending on the amount and size of the images, that could take a significant amount of time. Therefore, I might want to only execute it in release builds.
Note for the reviewer: the interesting part of this change can be found in the commit [set environment variable to build mode when running asset transformer…](579912d470
2024-03-11 21:00:17 +00:00
Andrew Kolos
83fad74535
Expose build mode in environment of asset transformer processes ( #144752 )
...
In service of https://github.com/flutter/flutter/issues/143348
When invoking a package to transform an asset, we set `FLUTTER_BUILD_MODE` to the CLI name of the build mode being used. Inspired by https://github.com/flutter/flutter/issues/101077#issuecomment-1890379501 :
> Do transformers know whether they get executed in debug or release mode? I kinda imagine that being useful. Ex: There's a transformer that optimizes the file size of images. Depending on the amount and size of the images, that could take a significant amount of time. Therefore, I might want to only execute it in release builds.
Note for the reviewer: the interesting part of this change can be found in the commit [set environment variable to build mode when running asset transformerâ¦](579912d470
2024-03-11 20:39:31 +00:00
engine-flutter-autoroll
d98d842d1f
Roll Flutter Engine from 9196947bc687 to 6745955bb49e (2 revisions) ( #144946 )
...
9196947bc6...6745955bb4zanderso@users.noreply.github.com Remove flaky check from observatory/tracing_test.dart (flutter/engine#51320 )
2024-03-11 skia-flutter-autoroll@skia.org Roll Skia from cb30f40eea75 to f8d5ecc7841d (4 revisions) (flutter/engine#51321 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-11 18:35:24 +00:00
victorgalo
b9afa60fdd
Skip test temporarily until headingLevel is added in engine (issue 41… ( #135077 )
...
The purpose of this PR is to temporarily skip one integration test that is blocking the changes indicated below:
(This change adds a new property in Semantics widget that would take an integer corresponding to the heading levels defined by the ARIA heading role. This is necessary in order to get proper accessibility and usability in a website for users who rely on screen readers and other assistive technologies.)
Issue fixed by this PR:
https://github.com/flutter/flutter/issues/97894
Engine part:
https://github.com/flutter/engine/pull/41435
Framework part:
https://github.com/flutter/flutter/pull/125771
2024-03-11 16:31:21 +00:00
engine-flutter-autoroll
505a5153b0
Roll Flutter Engine from 3b0b59bb224d to 9196947bc687 (1 revision) ( #144934 )
...
3b0b59bb22...9196947bc6skia-flutter-autoroll@skia.org Roll Skia from e6b884229d2d to cb30f40eea75 (1 revision) (flutter/engine#51318 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-11 16:24:06 +00:00
engine-flutter-autoroll
b8d01ce630
Roll Packages from 0badb4356021 to d489d84c359b (3 revisions) ( #144931 )
...
0badb43560...d489d84c35reidbaker@google.com [in_app_purchase_android] Add UserChoiceBilling mode. (flutter/packages#6162 )
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter from 471a82856d86 to 7c89ec8bbc6d (15 revisions) (flutter/packages#6288 )
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 7482962148e8 to ba3931984302 (2 revisions) (flutter/packages#6287 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-11 16:03:28 +00:00
engine-flutter-autoroll
3bb2e5948e
Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) ( #144923 )
...
210f84eb81...3b0b59bb2243091780+utzcoz@users.noreply.github.com Bump Robolectric to 4.11.1 (flutter/engine#51310 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-11 09:52:35 +00:00
engine-flutter-autoroll
8e12e133aa
Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) ( #144920 )
...
d13999c0ca...210f84eb81jiahaog@users.noreply.github.com Disambiguate conditional expressions (flutter/engine#51285 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-11 08:57:34 +00:00
engine-flutter-autoroll
087b15ae0d
Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) ( #144907 )
...
7c2a56a44b...d13999c0caskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gJ4Wr2FSpnGmoN3ke... to L6_XzizcJqjneCvGA... (flutter/engine#51317 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gJ4Wr2FSpnGm to L6_XzizcJqjn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-11 02:33:27 +00:00
Ian Hickson
dbcce277f3
Rename isAvailableForEnvironment to isForEnvironment ( #143176 ) ( #144858 )
...
This is part 4 of a broken down version of the #140101 refactor.
This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)
----
This is a reland of https://github.com/flutter/flutter/pull/143176 which was speculatively reverted in https://github.com/flutter/flutter/pull/144855 but turned out not to be the cause of the tree redness.
2024-03-10 06:20:38 +00:00
engine-flutter-autoroll
640d212b22
Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) ( #144894 )
...
f776643301...7c2a56a44bskia-flutter-autoroll@skia.org Roll Skia from 8b92038ff67f to e6b884229d2d (1 revision) (flutter/engine#51316 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-10 04:44:32 +00:00
engine-flutter-autoroll
6eb3ce9ec6
Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) ( #144891 )
...
51fefde43c...f776643301skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lAV5jgp4796siOZgI... to gJ4Wr2FSpnGmoN3ke... (flutter/engine#51315 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lAV5jgp4796s to gJ4Wr2FSpnGm
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-10 01:10:42 +00:00
engine-flutter-autoroll
98d242a50d
Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) ( #144889 )
...
49f01510e4...51fefde43cskia-flutter-autoroll@skia.org Roll Skia from 983774f73a16 to 8b92038ff67f (1 revision) (flutter/engine#51313 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 23:57:23 +00:00
engine-flutter-autoroll
cef0a9e9db
Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) ( #144887 )
...
958d7cd560...49f01510e4zanderso@users.noreply.github.com Roll buildroot to e9df434539745202fa5f9b729fe5f82e5de3f025 (flutter/engine#51306 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 22:34:23 +00:00
engine-flutter-autoroll
7cf293366c
Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) ( #144884 )
...
fc06f5a993...958d7cd560zanderso@users.noreply.github.com Explicitly list Android embedding dependency jars in GN (flutter/engine#51303 )
2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 0da56a6c7446 to 983774f73a16 (1 revision) (flutter/engine#51311 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 21:48:23 +00:00
engine-flutter-autoroll
b7b1857ca4
Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) ( #144876 )
...
6f7fdc5334...fc06f5a993skia-flutter-autoroll@skia.org Roll Dart SDK from 02e78997f308 to c3bd630e89bb (1 revision) (flutter/engine#51309 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 12:56:25 +00:00
engine-flutter-autoroll
ae97ccd453
Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) ( #144875 )
...
196132ffe2...6f7fdc5334skia-flutter-autoroll@skia.org Roll Skia from 8feb4b6a4aa6 to 0da56a6c7446 (1 revision) (flutter/engine#51308 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 11:47:32 +00:00
yim
f733e3a441
Fix multiple calls to Slider's onChanged. ( #143680 )
...
Fixes #143524
2024-03-09 07:50:23 +00:00
engine-flutter-autoroll
ff9b1a5c22
Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) ( #144870 )
...
d4e3d964dc...196132ffe2skia-flutter-autoroll@skia.org Roll Dart SDK from b52b754d5d3e to 02e78997f308 (1 revision) (flutter/engine#51307 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 07:46:41 +00:00
engine-flutter-autoroll
b267dc372b
Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) ( #144866 )
...
e79a72d362...d4e3d964dcskia-flutter-autoroll@skia.org Roll Skia from 3b0b79511469 to 8feb4b6a4aa6 (18 revisions) (flutter/engine#51305 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 06:00:31 +00:00
engine-flutter-autoroll
0a61e0e95b
Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) ( #144865 )
...
c3b70321be...e79a72d362skia-flutter-autoroll@skia.org Manual roll Dart SDK from 4c64fcc134bf to b52b754d5d3e (6 revisions) (flutter/engine#51304 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 04:39:30 +00:00
engine-flutter-autoroll
ebb180e4d8
Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) ( #144864 )
...
7953662766...c3b70321beskia-flutter-autoroll@skia.org Roll Skia from a4fb847f47d9 to 3b0b79511469 (1 revision) (flutter/engine#51289 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 03:57:17 +00:00
engine-flutter-autoroll
e070cbc288
Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) ( #144863 )
...
7541e902f1...7953662766chinmaygarde@google.com [Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. (flutter/engine#51298 )
2024-03-09 chinmaygarde@google.com [Impeller] Make DeviceHolder follow convention for backend specific utilities. (flutter/engine#51300 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 02:57:00 +00:00
engine-flutter-autoroll
6fab1fe66a
Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) ( #144862 )
...
953927eae7...7541e902f130870216+gaaclarke@users.noreply.github.com [Impeller] implement mask blur for textures (flutter/engine#51183 )
2024-03-08 zanderso@users.noreply.github.com Don't rely on dart binary on PATH in run_test.py (flutter/engine#51302 )
2024-03-08 tugorez@users.noreply.github.com Mark the Flutter Views as focusable by setting a tabindex value. (flutter/engine#50876 )
2024-03-08 chinmaygarde@google.com Update the instructions for updating licenses. (flutter/engine#51297 )
2024-03-08 1961493+harryterkelsen@users.noreply.github.com Optimize overlays in CanvasKit (flutter/engine#47317 )
2024-03-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5Ra_AjCji-uR1GaX7... to lAV5jgp4796siOZgI... (flutter/engine#51296 )
2024-03-08 chinmaygarde@google.com [Impeller] Add the KHR prefix to existing swapchain utilities. (flutter/engine#51295 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5Ra_AjCji-uR to lAV5jgp4796s
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 01:54:40 +00:00
Polina Cherkasova
a04fe3169a
Upgrade vm_service. ( #144845 )
2024-03-08 17:09:07 -08:00
Percival
cab4a0fb88
Replace dead links ( #144827 )
...
I have found that some Apple-related links are no longer accessible, and they have been replaced
2024-03-09 01:08:06 +00:00
engine-flutter-autoroll
c00064886c
Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) ( #144849 )
...
e099277ce0...953927eae7zanderso@users.noreply.github.com Revert test if changes to golden tests (flutter/engine#51291 )
2024-03-08 jmccandless@google.com iPad keyboard cut/copy/paste buttons (flutter/engine#50923 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 01:04:34 +00:00
Zachary Anderson
7bf84d0c6c
Mark Mac_arm64_ios module_test_ios bringup: true ( #144861 )
...
For https://github.com/flutter/flutter/issues/144860
2024-03-08 17:01:40 -08:00
auto-submit[bot]
0432a6941d
Reverts "Rename isAvailableForEnvironment to isForEnvironment ( #143176 )" ( #144855 )
...
Reverts: flutter/flutter#143176
Initiated by: QuncCccccc
Reason for reverting: made tree red.
Original PR Author: Hixie
Reviewed By: {Piinks}
This change reverts the following previous change:
This is part 4 of a broken down version of the #140101 refactor.
This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)
2024-03-08 23:19:15 +00:00
engine-flutter-autoroll
0a40291f7a
Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) ( #144844 )
...
05fdf947f8...e099277ce0dnfield@google.com Use `io.flutter.Build.API_LEVELS` rather than `android.os.Build.VERSION_CODES` (flutter/engine#51171 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-08 21:16:27 +00:00
Ian Hickson
5bd34ef541
Rename isAvailableForEnvironment to isForEnvironment ( #143176 )
...
This is part 4 of a broken down version of the #140101 refactor.
This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)
2024-03-08 20:20:13 +00:00
engine-flutter-autoroll
fde345a6cf
Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) ( #144839 )
...
bc4abcda63...05fdf947f8jonahwilliams@google.com [Impeller] More efficient usage of transient onscreen attachments. (flutter/engine#51206 )
2024-03-08 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Providing FUCHSIA_SDK_PATH env var for fuchsia lsc (flutter/engine#51234 )
2024-03-08 chris@bracken.jp Migrate vulkan_memory_allocator to flutter/third_party (flutter/engine#51275 )
2024-03-08 jason-simmons@users.noreply.github.com Update CI scripts to use either src/flutter/third_party/dart or src/third_party/dart (flutter/engine#51276 )
2024-03-08 kustermann@google.com Add fuchsia_gn_sdk GN variable pointing to //flutter/tools/fuchsia/gn-sdk (flutter/engine#51287 )
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 993a88a663c8 to a4fb847f47d9 (1 revision) (flutter/engine#51283 )
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 15f8d03a9594 to 993a88a663c8 (1 revision) (flutter/engine#51282 )
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 093994f8f078 to 15f8d03a9594 (1 revision) (flutter/engine#51280 )
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from bf3f9c5f0edb to 093994f8f078 (1 revision) (flutter/engine#51278 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-08 19:59:11 +00:00
Mitchell Goodwin
2be5084b26
Fixes the transition builder changing the Cupertino transition on Android. ( #134790 )
...
Fixes #124850 .
Changes the fallback for the builder on Android. Before the error was from the platform being changed mid Cupertino transition to iOS. If a default builder wasn't set for iOS (which a developer developing only for Android might not), then it defaulted to the Zoom transition. Which changing the transition while on the fly caused issues.
2024-03-08 19:00:16 +00:00
Jackson Gardner
074114b85a
Copy over source maps from dart2js target when they are enabled. ( #144832 )
...
This fixes https://github.com/flutter/flutter/issues/143703
We need to make sure that when source maps are enabled for the dart2js target, it advertises the sourcemap file as one of its outputs so that the web release bundle can copy it over.
2024-03-08 18:56:18 +00:00
Flutter GitHub Bot
ea1ef751e0
Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky ( #144677 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android new_gallery_opengles_impeller__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20new_gallery_opengles_impeller__transition_perf%22 ).
This test can be marked as unflaky.
2024-03-08 18:07:21 +00:00
engine-flutter-autoroll
fd4ab4f66e
Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) ( #144817 )
...
bbb1ed00af...bc4abcda63bdero@google.com [Impeller] Add mask blur style support to the RRect blur fast path. (flutter/engine#51250 )
2024-03-08 30870216+gaaclarke@users.noreply.github.com [Impeller] moved tests to aiks_blur_unittests, added warning (flutter/engine#51274 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-08 17:49:22 +00:00
engine-flutter-autoroll
1e1958fc5e
Roll Packages from 6701c9e61804 to 0badb4356021 (2 revisions) ( #144831 )
...
6701c9e618...0badb43560katelovett@google.com [two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells (flutter/packages#6283 )
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter from 8f84f3f32ddc to 471a82856d86 (27 revisions) (flutter/packages#6281 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-08 15:41:22 +00:00
Martin Kustermann
7c89ec8bbc
Remove toString() overrides in dart:ui/package:flutter in profile/release mode on wasm/vm targets ( #144763 )
...
The flutter engine & framework can opt out of this optimization for
individual classes / class hierarchies via:
* `@pragma(flutter:keep-to-string)`
* `@pragma(flutter:keep-to-string-in-subtypes)`
Or by using the convenience constant `@keepToString` from `dart:ui`.
=> This aligns the build process more with g3 (which already does this)
Closes https://github.com/flutter/flutter/issues/52759
2024-03-08 09:55:02 +01:00
engine-flutter-autoroll
7018685222
Roll Flutter Engine from 80cd7981043f to bbb1ed00af49 (3 revisions) ( #144813 )
...
80cd798104...bbb1ed00afchris@bracken.jp Move ANGLE to flutter/third_party (flutter/engine#51270 )
2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from 4a65dfcc70a5 to bf3f9c5f0edb (4 revisions) (flutter/engine#51268 )
2024-03-07 jason-simmons@users.noreply.github.com [Impeller] Fix a buffer overrun in ImpellerC reflector resource offsets (flutter/engine#51108 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-08 01:48:36 +00:00
Loïc de Porcaro
dde616dbe1
Update documentation of AlertDialog's default TextStyle for Material 3 ( #144697 )
...
## Update `AlertDialog` Documentation for Material 3 Defaults
This pull request updates the documentation for `AlertDialog` to accurately reflect the default text styles (`titleTextStyle` and `contentTextStyle`) when using Material 3.
Previously, the documentation suggested default styles (`TextTheme.titleLarge` for titles and `TextTheme.titleMedium` for content) that do not align with Material 3 implementation, which uses `TextTheme.headlineSmall` and `TextTheme.bodyMedium` respectively.
Fixes #144489
2024-03-08 00:21:35 +00:00
engine-flutter-autoroll
d632f34f9d
Roll Flutter Engine from 175069397a40 to 80cd7981043f (5 revisions) ( #144804 )
...
175069397a...80cd798104chris@bracken.jp Roll buildroot to ef514ca5144ba0a4ce5e7075c325d24cd6da73a4 (flutter/engine#51265 )
2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 4bc97350dc47 to 4c64fcc134bf (1 revision) (flutter/engine#51266 )
2024-03-07 bdero@google.com [Impeller] Record restore clips in the replay mechanism when StC is enabled. (flutter/engine#51259 )
2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from 6bfd57b8790f to 4a65dfcc70a5 (2 revisions) (flutter/engine#51263 )
2024-03-07 zanderso@users.noreply.github.com [gn] Disable running some python scripts from GN (flutter/engine#51248 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-08 00:13:23 +00:00
Andrew Kolos
06ac042271
Enable asset transformation for flutter run -d <browser> and flutter test ( #144734 )
...
Partial implementation of https://github.com/flutter/flutter/issues/143348 .
The title says it all. Feel free to experiment with the feature using this project: https://github.com/andrewkolos/asset_transformers_test .
2024-03-07 23:38:40 +00:00
