10729 Commits

Author SHA1 Message Date
Chris Bracken
23adf0085b
Eliminate hardcoding of no-sim-use-hardfp (#17147)
This is now derived automatically from the target platform by
gen_snapshot.
2018-05-01 09:55:23 -07:00
Adrian Secord
1680e55c02 Updated links to Material design guidelines to use short links. (#17077) 2018-04-30 20:29:46 -07:00
Chris Bracken
68a1e2f7aa
Simplify iOS debug build (#17145)
iOS debug builds always run in interpreted mode whether on device or on
simulator. In both cases, we can skip snapshotting and link against an
empty App.framework. Previously, we did this for iOS simulator builds.
This does the same for device builds.

Previously, debug iOS builds used gen_snapshot to generate a core
snapshot, then used 'xxd' to generate C files containing the snapshot
data in buffers named kDartVmSnapshotData and kDartIsolateSnapshotData,
which are then compiled/linked into App.framework. This is unnecessary
since the VM compiled into Flutter.framework already contains this data.
2018-04-30 19:51:30 -07:00
Chris Bracken
c3d43ef4a7
Improve AOT snapshot input verification + cleanup (#17144)
Bugfix: Moves AOT snapshot input verification past where the last input
is added to the inputs list.

Cleanup:
* Extracts _isValidAotPlatform method.
* Moves non-platform-specific logic to the top.
* Moves variable declaration closer to first use, and inlines to a
  narrower scope where possible.

This relands #17136, which was reverted in #17142 due to breakage in
on-device iOS debug builds.
2018-04-30 19:15:09 -07:00
Chris Bracken
d19bdc4339
Revert "Improve AOT snapshot input verification + cleanup (#17136)" (#17142)
This reverts commit 100be23a341a4206a76e19087bd899a1b1fe2b5e.
2018-04-30 17:34:36 -07:00
xster
709b0cb285
Accessibility fixes for new gallery (#16973) 2018-04-30 17:19:00 -07:00
Chris Bracken
100be23a34
Improve AOT snapshot input verification + cleanup (#17136)
Bugfix: Moves AOT snapshot input verification past where the last input
is added to the inputs list.

Cleanup:
* Extracts _isValidAotPlatform method.
* Moves non-platform-specific logic to the top.
* Moves variable declaration closer to first use, and inlines to a
  narrower scope where possible.
2018-04-30 16:47:03 -07:00
Todd Volkert
b2c67e88d4
Make Layer.toImage() accept bounds rather than size (#17129)
It allows callers to account for things like shadows that paint
outside the bounds of the widget.

https://github.com/flutter/flutter/issues/16859
2018-04-30 15:26:17 -07:00
Todd Volkert
5972fdb7aa
Fix RenderView.paintBounds (#17126)
It should account for the device pixel ratio

https://github.com/flutter/flutter/issues/16859
2018-04-30 13:48:42 -07:00
Chris Bracken
98ec321ad6
Merge two large switch blocks in AOT snapshotting (#17123)
No functional changes. Merges two platform switch statements and
eliminates an iOS-specific local.
2018-04-30 13:37:45 -07:00
Hans Muller
286cdf43f0
Add support for the Malay (ms) locale (#17121) 2018-04-30 11:12:25 -07:00
Todd Volkert
e19db89a0e
Add basic support for golden image file testing (#17094)
* Add a `matchesGoldenFile()` async matcher that will match
  a finder's widget's rasterized image against a golden file.
* Add support for pluggable image comparison backends
* Add a default backend that does simplistic PNG byte
  comparison on locally stored golden files.
* Add support for `flutter test --update-goldens`, which will
  treat the rasterized image bytes produced during the test
  as the new golden bytes and update the golden file accordingly

Still TODO:

* Add support for the `flutter_test_config.dart` test config hook
* Utilize `flutter_test_config.dart` in `packages/flutter/test`
  to install a backend that retrieves golden files from a dedicated
  `flutter/goldens` repo

https://github.com/flutter/flutter/issues/16859
2018-04-30 10:35:56 -07:00
Todd Volkert
dedd180f9f
Fix expectLater to not wrap the delegate in a guard (#17085)
Follow-up to https://github.com/flutter/flutter/pull/17063

https://github.com/flutter/flutter/issues/16859
2018-04-30 10:05:04 -07:00
Hans Muller
5c2259d505
Cross fade gallery UI front layer (#17064) 2018-04-30 08:23:11 -07:00
Mikkel Nygaard Ravn
7a0ebad092
Revert "Flutter tools recommend using Cocoapods 1.5.0 (#16971)" (#17110)
This reverts commit 6e26cc28ba4558ac35dcac8eaea3df4fd37a41e1.
2018-04-30 11:45:58 +02:00
Mikkel Nygaard Ravn
6e26cc28ba
Flutter tools recommend using Cocoapods 1.5.0 (#16971) 2018-04-30 11:24:09 +02:00
Chris Bracken
cdbb2385f1
Extract kernel compile from buildAotSnapshot (#17062)
Moves the kernel compile step to the beginning of the AOT build in a
separate method. This is pre-factoring for iOS universal builds where
the kernel build happens once, but we then snapshot twice: once for
armv7 and once for arm64.

This also writes dependencies to build/kernel_compile.d rather than
build/aot/snapshot.d, since that is immediately overwritten by
gen_snapshot.
2018-04-29 10:47:34 -07:00
Todd Volkert
8860627b63
Add WidgetTester.runAsync() (#17029)
This will allow callers to run real async code within a widget test.

https://github.com/flutter/flutter/issues/16859
2018-04-28 15:14:46 -07:00
Todd Volkert
8b99d1d83c
Add expectLater to flutter_test (#17063)
* Wrap `expectLater()` in flutter_tester so that callers can
  wait for the matcher to complete in their tests

https://github.com/flutter/flutter/issues/16859
2018-04-28 13:54:08 -07:00
Alexander Aprelev
c813eabf50
Roll engine to 613aae032f07b01b9ac2172529e51869431fe465 (dart roll) (#17069)
* Roll to pre-dart engine.

* Roll to dart roll engine.
2018-04-27 22:55:51 -07:00
Todd Volkert
a5a33325ef
Move toImage() impl from RepaintRenderBoundary to OffsetLayer (#17060)
https://github.com/flutter/flutter/issues/16859
2018-04-27 21:19:24 -07:00
Jonah Williams
f0c4bc30c6
Add SemanticService.tooltip method for Android tooltips (#16978) 2018-04-27 20:02:11 -07:00
Hans Muller
6334da0109
Assert that required dialog context args are non-null (#16890) 2018-04-27 16:33:38 -07:00
xster
396298fb39
Give more room for the front layer drag on iPhone X for new Gallery (#16975)
* Give more room for the front layer drag on iPhone X

* Tweak the animation visual effects

* review lint
2018-04-27 16:25:42 -07:00
xster
f8fe5e3cba
Fix some glyph codes that pointed to the wrong places in CupertinoIcons (#16916) 2018-04-27 16:25:14 -07:00
Chris Bracken
fe0de001d9
Eliminate unnecessary buildAotSnapshot parameter (#17056)
This isn't user-specifiable through a flag, so no need to pass it as a
parameter.
2018-04-27 15:51:07 -07:00
Andrew Davies
32d1f0a80a
[frdb] Analyzer fix. (#17057)
Removes unused var.
2018-04-27 13:34:50 -07:00
Jonah Williams
84dbef3982
add route semantics to backdrop widget (#16981) 2018-04-27 13:24:21 -07:00
Andrew Davies
61de5014b6
[frdp] Ignore stale ports. (#16944)
When forwarding all ports, run a test connection to each Dart VM instance, stopping port forwarding if the connection fails.

Also does the same for any batched calls that hit all Dart VM instances.
2018-04-27 13:24:01 -07:00
Chris Bracken
549acac655
Improve AOT build fingerprinting (#17053)
This is a simple refactoring with no functional changes. We now reuse
the existing _isBuildRequired() and _writeFingerprint() functions and
share them with script snapshotting rather than reimplementing their
logic.

Changes the signatures of both to support multiple output files (as
required for AOT snapshotting).
2018-04-27 13:03:40 -07:00
Chris Bracken
972a9e915a
Fix AOT snapshotting depfile path (#17050)
Fixes a bug introduced in 82f969ff0593e1da270bcc18cb0a495877f617df where
the depfile used for AOT snapshotting, useful in particular for skipping
gen_snapshot when inputs/outputs haven't changed since the last build.
2018-04-27 13:03:26 -07:00
Konstantin Scheglov
31156aed43
We can launch if the flutter-tester device is enabled. (#17019) 2018-04-27 09:33:42 -07:00
Hans Muller
bf3bd7667f
New Gallery UI reprise (#17031) 2018-04-27 08:11:20 -07:00
Alexander Aprelev
4033937c89
Roll engine to e11905c6e5ac226fe388b51faacf36cdc2e96d2c. (#17026)
Changes since the last roll:

```
e11905c6e Add tooltip method to Android AccessibilityBridge (#5103)
2ee36e270 Always enable verbose logging on fuchsia. (#5104)
131349f83 Update flutter runner process name to reflect last running shell. (#5102)
ad9826cbb Roll src/third_party/skia/ c79e2d155..47ed6f10e (10 commits; 1 trivial rolls) (#5100)
7617d2889 libtxt: post-process glyph positions in order to accurately right-justify text (#5093)
895c965ce Set file modified callback. (#5096)
956f3eeca Roll src/third_party/skia/ 5c9369eb1..c79e2d155 (7 commits) (#5099)
6e5112214 Roll src/third_party/skia/ 643ab1bf5..5c9369eb1 (1 commit; 1 trivial rolls) (#5098)
a9180ca20 Roll src/third_party/skia/ 6b043cb9c..643ab1bf5 (3 commits; 3 trivial rolls) (#5097)
82d461049 Roll src/third_party/skia/ 1366282bc..6b043cb9c (2 commits) (#5095)
fb4926e65 Roll src/third_party/skia/ 580aee2fa..1366282bc (2 commits) (#5094)
c249b7026 Path metrics/getBounds/combinations again (#4957)
df255b828 Roll src/third_party/skia/ de5cffbc4..580aee2fa (16 commits) (#5092)
e44e1b49f Initial plugin support for background downloads + content fetching (#5082)
78f8a0f45 [fuchsia] Changes for running Dart 2 on flutter_runner. (#5080)
cbec56a3d Roll src/third_party/skia/ 77e95f706..de5cffbc4 (14 commits) (#5090)
8da9398ed Throw an exception if a secondary isolate tries to send a platform message (#5069)
```
2018-04-26 19:54:39 -07:00
Chris Bracken
c38ac4480c
Eliminate unnecessary AOT build wrapper function (#17027)
Inlines the buildAotSnapshot function, which simply passes through its
arguments to Snapshotter.buildAotSnapshot.
2018-04-26 19:03:33 -07:00
Chris Bracken
ebcd08c6ef
Eliminate build aot --interpreter flag (#17025) (#17033)
This is required for iOS debug builds, but unused otherwise. In theory,
Android debug builds could be run in this mode, but this is historically
untested and adds unnecessary complexity to the code. If ad-hoc testing
is required, it can be patched in when necessary.

This re-lands 8c4f0c0d215ca3219923c60fce2cd7c7528acf9b with a fix to
xcode_backend.sh to eliminate the use of --interpreter.
2018-04-26 17:25:23 -07:00
Chris Bracken
e3247a3629
Revert "Eliminate build aot --interpreter flag (#17025)" (#17032)
Requires a fix to xcode_backend.sh. Will followup momentarily with that
fix.

This reverts commit 8c4f0c0d215ca3219923c60fce2cd7c7528acf9b.
2018-04-26 16:30:16 -07:00
Chris Bracken
8c4f0c0d21
Eliminate build aot --interpreter flag (#17025)
This is required for iOS debug builds, but unused otherwise. In theory,
Android debug builds could be run in this mode, but this is historically
untested and adds unnecessary complexity to the code. If ad-hoc testing
is required, it can be patched in when necessary.
2018-04-26 16:07:10 -07:00
Ian Hickson
c482cc4bb3
Add some suggestions for using Column with a SingleChildScrollView (#16500) 2018-04-26 16:06:39 -07:00
Ian Hickson
ca35ddd439
Add some Transform constructors (#16553)
See https://github.com/flutter/flutter/pull/15383
2018-04-26 16:06:17 -07:00
Ian Hickson
7d5e5ebc94
Fix broken link (#16965)
See https://docs.flutter.io/ to see what I mean.
2018-04-26 16:06:04 -07:00
Chris Bracken
82f969ff05
Move AOT snapshotting to Snapshotter class (#17015)
This moves AOT snapshotting out of build_aot.dart and into the
Snapshotter class. It also adds unit tests for iOS debug, profile, and
release builds.
2018-04-26 14:37:39 -07:00
Hans Muller
adf97fb58f
Increased the channels test timeout (#17018)
Increased the channels test timeout
2018-04-26 14:09:23 -07:00
Hans Muller
e62a6451f7
Fixed (#17010) 2018-04-26 10:29:44 -07:00
Jason Simmons
d8f2f36935
Use a space instead of a zero-width space to calculate the preferred height of a line of text (#16972)
The zero-width space character may not be supported by the font requested in
the text style.  If that happens, then libtxt will fall back to another font
to render that character, resulting in text metrics that do not match the
intended font.

Fixes https://github.com/flutter/flutter/issues/16257
2018-04-26 09:42:26 -07:00
Chris Bracken
9765f0af00
Extract Xxd class for iOS AOT snapshotting (#17006)
This fixes and re-lands 4bb7496b6243b13e14712b3b5702928c831a329f, which
was reverted in ceade39c83cf0832b53c4e0fbf17eee6081201ca due to test
failures caused by a bad rebase.
2018-04-26 08:32:51 -07:00
Todd Volkert
ae62a85699
Mark flaky tests as flaky (#17004) 2018-04-26 07:55:57 -07:00
Todd Volkert
ceade39c83
Revert "Extract Xxd class for iOS AOT snapshotting (#16986)" (#17003)
This reverts commit 4bb7496b6243b13e14712b3b5702928c831a329f.
2018-04-26 07:11:06 -07:00
Chris Bracken
4bb7496b62
Extract Xxd class for iOS AOT snapshotting (#16986)
Allows for better mockability when tests are added.
2018-04-25 22:16:59 -07:00
Todd Volkert
dcf05afca1
Add some trace statements to flutter_tools (#16990) 2018-04-25 21:33:25 -07:00