5235 Commits

Author SHA1 Message Date
Hans Muller
25164e1089 Make IconButton gesture targets as big as possible (#3423)
* Make IconButtons as big as possible
2016-04-20 10:00:14 -07:00
Ian Hickson
1b9476c4d9 Hide routes from the API when they're not needed. (#3431)
The 'routes' table is a point of confusion with new developers. By
providing a 'home' argument that sets the '/' route, we can delay the
point at which we teach developers about 'routes' until the point where
they want to have a second route.
2016-04-20 09:33:28 -07:00
Viktor Lidholt
f7360126b8 Gallery code snippets now analyzed (#3391)
* Gallery code snippets now analyzed
2016-04-20 09:29:01 -07:00
Ian Hickson
c294014d00 Remove deprecated API in EdgeInsets 2016-04-20 00:05:43 -07:00
Ian Hickson
e69812441f Rename RowInkWell to TableRowInkWell
...so that people don't think it's for Row.
2016-04-19 23:35:23 -07:00
Devon Carew
80fabfd3dd allow flutter create to re-gen over an existing project (#3419)
* allow flutter create to re-gen over an existing project

* add a regression test
2016-04-19 19:30:49 -07:00
Devon Carew
ff9bdb2c58 redraw the app after a repaint rainbow change (#3420) 2016-04-19 19:22:08 -07:00
Yegor
d8fe7a853e [tools] analyze the output of flutter create --with-driver-test (#3426)
Fixes https://github.com/flutter/flutter/issues/3149
2016-04-19 17:02:43 -07:00
Hans Muller
c7e2e8ae81 Remove Scaffold scrollableKey use in gallery demos (#3406)
* Remove Scaffold scrollable_key demo usage
2016-04-19 16:31:11 -07:00
Ian Hickson
6e0c76f4ba Give DefaultAssetBundle a default asset bundle. (#3422)
This makes it easier to use e.g. AssetImage in simple test applications.

Also, dartdoc improvements.

Also, use @required in one place, to see if it causes any trouble. If it
doesn't, I'll start using it in more places.
2016-04-19 16:14:30 -07:00
Devon Carew
dd2bde1918 add a service extension for repaint rainbow (#3409)
* add a service extension for repaint rainbow

* review comments
2016-04-19 12:57:10 -07:00
Ian Hickson
6dc440bdfd Make rootBundle handle the no-mojo case. (#3408)
The defaulting logic for bundles really belongs in the services layer,
not the widgets layer. This way we can tell non-widget code just to use
rootBundle if it just wants to read a JSON file or some such.
2016-04-19 11:19:38 -07:00
Devon Carew
6f0bb20658 rename deploy to release (#3407) 2016-04-19 11:17:00 -07:00
Ian Hickson
261923e5c6 Refactor service extensions (#3397)
Bindings now have a debugRegisterServiceExtensions() method that is
invoked in debug mode (only). (Once we have a profile mode, there'll be
a registerProfileServiceExtensions() method that gets called in that
mode only to register extensions that apply then.)

The BindingBase class provides convenience methods for registering
service extensions that do the equivalent of:

```dart
void extension() { ... }
bool extension([bool enabled]) { ... }
double extension([double extension])  { ... }
Map<String, String> extension([Map<String, String> parameters]) { ... }
```

The BindingBase class also itself registers ext.flutter.reassemble,
which it has call a function on the binding called
reassembleApplication().

The Scheduler binding now exposes the preexisting
ext.flutter.timeDilation.

The Renderer binding now exposes the preexisting ext.flutter.debugPaint.

The Renderer binding hooks reassembleApplication to trigger the
rendering tree to be reprocessed (in particular, to fix up the
optimisation closures).

All the logic from rendering/debug.dart about service extensions is
replaced by the above.

I moved basic_types to foundation.

The FlutterWidgets binding hooks reassembleApplication to trigger the
widget tree to be entirely rebuilt.

Flutter Driver now uses ext.flutter.driver instead of
ext.flutter_driver, and is hooked using the same binding mechanism.
Eventually we'll probably move the logic into the Flutter library so
that you just get it without having to invoke a special method first.
2016-04-19 10:53:58 -07:00
Jason Simmons
8451b669c8 Collect trace data through the observatory HTTP interface (#3393) 2016-04-19 10:38:49 -07:00
Ian Hickson
61605a9d9d Rearrange scheduling library (#3388)
To be more consistent with other parts of the platform:

* put the binding in a binding.dart file.

* rearrange some members of the Scheduler class to be more close to
  execution order.

* factor out Priority class into its own file.

* add more dart docs.
2016-04-19 10:35:18 -07:00
Yegor
e7657b9462 [driver] "waitFor" command in place of broken "exists" (#3373)
* [driver] "waitFor" command in place of broken "exits"

* [driver] wait using frame callback
2016-04-19 09:49:22 -07:00
Hans Muller
a2ce9483c1 Replace Block with ScrollableList in Cards demo (#3380) 2016-04-19 09:45:53 -07:00
Devon Carew
1c0a966384 rename the --develop option to --debug (#3384)
* rename the --develop option to --debug

* fail if both --debug and --deploy are specified
2016-04-18 16:41:15 -07:00
Ian Hickson
a9eddd4860 Also analyze the driver host entry points. (#3395) 2016-04-18 16:33:03 -07:00
Ian Hickson
424a6b1d6a Handle files disappearing during analysis (#3390) 2016-04-18 15:19:32 -07:00
Devon Carew
29fdc7a464 rename the --release and --debug flags (#3382) 2016-04-18 13:04:59 -07:00
Devon Carew
8b9c94203a Update README.md (#3381)
add explicit paths to the flutter recipies
2016-04-18 12:31:18 -07:00
Devon Carew
325354f6be add a temporary .analysis_options for flutter_tools (#3376) 2016-04-18 09:50:19 -07:00
Phil Quitslund
246a2cb055 Merge pull request #3375 from pq/sdk_opt
Analyze CLI option to specify a custom Dart SDK.
2016-04-18 09:44:05 -07:00
pq
26519aab23 Fixed spacing. 2016-04-18 09:25:17 -07:00
pq
4ff0e842e2 Analyze CLI option to specify a custom Dart SDK.
Handy for testing against specific local SDK builds.

(Note that the option is hidden.)
2016-04-18 09:03:31 -07:00
Devon Carew
12cac94cda Use arm deploy (#3374)
* download android-arm-deploy

* wire up --deploy to android-arm-deploy

* fix interpolation
2016-04-18 09:01:43 -07:00
Devon Carew
f132acaf1d use the new cache code to locate more artifacts (#3361)
* use the new cache code to locate more artifacts

* add todo

* review comments
2016-04-15 21:08:03 -07:00
Devon Carew
4678c12098 find all repo packages (#3368)
* find all repo packages

* .dartignore
2016-04-15 20:25:57 -07:00
Hans Muller
c4ae13ed22 Refresh indicator (#3354) 2016-04-15 18:39:18 -07:00
Yegor
9ce995f65e [driver] refactor API to finder objects (#3365) 2016-04-15 16:57:35 -07:00
Ian Hickson
a91bc0ba9c Material Data Tables (#3337)
+ Add new demo to gallery to show data tables. (This currently doesn't
use a Card; I'll create a Card version in a subsequent patch.)

+ Fix checkbox alignment. It now centers in its box regardless.

+ Add Colors.black54.

+ Some minor fixes to dartdocs.

+ DataTable, DataColumn, DataRow, DataCell

+ RowInkWell

+ Augment dartdocs of materia/debug.dart.

+ DropDownButtonHideUnderline to hide the underline in a drop-down when
  used in a DataTable.

+ Add new capabilities to InkResponse to support RowInkWell.

+ Augment dartdocs of materia/material.dart.

+ Add an assert to catch nested Blocks.

+ Fix a crash in RenderBox when you remove an object and an ancestor
  used its baseline. (https://github.com/flutter/flutter/issues/2874)

+ Fix (and redocument) RenderBaseline/Baseline.

+ Add flex support to IntrinsicColumnWidth.

+ Document more stuff on the RenderTable side.

+ Fix a bug with parentData handling on RenderTable children.

+ Completely rewrite the column width computations. The old logic made
  no sense at all.

+ Add dartdocs to widgets/debug.dart.

+ Add a toString for TableRow.
2016-04-15 16:51:03 -07:00
Yegor
db2f66aab1 [test] make CommonFinders constructor private to disallow extensions (#3371) 2016-04-15 16:49:51 -07:00
krisgiesing
27715e1d41 Add an example demonstrating use of isolates (#3347) 2016-04-15 16:31:23 -07:00
Hans Muller
f7cf0d97ca Fix the progress indicator demo (#3367) 2016-04-15 16:21:38 -07:00
Ian Hickson
efbcb0aa0c Fix docs for Divider. (#3364)
Fixes https://github.com/flutter/flutter/issues/3363
2016-04-15 15:40:04 -07:00
Ian Hickson
b5e471eec5 Include the error runtimeType in the message. (#3355)
Fixes https://github.com/flutter/flutter/issues/3352
2016-04-15 15:15:52 -07:00
Ian Hickson
d348f28df7 Use the same logic in flushPaint as flushLayout (#3353)
If two repaint boundaries mark themselves dirty, but the second one is a
child of the first, then the second one will get repainted by the first
and then when we come to paint it directly, we get confused because it
isn't dirty any more.

We ran into this in layout before. Apply the same fix. Also, apply the
same fix to composition while we're at it.
2016-04-15 14:55:18 -07:00
Eric Seidel
347831bf7f Merge pull request #3358 from eseidelGoogle/perf_overlay_gallery
Add a Performance Overlay toggle to the Gallery app
2016-04-15 13:25:08 -07:00
Ian Hickson
d9ca22a397 have invokeFrameCallback print the right stack (#3351)
Exception stack variable was shadowing the function argument stack.
2016-04-15 13:18:37 -07:00
Ian Hickson
e41c1c0b06 Split services/ into services/ and foundation/ (#3350)
We're getting back to the point where we have a bunch of foundation APIs
and it's getting confusing having them mixed with services/.
2016-04-15 13:18:29 -07:00
Eric Seidel
e845e8ad94 Merge pull request #3357 from eseidelGoogle/dev_benchmarks
Make update-packages cover dev/benchmarks.
2016-04-15 12:40:31 -07:00
Eric Seidel
711bf72620 Make update-packages cover dev/benchmarks.
update-packages only looks one level down, instead of
changing that, I'm just adding dev/benchmarks explicitly.

This will unbreak the bots which are dying trying to
flutter drive dev/benchmarks/complex_layout without
pub get having been run there.

@yjbanov @devoncarew
2016-04-15 12:35:02 -07:00
Ian Hickson
0f1dee5f46 Always dump (unwanted) exceptions during tests (#3344)
...even if the test fails.
2016-04-15 09:38:04 -07:00
Yegor
0e9737e4cc [driver] upgrade to the latest version of vm_service_client (#3348) 2016-04-14 23:23:45 -07:00
Yegor
86597cd10d [driver] lock vm_service_client
until we have a fix for the breaking changes
2016-04-14 16:26:17 -07:00
Yegor
d5d4e7c054 [driver] output per-frame build times in the timeline summary (#3334) 2016-04-14 11:28:16 -07:00
Phil Quitslund
f540c978d1 Merge pull request #3333 from pq/optional_type_args
Adding `@optionalTypeArgs`.
2016-04-14 10:57:34 -07:00
pq
de25ea22f7 Adding @optionalTypeArgs.
With the new dev build we've got the updated linter and so can use the `@optionalTypeArgs` annotation (in `meta 0.12.0`).

Bonus: this lets us clean up one more Regexp in the `analyze` command! :)
2016-04-14 10:03:46 -07:00