Jesús S Guerrero
2728ba0f23
Revert of #120385 ( #132167 )
...
Breaking google testing
revert of: https://github.com/flutter/flutter/pull/120385
b/295065534
2023-08-08 16:16:52 -07:00
Taha Tesser
b77b149df6
Add PopupMenuButton.iconColor, PopupMenuTheme.iconSize and fix button icon using unexpected color propert ( #132054 )
...
fixes [PopupMenuButton uses color property for icon color](https://github.com/flutter/flutter/issues/127802 )
fixes [`popup_menu_test.dart` lacks default icon color tests.](https://github.com/flutter/flutter/issues/132050 )
### Description
- Add `PopupMenuButton..iconColor` and fix the PopupMenu button icon using an unexpected color property.
- Add the missing `PopupMenuTheme.iconSize`.
- Clean up some tests and minor improvements.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [PopupMenuButton].
// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }
void main() => runApp(const PopupMenuApp());
class PopupMenuApp extends StatelessWidget {
const PopupMenuApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
popupMenuTheme: PopupMenuThemeData(
// iconSize: 75,
// iconColor: Colors.amber,
color: Colors.deepPurple[100],
),
),
home: const PopupMenuExample(),
);
}
}
class PopupMenuExample extends StatefulWidget {
const PopupMenuExample({super.key});
@override
State<PopupMenuExample> createState() => _PopupMenuExampleState();
}
class _PopupMenuExampleState extends State<PopupMenuExample> {
SampleItem? selectedMenu;
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('PopupMenuButton')),
body: Center(
child: PopupMenuButton<SampleItem>(
iconSize: 75,
// iconColor: Colors.amber,
color: Colors.deepPurple[100],
initialValue: selectedMenu,
// Callback that sets the selected popup menu item.
onSelected: (SampleItem item) {
setState(() {
selectedMenu = item;
});
},
itemBuilder: (BuildContext context) => <PopupMenuEntry<SampleItem>>[
const PopupMenuItem<SampleItem>(
value: SampleItem.itemOne,
child: Text('Item 1'),
),
const PopupMenuItem<SampleItem>(
value: SampleItem.itemTwo,
child: Text('Item 2'),
),
const PopupMenuDivider(),
const CheckedPopupMenuItem<SampleItem>(
value: SampleItem.itemThree,
checked: true,
child: Text('Item 3'),
),
],
),
),
);
}
}
```
</details>
2023-08-08 22:23:30 +00:00
Ian Hickson
e65c37ee45
More PageStorage clarity in the documentation ( #131954 )
...
Fixes https://github.com/flutter/flutter/issues/10867
2023-08-08 22:08:32 +00:00
Ian Hickson
b29069ec0b
Document that missed_frame_build_budget_count is misleading ( #132137 )
...
Fixes https://github.com/flutter/flutter/issues/109745
2023-08-08 22:08:30 +00:00
Lau Ching Jun
d5a0fcd5af
Locate the template directory using a TemplatePathProvider. ( #132156 )
...
So that the paths can be overridden.
2023-08-08 21:43:00 +00:00
engine-flutter-autoroll
547bdefba8
Roll Flutter Engine from dd03fae51d38 to 934ebb005d02 (4 revisions) ( #132159 )
...
dd03fae51d...934ebb005dskia-flutter-autoroll@skia.org Roll Skia from 6fa6fdd04783 to 5c8c7faf9131 (3 revisions) (flutter/engine#44506 )
2023-08-08 55360120+Matt2D@users.noreply.github.com Flutter iOS Interactive Keyboard: Handle Pointer Up (flutter/engine#44457 )
2023-08-08 30870216+gaaclarke@users.noreply.github.com [Impeller] improved glyph hashing performance (flutter/engine#44502 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 30c0319e7e42 to 6fa6fdd04783 (2 revisions) (flutter/engine#44503 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 21:20:50 +00:00
engine-flutter-autoroll
e2badf3857
Roll Flutter Engine from 22bd35a19352 to dd03fae51d38 (3 revisions) ( #132149 )
...
22bd35a193...dd03fae51d10456171+caroqliu@users.noreply.github.com Remove GFX branches from Flutter engine (flutter/engine#44401 )
2023-08-08 jason-simmons@users.noreply.github.com Use the Clang unreachable code warning flag in the engine tree (flutter/engine#44458 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 66ba512c613c to 30c0319e7e42 (3 revisions) (flutter/engine#44500 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 19:49:11 +00:00
Taha Tesser
ee47267d26
Fix TabBarTheme.indicatorColor not applied in Material 2 ( #132123 )
...
fixes [[Proposal] Improve TabBarTheme styling API for indicator color ](https://github.com/flutter/flutter/issues/130392 )
### Description
This fixes an issue where the `TabBarTheme.indicator` isn't applied in Material 2 and also adds indicator color tests for both M3 and M2.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [TabBar].
void main() => runApp(const TabBarApp());
class TabBarApp extends StatelessWidget {
const TabBarApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
useMaterial3: false,
tabBarTheme: const TabBarTheme(
indicatorColor: Colors.amber,
)
),
home: const TabBarExample(),
);
}
}
class TabBarExample extends StatelessWidget {
const TabBarExample({super.key});
@override
Widget build(BuildContext context) {
return DefaultTabController(
initialIndex: 1,
length: 3,
child: Scaffold(
appBar: AppBar(
title: const Text('TabBar Sample'),
bottom: const TabBar(
tabs: <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
text: 'Cloudy',
),
Tab(
icon: Icon(Icons.beach_access_sharp),
text: 'Sunny',
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
text: 'Rainy',
),
],
),
),
body: const TabBarView(
children: <Widget>[
Center(
child: Text("It's cloudy here"),
),
Center(
child: Text("It's rainy here"),
),
Center(
child: Text("It's sunny here"),
),
],
),
),
);
}
}
```
</details>
### Before
### After
2023-08-08 19:37:16 +00:00
Aakash Pamnani
0b81347897
Paginated Data Table : Fixed Row number at footer in last page ( #130389 )
...
Fixed the row count in the footer.
Before
After
*Issues Resolved*
Fixes #80421
2023-08-08 19:25:53 +00:00
Mouad Debbar
a2f48a360f
[web] Use benchmark callback from dart:ui_web ( #132087 )
...
Depends on https://github.com/flutter/engine/pull/44461
Fixes https://github.com/flutter/flutter/issues/130175
Part of https://github.com/flutter/flutter/issues/126831
2023-08-08 18:54:21 +00:00
engine-flutter-autoroll
f10a6ef758
Roll Flutter Engine from 99fdac88f3c6 to 22bd35a19352 (3 revisions) ( #132141 )
...
99fdac88f3...22bd35a193chris@bracken.jp [macOS] Fix engine/binaryMessenger retain cycle (flutter/engine#44471 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from f7162d33afb2 to 66ba512c613c (8 revisions) (flutter/engine#44497 )
2023-08-08 mdebbar@google.com [web] Expose the benchmark callback through dart:ui_web (flutter/engine#44461 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 17:55:08 +00:00
LouiseHsu
d9cb50e63d
[framework] Add Search Web to selection controls for iOS ( #131898 )
...
This PR adds framework support for the Search Web feature in iOS.
https://github.com/flutter/flutter/assets/36148254/c159f0d9-8f14-45e7-b295-e065b0826fab
The corresponding merged engine PR can be found [here](https://github.com/flutter/engine/pull/43324 ).
This PR addresses https://github.com/flutter/flutter/issues/82907
More details are available in this [design doc](https://docs.google.com/document/d/1QizXwBiO-2REIcEovl5pK06BaLPOWYmNwOE5jactJZA/edit?resourcekey=0-1pb9mJiAq29Gesmt25GAug )
2023-08-08 17:34:17 +00:00
Justin McCandless
9655311545
Remove Iterator from _History ( #132101 )
...
Cleaning up private code in Navigator.
2023-08-08 10:25:27 -07:00
Ian Hickson
e60dc3012e
Update dartdoc driver to match current behaviour ( #132078 )
2023-08-08 17:12:52 +00:00
Ian Hickson
9dbd1e9872
More documentation about warm-up frames ( #132085 )
2023-08-08 17:11:15 +00:00
engine-flutter-autoroll
23041cb2bb
Roll Flutter Engine from 146c4c9487fc to 99fdac88f3c6 (3 revisions) ( #132135 )
...
146c4c9487...99fdac88f3zanderso@users.noreply.github.com Excludes entity_pass.cc from clang-tidy due to timeouts (flutter/engine#44495 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0Jd9VPJCX145RGnqr... to 9Pl8nd13UI8rrS3JD... (flutter/engine#44494 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from r0vBgWqKSvQ6zzFam... to c18Y3Ga7cvdrmy8FQ... (flutter/engine#44492 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0Jd9VPJCX145 to 9Pl8nd13UI8r
fuchsia/sdk/core/mac-amd64 from r0vBgWqKSvQ6 to c18Y3Ga7cvdr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 17:09:18 +00:00
engine-flutter-autoroll
3886b0039c
Roll Packages from d7ee75ad59ad to ac4137624a13 (8 revisions) ( #132133 )
...
d7ee75ad59...ac4137624aengine-flutter-autoroll@skia.org Roll Flutter from ad0aa8de7512 to 436df69a4684 (17 revisions) (flutter/packages#4663 )
2023-08-08 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Repeatedly pump WebViews until one is garbage collected (flutter/packages#4662 )
2023-08-08 erikgerman917@gmail.com [xdg_directories] Add example app (flutter/packages#4554 )
2023-08-08 70025277+Nitin-Poojary@users.noreply.github.com [pigeon] Recursively create output target files (flutter/packages#4458 )
2023-08-07 jpnurmi@gmail.com [path_provider] Add getApplicationCachePath() (flutter/packages#4483 )
2023-08-07 10687576+bparrishMines@users.noreply.github.com [flutter_markdown] Adopt code excerpts in README (flutter/packages#4656 )
2023-08-07 reidbaker@google.com [All] Expand artifact hub to all plugins (flutter/packages#4645 )
2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter from 2ba9f7bdfe16 to ad0aa8de7512 (31 revisions) (flutter/packages#4659 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 16:53:24 +00:00
Polina Cherkasova
acd636f7ba
Handle breaking changes in leak_tracker. ( #131998 )
2023-08-08 09:39:19 -07:00
engine-flutter-autoroll
436df69a46
Roll Flutter Engine from 9c83d90b01bd to 146c4c9487fc (6 revisions) ( #132112 )
...
9c83d90b01...146c4c9487skia-flutter-autoroll@skia.org Roll Skia from b4a893827b2a to f7162d33afb2 (1 revision) (flutter/engine#44479 )
2023-08-07 jason-simmons@users.noreply.github.com Revert "[Impeller] DlCanvas implementation wrapping Aiks canvas" (flutter/engine#44466 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 5dd88a48f7e2 to b4a893827b2a (3 revisions) (flutter/engine#44470 )
2023-08-07 mdebbar@google.com [web] Silence `pub get` when it's successful (flutter/engine#44445 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mlT1Bm0L9bVynvMFF... to r0vBgWqKSvQ6zzFam... (flutter/engine#44463 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from d1ada6624536 to 5dd88a48f7e2 (8 revisions) (flutter/engine#44465 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from mlT1Bm0L9bVy to r0vBgWqKSvQ6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 05:58:16 +00:00
engine-flutter-autoroll
08b2c44413
Roll Flutter Engine from c27109291e22 to 9c83d90b01bd (5 revisions) ( #132108 )
...
c27109291e...9c83d90b01skia-flutter-autoroll@skia.org Roll Dart SDK from 0816d590a220 to f664f4b9c50d (1 revision) (flutter/engine#44462 )
2023-08-07 bdero@google.com [Impeller] Flutter GPU: Add GpuContext. (flutter/engine#44359 )
2023-08-07 ftsui@google.com Fix use-after-free crash in glfw embedder (flutter/engine#44358 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 9fbd7296de9a to d1ada6624536 (1 revision) (flutter/engine#44447 )
2023-08-07 zanderso@users.noreply.github.com Revert clang back to 6d667d4b261e81f325756fdfd5bb43b3b3d2451d (flutter/engine#44442 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 02:59:25 +00:00
engine-flutter-autoroll
73e1f9f524
Roll Flutter Engine from be085f6699b6 to c27109291e22 (3 revisions) ( #132086 )
...
be085f6699...c27109291eyjbanov@google.com [web] remove leftover comments from
semantics tester (flutter/engine#44350 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 77007f51bf81 to
9fbd7296de9a (4 revisions) (flutter/engine#44443 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from f19578685d17 to
77007f51bf81 (1 revision) (flutter/engine#44440 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 18:14:51 -07:00
Jesús S Guerrero
cef00d0c53
Revert "Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus" ( #132104 )
...
Reverts flutter/flutter#130164
reverting because it cause internal google testing failures b/294917394
2023-08-07 17:30:07 -07:00
Jonah Williams
915c52453b
[Impeller] add drawVertices and drawAtlas benchmarks. ( #132080 )
...
Adds impeller benchmarks to track the progress of improvements made in https://github.com/flutter/flutter/issues/131345
2023-08-08 00:28:16 +00:00
chunhtai
b01cb301cf
Adds more documentations around ignoreSemantics deprecations. ( #131287 )
...
migration guide update https://github.com/flutter/website/pull/9124
fixes the concerns in https://github.com/flutter/flutter/pull/120619
2023-08-07 23:59:48 +00:00
Mouad Debbar
55fe41be59
[web] New HtmlElementView.fromTagName constructor ( #130513 )
...
This wraps up the platform view improvements discussed in https://github.com/flutter/flutter/issues/127030 .
- Splits `HtmlElementView` into 2 files that are conditionally imported.
- The non-web version can be instantiated but it throws if it ends up being built in a widget tree.
- Out-of-the-box view factories that create visible & invisible DOM elements given a `tagName` parameter.
- New `HtmlElementView.fromTagName()` constructor that uses the default factories to create DOM elements.
- Tests covering the new API.
Depends on https://github.com/flutter/engine/pull/43828
Fixes https://github.com/flutter/flutter/issues/127030
2023-08-07 23:45:19 +00:00
Kate Lovett
f054f5aa09
Move mock canvas to flutter_test ( #131631 )
...
Fixes https://github.com/flutter/flutter/issues/59413
This relocates `mock_canvas.dart` and `recording_canvas.dart` from `flutter/test/rendering` to `flutter_test`.
The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :)
mock_canvas.dart needed a bit of cleanup - things like formatting and super parameters.
2023-08-07 23:43:03 +00:00
Matej Knopp
1c7e2afce9
Add static_path_tessellation macrobenchmark ( #131837 )
...
This adds a macrobenchmark representative of a real world application that uses SVG icons. The scenario of rasterizing complex paths that don't change over time does not seem to be covered by any other macrobenchmark and shows a significantly slower impeller performance compared to skia.
It's actually bit problematic to measure this because on A15 the CPU load with impeller is high enough to trigger CPU frequency change. So in order to get consistent reading I had to add a spinning background thread that would keep the CPU at highest frequency.
```objc
[NSThread detachNewThreadWithBlock:^{
while (true) {
pthread_yield_np();
}
}];
```
```bash
flutter drive --profile --local-engine=ios_profile -t test_driver/run_app.dart --driver test_driver/path_tessellation_static_perf_test.dart
```
| average_frame_build_time_millis |Time|
|--|--|
| Impeller | 0.46686524822695047 |
| Skia | 0.4625749999999999 |
| Skia - No RasterCache | 0.47173750000000086|
| average_frame_rasterizer_time_millis | Time |
|--|--|
| Impeller | 6.654328519855595 |
| Skia - Raster Cache | 0.2534123711340209 * |
| Skia - No RasterCache | 0.53424375 |
* Adding the `GeometryPainter` seems to have triggered the complexity threshold for raster cache.
<img alt="screenshot" width="320" src="https://github.com/flutter/flutter/assets/96958/7a2f9384-b512-477b-bffa-058d4d284a41 "/>
2023-08-07 23:39:49 +00:00
Mouad Debbar
ad0dbc8de5
[web] Remove usage of ui.webOnlyInitializePlatform() ( #131344 )
...
Part of https://github.com/flutter/flutter/issues/126831
2023-08-07 21:27:11 +00:00
engine-flutter-autoroll
0448a11c86
Roll Flutter Engine from 39a575f65d50 to be085f6699b6 (1 revision) ( #132069 )
...
39a575f65d...be085f6699skia-flutter-autoroll@skia.org Roll Skia from 359808ec2cb1 to f19578685d17 (1 revision) (flutter/engine#44439 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 21:00:49 +00:00
Justin McCandless
ebbb4b3887
Android context menu theming and visual update ( #131816 )
...
Fixes https://github.com/flutter/flutter/issues/89939 and updates the look of the Android context menu to match API 34.
## The problem
Before this PR, setting `surface` in the color scheme caused the background color of the Android context menu to change, but it wasn't possible to change the text color.
```dart
MaterialApp(
theme: ThemeData(
// Using a dark theme made the context menu text color be white.
colorScheme: ThemeData.dark().colorScheme.copyWith(
// Setting the surface here worked.
surface: Colors.white,
// But there was no way to set the text color. This didn't work.
onSurface: Colors.black,
),
),
),
```
| Expected (after PR) | Actual (before PR) |
| --- | --- |
| <img width="239" alt="Screenshot 2023-08-07 at 11 45 37 AM" src="https://github.com/flutter/flutter/assets/389558/a9fb75e5-b6c3-4f8e-8c59-2021780c44a7 "> | <img width="250" alt="Screenshot 2023-08-07 at 11 51 10 AM" src="https://github.com/flutter/flutter/assets/389558/a5abd2d2-49bb-47a0-836f-864d56af2f58 "> |
## Other examples
<table>
<tr>
<th>Scenario</th>
<th>Result</th>
</tr>
<tr>
<td>
```dart
MaterialApp(
theme: ThemeData(
colorScheme: ThemeData.light(),
),
...
),
```
</td>
<td>
<img width="244" alt="Screenshot 2023-08-07 at 11 42 05 AM" src="https://github.com/flutter/flutter/assets/389558/74c6870b-5ff7-4b1a-9e0c-b2bb4809ef1e ">
</td>
</tr>
<tr>
<td>
```dart
MaterialApp(
theme: ThemeData(
colorScheme: ThemeData.dark(),
),
...
),
```
</td>
<td>
<img width="239" alt="Screenshot 2023-08-07 at 11 42 23 AM" src="https://github.com/flutter/flutter/assets/389558/91fe32f8-bd62-4d9b-96e8-ae5a9a769745 ">
</td>
</tr>
<tr>
<td>
```dart
MaterialApp(
theme: ThemeData(
colorScheme: ThemeData.light().colorScheme.copyWith(
surface: Colors.blue,
onSurface: Colors.red,
),
),
...
),
```
</td>
<td>
<img width="240" alt="Screenshot 2023-08-07 at 11 43 06 AM" src="https://github.com/flutter/flutter/assets/389558/e5752f8b-3738-4391-9055-15c38bd4af21 ">
</td>
</tr>
<tr>
<td>
```dart
MaterialApp(
theme: ThemeData(
colorScheme: ThemeData.light().colorScheme.copyWith(
surface: Colors.blue,
onSurface: Colors.red,
),
),
...
),
```
</td>
<td>
<img width="244" alt="Screenshot 2023-08-07 at 11 42 47 AM" src="https://github.com/flutter/flutter/assets/389558/68cc68f0-b338-4d94-8810-d8e46fb1e48e ">
</td>
</tr>
</table>
2023-08-07 20:59:08 +00:00
engine-flutter-autoroll
9cc4f94397
Roll Flutter Engine from 39ce1c097bce to 39a575f65d50 (2 revisions) ( #132064 )
...
39ce1c097b...39a575f65dskia-flutter-autoroll@skia.org Roll Skia from e327eb094605 to 359808ec2cb1 (2 revisions) (flutter/engine#44438 )
2023-08-07 jason-simmons@users.noreply.github.com Do not log exceptions from JNI lookups of APIs that are known to be unavailable on older devices (flutter/engine#44357 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 17:00:25 +00:00
xhzq233
ff5b0e1457
CupertinoContextMenu improvement ( #131030 )
...
Fixes overlapping gestures in CupertinoContextMenu's subtree
2023-08-07 09:30:21 -07:00
engine-flutter-autoroll
1a31682e6c
Roll Flutter Engine from 5b47c0577060 to 39ce1c097bce (3 revisions) ( #132057 )
...
5b47c05770...39ce1c097bskia-flutter-autoroll@skia.org Roll Skia from 7a98630e0de9 to e327eb094605 (2 revisions) (flutter/engine#44437 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from f4047f002891 to 7a98630e0de9 (1 revision) (flutter/engine#44436 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zVfdIYcZ93Loob7VG... to 0Jd9VPJCX145RGnqr... (flutter/engine#44435 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zVfdIYcZ93Lo to 0Jd9VPJCX145
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 16:04:53 +00:00
Mingyu
06ca902dfc
Slider should check mounted before start interaction ( #132010 )
...
This is a follow up to the following pull requests:
- https://github.com/flutter/flutter/pull/124514
I was finally able to reproduce this bug and found out why it was happening. Consider this code:
```dart
GestureDetector(
behavior: HitTestBehavior.translucent,
// Note: Make sure onTap is not null to ensure events
// are captured by `GestureDetector`
onTap: () {},
child: _shouldShowSlider
? Slider(value: _value, onChanged: _handleSlide)
: const SizedBox.shrink().
)
```
Runtime exception happens when:
1. User taps and holds the Slider (drag callback captured by `GestureDetector`)
2. `_shouldShowSlider` changes to false, Slider disappears and unmounts, and unregisters `_handleSlide`. But the callback is still registered by `GestureDetector`
3. Users moves finger as if Slider were still there
4. Drag callback is invoked, `_SliderState.showValueIndicator` is called
5. Exception - Slider is already disposed
This pull request fixes it by adding a mounted check inside `_SliderState.showValueIndicator` to ensure the Slider is actually mounted at the time of invoking drag event callback. I've added a unit test that will fail without this change.
The error stack trace is:
```
The following assertion was thrown while handling a gesture:
This widget has been unmounted, so the State no longer has a context (and should be considered
defunct).
Consider canceling any active work during "dispose" or using the "mounted" getter to determine if
the State is still active.
When the exception was thrown, this was the stack:
#0 State.context.<anonymous closure> (package:flutter/src/widgets/framework.dart:950:9)
#1 State.context (package:flutter/src/widgets/framework.dart:956:6)
#2 _SliderState.showValueIndicator (package:flutter/src/material/slider.dart:968:18)
#3 _RenderSlider._startInteraction (package:flutter/src/material/slider.dart:1487:12)
#4 _RenderSlider._handleDragStart (package:flutter/src/material/slider.dart:1541:5)
#5 DragGestureRecognizer._checkStart.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:531:53)
#6 GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:275:24)
#7 DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:531:7)
#8 DragGestureRecognizer._checkDrag (package:flutter/src/gestures/monodrag.dart:498:5)
#9 DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:431:7)
#10 _CombiningGestureArenaMember.acceptGesture (package:flutter/src/gestures/team.dart:45:14)
#11 GestureArenaManager._resolveInFavorOf (package:flutter/src/gestures/arena.dart:281:12)
#12 GestureArenaManager._resolve (package:flutter/src/gestures/arena.dart:239:9)
#13 GestureArenaEntry.resolve (package:flutter/src/gestures/arena.dart:53:12)
#14 _CombiningGestureArenaMember._resolve (package:flutter/src/gestures/team.dart:85:15)
#15 _CombiningGestureArenaEntry.resolve (package:flutter/src/gestures/team.dart:19:15)
#16 OneSequenceGestureRecognizer.resolve (package:flutter/src/gestures/recognizer.dart:375:13)
#17 DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:414:13)
#18 PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12)
#19 PointerRouter._dispatchEventToRoutes.<anonymous closure> (package:flutter/src/gestures/pointer_router.dart:143:9)
#20 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13)
#21 PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18)
#22 PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7)
#23 GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:488:19)
#24 GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:468:22)
#25 RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:439:11)
#26 GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:413:7)
#27 GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:376:5)
#28 GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:323:7)
#29 GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:292:9)
#30 _invoke1 (dart:ui/hooks.dart:186:13)
#31 PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:433:7)
#32 _dispatchPointerDataPacket (dart:ui/hooks.dart:119:31)
Handler: "onStart"
Recognizer:
HorizontalDragGestureRecognizer#a5df2
```
*List which issues are fixed by this PR. You must list at least one issue.*
Internal bug: b/273666179, b/192329942
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-07 16:03:23 +00:00
engine-flutter-autoroll
122c42951a
Roll Packages from ce53da1bd741 to d7ee75ad59ad (7 revisions) ( #132058 )
...
ce53da1bd7...d7ee75ad59stuartmorgan@google.com [tool] Skip pathified analysis on resolver errors (flutter/packages#4647 )
2023-08-05 stuartmorgan@google.com [ci] Remove tools from Dockerfile (flutter/packages#4649 )
2023-08-05 32242716+ricardoamador@users.noreply.github.com Update to not backfill the ci.yaml roller task. (flutter/packages#4651 )
2023-08-04 stuartmorgan@google.com [pigeon] Consolidate mock handler tests (flutter/packages#4642 )
2023-08-04 stuartmorgan@google.com [camera_web] Adopt code excerpts in README (flutter/packages#4584 )
2023-08-04 stuartmorgan@google.com [image_picker] Allows 3.0 web implementation (flutter/packages#4648 )
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter from c00d241938b1 to 2ba9f7bdfe16 (25 revisions) (flutter/packages#4646 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 15:49:03 +00:00
engine-flutter-autoroll
ad0aa8de75
Roll Flutter Engine from b10891e0d8d8 to 5b47c0577060 (1 revision) ( #132040 )
...
b10891e0d8...5b47c05770skia-flutter-autoroll@skia.org Roll Skia from 558d9754241d to f4047f002891 (1 revision) (flutter/engine#44433 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 11:21:39 +00:00
engine-flutter-autoroll
c11ac7be9a
Roll Flutter Engine from 4304d6180264 to b10891e0d8d8 (1 revision) ( #132037 )
...
4304d61802...b10891e0d8skia-flutter-autoroll@skia.org Roll Skia from b7a1f4fdedc1 to 558d9754241d (1 revision) (flutter/engine#44432 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 09:43:32 +00:00
engine-flutter-autoroll
fd61c4a405
Roll Flutter Engine from eb91441398a1 to 4304d6180264 (1 revision) ( #132031 )
...
eb91441398...4304d61802skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 9QyQ03F49oT_9slFF... to mlT1Bm0L9bVynvMFF... (flutter/engine#44431 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 9QyQ03F49oT_ to mlT1Bm0L9bVy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 08:43:29 +00:00
Tomasz Gucio
55044a605f
Constrain _RenderScaledInlineWidget child size in computeDryLayout ( #131765 )
2023-08-07 10:28:07 +02:00
engine-flutter-autoroll
7de053b2b8
Roll Flutter Engine from 15b5707af406 to eb91441398a1 (1 revision) ( #132025 )
...
15b5707af4...eb91441398skia-flutter-autoroll@skia.org Roll Skia from 9c4cfcd16529 to b7a1f4fdedc1 (2 revisions) (flutter/engine#44430 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 07:51:33 +00:00
engine-flutter-autoroll
bfbe79feb2
Roll Flutter Engine from a1d513f78bbb to 15b5707af406 (2 revisions) ( #132020 )
...
a1d513f78b...15b5707af4skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fwCoUCWKEqZSJGPE8... to zVfdIYcZ93Loob7VG... (flutter/engine#44428 )
2023-08-06 skia-flutter-autoroll@skia.org Roll Skia from 72264deb9f05 to 9c4cfcd16529 (1 revision) (flutter/engine#44427 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fwCoUCWKEqZS to zVfdIYcZ93Lo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 01:47:34 +00:00
engine-flutter-autoroll
ecef964a2e
Roll Flutter Engine from c9bd380ccbb0 to a1d513f78bbb (1 revision) ( #132015 )
...
c9bd380ccb...a1d513f78bskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from iY3v8FawLUo9HvTeR... to 9QyQ03F49oT_9slFF... (flutter/engine#44425 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from iY3v8FawLUo9 to 9QyQ03F49oT_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 19:21:24 +00:00
engine-flutter-autoroll
310e911466
Roll Flutter Engine from 060c95f94364 to c9bd380ccbb0 (1 revision) ( #132008 )
...
060c95f943...c9bd380ccbskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from E0vw_CD-BaFAcSoH4... to fwCoUCWKEqZSJGPE8... (flutter/engine#44424 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from E0vw_CD-BaFA to fwCoUCWKEqZS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 12:45:22 +00:00
engine-flutter-autoroll
11d9846074
Roll Flutter Engine from af7aaae2f1f9 to 060c95f94364 (1 revision) ( #132006 )
...
af7aaae2f1...060c95f943skia-flutter-autoroll@skia.org Roll Skia from 1d390344bfca to 72264deb9f05 (1 revision) (flutter/engine#44423 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 10:11:24 +00:00
engine-flutter-autoroll
91d64391f0
Roll Flutter Engine from cdafc05a7217 to af7aaae2f1f9 (2 revisions) ( #132004 )
...
cdafc05a72...af7aaae2f1skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4pA5pP6XaVIJBXuq0... to iY3v8FawLUo9HvTeR... (flutter/engine#44422 )
2023-08-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QazMbN_0ttbJpf36s... to E0vw_CD-BaFAcSoH4... (flutter/engine#44421 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from QazMbN_0ttbJ to E0vw_CD-BaFA
fuchsia/sdk/core/mac-amd64 from 4pA5pP6XaVIJ to iY3v8FawLUo9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-06 06:47:35 +00:00
engine-flutter-autoroll
c09a9b4c46
Roll Flutter Engine from b512df490c94 to cdafc05a7217 (1 revision) ( #131996 )
...
b512df490c...cdafc05a72skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from UpzOzWyiGYKrIuKmG... to 4pA5pP6XaVIJBXuq0... (flutter/engine#44420 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from UpzOzWyiGYKr to 4pA5pP6XaVIJ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-05 23:20:34 +00:00
Tomasz Gucio
bc4cacac0d
Take paint offset into account for inline children hit test in Editable ( #131675 )
2023-08-05 15:36:54 +02:00
engine-flutter-autoroll
545ecd29f2
Roll Flutter Engine from d26b8c8fb60c to b512df490c94 (1 revision) ( #131987 )
...
d26b8c8fb6...b512df490cskia-flutter-autoroll@skia.org Roll Skia from 275bcb6d874d to 1d390344bfca (1 revision) (flutter/engine#44419 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-05 13:32:33 +00:00
engine-flutter-autoroll
53609ef838
Roll Flutter Engine from 2ce2913acbe4 to d26b8c8fb60c (1 revision) ( #131986 )
...
2ce2913acb...d26b8c8fb6skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3uzA1Z-yaMQE_Cz5f... to QazMbN_0ttbJpf36s... (flutter/engine#44418 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3uzA1Z-yaMQE to QazMbN_0ttbJ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-05 12:40:33 +00:00
engine-flutter-autoroll
e1f56f18c4
Roll Flutter Engine from 628b086265f2 to 2ce2913acbe4 (1 revision) ( #131983 )
...
628b086265...2ce2913acbskia-flutter-autoroll@skia.org Roll Dart SDK from 8a3277696c52 to 0816d590a220 (1 revision) (flutter/engine#44415 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-05 11:22:33 +00:00
