Pierre-Louis
28ca523ac2
Remove incorrect non-nullable assumption from ShapeDecoration.lerp ( #129298 )
...
Fixes https://github.com/flutter/flutter/issues/129299
2023-06-21 21:34:58 +00:00
Justin McCandless
16eb4f2c08
Gracefully handle negative position in getWordAtOffset ( #128464 )
...
Should fix an unreproducible crash in text editing and track it with an assertion.
2023-06-21 14:22:04 -07:00
Christopher Fujino
5cef69dd49
[flutter_tools] add a gradle error handler for could not open cache directory ( #129222 )
...
Works around part of https://github.com/flutter/flutter/issues/128866
2023-06-21 20:13:40 +00:00
engine-flutter-autoroll
d2c4b5a109
Roll Flutter Engine from f973fb4636d3 to 090fae83548a (5 revisions) ( #129293 )
...
f973fb4636...090fae8354skia-flutter-autoroll@skia.org Roll Skia from c983b97d03a8 to 7eeb94b1e778 (4 revisions) (flutter/engine#43045 )
2023-06-21 godofredoc@google.com Move android emulator tests to v2. (flutter/engine#43008 )
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 65f30e5804c7 to c983b97d03a8 (2 revisions) (flutter/engine#43044 )
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 7121db7c6dc2 to 65f30e5804c7 (3 revisions) (flutter/engine#43043 )
2023-06-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 178d3d1184cb to 88fa9330633e (1 revision) (flutter/engine#43041 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 20:06:04 +00:00
Renzo Olivares
b36ef583fb
Selection area right click behavior should match native ( #128224 )
...
This change updates `SelectableRegion`s right-click gesture to match native platform behavior.
Before: Right-click gesture selects word at position and opens context menu (All Platforms)
After:
- Linux, toggles context menu on/off, and collapses selection when click was not on an active selection (uncollapsed).
- Windows, Android, Fuchsia, shows context menu at right-clicked position (unless the click is at an active selection).
- macOS, toggles the context menu if right click was at the same position as the previous / or selects word at position and opens context menu.
- iOS, selects word at position and opens context menu.
This change also prevents the `copy` menu button from being shown when there is a collapsed selection (nothing to copy).
Fixes #117561
2023-06-21 19:32:04 +00:00
engine-flutter-autoroll
c40baf47c5
Roll Packages from 6e1918fa166c to 0fdf05f51029 (8 revisions) ( #129286 )
...
6e1918fa16...0fdf05f51034871572+gmackall@users.noreply.github.com [image_picker_android] Modify FileUtils.getBaseName to return the whole filename when it contains no period (flutter/packages#4237 )
2023-06-21 stuartmorgan@google.com [tools] Add mockito support to update-dependency (flutter/packages#4260 )
2023-06-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.2 to 3.5.3 (flutter/packages#4185 )
2023-06-21 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.21 to 1.8.22 in /packages/image_picker/image_picker_android/android (flutter/packages#4190 )
2023-06-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.0.3 to 4.1.0 (flutter/packages#4145 )
2023-06-20 stuartmorgan@google.com [ci] Add LUCI version of the analyze tasks (flutter/packages#4253 )
2023-06-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.21 to 1.8.22 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4193 )
2023-06-20 stuartmorgan@google.com [ci] Switch Linux and web build-all to LUCI (flutter/packages#4252 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 17:00:17 +00:00
Christopher Fujino
8af21e0efb
move test ownership from zanderso -> tools team ( #129199 )
...
Move more test ownership from zanderso to the tools team. This file is used by the flaky issue bot to comment weekly on test shards that flake > 2%. The owner of the shard will be @'d on the issue. It is their responsibility to investigate and triage (potentially re-prioritizing, the bot will initially assign it p1).
2023-06-21 16:43:33 +00:00
Elias Yishak
5d8cc978b9
Refactor Analytics global getter to point to context only ( #129196 )
...
Refactor the globals getter for `Analytics` to be in the context instead of having a default fallback. The current state of the tool creates a new instance every time `globals.analytics` was called
Addresses issue:
- https://github.com/flutter/flutter/issues/128535
2023-06-21 15:27:32 +00:00
engine-flutter-autoroll
b83f762dd5
Roll Flutter Engine from cfbd3652532d to f973fb4636d3 (1 revision) ( #129253 )
...
cfbd365253...f973fb4636skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 41wcREjd9roHDS1jM... to 4mkuVtlGBaumKSe8x... (flutter/engine#43038 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 41wcREjd9roH to 4mkuVtlGBaum
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 10:28:40 +00:00
engine-flutter-autoroll
66f47e94b1
Roll Flutter Engine from 059643dcc8e3 to cfbd3652532d (1 revision) ( #129243 )
...
059643dcc8...cfbd365253skia-flutter-autoroll@skia.org Roll Skia from a6412350122e to 7121db7c6dc2 (3 revisions) (flutter/engine#43037 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 09:36:38 +00:00
engine-flutter-autoroll
e5559b9c6c
Roll Flutter Engine from 5313ca367549 to 059643dcc8e3 (1 revision) ( #129240 )
...
5313ca3675...059643dcc8skia-flutter-autoroll@skia.org Roll Skia from efc045c15fdd to a6412350122e (2 revisions) (flutter/engine#43036 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 08:35:08 +00:00
engine-flutter-autoroll
f5203cb68f
Roll Flutter Engine from 946f523859fe to 5313ca367549 (2 revisions) ( #129234 )
...
946f523859...5313ca3675skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fdtK_FqpscIVvbb_j... to ct6r5YjdG2xpZPhkT... (flutter/engine#43035 )
2023-06-21 leroux_bruno@yahoo.fr [Android] Return the keyboard pressed state (flutter/engine#42758 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fdtK_FqpscIV to ct6r5YjdG2xp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 07:47:27 +00:00
engine-flutter-autoroll
88d6539e61
Roll Flutter Engine from e5a860c5479c to 946f523859fe (2 revisions) ( #129232 )
...
e5a860c547...946f523859skia-flutter-autoroll@skia.org Roll Dart SDK from 493133372cac to 178d3d1184cb (1 revision) (flutter/engine#43032 )
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from cc164404690f to efc045c15fdd (1 revision) (flutter/engine#43027 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 06:53:18 +00:00
LongCatIsLooong
04ff86f020
Relax OverlayPortal asserts ( #129053 )
...
Fixes https://github.com/flutter/flutter/issues/129025
Also
- simplifies OverlayPortal code a bit and adds an assert.
- `Tooltip` shouldn't rebuild when hiding/showing the tooltip
2023-06-21 02:40:48 +00:00
engine-flutter-autoroll
99aaff53dc
Roll Flutter Engine from adfc3af300a9 to e5a860c5479c (3 revisions) ( #129228 )
...
adfc3af300...e5a860c547jason-simmons@users.noreply.github.com Implement the APNG_DISPOSE_OP_BACKGROUND disposal method in the animated PNG decoder (flutter/engine#42933 )
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 13d83a6912ce to cc164404690f (1 revision) (flutter/engine#43024 )
2023-06-20 tamird@google.com Roll buildroot to 6e71c38443c0bf9d8954c87bf69bb4e019f44f94 (flutter/engine#43019 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 02:22:37 +00:00
godofredoc
dffef2715e
Move all the firebase lab device configs to .ci.yaml. ( #129219 )
...
Bug: https://github.com/flutter/flutter/issues/129211
2023-06-21 01:10:07 +00:00
engine-flutter-autoroll
325b7b3855
Roll Flutter Engine from 7d4abb81ccd1 to adfc3af300a9 (2 revisions) ( #129225 )
...
7d4abb81cc...adfc3af300skia-flutter-autoroll@skia.org Roll Dart SDK from 219b3198373c to 493133372cac (2 revisions) (flutter/engine#43021 )
2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 0b88d9031cd2 to 13d83a6912ce (4 revisions) (flutter/engine#43020 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-21 00:57:25 +00:00
Andrew Kolos
e1e45ca37a
update resolution-aware asset docs links ( #128769 )
...
Updates some doc comment links.
Fixes https://github.com/flutter/flutter/issues/128139
2023-06-20 23:45:52 +00:00
Justin McCandless
40b4bc996c
Fix: Magnifier appears and won't dismiss ( #128545 )
...
Fixes a bug when tapping near certain TextFields.
2023-06-20 16:36:45 -07:00
Tae Hyung Kim
541fdd60d3
DecoratedSliver ( #127823 )
...
This is a second attempt to merge #107269 . Currently I've fixed two of the issues:
1. Fixed horizontal scrollview by using a switch statement to consider vertical/horizontal case.
2. Fixed issue of `paintExtent` not being the right extent for painting. Rather using a `scrollExtent` for the main axis length of the decoration box and painting it offsetted by the `scrollOffset`.
3. If the sliver child has inifinite scrollExtent, then we only draw the decoration down to the bottom of the `cacheExtent`. The developer is expected to ensure that the border does not creep up above the cache area.
This PR includes a test that checks that the correct rectangle is drawn at a certain scrollOffset for both the horizontal and vertical case which should be sufficient for checking that `SliverDecoration` works properly now.
Fixes https://github.com/flutter/flutter/issues/107498 .
2023-06-20 23:35:42 +00:00
engine-flutter-autoroll
08561958eb
Roll Flutter Engine from 666244148e89 to 7d4abb81ccd1 (1 revision) ( #129217 )
...
666244148e...7d4abb81ccskia-flutter-autoroll@skia.org Roll Skia from d56841344bbe to 0b88d9031cd2 (3 revisions) (flutter/engine#43018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 23:32:12 +00:00
engine-flutter-autoroll
83f8b2e6c0
Roll Flutter Engine from 06d0c08460e5 to 666244148e89 (2 revisions) ( #129208 )
...
06d0c08460...666244148eskia-flutter-autoroll@skia.org Roll Skia from 9f8b501ca68c to d56841344bbe (5 revisions) (flutter/engine#43016 )
2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 0b26ffb4efe0 to 9f8b501ca68c (10 revisions) (flutter/engine#43012 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 22:37:53 +00:00
Md. Yeasin Sheikh
b733901de1
fixed PreferredSize constuctor invocations ( #128181 )
...
This PR changes the `PreferredSize` constructor parameter positioning to cover the constructor invocations. It helps on auto-complete and suggestion.
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes #128178
2023-06-20 22:21:12 +00:00
engine-flutter-autoroll
3b013b7bc2
Roll Flutter Engine from 1c16af76ca26 to 06d0c08460e5 (3 revisions) ( #129200 )
...
1c16af76ca...06d0c08460jason-simmons@users.noreply.github.com A few minor cleanups of the MultiFrameCodec (flutter/engine#42935 )
2023-06-20 jonahwilliams@google.com [Impeller] use pixel format in construction of initial PSO objects, set default sample count to 4. (flutter/engine#42972 )
2023-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from dc6691ef755c to 219b3198373c (1 revision) (flutter/engine#43005 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 20:02:21 +00:00
engine-flutter-autoroll
3bbd9b37ec
Roll Flutter Engine from ec64672afd91 to 1c16af76ca26 (1 revision) ( #129197 )
...
ec64672afd...1c16af76ca5236035+fzyzcjy@users.noreply.github.com Differentiate two `EncodeCommandsInReactor` with the same name (flutter/engine#42992 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 19:14:23 +00:00
engine-flutter-autoroll
0dee5dea10
Roll Flutter Engine from 4444ede34a9c to ec64672afd91 (3 revisions) ( #129194 )
...
4444ede34a...ec64672afdgoderbauer@google.com Reland "Add deprecations to PlatformMessage stuff" (#42580 ) (flutter/engine#42929 )
2023-06-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jzCJwD297aRZtdakZ... to 41wcREjd9roHDS1jM... (flutter/engine#43003 )
2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 6823d03cf2b2 to 0b26ffb4efe0 (2 revisions) (flutter/engine#43002 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jzCJwD297aRZ to 41wcREjd9roH
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 18:30:04 +00:00
Victoria Ashworth
25e98b54d7
Fix duplicate devices from xcdevice with iOS 17 ( #128802 )
...
This PR fixes issue of duplicate entries from `xcdevice list` cause devices to not show in `flutter devices`, `flutter run`, etc.
When a duplicate entry is found, use the entry without errors as the authority. If both have errors, use the one with the higher SDK as the authority.
Fixes https://github.com/flutter/flutter/issues/128719 .
2023-06-20 18:16:27 +00:00
Chris Yang
fadcaee842
iOS info.plist template: make UIViewControllerBasedStatusBar to be true ( #128970 )
...
Now that we support UIViewControllerBasedStatusBar by default (after engine roll: c7167765d7https://github.com/flutter/flutter/issues/128969
2023-06-20 18:11:18 +00:00
William Hesse
6ae22ef4e9
Fix detection that tests are running on monorepo bots ( #129173 )
...
Automatic CI testing runs on monorepo bots that tests the heads
of the Dart SDK, Flutter engine, and Flutter framework together.
These tests previously ran on bots called HHH (triple-headed),
and the logic for detecting this used the machine name of the test machine.
Extend that detection logic to cover the test machine hostnames that
run monorepo testing, that start with either 'dart-tests-' or 'luci-dart-'.
None of the machines used to run Flutter release builds have names
like this, even though they are in an internal Dart luci project.
Bug: b/231927187
2023-06-20 17:03:49 +00:00
Lau Ching Jun
3291750082
Use the new getIsolatePauseEvent method from VM service to check for pause event. ( #128834 )
...
The `getIsolate` method returns the full list of libraries which can be huge for large apps. Using the more speficic API to only fetch what we need improves hot reload performance.
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-06-20 16:42:28 +00:00
Swaroop S
80935ad984
Adding ScrollController support for Stepper widget ( #128814 )
...
This PR is to add **controller** property to the **Stepper** widget, so
that user has the flexibility to control the scroll offset for various
purposes(especially in case of scroll animations)!
Fixes #61207
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
2023-06-20 09:04:41 -07:00
engine-flutter-autoroll
ca6f08a306
Roll Packages from 59d93d64cb83 to 6e1918fa166c (6 revisions) ( #129176 )
...
59d93d64cb...6e1918fa16ychris@google.com [all] Update UIViewControllerBasedStatusBarAppearance to true (flutter/packages#4225 )
2023-06-17 31859944+LongCatIsLooong@users.noreply.github.com Add missing ignores for `textScaleFactor` deprecation (flutter/packages#4239 )
2023-06-17 goderbauer@google.com [url_launcher] Remove deprecated onPlatformMessage calls (flutter/packages#4233 )
2023-06-17 stuartmorgan@google.com [ci] Add LUCI version of build-all for web (flutter/packages#4232 )
2023-06-16 stuartmorgan@google.com [ci] Introduce LUCI version of Linux build-all-packages tests (flutter/packages#4229 )
2023-06-16 engine-flutter-autoroll@skia.org Roll Flutter from b0188cd18274 to fc8856eb80d3 (14 revisions) (flutter/packages#4231 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 15:51:29 +00:00
Tae Hyung Kim
48ba9c4193
Refactor generate_localizations_test.dart ( #128974 )
...
The file was becoming harder to deal with as it manually sets up a /lib/l10n directory with a `MemoryFileSystem` in every single test. This PR wraps this process in a helper function `setupLocalizations` and also provides a helper function `getGeneratedFileContent` which helps fetch the respective output file given the locale string.
2023-06-20 15:42:22 +00:00
Kevin Chisholm
e5ec07ba16
[process] Add a design doc issue template. ( #128361 )
...
Add a design doc issue template to streamline the proposal flow.
2023-06-20 13:42:34 +00:00
engine-flutter-autoroll
691e24c1dd
Roll Flutter Engine from bd6d3fc90462 to 4444ede34a9c (1 revision) ( #129169 )
...
bd6d3fc904...4444ede34askia-flutter-autoroll@skia.org Roll Skia from 1d6ca884ed77 to 6823d03cf2b2 (1 revision) (flutter/engine#42998 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 13:22:29 +00:00
engine-flutter-autoroll
fa99d44413
Roll Flutter Engine from 73c4ba4240cc to bd6d3fc90462 (1 revision) ( #129168 )
...
73c4ba4240...bd6d3fc904skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JewrT71vAzyDs8qRt... to fdtK_FqpscIVvbb_j... (flutter/engine#42997 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JewrT71vAzyD to fdtK_FqpscIV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 12:29:07 +00:00
engine-flutter-autoroll
5ffdd0f038
Roll Flutter Engine from 7ee874792067 to 73c4ba4240cc (1 revision) ( #129162 )
...
7ee8747920...73c4ba4240skia-flutter-autoroll@skia.org Roll Dart SDK from d87670619414 to dc6691ef755c (1 revision) (flutter/engine#42996 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 10:19:33 +00:00
engine-flutter-autoroll
7f5232f5d8
Roll Flutter Engine from 6a6c8fb591f5 to 7ee874792067 (1 revision) ( #129160 )
...
6a6c8fb591...7ee8747920skia-flutter-autoroll@skia.org Roll Skia from 60385192e512 to 1d6ca884ed77 (3 revisions) (flutter/engine#42995 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 09:23:39 +00:00
Leigha Jarett
b2c993cad3
Add to API docs to explain what Assist and Suggestion chips are ( #129034 )
...
Fixes https://github.com/flutter/flutter/issues/128028 .
It seems pretty straightforward so don't think it warrants the effort to add more samples.
2023-06-20 09:03:21 +00:00
engine-flutter-autoroll
63908a687b
Roll Flutter Engine from a91bb3f566b9 to 6a6c8fb591f5 (1 revision) ( #129158 )
...
a91bb3f566...6a6c8fb591skia-flutter-autoroll@skia.org Roll Skia from abcc292f8afe to 60385192e512 (1 revision) (flutter/engine#42993 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 08:37:27 +00:00
engine-flutter-autoroll
5182697c0d
Roll Flutter Engine from e0d456d9251b to a91bb3f566b9 (1 revision) ( #129148 )
...
e0d456d925...a91bb3f566skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lG2K667BLaS_haUZg... to jzCJwD297aRZtdakZ... (flutter/engine#42990 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lG2K667BLaS_ to jzCJwD297aRZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 01:37:33 +00:00
engine-flutter-autoroll
e661d01c2d
Roll Flutter Engine from 55418e648958 to e0d456d9251b (1 revision) ( #129146 )
...
55418e6489...e0d456d925skia-flutter-autoroll@skia.org Roll Skia from 9c2148cd1c82 to abcc292f8afe (1 revision) (flutter/engine#42989 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 00:33:37 +00:00
engine-flutter-autoroll
b8590b2315
Roll Flutter Engine from 84ecaa053ec6 to 55418e648958 (1 revision) ( #129145 )
...
84ecaa053e...55418e6489skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gX0QkT_dMBCTbiAHY... to JewrT71vAzyDs8qRt... (flutter/engine#42988 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gX0QkT_dMBCT to JewrT71vAzyD
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 23:31:30 +00:00
engine-flutter-autoroll
c99540264b
Roll Flutter Engine from 23a2c246600f to 84ecaa053ec6 (2 revisions) ( #129142 )
...
23a2c24660...84ecaa053eskia-flutter-autoroll@skia.org Roll Skia from 41689ff01f97 to 9c2148cd1c82 (1 revision) (flutter/engine#42987 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 60adb12ffc30 to d87670619414 (1 revision) (flutter/engine#42986 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 22:43:35 +00:00
Taha Tesser
467c970bfb
Introduce MaterialState color property for chips ( #128584 )
...
fixes https://github.com/flutter/flutter/issues/115827
fixes https://github.com/flutter/flutter/issues/101325
### Description
1. This PR adds a new MaterialState `color` property to all the chips (this makes it possible to customize chips in all states from the M3 specs).
2. Updated defaults to use the new MaterialState `color` property.
3. Updated and added new tests to all the chip test classes.
<details>
<summary>code sample</summary>
```dart
import 'package:flutter/material.dart';
const Color disabledColor = Colors.black26;
const Color backgroundColor = Colors.cyan;
final Color disabledSelectedColor = Colors.red.shade100;
const Color selectedColor = Colors.amber;
final MaterialStateProperty<Color> color =
MaterialStateProperty.resolveWith((Set<MaterialState> states) {
if (states.contains(MaterialState.disabled) &&
states.contains(MaterialState.selected)) {
return disabledSelectedColor;
}
if (states.contains(MaterialState.disabled)) {
return disabledColor;
}
if (states.contains(MaterialState.selected)) {
return selectedColor;
}
return backgroundColor;
});
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
useMaterial3: true,
// chipTheme: ChipThemeData(color: color),
),
home: const Example(),
);
}
}
class Example extends StatefulWidget {
const Example({super.key});
@override
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
bool enabled = false;
bool selected = true;
@override
Widget build(BuildContext context) {
const Widget verticalSpace = SizedBox(height: 20);
return Scaffold(
body: Center(
child: Column(
children: <Widget>[
const SizedBox(height: 25),
Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
const Card(
elevation: 0.0,
color: disabledColor,
child: Padding(
padding: EdgeInsets.all(8.0),
child: Text('disabledColor'),
),
),
const Card(
elevation: 0.0,
color: backgroundColor,
child: Padding(
padding: EdgeInsets.all(8.0),
child: Text('backgroundColor'),
),
),
Card(
elevation: 0.0,
color: disabledSelectedColor,
child: const Padding(
padding: EdgeInsets.all(8.0),
child: Text('disabledSelectedColor'),
),
),
const Card(
elevation: 0.0,
color: selectedColor,
child: Padding(
padding: EdgeInsets.all(8.0),
child: Text('selectedColor'),
),
),
],
),
const Spacer(),
Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Column(
mainAxisSize: MainAxisSize.min,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
RawChip(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('RawChip'),
isEnabled: enabled,
onSelected: enabled ? (bool value) {} : null,
),
verticalSpace,
InputChip(
isEnabled: enabled,
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('InputChip'),
onSelected: enabled ? (bool value) {} : null,
),
],
),
Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
FilterChip(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('FilterChip'),
onSelected: enabled ? (bool value) {} : null,
),
verticalSpace,
FilterChip.elevated(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('FilterChip.elevated'),
onSelected: enabled ? (bool value) {} : null,
),
],
),
Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
ChoiceChip(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('ChoiceChip'),
onSelected: enabled ? (bool value) {} : null,
),
verticalSpace,
ChoiceChip.elevated(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('ChoiceChip.elevated'),
onSelected: enabled ? (bool value) {} : null,
),
],
),
],
),
const Spacer(),
Row(
children: <Widget>[
Flexible(
child: SwitchListTile(
title: const Text('Enabled'),
value: enabled,
onChanged: (bool value) {
setState(() => enabled = value);
},
),
),
Flexible(
child: SwitchListTile(
title: const Text('Selected'),
value: selected,
onChanged: (bool value) {
setState(() => selected = value);
},
),
),
],
)
],
),
),
);
}
}
```
</details>
### Before (not possible to customize disabled and selected chips)
### After (using disabled and selected chips using the new MaterialState `color` property)
2023-06-19 22:03:26 +00:00
engine-flutter-autoroll
62a1c8ee62
Roll Flutter Engine from 280491d4cc21 to 23a2c246600f (8 revisions) ( #129140 )
...
280491d4cc...23a2c24660skia-flutter-autoroll@skia.org Roll Skia from 455d7306b951 to 41689ff01f97 (1 revision) (flutter/engine#42983 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d07173415e8 to 60adb12ffc30 (1 revision) (flutter/engine#42982 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fgS2avQGq4x_sbZHU... to lG2K667BLaS_haUZg... (flutter/engine#42981 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from c90c7dec5c18 to 455d7306b951 (1 revision) (flutter/engine#42980 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from d182b694a670 to c90c7dec5c18 (1 revision) (flutter/engine#42979 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from b2ec326cc4f3 to 3d07173415e8 (1 revision) (flutter/engine#42978 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from 24f2336d87f2 to d182b694a670 (2 revisions) (flutter/engine#42977 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from BuzniDS9u_hdghV5f... to gX0QkT_dMBCTbiAHY... (flutter/engine#42976 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fgS2avQGq4x_ to lG2K667BLaS_
fuchsia/sdk/core/mac-amd64 from BuzniDS9u_hd to gX0QkT_dMBCT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 20:52:10 +00:00
Jason Simmons
03d50d1f8a
Fix an ordering dependency in the flutter_tools upgrade test ( #129131 )
...
Cache.flutterRoot is set within testUsingContext and will be
uninitialized the first time test suite setup is invoked.
2023-06-19 11:18:16 -07:00
engine-flutter-autoroll
323c296922
Roll Flutter Engine from 164c6b49dfb5 to 280491d4cc21 (1 revision) ( #129102 )
...
164c6b49df...280491d4ccskia-flutter-autoroll@skia.org Roll Skia from f489be63a30a to 24f2336d87f2 (1 revision) (flutter/engine#42975 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 07:24:11 +00:00
Taha Tesser
165d237792
Fix InputDecoration.applyDefaults ignoring some properties ( #129010 )
...
fixes [`InputDecoration.applyDefaults` ignores some properties](https://github.com/flutter/flutter/issues/127330 )
<details>
<summary>code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(useMaterial3: true),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
const TextStyle textStyle = TextStyle(color: Color(0xFF00FFFF));
const Color color = Color(0xFF00FF00);
const InputBorder inputBorder = OutlineInputBorder(
borderSide: BorderSide(
color: Color(0xFF0000FF),
),
);
final InputDecoration appliedDefaults =
const InputDecoration().applyDefaults(
const InputDecorationTheme(
labelStyle: textStyle,
floatingLabelStyle: textStyle,
helperStyle: textStyle,
helperMaxLines: 2,
hintStyle: textStyle,
errorStyle: textStyle,
errorMaxLines: 2,
floatingLabelBehavior: FloatingLabelBehavior.never,
floatingLabelAlignment: FloatingLabelAlignment.center,
isDense: true,
contentPadding: EdgeInsets.all(1.0),
iconColor: color,
prefixStyle: textStyle,
prefixIconColor: color,
suffixStyle: textStyle,
suffixIconColor: color,
counterStyle: textStyle,
filled: true,
fillColor: color,
focusColor: color,
hoverColor: color,
errorBorder: inputBorder,
focusedBorder: inputBorder,
focusedErrorBorder: inputBorder,
disabledBorder: inputBorder,
enabledBorder: inputBorder,
border: InputBorder.none,
alignLabelWithHint: true,
constraints: BoxConstraints(
minWidth: 10, maxWidth: 20, minHeight: 30, maxHeight: 40),
),
);
return Scaffold(
appBar: AppBar(
title: const Text('InputDecoration().applyDefaults'),
),
// Centered FilledButton.
body: Center(
child: SingleChildScrollView(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ColoredBox(
color: appliedDefaults.labelStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.labelStyle.toString()),
),
ColoredBox(
color: appliedDefaults.floatingLabelStyle
.toString()
.contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.floatingLabelStyle.toString()),
),
ColoredBox(
color: appliedDefaults.helperStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.helperStyle.toString()),
),
ColoredBox(
color: appliedDefaults.hintStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.hintStyle.toString()),
),
ColoredBox(
color: appliedDefaults.errorStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.errorStyle.toString()),
),
ColoredBox(
color: appliedDefaults.iconColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.iconColor.toString()),
),
ColoredBox(
color: appliedDefaults.prefixStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.prefixStyle.toString()),
),
ColoredBox(
color:
appliedDefaults.prefixIconColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.prefixIconColor.toString()),
),
ColoredBox(
color: appliedDefaults.suffixStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.suffixStyle.toString()),
),
ColoredBox(
color:
appliedDefaults.suffixIconColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.suffixIconColor.toString()),
),
ColoredBox(
color: appliedDefaults.counterStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.counterStyle.toString()),
),
ColoredBox(
color: appliedDefaults.fillColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.fillColor.toString()),
),
ColoredBox(
color: appliedDefaults.focusColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.focusColor.toString()),
),
ColoredBox(
color: appliedDefaults.hoverColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.hoverColor.toString()),
),
ColoredBox(
color: appliedDefaults.errorBorder.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.errorBorder.toString()),
),
ColoredBox(
color: appliedDefaults.focusedBorder.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.focusedBorder.toString()),
),
ColoredBox(
color: appliedDefaults.focusedErrorBorder
.toString()
.contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.focusedErrorBorder.toString()),
),
ColoredBox(
color:
appliedDefaults.disabledBorder.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.disabledBorder.toString()),
),
ColoredBox(
color: appliedDefaults.enabledBorder.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.enabledBorder.toString()),
),
ColoredBox(
color: appliedDefaults.border.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.border.toString()),
),
ColoredBox(
color: appliedDefaults.constraints.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.constraints.toString()),
),
],
),
),
),
);
}
}
```
</details>
### Before
### After
2023-06-19 07:06:19 +00:00
engine-flutter-autoroll
59e30ef421
Roll Flutter Engine from d298f0bf720c to 164c6b49dfb5 (1 revision) ( #129100 )
...
d298f0bf72...164c6b49dfskia-flutter-autoroll@skia.org Roll Dart SDK from 5a9e97eebbed to b2ec326cc4f3 (1 revision) (flutter/engine#42974 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 05:45:11 +00:00
