13236 Commits

Author SHA1 Message Date
Jonah Williams
2acf6fdb6b
Outline for survey implementation (#27305) 2019-02-20 15:28:28 -08:00
Dan Field
d492d7165a
Manual engine roll to (#28222)
flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter/engine#7886)
flutter/engine@dad6ec01c Correct onAccessibilityFeaturesChanged docs (flutter/engine#7883)
flutter/engine@fc1a68ea1 Roll src/third_party/skia e0a6a048bc4a..7738736f9622 (4 commits) (flutter/engine#7884)
flutter/engine@a150cc125 Fix minor typos in accessibility action docs (flutter/engine#7882)
flutter/engine@bf1654450 Roll src/third_party/skia 249a25730521..e0a6a048bc4a (2 commits) (flutter/engine#7881)
flutter/engine@d60ef0c36 Roll src/third_party/skia ce62dec02293..249a25730521 (15 commits) (flutter/engine#7879)
flutter/engine@1263d28ab Fix caret being at left edge when newline pressed on centered text (flutter/engine#7875)
2019-02-20 14:19:30 -08:00
Michael Goderbauer
fbafe64fd7
Fix 'to to' (#28216) 2019-02-20 09:57:42 -08:00
Dan Field
dd23be3936
Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560 (#28178)
* Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560

* update goldens

* update goldens version
2019-02-19 21:35:31 -08:00
engine-flutter-autoroll
035e0765cc
f37b09a11 [fuchsia][SCN-1054] Map elevation onto -Z in Scenic (flutter/engine#7834) (#28036)
163a2fd5e1...f37b09a11b

git log 163a2fd5e140d10a30645e73031054ef39105d87..f37b09a11b281b2a4e5dfcb45029069c3ac6e460 --no-merges --oneline
f37b09a11 [fuchsia][SCN-1054] Map elevation onto -Z in Scenic (flutter/engine#7834)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2019-02-16 01:48:28 -05:00
engine-flutter-autoroll
85c045c8dc
Roll engine 033f2072c315..163a2fd5e140 (26 commits) (#28035)
033f2072c3...163a2fd5e1

git log 033f2072c315d48b4d7680d4cbbe856012b1259b..163a2fd5e140d10a30645e73031054ef39105d87 --no-merges --oneline
163a2fd5e Revert "Android embedding refactor pr3 add remaining systemchannels (#7738)" (flutter/engine#7849)
0d6ff1669 Shut down and restart the Dart VM as needed. (flutter/engine#7832)
256db4bc2 Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7738)
02d7ca31d Don't call static method from instance variable (flutter/engine#7841)
10cee612b Delete GL textures when they are released from the texture registry. (flutter/engine#7836)
69e460607 Fix NullPointerException in SurfaceTextureRegistryEntry (flutter/engine#7837)
9a965bc3d Fix NullPointerException in ResourceCleaner (flutter/engine#7838)
2acd79480 Add fml::FileExists implementation for Windows (flutter/engine#7845)
fa38a985c Update buildroot to 7f64ff4928e to unblock Mac builds. (flutter/engine#7846)
1ba329550 Add support for calling into other plugins from a background context on iOS (flutter/engine#7843)
df2fc973a Roll src/third_party/skia 154acd7a1374..be9aff25bddc (13 commits) (flutter/engine#7842)
0ca1d1f31 Remove the Dart JIT snapshot data from AOT builds of the embedder library (flutter/engine#7806)
c51ea4157 Roll src/third_party/skia 7a74c7cb6da0..154acd7a1374 (1 commits) (flutter/engine#7840)
ecbaea10a Ensure to pass dill file after VM options for gen_snapshot (flutter/engine#7839)
5d3f7145a Roll src/third_party/skia b00f7b34751b..7a74c7cb6da0 (1 commits) (flutter/engine#7835)
733739938 Roll src/third_party/skia 9a88bee122f1..b00f7b34751b (24 commits) (flutter/engine#7831)
6f318efe0 Move up ndk version that is being downloaded(old one no longer available) (flutter/engine#7830)
a8aa1ee06 Track flow id (flutter/engine#7826)
b1ce6b72f Roll src/third_party/skia a0dcd29f536b..9a88bee122f1 (4 commits) (flutter/engine#7825)
dbc166387 Roll src/third_party/skia 6152470dc69e..a0dcd29f536b (2 commits) (flutter/engine#7824)
942677695 Roll src/third_party/skia 4037f7f5d8b4..6152470dc69e (1 commits) (flutter/engine#7823)
e2394ad77 Add flow events connecting pointer events to frames (flutter/engine#7807)
0a5a7c56d Roll src/third_party/skia 09c01e9df260..4037f7f5d8b4 (3 commits) (flutter/engine#7821)
b867f4858 Roll src/third_party/skia 186669c4128b..09c01e9df260 (5 commits) (flutter/engine#7820)
af39e22c3 Fix tests that were committed after cirrus ran (flutter/engine#7819)
1f2cbf792 Roll src/third_party/dart 0a7dcf17eb..c92d5ca288 (64 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2019-02-15 23:32:28 -05:00
Stanislav Baranov
20d9de58d0
Revert "Add support for binary compression of dynamic patches by the flutter tool. (#27754)" (#28031)
This reverts commit b47da6c2b79d90f33d73e9225b4b3bbbd0ffd99e.
2019-02-15 18:43:36 -08:00
Dan Field
c90c3a18a2
Reland automatic discovery of observatory port for iOS (#27908)
* Discover port over mDNS 

* Update BUILD.gn for tools
2019-02-15 17:44:55 -08:00
liyuqian
7390cc5cdb
Increase our build budget to 16ms (#27709)
Because we now have 2 separate GPU and UI threads.
2019-02-15 16:12:36 -08:00
KyleWong
f9a6090082 Refactor local engine logic (#27765)
* Refactor for iOS.

* For android_xxx_unopt_arm64&ios_xxx_unopt_arm, remove the _arm64/_arm suffix.
dart generated in host_xxx_unopt/host_xxx has an arch of x86_64 which supports arm64/arm.

* Remove suffixes for various archs.
2019-02-15 15:56:49 -08:00
Jason Simmons
b6996ef326 Disable prefer_collection_literals in the analyzer until we can update to using set literals (#28024) 2019-02-15 15:54:16 -08:00
Hans Muller
19f79ac8da
Add extendBody parameter to Scaffold, body MediaQuery reflects BAB height (#27973) 2019-02-15 14:48:39 -08:00
Jonah Williams
c8c67b79c3
remove accidentally commited libs (#28011) 2019-02-15 11:59:23 -08:00
jslavitz
07fdfb70d3
Fixes switch vibration (#27900)
* Fixes Cupertino switch vibration
2019-02-15 10:55:06 -08:00
Gary Qian
29618f0b04
Roll engine for flutter/engine#7791 - Add trailing whitespace tracking. 2019-02-15 10:28:21 -08:00
Kate Lovett
70dfe01a15
Sample code for Icon class (#27968)
* Added sample code for a simple Icon, ref: #21136

* Removed duplicate line.

* Fixed incoreect parameter.

* Update icon.dart

Removed empty prose and added better context for sample code. Changed sample code for better visibility in execution of default app themes.

* Alas, Trailing space.

Nixed trailing space in comments.
2019-02-15 10:24:14 -08:00
Michael Goderbauer
a4de06ade0
Reapply "Fix overflow clipping/fading for text (#27892)" (#27980)
Fixes https://github.com/flutter/flutter/issues/25025
2019-02-15 09:37:33 -08:00
Todd Volkert
3b47b44348
Re-apply "Ensure all curves return 0 and 1 in .transform(t) when t=0/1" (#28006)
Re-applies #27409 by reverting #27919

The analyzer issue (dart-lang/sdk#35940) has been temporarily
worked around by virtue of #27929
2019-02-15 12:29:09 -05:00
Greg Spencer
dff25a3055
Fix Dashing rules to use new dartdoc CSS entity markers. (#27818)
This fixes the offline Dash/Zeal docs generation to use the newly added dartdoc markers for different entity types to make it more exact when finding entity names.

Bumped Dartdoc to the next release.
2019-02-15 08:40:19 -08:00
Todd Volkert
cb1c7a3664
Ensure that Dart SDK dirs have appropriate permissions (#26315)
This is a partial re-application of #24669

https://github.com/flutter/flutter/issues/24413
2019-02-15 11:03:57 -05:00
Greg Spencer
262f12b4a9
Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793)
This converts all remaining "## Sample code" segments into snippets, and fixes
the snippet generator to handle multiple snippets in the same dartdoc block
properly.

I also generated, compiled, and ran each of the existing application samples,
and fixed them up to be more useful and/or just run without errors.

This PR fixes these problems with examples:

1. Switching tabs in a snippet now works if there is more than one snippet in
   a single dartdoc block.
2. Generation of snippet code now works if there is more than one snippet.
3. Contrast of text and links in the code sample block has been improved to
   recommended levels.
4. Added five new snippet templates, including a "freeform" template to make
   it possible to show examples that need to change the app instantiation.
5. Fixed several examples to run properly, a couple by adding the "Scaffold"
   widget to the template, a couple by just fixing their code.
6. Fixed visual look of some of the samples when they run by placing many
   samples inside of a Scaffold.
7. In order to make it easier to run locally, changed the sample analyzer to
   remove the contents of the supplied temp directory before running, since
   having files that hang around is problematic (only a problem when running
   locally with the `--temp` argument).
8. Added a `SampleCheckerException` class, and handle sample checking
   exceptions more gracefully.
9. Deprecated the old "## Sample code" designation, and added enforcement for
   the deprecation.
10. Removed unnecessary `new` from templates (although they never appeared in
   the samples thanks to dartfmt, but still).

Fixes #26398
Fixes #27411
2019-02-15 07:48:49 -08:00
Martin Kustermann
7862bef13a
Use double literals where a double type is expected (#27929)
This makes the code more consistent but also fixes our flutter-analyze bot.

Issue https://github.com/dart-lang/sdk/issues/35940
2019-02-15 14:10:55 +01:00
Jonah Williams
67cf21577f
Add basic codegen app to be used for integration testing and benchmarks (#27257) 2019-02-14 23:17:16 -08:00
Jonah Williams
3205736fcf
add ui.Window fallback to TestViewConfiguration (#27987) 2019-02-14 22:49:49 -08:00
Jonah Williams
9bc5656637
Wire dart2js through flutter tool, add compilation test (#27668) 2019-02-14 22:42:30 -08:00
xster
8661d8aecd
Test text paint orders by color (#27983) 2019-02-14 19:19:53 -08:00
xster
22f8880909
Make sure the selection is still painted under the text (#27970) 2019-02-14 16:50:06 -08:00
Anthony
d1371cd269 Do not draw Slider tick marks if they are too dense (#27969) 2019-02-14 16:42:30 -08:00
Michael Goderbauer
d1707ab0ad
Revert "Fix overflow clipping/fading for text (#27892)" (#27966)
This reverts commit 46cabdab22ce59ba06949d666216ae4d10b76761.
2019-02-14 15:15:01 -08:00
KyleWong
e99c881f8d
Don't cache result for homeDirPath. (#27873) 2019-02-14 16:08:26 +08:00
engine-flutter-autoroll
da5c97c3ef
Roll engine d48de7a3ec97..3757390fa4b0 (17 commits) (#27907)
d48de7a3ec...3757390fa4

git log d48de7a3ec97ebf7ffe543aa74993efa51064789..3757390fa4b00d2d261bfdf5182d2e87c9113ff9 --no-merges --oneline
3757390fa Roll src/third_party/dart ecd7a88606..0a7dcf17eb (4 commits)
61d3080d5 Add FFI to libraries.yaml. (flutter/engine#7811)
f5259b8e2 Roll src/third_party/skia b6f53783337e..186669c4128b (8 commits) (flutter/engine#7816)
816921b9e Use newer Skia API for PathMeasure (flutter/engine#7809)
da56ff9c6 Roll src/third_party/skia 94a5328e0e4b..b6f53783337e (8 commits) (flutter/engine#7812)
04fbc2545 Roll src/third_party/skia 66f09a72995a..94a5328e0e4b (1 commits) (flutter/engine#7810)
347d690b2 Add support for new Scenic clip planes. (flutter/engine#7804)
309b90ca5 Roll src/third_party/skia 14d64dd4c47c..66f09a72995a (8 commits) (flutter/engine#7805)
1dead52a8 Roll src/third_party/skia 0b6ae6386d34..14d64dd4c47c (10 commits) (flutter/engine#7802)
74d94e52c Revert "Use all font managers to discover fonts for strut. (#7734)" (flutter/engine#7801)
769016c88 Roll src/third_party/skia 63d477cd99b0..0b6ae6386d34 (9 commits) (flutter/engine#7798)
f7eb3cb20 Roll src/third_party/skia 217acf58d0d8..63d477cd99b0 (1 commits) (flutter/engine#7797)
c4a55552b Use all font managers to discover fonts for strut. (flutter/engine#7734)
17b7d1e0a Roll src/third_party/dart 754e5f404c..ecd7a88606 (8 commits)
b4ed8cff3 Roll src/third_party/skia 233fc0b03c02..217acf58d0d8 (1 commits) (flutter/engine#7795)
27ab9f7af Roll src/third_party/skia 454e5fb7457d..233fc0b03c02 (4 commits) (flutter/engine#7794)
c58f5fefe Roll src/third_party/dart fdfe40ea95..754e5f404c (13 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2019-02-14 02:47:29 -05:00
Todd Volkert
4309fe863a
Revert "Ensure all curves return 0 and 1 in .transform(t) when t=0/1 (#27409)" (#27919)
This reverts commit d8cd2ff484c7799db0a7ed01f1a448dba14e6cec.
2019-02-14 02:20:35 -05:00
Jonah Williams
537b592ed5 fix multiroot scheme (#27914) 2019-02-13 23:17:28 -05:00
Todd Volkert
f1a8eed083
Revert "Clean up matters related to "offstageness". (#27425)" (#27915)
This reverts commit 1d93e924b7a1b4611de74537eba4f2bf25a4d0cf.
2019-02-13 20:58:41 -05:00
Tim Traversy
2cbd050f92 Adding horizontal and vertical scale parameter to ScaleUpdateDetails. (#27752) 2019-02-13 15:51:22 -08:00
Dan Field
ed4e3da360
update packages and supress lint (#27902) 2019-02-13 15:45:20 -08:00
Ian Hickson
1d93e924b7
Clean up matters related to "offstageness". (#27425)
In particular, make debugVisitOnstageChildren only work in debug mode, and add documentation.
2019-02-13 15:36:47 -08:00
Alexander Aprelev
8de5a07c3f
Revert "Disable usage of bare instructions in AOT (#27410)" (#27789)
This reverts commit 965dc52e2e86158a983e502ecfbac07ee29035f4 as performance gains seems to outweigh compressed apk size increase.
2019-02-13 15:29:50 -08:00
Marco Scannadinari
d8cd2ff484 Ensure all curves return 0 and 1 in .transform(t) when t=0/1 (#27409) 2019-02-13 15:17:42 -08:00
Michael Goderbauer
46cabdab22
Fix overflow clipping/fading for text (#27892) 2019-02-13 13:49:00 -08:00
Tim Traversy
f372eb37e6 DatePicker noon/midnight overflow fix (#27773) 2019-02-13 13:03:12 -08:00
Kartik Sharma
b4adafac08 Fixed Cupertino Switch Demo (#27528) 2019-02-13 12:43:08 -08:00
jslavitz
1196dbe94a
Fixes a cursor offset mistake for Material on iOS (#27851)
* Fixes offset and unblocks roll
2019-02-13 12:25:25 -08:00
Jonah Williams
a5af29e83c
Revert "Lazily download artifacts (Part II) (#27735)" (#27895)
This reverts commit 76061c4fa95b94a8e6462eb360aa1e7456cc0de3.
2019-02-13 11:59:51 -08:00
Jonah Williams
76061c4fa9
Lazily download artifacts (Part II) (#27735) 2019-02-13 11:04:28 -08:00
Hans Muller
16fd0eb512
Add Armenian translations (#27865) 2019-02-13 08:35:26 -08:00
KyleWong
4b4a9400b7 Refactor build-number/build-name logic. (#27743)
This PR aims at several things:

1. Use pub_semver to check a version in pubspec.yaml meets the requirements specified in https://semver.org/.
2. Don't limit build-number/build-name as a fixed format. Instead, validate it according to the target(ios/android).
3. Make sure that build-number/build-name are always validated no matter it's specified by the `flutter command` or version in pubspec.yaml.

Fixes #27589
2019-02-13 07:48:03 -08:00
KyleWong
f2004b8f43
Add android studio process logic for JetBrainsToolbox (#27687)
* Make plugin path search logic use version check as a fallback.

* In JetBrainsToolbox, Info.plist would be just some kind of wrapper, we need a double check before get the real one.

* Use Regex to get content instead of `default command` to avoid error output as there could be no JetBrainsToolboxApp key/value for a normal Info.plist(Android Studio.)
2019-02-13 15:05:20 +08:00
KyleWong
199ebaa677 Refactor ios bundleid/android application process logic. (#27471)
When creating a flutter project,
Make sure: applicationid for android conforms to: https://developer.android.com/studio/build/application-id

Make sure: bundleid for ios conforms to:
https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/understanding_utis/understand_utis_conc/understand_utis_conc.html
(Not only the name,but also the organization, as it's a check for whole bundleid.)
2019-02-12 19:40:53 -08:00
Greg Spencer
ef9c059ef2
Hook up character events and unmodified code points to Android raw key event handling. (#27853)
This makes Android raw key event handling use the "character" data coming from the engine properly, and gets rid of the "toLowerCase" hack that I was using to normalize logical key events, in favor of using the new "plainCodePoint" that has the unmodified code point (the code point as if no modifier keys were pressed).
2019-02-12 19:40:19 -08:00