Loïc Sharma
e7a1b68086
[SwiftPM] Add separate feature flag for the app migration ( #158897 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
### Overview
This splits the Swift Package Manager feature in two:
1. **SwiftPM feature**: This builds plugins using SwiftPM (if the app
supports it), and, uses the new app & plugin templates that support
SwiftPM
2. **SwiftPM app migration feature**: this updates an existing Flutter
iOS or macOS app to support Swift Package Manager. This feature requires
the SwiftPM feature - if SwiftPM is off, the app migration is also off.
For now, both features are off by default. We plan to turn on the first
feature in the next stable release. The app migration feature will be
stay off by default until we have higher confidence in the migration.
See this mini design doc:
https://github.com/flutter/flutter/issues/151567#issuecomment-2455941279
Here's the PR that updates the SwiftPM docs:
https://github.com/flutter/website/pull/11495
Part of https://github.com/flutter/flutter/issues/151567
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2025-01-07 19:46:03 +00:00
Chinmay Garde
8273197bc7
[Impeller] Update README on preview status on Android. ( #161253 )
2025-01-07 19:43:53 +00:00
Matan Lurey
e3b301f23d
Stamp golden files to verify engine Skia Gold is WAI. ( #161240 )
...
Auto-generated by `dart testing/skia_gold_client/tool/generate.dart`.
This is just to make sure that everything is working after the recent
configuration.
2025-01-07 18:23:39 +00:00
Bartek Pacia
fc261a103b
Fix broken link to Hot Reload gif in README ( #161113 )
...
Something looked off in the README.
2025-01-07 18:20:21 +00:00
Matan Lurey
986fd14363
Fold _FlutterTestRunnerImpl into FlutterTestRunner. ( #161188 )
...
Closes https://github.com/flutter/flutter/issues/160461 .
This pattern is covered by `interface class { ... }` in modern Dart.
See <https://dart.dev/language/class-modifiers#interface >.
2025-01-07 18:11:29 +00:00
Gray Mackall
f3d2204827
[Android] Add .cxx directories to app template .gitignore ( #161069 )
...
Fixes (but I still need to write the draft of the blog section so don't
autoclose github 🙏 ) https://github.com/flutter/flutter/issues/160372 .
-Module templates [already exclude the entire `.android`
directory](d9b7e56646/packages/flutter_tools/templates/module/common/.gitignore.tmpl (L40)d9b7e56646/packages/flutter_tools/templates/plugin_shared/android.tmpl/.gitignore27ba2f2790/packages/flutter_tools/templates/app/android.tmpl/.gitignorehttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com>
Co-authored-by: Greg Price <gnprice@gmail.com>
2025-01-07 18:09:49 +00:00
jesswrd
481950d3a2
Improve Plugins That Reference V1 Embedding Error Message ( #160890 )
...
Improved the error message that appears when using plugins that
reference v1 embedding. The new error message explains why the error
appears and how to fix it.
Fixes #160204
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
2025-01-07 18:06:08 +00:00
Martin Anderson
e7e5b1c87a
Update PopInvokedCallback Deprecated message ( #160324 )
...
I might be mistaken, but it seems like there's an error in the
`pop_scope.dart` file. Instead of `PopWithResultInvokedCallback`, it has
`PopInvokedWithResultCallback`.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-01-07 18:06:08 +00:00
Jenn Magder
0cc590860d
Mark platform_channel_sample_test_macos unflaky ( #160989 )
...
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/151883 was closed.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-07 17:56:06 +00:00
Jenn Magder
b71247dcab
Migrate engine labeler to top level ( #161212 )
...
Hoist engine/src/flutter/.github/labeler.yml to top-level labeler.
2025-01-07 17:56:05 +00:00
Jenn Magder
ff27e4a583
Mark analyzer_benchmark unflaky ( #160991 )
...
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/158243 was closed.
2025-01-07 17:56:05 +00:00
Devon Carew
e30bf85231
use uuid from package:uuid instead of from package:usage ( #161102 )
...
- use uuid from package:uuid instead of from package:usage
`package:usage` is discontinued and no longer maintained; this removes
one use of it from the flutter_tools codebase.
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
See also:
- https://github.com/flutter/flutter/pull/152692
- https://github.com/dart-archive/usage
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-07 17:33:23 +00:00
Jackson Gardner
bb4628e0f0
Scale any clip path by 1 / DPR. ( #161190 )
...
When applying a clip path, we need to scale it by the DPR in order for
it to be placed and sized correctly.
This addresses https://github.com/flutter/flutter/issues/157603
2025-01-07 16:41:27 +00:00
Matan Lurey
e66e04f39f
Remove verbose: true from canvas_test.dart. ( #161211 )
...
General cleanup after https://github.com/flutter/flutter/issues/157206 .
2025-01-07 16:23:52 +00:00
Reid Baker
b552906977
Set java 11 as expected java version in all templates ( #160349 )
...
Bump templates from java 8 to java 11.
fixes https://github.com/flutter/flutter/issues/156111
I want to talk to @gmackall before merging to talk through the
consequences.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
2025-01-07 15:27:23 +00:00
Matan Lurey
cda3515126
Use flutter repo for engine golds instead of flutter-engine. ( #160556 )
...
Closes https://github.com/flutter/flutter/issues/157206 .
I also added a `prefix` that will default to `engine.` to avoid
accidentally stomping on golden names across repos.
/cc @gaaclarke for visibility, @Piinks for visibility.
(I would love to get rid of this "engine copy" of the client as part of
longer-term mono repo deduplication).
2025-01-07 03:37:36 +00:00
Matan Lurey
95c1bc1c3e
[Engine] Make SkiaGoldClient a NOP when the branch is not main or master. ( #161187 )
...
Unblocks https://github.com/flutter/flutter/pull/160556 .
Currently the merge queue runs in post-submit mode, which looks for (and
fails to find) digests for PRs that have not yet been submitted,
blocking the engine goldens from being enabled/checked in
https://github.com/flutter/flutter/pull/160556 . This PR is a proposal to
fix that by skipping the tests.
We might decide instead that tests should not be running in the merge
queue at all, in which case we will _not_ merge this PR and will change
how the merge queue works instead. Otherwise this PR is a proof of
concept of [aligning implementations with the
framework](a9b3f6c042/packages/flutter_goldens/lib/flutter_goldens.dart (L338)
2025-01-07 01:38:52 +00:00
Matan Lurey
bb805fad1e
Rename shellPath to flutterTesterBinPath. ( #161189 )
...
Closes https://github.com/flutter/flutter/issues/160462 .
Maybe there are people who consider `flutter_tester` as the flutter
"shell", but this is more explicit.
2025-01-07 00:52:45 +00:00
Jonah Williams
434ca754e3
[Impeller] dont generate final 1x1 mip level to work around Adreno GPU bug ( #161192 )
...
Generating the final 1x1 mip level of a texture causes the entire
texture to become corrupted on some Adreno GPUs.
https://github.com/flutter/flutter/issues/160441
https://github.com/flutter/flutter/issues/159876
https://github.com/flutter/flutter/issues/160587
2025-01-07 00:44:52 +00:00
Matan Lurey
16b9fe049d
TestCompiler emits why an error occurred, if applicable, and some refactors to do so (#160984 )
...
Closes https://github.com/flutter/flutter/issues/160218 .
Basically, replaces `String?` with `sealed class TestCompilerResult {}`,
and ensures `errorMessage` is propogated.
We'll be using this path now for _all_ integration tests (not just for
web-specific things), so I'd like to get error messages.
2025-01-07 00:20:50 +00:00
gaaclarke
4f35112363
Updated eglConfigChoose error message and error clause. ( #161178 )
...
fixes https://github.com/flutter/flutter/issues/160806
- The error message will never say success anymore.
- The error clause is slightly more permissive. If this resolves the
issue though, the driver for the emulator has a bug in it since it
shouldn't return `success` and zero configs. It's probably just
indicating that it successfully found zero apropos configs.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-07 00:07:21 +00:00
Kate Lovett
7141c2a136
Update golden canary ( #161183 )
...
Verifying the framework golden workflow
Part of resolving https://github.com/flutter/flutter/pull/160556
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-06 22:47:29 +00:00
Matan Lurey
5a23a2a3c4
Remove now-unnecessary command felt analyze. ( #160986 )
...
Closes https://github.com/flutter/flutter/issues/154143 .
The entire engine sub-repo is now checked for Dart analysis issues, so a
separate command is not needed.
2025-01-06 21:43:47 +00:00
Jenn Magder
18163e3695
Mark flavors_test_macos unflaky ( #160990 )
...
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/156943 was closed.
2025-01-06 21:24:50 +00:00
Jenn Magder
8d60e7e74a
Update GitHub URL for failing android_semantics_integration_test bringup ( #160993 )
...
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/124636 was fixed with
https://github.com/flutter/flutter/pull/127128 . However it wasn't, and
is now failing on a legit behavior change the test caught.
The test is now failing due to
https://github.com/flutter/flutter/issues/153594 , and if this test
hadn't been marked flaky the commit in question would closed the tree
and been reverted.
2025-01-06 21:16:56 +00:00
Jenn Magder
938dcdadfd
Mark firebase_release_smoke_test unflaky ( #161006 )
...
`firebase_release_smoke_test` was [marked
flaky](https://github.com/flutter/flutter/pull/147338 ) due to a firebase
outage in April.
`firebase_android_embedding_v2_smoke_test` was deleted with
https://github.com/flutter/flutter/pull/158223 .
`firebase_abstract_method_smoke_test` was deleted with #159145
Closes https://github.com/flutter/flutter/issues/147335 .
2025-01-06 21:15:46 +00:00
Jenn Magder
fbb7807fb4
Update Create Pull Request GitHub workflow reviewers ( #161005 )
...
Update reviewer.
I didn't know this existed until I saw
https://github.com/flutter/flutter/pull/161001 .
Introduced https://github.com/flutter/flutter/pull/140363 . Tested
credentials are used in the cherry-pick bot:
3762f2e973/.github/workflows/easy-cp.yml (L69)
2025-01-06 21:15:43 +00:00
Jonah Williams
ffc7ced2a0
[Impeller] protect onscreen cmd buffer with render ready semaphore. ( #161140 )
...
Ensures that the onscreen command buffer is blocked via the render ready
semaphore, instead of just the layout transition. I can confirm this
fixes the rendering artifacts on the Samsung a50 - which I suspect are
the same as the issues these other devices are having. Essentially,
without the semaphore protecting the onscreen pass we can end up writing
to the color attachment while it is still being read.
* https://github.com/flutter/flutter/issues/160522
* https://github.com/flutter/flutter/issues/160370
2025-01-06 20:26:08 +00:00
Matan Lurey
a9b3f6c042
Update flutter_template_images to 5.0.0. ( #161105 )
...
Closes https://github.com/flutter/flutter/issues/160692 .
All references of `skeleton` and `app_shared` have been completely
removed, including in `flutter_template_images`.
See https://github.com/flutter/packages/pull/8360 .
2025-01-06 20:15:07 +00:00
Devon Carew
f00de04113
update repo to be forward compatible with shelf_web_socket v3.0 ( #161101 )
...
- update the engine and flutter_tools to be forward compatible with the
upcoming shelf_web_socket v3.0
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
- https://github.com/dart-lang/shelf/issues/457
- https://github.com/dart-lang/shelf/pull/463
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-06 19:51:49 +00:00
engine-flutter-autoroll
dff62dc5ce
Roll Packages from eb7358231e43 to 07ae98c5aff9 (29 revisions) ( #161174 )
...
eb7358231e...07ae98c5afflutter/packages#8371 )
2025-01-05 32538273+ValentinVignal@users.noreply.github.com
[google_maps_flutter] Activate leak testing (flutter/packages#8368 )
2025-01-05 32538273+ValentinVignal@users.noreply.github.com
[flutter_markdown] Fix some memory leaks and activate leak testing
[prod-leak-fix] (flutter/packages#8367 )
2025-01-03 36674458+WenHaozhan@users.noreply.github.com [image_picker]
Removes use of PHAsset on IOS 14+ (flutter/packages#8190 )
2025-01-03 matanlurey@users.noreply.github.com Delete unused templates
`skeleton` and `app_shared` and release as `5.0.0`.
(flutter/packages#8360 )
2025-01-02 stuartmorgan@google.com [tool] Ensure that
leak_tracker_flutter_testing is dev-only (flutter/packages#8365 )
2025-01-02 stuartmorgan@google.com [pigeon] Discuss stability in README
(flutter/packages#8366 )
2025-01-02 tarrinneal@gmail.com [shared_preferences] Add information
about shared preferences android to docs (flutter/packages#8296 )
2024-12-30 mchudy@users.noreply.github.com [camera] Remove OCMock from
permission tests (flutter/packages#8350 )
2024-12-29 kevmoo@users.noreply.github.com Drop vector bits from
allowed_unpinned_deps.yaml (flutter/packages#8327 )
2024-12-28 32538273+ValentinVignal@users.noreply.github.com [camera] Fix
memory leaks in example and activate leak testing
(flutter/packages#8287 )
2024-12-27 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds
platform for imports that aren't support on a platform
(flutter/packages#8338 )
2024-12-26 jessiewong401@gmail.com Bump Plugin Example Apps to
TargetSdkVersion >= 34 (flutter/packages#8285 )
2024-12-26 matanlurey@users.noreply.github.com Re-create
`templates/app`, add deprecation notices for `app_shared` and
`skeleton`. (flutter/packages#8336 )
2024-12-26 jessiewong401@gmail.com Update Gradle Command Test to Only
Accept Gradle Declarative Apply (flutter/packages#8325 )
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.guava:guava from 33.3.1-android to
33.4.0-android in /packages/camera/camera_android_camerax/android
(flutter/packages#8331 )
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump camerax_version from 1.3.4 to 1.4.1 in
/packages/camera/camera_android_camerax/android (flutter/packages#8330 )
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump com.google.truth:truth, com.google.code.gson:gson,
com.squareup.okhttp3:okhttp in /packages/espresso/android
(flutter/packages#8089 )
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[image_picker]: Bump androidx.activity:activity from 1.9.2 to 1.9.3 in
/packages/image_picker/image_picker_android/android
(flutter/packages#7897 )
2024-12-23 ditman@gmail.com [ci] Cumulative fixes to reopen the tree.
(flutter/packages#8344 )
2024-12-18 magder@google.com Group dependabot updates for some gradle
dependencies (flutter/packages#8100 )
2024-12-18 jessiewong401@gmail.com Applied Gradle Plugins Declaratively
All Remaining Example Apps (flutter/packages#8312 )
2024-12-18 49699333+dependabot[bot]@users.noreply.github.com
[lifecycle]: Bump androidx.annotation:annotation from 1.7.0 to 1.9.1 in
/packages/flutter_plugin_android_lifecycle/android
(flutter/packages#7974 )
2024-12-18 stuartmorgan@google.com [ci] Re-enable macOS sandboxing
(flutter/packages#8293 )
2024-12-18 49699333+dependabot[bot]@users.noreply.github.com [espresso]:
Bump com.android.tools.build:gradle from 7.4.1 to 8.7.2 in
/packages/espresso/android (flutter/packages#8013 )
2024-12-18 reidbaker@google.com [shared_preferences] Increase minimum
android endorsed version (flutter/packages#8318 )
2024-12-17 stuartmorgan@google.com Revert "[shared_preferences] Add
shared preferences devtools" (flutter/packages#8314 )
2024-12-16 adson@soraschools.com [shared_preferences] Add shared
preferences devtools (flutter/packages#6749 )
2024-12-16 ditman@gmail.com [google_adsense] Add optional init
parameters. (flutter/packages#8297 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-06 19:51:12 +00:00
Matan Lurey
5aa179eb04
Remove the word normalized, remove minimum/maximum. ( #161106 )
...
Post-submit feedback from
https://github.com/flutter/flutter/pull/160798#pullrequestreview-2527860035 .
2025-01-06 19:51:12 +00:00
Matan Lurey
351f2742af
Add SurfaceProducer.onSurfaceCleanup, deprecate onSurfaceDestroyed. ( #160937 )
...
Closes https://github.com/flutter/flutter/issues/160933 .
The timing of this callback gives our users (and plugin authors) a
chance to stop using the `Surface` before it becomes invalid, allowing
us to fix https://github.com/flutter/flutter/issues/156488 - we no
longer need to do shenanigans on storing and restoring state because
`ExoPlayer` can now handle it out of the box; see
https://github.com/flutter/flutter/issues/160933#issuecomment-2564092567 .
It's unfortunate we have to go through a bit of churn on the callback
API, but realistically this _is_ the feedback we were looking for when
originally creating it - it just took longer than expected due to the
long release cycle.
/cc @hasali19, @xxoo, @camsim99
2025-01-06 18:03:11 +00:00
Devon Carew
6d729b6d1d
rev to the latest dart-lang/http and remove older http_multi_server refs ( #161067 )
...
- rev to the latest dart-lang/http and remove older refs to
dart-lang/http_multi_server
This updates the combined flutter+engine repo to account for upstream
repo merges (package:http_multi_server ==> dart-lang/http).
Main tracking issue:
- https://github.com/dart-lang/sdk/issues/56591
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-06 17:37:16 +00:00
Matan Lurey
0c3359df8c
Omit hardcoded --packages=.dart_tool/package_config.json. ( #160982 )
...
Closes https://github.com/flutter/flutter/issues/160219 .
This hard-coded package configuration is no longer strictly correct
as-of Dart 3.6.0; a pub _workspace_
(https://dart.dev/tools/pub/workspaces ) can appear at a higher-level
than a package, and if the package is part of the workspace, tooling is
expected to (automatically) find `.dart_tool/package_config.json` at a
higher-level.
For example, the _engine_ sub-repo uses a
[workspace](9fd5bddc65/engine/src/flutter/pubspec.yaml (L82)
2025-01-06 16:25:30 +00:00
Daco Harkes
a6c057c406
[native_assets] Filter hook environment ( #161084 )
...
Follow up of https://github.com/flutter/flutter/pull/160672 to filter
the environment keys being passed in to build hooks.
~~Failures don't reproduce locally, so this is a draft PR to see which
environment keys are needed for the tests to succeed on CI.~~
Edit: Fixed issues by stopping to use the
Flutter-self-update-dart-executable and instead using the
Dart-sdk-dart-executable.
Relevant bug (already addressed in Dart standalone).
* https://github.com/dart-lang/native/issues/32
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-06 13:05:31 +00:00
Jackson Gardner
2d17299f20
Use the in-tree engine by default when using --local-engine or --local-web-sdk ( #161110 )
...
Now that we're in a monorepo, it makes sense to use the in-tree engine
by default when using `--local-engine` or `--local-web-sdk` rather than
looking for a sibling directory like we used to.
2025-01-04 00:42:37 +00:00
Michael Goderbauer
dbf9e32879
Bump characters, collection, meta ( #161066 )
...
Follow-up to https://github.com/flutter/flutter/pull/160985 .
These were missed by `flutter update-packages --force-upgrade` in
https://github.com/flutter/flutter/pull/160985 , likely due to some
circular dependency issue. They've been bumped by hand in this PR.
2025-01-03 02:23:10 +00:00
Daco Harkes
27ba2f2790
[native assets] Roll dependencies ( #160672 )
...
This PR rolls in a number of breaking changes from dart-lang/native:
* `BuildMode` is no longer part of the protocol, so Flutter no longer
passes it in.
* This means all code dealing with the name conflict between
`native_assets_cli.BuildMode` and `flutter_tools.BuildMode` has been
cleaned up.
* Also, the logs no longer mention the build mode.
* The tests still exercise both modes, because linking only happens in
release mode.
* `OS` is no longer part of the main protocol, but of the "code"
"protocol extension".
* The code now aligns more with `OS?` being nullable in a bunch of
places, since it is nullable if there's no code assets.
* The OS-specific config is nested in an object per OS.
* `CCompilerConfig`s fields are non-nullable now.
* So instead of passing an object with nullable fields around, a null
instead of the object is returned in various places.
* `FileSystem` is now passed in to the native assets builder.
This PR contains no feature changes.
This PR will need to be followed up by restricting what environment
variables are passed in (similar to
https://github.com/dart-lang/native/pull/1764 ), I will do this in a
follow up PR.
Tests:
* All existing features should be covered by existing tests.
2025-01-02 19:26:02 +00:00
Michael Goderbauer
d9b7e56646
Manual pub bump ( #160985 )
...
Since the autoroller is currently disabled (due to
https://github.com/flutter/flutter/issues/160473 ) this does a manual
roll of our dependencies to ensure that we don't fall too far behind.
2024-12-31 04:07:34 +00:00
dependabot[bot]
0b074a5c34
Bump peter-evans/create-pull-request from 7.0.5 to 7.0.6 in the all-github-actions group ( #161001 )
...
Bumps the all-github-actions group with 1 update:
[peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request ).
Updates `peter-evans/create-pull-request` from 7.0.5 to 7.0.6
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/peter-evans/create-pull-request/releases ">peter-evans/create-pull-request's
releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v7.0.6</h2>
<p>⚙️ Fixes an issue with commit signing where unicode characters in
file paths were not preserved.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@vercel/ncc</code> from 0.38.1 to
0.38.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3365 ">peter-evans/create-pull-request#3365</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot "><code>@actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3370 ">peter-evans/create-pull-request#3370</a></li>
<li>build(deps): bump
<code>@octokit/plugin-rest-endpoint-methods</code> from 13.2.4 to
13.2.5 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3375 ">peter-evans/create-pull-request#3375</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.50 to
18.19.54 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3376 ">peter-evans/create-pull-request#3376</a></li>
<li>build(deps): bump <code>@octokit/plugin-paginate-rest</code> from
11.3.3 to 11.3.5 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3377 ">peter-evans/create-pull-request#3377</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot "><code>@actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3388 ">peter-evans/create-pull-request#3388</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.54 to
18.19.55 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3400 ">peter-evans/create-pull-request#3400</a></li>
<li>build(deps): bump <code>@actions/core</code> from 1.10.1 to 1.11.1
by <a href="https://github.com/dependabot "><code>@dependabot</code></a>
in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3401 ">peter-evans/create-pull-request#3401</a></li>
<li>build(deps): bump
<code>@octokit/plugin-rest-endpoint-methods</code> from 13.2.5 to
13.2.6 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3403 ">peter-evans/create-pull-request#3403</a></li>
<li>build(deps-dev): bump eslint-plugin-import from 2.30.0 to 2.31.0 by
<a href="https://github.com/dependabot "><code>@dependabot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3402 ">peter-evans/create-pull-request#3402</a></li>
<li>build(deps): bump <code>@octokit/plugin-throttling</code> from
9.3.1 to 9.3.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3404 ">peter-evans/create-pull-request#3404</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot "><code>@actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3423 ">peter-evans/create-pull-request#3423</a></li>
<li>build(deps-dev): bump typescript from 5.6.2 to 5.6.3 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3441 ">peter-evans/create-pull-request#3441</a></li>
<li>build(deps): bump undici from 6.19.8 to 6.20.1 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3442 ">peter-evans/create-pull-request#3442</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot "><code>@actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3451 ">peter-evans/create-pull-request#3451</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.55 to
18.19.58 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3457 ">peter-evans/create-pull-request#3457</a></li>
<li>build(deps-dev): bump <code>@types/jest</code> from 29.5.13 to
29.5.14 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3462 ">peter-evans/create-pull-request#3462</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.58 to
18.19.60 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3463 ">peter-evans/create-pull-request#3463</a></li>
<li>chore: don't bundle undici by <a
href="https://github.com/benmccann "><code>@benmccann</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3475 ">peter-evans/create-pull-request#3475</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot "><code>@actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3478 ">peter-evans/create-pull-request#3478</a></li>
<li>chore: use node-fetch-native support for proxy env vars by <a
href="https://github.com/peter-evans "><code>@peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3483 ">peter-evans/create-pull-request#3483</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.60 to
18.19.64 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3488 ">peter-evans/create-pull-request#3488</a></li>
<li>build(deps-dev): bump undici from 6.20.1 to 6.21.0 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3499 ">peter-evans/create-pull-request#3499</a></li>
<li>build(deps-dev): bump <code>@vercel/ncc</code> from 0.38.2 to
0.38.3 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3500 ">peter-evans/create-pull-request#3500</a></li>
<li>docs: note <code>push-to-repo</code> classic PAT
<code>workflow</code> scope requirement by <a
href="https://github.com/scop "><code>@scop</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3511 ">peter-evans/create-pull-request#3511</a></li>
<li>docs: spelling fixes by <a
href="https://github.com/scop "><code>@scop</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3512 ">peter-evans/create-pull-request#3512</a></li>
<li>build(deps-dev): bump typescript from 5.6.3 to 5.7.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3516 ">peter-evans/create-pull-request#3516</a></li>
<li>build(deps-dev): bump prettier from 3.3.3 to 3.4.0 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3517 ">peter-evans/create-pull-request#3517</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.64 to
18.19.66 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3518 ">peter-evans/create-pull-request#3518</a></li>
<li>docs(README): clarify that an existing open PR is managed by <a
href="https://github.com/caugner "><code>@caugner</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3498 ">peter-evans/create-pull-request#3498</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot "><code>@actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3529 ">peter-evans/create-pull-request#3529</a></li>
<li>build(deps): bump <code>@octokit/plugin-paginate-rest</code> from
11.3.5 to 11.3.6 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3542 ">peter-evans/create-pull-request#3542</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.66 to
18.19.67 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3543 ">peter-evans/create-pull-request#3543</a></li>
<li>build(deps-dev): bump prettier from 3.4.0 to 3.4.1 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3544 ">peter-evans/create-pull-request#3544</a></li>
<li>build(deps-dev): bump eslint-import-resolver-typescript from 3.6.3
to 3.7.0 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3559 ">peter-evans/create-pull-request#3559</a></li>
<li>build(deps-dev): bump prettier from 3.4.1 to 3.4.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3560 ">peter-evans/create-pull-request#3560</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.67 to
18.19.68 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3570 ">peter-evans/create-pull-request#3570</a></li>
<li>build(deps): bump p-limit from 6.1.0 to 6.2.0 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3578 ">peter-evans/create-pull-request#3578</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot "><code>@actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3583 ">peter-evans/create-pull-request#3583</a></li>
<li>fix: preserve unicode in filepaths when commit signing by <a
href="https://github.com/peter-evans "><code>@peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3588 ">peter-evans/create-pull-request#3588</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/benmccann "><code>@benmccann</code></a>
made their first contribution in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3475 ">peter-evans/create-pull-request#3475</a></li>
<li><a href="https://github.com/scop "><code>@scop</code></a> made their
first contribution in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3511 ">peter-evans/create-pull-request#3511</a></li>
<li><a href="https://github.com/caugner "><code>@caugner</code></a> made
their first contribution in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3498 ">peter-evans/create-pull-request#3498</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="67ccf781d6https://redirect.github.com/peter-evans/create-pull-request/issues/3588 ">#3588</a>)</li>
<li><a
href="bb88e27d3fhttps://redirect.github.com/peter-evans/create-pull-request/issues/3583 ">#3583</a>)</li>
<li><a
href="b378ed537ahttps://redirect.github.com/peter-evans/create-pull-request/issues/3578 ">#3578</a>)</li>
<li><a
href="fa9200e5b4https://redirect.github.com/peter-evans/create-pull-request/issues/3570 ">#3570</a>)</li>
<li><a
href="16e0059bfdhttps://redirect.github.com/peter-evans/create-pull-request/issues/3560 ">#3560</a>)</li>
<li><a
href="5bffd5ae80https://redirect.github.com/peter-evans/create-pull-request/issues/3559 ">#3559</a>)</li>
<li><a
href="a22a0ddc21https://redirect.github.com/peter-evans/create-pull-request/issues/3544 ">#3544</a>)</li>
<li><a
href="b27ce378c8https://redirect.github.com/peter-evans/create-pull-request/issues/3543 ">#3543</a>)</li>
<li><a
href="4e0cc19e22https://redirect.github.com/peter-evans/create-pull-request/issues/3542 ">#3542</a>)</li>
<li><a
href="25b6871a4e5e914681df...67ccf781d6https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=7.0.5&new-version=7.0.6 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-30 23:05:26 +00:00
Matan Lurey
3762f2e973
Revert: "Move integration_test dependencies to non-dev_dependencies." ( #160980 )
...
Reverts flutter/flutter#160380 ; this ended up not being needed.
Closes https://github.com/flutter/flutter/issues/160379 .
2024-12-30 19:03:33 +00:00
Michael Goderbauer
ec66fe4669
Fix docImport issues ( #160918 )
...
Work towards https://github.com/flutter/flutter/issues/150800
2024-12-30 18:31:41 +00:00
Alex Li
9fd5bddc65
🐛 [tool] Installs the APK regardless of version ( #160432 )
...
Resolves https://github.com/flutter/flutter/issues/160402
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-30 02:26:27 +00:00
Yegor
01971467ef
Point to real Cocoon code in Tree-hygiene.md ( #160914 )
...
Point to real Cocoon code in Tree-hygiene.md
Co-authored-by: Matan Lurey <matanlurey@users.noreply.github.com>
2024-12-28 19:54:22 +00:00
Matan Lurey
4cd0e33013
Implement golden-file matching for integration_test on Android and iOS devices ( #160484 )
...
Work towards https://github.com/flutter/flutter/issues/143299 .
Work towards https://github.com/flutter/flutter/issues/160043 .
---
This PR implements, end-to-end, support for `matchesGoldenFile` when (a)
running with `package:integration_test` (b) on a device, such as an
Android emulator, Android device, iOS simulator, or iOS device, where
the _runner_ of a test file does not have process and local-file system
access.
There are multiple parts to this PR; I could make it smaller than 1K
lines, but the bulk of that is tests, and it would mean landing PRs that
are incomplete and unused, which does not seem useful - so instead here
is a quick overview of the PR's contents - questions/feedback welcome,
and I am willing to break code out or land incremental refactors if
requested.
1. Augmented `flutter_platform.dart` (used for iOS and Android), similar
to
[`flutter_web_platform.dart`](1398dc7eec/packages/flutter_tools/lib/src/test/flutter_web_platform.dart (L117-L128)https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/test/test_golden_comparator.dart )
to proxy calls (coming from the VM service protocol) for golden-file
updates and comparisons to a `flutter_tester` process. A full
explanation of how (or why) it works this way is too hard to include
here, but see https://github.com/flutter/flutter/pull/160215 for more
details.
1. Added `VmServiceProxyGoldenFileComparator`, which is a currently
unused (outside of a single e2e test) comparator that forwards calls to
`compare` and `update` to the VM service protocol (of which, the other
side of this is implemented above, in `flutter_platform.dart`. The idea
is that this comparator would be used automatically when running in an
integration test on a device that requires it (similar to how web works
today), but that is **not** wired up yet and requires additional work in
`flutter_tools`.
1. Added two unit tests (of both the client and server), and a full
e2e-test using it to run `matchesGoldenFile`.
2024-12-28 19:48:20 +00:00
LongCatIsLooong
b15625ca92
Turn deprecation message analyze tests back on ( #160554 )
...
Additionally:
- Deprecation message analyzer: use AST more instead of regex
- Deprecation message analyzer: removes some tests since they are in the
formatter's jurisdiction now
- update the analyzer test fixture to fix a couple line numbers
- `@_debugOnly` set `multiline` back to false. The source we get back
from the `ASTNode` doesn't have any line feed characters.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-27 23:26:24 +00:00
Matan Lurey
840ef1cac8
Update docs on Color to be more clear about normalized channel values. ( #160798 )
...
Closes https://github.com/flutter/flutter/issues/160592 .
~Made a few other tiny non-breaking refactors, for example changing
`withValues` internally.~
2024-12-27 22:17:01 +00:00
Matan Lurey
36e0099c4a
Bump flutter_template_images to remove TODO. ( #160917 )
...
Towards https://github.com/flutter/flutter/issues/160692 .
Prior to `flutter_template_images: 4.3.0`, the `app_shared` directory
was required.
In 4.3.0 it was forked back out to `app`
(https://pub.dev/packages/flutter_template_images/changelog ), as the
`skeleton` template has been removed, and the `skeleton` template was
the (only) reason for `app_shared` (to share code between `app` and
`skeleton`).
This is a NOP change tested by existing tests.
2024-12-27 22:15:54 +00:00
chunhtai
b86154c44e
Clarify where gclient is run from. ( #160889 )
...
If `gclient` is not run from the root errors occur such as: `Error:
client not configured; see 'gclient config'`.
2024-12-27 21:37:24 +00:00
