gaaclarke
e683e1031c
Added special case for fat width arcs ( #161255 )
...
fixes https://github.com/flutter/flutter/issues/158567
This draws arcs as oval sectors when the stroke width is large enough.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-14 16:55:30 +00:00
Matan Lurey
836fd6e567
Replace fetch with gclient sync. ( #161565 )
...
Just continue to remove outdated instructions.
2025-01-14 16:55:08 +00:00
engine-flutter-autoroll
ed9f920662
Roll Packages from 3c3bc6832b39 to d1fd6232ec33 (4 revisions) ( #161597 )
...
3c3bc6832b...d1fd6232ecolli.helenius@codemate.com [camera] Add API support query for
image streaming (flutter/packages#8250 )
2025-01-13 westracer1@gmail.com [webview_flutter_android] Add additional
WebSettings methods (flutter/packages#8270 )
2025-01-13 engine-flutter-autoroll@skia.org Roll Flutter from
864d4f59dde0 to 72db8f69e339 (11 revisions) (flutter/packages#8421 )
2025-01-13 30872003+misos1@users.noreply.github.com
[video_player_avfoundation, camera_avfoundation] never overwrite but
only upgrade audio session category (flutter/packages#7143 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-14 16:13:19 +00:00
Robert Ancell
c9923ca609
Remove unused method ( #161572 )
2025-01-14 14:35:36 +00:00
Harlen Batagelo
f2c15f9deb
Fix crash when closing a window with Alt+F4 in multi-win Flutter on Windows ( #161375 )
...
Reopened from https://github.com/flutter/engine/pull/56501 .
Fixes [#158450 ](https://github.com/flutter/flutter/issues/158450 ).
As mentioned in
[#158450 ](https://github.com/flutter/flutter/issues/158450 ), the crash
occurs because a destroyed object may be accessed if the window and view
have already been destroyed by the time `KeyEventCallback` is called.
This issue is not limited to the `Alt+F4` system key; it may also occur
if the window is closed using other key presses, such as pressing
`Enter` after navigating to a dialog's "Close" button.
This PR proposes a fix that checks whether the view ID is still valid
when the callback is invoked. If the view is invalid, the event is
skipped for that view.
A unit test has been added to assert that the `KeyEventCallback` is
invoked when the associated view is valid and not invoked when the view
is destroyed.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-14 13:32:36 +00:00
Bruno Leroux
e23c31265d
Update InputDecoration.border documentation ( #161415 )
...
## Description
This PR clarifies the InputDecoration.border documentation and fixes two
typos.
## Related Issue
Fixes [[Material] Outline TextFields don't respect
OutlineInputBorder.color](https://github.com/flutter/flutter/issues/31169 )
## Tests
Documentation only
2025-01-14 07:39:39 +00:00
Tong Mu
c16b9c52e4
[Web] Allow specifying the strategy on when to use <img> element to display images ( #159917 )
...
This PR follows the discussion under
https://github.com/flutter/flutter/pull/157755 and adds a flag to
determine when `<img>` elements are used. By default the feature is
turned off.
Instead of just a boolean for on & off, I made it an enum to accept
multiple options. Notably, an `always` option can be useful when the
developer wants a unified experience regardless of the image origin
(such as when displaying an image from arbitrary URLs.)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-14 06:16:18 +00:00
Siva
3f981117eb
Roll Dart to Version 3.7.0-323.0.dev ( #161567 )
...
https://dart.googlesource.com/sdk.git/+log/dbe08d993b3fe700ed716fa068742e8fb80b0a0a..f6ed8d7df6bfdf6fb08b38dd93c2ee1eba476b5a
[f6ed8d7](https://dart.googlesource.com/sdk.git/+/f6ed8d7df6bfdf6fb08b38dd93c2ee1eba476b5a )
[Version
3.7.0-323.0.dev](https://dart.googlesource.com/sdk.git/+/f6ed8d7df6bfdf6fb08b38dd93c2ee1eba476b5a )
by Dart CI · 12 hours ago
[dev](https://dart.googlesource.com/sdk.git/+/refs/heads/dev )
[3.7.0-323.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-323.0.dev )
[8063ed1](https://dart.googlesource.com/sdk.git/+/8063ed194b781f4c44fe7c714b54f49654470ea4 )
[[CFE] Spell checker
improvements](https://dart.googlesource.com/sdk.git/+/8063ed194b781f4c44fe7c714b54f49654470ea4 )
by Jens Johansen · 14 hours ago
[86ff64c](https://dart.googlesource.com/sdk.git/+/86ff64c97d40bdcf5b5dfc114c8ed56540aa341e )
[[CFE] Fix weekly but needing
dart2js_platform_unsound.dill](https://dart.googlesource.com/sdk.git/+/86ff64c97d40bdcf5b5dfc114c8ed56540aa341e )
by Jens Johansen · 14 hours ago
[11a4a94](https://dart.googlesource.com/sdk.git/+/11a4a94b950db8d409c7c6eb7c571282c99ac0ce )
[[infra-ish] Fix compile_flutter.sh after flutter engine was merged into
flutter/flutter](https://dart.googlesource.com/sdk.git/+/11a4a94b950db8d409c7c6eb7c571282c99ac0ce )
by Jens Johansen · 15 hours ago
[c075d93](https://dart.googlesource.com/sdk.git/+/c075d939e095307c26986c599f2ecbf6748a0d4e )
[[parser/scanner] Remove ScannerConfig
`enableNonNullable`](https://dart.googlesource.com/sdk.git/+/c075d939e095307c26986c599f2ecbf6748a0d4e )
by Jens Johansen · 16 hours ago
[5dfce91](https://dart.googlesource.com/sdk.git/+/5dfce919cd04bae29ab2c002f1a38a8916ec031f )
[[parser/scanner] Remove ScannerConfig
`enableExtensionMethods`](https://dart.googlesource.com/sdk.git/+/5dfce919cd04bae29ab2c002f1a38a8916ec031f )
by Jens Johansen · 16 hours ago
[1482910](https://dart.googlesource.com/sdk.git/+/1482910747ad63ec1207d30b0d9127419f9b9f08 )
[Version
3.7.0-322.0.dev](https://dart.googlesource.com/sdk.git/+/1482910747ad63ec1207d30b0d9127419f9b9f08 )
by Dart CI · 28 hours ago
[3.7.0-322.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-322.0.dev )
[7d8c34c](https://dart.googlesource.com/sdk.git/+/7d8c34c42532eb2b6fc3dbda221fb5cb2063b95b )
[[analyzer] Refine type of
`InterfaceTypeImpl.element`](https://dart.googlesource.com/sdk.git/+/7d8c34c42532eb2b6fc3dbda221fb5cb2063b95b )
by Paul Berry · 32 hours ago
[2229972](https://dart.googlesource.com/sdk.git/+/2229972ec5d89c1d5abba1f369d7d6e1ba8cc98c )
[Version
3.7.0-321.0.dev](https://dart.googlesource.com/sdk.git/+/2229972ec5d89c1d5abba1f369d7d6e1ba8cc98c )
by Dart CI · 2 days ago
[3.7.0-321.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-321.0.dev )
[bdf8c21](https://dart.googlesource.com/sdk.git/+/bdf8c213fe7a53987046dc2fa1d675e3b24ca9d8 )
[[analyzer] Use Impl types in
TypeProviderImpl.](https://dart.googlesource.com/sdk.git/+/bdf8c213fe7a53987046dc2fa1d675e3b24ca9d8 )
by Paul Berry · 2 days ago
[adcc212](https://dart.googlesource.com/sdk.git/+/adcc21238329cb5fc70b0601b4784f05d2bc314a )
[[analyzer] Changes related to
ExecutableElementImpl._parameters.](https://dart.googlesource.com/sdk.git/+/adcc21238329cb5fc70b0601b4784f05d2bc314a )
by Paul Berry · 2 days ago
[f585c17](https://dart.googlesource.com/sdk.git/+/f585c1743efe450b89d4a69cd53fa427c72e1fdd )
[Version
3.7.0-320.0.dev](https://dart.googlesource.com/sdk.git/+/f585c1743efe450b89d4a69cd53fa427c72e1fdd )
by Dart CI · 3 days ago
[3.7.0-320.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-320.0.dev )
[082be8f](https://dart.googlesource.com/sdk.git/+/082be8f4eaf445167d15a95bdde611a9eabde1fa )
[Version
3.7.0-319.0.dev](https://dart.googlesource.com/sdk.git/+/082be8f4eaf445167d15a95bdde611a9eabde1fa )
by Dart CI · 3 days ago
[3.7.0-319.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-319.0.dev )
[8bbe6fb](https://dart.googlesource.com/sdk.git/+/8bbe6fbdfe03e31ac6773114140cd9565d88052a )
[Elements. Report analyzer_use_new_elements without any txt file, add
file
ignores.](https://dart.googlesource.com/sdk.git/+/8bbe6fbdfe03e31ac6773114140cd9565d88052a )
by Konstantin Shcheglov · 3 days ago
[dc37a77](https://dart.googlesource.com/sdk.git/+/dc37a77cf7f0f92dca6b6b595aa66a930935131b )
[[ddc] Add rejection for removed const
fields](https://dart.googlesource.com/sdk.git/+/dc37a77cf7f0f92dca6b6b595aa66a930935131b )
by Nicholas Shahan · 3 days ago
[9a47293](https://dart.googlesource.com/sdk.git/+/9a472930e5100baf0efb2d33369b7fd473b92951 )
[[_fe_analyzer_shared] Renames to prepare for analyzer
refactoring.](https://dart.googlesource.com/sdk.git/+/9a472930e5100baf0efb2d33369b7fd473b92951 )
by Paul Berry · 3 days ago
[357a919](https://dart.googlesource.com/sdk.git/+/357a91908bbf0f71c147ea387339380c26ca8950 )
[Version
3.7.0-318.0.dev](https://dart.googlesource.com/sdk.git/+/357a91908bbf0f71c147ea387339380c26ca8950 )
by Dart CI · 3 days ago
[3.7.0-318.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-318.0.dev )
[11d24d6](https://dart.googlesource.com/sdk.git/+/11d24d6d55a71656be6874218809e7007aeac589 )
[Elements. TypeParameterElementImpl2.name3 is
nullable.](https://dart.googlesource.com/sdk.git/+/11d24d6d55a71656be6874218809e7007aeac589 )
by Konstantin Shcheglov · 3 days ago
[f91050c](https://dart.googlesource.com/sdk.git/+/f91050ca91a9f07263b1db78706258e88d967054 )
[[ddc] Add visitor for hot reload
deltas](https://dart.googlesource.com/sdk.git/+/f91050ca91a9f07263b1db78706258e88d967054 )
by Nicholas Shahan · 3 days ago
[ef771d4](https://dart.googlesource.com/sdk.git/+/ef771d49537c79fccb1364ecbeca35f58116f30a )
[[tests] Enum shorthands - Import
prefixes.](https://dart.googlesource.com/sdk.git/+/ef771d49537c79fccb1364ecbeca35f58116f30a )
by Kallen Tu · 3 days ago
[912ffda](https://dart.googlesource.com/sdk.git/+/912ffda5ec8fb44472b76a353ca43f150cd36bbc )
[Version
3.7.0-317.0.dev](https://dart.googlesource.com/sdk.git/+/912ffda5ec8fb44472b76a353ca43f150cd36bbc )
by Dart CI · 3 days ago
[3.7.0-317.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-317.0.dev )
[0577ca0](https://dart.googlesource.com/sdk.git/+/0577ca064d9f782bd44918645cf93487e63990a2 )
[[Migrate]
error_reporter_test.dart](https://dart.googlesource.com/sdk.git/+/0577ca064d9f782bd44918645cf93487e63990a2 )
by Brian Wilkerson · 3 days ago
[04ab58b](https://dart.googlesource.com/sdk.git/+/04ab58b31902c83d4858e7f70000992ac7dbd518 )
[Version
3.7.0-316.0.dev](https://dart.googlesource.com/sdk.git/+/04ab58b31902c83d4858e7f70000992ac7dbd518 )
by Dart CI · 4 days ago
[3.7.0-316.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-316.0.dev )
[5862859](https://dart.googlesource.com/sdk.git/+/5862859ad86dccc4166416d4b98f133a7d28c9e4 )
[[co19] Roll co19 to
2424cfed7eedf53a122f8bfdbb6319692f726ec8](https://dart.googlesource.com/sdk.git/+/5862859ad86dccc4166416d4b98f133a7d28c9e4 )
by Sergey G. Grekhov · 4 days ago
[d704828](https://dart.googlesource.com/sdk.git/+/d704828c3461ad408c47800588fb802136f66bc7 )
[[dart2wasm] Use Uint8List for representing
bytes](https://dart.googlesource.com/sdk.git/+/d704828c3461ad408c47800588fb802136f66bc7 )
by Martin Kustermann · 4 days ago
[5d3d965](https://dart.googlesource.com/sdk.git/+/5d3d965cd357eb89c1f979a683147ff64eff70f4 )
[[dart2wasm] Use Function.prototype.call.bind(Number.prototype.toString)
for small ints and
doubles](https://dart.googlesource.com/sdk.git/+/5d3d965cd357eb89c1f979a683147ff64eff70f4 )
by Martin Kustermann · 4 days ago
[4bcd8c2](https://dart.googlesource.com/sdk.git/+/4bcd8c2b8ce56756dbe7dd762af7f9322a777402 )
[[vm/compiler] Prune SSA during construction using
liveness](https://dart.googlesource.com/sdk.git/+/4bcd8c2b8ce56756dbe7dd762af7f9322a777402 )
by Vyacheslav Egorov · 4 days ago
[c95568a](https://dart.googlesource.com/sdk.git/+/c95568aede3f26fda36b58b081ec697a74960815 )
[[CFE] Fuzzer using
Dart.G](https://dart.googlesource.com/sdk.git/+/c95568aede3f26fda36b58b081ec697a74960815 )
by Jens Johansen · 4 days ago
[b022eca](https://dart.googlesource.com/sdk.git/+/b022ecae7070d5e345f55f730799cd229868a85a )
[[CFE] Fix crash in
_computeOnClause](https://dart.googlesource.com/sdk.git/+/b022ecae7070d5e345f55f730799cd229868a85a )
by Jens Johansen · 4 days ago
[feb770f](https://dart.googlesource.com/sdk.git/+/feb770fdf16f87ea920c633e194b65d0db284729 )
[Version
3.7.0-315.0.dev](https://dart.googlesource.com/sdk.git/+/feb770fdf16f87ea920c633e194b65d0db284729 )
by Dart CI · 4 days ago
[3.7.0-315.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-315.0.dev )
[0c103f1](https://dart.googlesource.com/sdk.git/+/0c103f10398d6b0980a24d5a1a2cf8046f81fe21 )
[Elements. Use TypeParameterElementImpl in
TypeParameterizedElementMixin.](https://dart.googlesource.com/sdk.git/+/0c103f10398d6b0980a24d5a1a2cf8046f81fe21 )
by Konstantin Shcheglov · 4 days ago
[05e5306](https://dart.googlesource.com/sdk.git/+/05e53068f9e0b9056e47d10066cf11bf499afac8 )
[Version
3.7.0-314.0.dev](https://dart.googlesource.com/sdk.git/+/05e53068f9e0b9056e47d10066cf11bf499afac8 )
by Dart CI · 4 days ago
[3.7.0-314.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-314.0.dev )
[92ef752](https://dart.googlesource.com/sdk.git/+/92ef75281059f0f837fa27be9d721c6410243002 )
[[dynamic-modules] Add pragma annotating implicitly extendable
types.](https://dart.googlesource.com/sdk.git/+/92ef75281059f0f837fa27be9d721c6410243002 )
by Nate Biggs · 4 days ago
[2de8b5e](https://dart.googlesource.com/sdk.git/+/2de8b5efb0f8da71cc8add9a9cbd246817eb8f7e )
[Elements. Migrate
lib/src/utilities/navigation/navigation_dart.dart](https://dart.googlesource.com/sdk.git/+/2de8b5efb0f8da71cc8add9a9cbd246817eb8f7e )
by Konstantin Shcheglov · 4 days ago
[4be4ec7](https://dart.googlesource.com/sdk.git/+/4be4ec7d364984b658d99cc308e00d57d5660df3 )
[Elements. Migrate
AnalyzerConverter.](https://dart.googlesource.com/sdk.git/+/4be4ec7d364984b658d99cc308e00d57d5660df3 )
by Konstantin Shcheglov · 4 days ago
[5f24674](https://dart.googlesource.com/sdk.git/+/5f24674138b78a744250b518257e3d9940b6c416 )
[[element model] migrate
`elements_base`](https://dart.googlesource.com/sdk.git/+/5f24674138b78a744250b518257e3d9940b6c416 )
by pq · 4 days ago
[e4ce6e2](https://dart.googlesource.com/sdk.git/+/e4ce6e28d5d4fb886bd32fafc717e178e2685134 )
[Drop pkg:js from "Web (Legacy)" docs
section](https://dart.googlesource.com/sdk.git/+/e4ce6e28d5d4fb886bd32fafc717e178e2685134 )
by Kevin Moore · 4 days ago
[75882f9](https://dart.googlesource.com/sdk.git/+/75882f9bf73337aaef2fd73bc44a38332e6aa9b7 )
[Elements. Migrate
CompletionTarget.](https://dart.googlesource.com/sdk.git/+/75882f9bf73337aaef2fd73bc44a38332e6aa9b7 )
by Konstantin Shcheglov · 4 days ago
[26d9167](https://dart.googlesource.com/sdk.git/+/26d91675f92fb9116d3351660978e4d9b7fedb98 )
[Elements. Migrate ElementSuggestionBuilder and
related.](https://dart.googlesource.com/sdk.git/+/26d91675f92fb9116d3351660978e4d9b7fedb98 )
by Konstantin Shcheglov · 4 days ago
[7d5f0a6](https://dart.googlesource.com/sdk.git/+/7d5f0a650819da939bdfda8797852d5f7d18b6a7 )
[DAS: Simplify fields in
AnalysisServer](https://dart.googlesource.com/sdk.git/+/7d5f0a650819da939bdfda8797852d5f7d18b6a7 )
by Sam Rawlins · 4 days ago
[7cbec89](https://dart.googlesource.com/sdk.git/+/7cbec8916d37f17b23e0eb03d6aa215989b9043a )
[DAS: Privatize and finalize fields in
AbstractNotificationManager](https://dart.googlesource.com/sdk.git/+/7cbec8916d37f17b23e0eb03d6aa215989b9043a )
by Sam Rawlins · 4 days ago
[d8fd208](https://dart.googlesource.com/sdk.git/+/d8fd208a79f3ce7675693c1089b1a3152b797429 )
[Elements. Migrate
test/src/utilities/change_builder/change_builder_dart_test.dart](https://dart.googlesource.com/sdk.git/+/d8fd208a79f3ce7675693c1089b1a3152b797429 )
by Konstantin Shcheglov · 4 days ago
[4356eac](https://dart.googlesource.com/sdk.git/+/4356eacd87d9a3a6a51beffc4d73261cee3d819e )
[Elements. Migrate lib/utilities/completion/suggestion_builder.dart and
required.](https://dart.googlesource.com/sdk.git/+/4356eacd87d9a3a6a51beffc4d73261cee3d819e )
by Konstantin Shcheglov · 4 days ago
[81b1313](https://dart.googlesource.com/sdk.git/+/81b13136aa05000b07b553280533a99d1dcbda36 )
[analyzer: rename docImports to docLibraryImports in a few
places](https://dart.googlesource.com/sdk.git/+/81b13136aa05000b07b553280533a99d1dcbda36 )
by Sam Rawlins · 4 days ago
[83db399](https://dart.googlesource.com/sdk.git/+/83db3996f769f0993d174830c02aee9bd1fbd736 )
[[dart2js] Fix DictionaryTypeMask hashCode and ==
consistency.](https://dart.googlesource.com/sdk.git/+/83db3996f769f0993d174830c02aee9bd1fbd736 )
by Nate Biggs · 4 days ago
[85727ca](https://dart.googlesource.com/sdk.git/+/85727caf2a163d13aed673ccfd4e4eebb9b6526d )
[[element model] migrate
`least_greatest_closure`](https://dart.googlesource.com/sdk.git/+/85727caf2a163d13aed673ccfd4e4eebb9b6526d )
by pq · 4 days ago
[2766858](https://dart.googlesource.com/sdk.git/+/2766858fba19783eefd682fffedee8e0953bdb6e )
[Elements. Migrate
lib/utilities/change_builder/change_builder_dart.dart](https://dart.googlesource.com/sdk.git/+/2766858fba19783eefd682fffedee8e0953bdb6e )
by Konstantin Shcheglov · 4 days ago
[1790fb7](https://dart.googlesource.com/sdk.git/+/1790fb7908d5079daebdaec31b628fa3c242e955 )
[DAS: Fix comment references in
refactoring/](https://dart.googlesource.com/sdk.git/+/1790fb7908d5079daebdaec31b628fa3c242e955 )
by Sam Rawlins · 4 days ago
[66624da](https://dart.googlesource.com/sdk.git/+/66624dadb5482697105269e780e51f27def663b6 )
[Elements. Update ExecutableElementImpl.parameters to return
List<ParameterElementImpl>.](https://dart.googlesource.com/sdk.git/+/66624dadb5482697105269e780e51f27def663b6 )
by Konstantin Shcheglov · 4 days ago
[1eee8ba](https://dart.googlesource.com/sdk.git/+/1eee8bae3ad4f22d0683e3ce548d9c25365fde6e )
[[ DDS ] Allow for vm_service >=14.0.0 <16.0.0 for package:dds and
package:dds_service_extensions](https://dart.googlesource.com/sdk.git/+/1eee8bae3ad4f22d0683e3ce548d9c25365fde6e )
by Ben Konyi · 4 days ago
[9ab2316](https://dart.googlesource.com/sdk.git/+/9ab2316d32ad5fced73c6716b0b0cde9a55c2138 )
[refactor dartdev
deps](https://dart.googlesource.com/sdk.git/+/9ab2316d32ad5fced73c6716b0b0cde9a55c2138 )
by Devon Carew · 4 days ago
[2b1f956](https://dart.googlesource.com/sdk.git/+/2b1f956207c7ceac3723ff0b088503bffa4fe490 )
[[element model] migrate
`driver`](https://dart.googlesource.com/sdk.git/+/2b1f956207c7ceac3723ff0b088503bffa4fe490 )
by pq · 4 days ago
[f8f10b8](https://dart.googlesource.com/sdk.git/+/f8f10b84076e8628b893a158cc32585c75dd4176 )
[[dart2wasm] Add annotations to member and static
intrinsics.](https://dart.googlesource.com/sdk.git/+/f8f10b84076e8628b893a158cc32585c75dd4176 )
by Nate Biggs · 4 days ago
[3202683f](https://dart.googlesource.com/sdk.git/+/3202683fe47541d71721a73e592d1174ad28c317 )
[Version
3.7.0-313.0.dev](https://dart.googlesource.com/sdk.git/+/3202683fe47541d71721a73e592d1174ad28c317 )
by Dart CI · 4 days ago
[3.7.0-313.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-313.0.dev )
[f49c620](https://dart.googlesource.com/sdk.git/+/f49c620ab34d13ead00fa3bb98b651f8db44484e )
[[analyzer][cfe] Share inference-using-bounds
routines](https://dart.googlesource.com/sdk.git/+/f49c620ab34d13ead00fa3bb98b651f8db44484e )
by Chloe Stefantsova · 5 days ago
[a6b99af](https://dart.googlesource.com/sdk.git/+/a6b99afdeaff69f1ca67baf34c90d47fdc355883 )
[[cfe] Create fields through
SourcePropertyBuilder](https://dart.googlesource.com/sdk.git/+/a6b99afdeaff69f1ca67baf34c90d47fdc355883 )
by Johnni Winther · 5 days ago
[ad562fd](https://dart.googlesource.com/sdk.git/+/ad562fdbbe1a260afbc8aeea8c0bc9dab1f1a2e1 )
[[parser] Rename accidentally committed 'allowLazyFoo'
parameter](https://dart.googlesource.com/sdk.git/+/ad562fdbbe1a260afbc8aeea8c0bc9dab1f1a2e1 )
by Jens Johansen · 5 days ago
[9b631bf](https://dart.googlesource.com/sdk.git/+/9b631bf33362be3bf359896fb4b1aa58a12ea602 )
[[deps] Roll
dart-lang/native](https://dart.googlesource.com/sdk.git/+/9b631bf33362be3bf359896fb4b1aa58a12ea602 )
by Liam Appelbe · 5 days ago
[6a1f9ed](https://dart.googlesource.com/sdk.git/+/6a1f9ed029c7d3c949dbadf0973e688ff7366d75 )
[[analysis_server] Insert new arguments before last child/children
arguments](https://dart.googlesource.com/sdk.git/+/6a1f9ed029c7d3c949dbadf0973e688ff7366d75 )
by Danny Tuppeny · 5 days ago
[e9a6d62](https://dart.googlesource.com/sdk.git/+/e9a6d62fa429d92ab300c16c3e24f05838572bd4 )
[[analysis_server] Return EditableArguments in parameter
order](https://dart.googlesource.com/sdk.git/+/e9a6d62fa429d92ab300c16c3e24f05838572bd4 )
by Danny Tuppeny · 5 days ago
[5d5d223](https://dart.googlesource.com/sdk.git/+/5d5d223b4ae197a312d6254d97846f3a34ad758e )
[linter: fix strict_top_level_inference
registry](https://dart.googlesource.com/sdk.git/+/5d5d223b4ae197a312d6254d97846f3a34ad758e )
by Sam Rawlins · 5 days ago
[302287e](https://dart.googlesource.com/sdk.git/+/302287eed2ec5b8bddfdd90c3af93175f9e87daa )
[[tests] Enum shorthands - Selector chain tests for cascades, ??,
collections and nested
contexts.](https://dart.googlesource.com/sdk.git/+/302287eed2ec5b8bddfdd90c3af93175f9e87daa )
by Kallen Tu · 5 days ago
[b9de4ae](https://dart.googlesource.com/sdk.git/+/b9de4ae02d47ae8fecf385753c5a114643c48062 )
[[CQ] remove trailing whitespace from `unnecessary_underscores_test`
source](https://dart.googlesource.com/sdk.git/+/b9de4ae02d47ae8fecf385753c5a114643c48062 )
by pq · 5 days ago
[c1ce43f](https://dart.googlesource.com/sdk.git/+/c1ce43fd8342d854f841edd6dcd4074326dc9fbf )
[[ddc] Remove unsound dart2js
dependency](https://dart.googlesource.com/sdk.git/+/c1ce43fd8342d854f841edd6dcd4074326dc9fbf )
by Nicholas Shahan · 5 days ago
[b69f6c1](https://dart.googlesource.com/sdk.git/+/b69f6c129480ea14ff16075b346ec1680f894308 )
[[CQ] add missing `scope_util_test` to all test
suite](https://dart.googlesource.com/sdk.git/+/b69f6c129480ea14ff16075b346ec1680f894308 )
by pq · 5 days ago
[edde039](https://dart.googlesource.com/sdk.git/+/edde03955b15c6a38c58fe2637dbc52439cb8686 )
[[element model] migrate
`element_visitors_test`](https://dart.googlesource.com/sdk.git/+/edde03955b15c6a38c58fe2637dbc52439cb8686 )
by pq · 5 days ago
[31d8adf](https://dart.googlesource.com/sdk.git/+/31d8adf1f3b9375e5a7af9fc81f8d28738d878e7 )
[Elements. Migrate
lib/src/utilities/change_builder/change_builder_core.dart](https://dart.googlesource.com/sdk.git/+/31d8adf1f3b9375e5a7af9fc81f8d28738d878e7 )
by Konstantin Shcheglov · 5 days ago
[11f53fd](https://dart.googlesource.com/sdk.git/+/11f53fd7d237d17ad940e35f43a2f963b4a5ed8c )
[[analysis_server] Preserve existing quote kinds when updating string
arguments](https://dart.googlesource.com/sdk.git/+/11f53fd7d237d17ad940e35f43a2f963b4a5ed8c )
by Danny Tuppeny · 5 days ago
[fc95268](https://dart.googlesource.com/sdk.git/+/fc95268a36197a2bf9976d7f1a96e2a83753ebe4 )
[[ResidentFrontendServer] Cache the compiler options that were last
used](https://dart.googlesource.com/sdk.git/+/fc95268a36197a2bf9976d7f1a96e2a83753ebe4 )
by Derek Xu · 5 days ago
[337e07f](https://dart.googlesource.com/sdk.git/+/337e07fab6b415e96d3554bc23a8da69507d7745 )
[[VM/Service] Use the resident frontend server for hot reload when it's
available](https://dart.googlesource.com/sdk.git/+/337e07fab6b415e96d3554bc23a8da69507d7745 )
by Derek Xu · 5 days ago
[8785c4e](https://dart.googlesource.com/sdk.git/+/8785c4e000167376f57aaed7ce1d016def2b11ff )
[Elements. Migrate
lib/utilities/range_factory.dart](https://dart.googlesource.com/sdk.git/+/8785c4e000167376f57aaed7ce1d016def2b11ff )
by Konstantin Shcheglov · 5 days ago
[8121b02](https://dart.googlesource.com/sdk.git/+/8121b02725d5412394841da173fb39ca27346de2 )
[Elements. Migrate
test/support/abstract_context.dart](https://dart.googlesource.com/sdk.git/+/8121b02725d5412394841da173fb39ca27346de2 )
by Konstantin Shcheglov · 5 days ago
[f3e68f2](https://dart.googlesource.com/sdk.git/+/f3e68f2d76c63318ad29ebea5a81acb724f4284e )
[[Migrate]
sdk_constraint_verifier.dart](https://dart.googlesource.com/sdk.git/+/f3e68f2d76c63318ad29ebea5a81acb724f4284e )
by Brian Wilkerson · 5 days ago
[491f4f4](https://dart.googlesource.com/sdk.git/+/491f4f48139c08c0be8ee6d346fe7e07922075fb )
[[CQ] Remove dead code from
ElementLocationImpl](https://dart.googlesource.com/sdk.git/+/491f4f48139c08c0be8ee6d346fe7e07922075fb )
by Brian Wilkerson · 5 days ago
2025-01-14 05:54:34 +00:00
Michael Goderbauer
9cab4ffee1
Use wildcards ( #161548 )
...
https://dart.dev/language/pattern-types#wildcard
2025-01-14 05:13:41 +00:00
Justin McCandless
1b0441c18a
Autocomplete Options Width ( #143249 )
...
| Problem | Before | After |
| --- | --- | --- |
| Width | <img width="797" alt="Screenshot 2024-02-09 at 1 29 09 PM"
src="https://github.com/flutter/flutter/assets/389558/c49fa584-2550-41f6-ab80-6c20d01412b1 ">
| <img width="794" alt="Screenshot 2024-02-09 at 1 23 59 PM"
src="https://github.com/flutter/flutter/assets/389558/1326f797-9883-4916-9de3-1939e7648d46 ">
|
| Overflow | 
| 
|
Fixes https://github.com/flutter/flutter/issues/78746
Fixes https://github.com/flutter/flutter/issues/92851
Part of https://github.com/flutter/flutter/issues/101620
Fixes https://github.com/flutter/flutter/issues/147483
Fixes https://github.com/flutter/flutter/issues/153274
Part of Google b/317115348
Fixes optionsViewOpenDirection not working, mentioned in
https://github.com/flutter/flutter/pull/143249#issuecomment-2036191457 .
### Requirements
* [x] By default, the width of the options matches the width of the
field.
* [x] Options can be aligned to the start or end for LTR/RTL languages.
* [x] The optionsViewOpenDirection parameter is respected.
* [x] If the options would vertically exceed the top or bottom of the
screen, they reposition themselves to fit on the screen while covering
the field. At least enough to tap an option. This has accessibility
implications, because sometimes an Autocomplete near the edge of a
narrow screen can be unusable.
* [x] If the Autocomplete is in a ScrollView, then the options move
along with the field during scrolling.
* [x] When the field moves or resizes, the options position and size
change to match. Even if the field is animated.
* [ ] The options layout updates on the same frame that the field layout
changes.
It's probably not possible to check all of these boxes so we'll probably
need to compromise.
#### Tools that I've used to try to achieve this
* LayoutBuilder to provide the field constraints[^1].
* Looking up layout information of a widget via GlobalKey.
* CompositedTransformFollower/Target.
* CustomSingleChildLayout.
[^1]: Originally this didn't work due to a bug when using LayoutBuilder
with OverlayPortal (https://github.com/flutter/flutter/pull/147856 ).
That has now been fixed.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-01-14 01:29:08 +00:00
Jason Simmons
fe598e7d6f
Move the analyzer_benchmark to Mac arm64 devicelab bots ( #161405 )
...
The arm64 Macs should have more memory than the Linux machines that are
available in the devicelab. The analyzer benchmark spawns a Dart
analysis server process that has a peak memory consumption of around
7GB, which may be activating the OOM killer on the Linux bots.
See https://github.com/flutter/flutter/issues/161306
2025-01-13 23:49:04 +00:00
Matan Lurey
d102e1197e
Remove references to cirrus, mostly in doc comments. ( #161529 )
...
Towards https://github.com/flutter/flutter/issues/161387 .
2025-01-13 23:49:04 +00:00
Jim Graham
366ed7f972
Fix paths when running clang-tidy on git diffs ( #161496 )
...
The working directory was `engine/src/flutter` but all of the file names
already had those parent directories on them so we'd be trying to find
build commands for `engine/src/flutter/engine/src/flutter`. This change
tells the git commands to make the file names relative to the working
directory (which is already `engine/src/flutter`).
Someone more familiar with the `--lint-head` option should double check
its operation since I wasn't sure exactly what it was supposed to do,
but the list of files it generated looked correct.
2025-01-13 23:49:03 +00:00
Yegor
0d906f5ecf
[web:a11y] treat empty tappables as buttons ( #161360 )
...
The situation will improve even further when we have proper ARIA roles,
but for now if a node is a leaf node and has a tap action, present it to
semantics as a button even if the `isButton` flag is missing.
Fixes https://github.com/flutter/flutter/issues/157743
2025-01-13 23:47:58 +00:00
Mitchell Goodwin
067afb7e69
Add route settings to CupertinoSheetRoute ( #161528 )
...
Adds route settings to the sheet route. From [this
comment.](https://github.com/flutter/flutter/pull/157568#issuecomment-2587720636 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-13 23:46:59 +00:00
Matan Lurey
1d38029c3b
Copy linux_host_engine as linux_host_engine_test, removing archives: [...]. ( #161532 )
...
Towards https://github.com/flutter/flutter/issues/161406 .
The goal is to, assuming this is WAI, move the `bringup: true` build
(the newly created one) to presubmit, and then in a follow-up PR, remove
the `tests: [...]` (and test dependencies) from
`linux_host_engine.json`, meaning that it would be a build/archive only
builder, and this _new_ builder would be a build/test one.
We talked about it being hypothetically better to _not_ build the engine
multiple times, and decided for now to depend on RBE and not try to
create stages or download artifacts created from another builder, but if
@zanderso has another suggestion here is the place to chime in :)
(Btw if we like this approach, I'll create a task list of every builder
that needs to be migrated)
2025-01-13 23:45:41 +00:00
Matan Lurey
1d79946ecb
Remove last two references to Cirrus CI. ( #161530 )
...
Towards https://github.com/flutter/flutter/issues/161387 .
2025-01-13 23:44:40 +00:00
John McDole
0009cc358f
Mark Mac_mokey microbenchmarks as flakey ( #161550 )
...
Random seed 349875783 is failing half the time.
```
flutter run -v -d IR65S859OJ4HAY6P --profile lib/benchmark_collection.dart --dart-define=seed=349875783
```
I'm concerned that this sometimes passes, which points to some hidden
timing bugs.
2025-01-13 23:14:39 +00:00
auto-submit[bot]
b95721ca6f
Reverts "Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute ( #160241 )" ( #161555 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#160241
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: yjbanov
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: there's evidence that this broke the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: chika3742
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {chunhtai, MitchellGoodwin}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
The recent changes have made it possible to customize the duration in
PageTransitionsBuilder, so I have adjusted
CupertinoPageTransitionsBuilder's transition duration to
CupertinoPageRoute.
related issue: #29068
| Before | After | Native |
| --- | --- | --- |
| <video
src="https://github.com/user-attachments/assets/1420bb86-37d2-4d5a-b0f9-e0860e3c8f01 ">
| <video
src="https://github.com/user-attachments/assets/f0455f3a-ca80-4cb6-a803-b9c48ec2075e ">
| <video
src="https://github.com/user-attachments/assets/74218f9d-f4a1-4008-84ac-caf73355f467 ">
|
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-01-13 22:39:19 +00:00
Ben Konyi
b3e65358d7
Add validator execution times to flutter doctor --verbose ( #158124 )
...
Should help provide more information for `flutter doctor` timeouts like
we've seen in https://github.com/flutter/flutter/issues/157513
2025-01-13 21:01:44 +00:00
Matan Lurey
5f06c091b9
Explain more specifically how to use flutter drive/what it does ( #161450 )
...
_Run integration tests for the project_ is not an accurate statement, as
there is nothing inherently about `flutter_driver` that is for
integration tests (for example, it could be just plain automation,
benchmarking, etc).
In addition, clarifies what the most common two arguments might be and
their defaults.
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2025-01-13 20:51:02 +00:00
Kishan Dhankecha
01fc23238e
Fixed repeated strings for incompatible Gradle or AGP version in create command ( #161223 )
...
Fixed the repeated string which shows the compatible Java version in the
create command.
<img width="1003" alt="image"
src="https://github.com/user-attachments/assets/143634ef-fb36-40ce-8934-a5237d574821 "
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-13 20:35:16 +00:00
Matan Lurey
607c79cdfd
Remove WEB_SHARD_COUNT, which no longer exists post-Cirrus. ( #161527 )
...
Towards https://github.com/flutter/flutter/issues/161387 .
2025-01-13 20:21:00 +00:00
Chinmay Garde
432843a0f3
[Impeller] Update guidance on prebuilt artifacts. ( #161251 )
2025-01-13 19:44:37 +00:00
Jim Graham
d80be471dd
Migrate DisplayList unit tests to DL/Impeller geometry classes ( #161453 )
...
Address the first item in
https://github.com/flutter/flutter/issues/161456 (Unit tests in the
display_list/ directory)
Some new `DlPath::Make<Shape>` factories were added to make test writing
simpler.
`DlPath` is now bi-directional! You can construct one from either an
`SkPath` or an `impeller::Path` and it will auto-convert to the other as
needed. This allows unit tests with custom paths to rely on
`impeller::Path` for path construction instead of `SkPath` (as long as
only simple move/line/quad/curve verbs are needed).
`RoundRect` now normalizes the argument rect in all constructors to
match Flutter expectations and `SkRRect` legacy behavior. This behavior
was already being enforced in `ui.rrect` but the unit tests we have to
verify the behavior are written against the `RoundRect` object itself so
this was the simplest way to make the unit tests work right, while
ensuring that we maintain correct behavior for `ui` objects. Ideally
these issues would be tested at the `ui` native interface instead of as
unit tests on our internal objects and we should be allowed to decide
how we want our internal APIs to behave with regard to this concept.
Skia inverted path types are no longer allowed in `DlPath` and all use
of them should be eliminated in the engine (except to test if they crash
when used in a debug unit test)
A couple of unit tests for `DlOpSpy` and Impeller's interop package were
migrated here along for the ride even though this PR was focused
primarily on `display_list/` unit tests.
2025-01-13 19:28:57 +00:00
Justin McCandless
8856ccb844
Context menu button callback docs clarification ( #161451 )
...
This PR updates the context menu button callback docs to clarify that
they are only called when their button is tapped, not when their action
happens any other way. There seemed to be confusion about this in
https://github.com/flutter/flutter/issues/117329 and
https://github.com/flutter/flutter/issues/160908 .
Fixes https://github.com/flutter/flutter/issues/160908 .
2025-01-13 19:27:17 +00:00
Chikamatsu Kazuya
5bd65c434a
Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute ( #160241 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
The recent changes have made it possible to customize the duration in
PageTransitionsBuilder, so I have adjusted
CupertinoPageTransitionsBuilder's transition duration to
CupertinoPageRoute.
related issue: #29068
| Before | After | Native |
| --- | --- | --- |
| <video
src="https://github.com/user-attachments/assets/1420bb86-37d2-4d5a-b0f9-e0860e3c8f01 ">
| <video
src="https://github.com/user-attachments/assets/f0455f3a-ca80-4cb6-a803-b9c48ec2075e ">
| <video
src="https://github.com/user-attachments/assets/74218f9d-f4a1-4008-84ac-caf73355f467 ">
|
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-13 19:11:59 +00:00
John McDole
27f8bb91a6
Udpate documentation on the third_party directories ( #161407 )
...
Fixes #161336
2025-01-13 19:03:50 +00:00
Matan Lurey
449079d4f1
Propagate environment variables when flutter drive is invoked. ( #161452 )
...
Closes https://github.com/flutter/flutter/issues/161449 .
~3 LOC, with 203 lines of tests (including an e2e integration test that
it actually works).
Feedback welcome!
(The reason I'm working on this is the ability to pass environment
variables makes it much easier and less hacky to make
`android_engine_test` configurable, i.e. have different expected outputs
for OpenGLES/Vulkan, compare screenshots locally for deflaking, etc).
2025-01-13 18:48:58 +00:00
Gray Mackall
6e8d80743d
Convert base application name handling to kotlin source (start of FGP kt conversion) ( #155963 )
...
Wires up a new gradle subproject defining kotlin classes to be used by
the FGP, so that we can incrementally move the entire plugin to be
written in kotlin source.
Starts by moving a piece of kotlin script.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-01-13 17:56:06 +00:00
Jonah Williams
ee8aab77fe
[Impeller] remove API 30 restriction for SurfaceControl testing. ( #161438 )
...
In order to give a minimal repro for the AHB issues to folks, I need to
be able to show that while it _should_ work on API 29 it doesn't in a
number of places.. Since this AHB swapchain is off by default this will
have no impact on production applications.
2025-01-13 17:41:50 +00:00
engine-flutter-autoroll
72db8f69e3
Roll Packages from 65547511c004 to 3c3bc6832b39 (16 revisions) ( #161515 )
...
65547511c0...3c3bc6832bflutter/packages#8412 )
2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8411 )
2025-01-11 engine-flutter-autoroll@skia.org Roll Flutter from
4b23b8182888 to 864d4f59dde0 (50 revisions) (flutter/packages#8408 )
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/android
(flutter/packages#8413 )
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#8410 )
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8357 )
2025-01-10 magder@google.com Fix dependabot test-dependencies group
io.mockk regex (flutter/packages#8406 )
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7306 )
2025-01-10 anay1018@gmail.com [url_launcher_windows] Correct logging url
(flutter/packages#8107 )
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8358 )
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the androidx group across 3 directories with 1 update
(flutter/packages#8329 )
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20241224 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8372 )
2025-01-10 mdebbar@google.com [url_launcher][web] Better support for
semantics in the Link widget (flutter/packages#6711 )
2025-01-10 32538273+ValentinVignal@users.noreply.github.com [camera]:
Activate leak testing for sub packages (flutter/packages#8353 )
2025-01-09 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Remove logic used to previously correct preview
rotation (flutter/packages#8256 )
2025-01-09 47866232+chunhtai@users.noreply.github.com [go_router]
Rephrases readme to better describe the current status
(flutter/packages#8403 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-13 17:18:30 +00:00
Taha Tesser
cef35e7790
Update error message for when leading/trailing width exceeds ListTile width and add missing test ( #161091 )
...
Fixes [ListTile Crashes When Width Is Reduced with Leading or Trailing
Widgets](https://github.com/flutter/flutter/issues/159380 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-13 13:57:38 +00:00
Taha Tesser
1c147a2cdb
Deprecate unused ButtonStyleButton.iconAlignment property ( #160023 )
...
Fixes [Deprecate unused `ButtonStyleButton.iconAlignment`
property](https://github.com/flutter/flutter/issues/159782 )
Refactor done in https://github.com/flutter/flutter/pull/158503 makes
`ButtonStyleButton.iconAlignment` redundant. In this PR I'm marking it
as deprecated without migration guide. However, it may possible to
remove it altogether.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-13 12:11:26 +00:00
Robert Ancell
d14140f854
Provide monitor information. ( #161359 )
...
Fixes https://github.com/flutter/flutter/issues/144230
2025-01-12 21:20:40 +00:00
Jonah Williams
bd1ebf2e14
[android_engine_test] Remove background/foreground from surface texture trampoline test. ( #161441 )
...
See if this fixes the golden. The background/foreground isn't necessary
for this test which is just a gold comparison of the rendering
2025-01-11 21:16:21 +00:00
Matan Lurey
00b6a4ed06
Remove some miscellaneous references to Cirrus. ( #161390 )
...
Towards https://github.com/flutter/flutter/issues/161387 .
... made a few TLC changes the best I could.
2025-01-11 05:28:56 +00:00
chunhtai
6b8b57913d
add semantics role and tab ( #161260 )
...
fixes https://github.com/flutter/flutter/issues/157134
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-11 00:08:55 +00:00
Mitchell Goodwin
50f7120de5
CupertinoSheetRoute ( #157568 )
...
Fixes #42560
### Updated 12/04/24
Adds a CupertinoSheetRoute which displays an iOS style sheet, while
giving the previous route a delegated transition to sync up correctly.
There's a lot of sample files in this draft showing different use cases
for the sake of reviewing the PR. We'll want to probably go down to
about two before this PR lands.
**TODO in this PR**
- [x] Write actual documentation
- [x] Write tests
**TODO in a feature branch, and will be merged with this PR**
- [ ] Add swipe down to dismiss
**TODO in a follow up PR**
- [ ] Stretching on swipe up
- [ ] Add a fullscreen version
- [x] Dark mode theming
How it currently compares, with the simple case and nested navigation:
| Flutter | Native|
| ------------- | ------------- |
|
|
|
|
|
|
Update:
Now the status bar will transition from dark to light text so that it's
visible after the transition.
`cupertino_sheet.0.dart` has an example of what it looks like to do a
simple case. It's fairly straightforward.
`cupertino_sheet.1.dart` shows one with nested navigation. It's
necessary to add a `Navigator` if showing page navigation within the
sheet is wanted. I'm thinking adding an API option that auto sets this
up may be needed as there are some pitfalls.
`cupertino_sheet.2.dart` functionally does the same as above but uses
the `showCupertinoSheet` to reduce boilerplate.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-10 23:01:08 +00:00
LongCatIsLooong
9e211cabbd
Update TextEditingController.text documentation to recommend against using it in production code ( #157769 )
...
The `TextEditingController.text` setter has been a major source of
confusion, as using it would usually result in loss of cursor position
if the text field is active. Arguably it also should not be part of the
controller's interface since it is a convenience method.
There are many issues, for example:
https://github.com/flutter/flutter/issues/65547
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-10 20:59:21 +00:00
Alex Li
771b8a4197
🔊 [tool] Add a wirelessly connected device name as displayName ( #160497 )
...
An improvement for #144634 .
A wirelessly connected device will displayed as `Target device 1
(wireless)` in various of places.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-10 20:51:34 +00:00
John McDole
ee4d46d43a
FixForward: method was renamed ( #161431 )
2025-01-10 16:58:24 +00:00
Jenn Magder
864d4f59dd
Mark complex_layout_scroll_perf_macos__timeline_summary unflaky ( #160997 )
...
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/158251 was closed.
Co-authored-by: Chris Bracken <chris@bracken.jp>
2025-01-10 04:21:23 +00:00
Jenn Magder
0624b56e3f
Mark hello_world_macos__compile unflaky ( #160998 )
...
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/159542 was closed.
2025-01-10 04:21:23 +00:00
Jenn Magder
b9159dd474
Mark animated_complex_opacity_perf_macos__e2e_summary unflaky ( #160996 )
...
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/157423 was closed.
Co-authored-by: Chris Bracken <chris@bracken.jp>
2025-01-10 04:21:23 +00:00
Jenn Magder
6437b9b0be
Mark integration_ui_test_test_macos unflaky ( #160999 )
...
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/152212 was closed.
2025-01-10 04:20:14 +00:00
Jenn Magder
c4635e526f
Mark hot_mode_dev_cycle_macos_target__benchmark unflaky ( #161000 )
...
Should have been marked unflaky when
https://github.com/flutter/flutter/issues/158568 was closed.
Co-authored-by: Chris Bracken <chris@bracken.jp>
2025-01-10 04:20:14 +00:00
Matan Lurey
89b336109f
Add a virtual-display (VD) platform view test, and refactor tests a bit. ( #161349 )
...
Towards https://github.com/flutter/flutter/issues/161261 .
Still need to add a HC (Hybrid Composition) variant, but figured I'd do
this incrementally to make it easier to review.
2025-01-10 03:23:40 +00:00
Matan Lurey
99fe90a05e
Remove CIRRUS_TASK_NAME from what I can tell, is always omitted on LUCI ( #161391 )
...
Towards https://github.com/flutter/flutter/issues/161387 .
Example build, no `CIRRUS_TASK_NAME`:
<https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8726279068923920961/+/u/OS_info/l_execution_details >
2025-01-10 03:05:34 +00:00
Matan Lurey
9bed9d7f95
Replace the always omitted CPU environment variable with numberOfProcessors. ( #161392 )
...
I am not sure if this is a 1:1 comparison, so please advise.
Towards https://github.com/flutter/flutter/issues/161387 .
2025-01-10 02:41:05 +00:00
