Taha Tesser
db89df51c3
Fix FlexibleSpaceBar.title doesn't respect the leading widget ( #132573 )
...
fixes [Long `FlexibleSpaceBar.title` doesn't respect the leading widget
](https://github.com/flutter/flutter/issues/132030 )
### Description
- This adds `FlexibleSpaceBarSettings.hasLeading` for the `FlexibleSpaceBar`'s title to respect the leading widget.
- Use the new `FlexibleSpaceBarSettings.hasLeading` property in the `SliverAppBar` for its `FlexibleSpaceBar`.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
useMaterial3: true,
brightness: Brightness.dark,
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
const Text('TargetPlatform.Android'),
Theme(
data: Theme.of(context).copyWith(
platform: TargetPlatform.android,
),
child: Container(
height: 250,
padding: const EdgeInsets.all(8),
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
width: 4,
),
),
child: const AppBarLeading(
showLeading: true,
showTitle: false,
),
),
),
const Text('TargetPlatform.iOS'),
Theme(
data: Theme.of(context).copyWith(
platform: TargetPlatform.iOS,
),
child: Container(
height: 250,
padding: const EdgeInsets.all(8),
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
width: 2,
),
),
child: const AppBarLeading(
showLeading: true,
showTitle: false,
),
),
),
],
),
);
}
}
class AppBarLeading extends StatelessWidget {
const AppBarLeading({
super.key,
required this.showLeading,
required this.showTitle,
});
final bool showLeading;
final bool showTitle;
@override
Widget build(BuildContext context) {
return Scaffold(
drawer: const Drawer(),
body: CustomScrollView(
slivers: [
SliverAppBar(
automaticallyImplyLeading: showLeading,
iconTheme: const IconThemeData(
color: Colors.amber,
),
title: showTitle ? const Text('AppBar') : null,
flexibleSpace: FlexibleSpaceBar(
title: Text('Title ' * 15),
// centerTitle: true,
),
toolbarHeight: showTitle ? 170 : 100,
),
],
),
);
}
}
```
</details>
### Before
### After
2023-08-22 20:47:05 +00:00
engine-flutter-autoroll
0283d8a8d0
Roll Flutter Engine from 21437d384b56 to 28b8bd5d5d91 (1 revision) ( #133075 )
...
21437d384b...28b8bd5d5dreidbaker@google.com i82973 scroll mouse wheel support (flutter/engine#44724 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 20:43:22 +00:00
engine-flutter-autoroll
ee7788cf4c
Roll Flutter Engine from 090754879679 to 21437d384b56 (1 revision) ( #133072 )
...
0907548796...21437d384b30870216+gaaclarke@users.noreply.github.com [Impeller] Tiny optimizations for text rendering (avoiding extra ops and copies). (flutter/engine#44822 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 19:55:23 +00:00
Ivan Inozemtsev
5665655d39
Add support for Future<List<int>?> to MatchesGoldenFile ( #132965 )
...
Otherwise when tests use `expectLater(getBytesOrNull(), matchesGoldenFile(...))`, they may fail in sound null safety mode and pass in weak null safety mode.
Fixes https://github.com/flutter/flutter/issues/132964
2023-08-22 19:40:18 +00:00
engine-flutter-autoroll
184323777a
Roll Packages from e26f3b9374d0 to c730a90f2fcc (3 revisions) ( #133067 )
...
e26f3b9374...c730a90f2fengine-flutter-autoroll@skia.org Roll Flutter from 5e6d88d766b9 to 54c98d7433c5 (24 revisions) (flutter/packages#4754 )
2023-08-22 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.5 to 1.13.7 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4736 )
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter from 6f227c078430 to 5e6d88d766b9 (8 revisions) (flutter/packages#4751 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 19:13:26 +00:00
engine-flutter-autoroll
43facd14fd
Roll Flutter Engine from ff375bf5d8eb to 090754879679 (1 revision) ( #133066 )
...
ff375bf5d8...0907548796skia-flutter-autoroll@skia.org Roll Dart SDK from ecb1e3aecfbb to 3ebf0fedfceb (1 revision) (flutter/engine#44962 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 19:02:58 +00:00
Zachary Anderson
6a2d1b94ca
Increase heap size for examples/flutter_view gradle build ( #133064 )
...
For the engine roll presubmit failure in https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20build_tests_3_3/10805/overview
2023-08-22 18:28:21 +00:00
engine-flutter-autoroll
c475409b8a
Roll Flutter Engine from c5e0152b01f4 to ff375bf5d8eb (4 revisions) ( #133062 )
...
c5e0152b01...ff375bf5d8skia-flutter-autoroll@skia.org Roll Skia from eff8446c42f8 to 50814d9ca5bb (1 revision) (flutter/engine#44958 )
2023-08-22 brianosman@google.com Add missing GrVkTypes include (flutter/engine#44957 )
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from a548d28072ce to eff8446c42f8 (2 revisions) (flutter/engine#44955 )
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from b3b8f3332cce to a548d28072ce (3 revisions) (flutter/engine#44953 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 18:02:49 +00:00
Justin McCandless
0278671bda
Fix memory leak in Form ( #132987 )
...
Diposes some restorable variables that weren't disposed before.
2023-08-22 10:23:13 -07:00
Victoria Ashworth
b3005a318b
Re-enable Xcode Debug tests ( #132523 )
...
Re-enables Xcode Debug tests (still in bringup). It also has them use an older version of Xcode that is compatible with the host OS.
Fixes https://github.com/flutter/flutter/issues/132309 .
2023-08-22 17:22:06 +00:00
Zachary Anderson
10b7712b5a
Increase heap for gradle in examples/platform_view ( #133052 )
...
Fixes https://github.com/flutter/flutter/issues/133051
2023-08-22 09:21:53 -07:00
Polina Cherkasova
4e6da2dcc7
Cover more tests with leak tracking. ( #132806 )
...
This PR replaces some `testWidgets` with `testWidgestsWithLeakTracking`.
2023-08-22 15:50:48 +00:00
engine-flutter-autoroll
c00bdc832d
Roll Flutter Engine from f5f099a4a5e3 to c5e0152b01f4 (4 revisions) ( #133049 )
...
f5f099a4a5...c5e0152b01skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DA_PryqcVU6Um3j2k... to G25oJMO5jbUi-UN4F... (flutter/engine#44951 )
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from bf08da24a261 to b3b8f3332cce (1 revision) (flutter/engine#44952 )
2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 00f6f69187df to ecb1e3aecfbb (1 revision) (flutter/engine#44950 )
2023-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RVhmZNTYsaIiTyjwP... to kKI09su99b0AKs8b3... (flutter/engine#44949 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RVhmZNTYsaIi to kKI09su99b0A
fuchsia/sdk/core/mac-amd64 from DA_PryqcVU6U to G25oJMO5jbUi
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 15:45:09 +00:00
engine-flutter-autoroll
54c98d7433
Roll Flutter Engine from 447981acbf36 to f5f099a4a5e3 (1 revision) ( #133035 )
...
447981acbf...f5f099a4a5skia-flutter-autoroll@skia.org Roll Skia from f13ee6ee5433 to bf08da24a261 (1 revision) (flutter/engine#44946 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 09:36:40 +00:00
engine-flutter-autoroll
7171c9b394
Roll Flutter Engine from 5e84d733ef67 to 447981acbf36 (2 revisions) ( #133031 )
...
5e84d733ef...447981acbfskia-flutter-autoroll@skia.org Roll Skia from 399e90397a07 to f13ee6ee5433 (1 revision) (flutter/engine#44944 )
2023-08-22 leroux_bruno@yahoo.fr [Linux] Expose channel buffers 'resize' and 'overflow' control commands (flutter/engine#44636 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 08:51:24 +00:00
engine-flutter-autoroll
f238211e1f
Roll Flutter Engine from e183e8a94093 to 5e84d733ef67 (1 revision) ( #133030 )
...
e183e8a940...5e84d733efskia-flutter-autoroll@skia.org Roll Skia from 14e7b3b2d660 to 399e90397a07 (1 revision) (flutter/engine#44943 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 07:58:43 +00:00
engine-flutter-autoroll
e085e613c8
Roll Flutter Engine from 454e0e35f8e4 to e183e8a94093 (2 revisions) ( #133026 )
...
454e0e35f8...e183e8a940skia-flutter-autoroll@skia.org Roll Skia from 9ecdc9265aaa to 14e7b3b2d660 (1 revision) (flutter/engine#44942 )
2023-08-22 bdero@google.com [Impeller] Supply a text backend to the AiksContext at runtime. (flutter/engine#44884 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 06:58:24 +00:00
engine-flutter-autoroll
5b20988483
Roll Flutter Engine from 857840db5574 to 454e0e35f8e4 (1 revision) ( #133020 )
...
857840db55...454e0e35f8matanlurey@users.noreply.github.com Disallow using ./tools/gn --enable-unittests --android (or --ios) (flutter/engine#44930 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 05:26:25 +00:00
engine-flutter-autoroll
fedf0a8a11
Roll Flutter Engine from 1ab054967c1d to 857840db5574 (2 revisions) ( #133018 )
...
1ab054967c...857840db55skia-flutter-autoroll@skia.org Roll Skia from 40442138ec94 to 9ecdc9265aaa (1 revision) (flutter/engine#44939 )
2023-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from aXDvHIK6XMKTHieu_... to DA_PryqcVU6Um3j2k... (flutter/engine#44938 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from aXDvHIK6XMKT to DA_PryqcVU6U
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 04:30:24 +00:00
engine-flutter-autoroll
8e7304bb27
Roll Flutter Engine from 5a292e42a593 to 1ab054967c1d (1 revision) ( #133014 )
...
5a292e42a5...1ab054967cchinmaygarde@google.com [Impeller] Document rendering backend selection on Android. (flutter/engine#44933 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 02:35:36 +00:00
Kate Lovett
a5b06f15a0
Fix visual overflow for SliverMainAxisGroup ( #132989 )
...
Fixes https://github.com/flutter/flutter/issues/132788
The SliverGeometry was not set properly for SliverMainAxisGroup. Omitting hasVisualOverflow affected the Viewport's choice to apply a clip, leading to the sliver being rendered outside of the bounds of the viewport.
2023-08-22 01:46:23 +00:00
engine-flutter-autoroll
1cf3925d4d
Roll Flutter Engine from e5929d83e9b7 to 5a292e42a593 (3 revisions) ( #133010 )
...
e5929d83e9...5a292e42a5skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lDn2QLh1I7rtNu01y... to RVhmZNTYsaIiTyjwP... (flutter/engine#44932 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from da6b74568ece to 40442138ec94 (3 revisions) (flutter/engine#44931 )
2023-08-21 31859944+LongCatIsLooong@users.noreply.github.com Reland "Implementing TextScaler for nonlinear text scaling (#42062 )" (flutter/engine#44907 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lDn2QLh1I7rt to RVhmZNTYsaIi
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 01:40:11 +00:00
Matan Lurey
a021015ef6
Always require --local-engine-host if --local-engine ( #133003 )
...
Closes #132245 .
2023-08-22 01:32:14 +00:00
engine-flutter-autoroll
97e434f86a
Roll Flutter Engine from 55b84268f2a6 to e5929d83e9b7 (3 revisions) ( #133005 )
...
55b84268f2...e5929d83e9dnfield@google.com [Impeller] Disable Impeller on Fuchsia (flutter/engine#44925 )
2023-08-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Added recycled command buffers. (flutter/engine#44904 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1859f7202bba to 00f6f69187df (1 revision) (flutter/engine#44922 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 00:27:36 +00:00
engine-flutter-autoroll
5a847b0959
Roll Flutter Engine from e5f690b829e5 to 55b84268f2a6 (1 revision) ( #133000 )
...
e5f690b829...55b84268f2godofredoc@google.com Use arm64 machines for ios_debug_sim_arm64 test. (flutter/engine#44920 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 23:41:14 +00:00
Angelo Silvestre
f9b91734a1
Add deleteBackwardByDecomposingPreviousCharacter mapping for tests ( #132919 )
...
In `MacOSTestTextInputKeyHandler`, there are some mappings from shortcuts to generate macOS selectors. However, `ctrl + backspace` isn't mapped to `deleteBackwardByDecomposingPreviousCharacter:`.
This PR adds the mapping for `deleteBackwardByDecomposingPreviousCharacter:`.
Fixes: https://github.com/flutter/flutter/issues/132917
2023-08-21 23:27:19 +00:00
engine-flutter-autoroll
254f235c7f
Roll Flutter Engine from fc75109c3a1e to e5f690b829e5 (1 revision) ( #132996 )
...
fc75109c3a...e5f690b829skia-flutter-autoroll@skia.org Roll Skia from ca891e495da1 to da6b74568ece (3 revisions) (flutter/engine#44917 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 22:26:59 +00:00
engine-flutter-autoroll
7f5de98ae2
Roll Flutter Engine from 2388b9db2be7 to fc75109c3a1e (3 revisions) ( #132992 )
...
2388b9db2b...fc75109c3abrianosman@google.com Include GrVkTypes where necessary (flutter/engine#44916 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from af4ecc4cd3e9 to ca891e495da1 (1 revision) (flutter/engine#44914 )
2023-08-21 godofredoc@google.com Remove explicit mac cpu dimensions (flutter/engine#44836 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 21:26:05 +00:00
engine-flutter-autoroll
f05dcafddf
Roll Flutter Engine from 210f5a8aa245 to 2388b9db2be7 (6 revisions) ( #132986 )
...
210f5a8aa2...2388b9db2bjohn@johnmccutchan.com [Impeller] Initial Android Impeller docs on backend selection and platform views. (flutter/engine#44815 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from da3bb89a5d88 to af4ecc4cd3e9 (1 revision) (flutter/engine#44911 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from 7e5a3009a8d4 to da3bb89a5d88 (9 revisions) (flutter/engine#44906 )
2023-08-21 zanderso@users.noreply.github.com Don't run clang_tidy --lint-all in presubmit (flutter/engine#44833 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 7dd53a3df4cf to 1859f7202bba (1 revision) (flutter/engine#44903 )
2023-08-21 gspencergoog@users.noreply.github.com Change Doxyfile options to not create subdirs (flutter/engine#44855 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 20:41:34 +00:00
Taha Tesser
af79b4c7a3
Update ExpansionPanel example for the updated expansionCallback callback ( #132837 )
...
fixes [ExpansionPanelList can't expand/collapse on the latest stable/master
](https://github.com/flutter/flutter/issues/132759 )
https://github.com/flutter/flutter/pull/128082 updated the `expansionCallback` and also the `ExpansionPanel` sample in the Flutter gallery but not the API example.
This PR fixes the API example and adds tests.
2023-08-21 20:13:22 +00:00
Gray Mackall
505f9d8954
Change gradle lockfile generation script to use --config-only flag ( #132967 )
...
The `generate_gradle_lockfiles.dart` script was generating the gradle wrapper by building a flavor that didn't exist. In the time since the script was written, the `--config-only` flag was created and should be used instead.
Context https://github.com/flutter/flutter/pull/132406#discussion_r1300352602
2023-08-21 19:51:55 +00:00
engine-flutter-autoroll
2b42a47724
Roll Flutter Engine from 0290d0bd79ee to 210f5a8aa245 (1 revision) ( #132973 )
...
0290d0bd79...210f5a8aa2jonahwilliams@google.com [Impeller] Remove sync switch (flutter/engine#44885 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 19:04:06 +00:00
Justin McCandless
8e95ee2e96
Docs on iOS's directional quote characters ( #132869 )
...
When you type a single or double quote character on the default iOS keyboard, it doesn't actually insert the usual `'` or `"`. Instead, it inserts a directional version that tries to match with others. This is very tricky when allow/deny-listing characters, so I've added a section about this to the docs.
Fixes https://github.com/flutter/flutter/issues/132232
2023-08-21 19:02:33 +00:00
Reid Baker
0c78dce529
Bump memory usage for flutter gallery ( #132968 )
...
Fixes https://github.com/flutter/flutter/issues/131006
Flakes related to out of memory in gradle when running tests.
Opted not to add enforcement for gradle.properties in https://github.com/flutter/flutter/blob/master/dev/bots/analyze.dart because the memory usage has been stable for 6 years and not every example needs more memory.
2023-08-21 18:07:56 +00:00
fzyzcjy
aeddab428d
When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK ( #127456 )
...
Close #127265
The CI fails because of simple analyzer errors. Thus, I would like to hear your opinions first!
2023-08-21 17:12:06 +00:00
engine-flutter-autoroll
27dd111ad5
Roll Flutter Engine from a9b00783bc7c to 0290d0bd79ee (1 revision) ( #132962 )
...
a9b00783bc...0290d0bd79skia-flutter-autoroll@skia.org Roll Skia from 475f07f5ca14 to 7e5a3009a8d4 (1 revision) (flutter/engine#44900 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 17:06:42 +00:00
engine-flutter-autoroll
e425b68046
Roll Packages from 4c16f3ef4033 to e26f3b9374d0 (5 revisions) ( #132960 )
...
4c16f3ef40...e26f3b9374raul.silveira@popcode.com.br [camera_android]: Fixes crash when record video on Android versions lower than 12 (flutter/packages#4635 )
2023-08-19 engine-flutter-autoroll@skia.org Roll Flutter from 5a556f8ecde6 to 6f227c078430 (11 revisions) (flutter/packages#4749 )
2023-08-18 10687576+bparrishMines@users.noreply.github.com Update release action Flutter version to 3.13.0 (flutter/packages#4745 )
2023-08-18 stuartmorgan@google.com [google_maps_flutter] Fix async handling in examples (flutter/packages#4729 )
2023-08-18 engine-flutter-autoroll@skia.org Roll Flutter from 2502b51f86c1 to 5a556f8ecde6 (42 revisions) (flutter/packages#4743 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 16:12:07 +00:00
engine-flutter-autoroll
5e6d88d766
Roll Flutter Engine from 14be26c91620 to a9b00783bc7c (2 revisions) ( #132955 )
...
14be26c916...a9b00783bcskia-flutter-autoroll@skia.org Roll Dart SDK from af7860c1b2a5 to 7dd53a3df4cf (1 revision) (flutter/engine#44898 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iQbvLoFBbhU8pkkqw... to lDn2QLh1I7rtNu01y... (flutter/engine#44895 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from iQbvLoFBbhU8 to lDn2QLh1I7rt
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 15:58:24 +00:00
engine-flutter-autoroll
3c0f7ca6b5
Roll Flutter Engine from e2d9809d1af3 to 14be26c91620 (2 revisions) ( #132946 )
...
e2d9809d1a...14be26c916skia-flutter-autoroll@skia.org Roll Skia from fca8fac08117 to 475f07f5ca14 (2 revisions) (flutter/engine#44896 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fiGH0e7wu87NiNtTr... to aXDvHIK6XMKTHieu_... (flutter/engine#44894 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fiGH0e7wu87N to aXDvHIK6XMKT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 11:48:31 +00:00
engine-flutter-autoroll
89e8295839
Roll Flutter Engine from 36ab259a61ed to e2d9809d1af3 (1 revision) ( #132944 )
...
36ab259a61...e2d9809d1askia-flutter-autoroll@skia.org Roll Dart SDK from c839eea7f0fa to af7860c1b2a5 (1 revision) (flutter/engine#44893 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 10:55:24 +00:00
engine-flutter-autoroll
7771926517
Roll Flutter Engine from e7d745111795 to 36ab259a61ed (2 revisions) ( #132937 )
...
e7d7451117...36ab259a61flar@google.com Split DisplayListBuilder into DlCanvas optimizer and DlOp recorder classes (flutter/engine#44718 )
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from d2369dac4a1d to fca8fac08117 (1 revision) (flutter/engine#44888 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 08:41:22 +00:00
engine-flutter-autoroll
c328d03928
Roll Flutter Engine from 8c7ce6ddde0f to e7d745111795 (1 revision) ( #132925 )
...
8c7ce6ddde...e7d7451117skia-flutter-autoroll@skia.org Roll Dart SDK from 632c8cccd30c to c839eea7f0fa (1 revision) (flutter/engine#44886 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 03:21:32 +00:00
engine-flutter-autoroll
45e464cb9d
Roll Flutter Engine from 394554bd1630 to 8c7ce6ddde0f (2 revisions) ( #132921 )
...
394554bd16...8c7ce6dddeskia-flutter-autoroll@skia.org Roll Skia from 4f6b9d08b6d1 to d2369dac4a1d (6 revisions) (flutter/engine#44883 )
2023-08-20 bdero@google.com [Impeller] Fix clip management for DrawPicture. (flutter/engine#44835 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 01:57:22 +00:00
engine-flutter-autoroll
3b7831acf3
Roll Flutter Engine from 2dcfb6cb7e49 to 394554bd1630 (4 revisions) ( #132918 )
...
2dcfb6cb7e...394554bd16chinmaygarde@google.com [Impeller] Document threading configuration with Vulkan. (flutter/engine#44874 )
2023-08-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from onEHyyETXAMieDyfP... to fiGH0e7wu87NiNtTr... (flutter/engine#44875 )
2023-08-20 skia-flutter-autoroll@skia.org Roll Dart SDK from a4908f67b63e to 632c8cccd30c (2 revisions) (flutter/engine#44872 )
2023-08-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pSqQ556xmZp7S4np5... to iQbvLoFBbhU8pkkqw... (flutter/engine#44878 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pSqQ556xmZp7 to iQbvLoFBbhU8
fuchsia/sdk/core/mac-amd64 from onEHyyETXAMi to fiGH0e7wu87N
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-21 00:02:42 +00:00
engine-flutter-autoroll
4ac85071e1
Roll Flutter Engine from f4bffdcf8536 to 2dcfb6cb7e49 (4 revisions) ( #132914 )
...
f4bffdcf85...2dcfb6cb7eskia-flutter-autoroll@skia.org Roll Skia from e9cf3f1740eb to 4f6b9d08b6d1 (2 revisions) (flutter/engine#44868 )
2023-08-20 jonahwilliams@google.com Revert "Implementing TextScaler for nonlinear text scaling" (flutter/engine#44882 )
2023-08-18 737941+loic-sharma@users.noreply.github.com [Embedder API] Add semantic string attributes (flutter/engine#44616 )
2023-08-18 31859944+LongCatIsLooong@users.noreply.github.com Implementing TextScaler for nonlinear text scaling (flutter/engine#42062 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-20 23:08:40 +00:00
Jackson Gardner
6f227c0784
Space character should be optional when tree shaking fonts ( #132880 )
...
Addresses the other part of https://github.com/flutter/flutter/issues/132711
2023-08-19 02:04:15 +00:00
engine-flutter-autoroll
6d757046f4
Roll Flutter Engine from 654d3a2c8494 to f4bffdcf8536 (5 revisions) ( #132876 )
...
654d3a2c84...f4bffdcf85jacksongardner@google.com Allow optional codepoints to be expressed to the font subset generator. (flutter/engine#44864 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from 2ddec49abd5c to e9cf3f1740eb (3 revisions) (flutter/engine#44862 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from 2dd1ed0baa7d to 2ddec49abd5c (2 revisions) (flutter/engine#44860 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from cf37d99d844d to 2dd1ed0baa7d (1 revision) (flutter/engine#44859 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 8109103e041b to a4908f67b63e (2 revisions) (flutter/engine#44858 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-19 00:37:23 +00:00
Renzo Olivares
2ecb8866a2
SelectionArea on iOS should toggle the context menu when tapping on the previous selection ( #132851 )
...
https://github.com/flutter/flutter/assets/948037/210fdee4-d922-422b-a257-4ee586a3814f
Related: https://github.com/flutter/flutter/issues/129583
2023-08-18 23:45:16 +00:00
Zachary Anderson
d5a162b788
Forward port API docs creation realm handling from prior script ( #132867 )
...
It looks like the logic added here:
https://github.com/flutter/flutter/pull/131951/files#diff-297ee4cfe6d9bffc2fa1376918a50b8e4165ada4569575880c40811b6f749265R18
got dropped in the refactor here:
https://github.com/flutter/flutter/pull/132710
2023-08-18 15:33:27 -07:00
engine-flutter-autoroll
1bdef6fea7
Roll Flutter Engine from 72c4e61fdbfa to 654d3a2c8494 (3 revisions) ( #132868 )
...
72c4e61fdb...654d3a2c84skia-flutter-autoroll@skia.org Roll Skia from edf0c0ecc7b1 to cf37d99d844d (1 revision) (flutter/engine#44857 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from e3adabdd0511 to edf0c0ecc7b1 (3 revisions) (flutter/engine#44854 )
2023-08-18 jason-simmons@users.noreply.github.com Flush pending graphics commands when the unref queue is drained on the IO thread (flutter/engine#44831 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-18 21:09:19 +00:00
