engine-flutter-autoroll
58171f0923
Roll Flutter Engine from 83fdadaf12f0 to 72c4e61fdbfa (2 revisions) ( #132861 )
...
83fdadaf12...72c4e61fdbskia-flutter-autoroll@skia.org Roll Skia from 31baf15e8f2c to e3adabdd0511 (2 revisions) (flutter/engine#44851 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from c9294edc03b9 to 31baf15e8f2c (10 revisions) (flutter/engine#44850 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-18 19:23:06 +00:00
chunhtai
61242fa13b
Updates app link gradle tasks and remove vm services ( #131805 )
...
1. Remove vm service registration
2. combine print<variant>ApplicationId and print<variant>AppLinkDomain into one task dump<variant>AppLinkSettings, which dump all the data in a json file
The deeplink validation tool will be a static app in devtool instead of regular app. A Static app doesn't require a running app; therefore, we can't call these API through vmservices. I decided to convert these API into flutter analyzer command, which will be done in a separate PR https://github.com/flutter/flutter/pull/131009 .
The reason these print tasks are converted into file dumps is to reduce the amount of data encoding and decoding. Instead of passing data through stdout, the devtool can read the files generated by gradle tasks instead.
2023-08-18 18:42:58 +00:00
engine-flutter-autoroll
6cefc2ea61
Roll Flutter Engine from 58f7d8ee3e2c to 83fdadaf12f0 (7 revisions) ( #132857 )
...
58f7d8ee3e...83fdadaf12zanderso@users.noreply.github.com Update Impeller
benchmarks.md with a Pixel 7 link (flutter/engine#44834 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
7xOzci7fempFgHNk9... to pSqQ556xmZp7S4np5... (flutter/engine#44846 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Dart SDK from
121fcbd8124c to 8109103e041b (1 revision) (flutter/engine#44844 )
2023-08-18 jonahwilliams@google.com [Impeller] add trace events for
VkRenderPass and VkFrameBuffer creation. (flutter/engine#44837 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
Tnp43n_nAR2N0l_gY... to onEHyyETXAMieDyfP... (flutter/engine#44845 )
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from 1e62a2d4c429 to
c9294edc03b9 (2 revisions) (flutter/engine#44843 )
2023-08-18 leroux_bruno@yahoo.fr [Android] Expose channel buffer resize
and overflow calls (flutter/engine#44434 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 7xOzci7fempF to pSqQ556xmZp7
fuchsia/sdk/core/mac-amd64 from Tnp43n_nAR2N to onEHyyETXAMi
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-18 11:28:02 -07:00
Mustafa Ateş Uzun
6875827f46
doc: add flag params ( #132485 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-18 17:48:05 +00:00
gmilou
58019b3428
Add a new MatrixTransition and refactor ScaleTransition and RotationT… ( #131084 )
...
â¦ransition to derive from it.
The MatrixTransition class uses a callback to handle any value => Matrix animation.
The alignment and filterQuality logic that was in ScaleTransition and RotationTransition is now factored in MatrixTransition.
The ScaleTransition.scale and RotationTransition.turns getters had to be kept because they're still referenced in https://github.com/flutter/packages/tree/main/packages/animations , and https://github.com/flutter/packages/flutter/test/ . I plan to remove the references there, once this PR is generally available, and then remove the getters here.
A RotationTransition test was updated to use matrixMoreOrLessEquals because using Matrix4.rotationZ doesn't have the special cases Transform.Rotation had, and zeroes in matrix weren't exactly zeroes.
fixes #130946
2023-08-18 16:50:06 +00:00
Andrey Suvorov
1cfba2620a
fixes l10n for CupertinoDatePicker in monthYear mode ( #130934 )
...
This PR fixes l10n issue when months names are being used in incorrect form in CupertinoDatePicker in CupertinoDatePickerMode.yearMonth (#130930 ).
The idea of this proposal is to add an optional parameter `standalone` for `CupertinoLocalizations.datePickerMonth` to be able to choose when to use months names in base form (intl DateSymbols.STANDALONEMONTHS) and when in day-dependent form (intl DateSymbols.MONTHS)
<details>
<summary>Before</summary>
<img width="366" alt="image" src="https://github.com/flutter/flutter/assets/32621121/1dd54fa7-6dd9-4053-889b-57134c145432 ">
<img width="387" alt="image" src="https://github.com/flutter/flutter/assets/32621121/c176070e-73e4-49d3-883b-ba31eca6d1d7 ">
</details>
<details>
<summary>After</summary>
<img width="369" alt="image" src="https://github.com/flutter/flutter/assets/32621121/255594f1-219d-4bd4-9b75-1012912f8ab0 ">
<img width="378" alt="image" src="https://github.com/flutter/flutter/assets/32621121/16bbb41f-3f62-4446-bf41-e27140b649a9 ">
</details>
2023-08-18 16:38:54 +00:00
engine-flutter-autoroll
5a556f8ecd
Roll Packages from 3b602e77e69a to 4c16f3ef4033 (3 revisions) ( #132848 )
...
3b602e77e6...4c16f3ef40katelovett@google.com [two_dimensional_scrollables] TableView (flutter/packages#4536 )
2023-08-17 stuartmorgan@google.com [ci] Update minimums for 3.13 stable (flutter/packages#4731 )
2023-08-17 10687576+bparrishMines@users.noreply.github.com Update stable version to efbf63d9c66b9f6ec30e9ad4611189aa80003d31 (flutter/packages#4730 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-18 15:45:21 +00:00
Victoria Ashworth
b52297da06
Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR ( #132803 )
...
Starting in Xcode 15, when building macOS, DT_TOOLCHAIN_DIR cannot be used to evaluate LD_RUNPATH_SEARCH_PATHS or LIBRARY_SEARCH_PATHS. `xcodebuild` error message recommend using TOOLCHAIN_DIR instead.
Since Xcode 15 isn't in CI, I tested it in a one-off `led` test:
* [Pre-fix failure](04e485a0b1/+/build.protod454a3e181/+/build.protohttps://github.com/flutter/flutter/issues/132755 .
2023-08-18 15:24:55 +00:00
Tae Hyung Kim
312ef54115
[flutter_tools] Generate localizations on flutter pub get ( #132172 )
...
Currently, flutter pub get generates localizations if there exists an l10n.yaml file where synthetic-package is not false. However, for any user who needs to turn off synthetic-package, their localizations are not generated. This PR should make the behavior more consistent. (Also it seems good to make it so that running flutter pub get once resolves all the dependencies so that people can get to work without running flutter gen-l10n manually.)
Fixes https://github.com/flutter/flutter/issues/84979 .
2023-08-18 15:01:09 +00:00
engine-flutter-autoroll
633b1ce402
Roll Flutter Engine from 866b43f656e4 to 58f7d8ee3e2c (1 revision) ( #132820 )
...
866b43f656...58f7d8ee3eskia-flutter-autoroll@skia.org Roll Dart SDK from 7101eb7569ac to 121fcbd8124c (1 revision) (flutter/engine#44832 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-18 04:00:25 +00:00
Navaron Bracke
03664d0acb
Fix description in index.html / manifest.json getting double quoted ( #131842 )
...
This PR adjusts the quoting of the project description not not apply twice in the index.html / manifest.json of web builds.
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/131834
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-18 02:58:20 +00:00
engine-flutter-autoroll
a1e3b3dae4
Roll Flutter Engine from 5019d6da655c to 866b43f656e4 (8 revisions) ( #132812 )
...
5019d6da65...866b43f656skia-flutter-autoroll@skia.org Roll Skia from 1bec2899ace8 to 1e62a2d4c429 (1 revision) (flutter/engine#44829 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 7e4e5796ee99 to 7101eb7569ac (2 revisions) (flutter/engine#44828 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from e4be2cab442f to 1bec2899ace8 (1 revision) (flutter/engine#44826 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from bfd45173e5e3 to e4be2cab442f (3 revisions) (flutter/engine#44824 )
2023-08-17 gspencergoog@users.noreply.github.com Add Doxygen doc generation for iOS, macOS, Linux, Windows, and Impeller (flutter/engine#43915 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VW7WAVPT3Cj5erlae... to Tnp43n_nAR2N0l_gY... (flutter/engine#44823 )
2023-08-17 jason-simmons@users.noreply.github.com Fix FlutterInjectorTest assumptions about how the executor service assigns tasks to threads (flutter/engine#44775 )
2023-08-17 john@johnmccutchan.com Reenable HardwareBuffer backed Android Platform Views on SDK >= 29 (flutter/engine#44790 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from VW7WAVPT3Cj5 to Tnp43n_nAR2N
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-18 00:50:31 +00:00
Jason Simmons
579991cbb3
Fix the name of the local-engine-host flag in the warning message ( #132808 )
2023-08-18 00:11:57 +00:00
Justin McCandless
f68d03f1cd
Reland root predictive back ( #132249 )
...
Root predictive back (https://github.com/flutter/flutter/pull/120385 ) was reverted in https://github.com/flutter/flutter/pull/132167 . This PR is an attempt to reland it.
The reversion happened due to failed Google tests (b/295073110).
2023-08-17 23:55:05 +00:00
Greg Spencer
ced3e76626
Reland: "Reorganize and clarify API doc generator" ( #132353 ) ( #132710 )
...
## Description
This re-lands #132353 with some additional options for keeping around the staging directory, so that the recipe for publishing docs can give those options and have the staging directory left around for deploying to the website.
Reverted in #132613
## Related Issues
- https://flutter-review.googlesource.com/c/recipes/+/49580
2023-08-17 23:53:06 +00:00
Ian Hickson
d19fb632ec
Allow date pickers to not have selected date ( #132343 )
...
This enables our various date picker classes to have a null `initialDate`.
It also fixes the logic of some of the widgets which used to do something when you _changed_ the `initial*` parameters, which is wrong for `initial*` properties (they by definition should only impact the initial state) and wrong for properties in general (behaviour should not change based on whether the widget was built with a new value or not, that violates the reactive design principles).
Fixes https://github.com/flutter/flutter/issues/638 .
2023-08-17 23:45:57 +00:00
LouiseHsu
3f34b480c8
[Framework] Add Share to selection controls ( #132599 )
...
In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc.
https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765
This PR is the framework portion of the changes that will allow Share to be implemented.
The corresponding merged engine PR is [here](https://github.com/flutter/engine/pull/44554 )
This PR addresses https://github.com/flutter/flutter/issues/107578
More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls )
2023-08-17 23:36:11 +00:00
engine-flutter-autoroll
ac66bdb7ec
Roll Packages from 9bf208f4beb6 to 3b602e77e69a (3 revisions) ( #132784 )
...
9bf208f4be...3b602e77e6ian@hixie.ch Add advice on code review for this repo (flutter/packages#4698 )
2023-08-16 stuartmorgan@google.com [platform] Import the `platform` package (flutter/packages#4613 )
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter from f0e7c5181641 to 2502b51f86c1 (15 revisions) (flutter/packages#4722 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-17 23:30:14 +00:00
engine-flutter-autoroll
fb7baa9e02
Roll Flutter Engine from 533670269c99 to 5019d6da655c (15 revisions) ( #132797 )
...
533670269c...5019d6da65dkwingsmt@users.noreply.github.com Basic view management for engine classes (flutter/engine#42991 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from d0d390f9310d to bfd45173e5e3 (5 revisions) (flutter/engine#44820 )
2023-08-17 matanlurey@users.noreply.github.com Implement 2 suggested Clang Tidy fixes we don't look for yet. (flutter/engine#44816 )
2023-08-17 louiseh0313@gmail.com Add share to selection controls (flutter/engine#44554 )
2023-08-17 zanderso@users.noreply.github.com Adds new builders for partial clang-tidy checks. (flutter/engine#44811 )
2023-08-17 41930132+hellohuanlin@users.noreply.github.com [ios][ios17]fix auto correction highlight on top left corner (flutter/engine#44779 )
2023-08-17 109111084+yaakovschectman@users.noreply.github.com [Windows] Delay enabling app lifecycle states until requested (flutter/engine#44238 )
2023-08-17 dkwingsmt@users.noreply.github.com Move `viewConfiguration` parsing from `PlatformDispatcher` to `_hooks` (flutter/engine#44787 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 92c32df13d31 to 7e4e5796ee99 (2 revisions) (flutter/engine#44810 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from c4805a975ab3 to d0d390f9310d (2 revisions) (flutter/engine#44807 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cPncZK6z8HmuOmQr_... to 7xOzci7fempFgHNk9... (flutter/engine#44809 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from efb5a5e0b78b to c4805a975ab3 (2 revisions) (flutter/engine#44795 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from 11cb8cdd37c1 to efb5a5e0b78b (1 revision) (flutter/engine#44792 )
2023-08-17 matanlurey@users.noreply.github.com Passthrough stderr results of clang_tidy when --enable-check-profile. (flutter/engine#44789 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d6e1fca5dbdf to 92c32df13d31 (1 revision) (flutter/engine#44788 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cPncZK6z8Hmu to 7xOzci7fempF
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-17 23:30:12 +00:00
godofredoc
a70a852c66
Run gsutil with full python3 and full path. ( #132805 )
...
This is to prevent failures when the gsutil.py is not executable.
2023-08-17 23:09:44 +00:00
Polina Cherkasova
aa1bacb35a
Leaks fix. ( #132778 )
...
Fixes https://github.com/flutter/flutter/issues/132769
2023-08-17 12:11:24 -07:00
Michael Goderbauer
f0bfd7d641
Send examples/api PRs to the framework review queue ( #132768 )
2023-08-17 18:56:57 +00:00
Jason Simmons
f1fa9e34c6
Update the tracing_tests Dart SDK version constraint to fix an analyzer error ( #132753 )
2023-08-17 18:51:31 +00:00
Chinmoy
f1d04a46cb
Update Scrollable on ScrollBehaviour change. ( #131164 )
...
Fixes : #130793
2023-08-17 18:48:57 +00:00
Loïc Sharma
9e67e0e4a1
[Windows] Allow overwriting the cache's Dart SDK archive license file… ( #132777 )
...
Relands https://github.com/flutter/flutter/pull/132669 after it was reverted by https://github.com/flutter/flutter/pull/132773 . The test failures were fixed separately by https://github.com/flutter/flutter/pull/132766
Tracking issue: https://github.com/flutter/flutter/issues/132592
Cherrypick issue: https://github.com/flutter/flutter/issues/132718
2023-08-17 18:45:18 +00:00
Zachary Anderson
6a02483044
Run new_gallery__transition_perf on Pixel 7 and Samsung A02 ( #132772 )
2023-08-17 11:42:57 -07:00
Jason Simmons
609382a8c4
Disable test order randomization on some leak tracker tests that are failing with today's seed ( #132766 )
2023-08-17 17:40:05 +00:00
yaakovschectman
e10d74b4d5
Revert "[Windows] Allow overwriting the cache's Dart SDK archive license file" ( #132773 )
...
Reverts flutter/flutter#132669
Introduced failure on `windows/mac/linux framework_library_tests`.
```
05:41 +7318 ~22 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_bar_theme_test.dart: (tearDownAll) [E]
Expected: leak free
Actual: <Instance of 'Leaks'>
Which: contains leaks:
# The text is generated by leak_tracker.
# For leak troubleshooting tips open:
# https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
notDisposed:
total: 3
objects:
ValueNotifier<_OverlayEntryWidgetState?>:
test: Constructor parameters override theme parameters
identityHashCode: 407433615
FocusScopeNode:
test: Constructor parameters override theme parameters
identityHashCode: 513181650
FocusScopeNode:
test: Constructor parameters override theme parameters
identityHashCode: 704743556
package:matcher expect
package:flutter_test/src/widget_tester.dart 458:18 expect
package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 81:5 _tearDownTestingWithLeakTracking
===== asynchronous gap ===========================
dart:async _CustomZone.registerBinaryCallback
package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 59:9 configureLeakTrackingTearDown.<fn>
```
2023-08-17 17:26:17 +00:00
Loïc Sharma
7ee864ee37
[Windows] Allow overwriting the cache's Dart SDK archive license file ( #132669 )
...
https://github.com/flutter/engine/pull/43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file.
This is a short-term solution that will be cherry-picked for the next [3.14 beta release](https://github.com/flutter/flutter/issues/132267 ). Addresses https://github.com/flutter/flutter/issues/132592 .
The long-term solution is tracked by https://github.com/flutter/flutter/issues/132702
2023-08-17 16:08:08 +00:00
Bernardo Ferrari
b7046b32db
Improve and optimize non-uniform Borders. ( #124417 )
...
~~Using the same priority order as a Border without borderRadius, it is possible to draw them on top of each other. This is better than the current behavior (crash!) and would work well for a "one color on top, another on bottom" scenario.~~
~~With this, if approved, we move the current number of possible exceptions from 4 to 1 (`BoxShape.circle` + `borderRadius`).~~
~~It is kind of odd how `borderRadius.zero` to `borderRadius != BorderRadius.zero` change, but I think it is better than crashing. Alternatively, we just remove the "original function" and see if any goldens are affected.~~
<img width="448" alt="image" src="https://user-images.githubusercontent.com/351125/236550350-7499d758-5b44-40e6-9105-32671eb21998.png ">
Another one for @gspencergoog. If this works, we could make the paint method public and re-use in the InputBorder PR (if that's also approved). Single line fix.
2023-08-17 04:04:23 +00:00
engine-flutter-autoroll
fe9c7f4fa7
Roll Flutter Engine from dbfe71c898b6 to 533670269c99 (15 revisions) ( #132717 )
...
dbfe71c898...533670269cskia-flutter-autoroll@skia.org Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786 )
2023-08-16 jason-simmons@users.noreply.github.com Revert "Conditionally enable HardwareBuffer backed platform views (#44744 )" (flutter/engine#44785 )
2023-08-16 dnfield@google.com [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782 )
2023-08-16 john@johnmccutchan.com Switch some ERROR logs to WARNING logs (flutter/engine#44784 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778 )
2023-08-16 matanlurey@users.noreply.github.com Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Zp9or9YwxZHHPeQbA... to VW7WAVPT3Cj5erlae... (flutter/engine#44777 )
2023-08-16 louiseh0313@gmail.com Fix search web test (flutter/engine#44704 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GpKKtPGPMiRcY0kcz... to cPncZK6z8HmuOmQr_... (flutter/engine#44769 )
2023-08-16 godofredoc@google.com Remove duplicated v1 builds. (flutter/engine#44767 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from d029f149a806 to e65aabc26c86 (4 revisions) (flutter/engine#44768 )
2023-08-16 zanderso@users.noreply.github.com Split lint.sh into separate scripts for clang-tidy and pylint (flutter/engine#44763 )
2023-08-16 john@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GpKKtPGPMiRc to cPncZK6z8Hmu
fuchsia/sdk/core/mac-amd64 from Zp9or9YwxZHH to VW7WAVPT3Cj5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-17 02:05:08 +00:00
Kate Lovett
ca319278bd
Fix lower bound of children from TwoDimensionalChildBuilderDelegate ( #132713 )
...
Found in https://github.com/flutter/packages/pull/4536
The max x and max y index should allow for a case where there are no children in the viewport.
This should be CP'd into stable once it lands.
2023-08-17 02:05:06 +00:00
Ian Hickson
8864395034
Improvements to EditableText documentation ( #132532 )
2023-08-17 01:02:17 +00:00
Matan Lurey
b66878a61e
Treat missing --local-engine-host as fatal on CI-like systems. ( #132707 )
...
Partial work towards https://github.com/flutter/flutter/issues/132245 .
The goal here is to "sniff" out any missing pieces that would block engine builds, rolls, benchmarks and so on before requiring humans to provide the parameter. The implementation is based on a [short discussion with @christopherfujino](https://discord.com/channels/608014603317936148/608022056616853515/1141503921546875110 ):
@matanlurey:
> Not sure whether to post here or â hackers-infra-ð¡ , but is there a way to (and is it advisable to) detect whether the tool is running in a CI environment? I'd like to "soft enforce" --local-engine-host being provided strictly on CI, make sure that lands well, and then "upgrade" it to being non-CI invocations as well (re: https://github.com/flutter/flutter/issues/132245 ).
>
> Also happy to get talked out of this idea ð
@christopherfujino:
> we have a check, lemme find it
> whether or not it is advisable, idk
> https://github.com/flutter/flutter/blob/flutter-3.14-candidate.0/packages/flutter_tools/lib/src/base/bot_detector.dart#L30
>
> (...)
>
> is your desire to get early signal before enforcing t his for humans to prevent functionality churn of landing and reverting and re-landing?
>
> (yes)
>
> uhh, sure, that's advisable ð
2023-08-17 00:41:03 +00:00
Kate Lovett
af0ca97842
Fix bad pattern in 2D tests ( #132709 )
...
Fixes some poor tests choices in the 2D tests that were identified in https://github.com/flutter/packages/pull/4536
2023-08-17 00:13:04 +00:00
Polina Cherkasova
1a0077dc81
Upgrade flutter packages. ( #132697 )
2023-08-16 16:26:58 -07:00
Renzo Olivares
0e15ab54d1
Triple tap selection should not move beyond text boundary at the tapped location ( #132357 )
...
This PR makes sure we do not select beyond the text boundary at the tapped position unless, we tap at the end of the text which in that case we should select the previous text boundary.
```dart
// if x is a boundary defined by `textBoundary`, most textBoundaries (except
// LineBreaker) guarantees `x == textBoundary.getLeadingTextBoundaryAt(x)`.
// Use x - 1 here to make sure we don't get stuck at the fixed point x.
final int start = textBoundary.getLeadingTextBoundaryAt(extent.offset - 1) ?? 0;
```
This was originally carried over from f468f3366c/packages/flutter/lib/src/widgets/editable_text.dart (L4167-L4179)Fixes #132126
2023-08-16 23:05:16 +00:00
Faisal Ansari
2cb762d154
fixed documentation error input decorator ( #132124 )
...
In the documentation of _Shaker in InputDecoration "Used to "shake" the floating label to the left and right"
to the left was twice I have removed it.
2023-08-16 23:03:21 +00:00
Polina Cherkasova
0ea523cf93
Fix not-disposed _InputBorderGap. ( #132694 )
...
Fixes: https://github.com/flutter/flutter/issues/132620
2023-08-16 22:38:59 +00:00
Matan Lurey
223ae5d3ac
Add support for LOCAL_ENGINE_HOST to Linux/Mac/Win builds. ( #132579 )
...
Partial work towards https://github.com/flutter/flutter/issues/132245 .
I also couldn't help myself to do a very minor refactor and add some comments to `LocalEngineInfo` because I was getting confused myself implementing it.
2023-08-16 22:24:51 +00:00
Michael Goderbauer
14f9ed28d0
Analyze doc code snippets for all packages for which we publish docs ( #132607 )
...
Fixes TODO in the analyzer script :)
2023-08-16 22:24:48 +00:00
yaakovschectman
e52e8da303
Revert "Roll Flutter Engine from dbfe71c898b6 to 12cafaeb9e31 (1 revision)" ( #132698 )
...
Reverts flutter/flutter#132677
Causes failure for `Linux firebase_abstract_method_smoke_test`
2023-08-16 21:58:18 +00:00
engine-flutter-autoroll
8617a18575
Roll Flutter Engine from dbfe71c898b6 to 12cafaeb9e31 (1 revision) ( #132677 )
...
dbfe71c898...12cafaeb9ejohn@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 19:36:49 +00:00
engine-flutter-autoroll
06cb9a676a
Roll Flutter Engine from 8f5f8b34c374 to dbfe71c898b6 (1 revision) ( #132673 )
...
8f5f8b34c3...dbfe71c898zanderso@users.noreply.github.com Adds runIf to linux_clang_tidy (flutter/engine#44759 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 18:25:48 +00:00
Polina Cherkasova
112f4293dc
Fix some leaks and add test to test cover remaining in a simple way. ( #131373 )
...
Contributes to https://github.com/flutter/flutter/issues/130467
Filed issue: https://github.com/flutter/flutter/issues/132620
2023-08-16 18:19:58 +00:00
engine-flutter-autoroll
371a9fc835
Roll Flutter Engine from 70b5700b79f6 to 8f5f8b34c374 (2 revisions) ( #132665 )
...
70b5700b79...8f5f8b34c3skia-flutter-autoroll@skia.org Roll Skia from f30893561924 to d029f149a806 (1 revision) (flutter/engine#44764 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 3ab12f40c2a4 to f30893561924 (1 revision) (flutter/engine#44761 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 17:33:44 +00:00
chunhtai
99790cc8c0
Add more use cases to a11y assessments ( #132325 )
...
see [go/flutter-gar-reporting-q3-2023](http://go/flutter-gar-reporting-q3-2023 )
2023-08-16 16:44:11 +00:00
engine-flutter-autoroll
33ef5e413f
Roll Packages from 84218b9d834c to 9bf208f4beb6 (7 revisions) ( #132659 )
...
84218b9d83...9bf208f4beengine-flutter-autoroll@skia.org Manual roll Flutter from 9b6945b465a1 to f0e7c5181641 (63 revisions) (flutter/packages#4719 )
2023-08-15 31859944+LongCatIsLooong@users.noreply.github.com Update palette_generator_test.dart (flutter/packages#4720 )
2023-08-15 mit@google.com [pigeon] Fix typo in README.md (flutter/packages#4707 )
2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Explicitly remove READ_EXTERNAL_STORAGE permission (flutter/packages#4716 )
2023-08-15 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds support for retrieving user agent (flutter/packages#4563 )
2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for video capture (flutter/packages#4620 )
2023-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.3 to 2.21.4 (flutter/packages#4706 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 16:07:41 +00:00
engine-flutter-autoroll
2502b51f86
Roll Flutter Engine from f186f1e9dc88 to 70b5700b79f6 (1 revision) ( #132655 )
...
f186f1e9dc...70b5700b79skia-flutter-autoroll@skia.org Roll Dart SDK from 80b9a90ae563 to cc5eeac65f89 (1 revision) (flutter/engine#44758 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 15:14:07 +00:00
engine-flutter-autoroll
9f46ed7449
Roll Flutter Engine from e8670f03a9b1 to f186f1e9dc88 (2 revisions) ( #132649 )
...
e8670f03a9...f186f1e9dcskia-flutter-autoroll@skia.org Roll Skia from cb3451491f11 to 3ab12f40c2a4 (1 revision) (flutter/engine#44756 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 586a6309e3a1 to cb3451491f11 (2 revisions) (flutter/engine#44755 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 12:14:41 +00:00
