Ross Llewallyn
2c3c6b05da
Docs typo: comprised -> composed ( #137896 )
...
This is a simple, common grammar issue. See here:
https://en.wikipedia.org/wiki/Comprised_of
2023-11-10 15:00:35 -08:00
Chinmoy
0bde95dc06
Deprecates onWillAccept and onAccept callbacks in DragTarget. ( #133691 )
...
This PR deprecates `onWillAccept` and `onAccept` over `onWillAcceptWithDetails` and `onAcceptWithDetails`.
Fixes : #133347
2023-11-10 22:47:22 +00:00
Chris Bracken
d71fe92ec4
[macOS] Suppress Xcode 15 createItemModels warning ( #138243 )
...
As of Xcode 15 on macOS Sonoma, the following message is (repeatedly)
output to stderr during builds (repros on non-Flutter apps). It is
supppressed in xcode itself, but not when run from the command-line.
```
2023-11-10 10:44:58.031 xcodebuild[61115:1017566] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot11/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-22267/IDEFoundation/Provisioning/Capabilities Infrastructure/IDECapabilityQuerySelection.swift:103
Details: createItemModels creation requirements should not create capability item model for a capability item model that already exists.
Function: createItemModels(for:itemModelSource:)
Thread: <_NSMainThread: 0x6000027c0280>{number = 1, name = main}
Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
```
This suppresses this message from stderr in our macOS build logs.
Issue: https://github.com/flutter/flutter/issues/135277
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-11-10 14:14:32 -08:00
engine-flutter-autoroll
29fd1a835a
Roll Flutter Engine from 275ddb296ec9 to 9d8a1125640d (1 revision) ( #138252 )
...
275ddb296e...9d8a112564skia-flutter-autoroll@skia.org Roll Skia from c4af3caee55c to d06840545bff (1 revision) (flutter/engine#47926 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 22:02:50 +00:00
Kostia Sokolovskyi
a6aaad3487
GestureRecognizer should dispatch creation and disposal events. ( #138223 )
2023-11-10 13:14:14 -08:00
engine-flutter-autoroll
28ea2f848d
Roll Flutter Engine from 5c2e16c5a95a to 275ddb296ec9 (1 revision) ( #138249 )
...
5c2e16c5a9...275ddb296eskia-flutter-autoroll@skia.org Roll Skia from 126c8faf6c36 to c4af3caee55c (4 revisions) (flutter/engine#47920 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 21:11:10 +00:00
engine-flutter-autoroll
ddc8126d8d
Roll Packages from b69f54ee0358 to a6821898bd5a (3 revisions) ( #138239 )
...
b69f54ee03...a6821898bdengine-flutter-autoroll@skia.org Roll Flutter from 4b4a1feb46d1 to f66215027e14 (17 revisions) (flutter/packages#5361 )
2023-11-09 32538273+ValentinVignal@users.noreply.github.com [go_router] Retain query parameter during refresh and first redirect (flutter/packages#5276 )
2023-11-09 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/packages#5356 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 20:46:16 +00:00
engine-flutter-autoroll
e98b55d878
Roll Flutter Engine from e5b75177ac8e to 5c2e16c5a95a (1 revision) ( #138247 )
...
e5b75177ac...5c2e16c5a9skia-flutter-autoroll@skia.org Roll Skia from 384f047aa0b6 to 126c8faf6c36 (4 revisions) (flutter/engine#47916 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 20:25:43 +00:00
Elias Yishak
7a278ae47c
CommandResultEvent migrated (#138165 )
...
Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251
This event was only called from one file (`flutter_command.dart`). With the previous implementation, we actually sent 2 events, one for the result of the `commandPath` and another containing the `maxRss` value from `ProcessInfo`.
I have consolidated this down to just one event and used a function to safely get the `maxRss` value, or return null when if there was an error getting that integer value
2023-11-10 20:19:50 +00:00
John McCutchan
af246a51b7
Fix #128925 by properly setting the Android Event Source ( #138241 )
...
Touch events were being ignored by Google Maps because we were always setting
the event source to UNKNOWN. This PR maps our PointerDeviceKind to
Android's InputDevice.SOURCE_* enums.
Manually tested with Google Maps.
https://github.com/flutter/flutter/issues/128925
2023-11-10 12:02:54 -08:00
engine-flutter-autoroll
2a979ec60d
Roll Flutter Engine from 77349dc8e27b to e5b75177ac8e (2 revisions) ( #138244 )
...
77349dc8e2...e5b75177acskia-flutter-autoroll@skia.org Roll Dart SDK from 33307e78db2b to 91c4a92a64ea (6 revisions) (flutter/engine#47915 )
2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 5df579e87784 to 384f047aa0b6 (4 revisions) (flutter/engine#47912 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 19:44:13 +00:00
engine-flutter-autoroll
d42d639924
Roll Flutter Engine from a5eab0d281fe to 77349dc8e27b (4 revisions) ( #138237 )
...
a5eab0d281...77349dc8e243054281+camsim99@users.noreply.github.com [Android] Bump robolectric version to support unit testing on Android 34 (flutter/engine#47768 )
2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from ae6df7264c6e to 5df579e87784 (1 revision) (flutter/engine#47910 )
2023-11-10 mdebbar@google.com [web] Move styling from FlutterViewEmbedder to StyleManager (flutter/engine#47489 )
2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from e23e328584a1 to ae6df7264c6e (1 revision) (flutter/engine#47907 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 18:41:18 +00:00
Elias Yishak
9a76efc8e3
Update analytics constructor to include FLUTTER_HOST ( #138107 )
...
Fixes issues:
- https://github.com/flutter/flutter/issues/138035
Similar to GA3, we will now record the host running the flutter tool, such as VSCode, stored in the `FLUTTER_HOST` env variable
2023-11-10 17:44:08 +00:00
Sam Rawlins
33c0f27464
Prepare the analyze_once test for removal of analysis_options_user support ( #138229 )
...
Fixes https://github.com/flutter/flutter/issues/138227 . Work towards https://github.com/flutter/flutter/issues/82948
In c033718da0
2023-11-10 17:38:56 +00:00
engine-flutter-autoroll
cdc873ec7d
Roll Flutter Engine from b020893cba29 to a5eab0d281fe (5 revisions) ( #138231 )
...
b020893cba...a5eab0d281flutter/engine#47909 )
2023-11-10 15619084+vashworth@users.noreply.github.com Temporarily disable test UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#47883 )
2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 5075f1572bfe to e23e328584a1 (3 revisions) (flutter/engine#47900 )
2023-11-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 33307e78db2b to 5075ac874117 (3 revisions) (flutter/engine#47899 )
2023-11-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0pD5ceqf-e9y9NTNn... to 8sk2n2-NXJ-ceyc7T... (flutter/engine#47898 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0pD5ceqf-e9y to 8sk2n2-NXJ-c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 17:23:19 +00:00
Dan Field
9295035e83
Drop unnecessary URI encoding of websocket url in listener ( #137969 )
...
This seems like an old remnant that is now completely unnecessary.
2023-11-10 17:21:17 +00:00
Tirth
983b2f6bc8
Adds useRootNavigator property to PopupMenuButton widget. ( #137453 )
...
Adds `useRootNavigator` property to `PopupMenuButton` widget.
Fixes #95425
2023-11-10 16:14:16 +00:00
engine-flutter-autoroll
d7bf0a8f3d
Roll Flutter Engine from de9c4d672ad7 to b020893cba29 (1 revision) ( #138206 )
...
de9c4d672a...b020893cba58529443+srujzs@users.noreply.github.com Remove implements of JS types on @staticInterop classes (flutter/engine#47869 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 06:00:32 +00:00
engine-flutter-autoroll
e6228d4319
Roll Flutter Engine from e80af854bd3a to de9c4d672ad7 (2 revisions) ( #138204 )
...
e80af854bd...de9c4d672askia-flutter-autoroll@skia.org Roll Skia from 971e197ca81a to 5075f1572bfe (2 revisions) (flutter/engine#47885 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 583c85e03fb0 to 971e197ca81a (1 revision) (flutter/engine#47879 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 04:39:59 +00:00
Nate Bosch
fa3a37c76d
Use merge-base in find_commit.dart ( #138033 )
...
Closes #97595
The prior approach of manually diffing the entire log chain is less
efficient, and only found the original branch point ignoring subsequent
merges. The limitation forced PR workflows into rebasing and force
pushing new history to get the branch point far enough for CI to pass.
Use `git merge-base` to find the latest common commit with the main
branch.
Add an `allowFailure` argument to the `git` utility to use a more
specific failure in the case of no shared history when this command will
fail with a generic error.
Use `^branch` with the `git log` commands to exclude shared history and
more easily count the unique commits on each branch.
Drop the `Commit` abstraction. Parse directly to timestamp or line counts.
2023-11-10 02:15:27 +00:00
engine-flutter-autoroll
ed92828968
Roll Flutter Engine from d4a51fae094c to e80af854bd3a (1 revision) ( #138199 )
...
d4a51fae09...e80af854bd30870216+gaaclarke@users.noreply.github.com Expanded the performance lints (flutter/engine#47868 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 01:26:26 +00:00
flutter-pub-roller-bot
bc8acbe14b
Roll pub packages ( #138163 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-11-10 01:20:14 +00:00
engine-flutter-autoroll
98edc08b99
Roll Flutter Engine from 9a3494e31171 to d4a51fae094c (1 revision) ( #138198 )
...
9a3494e311...d4a51fae09skia-flutter-autoroll@skia.org Roll Skia from 6ff0fdf79bfa to 583c85e03fb0 (6 revisions) (flutter/engine#47877 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-10 00:30:04 +00:00
Victoria Ashworth
4eda3b96c5
Move Mac_build_test flutter_gallery__transition_perf_e2e_ios to staging ( #138196 )
...
Seems that bots recently upgraded to macOS 13 are missing certs (https://github.com/flutter/flutter/issues/138194 ). Temporarily move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to staging.
2023-11-10 00:12:06 +00:00
engine-flutter-autoroll
9111d7f1cd
Roll Flutter Engine from 670e85f184d3 to 9a3494e31171 (2 revisions) ( #138191 )
...
670e85f184...9a3494e311jonahwilliams@google.com [Impeller] Remove unused/untested Path APIs. (flutter/engine#47841 )
2023-11-09 athom@google.com Remove references to the runtime/third_party directory in the Dart SDK (flutter/engine#47853 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 23:01:05 +00:00
Camille Simon
c66bb0a18a
[Android] Support Android 34 (take 2) ( #137967 )
...
Re-lands https://github.com/flutter/flutter/pull/137191 .
The fix for the issue causing that PR to be reverted was tested in this PR but ultimately landed separately in https://github.com/flutter/flutter/pull/138093 .
2023-11-09 22:40:15 +00:00
engine-flutter-autoroll
ce8c3f2022
Roll Flutter Engine from 0fae75f963e4 to 670e85f184d3 (2 revisions) ( #138187 )
...
0fae75f963...670e85f184skia-flutter-autoroll@skia.org Roll Skia from ff418c512205 to 6ff0fdf79bfa (2 revisions) (flutter/engine#47874 )
2023-11-09 goderbauer@google.com Reland "Remove physical geometry" (flutter/engine#47872 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 22:16:15 +00:00
Renzo Olivares
3225aa5815
Fix text selection in SearchAnchor/SearchBar ( #137636 )
...
This changes fixes text selection gestures on the search field when using `SearchAnchor`.
Before this change text selection gestures did not work due to an `IgnorePointer` in the widget tree.
This change:
* Removes the `IgnorePointer` so the underlying `TextField` can receive pointer events.
* Introduces `TextField.onTapAlwaysCalled` and `TextSelectionGestureDetector.onUserTapAlwaysCalled`, so a user provided on tap callback can be called on consecutive taps. This is so that the user provided on tap callback for `SearchAnchor/SearchBar` that was previously only handled by `InkWell` will still work if a tap occurs in the `TextField`s hit box. The `TextField`s default behavior is maintained outside of the context of `SearchAnchor/SearchBar`.
Fixes https://github.com/flutter/flutter/issues/128332 and #134965
2023-11-09 22:12:01 +00:00
engine-flutter-autoroll
8b150bd076
Roll Flutter Engine from ca30d7df7105 to 0fae75f963e4 (2 revisions) ( #138174 )
...
ca30d7df71...0fae75f963mdebbar@google.com [web] Refactor a11y announcements out of FlutterViewEmbedder (flutter/engine#47487 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from a58076ed871a to ff418c512205 (5 revisions) (flutter/engine#47871 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 21:36:18 +00:00
hangyu
c4b11d801a
Make it possible to disable tapping to dismiss a tooltip. ( #137375 )
...
issue: https://github.com/flutter/flutter/issues/137438
Use case: I want to add action button is tooltip and thus want to disable tap to dismiss a tooltip.
2023-11-09 20:10:04 +00:00
engine-flutter-autoroll
e65c2681a9
Roll Flutter Engine from eb89b9440520 to ca30d7df7105 (4 revisions) ( #138166 )
...
eb89b94405...ca30d7df71skia-flutter-autoroll@skia.org Roll Skia from 775da2d297de to a58076ed871a (3 revisions) (flutter/engine#47866 )
2023-11-09 34871572+gmackall@users.noreply.github.com [Re-land] Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47839 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 6bd98dc2dffd to 33307e78db2b (1 revision) (flutter/engine#47865 )
2023-11-09 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/engine#47835 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 19:40:44 +00:00
Qun Cheng
6673fe5cb1
Add onSubmitted and onChanged for SearchAnchor and SearchAnchor.bar ( #136840 )
...
Fixes #130687 and #132915
This PR is to add two properties: `viewOnChanged` and `viewOnSubmitted` to `SearchAnchor` and `SearchAnchor.bar` so we can control the search bar on the search view.
2023-11-09 19:08:52 +00:00
engine-flutter-autoroll
659ed55a83
Roll Flutter Engine from 35cad36b7ec5 to eb89b9440520 (1 revision) ( #138162 )
...
35cad36b7e...eb89b94405skia-flutter-autoroll@skia.org Roll Skia from df263765ebc8 to 775da2d297de (2 revisions) (flutter/engine#47861 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 19:01:20 +00:00
Reid Baker
94079b9c61
Improved Java version parsing ( #138155 )
...
Fixes #135402
Add fallback logic for a different format of java version output and handle no patch versions.
Add tests for new logic output to prevent regressions.
2023-11-09 18:38:18 +00:00
engine-flutter-autoroll
750e232be1
Manual roll Flutter Engine from 8b490a9f1650 to 35cad36b7ec5 (15 revisions) ( #138154 )
...
Manual roll requested by zra@google.com
8b490a9f16...35cad36b7eflutter/engine#47862 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 7d0768083298 to df263765ebc8 (2 revisions) (flutter/engine#47860 )
2023-11-09 chillers@google.com Reland "Remove Fuchsia Mac SDK from DEPS" (flutter/engine#47823 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 8f8c9a144797 to 7d0768083298 (1 revision) (flutter/engine#47858 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 6f36eb00cacf to 6bd98dc2dffd (1 revision) (flutter/engine#47857 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 14933042494d to 6f36eb00cacf (4 revisions) (flutter/engine#47855 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from b055626ce8c2 to 8f8c9a144797 (1 revision) (flutter/engine#47854 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from b6ce84dc3e53 to b055626ce8c2 (1 revision) (flutter/engine#47850 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sD8HRA4JmXczujkqO... to 0pD5ceqf-e9y9NTNn... (flutter/engine#47847 )
2023-11-09 goderbauer@google.com Remove physical geometry (flutter/engine#47825 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from f3e4fd80eeeb to b6ce84dc3e53 (1 revision) (flutter/engine#47843 )
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from d9ec01cf15ff to f3e4fd80eeeb (3 revisions) (flutter/engine#47838 )
2023-11-09 737941+loic-sharma@users.noreply.github.com [Windows] Remove global state in keyboard tests (flutter/engine#47829 )
2023-11-08 mdebbar@google.com [web] Non-singleton implementation of ui.FlutterView (flutter/engine#47806 )
2023-11-08 gspencergoog@users.noreply.github.com Move window state update to window realize callback (flutter/engine#47713 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from sD8HRA4JmXcz to 0pD5ceqf-e9y
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 18:05:19 +00:00
engine-flutter-autoroll
f66215027e
Roll Packages from 94c762380828 to b69f54ee0358 (1 revision) ( #138149 )
...
94c7623808...b69f54ee03engine-flutter-autoroll@skia.org Roll Flutter from 5a6a3224fe15 to 4b4a1feb46d1 (21 revisions) (flutter/packages#5354 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 15:42:24 +00:00
Andrew Kolos
94550c6257
prevent tool crash when IntelliJValidatorOnMac encounters an installation with a missing CFBundleIdentifier ( #138095 )
...
Fixes https://github.com/flutter/flutter/issues/138029 (see my comment there for more info)
2023-11-09 03:46:25 +00:00
engine-flutter-autoroll
2f62af423a
Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) ( #138118 )
...
233bd6263c...8b490a9f16skia-flutter-autoroll@skia.org Roll Skia from 1241a903cd33 to d9ec01cf15ff (1 revision) (flutter/engine#47836 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 01:38:07 +00:00
flutter-pub-roller-bot
55e692229e
Roll pub packages ( #138114 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-11-09 00:48:01 +00:00
engine-flutter-autoroll
238ff7602a
Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) ( #138116 )
...
b3af5d64d3...233bd6263cflutter/engine#47834 )
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from e585bb68893b to 1241a903cd33 (2 revisions) (flutter/engine#47830 )
2023-11-08 34871572+gmackall@users.noreply.github.com Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47609 )
2023-11-08 chris@bracken.jp [macOS] Allocate textures as unique_ptr earlier (flutter/engine#47786 )
2023-11-08 flar@google.com Reland "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47824 )
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from e2b8ebe16203 to e585bb68893b (7 revisions) (flutter/engine#47826 )
2023-11-08 jonahwilliams@google.com [Impeller] Add support for specialization constants (III). (flutter/engine#47765 )
2023-11-08 30870216+gaaclarke@users.noreply.github.com [Impeller] Documented the 2 step in the gaussian blur. (flutter/engine#47822 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-09 00:08:26 +00:00
Victoria Ashworth
46dcb32c23
Use specific version of mac_toolchain ( #138115 )
...
Newer versions of mac_toolchain increase Xcode install times by ~2 minutes (https://github.com/flutter/flutter/issues/138109 ). As a temporary solution, we're using an older version of mac_toolchain.
2023-11-08 23:37:54 +00:00
Christopher Fujino
a408c6d976
[flutter_tools] disable flutter build AAR for plugins ( #137878 )
...
Per discord discussion, building an AAR out of a plugin project has not worked for years, so let's just disable the functionality. Context: https://github.com/flutter/flutter/issues/137564
2023-11-08 23:12:08 +00:00
engine-flutter-autoroll
88200f8c2b
Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) ( #138113 )
...
21f055f7d8...b3af5d64d3jason-simmons@users.noreply.github.com [Impeller] Create a global Vulkan instance in PlaygroundImplVK to prevent SwiftShader from being unloaded after a test completes (flutter/engine#47781 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-08 22:34:52 +00:00
engine-flutter-autoroll
59bd89945a
Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) ( #138111 )
...
5306213d9d...21f055f7d8flutter/engine#47821 )
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from fb69e696dc45 to e2b8ebe16203 (4 revisions) (flutter/engine#47815 )
2023-11-08 flar@google.com [Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching (flutter/engine#47736 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-08 21:49:54 +00:00
Michael Goderbauer
1ef6e99867
Remove physicalGeometry ( #138103 )
...
Looks like this was proactively added in https://github.com/flutter/engine/pull/20496 , but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.
Related engine PR: https://github.com/flutter/engine/pull/47825
2023-11-08 21:43:59 +00:00
Camille Simon
3215c492c8
[Android] Fix FlutterTestRunner.java deprecations ( #138093 )
...
Fixes deprecations causing unexpected standard error integration test failures: https://github.com/flutter/flutter/issues/138061 , https://github.com/flutter/flutter/issues/138063 , https://github.com/flutter/flutter/issues/138067 , https://github.com/flutter/flutter/pull/138077 .
Note that the issue this fixes was the same that was the cause for reverting https://github.com/flutter/flutter/pull/137191 . I made this same fix in https://github.com/flutter/flutter/pull/137967 and changed `Mac_android run_release_test` to run in presubmit to see a successful run for proof that this fix works.
2023-11-08 21:10:48 +00:00
Casey Hillers
04fdec2cd2
Remove fuchsia mac version ( #138101 )
...
https://github.com/flutter/flutter/issues/138087
Google testing failures are due to merge conflicts, there's no references on this file.
2023-11-08 21:06:56 +00:00
engine-flutter-autoroll
8b2e5b30a7
Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) ( #138108 )
...
6dbcf8f131...5306213d9d34871572+gmackall@users.noreply.github.com Switch to Android 14 for physical device firebase tests (flutter/engine#47016 )
2023-11-08 jonahwilliams@google.com [Impeller] remove capability to read from onscreen. (flutter/engine#47808 )
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from a4cce5236dcf to fb69e696dc45 (1 revision) (flutter/engine#47810 )
2023-11-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 15c286ed91ea to 14933042494d (5 revisions) (flutter/engine#47805 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-08 20:54:06 +00:00
Flutter GitHub Bot
35ca279ce9
Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky ( #138073 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_android hot_mode_dev_cycle__benchmark"
}
-->
Issue link: https://github.com/flutter/flutter/issues/138072
2023-11-08 20:24:04 +00:00
Dan Field
a3f2c7a4f8
Document additional cases ( #137957 )
...
Fixes https://github.com/flutter/flutter/issues/137924
Fixes https://github.com/flutter/flutter/issues/136885
The framework defaults to keeping the widget tree alive and ready to render regardless of application lifecycle events such as showing or hiding a view controller.
Add-to-app developers may be surprised by this, and tend to file bugs asking why `dispose` isn't called when the view is dismissed (or why memory usage is higher than expected after dismissing Flutter UI).
Adds documentation to explain the limitation and what to do instead.
/cc @zanderso @chinmaygarde @jonahwilliams @jason-simmons since we were discussing this in triage.
2023-11-08 19:10:22 +00:00
