7527 Commits

Author SHA1 Message Date
Michael Goderbauer
2d4e4dd6dc Fix timestamp comparison in BAT file (#8407) 2017-02-24 15:26:36 -08:00
Chris Bracken
b880dff349 Roll engine to 335daf19304ffbbf96c1e1ff840e546f17ce50d6 (#8404) 2017-02-24 13:37:42 -08:00
Adam Barth
f20c3d1032 Add a color argument to Container. (#8396)
It's common to just want a simple colored box. Simple thing should be simple,
so this patch adds a convenience argument to Continer for creating a box
decoration that is just a color.

Fixes #5555
2017-02-24 12:25:48 -08:00
Adam Barth
76394630ac Add barrierDismissable argument to showDialog (#8397)
In some situations, dialogs don't want the barrier to be dismissable.

Fixes #8354
2017-02-24 12:25:33 -08:00
Jason Simmons
b592868249 Roll the engine (#8402) 2017-02-24 12:20:22 -08:00
Adam Barth
a1d36f6892 Revert "Read package ID and activity name from .apk for Gradle-based builds." (#8400) 2017-02-24 11:23:14 -08:00
Michael Goderbauer
756842a29e Don't delete old Dart SDK if it is in use (#8385) 2017-02-24 09:28:58 -08:00
Adam Barth
eb839755b7 Overscrolls should appear below pinned headers (#8383)
With slivers, the app bar is part of the scroll view. Naively, the overscroll
appears at the beginning of the scroll view, but that's not the desired
behavior. Instead, the app bar should remained pinned to the top of the scroll
view and the overscroll should appear below the app bar, which is what this
patch does.

Fixes #8228
2017-02-24 08:11:08 -08:00
Jakob Andersen
a0c3aae16d Read package ID and activity name from .apk for Gradle-based builds. (#8393)
The gradle build scripts can be configured to output different
application IDs for different build types, so we need to examine the
built .apk to figure out the name of the package and activity.

Fixes #8327
2017-02-24 16:30:59 +01:00
Jakob Andersen
7f9a53b136 Relax Android Studio version check. (#8389)
It's not just $HOME/.AndroidStudio2.2, it might also be
.AndroidStudioPreview2.3, or .AndroidStudioFooBar1.7, or whatever.

Made the Version parser less throw-happy, and relaxed the directory name
checks to allow for the above.

Fixes #8353.
2017-02-24 11:59:59 +01:00
Adam Barth
6a9ea16e9f jumpTo during a user drag shouldn't assert (#8384)
Fixes #8380
2017-02-23 19:08:27 -08:00
Michael Goderbauer
718859ad8d Partially revert #8332 (#8386)
The JDK doesn't put `javac` in the PATH on Windows :(
2017-02-23 17:35:20 -08:00
Phil Quitslund
a002e72022 Bump to test 0.12.20. (#8349)
* Bump to test `0.12.20`.

Some test `0.12.20` highlights:
  * introduces `expectLater()`  that returns a `Future` that completes when the matcher has finished running
  * deprecates the `verbose` parameter to `expect()` and the `formatFailure()` (to be removed in `0.13.0`)

Otherwise:
  * to keep up w/ the deprecation of `verbose`, removes `widget_tester` API to pass `verbose` flag (alternatively we could suppress the warning for now)

* Update stack manipulation.

* Fix framecount.
2017-02-23 15:08:25 -08:00
Alexandre Ardhuin
8c043d06de fix lints for directives_ordering rule (#8382) 2017-02-23 13:37:26 -08:00
xster
2b61e21b29 Change doc references from .xcodeproj to xcworkspace (#8379) 2017-02-23 12:40:23 -08:00
Michael Goderbauer
b65ed45222 Improvments to bat file (#8377)
Mainly: Don't call out to PoerShell (expansive!) if Dart SDK is upto date.
2017-02-23 12:09:52 -08:00
Chris Bracken
064a63e932 Add haptic feedback tests for DatePicker (#8376) 2017-02-23 10:53:40 -08:00
Chris Bracken
ebaffbdd07 Correct spelling of 'Interval' in var name (#8375) 2017-02-23 10:53:29 -08:00
Todd Volkert
a68c979b73 Add ability to record & replay VMService connection (#8355) 2017-02-23 10:05:00 -08:00
Jakob Andersen
2a05cfdf07 Remove superfluous (and wrong) target file check (#8367) 2017-02-23 16:27:30 +01:00
Jakob Andersen
6d66be17b9 Add support for target file in Gradle builds. (#8364)
If a target file is specified on the flutter tools command line, pass it
through to Gradle.

It is still possible to statically specify a target file in the flutter
section of build.gradle, but it is now possible to specify it on the
command line as well. The command line option takes precedence.

Fixes #8175.
2017-02-23 15:09:05 +01:00
Jakob Andersen
13d7770cf9 Fix local engine support for Gradle builds. (#8362)
Fixes #6761.
2017-02-23 14:56:19 +01:00
Devon Carew
fa04321604 filter an ios simulator assert (#8357) 2017-02-22 20:55:08 -08:00
Chris Bracken
093afe0255 Haptic feedback on time changes in TimePicker (#8348)
Trigger a vibration on hour/minute changes, with an upper bound on
number of feedback events per second.

Note: state changes are expected to trigger haptic feedback on Android,
but not on iOS time pickers.
2017-02-22 19:11:44 -08:00
Hans Muller
3a0b83b1b6 Added support for a pinned floating SliverAppBar (#8345) 2017-02-22 16:19:36 -08:00
Chris Bracken
9ada90a160 Suppress TimePicker haptic feedback on iOS (#8347)
State changes are expected to trigger haptic feedback on Android, but
not on iOS time pickers.
2017-02-22 16:16:52 -08:00
Adam Barth
5e93756f19 Clean up flipping of ScrollDirection (#8343)
Makes RenderViewport.layoutOneSide more readable.
2017-02-22 15:57:32 -08:00
xster
34a6e48ac8 16 dp title margin when there’s no leading button (#8344) 2017-02-22 14:53:53 -08:00
Michael Goderbauer
7201c8c994 add AppVeyor build status badge (#8341) 2017-02-22 14:01:50 -08:00
Michael Goderbauer
28a2b99989 only request sky_snapshot if it is actually needed (#8340) 2017-02-22 13:55:58 -08:00
Adam Barth
fc9a00fd6c Improve the error message for unbounded viewports (#8321)
Rather than generating a cryptic assert, we now generate a more useful error
message.

Fixes #8296
2017-02-22 13:29:13 -08:00
Michael Goderbauer
99ae5a897e Add line about Java version back to flutter doctor (#8332)
Line was accidentally removed by #8320

Also, change the version check from `java` to `javac` since we need the JDK and not just the JRE.
2017-02-22 13:01:53 -08:00
Chris Bracken
6d135e4520 Eliminate extraneous bool in DatePicker haptic feedback (#8337) 2017-02-22 12:51:06 -08:00
Chris Bracken
c8f8d0014a Disable DatePicker vibrate on date change on iOS (#8335)
In the Android native material DatePicker, haptic feedback is expected
on date change. This is not expected behaviour for iOS date/time
pickers.
2017-02-22 12:03:57 -08:00
xster
72fa281f12 Conform appbar buttons to Material (#8263)
Extend app bar left to edge, right to 4dp
Make leading button square and 56dp
Keep title at 72dp on Android according to Material
Renamed IconButton.size to .iconSize
IconButton minimum size expands to 48dp (#8264)
IconButton default constraints to 48. Can still stretch to infinity but can't be smaller than 48.
Ink splash for IconButton 40% bigger than the touch target to match Material
Tests
2017-02-22 11:32:22 -08:00
Hans Muller
52c7a123fc Fixed "AppBar actions are vertically centered" test (#8333) 2017-02-22 11:06:31 -08:00
Michael Goderbauer
7a7f9b68ec add appveyor config (#8323)
appveyor.com runs our tests on Windows for each PR.
2017-02-22 10:34:31 -08:00
Jakob Andersen
a745fd58be Don't reinstall the app if the latest build is already installed. (#8328)
Only implemented for Android devices for now. Compare the installed SHA1
to the latest build. If they match, there's no reason to reinstall the
build.

Fixes #8295
2017-02-22 14:35:49 +01:00
Jakob Andersen
3676ffe477 Fix bug parsing Gradle version. (#8326)
* Fix bug parsing Gradle version.

Version from pub_semver requires versions of the format X.Y.Z. Gradle
doesn't follow semantic versioning, though, so version parsing would
fail on versions like '3.2'. Fixed by writing a custom Version class.

Also removed a check for apksigner when building Gradle-based projects.

Fixes #8298
2017-02-22 11:53:32 +01:00
Michael Goderbauer
e552832635 fix tests on Windows for flutter tools (#8322) 2017-02-21 16:56:37 -08:00
Adam Barth
0e8b6aab46 ListView shouldn't be scrollable when there isn't any scroll extent (#8318)
Previously, a ListView would always accept user input, even if it wasn't
actually scrollable. Now, by default, we don't accept user input if there's no
scroll range. You can override this behavior using the ScrollPhysics.

Fixes #8276
Fixes #8278
Fixes #8271
2017-02-21 16:54:23 -08:00
Michael Goderbauer
7db8241a6d Revert "Revert "Replace jarsigner with apksigner" (#8164)" (#8320)
This reverts commit 70d7fe3a0dede9f3556fda8fe018dc4ed4a08490.

The Java version missmatch on the bots has been resolved.
2017-02-21 16:26:30 -08:00
Adam Barth
b6e282779a Disable menu button when bottom sheet open (#8319)
Otherwise tapping the menu button causes the bottom sheet to disappear and
reappear.

Fixes #8275
2017-02-21 16:25:28 -08:00
Todd Volkert
0d2c9670fd Resolve TODOs to migrate from OperatingSystemUtils to Platform (#8314) 2017-02-21 15:11:49 -08:00
Michael Goderbauer
ac7954c11a Migrate from touch cmd to dart's built-in API (#8313)
This enables us to run more tests on Windows.
2017-02-21 15:11:37 -08:00
Alexandre Ardhuin
e9a775bf38 prefer const constructors (#8316) 2017-02-21 14:54:29 -08:00
Adam Barth
663862557b Factor WillPopScope out of Form (#8311)
This functionality is independently useful.

Fixes #8293
2017-02-21 14:40:13 -08:00
Adam Barth
434d6c3ff8 Improve Stack docs (#8312)
Discuss how to change paint order.
2017-02-21 14:14:25 -08:00
Adam Barth
addcb1f7af Move RenderViewport to its own file (#8310)
It doesn't need to be in the same file as RenderSliver.
2017-02-21 13:13:02 -08:00
Chris Bracken
58898636cc Only attempt to deploy to USB-connected iOS devices (#8309)
Do not attempt to deploy/debug wifi connected iOS devices. ios-deploy is
able to install over wifi, but we've had several bugs reporting failure
to run/debug once installation has completed when the device is also
connected via USB. Note that we don't currently support deploy/debug
over wifi since libimobiledevice (which is also required) requires a USB
connection.
2017-02-21 13:02:50 -08:00