firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,438 Commits 1 Branch 0 Tags
Commit Graph

38438 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
5052b556a4 Roll Skia from 6a3f77189dde to ded8ab47ee69 (1 revision) (flutter/engine#56774) 
https://skia.googlesource.com/skia.git/+log/6a3f77189dde..ded8ab47ee69

2024-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9071e1ad430c to 73e40f43c062 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-23 17:23:39 +00:00
skia-flutter-autoroll
57af1fa4fc Roll Dart SDK from 202083b79ac5 to df716eaa6ed2 (1 revision) (flutter/engine#56773) 
https://dart.googlesource.com/sdk.git/+log/202083b79ac5..df716eaa6ed2

2024-11-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-183.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-23 08:08:37 +00:00
skia-flutter-autoroll
95bfdadec6 Roll Dart SDK from eb01a0430f72 to 202083b79ac5 (1 revision) (flutter/engine#56772) 
https://dart.googlesource.com/sdk.git/+log/eb01a0430f72..202083b79ac5

2024-11-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-182.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-23 03:58:30 +00:00
skia-flutter-autoroll
f687621cb8 Roll Skia from c3d9596a93f8 to 6a3f77189dde (1 revision) (flutter/engine#56771) 
https://skia.googlesource.com/skia.git/+log/c3d9596a93f8..6a3f77189dde

2024-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6c717e914923 to 9071e1ad430c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-23 03:36:23 +00:00
Chris Bracken
2c1d5bbc8a iOS: Fix typo in fluttterViewController (flutter/engine#56770) 
Ran into this typo during a separate refactoring. Breaking it out to avoid an already large patch getting any bigger.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-23 01:46:21 +00:00
skia-flutter-autoroll
f764f183dc Roll Skia from e7caf38140ce to c3d9596a93f8 (2 revisions) (flutter/engine#56765) 
https://skia.googlesource.com/skia.git/+log/e7caf38140ce..c3d9596a93f8

2024-11-22 nscobie@google.com [graphite] Allow clients to configure active logging level
2024-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from a049ff55ff14 to c0ad379b6c58

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-22 23:57:27 +00:00
auto-submit[bot]
2805143dd5 Reverts "[engine] more consistently flush dart event loop, run vsync callback immediately (#56738)" (flutter/engine#56767) 
Reverts: flutter/engine#56738
Initiated by: jonahwilliams
Reason for reverting: speculative revert for framework failures.
Original PR Author: jonahwilliams

Reviewed By: {jason-simmons}

This change reverts the following previous change:
Changes the following shell callbacks to flush the dart event loop:

* OnPlatformViewSetViewportMetrics
* OnPlatformViewDispatchPointerDataPacket
* OnPlatformViewDispatchPlatformMessage
* OnPlatformViewSetSemanticsEnabled
* OnPlatformViewSetAccessibilityFeatures

Using a new TaskRunner API RunNowAndFlushMessages. If the task runner can run tasks on the current thread, this will immediately invoke a callback and then post an empty task to the event loop to ensure dart listeners fire.

This also updates the vsync waiter to use RunNowOrPostTask, so that we start vsync events as early as possible.
 2024-11-22 23:51:26 +00:00
skia-flutter-autoroll
3fca18a7a5 Roll Dart SDK from 8b65a7a628e2 to eb01a0430f72 (2 revisions) (flutter/engine#56764) 
https://dart.googlesource.com/sdk.git/+log/8b65a7a628e2..eb01a0430f72

2024-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-181.0.dev
2024-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-180.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-22 23:35:15 +00:00
Jonah Williams
8aabbdf368 [Impeller] delete Impeller sim opt out. (flutter/engine#56706) 
Impeller only on simulators.
 2024-11-22 21:10:00 +00:00
Jason Simmons
d6095e5be3 [Impeller] Ensure that SnapshotControllerImpeller has a rendering context before creating the snapshot (flutter/engine#56743) 
The Skia snapshot controller will activate the delegate's surface render context on the current thread.  If the delegate has no surface, then it will use the snapshot surface producer to create a temporary surface.

The Impeller snapshot controller needs to do the same in order to support OpenGL/GLES scenarios where the thread does not currently have an EGL context.
 2024-11-22 20:46:39 +00:00
Jim Graham
dee413e427 [DisplayList] migrate DlColorSource objects to Impeller geometry (flutter/engine#56735) 
The DlColorSource code uses Skia geometry classes for its internal computations. This PR switches those implementations to use the Impeller geometry classes for consistency and 3rd party header file independence.
 2024-11-22 20:30:21 +00:00
Chinmay Garde
219060790d [Impeller] libImpeller: Tinker on the README. (flutter/engine#56761) 
Also adds references to the C++ wrapper and examples.
 2024-11-22 20:26:14 +00:00
Jonah Williams
4a17eac8a1 [Impeller] dont create temp vec for discard. (flutter/engine#56759) 
This can have at most 3 entries so just use an array to avoid heap allocation.
 2024-11-22 20:26:11 +00:00
skia-flutter-autoroll
a8b975b315 Roll Fuchsia Linux SDK from zhFzwYCH-N_wasTnM... to D5CBHuB2c-v3Zai-c... (flutter/engine#56757) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-22 18:47:02 +00:00
skia-flutter-autoroll
cdaba7b7bc Roll Dart SDK from 141291fd570d to 8b65a7a628e2 (1 revision) (flutter/engine#56755) 
https://dart.googlesource.com/sdk.git/+log/141291fd570d..8b65a7a628e2

2024-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-179.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-22 18:45:05 +00:00
Jonah Williams
7e786d8dc8 [Impeller] cache and reuse openGL framebuffer attachments. (flutter/engine#56746) 
Creating and attaching textures/render buffers to a FBO is an expensive operation. Similar to how we cache vulkan framebuffers/render passes, we can cache the FBO object on the color0 texture to avoid extra state invalidation.

Part of https://github.com/flutter/flutter/issues/159177
 2024-11-22 17:43:43 +00:00
skia-flutter-autoroll
d3a6012bfa Roll Skia from 700e685861c8 to e7caf38140ce (25 revisions) (flutter/engine#56756) 
https://skia.googlesource.com/skia.git/+log/700e685861c8..e7caf38140ce

2024-11-22 jlavrova@google.com Reland "Making fontStyle and fixedPitch fields "virtual""
2024-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1f0ac74a7a93 to 10c2dc7a1b4b (14 revisions)
2024-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fc122129fa28 to 6c717e914923 (5 revisions)
2024-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2b2d3ae5900c to 808d8a5c3b87 (6 revisions)
2024-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d2ad5a36f4e6 to eef82f6f51a2 (16 revisions)
2024-11-21 jlavrova@google.com Revert "Making fontStyle and fixedPitch fields "virtual""
2024-11-21 jlavrova@google.com Making fontStyle and fixedPitch fields "virtual"
2024-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 94069332c202 to fc122129fa28 (8 revisions)
2024-11-21 lukasza@chromium.org [rust png] Integrate `cICP` support into `SkPngRustCodec`.
2024-11-21 robertphillips@google.com [graphite] Remove deprecated Precompile API call
2024-11-21 robertphillips@google.com [graphite] Add more Test job suppressions for Dawn thread race
2024-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 74f74b63df26 to 1f0ac74a7a93 (13 revisions)
2024-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7fb17334e756 to 2b2d3ae5900c (7 revisions)
2024-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 839eadc23139 to d2ad5a36f4e6 (15 revisions)
2024-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3c7156644de7 to 94069332c202 (11 revisions)
2024-11-20 vigneshv@google.com Reland "SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec"
2024-11-20 kjlubick@google.com Fix Vello build rules
2024-11-20 robertphillips@google.com [graphite] Add a more robust threaded Compile/Precompile test
2024-11-20 jvanverth@google.com Fix verylarge_picture on Adreno Vulkan.
2024-11-20 kjlubick@google.com Reland "add triangulated gradient effect"
2024-11-20 lokokung@google.com Uses newer APIs for device.PopErrorScope in DawnErrorChecker.
2024-11-20 danieldilan@google.com Clamp alpha in SkScan_AAAPath to int32_max to avoid integer overflow.
2024-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 987cc0de1d4c to 74f74b63df26 (11 revisions)
2024-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 867065ecbb6a to 3c7156644de7 (4 revisions)
2024-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b51256461a37 to 7fb17334e756 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-22 17:42:02 +00:00
skia-flutter-autoroll
4e88679b4f Roll Dart SDK from c1106f7e4cde to 141291fd570d (1 revision) (flutter/engine#56748) 
https://dart.googlesource.com/sdk.git/+log/c1106f7e4cde..141291fd570d

2024-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-178.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-22 07:59:26 +00:00
Jonah Williams
602ab9846d [engine] more consistently flush dart event loop, run vsync callback immediately (flutter/engine#56738) 
Changes the following shell callbacks to flush the dart event loop:

* OnPlatformViewSetViewportMetrics
* OnPlatformViewDispatchPointerDataPacket
* OnPlatformViewDispatchPlatformMessage
* OnPlatformViewSetSemanticsEnabled
* OnPlatformViewSetAccessibilityFeatures

Using a new TaskRunner API RunNowAndFlushMessages. If the task runner can run tasks on the current thread, this will immediately invoke a callback and then post an empty task to the event loop to ensure dart listeners fire.

This also updates the vsync waiter to use RunNowOrPostTask, so that we start vsync events as early as possible.
 2024-11-22 07:47:17 +00:00
Chris Bracken
39db174656 Extract backend-specific code in ShellTestPlatformView (flutter/engine#56722) 
Moves code specific to each graphics backend into the (existing) translation unit associated with that backend.

Previously, we could not include any Objective-C types in `shell_test_platform_view_metal.h`, since that file was included into `shell_test_platform_view.cc`, which is pure C++. To work around this, we had encapsulated Objective-C Metal types in a `DarwinContextMetal` struct hidden in the implementation file with a pointer to it forward-declared in the header.

We now use Metal types directly in the header, without the workarounds.

Issue: https://github.com/flutter/flutter/issues/158998
Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-22 07:40:29 +00:00
Chris Bracken
5883c1a69b Eliminate ShellTestPlatformView::BackendType::kDefaultBackendType (flutter/engine#56744) 
`kDefaultBackendType` is intended to make life easier for authors of tests, but in any switch statement where it's used (currently just a single location), we rely on ordering it first and `#ifdef`ing out all backends that aren't available.

Instead, we define a static function that returns the default that callers can invoke instead. This avoids relinace on case ordering and fallthrough.

In https://github.com/flutter/engine/pull/56722 we split backends out into separate translation units, and ideally should remove the `#ifdef`s, which means we can't rely on this trick anymore.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-22 05:47:20 +00:00
skia-flutter-autoroll
932d854edc Roll Skia from 2614590b4f32 to 700e685861c8 (1 revision) (flutter/engine#56725) 
https://skia.googlesource.com/skia.git/+log/2614590b4f32..700e685861c8

2024-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6898ea1d553e to 839eadc23139 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-22 03:54:23 +00:00
skia-flutter-autoroll
de48b04e35 Roll Dart SDK from b36e4d731d67 to c1106f7e4cde (12 revisions) (flutter/engine#56742) 
https://dart.googlesource.com/sdk.git/+log/b36e4d731d67..c1106f7e4cde

2024-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-177.0.dev
2024-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-176.0.dev
2024-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-175.0.dev
2024-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-174.0.dev
2024-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-173.0.dev
2024-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-172.0.dev
2024-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-171.0.dev
2024-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-170.0.dev
2024-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-169.0.dev
2024-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-168.0.dev
2024-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-167.0.dev
2024-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-166.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-22 02:52:08 +00:00
Chinmay Garde
13e15ab91b [Impeller] libImpeller: A C++ wrapper to the Impeller API. (flutter/engine#56682) 
_`impeller.hpp` is to `impeller.h` what `vulkan.hpp` is to `vulkan.h`_

* A single header C++ 17 library that only depends on impeller.h and standard libc++ utilities.
* The C++ library proc. table is setup at runtime (via dlsym and related methods). Impeller users don't need to link against libimpeller.so as long as they can discover it at runtime.
* RAII wrappers for all opaque objects.
* Namespaces are configurable depending on target.
* Included in the distributed SDK next to impeller.h.
 2024-11-22 00:56:32 +00:00
Chinmay Garde
daa09b9a64 [Impeller] Run simulator tests with Impeller enabled. (flutter/engine#56740) 
The Info.plist override was missed earlier.

The main changes to the tests are due to the UI thread merge with the platform thread. The amendment to the "spawn" API are due to the fact that the assertions checked for the presence of GrDirectContext which will never exist with Impeller.

Unblocks https://github.com/flutter/engine/pull/56706
 2024-11-21 23:48:59 +00:00
auto-submit[bot]
8958ff46da Reverts "[Impeller] support GLES 3.0 MSAA without extension. (#56705)" (flutter/engine#56741) 
Reverts: flutter/engine#56705
Initiated by: jonahwilliams
Reason for reverting: goldens occassionally fail to render anything.
Original PR Author: jonahwilliams

Reviewed By: {gaaclarke}

This change reverts the following previous change:
Adds multisampling support for GLES devices without GL_EXT_multisampled_render_to_texture provided they are at least GLES 3.0 to support mutlisampled render buffers.

Fixes https://github.com/flutter/flutter/issues/158360
Fixes https://github.com/flutter/flutter/issues/157951

TBD: should we prefer renderbuffer 3.0 approach over multisample_render_to_texture?
 2024-11-21 23:18:48 +00:00
skia-flutter-autoroll
0e426efd96 Roll Dart SDK from dde57dc75c15 to b36e4d731d67 (1 revision) (flutter/engine#56723) 
https://dart.googlesource.com/sdk.git/+log/dde57dc75c15..b36e4d731d67

2024-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-165.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-21 22:30:33 +00:00
Daco Harkes
09e3b52bdf [native assets] Consume NativeAssetsManifest.json (flutter/engine#56727) 
This PR introduces a `NativeAssetsManifest.json` next to the `AssetManifest.json` and `FontManifest.json`. This removes the need for embedding the native assets mapping inside the kernel file and will enable decoupling native assets building and bundling from the kernel compilation in flutter tools. This will then allow us to remove dry-run from the build hook protocol.

(It also means all isolate groups will have the same native assets. However, since Flutter does not support `Isolate.spawnUri` from kernel files anyways, this is not a regression.)

This manifest is parsed eagerly on startup by the engine in a manner similar to how the font manifest is parsed. The manifest contents need to be available in the callback for resolving assets, which does not have access to the engine. Therefore the parsed manifest is `NativeAssetsManager` stored in the `IsolateGroupData`. The engine passes it in on isolate group creation, and the FFI callbacks access it from the isolate group data.

Issue:

* https://github.com/flutter/flutter/issues/154425

Related PRs:

* https://dart-review.googlesource.com/c/sdk/+/388161

Follow up work:

* This PR does not yet remove the engine callbacks registered via the dart_api that rely on kernel embedding. If we were to do that in this PR, it would require a manual roll of the engine into flutter/flutter with the PR that switches flutter_tools to emit the native assets manifest instead of embedding in kernel, and a manual roll into g3 to switch emitting a manifest instead of embedding in kernel. A TODO is left in the code for those callbacks to be removed.

## Testing

Most of this PR cannot be tested in isolation. The code in this PR is heavily exercised in the follow up flutter_tools PR which creates the `NativeAssetsManifest.json` and removes the embedding of native assets in kernel files.

* This PR adds a unit test for parsing the JSON manifest.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-21 18:01:46 +00:00
Jonah Williams
47ba585ccf [Impeller] support GLES 3.0 MSAA without extension. (flutter/engine#56705) 
Adds multisampling support for GLES devices without GL_EXT_multisampled_render_to_texture provided they are at least GLES 3.0 to support mutlisampled render buffers.

Fixes https://github.com/flutter/flutter/issues/158360
Fixes https://github.com/flutter/flutter/issues/157951

TBD: should we prefer renderbuffer 3.0 approach over multisample_render_to_texture?
 2024-11-21 18:01:44 +00:00
gaaclarke
60378be0f6 Updated some impeller benchmark urls (flutter/engine#56721) 
The urls that use keys seem to atrophy quickly

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-11-21 09:39:58 -08:00
skia-flutter-autoroll
eea27fa310 Roll Fuchsia Linux SDK from oq6Ztlu1b1mgdDSPH... to zhFzwYCH-N_wasTnM... (flutter/engine#56736) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-21 15:42:09 +00:00
Mouad Debbar
b56fac41f9 [web] Make sure to include all split fonts (flutter/engine#56733) 
The `csslib` parser was not reliably parsing all URLs in the CSS response. I'm switching to using a RegExp to extract all URLs reliably.

Fixes https://github.com/flutter/flutter/issues/159215
 2024-11-21 14:35:18 +00:00
Mouad Debbar
3e281cda44 [web] Work around wrong pointerId in coalesced events in iOS Safari 18.2 (flutter/engine#56719) 
In iOS 18.2, Safari [added support](https://developer.apple.com/documentation/safari-release-notes/safari-18_2-release-notes#Web-API) for the [`getCoalescedEvents`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/getCoalescedEvents) API.

That being said, the API seems to be incomplete (or at least doesn't match other browsers' behavior). The coalesced events lack a [`pointerId`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/pointerId) and [`target`](https://developer.mozilla.org/en-US/docs/Web/API/Event/target) properties.

I'm not sure if this issue will be fixed in the stable release of iOS 18.2, so in the meantime, this PR implements a workaround to avoid this issue.

Fixes https://github.com/flutter/flutter/issues/158299
Fixes https://github.com/flutter/flutter/issues/155987
 2024-11-21 14:33:28 +00:00
AthulJoseph
4705535548 [Flutter GPU] Added support to set Scissor. (flutter/engine#56302) 
Added support to set scissors. This resolves issue #157199
 2024-11-21 05:52:54 +00:00
Juanjo Tugores
69da421d98 Enable view focus (flutter/engine#54966) 
Enable view focus

https://github.com/flutter/flutter/issues/153022

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-21 05:49:05 +00:00
Robert Ancell
504bff9b26 Allow GTK style enum naming (flutter/engine#56731) 
Remove the linting overrides for enum names and set this in the
clang-format file.
 2024-11-21 15:16:43 +13:00
Tong Mu
de98354d8e Fix: Impeller playground's shapes should react to controllers (flutter/engine#56734) 
Fixes https://github.com/flutter/flutter/issues/159213

I've went through all `static` in the file and removed the ones that I think are incorrect.

<img width="1136" alt="image" src="https://github.com/user-attachments/assets/29fe63ed-d077-4384-88ec-2f80dcc8c719">

I've experimented with all entity playgrounds to make sure their controllers work, except for `BlendingModeOptions`, which doesn't change whatsoever and I can't figure out.

This PR should not need tests, as it fixes the tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-20 21:58:22 +00:00
Jim Graham
e3d616ca84 [DisplayList] migrate DlImageFilter code to Impeller geometry classes (flutter/engine#56720) 
The DlImageFilter code uses Skia geometry classes for its internal computations. This PR switches those implementations to use the Impeller geometry classes for consistency and 3rd party header file independence.
 2024-11-20 20:47:37 +00:00
Robert Ancell
56686525b2 Split channel messaging out of handlers (flutter/engine#56667) 
Split the channel messaging out of the system channels to make them
simpler to understand and refactor.

The new channel classes could be automatically generated in a second
phase, e.g. using Pigeon to reduce code usage.

The new classes don't have tests as they will already be covered by the
existing code.
 2024-11-21 09:32:20 +13:00
Jason Simmons
b8e58bbb0b Revert "Added assert for opengles thread safety (#56585)" (flutter/engine#56730) 
This reverts commit 11123f1bbf8833d029f0800ca5830085347bcf95.

The implementation of the assert assumes that there is a single raster thread ID that will remain constant throughout the lifetime of the process.  That is not true for scenarios like recreating the engine after suspending and resuming an Android app, or instantiating multiple engines within one process.
 2024-11-20 20:26:04 +00:00
Daco Harkes
a599b5e31f [et] Add Android x64 configurations (flutter/engine#56703) 
Closes: https://github.com/flutter/flutter/issues/156598
 2024-11-20 19:03:25 +00:00
Jonah Williams
c9bb068cfa [Impeller] flush all GLES cmd buffers together. (flutter/engine#56724) 
Locally this gives much better performance, about doubling frame time on the Pixel 4. This avoids multiple glbuffersubdata calls that seems to perform particularly bad on mobile devices.

Thinking about it more, I'm not sure that having a separate EncodeCommands API is useful for RenderPass/BlitPass. instead they should probably just use submit. but that is a refactor for another day.

https://github.com/flutter/flutter/issues/159177
 2024-11-20 17:41:14 +00:00
skia-flutter-autoroll
957a442547 Roll Fuchsia Linux SDK from dJ0gh-z1KVnSzvfjW... to oq6Ztlu1b1mgdDSPH... (flutter/engine#56728) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 14:13:37 +00:00
skia-flutter-autoroll
b605c31267 Roll Skia from d776efdac21b to 2614590b4f32 (1 revision) (flutter/engine#56718) 
https://skia.googlesource.com/skia.git/+log/d776efdac21b..2614590b4f32

2024-11-19 briansalomon@gmail.com Show timer queries for Ganesh/GL in Viewer stats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 22:54:18 +00:00
Chris Bracken
1a60defc96 TestMetalContext: Use ARC-managed Metal types (flutter/engine#56717) 
Previously, we could not include any Objective-C types in test_metal_context.h, since that file was transitively included in pure C++ translation units. All users have been refactored into backend-specific files, and all Metal-related files are Objective-C++ files.

We now use Metal types directly in the header, without the workarounds.

Issue: https://github.com/flutter/flutter/issues/158998
Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-19 22:50:10 +00:00
skia-flutter-autoroll
ccef3ff9c3 Roll Skia from a694b9e85a49 to d776efdac21b (3 revisions) (flutter/engine#56716) 
https://skia.googlesource.com/skia.git/+log/a694b9e85a49..d776efdac21b

2024-11-19 kjlubick@google.com Fix invalid cross-device link error in deps_parser
2024-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 824ef0f736ed to 867065ecbb6a (2 revisions)
2024-11-19 kjlubick@google.com Reland "Remove TODOs in GNI exporter tool"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 21:32:58 +00:00
skia-flutter-autoroll
e41ee7a54a Roll Dart SDK from b01654fa26c7 to dde57dc75c15 (3 revisions) (flutter/engine#56714) 
https://dart.googlesource.com/sdk.git/+log/b01654fa26c7..dde57dc75c15

2024-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-164.0.dev
2024-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-163.0.dev
2024-11-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-162.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 21:17:01 +00:00
Chris Bracken
ddb5df9483 EmbedderTest: templatise GetEmbedderContext (flutter/engine#56709) 
In many embedder tests, we want to get at the appropriate backend-specific `EmbedderTestContext` subclass (`EmbedderTestContextGL`, etc.) in order to make backend-specific setup calls such as `SetGLFBOCallback()` or others. Formerly, this required casting the returned `EmbedderTestContext&` to the appropriate subclass in each test.

This templatises the `GetEmbedderContext()` method to return the appropriate backend-specific subclass directly.

Issue: https://github.com/flutter/flutter/issues/158998

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-19 20:20:08 +00:00
Chris Bracken
055f3d8edd display_list: Extract backend-specific surface providers (flutter/engine#56711) 
Extracts backend-specific code in DlSurfaceProvider to separate translation units. In particular, this allows for less conditional header includes, and more specifically, allows code relating to the Metal backend to include headers that include ARC-managed Objective-C types. Today we cast these all to void* (and manage refcounting manually) since these headers are included in dl_surface_provider.cc, which is a pure C++ translation unit.

No test changes since this patch includes no semantic changes.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-19 20:20:05 +00:00
skia-flutter-autoroll
d3434485d9 Roll Skia from 78ef6b7a574f to a694b9e85a49 (5 revisions) (flutter/engine#56713) 
https://skia.googlesource.com/skia.git/+log/78ef6b7a574f..a694b9e85a49

2024-11-19 robertphillips@google.com [graphite] Fix up Context's recorder tracking thread safety
2024-11-19 vigneshv@google.com SkCrabbyAvifCodec: Set mediacodec color format
2024-11-19 vigneshv@google.com SkCrabbyAvifCodec: Make a copy of the image before scaling
2024-11-19 jlavrova@google.com Refactoring proxy for FontConfig out of FontMgr
2024-11-19 jvanverth@google.com [ganesh] Fix artifacts from looping colorizer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 20:06:40 +00:00