8841 Commits

Author SHA1 Message Date
Ian Hickson
35496d00a9 Re-enable coverage checking. (#11537)
I forgot to do this when I updated our test package.
2017-08-07 16:55:29 -07:00
Jaime Wren
dbd3bf28e6 Replace FLUTTER_MODULE_TYPE with WEB_MODULE in dev/manual_tests/* and examples/* iml files (#11234) 2017-08-07 15:53:56 -07:00
Chris Bracken
cb14eb989d Update IntelliJ project files for latest plugin (#11536)
The most recent Flutter IntelliJ plugin replaces FLUTTER_MODULE with
WEB_MODULE and eliminates the exclusion of packages/ directories.
Use of the packages/ directory was turned off by default months ago, and
is replaced by the .packages file.
2017-08-07 12:19:25 -07:00
Yegor
bbc15724bd roll engine ff50334587 to get async stacks (#11519) 2017-08-07 10:03:09 -07:00
paolosoares
4da5e9b249 Adds more customization options to the Chip widget (#11498)
* Adds more customization options to the Chip widget

Includes:
- Custom Tooltip message for the delete button;
- Custom background color for the chip
- Custom delete icon color
- Custom label text style

* Adds missing type annotations to tests and improves documentation.

* Tweaks labelStyle field documentation
2017-08-04 17:44:20 -07:00
Ian Hickson
db88414131 Upgrade to the most recent test package. (#11526)
Also, add tests to verify that our coverage is actually being tested!
2017-08-04 16:33:38 -07:00
Michael Goderbauer
1e53d3206b Adding tests for animationStatus (#11520)
* Adding tests for animationStatus

* remove comments

* animateTo is allways forward

* clearify docs

* review comments
2017-08-04 16:14:05 -07:00
Jason Simmons
a5c4680e72 Reset the terminal if an exception occurs while handling terminal input in the app runner (#11516) 2017-08-04 14:27:36 -07:00
Michael Goderbauer
ec9df2f269 Allow Duration.Zero for animateTo (#11515) 2017-08-04 13:04:51 -07:00
Carlo Bernaschina
802d5d2028 Roll engine to 73afec408194dd6e03c0d8483f0ea1332113b9a4 (#11518) 2017-08-04 12:54:11 -07:00
Ian Hickson
00e135d879 Prevent event dispatch from happening during reassemble. (#11459)
It was previously possible for event dispatch to occurr during the
brief window where the tree had been marked dirty but before it had
been relaid out by reassemble, which would cause assertions to fire if
someone did a hot reload while touching the device.
2017-08-04 12:01:35 -07:00
Michael Goderbauer
d17ae25034 Do not schedule animation if already at the target value (#11503)
* Do not schedule animation if already at the target value

* Partially fixes https://github.com/flutter/flutter/issues/11495.
* Also includes a fix for Cupertino button to always run the tap animation even if the finger is immediately lifted from the screen (uncovered by a test failure).

* refactorings

* more tests

* test clearifications

* remove Listener

* fix lints

* fix async issue
2017-08-04 10:42:08 -07:00
Mikkel Nygaard Ravn
75ef9d02e8 Avoid building x86 jar for profile and release modes (#11486) 2017-08-04 14:57:54 +02:00
Jason Simmons
7df854ad47 Disable the coverage shard in Travis (#11512)
In a Travis environment, the test package is exiting the process after
completing the tests.
See dart-lang/test@d1057c4

The flutter test command calls the test package's main() and then expects to
do other work afterward.  The exit prevents flutter test from writing the
new coverage results, causing the coveralls tool to run against an old
lcov.info file.
2017-08-03 18:05:49 -07:00
Jacob Richman
cf8d11ad1b Revert "Cache the hosted directory under .pub-cache instead of all of .pub-cache." (#11507)
This reverts commit 0cfd3dec239faf3c13ce759df15ddab226545e8c.
2017-08-03 15:30:28 -07:00
Jacob Richman
b64c0e117c Cache the hosted directory under .pub-cache instead of all of .pub-cache. (#11506) 2017-08-03 13:16:29 -07:00
Jason Simmons
ffe5851eb7 Do not throw if a hot reload is attempted when all Flutter instances on the device have been stopped (#11504)
This can happen if an Android host app has been paused but its process is still running
2017-08-03 13:09:10 -07:00
Devon Carew
8ee902c04b rev the min. recommended flutter plugin version (#11501) 2017-08-03 10:21:35 -07:00
Jacob Richman
93a98327a8 Add Diagnosticable base class and add documentation. (#11458)
Add Diagnosticable base class and documentation
2017-08-03 09:49:44 -07:00
Michael Goderbauer
58f47bd906 Roll engine to 1de56a33d256ce4002a28ffe281163622e0c4010 (#11494) 2017-08-02 17:34:23 -07:00
Yegor
89d06450e1 FadeInImage: shows a placeholder while loading then fades in (#11371)
* FadeInImage: shows a placeholder while loading then fades in

* fix dartdoc quotes

* license headers; imports

* use ImageProvider; docs; constructors

* _resolveImage when placeholder changes

* address comments

* docs re ImageProvider changes; unsubscribe from placeholder

* rebase

* address comments
2017-08-02 09:44:27 -07:00
Devon Carew
c72381aa2d refactor commands_test to choose a free port for the service protocol (#11446)
* refactor commands_test to choose a free port for the service protocol

* discover the service protocol port

* add a todo
2017-08-02 08:29:44 -07:00
Jason Simmons
c80d2482f9 An API that prefetches an image into the cache (#11471) 2017-08-01 17:36:38 -07:00
Ian Hickson
3d5afb5a81 Revert "Skip AOT snapshot build if inputs are unchanged" (#11463)
* Revert "Support space- and backslash-escaped dependencies (#11090)"

This reverts commit e6bafd0bdb70108b9f0604798386fd9e644e7c8d.

* Revert "Skip AOT snapshot build if inputs are unchanged (#11084)"

This reverts commit b5e522e2002f1b616e689b5012c9a42bbc9321f4.
2017-08-01 16:46:24 -07:00
Michael Goderbauer
d68caaafcd post-alpha-release work (#11472) 2017-08-01 16:45:29 -07:00
Devon Carew
a7c3bf4849 perform the initial poll for devices quicker (#11356)
* perform the initial poll for devices quicker

* add a Poller class

* test the new Poller class
2017-08-01 15:29:54 -07:00
Michael Goderbauer
bbcfb8d51a prepare alpha release (#11464) 2017-08-01 14:50:29 -07:00
Ian Hickson
ae5c3d5f89 Revert "Revert "Always evaluate the finder in driver.waitFor*()" (#11451)" (#11462)
This reverts commit 5d9db106db23d14e22a9c326d97d50fb1fcdc4d7.
2017-08-01 14:23:44 -07:00
perlatus
d1b222bef6 PopupMenuButton: create IconButton if child is Icon (#10230)
* PopupMenuButton: create IconButton if child is Icon

Otherwise the resulting button has an abnormally small and rectangular
area. With multiple PopupMenuButton(child: Icon) they get squished
together in the AppBar.

* Add separate icon argument to PopupMenuButton

* Fix style issues and tweak dartdocs

* Add tests for icon argument to PopupMenuButton

* Group icon tests and fix broken test, analyzer warnings

* Test that the correct custom icon is present

* Apply De Morgan's to work around dart analyzer bug

see: https://github.com/dart-lang/sdk/issues/30288
2017-08-01 12:32:49 -07:00
Alexey Shamrin
cfcf6d4428 brew update is not needed any more: Homebrew/brew#679 (#11406) 2017-08-01 12:21:56 -07:00
Ian Hickson
5d9db106db Revert "Always evaluate the finder in driver.waitFor*()" (#11451)
* Revert "Make plugins add their repos to projects in the consuming app (#11447)"

This reverts commit abe1e2520bb117c3de06cd3c44ad2a8250000de8.

* Revert "Support for custom build types on Android (#11354)"

This reverts commit 87eec719e20dd1423891a851d94b504b2453bf29.

* Revert "add a profile() method (#11443)"

This reverts commit 561d17a87606f8cf118b57bfacccb1acf6b9b594.

* Revert "Fix documentation based on dartdoc's warnings (#11428)"

This reverts commit 6655074b370d39150d2ed28f67851e3bce7013ab.

* Revert "Improve some docs around WillPopScope. (#11429)"

This reverts commit 58a28a296579b39360cbbb4a5f8b4b575eeb218b.

* Revert "temporarily disable broken driver test in integration_ui (#11440)"

This reverts commit 764515ec780421272de40b6b6c399497a1b38876.

* Revert "style fix"

This reverts commit 00bfc86630661edbd670b7c473fe07b11c6eee7a.

* Revert "tests for waitFor/waitForAbsent"

This reverts commit 31d2ee9c0cf259bc607bfbcaf112d4b8c2c360c1.

* Revert "Always evaluate the finder in `driver.waitFor()` and `driver.waitForAbsent()`"

This reverts commit 11d7c79b9902f960e9541f9f7da2f8857e4aaef4.
2017-08-01 10:39:08 -07:00
xster
ead51eae68 Roll engine (#11457)
* roll

* no-op commit

* revert no-op
2017-07-31 16:29:50 -07:00
Jason Simmons
b7bf2cd528 roll engine (#11456) 2017-07-31 14:02:37 -07:00
Ian Hickson
d4beaf54f0 Audit use of saveLayer (#11442)
It has recently come to light that we may have been ordering saveLayer
calls and clip calls incorrectly.
2017-07-31 12:21:42 -07:00
Mikkel Nygaard Ravn
abe1e2520b Make plugins add their repos to projects in the consuming app (#11447) 2017-07-31 14:51:09 +02:00
Mikkel Nygaard Ravn
87eec719e2 Support for custom build types on Android (#11354) 2017-07-31 13:57:24 +02:00
Devon Carew
561d17a876 add a profile() method (#11443)
* add a profile() method

* add todos
2017-07-30 16:29:28 -07:00
Ian Hickson
6655074b37 Fix documentation based on dartdoc's warnings (#11428) 2017-07-28 15:44:38 -07:00
Ian Hickson
58a28a2965 Improve some docs around WillPopScope. (#11429)
...and break the navigator<->routes circular dependency.

This is a step towards fixing https://github.com/flutter/flutter/issues/9577 but doesn't yet do so.
2017-07-28 15:10:11 -07:00
Yegor
764515ec78 temporarily disable broken driver test in integration_ui (#11440) 2017-07-28 14:30:10 -07:00
Yegor Jbanov
00bfc86630 style fix 2017-07-28 13:10:03 -07:00
Yegor Jbanov
31d2ee9c0c tests for waitFor/waitForAbsent 2017-07-28 13:10:03 -07:00
Todd Volkert
11d7c79b99 Always evaluate the finder in driver.waitFor() and driver.waitForAbsent()
Fixes #11327
2017-07-28 13:10:03 -07:00
Devon Carew
ba5bb57a52 Revert "fire service protocol extension events for frames (#10966)" (#11430)
This reverts commit 4b4cabb761ec1cb7fb5f2e8ec6e850de29a03056.
2017-07-27 16:14:30 -07:00
Devon Carew
4b4cabb761 fire service protocol extension events for frames (#10966)
* fire service protocol extension events for frames

* start time in micros

* introduce a profile() function; only send frame events when in profile (or debug) modes

* moved the profile() function to foundation/profile.dart

* refactor to make the change more testable; test the change

* fire service protocol events by listening to onFrameInfo

* remove the frame event stream; add a devicelab test

* remove a todo

* final
2017-07-27 15:34:53 -07:00
Jason Simmons
22ccb74ef5 Check all possible output directories to find a locally built gen_snapshot (#11417)
The output location of gen_snapshot differs based on the engine's target
platform, and we don't know the target platform when building a
platform-independent FLX in JIT mode.
2017-07-27 14:22:21 -07:00
Ian Hickson
87445e5913 Increase the touch slop. (#11419)
It was 8.0. It's now arbitrarily 18.0.

Changing this required adjusting some tests. Adjusting the tests
required debugging the tests. Debugging the tests required some tools
to help debugging gesture recognizers and gesture arenas, so I added
some. It also required updating some toString() methods which resulted
in some changes to the tree diagnostics logic.

Also I cleaned up some docs while I was at it.
2017-07-27 14:01:06 -07:00
Devon Carew
990dae85eb remove the flutter view cache; fix the ability to quit the app after a full restart (#11420)
* remove the flutter view cache; fix the ability to quit the app after a full restart

* improve test

* update test
2017-07-27 11:47:33 -07:00
Jason Simmons
2225e21fc0 roll engine (#11422) 2017-07-26 20:55:16 -07:00
Devon Carew
1d8705f3db re-flow comments in the create template (#11413) 2017-07-26 11:44:50 -07:00