33182 Commits

Author SHA1 Message Date
Callum Moffat
97d273ce1f
CupertinoThemeData equality (#119480) 2023-02-01 07:13:18 +00:00
engine-flutter-autoroll
e1f0b1d146
d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (#119686) 2023-02-01 06:47:13 +00:00
Callum Moffat
a752c2f154
Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (#119439) 2023-02-01 05:41:16 +00:00
engine-flutter-autoroll
3894d24816
1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (#119683) 2023-02-01 05:03:13 +00:00
Alex Li
8d0af36798
🥅 Produce warning instead of error for storage base url overrides (#119595)
* 🥅 Only log warning for storage base url

*  Add test

*  Add the link to the test

*  Remove the test

*  Remove the extra import
2023-02-01 03:49:31 +00:00
engine-flutter-autoroll
6f9a896d79
Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (#119675)
* 7d063fd28 Roll Dart SDK from 9bcc1773ebf0 to 8b57d23a7246 (1 revision) (flutter/engine#39303)

* 38913c548 Add SkSurface include to every file where it's used (flutter/engine#39304)
2023-02-01 02:38:18 +00:00
Michael Goderbauer
82df23539f
Undo making Flex,Row,Column const (#119669) 2023-01-31 18:03:09 -08:00
engine-flutter-autoroll
dc86565941
Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (#119670)
* 6678d9cc6 clipPath to use fillType param (flutter/engine#38956)

* 5c83e6eac Remove uses of `--full-dart-sdk` from the engine_v2 builders. (flutter/engine#39297)

* d13ad269f [Shell] Update stale comments after multi-view (flutter/engine#39298)

* 521b97544 Roll Fuchsia Mac SDK from IdMSzll1VeWJMV6v8... to Clk4li1185E2JoIkU... (flutter/engine#39300)
2023-02-01 01:53:26 +00:00
Hans Muller
198a51ace9
Migrate the Material Date pickers to M3 Reprise (#119033) 2023-01-31 15:31:06 -08:00
Tae Hyung Kim
3884381415
Make gen-l10n error handling independent of logger state (#119644)
* init

* lint

* lint again
2023-01-31 15:28:27 -08:00
engine-flutter-autoroll
8f90e2a7d5
Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (#119655)
* 32c157e34 [web] Remove unused test helper: expectPageHtml (flutter/engine#39287)

* bb7b7006f Unblock Skia roll by including SkSurface header (flutter/engine#39295)
2023-01-31 22:59:08 +00:00
Jason Simmons
fbe9ff33e6
Disable an inaccurate test assertion that will be fixed by an engine roll (#119653)
https://skia-review.googlesource.com/c/skia/+/619838 fixes a bug in
SkParagraph.  One of the selectable region tests relies on the old
behavior.

After that Skia change rolls into the framework, the update to the test
in https://github.com/flutter/flutter/pull/118902 should be landed.
2023-01-31 22:17:43 +00:00
engine-flutter-autoroll
60c1f293dc
2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (#119645) 2023-01-31 20:47:40 +00:00
Ian Hickson
ff22813b77
separatorBuilder can't return null (#119566)
...so remove the assert
2023-01-31 20:23:02 +00:00
Tanay Neotia
0e22aca785
Add support for image insertion on Android (#110052)
* Add support for image insertion on Android

* Fix checks

* Use proper Dart syntax on snippet

* Specify type annotation on list

* Fix nits, add some asserts, and improve example code

* Add missing import

* Fix nullsafety error

* Fix nullsafety error

* Remove reference to contentCommitMimeTypes in docs

* Fix nits

* Fix warnings and import

* Add test for content commit in editable_text_test.dart

* Check that URIs are equal in test

* Fix nits and rename functions / classes to be more self-explanatory

* Fix failing debugFillProperties tests

* Add empty implementation to `insertContent` in TextInputClient

* Tweak documentation slightly

* Improve docs for contentInsertionMimeTypes and fix assert

* Rework contentInsertionMimeType asserts

* Add test for onContentInserted example

* Switch implementation to a configuration class for more granularity in setting mime types

* Fix nits

* Improve docs and fix doc tests

* Fix more nits (LongCatIsLooong)

* Fix failing tests

* Make parameters (guaranteed by platform to be non-nullable) non-nullable

* Fix analysis issues
2023-01-31 19:46:18 +00:00
engine-flutter-autoroll
7bf95f41e4
1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (#119640) 2023-01-31 19:41:25 +00:00
Bruno Leroux
e2b3d89e7a
Fix CupertinoNavigationBar should create a backward compatible Annota… (#119515)
* Fix CupertinoNavigationBar should create a backward compatible AnnotatedRegion

* Remove extra space
2023-01-31 19:36:38 +00:00
Michael Goderbauer
6a5405925d
Make MultiChildRenderObjectWidget const (#119195) 2023-01-31 11:13:59 -08:00
engine-flutter-autoroll
9b3b9cf089
Roll Flutter Engine from aa00da3c1612 to cd2e8885e491 (6 revisions) (#119639)
* 707458b92 Roll Dart SDK from 52dc94238144 to c64a3f0c9fea (5 revisions) (flutter/engine#39281)

* 0aec06abd Roll Dart SDK from c64a3f0c9fea to 4fdbc7c28141 (1 revision) (flutter/engine#39282)

* 95a65fcbb Roll Fuchsia Mac SDK from CNkyuFjzxZhOxLNRS... to IdMSzll1VeWJMV6v8... (flutter/engine#39283)

* 957412921 Python compatibility fix (flutter/engine#39286)

* 3147334f2 Roll Skia from 3c6eb76a683a to c29211525dac (2 revisions) (flutter/engine#39289)

* cd2e8885e Roll Fuchsia Linux SDK from cTwkXiHcuqwrumaJ5... to 71lEeibIyrq0V8jId... (flutter/engine#39284)
2023-01-31 18:41:51 +00:00
Michael Goderbauer
2fccf4d471
Remove MediaQuery from WidgetsApp (#119377)
* Remove MediaQuery from WidgetsApp

* more

* fix test

* more deprecation notices.
2023-01-31 17:55:54 +00:00
Ian Hickson
d4c74858fd
Make Decoration.padding non-nullable (#119581)
The default implementation returns EdgeInsets.zero, the ShapeDecoration subclass already makes it non-nullable, and there isn't any benefit to returning null as far as I can tell.
2023-01-31 17:51:49 +00:00
Victoria Ashworth
f6b0c6ddef
Use first Dart VM Service found with mDNS if there are duplicates (#119545)
* fix when duplicate mdns results are found

* put mdns auth code in it's own function and update tests

* add comments, refactor auth code parsing, other small tweaks
2023-01-31 17:48:19 +00:00
engine-flutter-autoroll
a16d82cbad
aa00da3c1 Roll Skia from fc31f43cc40a to 3c6eb76a683a (1 revision) (flutter/engine#39280) (#119605) 2023-01-31 17:38:56 +00:00
Chris Bracken
d272a3ab80
Reland: [macos] add flavor options to tool commands (#119564)
* Reland: [macos] add flavor options to tool commands

Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.

This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:

The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:

* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout

Fixes #64088

* Partial revert: eliminate install check on desktop

The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.

Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.

Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
2023-01-31 17:37:46 +00:00
Danny Tuppeny
67d07a6de4
[flutter_tools] Fix parsing of existing DDS URIs from exceptions (#119506)
* [flutter_tools] Fix parsing of existing DDS URIs from exceptions

Fixes #118609.

* Fix formatting

Co-authored-by: Christopher Fujino <fujino@google.com>

* Fix formatting

Co-authored-by: Christopher Fujino <fujino@google.com>

---------

Co-authored-by: Christopher Fujino <fujino@google.com>
2023-01-31 17:36:44 +00:00
engine-flutter-autoroll
df0ab40ece
Roll Plugins from ff84c44a5ddb to 9da327ca39c4 (15 revisions) (#119629)
* 90f447313 [ci] Increase timeouts for platform_tests (flutter/plugins#7036)

* f5568e4b1 [google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID (flutter/plugins#4747)

* 0c05e8d91 Roll Flutter from a815ee634202 to 75680ae99e85 (58 revisions) (flutter/plugins#7048)

* a4c320902 [camera]: Bump camerax_version from 1.3.0-alpha02 to 1.3.0-alpha03 in /packages/camera/camera_android_camerax/android (flutter/plugins#7061)

* 8f12b27b6 [ci] Add LUCI versions of macOS ARM tests (flutter/plugins#6984)

* 3843b38e2 [tool] Improve main-branch detection (flutter/plugins#7038)

* d39e7569c [in_app_purchase] Prep for more const widgets (flutter/plugins#7030)

* ddb9777ee [ci] Switch remaining macOS host tests to LUCI (flutter/plugins#7063)

* 2edf56324 [ci] Part 1 of swapping iOS platform test arch (flutter/plugins#7064)

* 35f0b1a49 [camerax] Add system services to plugin (flutter/plugins#6986)

* 5dd0f41a2 [webview]: Bump mockito-inline (flutter/plugins#7056)

* 1896f10ca [webview_flutter_wkwebview][webview_flutter_android] Fixes bug where the `WebView`s could not be released (flutter/plugins#6996)

* a494825fa [camerax] Allow instance manager to create identical objects (flutter/plugins#7034)

* 6ef73da26 [ci] Increase heavy workload memory (flutter/plugins#7065)

* 9da327ca3 [various] Update to use sharedDarwinSource (flutter/plugins#7027)
2023-01-31 17:33:23 +00:00
engine-flutter-autoroll
2c34a88eb8
Roll Flutter Engine from 9448f2966c11 to 72abe0e4b828 (3 revisions) (#119603)
* a80741c39 Roll Skia from 3c4cd77c5e5d to fc31f43cc40a (1 revision) (flutter/engine#39278)

* b7f152d50 Download emsdk for web framework tests. (flutter/engine#39268)

* 72abe0e4b Remove useless variable in Canvas.drawCircle. (flutter/engine#39250)
2023-01-31 07:28:09 +00:00
Casey Hillers
7ba440655a
Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)
This reverts commit 530c3f2d13bae3c45510ae5e4a0d9a5cd987a5aa.
2023-01-30 20:37:21 -08:00
engine-flutter-autoroll
504e5652f0
Roll Flutter Engine from 77218818138f to 9448f2966c11 (3 revisions) (#119592)
* 999e5e5fc Rebase all (flutter/engine#38855)

* 9cc2a8e8f Update bytes str code (flutter/engine#39275)

* 9448f2966 Revert "[fuchsia] Diagnostics directory rights are R* (#39203)" (flutter/engine#39271)
2023-01-31 03:37:11 +00:00
Michael Goderbauer
5b6572f96d
Add debug diagnostics to channels integration test (#119579) 2023-01-31 02:55:01 +00:00
Michael Goderbauer
65900b71b9
Remove deprecated AnimatedSize.vsync parameter (#119186)
* Remove deprecated AnimatedSize.vsync parameter

* add dartfix

* Update packages/flutter/lib/fix_data/fix_widgets/fix_widgets.yaml

* Update packages/flutter/lib/fix_data/fix_widgets/fix_widgets.yaml

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-01-31 02:52:49 +00:00
engine-flutter-autoroll
2340902534
Roll Flutter Engine from daa8eeb7fc0b to 77218818138f (3 revisions) (#119586)
* e67a30e00 [web] @JS('Intl') (flutter/engine#39211)

* 7cb1f0ce7 [web] Use our own icu_bidi (flutter/engine#39200)

* 772188181 @alwaysThrows is deprecated. Return `Never` instead. (flutter/engine#39269)
2023-01-31 02:51:16 +00:00
LongCatIsLooong
1148a2a8ba
Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (#119359)
* PostFrameCallbacks -> compositionCallbacks

* review

* review
2023-01-31 01:39:09 +00:00
engine-flutter-autoroll
865dc5c510
Roll Flutter Engine from 5011144c0b46 to daa8eeb7fc0b (2 revisions) (#119584)
* 033514b3d [Windows] Remove dead code from FlutterWindow tests (flutter/engine#39216)

* daa8eeb7f [Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests (flutter/engine#39209)
2023-01-31 01:09:05 +00:00
engine-flutter-autoroll
edaeec8ed5
Roll Flutter Engine from b2efe01754ef to 5011144c0b46 (3 revisions) (#119578)
* 46adc3f5b Roll Skia from 59dcffca9061 to 3c4cd77c5e5d (22 revisions) (flutter/engine#39264)

* a1c06a5c8 Roll Fuchsia Mac SDK from EAFnGijD0l5QxaPxF... to CNkyuFjzxZhOxLNRS... (flutter/engine#39263)

* 5011144c0 Roll Fuchsia Linux SDK from xTXbcsPr5GJvFSLha... to cTwkXiHcuqwrumaJ5... (flutter/engine#39265)
2023-01-31 00:21:14 +00:00
Renzo Olivares
1f0b6fbd7a
Remove deprecated AppBar/SliverAppBar/AppBarTheme.textTheme member (#119253)
* remove textTheme usage from AppBar SliverAppBar and AppBarTheme and migrate usages in the framework

* Fix test

* update _PackageLicensePageTitle to accept titleTextStyle

* Fix test

---------

Co-authored-by: Renzo Olivares <roliv@google.com>
2023-01-31 00:00:43 +00:00
Flutter GitHub Bot
8898f4f198
Marks Mac_android run_debug_test_android to be unflaky (#117468) 2023-01-30 23:26:54 +00:00
engine-flutter-autoroll
c4520bc8b0
b2efe0175 [web] Expose felt flag for building CanvasKit Chromium (flutter/engine#39201) (#119567) 2023-01-30 23:25:29 +00:00
LongCatIsLooong
329f86a907
Make a few values non-nullable in cupertino (#119478) 2023-01-30 22:51:21 +00:00
Loïc Sharma
18c7f8a278
Fix typo in --machine help text (#119563) 2023-01-30 22:46:48 +00:00
hangyu
b227df3089
Hint text semantics to be excluded in a11y read out if hintText is not visible. (#119198)
* Update input_decorator.dart

* Update text_field_test.dart

* Update time_picker.dart

Update time_picker.dart
2023-01-30 14:45:26 -08:00
Renzo Olivares
6c12e39947
Introduce ParagraphBoundary subclass for text editing (#116549)
* attempt to extend to paragraph

* second attempt

* clean up implementation

* clean up

* updates

* updates

* Fix implementation

* remove old

* update docs

* update docs

* fix analyzer

* Fix bug where new line character was selected and backwards selection failed

* remove print

* Add test for paragraph boundary

* Add text editing test for extending selection to paragraph for mac and ios

* rename to ExtendSelectionToParagraphBoundaryIntent

* fix analyzer

* Should default to downstream when collapsing selection

* get rid of _getParagraphAtOffset and move into getTextBoundaryAt

* Search for all line terminators

* iterate through code units instead of characters

* Address some reviewer comments"

* Add separate implementations for leading and trailing paragraph boundary methods

* Do not break after a carriage return if it is followed by a line feed

* test carriage return followed by a line feed

* more tests

* Do not continue if the line terminator is at the target text offset

* add hack to extend highlight to line terminator

* Revert "add hack to extend highlight to line terminator"

This reverts commit b4d3c434539b66c3c81c215e87c645b425902825.

* Revert "Do not continue if the line terminator is at the target text offset"

This reverts commit 789e1b838e54e7c25600bfa8852e59431ccaf5dc.

* Update ParagraphBoundary with latest TextBoundary changes

* Update implementation to iterate through indexes

* update getTrailingTextBoundaryAt to include the line terminator

* Updates

* more updates

* more updates

* updates

* updates

* Lets try this again

* clean up

* updates

* more updates

* updates

* fix

* Re-implement using custom paragraph boundary applying method

* Revert "Re-implement using custom paragraph boundary applying method"

This reverts commit cd2f7f4b6eb6726b28f82a43708812e06a49df95.

* Revert "fix"

This reverts commit 8ec1f8f58935cfb3eb86dc6afd2894537af4cf7b.

* updates

* Revert "updates"

This reverts commit 9dcca4a0031fe18ada9d6ffbbe77ba09918e82ae.

* Revert "Revert "fix""

This reverts commit 9cc1332cd3041badc472d0d223a106203e46afb8.

* Revert "Revert "Re-implement using custom paragraph boundary applying method""

This reverts commit 1acb606fb743fd840da20cca26d9a7c26accb71d.

* Fix paragraph boundaries

* Add failing test

* Address some comments

* group tests and fix analyzer

* fix typo

* fix remaining test

* updates

* more fixes and logs

* clean up and add another test

* Fix last test

* Add new test

* Clean up

* more clean up

* clean up comments

* address comments

* updates

* return null when position is out of bounds and 0 or end of text if appropriate

* Clean up cases

* Do not return null when OOB in the direction of iteration

* clean up

* simplify implementation thanks to LongCatIsLooong feedback

* Address comments

* Add line and paragraph separator

* Use _moveBeyondTextBoundary instead of custom _moveToParagraphBoundary

* Change some intent names and revert fromPosition change

* clean up docs

---------

Co-authored-by: Renzo Olivares <roliv@google.com>
2023-01-30 22:44:26 +00:00
Ben Konyi
7477d7ac79
Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)
* Reland "Add --serve-observatory flag to run, attach, and test (#118402)"

This reverts commit 86ab01d2bd82333be7a0cd4957903f424de02104.

* Fix flaky failures

* Fix VM service disappearing failure
2023-01-30 21:00:18 +00:00
engine-flutter-autoroll
92df6b4bc0
396c7fd0b Reland "Remove references to Observatory (#38919)" (flutter/engine#39139) (#119546) 2023-01-30 19:44:25 +00:00
Kate Lovett
e69ea6dee4
Support flipping mouse scrolling axes through modifier keys (#115610)
* Maybe maybe

* Nit

* One more nit

* ++

* Fix test

* REview feedback

* Add comment about ios

* ++

* Doc nit

* Handle trackpads

* Review feedback
2023-01-30 19:34:48 +00:00
chunhtai
54405bfa38
fixes PointerEventConverter to handle malformed scrolling event (#118124)
* fixes PointerEventConverter to handle malformed scrolling event

* update
2023-01-30 19:33:01 +00:00
Elias Yishak
458b298f98
Refactoring to use ver command instead of systeminfo (#119304)
* refactoring to use `ver` command instead of `systeminfo`

* fix tests to match new approach

* adding another valid validator using brazil locale text

* refactor tests to use generic fake class `ver` arg + showing output from `ver` if unsuccessful

* update reason text in test

* fix reason text to be hard coded
2023-01-30 19:29:13 +00:00
Camille Simon
59d80dc876
[Android] Add explicit exported tag to Linux_android flavors test (#117542)
* Add exported tag

* Undo testing changes
2023-01-30 18:47:51 +00:00
Flutter GitHub Bot
b68cebd9ce
roll packages (#119530) 2023-01-30 18:46:35 +00:00
Flutter GitHub Bot
df8ad3d2cb
roll packages (#119370) 2023-01-30 17:34:10 +00:00