This is already handled by pkg:shelf
There is some subtlety with String here, since String.length might not
align with the size in bytes over the wire, depending on the contents
and the encoding
Best to just let pkg:shelf handle it
* Make _focusDebug not interpolate in debug mode
* Add test
* Revert undesired change
* Fix test to fail before too
* Remove accidental skips
* Switch to using a generating closure for arguments.
* Remove a word
* fix: gets removedItem instead of its index
add: sliver_animated_list.0_test.dart
* fix: sliver_animated_list.0_test.dart
* fix: pr comments
* fix test import
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
---------
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
* 510ecfa93 Don't rely on timings for dimension_provider unit test. (flutter/engine#39343)
* b1ccae745 Roll Skia from 60242c4ea6a7 to c2d81db3ef41 (5 revisions) (flutter/engine#39344)
* 616ecd8be [Web][HTML] Add mirrored characters support for RTL languages (flutter/engine#39162)
* Round 2 with dimensions
* Try with stringified keys
* Forgot a comma
* trying a list of maps.
* Try key value pairs
* Try with kvm only
* try with swarming_dimensions
* Updated with fix in swarming.star
* Attempting to remove the bring up property to verify test is running.
* Remove android from target tags to avoid adb command automatically running in test_utils call.
* Remove the duplicated dependencies in the defines target that exist in the platform
* 10768c4fa Roll Skia from 532c04c00ad7 to 60242c4ea6a7 (5 revisions) (flutter/engine#39340)
* ae38c9585 Roll Dart SDK from 11d97405a447 to 73b03bb636d3 (1 revision) (flutter/engine#39341)
* e64f3264c Add missing file to artifacts.zip and win platform. (flutter/engine#39310)
* a19cf360a Roll Skia from 934ef0660509 to c3c5c6f61421 (1 revision) (flutter/engine#39332)
* 76dc4f989 Roll Skia from c3c5c6f61421 to 532c04c00ad7 (1 revision) (flutter/engine#39333)
* 8a74e633e Roll Dart SDK from 99014717b633 to 11d97405a447 (3 revisions) (flutter/engine#39337)
* 67662080e Roll Fuchsia Mac SDK from j5rQsxkO2VJrX55Yj... to rqjJA8z_K0gdGcsvA... (flutter/engine#39338)
* 388890a98 [Windows] Use 'ninja' instead of 'ninja.exe' (flutter/engine#39326)
* add asset manifest bin loading and asset manifest api
* use new api for image resolution
* remove upfront smc data casting
* fix typecasting issue
* remove unused import
* fix tests
* lints
* lints
* fix import
* revert image resolution changes
* Update image_resolution_test.dart
* Update decode_and_parse_asset_manifest.dart
* make targetDevicePixelRatio optional
* Update packages/flutter/lib/src/services/asset_manifest.dart
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
* Update packages/flutter/lib/src/services/asset_manifest.dart
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
* fix immutable not being imported
* return List in AssetManifest methods, fix annotation import
* simplify onError callback
* make AssetManifest methods abstract instead of throwing UnimplementedError
* simplify AssetVariant.key docstring
* tweak _AssetManifestBin docstring
* make AssetManifest and AssetVariant doc strings more specific
* use List.of instead of List.from for type-safety
* adjust import
* change _AssetManifestBin comment from doc comment to normal comment
* revert to callback function for onError in loadStructuredBinaryData
* add more to the docstring of AssetManifest.listAssets and AssetVariant.key
* add tests for CachingAssetBundle caching behavior
* add simple test to ensure loadStructuredBinaryData correctly calls load
* Update asset_manifest.dart
* update docstring for AssetManifest.getAssetVariants
* rename getAssetVariants, have it include main asset
* rename isMainAsset field of AssetMetadata to main
* (slightly) shorten name of describeAssetAndVariants
* rename describeAssetVariants back to getAssetVariants
* add tests for TestAssetBundle
* nits
* fix typo in docstring
* remove no longer necessary non-null asserts
* update gallery and google_fonts versions
---------
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
* edba2d078 Roll Skia from a2e706ab283d to 934ef0660509 (7 revisions) (flutter/engine#39327)
* 387a894f6 Roll Fuchsia Mac SDK from 31KOCvc_d1yPT_yes... to j5rQsxkO2VJrX55Yj... (flutter/engine#39328)
* b8b49e161 Roll buildroot to #75f75b73. (flutter/engine#39329)
* 679c4b42e Roll Dart SDK from 1c219a91e637 to 99014717b633 (1 revision) (flutter/engine#39330)
* Run Mac hostonly presubmit tests on any available arch
* Force all Mac tests to run on arm64 to validate in presubmit
* Go back to web tests on x64
* Run plugin_test_ios on x64
* Try Chrome 110 on arm
* Revert chrome bump, remove forcing arm64
* Update issue number
* 4b77e7793 [Impeller] improve blur performance for Android and iPad Pro. (flutter/engine#39291)
* 97d27ff59 [Impeller] let images with opacity and filters passthrough. (flutter/engine#39237)
* 39b86cf03 Roll Fuchsia Linux SDK from TFcelQ5SwrzkcYK2d... to QxkjqmRgowkk_n2NZ... (flutter/engine#39322)
* a12d10277 Roll Skia from 86f7b2dd2b4f to a2e706ab283d (7 revisions) (flutter/engine#39323)
* 🔥 Do not format the messages file
* ✅ Add test
* ✅ Add the link to the test
* ✅ Respect the path separator from the file system
* ✅ Add the untranslated messages file existence test
* 30ba71efa Roll Skia from 8f33da33edcf to 4b5799677173 (1 revision) (flutter/engine#39318)
* 0de70dbe5 Use the x64 toolchain when building host artifacts on arm64 mac (flutter/engine#39279)
* 4fc0a0297 Update README.md (flutter/engine#39319)
* bae377499 Roll Skia from 4b5799677173 to 86f7b2dd2b4f (8 revisions) (flutter/engine#39320)
* ba3adb74d Roll Dart SDK from 88d1f3ffa266 to b47964e5d575 (1 revision) (flutter/engine#39321)
* Check whether slider is mounted before interaction, no-op if unmounted (#113556)
* Check whether slider is unmounted before interaction
* Update slider.dart
* Update Slider
* Add test
* Update slider_test.dart
* Update packages/flutter/test/material/slider_test.dart
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
* exposed tooltip longPress action when available
* updated tooltip test
* updated date picker test
---------
Co-authored-by: Mingyu <lyming90@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Harper Liu <harperl0818@gmail.com>
* 4ea9d6cdf Roll Skia from da41cf18f651 to 8f33da33edcf (1 revision) (flutter/engine#39315)
* 0bc7bce97 Roll Dart SDK from de03e1f41b50 to 88d1f3ffa266 (1 revision) (flutter/engine#39316)
* c08a286d6 Roll Fuchsia Mac SDK from Clk4li1185E2JoIkU... to 31KOCvc_d1yPT_yes... (flutter/engine#39317)
