11986 Commits

Author SHA1 Message Date
Øystein K
35e9a84c0e Added more cupertino icons (#22347)
Microphone, clock, time, padlock and eye icons added (both outlined and solid)
2018-09-27 09:16:13 -07:00
Michael Klimushyn
020fd590b0
Prevent dropdown menu's scroll offset from going negative (#22235)
In long lists this resulted in the dropdown scrolling to the very last
item in its list. Now clamping the value at `0.0`. Added a test to
verify that the selected item aligns with the button to test the offset.

Fixes flutter/flutter#15346
2018-09-26 14:28:26 -07:00
Jonah Williams
63f2fb9f5d
Add coverage directory to fuchsia coverage script (#22236) 2018-09-26 13:17:20 -07:00
liyuqian
84c61ad640
Add doc for transparent image inside Opacity (#22278) 2018-09-26 13:03:26 -07:00
James D. Lin
960d669897
Make platform_channels_swift use more idiomatic Swift (#21712)
Make platform_channels_swift use more idiomatic Swift

* Remove semicolons.
* `if (condition)` => `if condition`.
* `Class.init(...)` => `Class(...)`.
* Remove `break` statements from `switch` cases.
* Remove some unnecessary uses of `self`.
2018-09-26 11:13:10 -07:00
MH Johnson
a2dbc20b77
[Documentation] Replaced lerp dart docs with macro (#22309) 2018-09-26 13:12:18 -04:00
Greg Spencer
306bcbde8a Fixes terse doctor output when no devices available. (#22108) 2018-09-26 09:33:08 -07:00
Yegor
f16d005d66
remove _ListenerMixin, which provides dubious value (#22268)
* remove _ListenerMixin, which provides dubious value

* remove trailing whitespace
2018-09-26 09:30:45 -07:00
xster
6b94e6b168 Fix picker demo safe area layout (#22244) 2018-09-26 09:28:27 -07:00
Hans Muller
63efe4c4ac
Fix some TabBarTheme mergeOs (#22285) 2018-09-26 09:11:18 -07:00
Mikkel Nygaard Ravn
52697ef962 Fixes to support add2app on iOS (#22277)
* Fix xcode_backend.sh script to support add2app

* Fix ios deployment target. Too old for new Xcode.

* Fix ios host app

* Register plugins with Flutter view
2018-09-26 01:57:05 -04:00
Michael Goderbauer
eda228404c
Strip debug symbols from App.framework for non-debug builds (#22245)
A dSYM file is created for the stripped `App.framework` and placed at `build/aot/App.dSYM`.

Reduces `App.framework` for Flutter Gallery by 6MB uncompressed, minus 23%.
Reduces `App.framework` for Hello World by 1.6MB uncompressed, minus 22%.

Fixes #4287.
Fixes #18693.
Helps with #21813.
See also #12012.

This change depends on https://dart-review.googlesource.com/c/sdk/+/76306.
2018-09-26 00:57:39 +02:00
Aart Bik
f330e27dbd
Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 (#22271)
* Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133

Included CLs:

4cf2d3990b [VM runtime] Store Smi instance type in type test cache when using the interpreter.
a6b1a99f4c Make mixins abstract by default
ab305f2f26 Recover from duplicated declarations
4e32a356e0 Ignore synthetic elements created by the parser
fc04f56430 [infra] Remove deleted Dart 1 builders (app/precomp) from the test matrix
8477dc2131 Update status after 570fd5a7884
1652850381 Compute static types during impact computation
b4341f02db Remove unneeded method rti need
570fd5a788 Error on re-export, export and import of libraries with same name.
4b312b2b8c Support multiple superclasses in the mixin `on` clause.
8debb4e9db [fuchsia] Add zx_vmo_replace_as_executable calls
d34337aa2d Ignore noSuchMethod() for the purpose of searching concrete member implementations.
b6284b41e3 Revert "[VM] Dart_Initialize no longer crashes after Dart_Cleanup"
94481adbd4 [vm] Only include debugger/profiler slots in RawCode in product mode.
519ee905f9 [VM] Dart_Initialize no longer crashes after Dart_Cleanup
53497549ab [vm] Specialize 'new List()' on kernel AST
afd4cc9d1a [vm/tfa] Infer concrete class of int literals in TFA
a4d48f49e7 [vm/tfa] Infer concrete class of string literals in TFA
9106228a55 [vm, dwarf] Set default_is_stmt to true for compatability with dsymutil.
6ce0dc0006 dartfix stub implementation
e4eb2437b8 Look into superclassConstraints while searching for a member in interfaces.
95d37b0921 Revert "Implement inheritance/override checks from the spec."
355c73d4ee [VM] Remove support for option --no-preview-dart-2
95b8a19a20 Mixin declarations don't have supertype, fix isMoreSpecificThan().
e9586a5d14 [vm] Update workaround for Android Kernel bug (b089d4f).
ef7d144bc7 Add regression test for issue 34392.
56f6c52d58 large_class_declaration_test is slow now.
0ac3b8fff9 [fuchsia] Add missing vm:entry-point annotation
19e844ed5b [dart/fuzzing] Use current directory as SDK top (by default)
58e44c1400 Don't use ClassElementImpl for now in override checking.
62d154f6a3 [vm/bytecode] Record null-initialized fields in bytecode
70cc34df21 Custom format errors and exceptions to show traces
95831136b4 Fix NPE when accessing superclass
836a1d7a88 Implement inheritance/override checks from the spec.
d07039782a Remove redundant resolution
dba8b37d38 [vm] Benchmark for reading kernel bytecode

* Move one revision later.

Rationale:
Relatively harmless change, but at least has
builds (force builds on the older revision
will take a while again).
2018-09-25 15:54:50 -07:00
MH Johnson
f37c235c32
[Material] Add TabBarTheme (#22012)
* Add tab bar theme.

* Add tab bar theme.

* Add tests, pass context to getters.

* update goldens from linux box

* update goldens from linux box

* Added new golden test, addressed comments

* override hashCode and == in TabBarTheme

* Fix comment typos

* Addressed Hans' comments.

* Formatting changes

* [TabBarTheme] Fixed spacing

* [TabBarTheme] Update goldens version to latest commit
2018-09-25 17:45:40 -04:00
Hans Muller
6c00bf98ee
Fix overscroll_demo in the a11y contrast test (#22276) 2018-09-25 14:38:25 -07:00
Kathy Walrath
387c458a98
Really fix the flutter dartdoc link (#22266)
It turns out that #21888 didn't really fix the link, because *this* is the README used by dartdoc for flutter.
2018-09-25 14:35:08 -07:00
Mikkel Nygaard Ravn
a600fe7f13 Support materializing Flutter module host app on iOS (#21276)
* Prototype

* Fix paths to Flutter library resources

* Invoke pod install as necessary for materialized modules

* Add devicelab test for module use on iOS

* Remove debug output

* Rebase, reame materialize editable

* Add devicelab test editable iOS host app

* Removed add2app test section
2018-09-25 15:21:13 -04:00
Dan Field
5c07e6dff7
fix analyzer (#22273) 2018-09-25 14:29:09 -04:00
Dan Field
ea5435c2ef
Widgets app refactor (#22269)
* Refactor of cupertino/material/widgets app

* update docs 

* Update tests for const
2018-09-25 13:57:12 -04:00
Hans Muller
582f35dfb1
PageTransitionsTheme, new MountainView page transition (#21715)
MaterialPageRoute transitions are now defined by the Theme. Added (optional) support for Android P style page transitions.
2018-09-25 10:56:29 -07:00
Greg Spencer
eadd59a9ec
Swap out the moon emoji used for progress spinner for a single-cell character. (#22243)
Swap out the moon emoji used for progress spinner for a single-cell character.

The moon emoji looked cool, but couldn't be used because of bugs in xterm.js, used for VSCode's terminal, among others. The moon emoji is two character cells wide, but xterm.js doesn't advance by two cells when it adds the emoji, but does go back by two when it backspaces.

This changes us to a different character animation (dots) that is only one cell wide, and so doesn't have this problem.
2018-09-25 10:55:41 -07:00
Dan Field
a52bd81560
Revert "Refactor of cupertino/material/widgets app (#22161)" (#22249)
This reverts commit 61cf946ba8c55c73c9119a203d07b8c025b6aa92.
2018-09-25 00:25:50 -04:00
Dan Field
61cf946ba8
Refactor of cupertino/material/widgets app (#22161)
* Make CupertinoApp and MaterialApp both use WidgetsApp for Navigator

* Make CupertinoApp and MaterialApp const constructors

* Make WidgetsApp routes aware

* Update tests
2018-09-24 23:55:03 -04:00
Jacob Richman
6776352f64 Only register WidgetInspectorService extension in debug builds. (#22238) 2018-09-24 17:24:33 -07:00
creativecreatorormaybenot
27d9004506 Added multiple Cupertino icons (#21656) 2018-09-24 16:48:20 -07:00
Andrew Davies
491c4e2138
[frdp] Removes regex check for Isolate search. (#22100)
This will now make it so that the Dart VM class returns any Isolate that
matches the passed Pattern, without checking for any specific strings
like "main()"

This causes the search to skip over Isolates that would have matched.
2018-09-24 15:30:49 -07:00
Michael Klimushyn
efbd6f604f
Update docs on various platform APIs (#22060) 2018-09-24 15:17:54 -07:00
engine-flutter-autoroll
6014f29b5a
Roll engine f4aadb11cf13..74625aed323d (2 commits) (#22227)
f4aadb11cf...74625aed32

git log f4aadb11cf13..74625aed323d --no-merges --oneline
74625aed3 Keyboard padding detection heuristic to distringuish when to include bottom inset. (flutter/engine#6288)
617b122bd Roll Dart to a2eb050044eec93f0844667b8b6132e858467e4e. (flutter/engine#6321)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-24 16:00:35 -04:00
engine-flutter-autoroll
d00b30ff84
Roll engine d5deda95176e..f4aadb11cf13 (1 commits) (#22219)
d5deda9517...f4aadb11cf

git log d5deda95176e..f4aadb11cf13 --no-merges --oneline
f4aadb11c Change FlutterDartProject to keep precedence when looking for the ass… (flutter/engine#6305)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-24 14:23:33 -04:00
Hans Muller
2d0af0aa48
Gallery accessibility test: check default themes, gallery themes (#22141) 2018-09-24 10:41:30 -07:00
engine-flutter-autoroll
8553497bd2
Roll engine 17f8b2f32ae4..d5deda95176e (1 commits) (#22215)
17f8b2f32a...d5deda9517

git log 17f8b2f32ae4..d5deda95176e --no-merges --oneline
d5deda951 Roll src/third_party/skia 0a3864651457..a9adb6f03525 (2 commits) (flutter/engine#6320)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-24 13:25:32 -04:00
Janice Collins
dc5f85e72c
Upgrade dartdoc to version 0.21.1. (#22143) 2018-09-24 09:20:15 -07:00
engine-flutter-autoroll
cb531ad8c0
Roll engine 57fd394e59b8..17f8b2f32ae4 (5 commits) (#22211)
57fd394e59...17f8b2f32a

git log 57fd394e59b8..17f8b2f32ae4 --no-merges --oneline
17f8b2f32 Roll src/third_party/skia c955a1645148..0a3864651457 (1 commits) (flutter/engine#6319)
bef460999 Roll src/third_party/skia bdb32d17999e..c955a1645148 (2 commits) (flutter/engine#6318)
6c17ce74e Roll src/third_party/skia 937348d4d442..bdb32d17999e (1 commits) (flutter/engine#6317)
94c591a1d Roll src/third_party/skia 175b587a634d..937348d4d442 (1 commits) (flutter/engine#6316)
e82db8668 Remove the unused Mac Desktop shell. (flutter/engine#6314)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-24 09:53:33 -04:00
Ian Hickson
6d134e0c86
Animation API improvements (#21540) 2018-09-23 00:43:05 -07:00
engine-flutter-autoroll
adcf226e2a
Roll engine f3a3d0ce7f0b..57fd394e59b8 (1 commits) (#22176)
f3a3d0ce7f...57fd394e59

git log f3a3d0ce7f0b..57fd394e59b8 --no-merges --oneline
57fd394e5 Ensure that objects on stack that close traces have unique variable names. (flutter/engine#6298)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-22 18:58:32 -04:00
Devon Carew
762c86995d
expose the debugProfileBuildsEnabled flag as a service extension (#21492)
* expose the debugProfileBuildsEnabled flag as a service extension

* fix tests

* review comments

* remove a new keyword

* test fixes

* review comments
2018-09-22 14:44:09 -07:00
Ian Hickson
989cf18b0d
[H] Cleanup (#21542)
* Improve documentation and clean up code.

* Remove "Note that".

The phrase "note that" is basically meaningless as a prefix to an
otherwise fine sentence.
2018-09-22 02:02:56 -07:00
engine-flutter-autoroll
5991f1f866
Roll engine cc3009cb4ea9..f3a3d0ce7f0b (5 commits) (#22162)
cc3009cb4e...f3a3d0ce7f

git log cc3009cb4ea9..f3a3d0ce7f0b --no-merges --oneline
f3a3d0ce7 Roll src/third_party/skia 11f4994b84e1..175b587a634d (1 commits) (flutter/engine#6313)
19ac3e1ac Roll src/third_party/skia 358558a4cecc..11f4994b84e1 (2 commits) (flutter/engine#6312)
7648d21b0 Dart SDK roll for 2018-09-21 (flutter/engine#6311)
5b8e8c328 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207)
02901b78c Decouple PlatformViewsController from FlutterView. (flutter/engine#6303)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-22 03:37:32 -04:00
Gary Qian
8ea841baf0
Roll engine a8890fdccd667d to 8471862cff77aa4 (#22153)
Unbreak build.

git log a8890fdccd667d0bf0fa0a81ac350dadef60bd6c..cc3009cb4ea920863b23937ef569327880b01fba --no-merges --oneline
cc3009cb4 Revert 'Dart SDK roll for 2018/09/20' 8471862c (#6309)
bbdf7c158 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (#6307)
dea09212c Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (#6308)
d29c7db76 Add logging if FlutterDartProject fails to load the application kernel snapshot (#6257)
2a1debfcc Update deprecated subtags from language subtag registry. (#6280)
540cd9626 Add Xib splashscreen support (#6289)
05f21e63a (main) Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (#6279)
ca6f10389 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (#6304)
3b46705db Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (#6302)
0c166fe3f Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (#6301)
cf0fbadce Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (#6299)
2ec20aaeb Remove bottom safe-area padding when keyboard up (#6297)
2018-09-21 17:15:17 -07:00
Gary Qian
449e3c2a0a
Roll engine 2e8e96fad1..a8890fdccd667 and fix paragraph tests (#22111) 2018-09-20 19:46:50 -07:00
Yegor
833540972f
add a test for single- and multi-line paragraph layout (#22047)
* add a test for single- and multi-line paragraph layout

* use flutter_test

* use closeTo for double comparison
2018-09-20 16:44:19 -07:00
Greg Spencer
eed8c7ad07
Fix the run_release_test devicelab test after changing output. (#22104) 2018-09-20 16:30:07 -07:00
Greg Spencer
efcd9a8001
Simplify Gradle compiler output. (#21760)
This changes the compiler output for gradle to be less verbose and more easily read.

This only applies to compilation error messages: other gradle messages will continue to print as before.

It also fixes a small problem with the performance measurement printing (see that "7.1s" on it's own line in the original?) so that if something is expected to have multiple lines of output, it prints an initial line, and a "Done" line with the elapsed time, so that it's possible to know what the time applies to.

It also updates the spinner to be fancier, at least on platforms other than Windows (which is missing a lot of symbols in its console font).

Addresses #17307
2018-09-20 15:45:48 -07:00
Alexander Markov
83cdb5738e
Cleanup uses of entry points files (#22098) 2018-09-20 15:10:41 -07:00
Greg Spencer
54236427dc
Fix flake in logger_test (#22095)
This fixes a flaky test where it included 0ms as part of an output check. Kind of a classic flaky test.
2018-09-20 14:45:24 -07:00
Kathy Walrath
72d86f904f
Fix a link (#21888)
Fix a link that works in GitHub but not in dartdoc.
2018-09-20 13:15:51 -07:00
Stanislav Baranov
c799c2fd80
Use "product" mode VM snapshot when running dynamic "release" mode flutter with cached engine. (#22043)
Dynamic "release" mode requires "product" (not "release") mode VM, so we must point it to the correct cached snapshot.

Generation and caching of this snapshot happens the following corresponding change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1232134
2018-09-20 13:12:38 -07:00
Alexander Aprelev
76468dd56a Dart roll 2018-09-20 12:42:41 -07:00
Alexander Aprelev
6eea84cc34 Pre-dart roll 2018-09-20 12:42:41 -07:00
Alexander Aprelev
2fec45b17d
Amend the test following console output changes. (#22093)
This is the follow-up to https://github.com/flutter/flutter/pull/20958.
2018-09-20 12:12:53 -07:00