Greg Spencer
365f577c70
Normalize assert checking of clipBehavior ( #38568 )
...
I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary.
This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
2019-08-23 14:08:04 -07:00
engine-flutter-autoroll
53168db99a
72283b641 Roll src/third_party/skia f17d1c952987..0f15d7373bf1 (6 commits) (flutter/engine#11415) ( #39139 )
...
git@github.com:flutter/engine.git/compare/1e828b2326aa...72283b64196c
git log 1e828b2326aa..72283b64196c --no-merges --oneline
2019-08-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia f17d1c952987..0f15d7373bf1 (6 commits) (flutter/engine#11415 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-23 17:06:36 -04:00
Yegor
190698d0d2
run web tests in batches; enable foundation tests ( #37268 )
...
* shard tests
* make foundation tests pass
2019-08-23 13:23:48 -07:00
lisa-liao
d883337669
[Shrine] Adding outlines to text fields ( #38895 )
...
* Adding outlines to text fields
2019-08-23 15:52:28 -04:00
engine-flutter-autoroll
7ca3ed129c
Roll engine 975a8aa5752e..1e828b2326aa (2 commits) ( #39128 )
...
git@github.com:flutter/engine.git/compare/975a8aa5752e...1e828b2326aa
git log 975a8aa5752e..1e828b2326aa --no-merges --oneline
2019-08-23 iska.kaushik@gmail.com Ios simulator unittests seem to not consider the full compilation unit (flutter/engine#11413 )
2019-08-23 iska.kaushik@gmail.com Make message loop task entry containers thread safe (flutter/engine#11367 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-23 15:42:36 -04:00
Hans Muller
cf87f68fd0
Correct InheritedTheme.captureAll() for multiple theme ancestors of the same type ( #39089 )
2019-08-23 09:41:03 -07:00
Christopher Fujino
d1e0273ecb
refactor cocoapods validator to detect broken install ( #38560 )
2019-08-23 09:21:09 -07:00
Jonah Williams
b3014ff5c0
add profile mode to flutter web applications ( #39073 )
2019-08-23 08:47:01 -07:00
Jonah Williams
b2d19d2af5
Add support for macOS release/profile mode (3 of 3) ( #38909 )
2019-08-23 08:46:24 -07:00
Greg Spencer
055c548902
Fix KeySet<T> (and LogicalKeySet, PhysicalKeySet) hashCode calculation ( #38936 )
...
This fixes the hashCode calculation for KeySet<T> so that it doesn't depend on the insertion order of the keys in the set.
The fix involves switching from Set<T> to HashSet<T> internally, so that the iteration order is stable around the hash values of the inserted keys, and not the insertion order. This matters when hashList is called in KeySet<T>.hashCode to build the hash value of the contents of the internal set.
Fixes #38919
2019-08-23 07:51:35 -07:00
Michael Thomsen
01a5d112d5
Make forward calls run interactively ( #39052 )
2019-08-23 11:16:30 +02:00
engine-flutter-autoroll
5cd93ed9bd
Roll engine 78ac65320bde..975a8aa5752e (11 commits) ( #39099 )
...
git@github.com:flutter/engine.git/compare/78ac65320bde...975a8aa5752e
git log 78ac65320bde..975a8aa5752e --no-merges --oneline
2019-08-23 bkonyi@google.com Roll src/third_party/dart 022585cfe2..06d3769ac6 (12 commits)
2019-08-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 941d0a365045..f17d1c952987 (1 commits) (flutter/engine#11393 )
2019-08-23 chinmaygarde@google.com Wire up software rendering in the test compositor. (flutter/engine#11392 )
2019-08-23 bkonyi@google.com Roll src/third_party/dart 88c0c11612..022585cfe2 (14 commits)
2019-08-23 yjbanov@google.com preventDefault on touchend to show iOS keyboard (flutter/engine#11390 )
2019-08-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2a5954140b49..941d0a365045 (6 commits) (flutter/engine#11389 )
2019-08-22 stuartmorgan@google.com Allow overriding the GLFW pixel ratio (flutter/engine#11388 )
2019-08-22 stuartmorgan@google.com Allow non-resizable windows in GLFW embedding (flutter/engine#11386 )
2019-08-22 yjbanov@google.com sync web engine; run web engine tests (flutter/engine#11031 )
2019-08-22 garyq@google.com Reland "Track detailed LibTxt metrics with LineMetrics(#10127 )" (flutter/engine#11064 )
2019-08-22 egarciad@google.com Remove empty line in the pom file (flutter/engine#11382 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-23 04:30:36 -04:00
engine-flutter-autoroll
d70a6a1b09
Roll engine 5f03c7e35d71..78ac65320bde (3 commits) ( #39084 )
...
git@github.com:flutter/engine.git/compare/5f03c7e35d71...78ac65320bde
git log 5f03c7e35d71..78ac65320bde --no-merges --oneline
2019-08-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 068af9e416cb..2a5954140b49 (8 commits) (flutter/engine#11383 )
2019-08-22 stuartmorgan@google.com Switch to an incremental runloop for GLFW (flutter/engine#11368 )
2019-08-22 dnfield@google.com Update scenarios readme (flutter/engine#11374 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-23 02:22:36 -04:00
Mehmet Fidanboylu
d921098dd4
Break dependency of tools/lib/src from lib/src/commands/ ( #39072 )
2019-08-22 21:14:03 -07:00
Michael Goderbauer
97df403398
TweenAnimationBuilder for building custom animations without managing an AnimationController ( #38317 )
2019-08-22 20:48:53 -07:00
engine-flutter-autoroll
98ef956073
Roll engine 0345967a1964..5f03c7e35d71 (3 commits) ( #39074 )
...
git@github.com:flutter/engine.git/compare/0345967a1964...5f03c7e35d71
git log 0345967a1964..5f03c7e35d71 --no-merges --oneline
2019-08-22 stuartmorgan@google.com Use of App.framework in macOS FlutterDartProject (flutter/engine#11380 )
2019-08-22 bkonyi@google.com Roll src/third_party/dart 9fda4c1101..88c0c11612 (12 commits)
2019-08-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia c071fc92cd3d..068af9e416cb (3 commits) (flutter/engine#11379 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-22 16:26:36 -04:00
engine-flutter-autoroll
c3390b7288
0345967a1 Include Java stack trace in method channel invocations (flutter/engine#11361) ( #39064 )
...
git@github.com:flutter/engine.git/compare/bb8e6e4dbcbb...0345967a1964
git log bb8e6e4dbcbb..0345967a1964 --no-merges --oneline
2019-08-22 amirh@users.noreply.github.com Include Java stack trace in method channel invocations (flutter/engine#11361 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-22 14:37:36 -04:00
lisa-liao
ae847d9730
Allow independent theming of Persistent and Modal bottom sheets ( #38650 )
...
BottomSheetThemeData has an additional field modalElevation which makes it possible to set different elevations between persistent and modal bottom sheets.
2019-08-22 13:58:39 -04:00
Shi-Hao Hong
f0656ac37d
Explain const values in MediaQuery test file ( #39059 )
2019-08-22 13:43:17 -04:00
ryenus
8a258dca48
echo error messages to stderr ( #37845 )
...
Otherwise the error messages would be executed as code when the output
is supposed to be sourced, e.g. $(flutter bash-completion)
2019-08-22 10:10:00 -07:00
engine-flutter-autoroll
bd3305b14b
bb8e6e4db Roll src/third_party/dart 1279641cdd..9fda4c1101 (3 commits) ( #39058 )
...
git@github.com:flutter/engine.git/compare/17f1b500f9db...bb8e6e4dbcbb
git log 17f1b500f9db..bb8e6e4dbcbb --no-merges --oneline
2019-08-22 bkonyi@google.com Roll src/third_party/dart 1279641cdd..9fda4c1101 (3 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-22 12:37:36 -04:00
Jonah Williams
9818d2df3b
Add web workflow to default validators ( #39006 )
2019-08-22 09:30:19 -07:00
Zachary Anderson
663dc1d774
[flutter_tool] Teach crash reporter about HttpException ( #39005 )
2019-08-22 09:18:25 -07:00
engine-flutter-autoroll
0249050f23
Roll engine fc27f80a1242..17f1b500f9db (2 commits) ( #39042 )
...
git@github.com:flutter/engine.git/compare/fc27f80a1242...17f1b500f9db
git log fc27f80a1242..17f1b500f9db --no-merges --oneline
2019-08-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 42c6af9182d2..c071fc92cd3d (6 commits) (flutter/engine#11372 )
2019-08-22 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from 4uAyd... to NRiBy... (flutter/engine#11371 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-22 10:56:36 -04:00
Jonah Williams
33e7af728a
Dont throw StateError when calling assemble with bad target ( #39000 )
2019-08-21 23:44:39 -07:00
engine-flutter-autoroll
1096ea38a0
fc27f80a1 1. Update license files to account for the new Dart License file (flutter/engine#11364) ( #39028 )
...
git@github.com:flutter/engine.git/compare/3c695b131ce7...fc27f80a1242
git log 3c695b131ce7..fc27f80a1242 --no-merges --oneline
2019-08-22 a-siva@users.noreply.github.com 1. Update license files to account for the new Dart License file (flutter/engine#11364 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-22 02:26:36 -04:00
engine-flutter-autoroll
8f8bb496c8
3c695b131 Roll src/third_party/skia 9e081d164c81..42c6af9182d2 (3 commits) (flutter/engine#11366) ( #39024 )
...
git@github.com:flutter/engine.git/compare/e6b983cefe2a...3c695b131ce7
git log e6b983cefe2a..3c695b131ce7 --no-merges --oneline
2019-08-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e081d164c81..42c6af9182d2 (3 commits) (flutter/engine#11366 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-22 01:03:36 -04:00
Shi-Hao Hong
3b7410476f
Add MediaQuery.systemGestureInsets to support Android Q ( #37416 )
...
* Wire Window.systemGestureInsets to MediaQuery.systemGestureInsets
* Add systemGestureInsets property to TestWindow
2019-08-22 00:34:11 -04:00
engine-flutter-autoroll
3f6bac66d3
e6b983cef Build legacy web dart sdk (flutter/engine#11360) ( #39023 )
...
git@github.com:flutter/engine.git/compare/ccf5d619b58a...e6b983cefe2a
git log ccf5d619b58a..e6b983cefe2a --no-merges --oneline
2019-08-22 jonahwilliams@google.com Build legacy web dart sdk (flutter/engine#11360 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 23:34:36 -04:00
LongCatIsLooong
a671b28369
CupertinoDynamicColor and friends ( #37719 )
2019-08-21 20:07:42 -07:00
Chris Bracken
ffa3785411
Update package versions to latest ( #39013 )
...
This fixes a breakage in fuchsia where package_config version 1.1.0 is
required but flutter_tools is currently locked to 1.05.
2019-08-21 19:15:33 -07:00
Jenn Magder
892d62f03a
Clean Xcode workspace during flutter clean ( #38992 )
2019-08-21 18:42:56 -07:00
engine-flutter-autoroll
aa41088e76
Roll engine 3606f7bc2d06..ccf5d619b58a (2 commits) ( #39015 )
...
git@github.com:flutter/engine.git/compare/3606f7bc2d06...ccf5d619b58a
git log 3606f7bc2d06..ccf5d619b58a --no-merges --oneline
2019-08-21 chinmaygarde@google.com Dry up fixture comparison in embedder unit-tests. (flutter/engine#11359 )
2019-08-21 egarciad@google.com Remove engine hash from pom filename (flutter/engine#11356 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 21:40:36 -04:00
engine-flutter-autoroll
01ac023dba
3606f7bc2 Roll src/third_party/skia 80bff5b3a2d7..9e081d164c81 (16 commits) (flutter/engine#11354) ( #39007 )
...
git@github.com:flutter/engine.git/compare/1efb5b770c97...3606f7bc2d06
git log 1efb5b770c97..3606f7bc2d06 --no-merges --oneline
2019-08-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 80bff5b3a2d7..9e081d164c81 (16 commits) (flutter/engine#11354 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 20:08:36 -04:00
adazh
93c32c4ff6
Moved the default BinaryMessenger instance to ServicesBinding ( #38464 )
...
* Moved the default BinaryMessenger instance to ServicesBinding
This reverts commit 821602aef36983d416836e5d6fcc78fe9d3facb1.
* Added assertion in defaultBinaryMessenger. Also fixed the devicelab tests.
2019-08-21 16:47:42 -07:00
engine-flutter-autoroll
ddb10dd9d1
Roll engine ab097a59faf5..1efb5b770c97 (2 commits) ( #39004 )
...
git@github.com:flutter/engine.git/compare/ab097a59faf5...1efb5b770c97
git log ab097a59faf5..1efb5b770c97 --no-merges --oneline
2019-08-21 dnfield@google.com update sim script (flutter/engine#11355 )
2019-08-21 dnfield@google.com Firebase test for Platform Views on iOS (flutter/engine#11350 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 18:31:36 -04:00
Jenn Magder
2ba3054d90
Mark smoke_catalina_start_up not flaky ( #38999 )
2019-08-21 15:24:52 -07:00
LongCatIsLooong
9aea03f4af
Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport ( #37024 )
2019-08-21 15:02:24 -07:00
Nigel Gott
bf097eec87
Fix DragTarget not being rebuilt when a rejected Draggable enters #38786 ( #38789 )
2019-08-21 14:53:18 -07:00
Hans Muller
2e01eef5aa
Added InheritedTheme ( #38583 )
2019-08-21 14:02:19 -07:00
∂ω∂
4277f364ff
flutter_tools/version: git log.showSignature=false ( #38576 )
2019-08-21 13:55:57 -07:00
rami-a
6a5d32962c
[Material] Add clip property to bottom sheet and theme ( #38831 )
2019-08-21 16:14:52 -04:00
Zachary Anderson
36e8b93d1c
[flutter_tool] Only send one crash report per run ( #38925 )
2019-08-21 13:07:52 -07:00
engine-flutter-autoroll
ea64b84dc1
ab097a59f De-dup FILE output for each license (flutter/engine#10945) ( #38996 )
...
git@github.com:flutter/engine.git/compare/29469f39c13a...ab097a59faf5
git log 29469f39c13a..ab097a59faf5 --no-merges --oneline
2019-08-21 stuartmorgan@google.com De-dup FILE output for each license (flutter/engine#10945 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 16:02:36 -04:00
Zachary Anderson
3ceef86b9a
[flutter_tool] Handle crashes from doctor validators ( #38920 )
2019-08-21 11:15:02 -07:00
engine-flutter-autoroll
6e34e805b3
Roll engine 9f8b1d223ee8..29469f39c13a (3 commits) ( #38982 )
...
git@github.com:flutter/engine.git/compare/9f8b1d223ee8...29469f39c13a
git log 9f8b1d223ee8..29469f39c13a --no-merges --oneline
2019-08-21 tamird@google.com [lsc] Remove fuchsia.net.SocketProvider (flutter/engine#11316 )
2019-08-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia f99b7960f433..80bff5b3a2d7 (2 commits) (flutter/engine#11343 )
2019-08-21 egarciad@google.com Remove engine hash from the output artifact (flutter/engine#11330 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 14:02:36 -04:00
adazh
22db62c1db
Added a composable waitForCondition Driver/extension API. ( #38836 )
...
* Added a composable waitForCondition Driver/extension API.
This reverts commit df2db4e50f64de732a517db56d410d90a310268c.
* Added SerializableWaitCondition for communicating between driver script on host and extension on device.
2019-08-21 09:42:26 -07:00
engine-flutter-autoroll
9c3e4de4c0
Roll engine ba51408257b6..9f8b1d223ee8 (3 commits) ( #38974 )
...
git@github.com:flutter/engine.git/compare/ba51408257b6...9f8b1d223ee8
git log ba51408257b6..9f8b1d223ee8 --no-merges --oneline
2019-08-21 stuartmorgan@google.com Clean up Windows and Linux build output (flutter/engine#11324 )
2019-08-21 stuartmorgan@google.com Roll angle licenses (flutter/engine#11035 )
2019-08-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0b9801eadc12..f99b7960f433 (3 commits) (flutter/engine#11338 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 12:34:36 -04:00
engine-flutter-autoroll
948316cd17
Roll engine 05a0074580e1..ba51408257b6 (3 commits) ( #38960 )
...
git@github.com:flutter/engine.git/compare/05a0074580e1...ba51408257b6
git log 05a0074580e1..ba51408257b6 --no-merges --oneline
2019-08-21 chinmaygarde@google.com Reference the Flutter framework instead of the dylib in iOS tests. (flutter/engine#11337 )
2019-08-21 jonahwilliams@google.com Reland remove kernel sdk script (flutter/engine#10814 )
2019-08-21 stuartmorgan@google.com Fix change_install_name.py to be GN-friendly (flutter/engine#11309 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 10:04:40 -04:00
engine-flutter-autoroll
15eb4fdb31
Roll engine 51bdf834203c..05a0074580e1 (2 commits) ( #38955 )
...
git@github.com:flutter/engine.git/compare/51bdf834203c...05a0074580e1
git log 51bdf834203c..05a0074580e1 --no-merges --oneline
2019-08-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia aa3820a9123c..0b9801eadc12 (3 commits) (flutter/engine#11334 )
2019-08-21 dnfield@google.com Add tests for platform views (flutter/engine#11319 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-08-21 03:02:36 -04:00