firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
43,010 Commits 1 Branch 0 Tags
Commit Graph

43010 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
3abd2f3131
Roll Flutter Engine from 10e50bd42c42 to 9226b089d634 (1 revision) (#157702) 
10e50bd42c...9226b089d6

2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from cadf2538dcde to dd0158912c76 (3 revisions) (flutter/engine#56162)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-28 07:40:53 +00:00
Valentin Vignal
eef9f7129e
Add test for navigator_state.restorable_push_replacement.0.dart (#157668) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/navigator/navigator_state.restorable_push_replacement.0.dart`
 2024-10-28 06:56:39 +00:00
Sam Rawlins
5879a5cba1
Remove unsafe_html lint rule (#157531) 
Fixes https://github.com/flutter/flutter/issues/157530
 2024-10-28 01:09:20 +00:00
engine-flutter-autoroll
16c5c80867
Roll Flutter Engine from 3162aaad0086 to 10e50bd42c42 (1 revision) (#157690) 
3162aaad00...10e50bd42c

2024-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5osQdhk4W6CcWgjIg... to VJIEKDIuzhhloCBro... (flutter/engine#56154)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 5osQdhk4W6Cc to VJIEKDIuzhhl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-27 14:05:23 +00:00
yim
04bcfe9281
Fix Scaffold extend body (#157441) 
Fixes: #157316
 2024-10-27 04:54:30 +00:00
engine-flutter-autoroll
030eea8617
Roll Flutter Engine from c9b8ac96f6ce to 3162aaad0086 (3 revisions) (#157681) 
c9b8ac96f6...3162aaad00

2024-10-26 chris@bracken.jp Migrate FlutterViewController to ARC (flutter/engine#55669)
2024-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y4TdnTpLdkI107K42... to 5osQdhk4W6CcWgjIg... (flutter/engine#56152)
2024-10-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 0257f458e40a to a75848f92210 (2 revisions) (flutter/engine#56150)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Y4TdnTpLdkI1 to 5osQdhk4W6Cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-26 23:04:38 +00:00
gaaclarke
5a11904383
Relands "Wide gamut framework gradient test (#153976)" (#157643) 
This was reverted because it failed to run. Colors were getting clamped
in the dithering fragment shader.

One change was made when relanding, i increased the epsilon for the
radial and conical gradients. They don't appear to give back the exact
color you asked for.

Do not land until https://github.com/flutter/engine/pull/56140 is rolled
into the framework.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-10-26 08:44:53 -07:00
engine-flutter-autoroll
9327c24d80
Roll Flutter Engine from 7c5c5fe5c84d to c9b8ac96f6ce (3 revisions) (#157662) 
7c5c5fe5c8...c9b8ac96f6

2024-10-26 skia-flutter-autoroll@skia.org Roll Skia from da6c17329e0b to cadf2538dcde (3 revisions) (flutter/engine#56147)
2024-10-25 30870216+gaaclarke@users.noreply.github.com Removed clamping from dithering (flutter/engine#56140)
2024-10-25 jacksongardner@google.com Reland (x2) Skwasm overlay optimizations (flutter/engine#56067)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-26 13:37:42 +00:00
Valentin Vignal
2d09837ed0
Add test for navigator_state.restorable_push_and_remove_until.0.dart (#157595) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/navigator/navigator_state.restorable_push_and_remove_until.0.dart`
 2024-10-26 10:21:26 +00:00
Matan Lurey
3af8b0a4df
Tighten up throwToolExit, explain when to use it. (#157561) 
Documents when to use `throwToolExit` and how to use it.

Replaces every invocation of `throw ToolExit` with `throwToolExit` and makes the former impossible; this is so that every user will at least (hypothetically) have the chance to read the documentation attached to `throwToolExit` (and if we change parameters in the future they will all flow through one place).
 2024-10-26 03:17:24 +00:00
Matan Lurey
82a20e407e
Remove extraneous throw. (#157658) 
h/t to @tvolkert for noticing this one!
 2024-10-26 02:49:20 +00:00
Valentin Vignal
4e52defed4
Add tests for navigator.restorable_push.0.dart (#157492) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/navigator/navigator.restorable_push.0.dart`
 2024-10-26 02:39:13 +00:00
engine-flutter-autoroll
ece457ba74
Roll Flutter Engine from 43e4d9a30666 to 7c5c5fe5c84d (1 revision) (#157644) 
43e4d9a306...7c5c5fe5c8

2024-10-25 jonahwilliams@google.com [Impeller] Lock access to descriptor
pool map. (flutter/engine#56113)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 16:01:12 -07:00
engine-flutter-autoroll
9b84dbed06
Roll Flutter Engine from 5061358e255f to 43e4d9a30666 (1 revision) (#157637) 
5061358e25...43e4d9a306

2024-10-25 skia-flutter-autoroll@skia.org Roll Dart SDK from
3067d697ae26 to 0257f458e40a (4 revisions) (flutter/engine#56135)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 14:49:51 -07:00
engine-flutter-autoroll
1cc8a07ace
Roll Flutter Engine from eb867e055790 to 5061358e255f (2 revisions) (#157623) 
eb867e0557...5061358e25

2024-10-25 30870216+gaaclarke@users.noreply.github.com renamed TextFrameDispatcher to FirstPassDispatcher (flutter/engine#56098)
2024-10-25 30870216+gaaclarke@users.noreply.github.com Added retry mechanism for pipeline creation (flutter/engine#56071)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 20:31:21 +00:00
Polina Cherkasova
9cf98f7273
Create flutter specific leak troubleshooting guidance. (#157396) 2024-10-25 13:25:34 -07:00
Kate Lovett
2c20325af4
Update CupertinoNavigationBar to support large layout (#157133) 
Fixes https://github.com/flutter/flutter/issues/149625

This adds a new constructor CupertinoNavigationBar.large for the large style navigation bar. CupertinoSliverNavigationBar enables dynamically changing between the smaller and larger layouts for native iOS headers in response to scrolling, this change makes it possible to configure the static navigation bar in one style or the other.
 2024-10-25 19:08:12 +00:00
engine-flutter-autoroll
6337eb1a39
Roll Flutter Engine from 38e9be1f74fa to eb867e055790 (3 revisions) (#157613) 
38e9be1f74...eb867e0557

2024-10-25 30870216+gaaclarke@users.noreply.github.com Faster vulkan buffer tracking (flutter/engine#56099)
2024-10-25 jonahwilliams@google.com [Impeller] Reland: hash less stuff per frame. (flutter/engine#55742)
2024-10-25 skia-flutter-autoroll@skia.org Roll Skia from cc75472dedc2 to da6c17329e0b (3 revisions) (flutter/engine#56132)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 18:43:25 +00:00
auto-submit[bot]
add7e81f4f
Reverts "Wide gamut framework gradient test (#153976)" (#157615) 
Reverts: flutter/flutter#153976
Initiated by: jonahwilliams
Reason for reverting: failing on postsubmit
Original PR Author: gaaclarke

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
issue: https://github.com/flutter/flutter/issues/127855
depends on https://github.com/flutter/engine/pull/54748 being rolled into the framework
 2024-10-25 17:38:18 +00:00
gaaclarke
4f66f1333f
Wide gamut framework gradient test (#153976) 
issue: https://github.com/flutter/flutter/issues/127855
depends on https://github.com/flutter/engine/pull/54748 being rolled into the framework
 2024-10-25 17:04:57 +00:00
engine-flutter-autoroll
8252990e1b
Roll Flutter Engine from b413d9996c86 to 38e9be1f74fa (2 revisions) (#157604) 
b413d9996c...38e9be1f74

2024-10-25 robert.ancell@canonical.com Clean up comments and names in FlView (flutter/engine#56084)
2024-10-25 robert.ancell@canonical.com Move platform handler from FlView to FlEngine (flutter/engine#56024)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 16:39:58 +00:00
engine-flutter-autoroll
74a6613469
Roll Packages from a556f0f52825 to e0c4f55cd355 (2 revisions) (#157605) 
a556f0f528...e0c4f55cd3

2024-10-25 stuartmorgan@google.com [path_parsing] Initial import (flutter/packages#7908)
2024-10-24 stuartmorgan@google.com [video_player] Simplify Pigeon API on Android (flutter/packages#7909)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 16:35:57 +00:00
Jonah Williams
c4c545215a
Support backdrop key in flutter framework. (#157278) 
The backdrop key functionality allows multiple backdrop filters to share the same input filter, dramatically improving raster performance. This is only supported on the Impeller backend.

The backdrop key class allocates a new int from a static and passes this to the engine layer. with 64 bit integers, we can allocate many backdrop filter ids per frame and never run out.

See also: https://github.com/flutter/flutter/issues/156455

```dart
import 'dart:math';
import 'dart:ui';

import 'package:flutter/material.dart';

final _random = Random();

void main() => runApp(const BackdropFilterDemo());

class BackdropFilterDemo extends StatelessWidget {
  const BackdropFilterDemo({super.key});

  static final listKey = BackdropKey();
  static final overlayKey = BackdropKey();

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        backgroundColor: Colors.white,
        body: Stack(
          children: [
            ListView.builder(
              itemCount: 120, // 60 pairs of red and blue containers
              itemBuilder: (context, index) {
                return Container(
                  height: 100,
                  color: index % 2 == 0 ? Colors.red : Colors.blue,
                );
              },
            ),
            Center(
              child: Container(
                width: 400,
                height: 400,
                decoration: BoxDecoration(
                  border: Border.all(color: Colors.black),
                ),
                child: Image.network('https://picsum.photos/400'),
              ),
            ),
            ListView.separated(
              separatorBuilder: (_, __) => const SizedBox(height: 8),
              itemBuilder: (context, index) => BlurEffect(
                backdropKey: listKey,
                child: SizedBox(
                  height: 50,
                  child: Center(
                    child: Text(index.toString(),
                        style: const TextStyle(color: Colors.white)),
                  ),
                ),
              ),
              itemCount: 200,
            ),
            Positioned.fill(
              bottom: null,
              child: BlurEffect(
                backdropKey: overlayKey,
                child: Padding(
                  padding: EdgeInsets.only(
                    top: MediaQuery.of(context).viewPadding.top,
                  ),
                  child: const SizedBox(height: 45),
                ),
              ),
            ),
            Positioned.fill(
              top: null,
              child: BlurEffect(
                backdropKey: overlayKey,
                child: Padding(
                  padding: EdgeInsets.only(
                    top: MediaQuery.of(context).viewPadding.bottom,
                  ),
                  child: const SizedBox(height: 50),
                ),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

class BlurEffect extends StatelessWidget {
  final Widget child;

  const BlurEffect({
    required this.child,
    required this.backdropKey,
    super.key,
  });

  final BackdropKey backdropKey;

  @override
  Widget build(BuildContext context) {
    return ClipRect(
      child: BackdropFilter(
        backdropKey: backdropKey,
        filter: ImageFilter.blur(
          sigmaX: 40,
          sigmaY: 40,
          // tileMode: TileMode.mirror,
        ),
        child: DecoratedBox(
          decoration: BoxDecoration(color: Colors.black.withOpacity(.65)),
          child: child,
        ),
      ),
    );
  }
}
```

### Skia

<img src="https://github.com/user-attachments/assets/4c08e92d-f0ba-42b2-a4c4-fc44efbcfae0" width="200"/>

### Impeller

<img src="https://github.com/user-attachments/assets/21e95efd-5e0c-4f41-8f84-af3f0e47d1aa" width="200"/>
 2024-10-25 16:27:51 +00:00
Reid Baker
23274284a7
Add 3.24.4 changelog to master (#157600) 
https://github.com/flutter/flutter/pull/157596/files
 2024-10-25 15:36:01 +00:00
Mohellebi abdessalem
7e2a06657c
Update flutter.groovy to catch unknown task exception when finding api task (#157282) 
see #147122 for context
and [this](https://github.com/flutter/flutter/pull/157221) for more
 2024-10-25 14:51:12 +00:00
engine-flutter-autoroll
fb8d938e6e
Roll Flutter Engine from c4b0184c8783 to b413d9996c86 (1 revision) (#157580) 
c4b0184c87...b413d9996c

2024-10-25 skia-flutter-autoroll@skia.org Roll Skia from 53c9663c3b83 to cc75472dedc2 (10 revisions) (flutter/engine#56121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 08:24:40 +00:00
engine-flutter-autoroll
3cd12f2c06
Roll Flutter Engine from b1c2ba8c4d52 to c4b0184c8783 (1 revision) (#157578) 
b1c2ba8c4d...c4b0184c87

2024-10-25 flar@google.com [DisplayList] Remove legacy size fields in DLOp records (flutter/engine#56101)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 07:27:26 +00:00
Valentin Vignal
086c07cc05
Add test for build_owner.0.dart (#157499) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/framework/build_owner.0.dart`
 2024-10-25 07:13:22 +00:00
Valentin Vignal
ffb1239801
Add tests for focusable_action_detector.0.dart (#157575) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/actions/focusable_action_detector.0.dart`
 2024-10-25 07:05:26 +00:00
Valentin Vignal
29eee6ac16
Add test for navigator.restorable_push_and_remove_until.0.dart (#157487) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/navigator/navigator.restorable_push_and_remove_until.0.dart`
 2024-10-25 06:39:33 +00:00
engine-flutter-autoroll
41b362b12c
Roll Flutter Engine from 29440ed1e225 to b1c2ba8c4d52 (1 revision) (#157572) 
29440ed1e2...b1c2ba8c4d

2024-10-25 chinmaygarde@google.com [Impeller] libImpeller: Respect the paragraph style line height specification. (flutter/engine#56066)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 02:59:25 +00:00
engine-flutter-autoroll
b97f3d2752
Roll Flutter Engine from 88716d804aef to 29440ed1e225 (1 revision) (#157569) 
88716d804a...29440ed1e2

2024-10-24 jason-simmons@users.noreply.github.com [web] Do not copy invalid images in the Skia test image collection (flutter/engine#56102)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 01:44:24 +00:00
engine-flutter-autoroll
287f6392e7
Roll Flutter Engine from b8b28c80a737 to 88716d804aef (2 revisions) (#157567) 
b8b28c80a7...88716d804a

2024-10-24 devoncarew@google.com [deps] update deps and pubspecs for the new locations of package:matcher, package:collection, and package:boolean_selector (flutter/engine#56107)
2024-10-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d218a25e8bf to 3067d697ae26 (3 revisions) (flutter/engine#56106)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-25 00:43:17 +00:00
engine-flutter-autoroll
2ae16a2373
Roll Flutter Engine from 48ff670d256b to b8b28c80a737 (2 revisions) (#157564) 
48ff670d25...b8b28c80a7

2024-10-24 jonahwilliams@google.com [android] make failing to acquire a java image non-fatal. (flutter/engine#56105)
2024-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from NxrFCTty8wV4-6Cpl... to Y4TdnTpLdkI107K42... (flutter/engine#56096)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from NxrFCTty8wV4 to Y4TdnTpLdkI1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-24 23:36:33 +00:00
Matan Lurey
f2e907acdd
Use discenrable characters (replace ' 🙙 🙛 ' in error logs) (#157548) 
Fixes an annoyance of mine where I stare at two boxes in the logs and have to guess if they are part of the real output:

<img width="795" alt="Screenshot 2024-10-24 at 12 47 58 PM" src="https://github.com/user-attachments/assets/a986f71c-5533-4899-aeb8-126dc82794fb">

Related to https://github.com/flutter/flutter/issues/157542#issuecomment-2436083676.
 2024-10-24 22:05:52 +00:00
Matan Lurey
a4167b7cf2
Remove unused PubDependenciesProjectValidator. (#157516) 
Closes https://github.com/flutter/flutter/issues/157479.

This came up while I was looking at parsing the results of `dart pub deps --json`, turns out it isn't used.
 2024-10-24 22:05:50 +00:00
auto-submit[bot]
b98d9a37ac
Reverts "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032)" (#157559) 
Reverts: flutter/flutter#157032
Initiated by: gmackall
Reason for reverting: https://github.com/flutter/flutter/pull/157032#issuecomment-2436336078
Original PR Author: gmackall

Reviewed By: {reidbaker, bartekpacia}

This change reverts the following previous change:
I recently noticed the following log when building an app in verbose mode:
```
This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 35.
```

It looks like AGP would like us to use a newer AGP version if we want to use compileSdk 35 (which we do). This pr upgrades the tests, in advance of updating the templates.
 2024-10-24 21:06:16 +00:00
Jonah Williams
b36a1316c3
Mark mac impeller as bringup. (#157551) 
These started flaking and I don't know why. Mark as bringup until we can
investigate.
 2024-10-24 13:18:18 -07:00
Taha Tesser
cdf4a2d109
Deprecate ThemeData.dialogBackgroundColor in favor of DialogThemeData.backgroundColor (#155072) 
Related to [☂️ Material Theme System Updates](https://github.com/flutter/flutter/issues/91772)
 2024-10-24 20:12:21 +00:00
Gray Mackall
5ca6350a06
Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032) 
I recently noticed the following log when building an app in verbose mode:
```
This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 35.
```

It looks like AGP would like us to use a newer AGP version if we want to use compileSdk 35 (which we do). This pr upgrades the tests, in advance of updating the templates.
 2024-10-24 20:08:45 +00:00
engine-flutter-autoroll
866f36293c
Roll Flutter Engine from 246344f26edc to 48ff670d256b (2 revisions) (#157544) 
246344f26e...48ff670d25

2024-10-24 magder@google.com Remove 'Linux mac_clangd' in favor of 'Mac clangd' (flutter/engine#56082)
2024-10-24 30870216+gaaclarke@users.noreply.github.com Added thread name to pipeline validation error. (flutter/engine#56074)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-24 20:03:22 +00:00
Matan Lurey
dc13c3bfb7
Allow opting out of .flutter-plugins, opt-out in refreshPluginsList. (#157527) 
Work towards https://github.com/flutter/flutter/issues/48918.

Workaround for https://github.com/flutter/flutter/issues/157391 (see https://github.com/flutter/flutter/pull/157393#issuecomment-2434336047).

I'll run all post-submit tasks as well on this PR using `test: all`.
 2024-10-24 20:01:45 +00:00
auto-submit[bot]
73f66a7ea4
Reverts "Reverts "Added a warning if flutter.groovy uses a .flutter-plugins file. (#157388)" (#157541)" (#157549) 
Reverts: flutter/flutter#157541
Initiated by: matanlurey
Reason for reverting: Was _not_ the cause of failure, see https://github.com/flutter/flutter/issues/157542.
Original PR Author: auto-submit[bot]

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Reverts: flutter/flutter#157388
Initiated by: matanlurey
Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree.
Original PR Author: matanlurey

Reviewed By: {reidbaker}

This change reverts the following previous change:
Work towards https://github.com/flutter/flutter/issues/48918.

This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).
 2024-10-24 19:52:25 +00:00
Mairramer
8cc862c727
Changes the offset computation to first item for RenderSliverMainAxisGroup (#154688) 
Fixes https://github.com/flutter/flutter/issues/154615
When scrolling back to the top, the position of the first visible item should have its scrollExtent subtracted. Otherwise, the accumulated position may be retained, which may result in the first visible item being hidden in some cases.
 2024-10-24 19:23:07 +00:00
engine-flutter-autoroll
19296abf85
Roll Packages from 5e03bb1da411 to a556f0f52825 (7 revisions) (#157539) 
5e03bb1da4...a556f0f528

2024-10-24 10687576+bparrishMines@users.noreply.github.com [camera] Manual roll and skip failing tests (flutter/packages#7891)
2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7898)
2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7906)
2024-10-23 48524817+wamynobe@users.noreply.github.com [pigeon] Allows swift generator to skip error class generation (flutter/packages#7849)
2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7903)
2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/file_selector/file_selector_android/android (flutter/packages#7900)
2024-10-23 43054281+camsim99@users.noreply.github.com [video_player_android] Give `can pause` integration test range to test for (flutter/packages#7913)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-24 18:55:08 +00:00
Loïc Sharma
bf319d6213
Add partial test for flutter build ios-framework on non-module (#157482) 
Add a partial test for running `flutter build ios-framework` on a regular app project (not a module).

Follow-up to this conversation: https://github.com/flutter/flutter/pull/157393/files#r1811810540

Part of https://github.com/flutter/flutter/issues/146957
 2024-10-24 18:53:09 +00:00
Loïc Sharma
fe95b2e225
Add example to SafeArea docs (#157228) 2024-10-24 18:53:07 +00:00
auto-submit[bot]
ef99fcbd60
Reverts "Added a warning if flutter.groovy uses a .flutter-plugins file. (#157388)" (#157541) 
Reverts: flutter/flutter#157388
Initiated by: matanlurey
Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree.
Original PR Author: matanlurey

Reviewed By: {reidbaker}

This change reverts the following previous change:
Work towards https://github.com/flutter/flutter/issues/48918.

This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).
 2024-10-24 18:20:47 +00:00
Matan Lurey
25b55b9f2d
Added a warning if flutter.groovy uses a .flutter-plugins file. (#157388) 
Work towards https://github.com/flutter/flutter/issues/48918.

This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).
 2024-10-24 16:25:09 +00:00
engine-flutter-autoroll
cc86b703ce
Roll Flutter Engine from be56084344d1 to 246344f26edc (2 revisions) (#157504) 
be56084344...246344f26e

2024-10-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 024c9570fae4 to 7d218a25e8bf (1 revision) (flutter/engine#56085)
2024-10-24 skia-flutter-autoroll@skia.org Roll Dart SDK from dd06a1e3002c to 024c9570fae4 (1 revision) (flutter/engine#56079)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-24 15:57:22 +00:00