Alexander Aprelev
3b8f6c4020
Upgrade framework pub dependencies, roll engine with rolled dart sdk ( #130163 )
...
Manual roll is needed because incoming dart sdk requires updated version
vm_snapshot_analysis (>=0.7.4).
5ae09b8b4f...7c83ea3e85#43457 )" (#43472 )
9ef3e8d533 Roll Skia from 5eba922297bb to 93c92f97f5ab (2 revisions) (#43471 )
```
Remove implementation of SuitePlatform from the test as well. Remove use
of fake cwd from SuitePlatform as it can't be properly faked.
2023-07-07 13:55:35 -07:00
Jesús S Guerrero
acb0855432
Revert "[a11y] CupertinoSwitch On/Off labels" ( #130166 )
...
Reverts flutter/flutter#127776
Currently breaking google testing
2023-07-07 20:04:00 +00:00
Polina Cherkasova
ce50828669
Test that inspector does not hold objects. ( #130102 )
2023-07-07 12:33:08 -07:00
Caique Ribeiro de Oliveira
3f2d798bd6
Fix XCode download link ( #129795 )
...
<img width="919" alt="image" src="https://github.com/flutter/flutter/assets/42003129/4bc8c3b8-29af-4b98-9232-47a583523e3c ">
I was installing Flutter and noticed that the download link for Xcode is incorrect. They might have changed it, but the current link doesn't exist.
2023-07-07 18:09:57 +00:00
engine-flutter-autoroll
f2e281fb31
Roll Packages from 9bcf4bfa493f to b61eea12dbf9 (1 revision) ( #130154 )
...
9bcf4bfa49...b61eea12dbaam@google.com Roll pigeon dependency to unblock flutter framework deps roll (flutter/packages#4383 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 17:30:27 +00:00
Chris Bobbe
8ab46bbce4
(Raw)Autocomplete: Add optional [optionsViewOpenDirection] param ( #129802 )
...
Allows positioning Autocomplete options above the field (previously hardcoded to under the field).
2023-07-07 10:25:35 -07:00
fzyzcjy
61ebf755d7
Tiny one space formatting fix ( #130053 )
...
You know, I like to see beautiful code, so really hope we have auto formatter, such that all these (at least such formatting error) can be done automatically!
2023-07-07 17:11:49 +00:00
engine-flutter-autoroll
9373289249
Roll Flutter Engine from 8aa2e6516af1 to 5ae09b8b4fa3 (7 revisions) ( #130150 )
...
8aa2e6516a...5ae09b8b4faam@google.com Revert "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) (#43457 )" (flutter/engine#43466 )
2023-07-07 skia-flutter-autoroll@skia.org Roll Skia from 7a3a89fadc25 to 5eba922297bb (1 revision) (flutter/engine#43464 )
2023-07-07 skia-flutter-autoroll@skia.org Roll Skia from adf5b9c27c33 to 7a3a89fadc25 (1 revision) (flutter/engine#43462 )
2023-07-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3D0ft09qP4-Hp_3mQ... to MPy31yjgPV-d_YJq0... (flutter/engine#43460 )
2023-07-07 skia-flutter-autoroll@skia.org Roll Skia from 57dc2a31bf26 to adf5b9c27c33 (2 revisions) (flutter/engine#43459 )
2023-07-07 skia-flutter-autoroll@skia.org Roll Skia from 11a2eefe4c61 to 57dc2a31bf26 (1 revision) (flutter/engine#43456 )
2023-07-07 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) (flutter/engine#43457 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 3D0ft09qP4-H to MPy31yjgPV-d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 16:55:54 +00:00
Victoria Ashworth
6683468f0b
Add debugging for iOS startup test flakes ( #130099 )
...
Adding debugging for https://github.com/flutter/flutter/issues/129836 .
Takes a screenshot when startup test takes too long (10 minutes).
Also, removes some old debugging and add new debugging message.
2023-07-07 16:49:00 +00:00
Hans Muller
d55a7d89e0
Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." ( #130144 )
...
Reverts flutter/flutter#114303
The breaking API change in flutter/flutter#114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: https://github.com/flutter/flutter/issues/130062 .
Fixes https://github.com/flutter/flutter/issues/130062
2023-07-07 16:39:08 +00:00
engine-flutter-autoroll
d5b8db303f
Roll Packages from 771ec9b42a38 to 9bcf4bfa493f (12 revisions) ( #130143 )
...
771ec9b42a...9bcf4bfa49stuartmorgan@google.com [ci] Add LUCI web platform tests (flutter/packages#4391 )
2023-07-07 stuartmorgan@google.com [webview_flutter] Enable unawaited_futures lint (flutter/packages#4271 )
2023-07-07 stuartmorgan@google.com [ci] Add partial LUCI version of repo_checks (flutter/packages#4389 )
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/packages#4302 )
2023-07-06 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations (flutter/packages#4354 )
2023-07-06 stuartmorgan@google.com [local_auth] Update Windows Pigeon version (flutter/packages#4388 )
2023-07-06 77553258+victorsanni@users.noreply.github.com [url_launcher] Remove nested third_party safari checker (flutter/packages#4330 )
2023-07-06 stuartmorgan@google.com [ci] Add partial LUCI Android platform tests (flutter/packages#4381 )
2023-07-06 stuartmorgan@google.com [ci] Switch `master` Linux custom package tests to LUCI (flutter/packages#4386 )
2023-07-06 47866232+chunhtai@users.noreply.github.com [go_router] Exposes package-level privates (flutter/packages#4380 )
2023-07-06 stuartmorgan@google.com [file_selector] Update to 1.0 (flutter/packages#4362 )
2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter from 35085c394dda to bc49cd1bcab5 (14 revisions) (flutter/packages#4387 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 15:53:56 +00:00
engine-flutter-autoroll
ce9a604a3b
Roll Flutter Engine from 650ff096488a to 8aa2e6516af1 (1 revision) ( #130116 )
...
650ff09648...8aa2e6516adnfield@google.com [Impeller] Duplicate include removal from lazy_glyph_atlas.cc. (flutter/engine#43453 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 05:18:04 +00:00
engine-flutter-autoroll
9c006666d1
Roll Flutter Engine from 1fa222fae283 to 650ff096488a (3 revisions) ( #130114 )
...
1fa222fae2...650ff09648skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MEXi9Xyj7u24PSx_J... to Cfxhimvf7nMO99ky_... (flutter/engine#43454 )
2023-07-07 zanderso@users.noreply.github.com Reduce redundant Linux clang-tidy work and run on more cores (flutter/engine#43448 )
2023-07-07 jason-simmons@users.noreply.github.com [Impeller] Set up the clear color for non-MSAA render targets. (flutter/engine#43452 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from MEXi9Xyj7u24 to Cfxhimvf7nMO
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 03:55:43 +00:00
engine-flutter-autoroll
03af0e535f
Roll Flutter Engine from 491f317978f4 to 1fa222fae283 (1 revision) ( #130110 )
...
491f317978...1fa222fae2skia-flutter-autoroll@skia.org Roll Skia from 072dfcc435de to 11a2eefe4c61 (5 revisions) (flutter/engine#43451 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 02:25:11 +00:00
engine-flutter-autoroll
f5d3cb6d4f
Roll Flutter Engine from 48bf7ac59254 to 491f317978f4 (2 revisions) ( #130107 )
...
48bf7ac592...491f317978chinmaygarde@google.com Account for updated Impeller label. (flutter/engine#43450 )
2023-07-06 bdero@google.com [Impeller] Fix DrawPicture. (flutter/engine#43446 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 00:39:00 +00:00
engine-flutter-autoroll
6baa72be68
Roll Flutter Engine from 42df55a9e63e to 48bf7ac59254 (1 revision) ( #130106 )
...
42df55a9e6...48bf7ac592john@johnmccutchan.com Eagerly remove the PlatformView from the view hierarchy on Android (flutter/engine#43423 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-06 23:54:37 +00:00
fzyzcjy
bf72b63536
Super tiny code optimization: No need to redundantly check whether value has changed ( #130050 )
...
Removed two unnecessary `if` conditions.
2023-07-06 16:30:01 -07:00
engine-flutter-autoroll
1fb3687bf8
Roll Flutter Engine from 06c936205d96 to 42df55a9e63e (3 revisions) ( #130100 )
...
06c936205d...42df55a9e6skia-flutter-autoroll@skia.org Roll Skia from 10a43e57e0a6 to 072dfcc435de (2 revisions) (flutter/engine#43445 )
2023-07-06 dkwingsmt@users.noreply.github.com Remove dead code for recreating a11y node delegates (flutter/engine#43359 )
2023-07-06 737941+loic-sharma@users.noreply.github.com [macOS] Fix assertion typo (flutter/engine#43179 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-06 22:39:09 +00:00
engine-flutter-autoroll
94f0459d8b
Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions) ( #130097 )
...
Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions)
Manual roll requested by zra@google.com
bd2e42b203...06c936205ddnfield@google.com Handle nested display list clips in Impeller dispatcher (flutter/engine#43442 )
2023-07-06 louiseh0313@gmail.com Add Look Up to iOS selection controls (flutter/engine#43308 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Skia from 6aaef9cbc3af to 10a43e57e0a6 (1 revision) (flutter/engine#43444 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Skia from 620de5ac9f6b to 6aaef9cbc3af (1 revision) (flutter/engine#43441 )
2023-07-06 ychris@google.com Revert "[iOS][Keyboard] Wait vsync on UI thread and update viewport inset to avoid jitter." (flutter/engine#43422 )
2023-07-06 skia-flutter-autoroll@skia.org Roll ICU from a2961dc659b4 to e8c3bc9ea97d (7 revisions) (flutter/engine#43440 )
2023-07-06 zanderso@users.noreply.github.com Further shard clang-tidy runs (flutter/engine#43428 )
2023-07-06 dnfield@google.com Release log capture at end of test (flutter/engine#43429 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uGhka7LBG80dM_I3a... to 3D0ft09qP4-Hp_3mQ... (flutter/engine#43439 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from amH2MWTworhTLdMWy... to MEXi9Xyj7u24PSx_J... (flutter/engine#43438 )
2023-07-06 109111084+yaakovschectman@users.noreply.github.com Use Windows Display Language (flutter/engine#43341 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Skia from b2ba6e1d8c0e to 620de5ac9f6b (2 revisions) (flutter/engine#43437 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Skia from 50e866b51a64 to b2ba6e1d8c0e (2 revisions) (flutter/engine#43436 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Skia from 8ed969b60e98 to 50e866b51a64 (1 revision) (flutter/engine#43435 )
2023-07-06 737941+loic-sharma@users.noreply.github.com Fix typo in painting.dart (flutter/engine#43378 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from C3Q7MJBYkiin8zw-f... to uGhka7LBG80dM_I3a... (flutter/engine#43433 )
2023-07-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iwgWLB4KaXslnaGwK... to amH2MWTworhTLdMWy... (flutter/engine#43432 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from a39421eb8d7b to 8ed969b60e98 (6 revisions) (flutter/engine#43431 )
2023-07-05 jonahwilliams@google.com [Impeller] Allocate fewer textures in dedicated memory and adjust buffer flags. (flutter/engine#43313 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from d6e941012b87 to a39421eb8d7b (4 revisions) (flutter/engine#43427 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from e0b9e047332d to d6e941012b87 (2 revisions) (flutter/engine#43424 )
2023-07-05 ychris@google.com [iOS] Avoid crash when backdrop filter is null for PlatformViews (flutter/engine#43150 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from 401c397f7235 to e0b9e047332d (1 revision) (flutter/engine#43420 )
2023-07-05 737941+loic-sharma@users.noreply.github.com [Windows] Fix `FlutterWindow::GetNativeViewAccessible` crash (flutter/engine#43368 )
2023-07-05 linxunfeng@yeah.net [iOS] Fix FlutterViewController retain cycle (flutter/engine#43379 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from 23052eb28808 to 401c397f7235 (1 revision) (flutter/engine#43419 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from d58324bf653d to 23052eb28808 (3 revisions) (flutter/engine#43418 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from iwgWLB4KaXsl to MEXi9Xyj7u24
fuchsia/sdk/core/mac-amd64 from C3Q7MJBYkiin to 3D0ft09qP4-H
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
...
2023-07-06 21:24:20 +00:00
Flutter GitHub Bot
c8265f81cf
Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky ( #128398 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux firebase_oriol33_abstract_method_smoke_test"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20firebase_oriol33_abstract_method_smoke_test%22 ).
This test can be marked as unflaky.
2023-07-06 19:42:24 +00:00
Polina Cherkasova
bff6b93683
Next attempt to make inspector weakly referencing the inspected objects. ( #129962 )
2023-07-06 12:19:18 -07:00
Gil Nobrega
4f6c887751
[a11y] CupertinoSwitch On/Off labels ( #127776 )
...
Adds optional visual labels to Cupertino's on/off switch for accessibility.
2023-07-06 11:18:13 -07:00
Henrique Nascimento
eebb1d6ddf
Add option for flexible space on material SearchDelegate ( #128132 )
...
This pull request introduces the `buildFlexibleSpace` method to the `SearchDelegate` class in the material library.
It allows users to add a flexible space widget to the `AppBar` in a `_SearchPage`, providing more customization options.
This PR does not fix any specific issue as there are no open issues related to this feature.
2023-07-06 17:52:58 +00:00
engine-flutter-autoroll
7e2f1f5bf6
Roll Packages from 704207985a21 to 771ec9b42a38 (12 revisions) ( #130077 )
...
704207985a...771ec9b42astuartmorgan@google.com [ci] Enable LUCI Dart unit tests (flutter/packages#4378 )
2023-07-06 stuartmorgan@google.com [ci] Bring up LUCI Linux custom package tests (flutter/packages#4382 )
2023-07-06 tarrinneal@gmail.com [pigeon] adds generate option for example pigeons (flutter/packages#4370 )
2023-07-06 47866232+chunhtai@users.noreply.github.com [go_router] Allows redirect only GoRoute to be part of RouteMatchList (flutter/packages#4315 )
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.5.0 to 20.6.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4359 )
2023-07-06 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix a crash when casting NSNull to an Array (flutter/packages#4289 )
2023-07-06 hello@kamil.id [google_sign_in_web] Fixes force unwrap on values that can be null (flutter/packages#4374 )
2023-07-05 engine-flutter-autoroll@skia.org Roll Flutter from 590ef2d402f6 to 35085c394dda (3 revisions) (flutter/packages#4379 )
2023-07-05 43054281+camsim99@users.noreply.github.com [camerax] Fixes `unawaited_futures` violations (flutter/packages#4337 )
2023-07-05 stuartmorgan@google.com [ci] Remove `starqlteue` from FTL tests (flutter/packages#4375 )
2023-07-05 stuartmorgan@google.com [tools] Switch to `flutter test` (flutter/packages#4348 )
2023-07-05 joshuapetitma@yahoo.com [flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet (flutter/packages#3880 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-06 15:53:39 +00:00
luckysmg
e0ad12969f
[framework] Add textField OCR support for framework side ( #96637 )
...
iOS OCR keyboard input support.
2023-07-06 08:51:06 -07:00
fabiancrx
2f7614a818
[flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder ( #128810 )
...
Replaces AnimatedBuilder for ListenableBuilder in the skeleton template
Fixes https://github.com/flutter/flutter/issues/128801
No tests needed
2023-07-06 15:14:51 +00:00
Ian Hickson
bc49cd1bca
Allow long-press gestures to continue even if buttons change. ( #127877 )
...
Previously, if you changed buttons during a long-press gesture, if it was before the gesture was accepted we would discard it, and if it was after the gesture was accepted we would silently end it without firing any of the relevant events.
This silent cancelation behavior is terrible because it means there's no way for consumers to know what state they're in, so you end up with widgets that thing they're still being long-pressed even though nothing is happening.
We could change the behavior in three ways, as far as I can tell:
- we could send a cancel event when you change buttons. This would introduce a new kind of transition (start->cancel) which I don't think we currently require people to support. This would therefore not fix existing code and would make future code more complicated to handle a really obscure user action that it seems unlikely anyone cares about.
- we could send an end event when you change buttons. This would mean the action commits, even though the user is still holding the mouse button down. This seems slightly better than the previous option but still not ideal as it means nudging the mouse button commits you even though you're still holding the button down.
- we could ignore button changes after the long-press has been accepted.
I implemented the last one in this PR.
2023-07-06 00:42:57 +00:00
Michael Goderbauer
55b6f049a6
Enable unreachable_from_main lint - it is stable now!!1 ( #129854 )
...
PLUS: clean-up of all the unreachable stuff.
2023-07-06 00:09:01 +00:00
Ian Hickson
99cb18b1a8
Update labeler to new label names ( #130040 )
...
q.v. https://flutter.dev/go/triage-2023-rfc
2023-07-06 00:00:47 +00:00
Snonky
e0a9ad15b9
MergeableMaterial: Fix adding a slice and separating it ( #128804 )
2023-07-05 16:58:28 -07:00
Ian Hickson
76bdf463e5
Update infrastructure issue template for new priority scheme ( #129741 )
2023-07-05 23:33:58 +00:00
Loïc Sharma
997ef1b402
Fix typo in canvas example ( #129879 )
2023-07-05 23:20:54 +00:00
Hans Muller
14f1e13edb
Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 ( #129860 )
...
Reland https://github.com/flutter/flutter/pull/129556/ which had failed
an internal test (see Google internal link b/288993600) and was reverted
in https://github.com/flutter/flutter/pull/129645 .
This PR must be landed with G3 Fix cl/543755631
2023-07-05 15:41:13 -07:00
Ian Hickson
f37a4d05a4
Change from "created via performance template" to "from: performance template" ( #130035 )
...
This more closely matches our other conventions.
2023-07-05 22:34:49 +00:00
pdblasi-google
e1702a96f6
Removes deprecated APIs from v2.6 in binding.dart and widget_tester.dart ( #129663 )
...
Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart`
Resolves #129654
2023-07-05 19:26:24 +00:00
Helin Shiah
0b44577f16
Add new hot reload case string ( #130008 )
...
This change is for an internal IDE client to send a custom hot reload
request, as custom requests from the client must start with `$/`.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above. (this PR is linked internally)
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-07-05 15:16:33 -04:00
engine-flutter-autoroll
553593741a
Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions) ( #130023 )
...
Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions)
Manual roll requested by zra@google.com
987b621eac...bd2e42b203zanderso@users.noreply.github.com Reverts Dart SDK to version 3.1.0-262.0.dev (flutter/engine#43417 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8YulTHvG-Jg3Sof-S... to C3Q7MJBYkiin8zw-f... (flutter/engine#43415 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Dart SDK from f7c242ded366 to e193587883d6 (1 revision) (flutter/engine#43414 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from a453fed07c91 to d58324bf653d (1 revision) (flutter/engine#43413 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from faf906db84ab to a453fed07c91 (4 revisions) (flutter/engine#43412 )
2023-07-05 skia-flutter-autoroll@skia.org Roll Dart SDK from c89f5ac4fd46 to f7c242ded366 (1 revision) (flutter/engine#43410 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8-taK-r4HkgVAIGtU... to 8YulTHvG-Jg3Sof-S... (flutter/engine#43409 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 7cd6ed860b63 to c89f5ac4fd46 (1 revision) (flutter/engine#43408 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Dart SDK from d128bd4977a7 to 7cd6ed860b63 (1 revision) (flutter/engine#43406 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Skia from eaca275ef1c0 to faf906db84ab (1 revision) (flutter/engine#43405 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Dart SDK from e58e3bd3b507 to d128bd4977a7 (1 revision) (flutter/engine#43403 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from GNWxBcnfjZlyaOw34... to 8-taK-r4HkgVAIGtU... (flutter/engine#43402 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Skia from bb18c9b1f730 to eaca275ef1c0 (1 revision) (flutter/engine#43401 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 604ccea2f5b9 to e58e3bd3b507 (1 revision) (flutter/engine#43400 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Skia from 85a3fda32850 to bb18c9b1f730 (3 revisions) (flutter/engine#43399 )
2023-07-04 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/engine#43398 )
2023-07-04 skia-flutter-autoroll@skia.org Roll Skia from 4abc43e2ffcc to 85a3fda32850 (1 revision) (flutter/engine#43393 )
2023-07-04 chinmaygarde@google.com [Impeller] Document `impeller::Context`. (flutter/engine#43389 )
2023-07-03 skia-flutter-autoroll@skia.org Roll Dart SDK from a4c5ed075a2b to 604ccea2f5b9 (1 revision) (flutter/engine#43390 )
2023-07-03 skia-flutter-autoroll@skia.org Roll Dart SDK from c092e09b7e64 to a4c5ed075a2b (1 revision) (flutter/engine#43387 )
2023-07-03 skia-flutter-autoroll@skia.org Roll Skia from 6a5ea15c942b to 4abc43e2ffcc (1 revision) (flutter/engine#43386 )
2023-07-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from cytps4RRhs8-wbcVJ... to GNWxBcnfjZlyaOw34... (flutter/engine#43373 )
2023-07-03 skia-flutter-autoroll@skia.org Roll Dart SDK from dedff8f0ebd2 to c092e09b7e64 (1 revision) (flutter/engine#43374 )
2023-07-03 skia-flutter-autoroll@skia.org Roll Skia from 94ad507b8959 to 6a5ea15c942b (1 revision) (flutter/engine#43385 )
2023-07-03 skia-flutter-autoroll@skia.org Roll Skia from e16d5b988a36 to 94ad507b8959 (2 revisions) (flutter/engine#43383 )
2023-07-03 skia-flutter-autoroll@skia.org Roll Skia from 384b84445a9f to e16d5b988a36 (1 revision) (flutter/engine#43382 )
2023-07-02 skia-flutter-autoroll@skia.org Roll Skia from dbf0829114ee to 384b84445a9f (2 revisions) (flutter/engine#43381 )
2023-07-01 bdero@google.com [Impeller] Remove blend mode restrictions on clear color optimization (flutter/engine#43348 )
2023-07-01 skia-flutter-autoroll@skia.org Roll Dart SDK from f00f7363f4bf to dedff8f0ebd2 (4 revisions) (flutter/engine#43371 )
2023-07-01 skia-flutter-autoroll@skia.org Roll Skia from ceaeef84b8a3 to dbf0829114ee (15 revisions) (flutter/engine#43370 )
2023-07-01 bdero@google.com [Impeller] Add explicit color filter types to Aiks. (flutter/engine#43342 )
2023-07-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 2d98d9e27dae to f00f7363f4bf (1 revision) (flutter/engine#43354 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from cytps4RRhs8- to C3Q7MJBYkiin
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
...
2023-07-05 17:25:49 +00:00
Myles Moylan
ec72610378
Add simple unit tests for annotations.dart file ( #128902 )
...
This PR is adding a file of two simple unit tests in order to improve code coverage (covering two simple classes within the annotations.dart file).
The issue this is fixing is the lack of complete test coverage for the annotations.dart file.
2023-07-05 17:21:28 +00:00
ipcjs
aaaea51dd2
fix a bug when android uses CupertinoPageTransitionsBuilder... ( #114303 )
...
When android uses iOS style `PageTransitionsBuilder` and iOS uses android style `PageTransitionsBuilder`, on android, swipe from the left edge of the screen doesn't work. This PR solves that problem.
#99919 introduced a breaking change, the pr re-implemented it <del>without introducing a breaking change.**</del>
2023-07-05 16:41:32 +00:00
Piotr FLEURY
168d807734
Add .env file support for option --dart-define-from-file ( #128668 )
...
# Proposal
I suggest to make possible to specify .env files to the --dart-define-from-file in addition to the Json format.
# Issue
Close #128667
2023-07-05 16:35:08 +00:00
Pierre-Louis
35085c394d
Improve documentation for ColorSheme.fromImageProvider ( #129952 )
...
Sample code is added, documentation condensed, and links to guidelines updated.
For b/258360306
2023-07-05 15:47:57 +00:00
engine-flutter-autoroll
a2dbd1ec4d
Roll Packages from a03b900efc0e to 704207985a21 (2 revisions) ( #130013 )
...
a03b900efc...704207985astuartmorgan@google.com [ci] Add a web version of Dart unit tests (flutter/packages#4352 )
2023-07-04 engine-flutter-autoroll@skia.org Roll Flutter from aa5f4a28e9a8 to 590ef2d402f6 (5 revisions) (flutter/packages#4373 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 15:42:23 +00:00
Polina Cherkasova
5b12b7467f
Cleanup: stop accepting DiagnosticsNode as input from DevTools. ( #129302 )
2023-07-04 10:12:49 -07:00
engine-flutter-autoroll
590ef2d402
Roll Packages from cdae854a59b9 to a03b900efc0e (1 revision) ( #129957 )
...
cdae854a59...a03b900efc10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes inspectable compile-time error and crash from equal `NSURL`s (flutter/packages#4340 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 15:43:20 +00:00
engine-flutter-autoroll
ddb16b7d92
Roll Packages from 53ed5a0aa9e4 to cdae854a59b9 (9 revisions) ( #129918 )
...
53ed5a0aa9...cdae854a59engine-flutter-autoroll@skia.org Roll Flutter from ff838bca8990 to aa5f4a28e9a8 (29 revisions) (flutter/packages#4363 )
2023-07-01 stuartmorgan@google.com [tool] Add a flag to skip cleanup (flutter/packages#4357 )
2023-07-01 stuartmorgan@google.com [file_selector] Endorse Android (flutter/packages#4329 )
2023-07-01 stuartmorgan@google.com [google_sign_in] Convert Android to Pigeon (flutter/packages#4344 )
2023-06-30 tarrinneal@gmail.com [Pigeon] readme updates (flutter/packages#3705 )
2023-06-30 43054281+camsim99@users.noreply.github.com [camera_android] Support concurrently image capture and image streaming (flutter/packages#4332 )
2023-06-30 kustermann.martin@gmail.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/packages#4342 )
2023-06-30 tarrinneal@gmail.com [shared_preferences] Adds allowList to setPrefix method. (flutter/packages#3794 )
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter from 51bef1b63271 to ff838bca8990 (12 revisions) (flutter/packages#4346 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 18:27:33 +00:00
engine-flutter-autoroll
1b51de9e11
Roll Flutter Engine from e6b8292705a8 to 987b621eac4e (1 revision) ( #129863 )
...
e6b8292705...987b621eacskia-flutter-autoroll@skia.org Roll Skia from 2d05e3ec6b67 to ceaeef84b8a3 (1 revision) (flutter/engine#43355 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 15:12:52 +00:00
Robert Ancell
9760bb0cf0
Add an example showing how to use textures ( #122779 )
...
There didn't seem to be any examples on how to do this.
I've only shown the Linux implementation, others may want to follow this
PR up with support for other platforms.
2023-07-03 13:54:18 +12:00
Parker Lougheed
63a8298d4b
Update links to old linter site to dart.dev ( #129866 )
...
Removes the remaining links to the old linter site, to the guaranteed dart.dev/lints redirect.
Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
2023-07-01 18:36:10 +00:00
Michael Goderbauer
aa5f4a28e9
Enable no_wildcard_variable_uses lint ( #129858 )
...
Wildcard parameters and local variables (e.g. underscore-only names like _, __, ___, etc.) will become non-binding in a future version of the Dart language. Any existing code that uses wildcard parameters or variables will break. In anticipation of this change, and to make adoption easier, this lint disallows wildcard and variable parameter uses.
We had no violations of this in the framework. Let's keep it that way!
2023-07-01 01:16:21 +00:00
Christopher Fujino
97fce9aa19
mark packages-autoroller bringup again ( #129859 )
...
Even after updating the account (and the cloudKMS GitHub token), when
the bot tries to push to
https://github.com/flutter-pub-roller-bot/flutter , it gets a 403, which
probably means authentication failed. I will have to investigate next
week.
```
Exception: GitException: Exception on command "push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1": Command "git push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1" failed in directory "/b/s/w/ir/x/w/flutter_conductor_checkouts/framework" to update the release branch with the commit. Git exited with error code 128.
stderr from git:
16:33:21.199510 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/bin/git
16:33:21.199587 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/bin
16:33:21.200155 git.c:460 trace: built-in: git push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1
16:33:21.200542 run-command.c:655 trace: run_command: GIT_DIR=.git git remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.201787 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/libexec/git-core/git
16:33:21.201845 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/libexec/git-core
16:33:21.202175 git.c:750 trace: exec: git-remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.202195 run-command.c:655 trace: run_command: git-remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.203510 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/libexec/git-core/git-remote-http
16:33:21.203567 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/libexec/git-core
remote: Permission to flutter-pub-roller-bot/flutter.git denied to flutter-pub-roller-bot.
fatal: unable to access 'https://github.com/flutter-pub-roller-bot/flutter.git/ ': The requested URL returned error: 403
```
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20packages_autoroller/6031/overview
This is still being tracked in
https://github.com/flutter/flutter/issues/129744
2023-06-30 16:54:55 -07:00
