12086 Commits

Author SHA1 Message Date
Danny Tuppeny
3ea4b44374
Increase timeout waiting for app to start (#22504)
https://github.com/flutter/flutter/issues/22338#issuecomment-425794734 shows almost 1 minute being spent on the `Resolving Dependencies` step alone. Possibly this needs to go higher still, but this should be a good start.
2018-10-05 17:02:08 +01:00
tonyzhao1
b04447d51c Split Android license checks into their own subvalidator (#22446) 2018-10-05 08:45:16 -07:00
Alexandre Ardhuin
2d3ff10d62
apply lint prefer_void_to_null in packages/flutter_tools (#22686) 2018-10-05 07:54:56 +02:00
Alexandre Ardhuin
c26b56cba3
apply lint prefer_void_to_null in packages/fuchsia_remote_debug_protocol (#22690) 2018-10-05 06:48:20 +02:00
engine-flutter-autoroll
3b8c534576
Roll engine cf0855e69fa8..90b1023c84c4 (2 commits) (#22708)
cf0855e69f...90b1023c84

git log cf0855e69fa8..90b1023c84c4 --no-merges --oneline
90b1023c8 Remove unused imports and variables (flutter/engine#6437)
1f98aa6df Add the isolate name server to the set of native APIs available on secondary isolates (flutter/engine#6444)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-04 23:01:02 -04:00
engine-flutter-autoroll
30222b7bee
Roll engine 45c5fe5613cb..cf0855e69fa8 (2 commits) (#22704)
45c5fe5613...cf0855e69f

git log 45c5fe5613cb..cf0855e69fa8 --no-merges --oneline
cf0855e69 Roll Dart to version  c6254163dc7a5f704d7609af65e4650ef0550ccd (flutter/engine#6439)
2fa1ab9de Roll src/third_party/skia d95303e10cbc..4302eb9a6e14 (12 commits) (flutter/engine#6443)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-04 22:17:01 -04:00
Greg Spencer
407ce13792
Temporarily disabling Docs deployment again. (#22705)
This reverts commit fef759f410ea00fee91aecf44e789ce4ba2c0dcc, because apparently
the service is still "unavailable".
2018-10-04 18:00:23 -07:00
engine-flutter-autoroll
5ae23849cf
Roll engine c8755d74c17e..45c5fe5613cb (2 commits) (#22700)
c8755d74c1...45c5fe5613

git log c8755d74c17e..45c5fe5613cb --no-merges --oneline
45c5fe561 Remove touch mapper and respect the UITouch phase when calculating the pointer data change type. (flutter/engine#6430)
234736801 Roll src/third_party/skia 66a973493468..d95303e10cbc (13 commits) (flutter/engine#6440)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-04 20:41:01 -04:00
Greg Spencer
fef759f410
Revert "Temporarily disabling Docs deployment (#22588)" (#22683)
This reverts commit 9eca083006c8fae5937754b9f5275eaef3fbad19 to turn on
docs generation again, since now we have paid...
2018-10-04 17:39:04 -07:00
Greg Spencer
3dbcfc73b9
Add correct environment to allow deploy of gallery app. (#21713)
The Gallery deployment was missing some secrets in order to correctly deploy. This adds those missing secrets as encrypted env vars.
2018-10-04 15:59:25 -07:00
Greg Spencer
40a7a9cfc3
Fixes a common crash in getAdbDevices when adb executable isn't found. (#22676)
Apparently, this accounts for 13% of our crashes in Beta.
2018-10-04 15:57:15 -07:00
Jonah Williams
cfc73590b7
Adds more time to contrast tests (#22681) 2018-10-04 15:56:52 -07:00
Greg Spencer
abb1758edf
Fix places in devicelab tests where it expects the app template. (#22696)
I missed some create template conversions in the devicelab directory.
2018-10-04 15:30:08 -07:00
Greg Spencer
3246a66374
Make devicelab tests use 'app' template (#22694)
Fixes the build after my module rename broke the Windows tests.
2018-10-04 14:30:59 -07:00
Greg Spencer
9f23866a0a
Rename module --> application in flutter create command. (#22565)
This renames the "module" template to the "application" template, and makes "application" the default. The existing "app" template is now deprecated.

flutter create also now recognizes the type of project in an existing directory, and is able to recreate it without having the template type explicitly specified (although you can still do that). It does this now by first looking in the .metadata file for the new project_type field, and if it doesn't find that, then it looks at the directory structure. Also, the .metadata file is now overwritten even on an existing directory so that 1) the project_type can be added to legacy projects, and 2) the version of Flutter that updated the project last is updated.

I also cleaned up a bunch of things in create_test.dart, added many more tests, and added an example test to the test/ directory in the generated output of the application template.

Fixes #22530
Fixes #22344
2018-10-04 13:03:20 -07:00
engine-flutter-autoroll
66f1c6757b
Roll engine 74e68ff8b108..c8755d74c17e (1 commits) (#22684)
74e68ff8b1...c8755d74c1

git log 74e68ff8b108..c8755d74c17e --no-merges --oneline
c8755d74c Update FlutterFrontendCompiler.rejectLastDelta to match the signature in CompilerInterface (flutter/engine#6426)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-04 15:32:02 -04:00
Gary Qian
00bcffd108
Roll engine and update tests (#22643)
git log 7e3b41dc7ba6..74e68ff8b108 --no-merges --oneline
74e68ff8b Roll src/third_party/skia 7b7805581733..66a973493468 (4 commits) (#6436)
58fbd1fd1 Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (#6435)
83151d9fc Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (#6434)
5fe7e377d Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (#6432)
5340f4224 Revert "Use single_root_scheme when compiling platform (#6402)" (#6431)
37fd43d43 Add deadline_now_delta argument to Engine::NotifyIdle's trace (#6419)
4af077b29 Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (#6429)
165f3dd1c Update //third_party/benchmark dependency to 21f1eb (ToT). (#6427)
34bd0ef87 Don’t build benchmarking binaries on Windows. (#6428)
ae4db4469 Ensure setViewIdResourceName has the correct version guard (#6404)
2c5d0c407 [rapidjson] Fix import statements (#6418)
c2128fc80 Create a benchmarking target for the shell. (#6420)
30f78af91 Raise errors on non-zero exits while creating artifacts on the bots. (#6424)
191168cec Disable line_height tests on Windows (#6423)
061cc6643 Fix ideographic baseline to match spec. (#6422)
74eac1f56 Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (#6421)
10b45405b Implement ParagraphStyle.line_height and add tests for line_height and baselines. (#6417)
2018-10-04 10:57:30 -07:00
jslavitz
64029ba6ea
Vertical divider (#22641)
* Vertical divider bug fix and additional cleaning.
2018-10-04 10:29:32 -07:00
Philip
4a13be4151 Added sample code for scaffold widget [#21136] (#21613)
* added sample code for scaffold widget [#21136]

* Fixed indent and spacing for scaffold sample code

* Update scaffold.dart

Fix one more formatting issue
2018-10-04 10:21:05 -07:00
Jason Simmons
e031613a2a
Use "gradle tasks --all" to query build variants (#21761)
Previously flutter_tools had used "gradle properties" to find the build types
and flavors supported by the Gradle project.  Tasks should work more reliably
across different versions of the Android Gradle plugin.

Fixes https://github.com/flutter/flutter/issues/20781
2018-10-04 10:06:31 -07:00
Alexandre Ardhuin
d340e2f229
apply lint prefer_void_to_null in dev/ (#22661) 2018-10-04 18:44:23 +02:00
Ahmed Abu Eldahab
89c5ace117 Adding Changelog URL to the README.md file (#20915)
* Adding Changelog URL to the README.md file

* Update README to match the latest version on DEV

- Update README to match the latest version on DEV branch 
- Add Changelog URL

* Update README.md

Fix contributing link
2018-10-04 09:26:06 -07:00
Alexandre Ardhuin
2ea1d81cdc
sort_constructors_first (#22575) 2018-10-04 07:28:07 +02:00
Dan Field
a68b03e9ce
Revert "Roll engine 74662ab69523..7e3b41dc7ba6 (6 commits) (#22639)" (#22647)
This reverts commit ec0df1110c22de2583eb214127eeb5d1498c03bf.
2018-10-03 17:37:00 -07:00
engine-flutter-autoroll
ec0df1110c Roll engine 74662ab69523..7e3b41dc7ba6 (6 commits) (#22639)
74662ab695...7e3b41dc7b

git log 74662ab69523..7e3b41dc7ba6 --no-merges --oneline
7e3b41dc7 Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416)
69ae5694d Do not register UI-related native functions in secondary isolates (flutter/engine#6401)
19c135c67 Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415)
65b886ba9 Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414)
360d44668 Use single_root_scheme when compiling platform (flutter/engine#6402)
c7a5abf98 Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-03 17:25:39 -07:00
Jonah Williams
3e0cefb80e
Fix build by removing new (#22634) 2018-10-03 14:34:50 -07:00
Philip
d0c9560856 Make RotationTransition widget alignment configurable (#22535) 2018-10-03 14:20:05 -07:00
Michael Goderbauer
07fc9f6442
Fix mkdir call to not fail if dir exists (#22622) 2018-10-03 14:12:54 -07:00
Danny Tuppeny
d43155695d
Revert "Use (processors-1) for test runs (test defaults to processors/2)" (#22628)
* Revert "Custom offset functionality for Popup Menu Button (#22534)"

This reverts commit f44b277fa632c848ea113ee3f397f713bc429153.

* Revert "Updated the ColorScheme dartdoc: a11y (#22618)"

This reverts commit aa6a27e8a25ba4d6d68539a0ae9285385a29ae9e.

* Revert "Added support for the Khmer (km) language (#22617)"

This reverts commit 3a87b93fcee696480504f0659062f0d7206c44a3.

* Revert "Use 'Future<void>' insted of 'Future<Null>' in SystemChrome (#22583)"

This reverts commit 37c10acb978009b1ee690478a31b30eb7371eb25.

* Revert "Choice Chip Fix (#22589)"

This reverts commit 8d76d37f33b474c77c35c91bfeaeedd86d8a6fb5.

* Revert "Throw if trying to set fs.currentDirectory in tests (#22037)"

This reverts commit 2f6155bf188911bc0630b1b2e6786e968a570fe7.

* Revert "Use (processors-1) for test runs (test defaults to processors/2) (#22085)"

This reverts commit d44f003079b53643d6f0afd9a5f57383c3de62cb.
2018-10-03 21:35:36 +01:00
Danny Tuppeny
55d70506ed
Mark module_test_ios as not-flaky (#22626)
The only reds on the dashboard for this test are on rows that have many failures across the run; this does not appear to be at all flaky.
2018-10-03 21:03:25 +01:00
jslavitz
f44b277fa6
Custom offset functionality for Popup Menu Button (#22534)
* Adds offset functionality to popup menu
* Adds a test
2018-10-03 11:19:19 -07:00
Hans Muller
aa6a27e8a2
Updated the ColorScheme dartdoc: a11y (#22618) 2018-10-03 11:15:28 -07:00
Hans Muller
3a87b93fce
Added support for the Khmer (km) language (#22617) 2018-10-03 11:14:56 -07:00
Gary Qian
37c10acb97
Use 'Future<void>' insted of 'Future<Null>' in SystemChrome (#22583) 2018-10-03 11:14:09 -07:00
jslavitz
8d76d37f33
Choice Chip Fix (#22589)
* choice chip fix

* added test
2018-10-03 11:08:01 -07:00
Danny Tuppeny
2f6155bf18
Throw if trying to set fs.currentDirectory in tests (#22037)
* Block setting of fs.currentDirectory in tests

This isn't perfect, it only covers tests using testUsingContext, but that is the huge majority of tests.

* Tweak error message.
2018-10-03 19:07:04 +01:00
Danny Tuppeny
d44f003079
Use (processors-1) for test runs (test defaults to processors/2) (#22085)
* Use (processors-1) for test runs (test defaults to processors/2)

* Add missing import 🙄
2018-10-03 19:06:48 +01:00
Rui Kowase
b9f6e2c315 Remove new keyword from sample code (#22465) 2018-10-03 18:11:29 +02:00
engine-flutter-autoroll
b08f36e3cc Roll engine f6af1f20ba92..74662ab69523 (13 commits) (#22599)
f6af1f20ba...74662ab695

git log f6af1f20ba92..74662ab69523 --no-merges --oneline
74662ab69 Revert &#34;Share engine layers with the framework&#34; (flutter/engine#6412)
2de87a80f Roll src/third_party/skia 6719fcc43b1e..deb512045e6a (7 commits) (flutter/engine#6411)
68a42e3f4 Add nullability annotations to MethodChannel/MethodCall. (flutter/engine#6393)
71ba20a64 Dart SDK roll for 2018-10-02 to d2c5a24fd9ead97a7f18d02786e679293cc3709e (flutter/engine#6410)
9ccc96625 Share engine layers with the framework (flutter/engine#6406)
fa719e3e7 Roll src/third_party/skia cc4dbfcfbd8a..6719fcc43b1e (17 commits) (flutter/engine#6409)
dc2634dcf Force lf-line endings for so that source offsets match across platforms. (flutter/engine#6408)
44a514943 Roll src/third_party/skia 7dae882574d2..cc4dbfcfbd8a (15 commits) (flutter/engine#6405)
de32c659b Roll src/third_party/skia 3b8b11e1f912..7dae882574d2 (15 commits) (flutter/engine#6403)
3a9c22afd Allow GetRectsForRange to provide more detailed/nuanced metrics through RectStyle enum. (flutter/engine#6335)
b59c86493 Rename the Android fragment support library JAR (flutter/engine#6400)
4213ac19c Add an Android fragment support library to third_party (flutter/engine#6384)
a785b25f4 do not count Hidden nodes at the beginning of the scrollable (flutter/engine#6381)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-02 23:27:58 -07:00
xster
188c25fbd3
Clarify that only one nav bar should be in each route (#22584) 2018-10-02 20:09:23 -07:00
xster
dd3af0e287
Cupertino picker fidelity fixes (#22537) 2018-10-02 18:35:02 -07:00
xster
08fe1d86e9
Update android fastlane bundle packages (#22532) 2018-10-02 18:34:40 -07:00
xster
9b893b1430
Set the upload key in cirrus when publishing (#22581) 2018-10-02 18:34:20 -07:00
Michael Goderbauer
bfa9822134
Hide App.framework.dSYM from Spotlight (#22540) 2018-10-02 18:28:22 -07:00
Hans Muller
99a2293893
Added ColorScheme dartdoc (#22592) 2018-10-02 17:35:36 -07:00
Greg Spencer
9eca083006
Temporarily disabling Docs deplyment (#22588)
Merging on read to unbreak the build.

TBR= @Hixie
2018-10-02 16:15:04 -07:00
Hans Muller
eea3465ae7
Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)
Introduce an overall material "color scheme" and to make it possible to redefine how a component's visual properties bind to the color scheme and to the existing material Theme.
2018-10-02 14:50:43 -07:00
Gary Qian
46bc911b72
Add 'restoreSystemUIOverlays' to SystemChrome to allow simple UI restore after System force changes. (#22221)
* Add 'restoreSystemUIOverlays' to SystemChrome to allow simple UI restore after System force changes.
2018-10-02 14:44:39 -07:00
mockturtl
13684e4f8e use RadioListTile in expansion panels demo (#20240)
* use RadioListTile in expansion panels demo

Fixes #6048.
- expose `_Location`
- appease analyzer
2018-10-02 11:15:17 -07:00
Danny Tuppeny
d89604d85c
Change file paths to URIs to fix "Could not run configuration in engine" on Windows (#22507)
* Change file paths to URIs to fix "Could not run configuration in engine" on Windows

Plus unskip test that was failing due to this.

Fixes #21348.

* Remove unused import
2018-10-02 18:31:55 +01:00