42082 Commits

Author SHA1 Message Date
engine-flutter-autoroll
405a45c69e
Roll Flutter Engine from c5d23162bb9b to 30ffbfaf6a06 (1 revision) (#153721)
c5d23162bb...30ffbfaf6a

2024-08-19 jonahwilliams@google.com [Impeller] finish experimental canvas changes. (flutter/engine#54569)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 21:30:07 +00:00
engine-flutter-autoroll
83b8b1570c
Roll Flutter Engine from bf538a0a98b0 to c5d23162bb9b (1 revision) (#153719)
bf538a0a98...c5d23162bb

2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from d88bfe2939e8 to d528658273db (9 revisions) (flutter/engine#54619)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 20:14:40 +00:00
Zachary Anderson
88123277fc
Remove android stack_size_test (#153695)
This test expects to run on 32-bit hardware, but the devicelab no longer
has 32-bit Android hardware. In particular, the test contains hand-coded
32-bit arm assembly for reading the stack pointer from Dart code via
`dart:ffi`.

This test was added in response to a framework change that caused stack
frames to be larger than expected while building widgets, leading apps
to crash with StackOverflow exceptions unexpectedly. Since then (>3
years ago) this test has not prevented any similar issue, so I believe
deleting it rather than fixing it is a better use of resources.
2024-08-19 12:25:35 -07:00
engine-flutter-autoroll
3a6053208b
Roll Flutter Engine from e29b5529080d to bf538a0a98b0 (2 revisions) (#153713)
e29b552908...bf538a0a98

2024-08-19 reidbaker@google.com Set download_jdk variable (flutter/engine#54584)
2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from e49cd5f3cffb to d88bfe2939e8 (1 revision) (flutter/engine#54613)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 18:11:16 +00:00
Kate Lovett
6a28048935
Update goldctl git revision (#153710)
This updates the version of goldctl we checkout for testing.
The recent update makes goldctl more resilient to I/O timeouts.
2024-08-19 18:09:25 +00:00
Jason Simmons
31c3d0927b
Do not cancel the VmService's subscription to the isolate event stream in FlutterVmService.findExtensionIsolate (#153607)
The stream subscriptions in the device's VmService are used by other parts of FlutterVmService and other components throughout flutter_tools.  Components that listen to streams should not call VmService.streamCancel because that will interfere with other users who still want the events.

See https://github.com/flutter/flutter/issues/153049
See https://github.com/flutter/flutter/issues/153563
2024-08-19 17:40:07 +00:00
engine-flutter-autoroll
bf5bcff0c2
Roll Packages from 2c37fb052cd4 to 7c1a05c8b122 (3 revisions) (#153698)
2c37fb052c...7c1a05c8b1

2024-08-16 14177215+unliar@users.noreply.github.com [go_router] docs: replace out dated initialRoute to initialLocation (flutter/packages#7147)
2024-08-16 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Updates readme to clarify currently supported features (flutter/packages#7398)
2024-08-16 engine-flutter-autoroll@skia.org Roll Flutter from bced008679af to a0c04534f5ea (5 revisions) (flutter/packages#7429)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 15:48:35 +00:00
engine-flutter-autoroll
0efb746c34
Roll Flutter Engine from 52621de86f54 to e29b5529080d (1 revision) (#153699)
52621de86f...e29b552908

2024-08-19 kjlubick@users.noreply.github.com Update gni filegroup when building Skia's codec files (flutter/engine#54588)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 15:45:17 +00:00
engine-flutter-autoroll
4c0d77c4b9
Roll Flutter Engine from 356d51d46736 to 52621de86f54 (1 revision) (#153693)
356d51d467...52621de86f

2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from 3896447e3531 to e49cd5f3cffb (1 revision) (flutter/engine#54612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 14:10:38 +00:00
engine-flutter-autoroll
5c5ae033e1
Roll Flutter Engine from ef8252cbbd6a to 356d51d46736 (1 revision) (#153685)
ef8252cbbd...356d51d467

2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from 5274def7cf1f to 3896447e3531 (1 revision) (flutter/engine#54611)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 10:47:25 +00:00
engine-flutter-autoroll
61a4e0288a
Roll Flutter Engine from cf12bb6465e8 to ef8252cbbd6a (1 revision) (#153681)
cf12bb6465...ef8252cbbd

2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from 75bd296f9756 to 5274def7cf1f (2 revisions) (flutter/engine#54610)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 09:11:37 +00:00
engine-flutter-autoroll
277047c99f
Roll Flutter Engine from c28282d39f4a to cf12bb6465e8 (1 revision) (#153674)
c28282d39f...cf12bb6465

2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from 7025ec4bff25 to 75bd296f9756 (1 revision) (flutter/engine#54609)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 07:45:07 +00:00
engine-flutter-autoroll
777e90a983
Roll Flutter Engine from d0d7de5c333d to c28282d39f4a (1 revision) (#153671)
d0d7de5c33...c28282d39f

2024-08-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from yKkNB9F8Hwnjq2AMW... to hNxjRSbGnxD3IhdOm... (flutter/engine#54608)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from yKkNB9F8Hwnj to hNxjRSbGnxD3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 05:23:24 +00:00
engine-flutter-autoroll
7e9d9e0a90
Manual roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) (#153659)
Manual roll requested by zra@google.com

c94651c33b...d0d7de5c33

2024-08-18 skia-flutter-autoroll@skia.org Roll Skia from ac7149e315ec to 7025ec4bff25 (1 revision) (flutter/engine#54605)
2024-08-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from a3zdjZKduabZSBN0B... to yKkNB9F8Hwnjq2AMW... (flutter/engine#54602)
2024-08-17 skia-flutter-autoroll@skia.org Roll Skia from 570b18e1afda to ac7149e315ec (1 revision) (flutter/engine#54600)
2024-08-17 zanderso@users.noreply.github.com Shift linux_fuchsia_tests from staging to prod (flutter/engine#54597)
2024-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596)
2024-08-17 skia-flutter-autoroll@skia.org Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595)
2024-08-17 chris@bracken.jp macOS: Extract framework creation to sky_utils (flutter/engine#54586)
2024-08-16 skia-flutter-autoroll@skia.org Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592)
2024-08-16 chris@bracken.jp [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to yKkNB9F8Hwnj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-18 17:24:40 +00:00
kzrnm
ea477d5981
[gen_l10n] isCustomDateFormat accepts an actual boolean (#153439)
Fixes #153420

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-08-18 08:57:30 -07:00
auto-submit[bot]
5d70d1914f
Reverts "Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (#153618)" (#153627)
Reverts: flutter/flutter#153618
Initiated by: zanderso
Reason for reverting: The tree is red.
Original PR Author: engine-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

c94651c33b...c9fb47927f

2024-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596)
2024-08-17 skia-flutter-autoroll@skia.org Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595)
2024-08-17 chris@bracken.jp macOS: Extract framework creation to sky_utils (flutter/engine#54586)
2024-08-16 skia-flutter-autoroll@skia.org Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592)
2024-08-16 chris@bracken.jp [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to a3zdjZKduabZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-17 13:35:16 +00:00
engine-flutter-autoroll
28c4dfabd9
Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (#153618)
c94651c33b...c9fb47927f

2024-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596)
2024-08-17 skia-flutter-autoroll@skia.org Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595)
2024-08-17 chris@bracken.jp macOS: Extract framework creation to sky_utils (flutter/engine#54586)
2024-08-16 skia-flutter-autoroll@skia.org Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592)
2024-08-16 chris@bracken.jp [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to a3zdjZKduabZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-17 02:49:28 +00:00
flutter-pub-roller-bot
55b9c5a571
Roll pub packages (#153581)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-17 00:44:08 +00:00
engine-flutter-autoroll
c7d0e606ad
Roll Flutter Engine from cc732b4c698e to c94651c33b0e (1 revision) (#153609)
cc732b4c69...c94651c33b

2024-08-16 zanderso@users.noreply.github.com Move Fuchsia tests to a separate config file (flutter/engine#54591)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-17 00:34:23 +00:00
engine-flutter-autoroll
9473c8b5d1
Roll Flutter Engine from acb71d8307fa to cc732b4c698e (1 revision) (#153605)
acb71d8307...cc732b4c69

2024-08-16 skia-flutter-autoroll@skia.org Roll Skia from 7c0eeaf12413 to fc8769175d35 (58 revisions) (flutter/engine#54589)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 23:30:24 +00:00
Michael Goderbauer
d9dbefc949
fix some unintended HTML tags in docs (#153507)
I used the `unintended_html_in_doc_comment` to find these, but sadly the lint is not ready to be enabled yet due to https://github.com/dart-lang/linter/issues/5065.
2024-08-16 23:17:14 +00:00
engine-flutter-autoroll
887afe2adf
Roll Flutter Engine from b66893e1fb7e to acb71d8307fa (1 revision) (#153600)
b66893e1fb...acb71d8307

2024-08-16 lhkbob@gmail.com Remove SkOSLibrary files from build and license scripts (flutter/engine#54583)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 22:26:55 +00:00
engine-flutter-autoroll
8817d45220
Roll Flutter Engine from d5bf3afc601f to b66893e1fb7e (2 revisions) (#153582)
d5bf3afc60...b66893e1fb

2024-08-16 chris@bracken.jp iOS: Add dSYM binaries to without_entitlements.txt (flutter/engine#54576)
2024-08-16 kevinjchisholm@gmail.com Manual roll Dart SDK from 44635f897535 to 8c02ad43e01a (3 revisions)  (flutter/engine#54581)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 18:21:23 +00:00
chunhtai
9e91307947
Update README.md (#153470)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-08-16 17:57:26 +00:00
chunhtai
5fdc911135
adds team-accessibility to triage workflow (#153575)
add team-accessibility to triage workflow
2024-08-16 17:19:06 +00:00
Andrew Kolos
080928dda3
add HttpException to the list of handled exceptions within ResidentWebRunner::run (#153527)
Resolves https://github.com/flutter/flutter/issues/153298, a major crasher of the flutter tool. I plan on cherry-picking this change.

In `ResidentWebRunner::run`, many connection-related exceptions are caught, logged, and have `ToolExit`s thrown in their place ([code](d23be7a07d/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart (L370-L385)), [PR that introduced this](https://github.com/flutter/flutter/pull/50895)). However, `HttpException` is not included in this list. See https://github.com/flutter/flutter/issues/153298#issuecomment-2290900158 for details if interested.
2024-08-16 16:40:19 +00:00
Nate Wilson
a0c04534f5
Style Guide updates (#152525)
This pull request updates the style guide for improved internal consistency and to match current linter rules.

I'll make comments for each change here!
2024-08-16 16:19:06 +00:00
engine-flutter-autoroll
febf4cdc8c
Roll Packages from 86d15a65d091 to 2c37fb052cd4 (5 revisions) (#153571)
86d15a65d0...2c37fb052c

2024-08-16 engine-flutter-autoroll@skia.org Manual roll Flutter from 99f00a130923 to bced008679af (13 revisions) (flutter/packages#7424)
2024-08-16 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds IMA plugin to labeler yaml (flutter/packages#7420)
2024-08-15 matanlurey@users.noreply.github.com Roll `avd_cipd_verison` to latest to use the `crashreport` tool. (flutter/packages#7422)
2024-08-15 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add breakpoint extension to get the current active breakpoint (flutter/packages#7347)
2024-08-15 engine-flutter-autoroll@skia.org Roll Flutter from cc13cd1f1191 to 99f00a130923 (24 revisions) (flutter/packages#7419)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 16:15:19 +00:00
Zachary Anderson
69ff9eae7b
Move Android API level 35 emulator tests to staging (#153568)
These same tests but running against API level 34 emulators are remaining as presubmit tests. The API level 35 tests should stay in staging while the emulator stabilizes. So we can collect flake data and continue to debug. 

Related: https://github.com/flutter/flutter/issues/153445
2024-08-16 15:43:13 +00:00
engine-flutter-autoroll
19fdece6c1
Roll Flutter Engine from a8fefc81188e to d5bf3afc601f (2 revisions) (#153565)
a8fefc8118...d5bf3afc60

2024-08-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) (#54558)" (flutter/engine#54578)
2024-08-16 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) (flutter/engine#54558)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 15:11:37 +00:00
Loïc Sharma
15876ff6ea
[Swift Package Manager] Test removing the last Flutter plugin (#153519)
The Flutter tool has a bug where removing the last Flutter plugin does not correctly update the CocoaPods integration.

This adds a test to ensure  that the generated Swift package is properly updated when the last Flutter plugin is removed.

See: https://github.com/flutter/flutter/issues/11819#issuecomment-2289782626
2024-08-16 14:03:13 +00:00
engine-flutter-autoroll
bced008679
Roll Flutter Engine from 68938abd03b9 to a8fefc81188e (1 revision) (#153537)
68938abd03...a8fefc8118

2024-08-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qpfC-GAVZvOwAQU5f... to Z5hq3ZkPNCpZWRQnl... (flutter/engine#54574)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from qpfC-GAVZvOw to Z5hq3ZkPNCpZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 02:29:24 +00:00
Maurice Parrish
16dae5b3bf
[interactive_media_ads] Adds missing IMA plugin to issue template (#153510) 2024-08-16 02:05:33 +00:00
engine-flutter-autoroll
b96adb1e97
Roll Flutter Engine from 65fd6ca194c1 to 68938abd03b9 (1 revision) (#153533)
65fd6ca194...68938abd03

2024-08-15 jonahwilliams@google.com [Impeller] add support for superellipse. (flutter/engine#54562)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 01:36:25 +00:00
engine-flutter-autoroll
ba31bf8c0e
Roll Flutter Engine from 8f3f80ec1225 to 65fd6ca194c1 (1 revision) (#153529)
8f3f80ec12...65fd6ca194

2024-08-15 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Improve how overlays are optimized (flutter/engine#54547)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 00:34:39 +00:00
engine-flutter-autoroll
f825a75631
Manual roll Flutter Engine from 971ddd9fe1bf to 8f3f80ec1225 (5 revisions) (#153525)
Manual roll requested by zra@google.com

971ddd9fe1...8f3f80ec12

2024-08-15 jonahwilliams@google.com [Impeller] revert experimental canvas. (flutter/engine#54570)
2024-08-15 69794332+smart7even@users.noreply.github.com Fix typo in AppLifecycleState documentation (flutter/engine#54544)
2024-08-15 codefu@google.com Update RBE troubleshooting (flutter/engine#54568)
2024-08-15 jonahwilliams@google.com [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781)
2024-08-15 jonahwilliams@google.com [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 23:04:09 +00:00
Joe Kawai
5d59f8bb1a
Add TextHeightBehavior argument for DefaultTextStyle.merge (#153178)
Addresses an issue where `DefaultTextStyle.merge` is missing the `textHeightBehavior` argument. The argument is present in the `DefaultTextStyle` constructor.

Resolves #120176
2024-08-15 23:00:15 +00:00
RamonFarizel
81ee230f49
Update TextTheme with the M3 Typography tokens (#153131)
This PR adds a new table with[ Material 3 typography tokens](https://m3.material.io/styles/typography/type-scale-tokens).

Issue:
https://github.com/flutter/flutter/issues/148429
2024-08-15 22:48:58 +00:00
Justin McCandless
73c9e4e578
Design-Documents.md incorrect link (#153509)
Fixed an incorrect link. I think it was accidentally pasted twice.
2024-08-15 22:02:00 +00:00
Matan Lurey
af815f0d9b
Roll avd_cipd_verison to latest to use the crashreport tool. (#153520)
Work towards https://github.com/flutter/flutter/issues/153445.

I can do a similar set of PRs on flutter/packages and flutter/engine for consistency.

/cc @johnmccutchan @reidbaker @zanderso
2024-08-15 21:58:31 +00:00
Greg Spencer
1633c47dda
Improve asserts on Element.mount (#153477)
## Description

In debugging an issue with mount, I hit one of these asserts, and I thought it would be a much better assert with some context.

## Tests
 - No test changes because the change is only to the output string of an assert.
2024-08-15 21:30:03 +00:00
Bernardo Ferrari
ce63c029c5
Fix anti-aliasing when painting borders with solid colors. (#153365)
Trying to reland https://github.com/flutter/flutter/pull/122317 in 2024. Let's see if we can.

<img width="666" alt="image" src="https://user-images.githubusercontent.com/351125/182002867-03d55bbb-163d-48b9-ba3c-ed32dbef2680.png">

Side effect: shapes with border will be rounder:
![Frame 6](https://github.com/user-attachments/assets/95324ebc-8db5-4365-817f-bc62304b9044)

Close https://github.com/flutter/flutter/issues/13675.
2024-08-15 19:02:23 +00:00
flutter-pub-roller-bot
70460854d1
Roll pub packages (#153479)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-15 16:39:28 +00:00
engine-flutter-autoroll
ea87865364
Roll Packages from e4f2247c3f41 to 86d15a65d091 (7 revisions) (#153499)
e4f2247c3f...86d15a65d0

2024-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.2 (flutter/packages#7417)
2024-08-15 tarrinneal@gmail.com [shared_preferences] remove testing section from README (flutter/packages#7410)
2024-08-13 nathan.wilson1232@gmail.com Fix breakages introduced by `SplashFactory` (flutter/packages#6952)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 2afc452d3a8e to cc13cd1f1191 (6 revisions) (flutter/packages#7404)
2024-08-13 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert Circle and Marker to Pigeon (flutter/packages#7326)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7379)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/file_selector/file_selector_android/android (flutter/packages#7381)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 15:49:24 +00:00
engine-flutter-autoroll
99f00a1309
Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (#153487)
76a1c64f4e...971ddd9fe1

2024-08-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Refactor create_macos_framework.py (#54557)" (flutter/engine#54566)
2024-08-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] migrate blur tests to display list. (#54519)" (flutter/engine#54564)
2024-08-15 jonahwilliams@google.com [Impeller] migrate blur tests to display list. (flutter/engine#54519)
2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from J1EXQ2ozMIQEa6F7H... to -XDS8eBA0Le-zCEfW... (flutter/engine#54561)
2024-08-14 chris@bracken.jp macOS: Refactor create_macos_framework.py (flutter/engine#54557)
2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MeV5i7xXXFPHF5sBK... to qpfC-GAVZvOwAQU5f... (flutter/engine#54559)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from MeV5i7xXXFPH to qpfC-GAVZvOw

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 07:00:25 +00:00
Qun Cheng
108a355453
Update tokens to 5.0.0 (#153385)
This PR is to
* Update the Material Design tokens to 5.0.0
* 4 color roles in **Light mode** have different default values
   `onPrimaryContainer`: Primary10  -> Primary30 
   `onSecondaryContainer`: Secondary10 -> Secondary30
   `onTertiaryContainer`: Tertiary10 -> Tertiary30
   `onErrorContainer`: Error10 -> Error30
    
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;![Screenshot 2024-08-13 at 12 53 03 PM](https://github.com/user-attachments/assets/bfa863d9-03d3-4557-8676-d56febdb2be5)

* new tokens added in list.json
* `md.comp.menu.list-item.*` tokens are deprecated and should be replaced by tokens in list.json and we've done the migration last year:)!(#122388)
2024-08-14 22:53:36 +00:00
dependabot[bot]
b4b8f07124
Bump github/codeql-action from 3.26.1 to 3.26.2 (#153468)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.1 to 3.26.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="429e197704"><code>429e197</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2425">#2425</a> from github/update-v3.26.2-a93f8c2fd</li>
<li><a href="9eec338902"><code>9eec338</code></a> Update changelog for v3.26.2</li>
<li><a href="a93f8c2fd1"><code>a93f8c2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2423">#2423</a> from github/mergeback/v3.26.1-to-main-29d86d22</li>
<li><a href="af1f2e89e3"><code>af1f2e8</code></a> Address incorrect CHANGELOG.md</li>
<li><a href="2bc3b8381e"><code>2bc3b83</code></a> Update checked-in dependencies</li>
<li><a href="dd9700c166"><code>dd9700c</code></a> Reapply &quot;Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2....</li>
<li><a href="ece28a826b"><code>ece28a8</code></a> Update changelog and version after v3.26.1</li>
<li>See full diff in <a href="29d86d22a3...429e197704">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.26.1&new-version=3.26.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-08-14 22:19:04 +00:00
Michael Goderbauer
4b60bb530f
Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (#153464)
invalid_runtime_check_with_js_interop_types has been added to recommended: 894b5006c4
2024-08-14 22:10:21 +00:00
engine-flutter-autoroll
fafe3df405
Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (#153465)
9b8421662e...76a1c64f4e

2024-08-14 chris@bracken.jp macOS: Clean up create_macos_framework.py (#54543) (flutter/engine#54555)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 22:06:16 +00:00
engine-flutter-autoroll
bd083887a4
Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (#153463)
328c4df832...9b8421662e

2024-08-14 jonnywang@google.com [fuchsia] Use Fuchsia API 22 (flutter/engine#54554)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 21:12:18 +00:00