27629 Commits

Author SHA1 Message Date
Hixie
d4dd786bd7 Allow route transitions to be more flexible
- Fix AnimationTiming to have defaults for 'interval' and 'curve' since
  that seems to be how we use it.

- Merge RouteBase.build and RouteBase.buildTransition

- Get rid of HistoryEntry, since it added nothing

- Broke out RouteBase.createPerformance() so subclasses can change what
  is created.

- Build the routes backwards so that we more efficiently avoid building
  hidden routes.

- Introduce an explicit way (!hasContent) for RouteState to avoid
  building, rather than the implicit "build returns null" we had before.
2015-09-18 14:25:18 -07:00
jason-simmons
682116529e Merge pull request #1229 from jason-simmons/editable_text_placeholder_flex
In EditableText, wrap the placeholder text in a Row so it will expand to its parent's width
2015-09-18 14:24:26 -07:00
Jason Simmons
80b2c1732a In EditableText, wrap the placeholder text in a Row so it will expand to its parent's width
This will ensure that the width of an empty Input is consistent with the
width of an Input that contains text.

Also add a unit test for the Input widget and a way for tests to provide mock
implementations of Mojo services such as the keyboard.
2015-09-18 13:46:31 -07:00
Adam Barth
94b27e7b81 Merge pull request #1234 from abarth/game_imports
SkySprites should import the public libraries
2015-09-18 12:41:11 -07:00
Hixie
1429b15780 Adjust indent in Positioned to match style guide. 2015-09-18 12:08:44 -07:00
Ian Hickson
81e0ea3551 Merge pull request #1175 from Hixie/performance-view
Require that you pass transitions a performance.
2015-09-18 11:53:58 -07:00
Adam Barth
490b22874a SkySprites should import the public libraries
Importing the public libraries caused a name conflict with dart:sky because we
assume people will import dart:sky into a namespace, so I've also changed
skysprites to import dart:sky into a namespace.
2015-09-18 11:19:39 -07:00
Adam Barth
62458b7b6d Lift docs from Markdown to dartdoc
I've also removed the top-level description of the Sky package. Instead, we
should host that content on flutter.io.
2015-09-18 10:50:45 -07:00
Hixie
e73bbd949e Require that you pass transitions a performance.
This fixes #1103.
2015-09-18 10:30:47 -07:00
Hixie
01778c4895 Provide hooks for when exceptions are thrown.
This might be helpful for #1219.

Also, remove inDebugMode since it's redundant with just using asserts,
which compile entirely out in release mode.
2015-09-18 10:23:58 -07:00
Adam Barth
4467a268ce Move theme into material.dart
Also, introduce Colors and Typography to hold the material colors and the
typography declarations. Previously we expected clients of these libraries to
import them into a namespace, but that doesn't play nice with re-exporting them
from material.dart.
2015-09-18 09:57:21 -07:00
Adam Barth
0c5d0221c8 Rev pub package 2015-09-18 09:56:44 -07:00
Adam Barth
92e7e4935c Update imports after material.dart rename 2015-09-18 09:56:10 -07:00
Hixie
499d832259 Handle the case of a Widget being moved down
When we sync() a Component, we need to clear the old Component's _child
pointer, otherwise if we reuse that Component we'll get confused about
what the old child is.
2015-09-17 17:23:20 -07:00
Ian Hickson
c0d326b17f Merge pull request #1218 from Hixie/toString
Improve debugging aids for widgets, rendering.
2015-09-17 16:27:02 -07:00
Ian Fischer
a89fdd92ce Kill the sky_server on Mac in a way that works to avoid unexpected behavior when working with more than one app at once. 2015-09-17 16:03:29 -07:00
Adam Barth
9ba2a6e136 Merge pull request #29 from jamesr/stamp_skyx
Prepend mojo shebang to skyx files
2015-09-17 16:01:31 -07:00
Adam Barth
409f0e13d4 Merge pull request #1222 from abarth/rm_skyx
Remove the skyx package
2015-09-17 16:00:39 -07:00
Adam Barth
55768124b6 Remove the skyx package
This code is now part of sky_tools.
2015-09-17 16:00:28 -07:00
James Robinson
0b2a946b23 Prepend mojo shebang to skyx files
skyx files are zips, so they can have anything at the start. Having
a shebang line at the start makes it easier to run skyx files in a mojo
environment.
2015-09-17 15:27:33 -07:00
Adam Barth
6626817c86 Rev pub package 2015-09-17 15:26:31 -07:00
Adam Barth
3e9ceec0b1 Improve sky_tools build so that it works from sky_engine
With this patch, we can switch over to using this command from the build system
in the sky_engine repo.
2015-09-17 15:12:15 -07:00
Collin Jackson
847cea15d6 Ensure that the item under the focal point stays in the same place despite zooming 2015-09-17 14:36:48 -07:00
Adam Barth
a75e79f0ce Address review comments from @iansf 2015-09-17 14:02:55 -07:00
Hixie
970c8ce842 Improve debugging aids for widgets, rendering.
We need a short name more often than a tree dump, so toString() should
be the short name.

Make debugDumpRenderTree() a global like debugDumpApp(), for
consistency. It's hard to remember the
SkyBinding.instance.dumpRenderTree() incantation.

Fixes #1179.
2015-09-17 13:59:46 -07:00
Viktor Lidholt
d83b3ba0c8 Merge pull request #1216 from vlidholt/master
Adds TexturedLine and animated EffectLine to sprites
2015-09-17 13:58:49 -07:00
Adam Barth
cf41a63396 Add a build command to sky_tools
This command will produce an flx package. Currently, this command doesn't work
because we don't have the Flutter compiler downloaded from Google storage yet.
A future patch will make that happen.
2015-09-17 13:37:53 -07:00
Hixie
b1e64571e6 Fix removal logic in widgets
We were not removing children if they were more recently synced than we
were. This makes no sense. We should remove all children unless they
were synced this very generation already (in which case they'll be
somewhere else in the tree by now).
2015-09-17 13:30:27 -07:00
Viktor Lidholt
8900b4c8ba Adds TexturedLine and animated EffectLine to sprites 2015-09-17 13:27:43 -07:00
Collin Jackson
6dd58b2108 add a test for scale gestures 2015-09-17 12:45:13 -07:00
Adam Barth
6d78b0501a Remove reference to oblique
We removed this value from the engine because it's not useful.
2015-09-17 11:19:24 -07:00
Adam Barth
7064551a45 Move mojo frontend into services.dart
What's important about this code is that it's presenting services outside the
VM, not the particular technology used to present the services.
2015-09-16 19:13:50 -07:00
Adam Barth
41b8ffd623 Create gestures.dart
This patch is part of a sequence of patches towards fewer top-level libraries.
In this patch, the gesture libraries are combined into one gestures.dart
library.
2015-09-16 18:25:00 -07:00
Collin Jackson
b50c015f33 Merge remote-tracking branch 'origin/master' into pinch
Conflicts:
	examples/widgets/scale.dart
2015-09-16 17:58:38 -07:00
Collin Jackson
d602589db3 Merge pull request #1181 from collinjackson/pinch
First pass at support for pinch gestures; panning issues (needs testing)
2015-09-16 17:57:42 -07:00
Collin Jackson
97b25712f0 Update scale API and add example 2015-09-16 17:20:23 -07:00
Collin Jackson
842e94e9f8 First pass at support for pinch gestures; panning issues (needs testing)
Conflicts:
	sky/packages/sky/lib/gestures/drag.dart
2015-09-16 17:20:23 -07:00
Adam Barth
f55a6ad1c1 Rev pub packages 2015-09-16 17:13:38 -07:00
Adam Barth
5bc8d7c782 Update sky_tools 2015-09-16 16:49:27 -07:00
Adam Barth
e8ef4704ea Rev pub package 2015-09-16 16:48:49 -07:00
Adam Barth
f379a01946 Handle subprocess crashes during testing 2015-09-16 16:47:22 -07:00
Collin Jackson
109a496e2c Update scale API and add example 2015-09-16 16:21:33 -07:00
Hixie
2618f34dfe Improve debugging aids in framework.dart 2015-09-16 16:08:05 -07:00
Collin Jackson
4ab606973f First pass at support for pinch gestures; panning issues (needs testing)
Conflicts:
	sky/packages/sky/lib/gestures/drag.dart
2015-09-16 15:01:38 -07:00
Adam Barth
76a51409c5 Remove stray }
This stray line was causing an analyzer error.
2015-09-16 14:35:09 -07:00
Adam Barth
4561f9eb65 Remove extra return 2015-09-16 14:28:44 -07:00
Ian Hickson
0913fb71ba Merge pull request #1197 from Hixie/mimic
Factor out GlobalKeyWatcher
2015-09-16 14:27:44 -07:00
Hixie
f3655f346b Minor clean up of animation_performance.dart
- Reorder the methods so they are closer to run order.
- Reindent the code to match style guide.
2015-09-16 14:09:51 -07:00
Hixie
d866860605 Factor out GlobalKeyWatcher
This also moves the logic that tracks what Widget is being watched into
GlobalKeyWatcher, and much simplifies Mimic based on this.
2015-09-16 13:20:09 -07:00
Ian Hickson
ebf71f59d6 Merge pull request #1191 from Hixie/flex
FlexAlignItems.stretch didn't stretch
2015-09-16 13:09:08 -07:00