27629 Commits

Author SHA1 Message Date
Ian Fischer
17d89f3dbb Avoid crashing when an iOS device isn’t connected. 2015-08-31 10:41:52 -07:00
Ian Hickson
1e61314ed5 Merge pull request #897 from Hixie/sync-children
Provide a fast path for MultiChildRenderObjectWrapper.syncRenderObject() when the children lists are identical.
2015-08-31 10:36:28 -07:00
Adam Barth
5fb3176951 Merge pull request #953 from abarth/painting_docs
Add dartdoc for the painting code
2015-08-31 09:37:10 -07:00
Adam Barth
e525943d81 Add dartdoc for the painting code 2015-08-31 09:36:35 -07:00
Adam Barth
528ff0f117 onPressed not called when in a Positioned Flex
We were setting the main axis extent to zero because we had a sign error.

Fixes #918
2015-08-31 09:12:40 -07:00
Adam Barth
ff74d9ec19 Unbreak link when deployed 2015-08-30 18:43:17 -07:00
Ian Hickson
bbb29f229f Add gestures/ to README.md prose 2015-08-30 16:30:59 -07:00
Ian Hickson
f291588da5 Add gestures/ to README.md diagram 2015-08-30 16:29:48 -07:00
Adam Barth
35ac1f710e Add dartdoc for base 2015-08-30 13:03:03 -07:00
Adam Barth
984a39f491 Update box_painter.dart 2015-08-30 11:03:00 -07:00
Adam Barth
92ef38fd46 Merge pull request #946 from abarth/infinite_border_radius
BoxDecoration's borderRadius should be able to handle a value of double.INFINITY
2015-08-29 22:34:30 -07:00
Adam Barth
bef55951a5 Scrolls should start immediately when possible
If there are no other gestures in the arena, we should kick off the scroll
gesture right away. This change pulled a refactoring of how we dispatch events
to Widgets. Now we dispatch events to Widgets interleaved with their associated
RenderObjects. (Previously we dispatched to all of the RenderObjects first.)
2015-08-29 22:30:49 -07:00
Adam Barth
4adf70215d Pull in a new version of playfair
We need the new version because of the TextPainter rename.
2015-08-29 15:54:43 -07:00
Adam Barth
b3b4b4573f Rev pub package 2015-08-29 15:52:08 -07:00
Adam Barth
16f4f836af Update playfair after TextPainter rename 2015-08-29 11:47:18 -07:00
Adam Barth
365d2277c8 Rename ParagraphPainter to TextPainter
Also, add asserts that the text has layout before being painted.
2015-08-29 11:41:20 -07:00
Adam Barth
650c4a64f5 BoxDecoration's borderRadius should be able to handle a value of double.INIFINITY
We just need to enforce some finite clamp and Skia will do the rest.

Fixes #939
2015-08-28 20:58:34 -07:00
Adam Barth
5feb77f69f Remove unused import to make analyzer happy 2015-08-28 20:50:54 -07:00
Adam Barth
1344211bdb Merge pull request #941 from abarth/scroll_disambig
Disambiguate horizontal and vertical scrolling
2015-08-28 20:33:31 -07:00
Adam Barth
b40864c9b7 Disambiguate horizontal and vertical scrolling
We now have separate gestures for horizontal, vertical, and pan scrolling.
2015-08-28 20:33:14 -07:00
Ian Fischer
d96f385310 Merge pull request #944 from iansf/no_android
Don't crash when no Android device is attached
2015-08-28 19:28:51 -07:00
Misha Dynin
af9212c78d Fixed a typo in the README. 2015-08-28 17:54:14 -07:00
Ian Fischer
576f51d4f4 Make it so that sky_tool doesn’t crash if an Android device isn’t attached.
Refactors a bunch of Android-related things into an AndroidDevice singleton class.
2015-08-28 17:13:39 -07:00
Ian Hickson
a5d9c0cb2b Merge pull request #942 from Hixie/mixed-mid
Fix crash when a MixedViewport is initially offset at a non-zero position
2015-08-28 16:59:43 -07:00
Hixie
fc7943fe06 Test MixedViewport
add/remove/add smoketest
basic vertical behaviour
basic horizontal behaviour
2015-08-28 16:59:10 -07:00
Hixie
791bd8b546 Fix crash when a MixedViewport is initially offset at a non-zero position.
We need to always remove the widget when you sync a non-visible
widget, even if we already have it, because otherwise we'll try to
sync it with null again later, which causes a crash.

Test in #938.
2015-08-28 16:57:05 -07:00
Viktor Lidholt
2d0d82e0b0 Merge pull request #940 from vlidholt/master
Improvements to demo game
2015-08-28 16:16:51 -07:00
Adam Barth
ce2d9f374e Rev pub package 2015-08-28 16:13:02 -07:00
Viktor Lidholt
138e8fbf42 Adds power-ups to demo game 2015-08-28 16:07:00 -07:00
Viktor Lidholt
c7d2872d77 Adds new enemies and coin display to demo game 2015-08-28 16:07:00 -07:00
Hixie
eb84a0cae4 Set and remove the callbacks on the RenderObject when we create and remove it.
...and not when we mount and dismount.

Turns out that when we dismount, it's too late -- we've already set
renderObject to null.

We also mark the mixed viewport as dirty when it is removed from its parent.
Without this, we try to reuse the child nodes in subsequent syncs, which is a disaster.
2015-08-28 15:07:51 -07:00
Adam Barth
f4869c764b onScrollStart shouldn't have an offset
Instead, we pump a onScrollUpdate with the offset if there is an offset.
2015-08-28 15:07:30 -07:00
Hixie
06efe78546 Add support for 'direction' to MixedViewport. 2015-08-28 14:27:51 -07:00
Adam Barth
81b3bdd414 Merge pull request #930 from abarth/scroll
Add scroll gestures and use them in Scrollable
2015-08-28 14:05:36 -07:00
Adam Barth
e99ff36283 Add scroll gestures and use them in Scrollable
This patch replaces the scroll gestures used by Scrollable with ones detected
by the ScrollGestureDetector.
2015-08-28 13:59:46 -07:00
Hixie
9047830c2e Rationalise the Key API.
Add a way of having keys based on numeric types or DateTimes by having a ValueKey<T> class.
Remove the redundant ways of declaring things, except for leaving one shorthand -- you can say `new Key(s)` instead of `new ValueKey<String>(s)`.
2015-08-28 13:17:34 -07:00
Hixie
12e3897f40 Stop exporting framework.dart from basic.dart, since we now have widgets.dart exporting all of framework.dart. 2015-08-28 13:06:11 -07:00
Adam Barth
1674ecb6f1 Merge pull request #921 from abarth/use_tap
Use GestureDetector in the framework and examples
2015-08-28 12:52:51 -07:00
Ian Fischer
4f1b4e3e85 Merge pull request #922 from iansf/verbose_flag
Add a --verbose flag to sky_tool
2015-08-28 12:40:59 -07:00
Ian Fischer
0ee00fb2fa Add a verbose flag to sky_tool that logs all of shell commands being run.
Also clean up some formatting issues.
2015-08-28 11:00:54 -07:00
Adam Barth
dc84e882df Use GestureDetector in the framework and examples
We're now using it at the widget layer for everything except scrolling and
flinging.
2015-08-28 10:58:46 -07:00
Adam Barth
a46b83da80 Merge pull request #912 from abarth/tap
Add tap, show press, and long press gestures and use tap in IconButton
2015-08-28 10:23:01 -07:00
Adam Barth
95e80663db Add tap, show press, and long press gestures and use tap in IconButton
These gestures use the new gesture detection system.
2015-08-28 10:21:35 -07:00
Ian Fischer
d2e32b806d Merge pull request #916 from iansf/release_flag
Add --release flag
2015-08-28 09:56:33 -07:00
Ian Fischer
f3d9961af7 Add global release flag that will attempt to use release builds during install. 2015-08-28 09:37:54 -07:00
Adam Barth
01e7c6966e Fix analyzer warning 2015-08-27 22:59:24 -07:00
Adam Barth
d7e6f7b751 Merge pull request #908 from abarth/gesture_arena
Add GestureArena
2015-08-27 17:17:28 -07:00
Adam Barth
d8de2f9770 Add GestureArena
In the GestureArena, gestures will fight it out to see which is the real
ultimate gesture.
2015-08-27 17:17:12 -07:00
Eric Seidel
19766c05de Merge pull request #878 from eseidelGoogle/grid
Add basic Grid widget and test RenderGrid
2015-08-27 15:55:39 -07:00
Ian Hickson
ce51289616 Merge pull request #901 from Hixie/layout-callback
Allow parents of RenderObjects that have layout callbacks to depend on those objects' sizes.
2015-08-27 15:32:02 -07:00