27629 Commits

Author SHA1 Message Date
Ian Fischer
ccd4add7c4 Merge pull request #903 from iansf/fix_dumb_mistake
Fix infinite loop
2015-08-27 15:31:04 -07:00
Adam Barth
24d1e09b0d Add test for PointerRouter 2015-08-27 15:29:31 -07:00
Ian Fischer
ec503ea9b8 Fix infinite loop in sky_tool listen if you didn’t specify —local-build 2015-08-27 15:29:26 -07:00
Hixie
a6e6b93b14 Allow parents of RenderObjects that have layout callbacks to depend on those objects' sizes.
Previously, if you used a layout callback, you could not have a parent
that did parentUsesSize, or if you did, you had to be marked
sizedByParent. With this patch, we allow the parent to depend on your
layout, even if you modify your child list during your layout using a
layout callback, by checking that the parent is still actively being
laid out in this scenario.
2015-08-27 15:26:57 -07:00
Adam Barth
2994e47c48 Merge pull request #899 from abarth/pointer_router
Add PointerRouter
2015-08-27 15:25:51 -07:00
Ian Fischer
e30b436d1a Merge pull request #898 from iansf/require_ios_7
Only require iOS 7 for Fitness app
2015-08-27 15:08:27 -07:00
Adam Barth
45f2c58987 Add PointerRouter
This patch is the first step towards implementing gestures. The pointer router
allows the gesture detectors to hook in at the end of the pointer event
propagation chain.

Related to #145
2015-08-27 15:02:35 -07:00
Ian Fischer
b214e355f6 Only require iOS 7 for Fitness app. 2015-08-27 15:02:18 -07:00
Eric Seidel
b58f850e63 Add a Widget wrapper around Grid and test RenderGrid
@abarth
2015-08-27 14:52:19 -07:00
Eric Seidel
0d4b997008 Add a pageChanged callback to PageableList
Also includes changes to widget_tester sufficient to
test scrolling.

@abarth
2015-08-27 14:51:53 -07:00
Hixie
204c073615 Provide a fast path for MultiChildRenderObjectWrapper.syncRenderObject() when the children lists are identical.
This isn't so much for performance so much as because I don't want to
have to keep checking that the main syncChildren() function maintains
the invariant of not screwing up when the two lists are actually the
same list.
2015-08-27 14:50:58 -07:00
Ian Fischer
338ca571b2 Make sure that local build paths exist before doing things that expect them. 2015-08-27 13:46:15 -07:00
Adam Barth
f688c11ceb Merge pull request #890 from abarth/cancel_queued_callback
Scheduler should be able to cancel a queued callback
2015-08-27 11:06:26 -07:00
Ian Fischer
8fa319a3e7 Merge pull request #891 from iansf/reorder_listen
Start "sky_tool listen" with a refresh
2015-08-27 10:56:59 -07:00
Ian Fischer
fdaea8b79d Have “sky_tool listen” start with a refresh so that iOS devices don’t wait on a black screen for the first filesystem change. 2015-08-27 10:54:10 -07:00
Adam Barth
315577fc95 Scheduler should be able to cancel a queued callback
Previously, once a callback was in the execution queue, it couldn't be
canceled. Now we check whether the callback was canceled before executing it.
2015-08-27 10:51:01 -07:00
Ian Hickson
91a72d9fed Merge pull request #879 from Hixie/RenderBlockViewport
Abstract out syncChildren().
2015-08-27 10:44:45 -07:00
Adam Barth
e51525cfe8 Rev pub package 2015-08-27 10:29:47 -07:00
Viktor Lidholt
5f277dd4d2 Merge pull request #874 from vlidholt/master
Adds counting of coins in demo game
2015-08-27 10:23:24 -07:00
Alhaad Gokhale
82153a5163 Update version of mojo and mojo_services to 0.0.23 for sky dart. 2015-08-27 10:05:22 -07:00
Adam Barth
a29e2ebb18 Merge pull request #882 from abarth/image_logging
Add logging to help diagnose image loading failures
2015-08-26 19:45:08 -07:00
Adam Barth
d6e949fba3 Add logging to help diagnose image loading failures
For debugging #801
2015-08-26 17:17:35 -07:00
Hixie
e6f34f8666 Abstract out syncChildren().
The core of MultiChildRenderObjectWrapper.syncRenderObject() could
apply to any subclass that uses a flat child list, so this abstracts
it out into the superclass.

(Also, instead of requiring the callbacks of RenderBlockViewport to
constrain their results, we just constrain it for them. Makes things a
bit easier for users of that class.)
2015-08-26 16:56:25 -07:00
Adam Barth
07d96a2314 Rename layout_utils.dart to rendering_tester.dart
Also, rename build_utils.dart to widget_tester.dart. These files are now named
for their most commonly used classes.

Finally, add a .analysis_options to silence the (intentional) analyzer warnings
in append_child_test.dart.
2015-08-26 15:49:04 -07:00
Adam Barth
d8fdccc596 Merge pull request #875 from abarth/merge_pump_frame
Merge pumpPaintFrame and pumpFrame in WidgetTester
2015-08-26 15:46:28 -07:00
Adam Barth
c405631ccd Merge pumpPaintFrame and pumpFrame in WidgetTester
We can make all the test pass by removing more of the mocks and using the real
code.
2015-08-26 15:42:52 -07:00
Collin Jackson
56508d4159 Merge pull request #872 from collinjackson/more_date_picker_tests
Test year selection for date picker
2015-08-26 15:39:24 -07:00
Viktor Lidholt
e239e4c993 Adds counting of coins in demo game 2015-08-26 15:35:19 -07:00
Collin Jackson
52ed57e1bb Test year selection for date picker 2015-08-26 15:30:49 -07:00
Hans Muller
38d2302864 Merge pull request #850 from HansMuller/progress-bar-animation
Fix ProgressIndicators and add a regression test

Added some unit test infrastucture for checking layers.
2015-08-26 15:24:12 -07:00
Hans Muller
4e650a8928 Fix ProgressIndicators and add a regression test
Added some unit test infrasture for checking layers.
2015-08-26 15:22:24 -07:00
Ian Hickson
7a4bdc7f2a Merge pull request #870 from Hixie/RenderBlockViewport
Generalise RenderBlockViewport so that it can be used by a Widget that knows its children's dimensions.
2015-08-26 15:16:43 -07:00
Hixie
b1468cb2ea ShrinkWrapHeight widget
- add debugDescribeSettings to a few classes that were missing it
- fix some minor bugs in RenderShrinkWrapWidth and ShrinkWrapWidth
- introduce RenderShrinkWrapHeight and ShrinkWrapHeight
2015-08-26 15:07:53 -07:00
Hixie
04a8fe8e6b Generalise RenderBlockViewport so that it can be used by a Widget that knows its children's dimensions. 2015-08-26 14:25:53 -07:00
Adam Barth
bb38d1d974 Remove unused import to silence analyzer 2015-08-26 14:21:36 -07:00
Andrew Wilson
c6ae330320 Fix npe. 2015-08-26 14:14:44 -07:00
Eric Seidel
b122969624 Add support for RenderGrid
I'll write the Widget wrapper in the next CL, including adding
support for padding at the Widget layer.

@Hixie
2015-08-26 13:52:30 -07:00
Ian Hickson
bdc77e868c Merge pull request #863 from Hixie/mixed-viewport-changes
Make RenderBlockViewport shrink-wrap its children in the main axis direction
2015-08-26 13:43:55 -07:00
Adam Barth
c476f8b3d5 Merge pull request #866 from abarth/test_date_picker
Add a basic test for DatePicker
2015-08-26 13:40:31 -07:00
Adam Barth
92e5a65d29 Add a basic test for DatePicker
Most of this work in this patch is building out the test framework to the point
where we can write this test.
2015-08-26 13:38:05 -07:00
Ian Hickson
f5fdc1cf1b Merge pull request #852 from Hixie/sizing-docs
Update the documentation on sizing, make another assert point to it.
2015-08-26 13:25:17 -07:00
Hixie
301d0d3774 Make RenderBlockViewport shrink-wrap its children in the main axis direction. 2015-08-26 13:19:04 -07:00
Viktor Lidholt
6528903150 Merge pull request #862 from vlidholt/master
Moves GameObjectFactory and PlayerState to their own files in demo game
2015-08-26 13:18:57 -07:00
Viktor Lidholt
d90ccd3a2a Moves GameObjectFactory and PlayerState to their own files in demo game 2015-08-26 13:14:40 -07:00
Jim Beveridge
3c1672a899 Automatically update apk on device.
Fixes #454.
2015-08-26 13:13:14 -07:00
Viktor Lidholt
d7a7a2ed29 Merge pull request #859 from vlidholt/master
Adds power ups to demo game
2015-08-26 12:46:50 -07:00
Viktor Lidholt
3464bd18d0 Adds power ups to demo game, and some minor refactoring to support the addition 2015-08-26 12:41:21 -07:00
Andrew Wilson
6215abec4d Change generic value names to be more descriptive for assert tracing. 2015-08-26 12:22:38 -07:00
Adam Barth
ea2ff27356 Merge pull request #855 from abarth/big_circle_test
Turn big_circle.dart into a test
2015-08-26 11:20:36 -07:00
Collin Jackson
79e92a53a8 Add haptic feedback to date picker 2015-08-26 11:20:00 -07:00