38094 Commits

Author SHA1 Message Date
engine-flutter-autoroll
4d75edb3c0
Roll Flutter Engine from 4a344e050401 to 152790b5811b (1 revision) (#138959)
4a344e0504...152790b581

2023-11-23 skia-flutter-autoroll@skia.org Roll Skia from 094c3d963ba0 to 2c89bb28860b (1 revision) (flutter/engine#48341)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 22:09:23 +00:00
engine-flutter-autoroll
a14d721420
Roll Flutter Engine from 6e71c3642abf to 4a344e050401 (1 revision) (#138958)
6e71c3642a...4a344e0504

2023-11-23 skia-flutter-autoroll@skia.org Roll Skia from fc9c5337e568 to 094c3d963ba0 (6 revisions) (flutter/engine#48340)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 21:21:06 +00:00
engine-flutter-autoroll
ba6d874944
Roll Flutter Engine from bec0dacaae41 to 6e71c3642abf (2 revisions) (#138956)
bec0dacaae...6e71c3642a

2023-11-23 skia-flutter-autoroll@skia.org Roll Skia from 5606ef899116 to fc9c5337e568 (1 revision) (flutter/engine#48339)
2023-11-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IK4xyRtZkDwqT6pXA... to 4CZFCL5oL042nQihC... (flutter/engine#48338)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from IK4xyRtZkDwq to 4CZFCL5oL042

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 20:27:25 +00:00
Christopher Fujino
4c978efead
[flutter_tools] Fix bad state future already completed in flutter logs (#138517)
Fixes https://github.com/flutter/flutter/issues/138436
2023-11-23 19:56:14 +00:00
chunhtai
d92d2c12b2
Fix SliverGrid garbage collection issue (#138915)
The code doesn't consider indices of children may not be continuous after rebuild.

fixes https://github.com/flutter/flutter/issues/138749
2023-11-23 19:47:36 +00:00
engine-flutter-autoroll
2663e50a02
Roll Flutter Engine from f331e0afaf2e to bec0dacaae41 (6 revisions) (#138954)
f331e0afaf...bec0dacaae

2023-11-23 linxunfeng@yeah.net Fix not being able to hide iOS status bar via setEnabledSystemUIMode (flutter/engine#48271)
2023-11-22 mdebbar@google.com [web] Hook the new JS API to the FlutterViewManager (flutter/engine#48283)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 3a79d7a618aa to 5606ef899116 (1 revision) (flutter/engine#48331)
2023-11-22 louiseh0313@gmail.com Fix Share Screen Crash on iPad (flutter/engine#48220)
2023-11-22 dnfield@google.com Delete unused/test only code from FML (flutter/engine#48327)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 30ecaac60b47 to 3a79d7a618aa (1 revision) (flutter/engine#48328)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 19:45:07 +00:00
engine-flutter-autoroll
791470b1a7
Roll Packages from 2102327ab9f2 to 6c5ad9ee1a0b (1 revision) (#138950)
2102327ab9...6c5ad9ee1a

2023-11-22 engine-flutter-autoroll@skia.org Manual roll Flutter from ab721f935ffc to 14549b38891f (20 revisions) (flutter/packages#5466)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 19:41:28 +00:00
dependabot[bot]
106667eb4b
Bump dessant/lock-threads from 5.0.0 to 5.0.1 (#138921)
Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 5.0.0 to 5.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/releases">dessant/lock-threads's releases</a>.</em></p>
<blockquote>
<h2>v5.0.1</h2>
<p>Learn more about this release from the <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file. See <a href="https://github.com/absolute-version/commit-and-tag-version">commit-and-tag-version</a> for commit guidelines.</p>
<h2><a href="https://github.com/dessant/lock-threads/compare/v5.0.0...v5.0.1">5.0.1</a> (2023-11-22)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>support filtering threads by labels with spaces (<a href="0a63678232">0a63678</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/40">#40</a></li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a> (2023-11-14)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>Discussions are also processed by default,
set the <code>process-only</code> input parameter to preserve the old behavior</li>
</ul>
<pre lang="yaml"><code>    steps:
      - uses: dessant/lock-threads@v5
        with:
          process-only: 'issues, prs'
</code></pre>
<ul>
<li>the action now requires Node.js 20</li>
</ul>
<h3>Features</h3>
<ul>
<li>lock discussions (<a href="0a0976f3de">0a0976f</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="5a25b54eae">5a25b54</a>)</li>
</ul>
<h3><a href="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a> (2023-06-12)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>retry and throttle GitHub API requests (<a href="1618e91da6">1618e91</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a> (2022-12-04)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>the action now requires Node.js 16</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1bf7ec2505"><code>1bf7ec2</code></a> chore(release): 5.0.1</li>
<li><a href="adf4aa5f8a"><code>adf4aa5</code></a> chore: update package</li>
<li><a href="0a63678232"><code>0a63678</code></a> fix: support filtering threads by labels with spaces</li>
<li>See full diff in <a href="d42e5f4980...1bf7ec2505">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dessant/lock-threads&package-manager=github_actions&previous-version=5.0.0&new-version=5.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2023-11-22 22:15:57 +00:00
engine-flutter-autoroll
ce1231d682
Manual roll Flutter Engine from 342fb003b11f to f331e0afaf2e (9 revisions) (#138918)
Manual roll requested by jacksongardner@google.com

342fb003b1...f331e0afaf

2023-11-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] pass const ref to binding helpers." (flutter/engine#48330)
2023-11-22 jacksongardner@google.com Revert "Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions)" (flutter/engine#48325)
2023-11-22 jonahwilliams@google.com [Impeller] cache render target properties on Render Pass. (flutter/engine#48323)
2023-11-22 jonahwilliams@google.com [Impeller] pass const ref to binding helpers. (flutter/engine#48318)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 994558cd1fae to 30ecaac60b47 (1 revision) (flutter/engine#48324)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 9086788fc341 to 994558cd1fae (1 revision) (flutter/engine#48322)
2023-11-22 31859944+LongCatIsLooong@users.noreply.github.com Expose a few more glyph apis from `ui.Paragraph` (flutter/engine#47698)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from efdec1f459ce to 9086788fc341 (2 revisions) (flutter/engine#48317)
2023-11-22 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions) (flutter/engine#48316)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 22:08:03 +00:00
Michael Goderbauer
094f529b6a
Fix team-infra label in dependabot (#138917)
As part of the new triage process (https://flutter.dev/go/triage-2023-rfc) the "team: infra" label was replaced by "team-infra"
2023-11-22 22:04:15 +00:00
Yegor
14549b3889
make FakeView not send Scene and semantics to the engine (#138849)
`FakeView` wraps the same underlying `FlutterView`. Sending semantics updates and Scene objects from multiple fake views into the same engine `FlutterView` violates contracts with the engine. This PR stubs out `render` and `updateSemantics` methods in `FakeView` classes to prevent that.

This unblocks https://github.com/flutter/engine/pull/48251, which implements multi-view semantics for web.
2023-11-22 20:48:20 +00:00
Qun Cheng
c7d4b32fdd
Update the default outline color for OutlinedButton (#138768)
Fix b/311343182

This is to update the default outline for `OutlinedButton`. When the button is focused, the outline color should be primary color.
2023-11-22 20:16:37 +00:00
engine-flutter-autoroll
843074c5bd
Roll Flutter Engine from c954a64c509b to 342fb003b11f (1 revision) (#138903)
c954a64c50...342fb003b1

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 2c68a803f497 to efdec1f459ce (2 revisions) (flutter/engine#48315)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 17:41:54 +00:00
engine-flutter-autoroll
721ee57492
Roll Packages from c9933fc09a0b to 2102327ab9f2 (3 revisions) (#138895)
c9933fc09a...2102327ab9

2023-11-22 mikemcguiness@protonmail.com [cross_file] adopt code excerpts in README (flutter/packages#5347)
2023-11-21 engine-flutter-autoroll@skia.org Manual roll Flutter from 9c9e0617b149 to ab721f935ffc (16 revisions) (flutter/packages#5461)
2023-11-21 kevmoo@users.noreply.github.com [url_launcher_web] migrate to pkg:web (flutter/packages#5451)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 15:45:08 +00:00
Flutter GitHub Bot
29c95cda78
Marks Mac_build_test flutter_gallery__transition_perf_e2e_ios to be unflaky (#138886)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_build_test flutter_gallery__transition_perf_e2e_ios"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_build_test%20flutter_gallery__transition_perf_e2e_ios%22).
This test can be marked as unflaky.
2023-11-22 15:43:15 +00:00
engine-flutter-autoroll
35a53b0b1a
Roll Flutter Engine from d55b673f895c to c954a64c509b (1 revision) (#138894)
d55b673f89...c954a64c50

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from af2bd26a3a5e to 2c68a803f497 (1 revision) (flutter/engine#48311)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 15:27:57 +00:00
Elias Yishak
48187028c1
Add commandHasTerminal parameter + apple usage event + sendException events for package:unified_analytics (#138806)
Relates to tracker issue:
- https://github.com/flutter/flutter/issues/128251

This PR includes 3 major updates:
- Adding the `commandHasTerminal` parameter for `Event.flutterCommandResult`
  - In `packages/flutter_tools/lib/src/runner/flutter_command.dart`
- Adding the new event for `sendException` from package:usage to be `Event.exception` (this event can be used by all dash tools)
  - In `packages/flutter_tools/lib/runner.dart`
- Migrating the generic `UsageEvent` which was only used for Apple related workflows for iOS and macOS. I did an initial analysis in this [sheet](https://docs.google.com/spreadsheets/d/11KJLkHXFpECMX7tw-trNkYSr5MHDG15XNGv6TgLjfQs/edit?resourcekey=0-j4qdvsOEEg3wQW79YlY1-g#gid=0) to identify all the call sites
  - Found in several files, highlighted in the sheet above
2023-11-22 12:25:10 +00:00
engine-flutter-autoroll
67a602d722
Roll Flutter Engine from 6c8f7b566a22 to d55b673f895c (1 revision) (#138890)
6c8f7b566a...d55b673f89

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cc9006085362 to af2bd26a3a5e (1 revision) (flutter/engine#48307)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 12:21:10 +00:00
engine-flutter-autoroll
b3f71ff366
Roll Flutter Engine from dda2499df48a to 6c8f7b566a22 (1 revision) (#138875)
dda2499df4...6c8f7b566a

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 143b6b5b91a5 to cc9006085362 (1 revision) (flutter/engine#48306)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 07:50:07 +00:00
engine-flutter-autoroll
9a9ee23655
Roll Flutter Engine from 1ae1d5318257 to dda2499df48a (4 revisions) (#138872)
1ae1d53182...dda2499df4

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cebd44423589 to 143b6b5b91a5 (1 revision) (flutter/engine#48305)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 23b9316efd20 to cebd44423589 (1 revision) (flutter/engine#48304)
2023-11-22 jonahwilliams@google.com [Impeller] make host buffer state internally ref counted. (flutter/engine#48303)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from b6f33389cefa to 23b9316efd20 (2 revisions) (flutter/engine#48302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 07:00:10 +00:00
engine-flutter-autoroll
615481deb7
Roll Flutter Engine from 7cf9d90d59e1 to 1ae1d5318257 (8 revisions) (#138861)
7cf9d90d59...1ae1d53182

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) (flutter/engine#48299)
2023-11-22 jonahwilliams@google.com [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/linux/...` compatible with `.clang-tidy`. (flutter/engine#48297)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/android/...` compatible with `.clang-tidy`. (flutter/engine#48296)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48295)
2023-11-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293)
2023-11-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Q3HcTitDF90Z to IK4xyRtZkDwq

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 05:58:23 +00:00
Jackson Gardner
b186c69684
Revert "Reland VelocityTracker update (again)" (#138863)
Reverts flutter/flutter#138843

This has broken the Mac_ios microbenchmarks_ios. Example failure:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/9339/overview
2023-11-21 19:17:46 -08:00
Andrew Kolos
cf09a8a24f
In flutter doctor -v, when JRE is too out-of-date to run sdkmanager, print a helpful error message (#138762)
Closes https://github.com/flutter/flutter/issues/138132. See this issue for more information.
2023-11-21 23:16:08 +00:00
engine-flutter-autoroll
9d9dbb78d5
Roll Flutter Engine from a8e9b8dd562b to 7cf9d90d59e1 (1 revision) (#138847)
a8e9b8dd56...7cf9d90d59

2023-11-21 matanlurey@users.noreply.github.com Yet more compliance with `.clang_tidy`, stragglers edition. (flutter/engine#48291)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 23:14:21 +00:00
engine-flutter-autoroll
ba433ebb65
Roll Flutter Engine from 90d1ff04ae02 to a8e9b8dd562b (1 revision) (#138846)
90d1ff04ae...a8e9b8dd56

2023-11-21 jacksongardner@google.com Update skia build file to account for new skcms changes. (flutter/engine#48286)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 22:31:16 +00:00
Kate Lovett
3e4e280914
Reland VelocityTracker update (again) (#138843)
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291
Fixes https://github.com/flutter/flutter/issues/97761

The original change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728

It was reverted again due to a change in the leak tracking tests that broke it.
2023-11-21 22:21:22 +00:00
engine-flutter-autoroll
50c9a377c7
Roll Flutter Engine from 31799868224d to 90d1ff04ae02 (2 revisions) (#138844)
3179986822...90d1ff04ae

2023-11-21 matanlurey@users.noreply.github.com Make `{shell|lib/ui}/...` compatible with `.clang_tidy`. (flutter/engine#48242)
2023-11-21 jonahwilliams@google.com [Impeller] Ensure that overlay surfaces are constructed with wide gamut settings. (flutter/engine#48190)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 21:50:03 +00:00
Taha Tesser
ccc3622e17
Fix M3 Tabs Specs links (#138808)
fixes [Material 3 Tab Specs links are broken/outdated ](https://github.com/flutter/flutter/issues/138805)
2023-11-21 21:46:07 +00:00
engine-flutter-autoroll
e791c4345c
Roll Flutter Engine from 0c2de1e8849c to 31799868224d (1 revision) (#138840)
0c2de1e884...3179986822

2023-11-21 matanlurey@users.noreply.github.com Make `{flow|fml|impeller}/...` compatible with `.clang_tidy`. (flutter/engine#48241)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 20:16:25 +00:00
engine-flutter-autoroll
85e509d035
Roll Flutter Engine from 746697c27569 to 0c2de1e8849c (1 revision) (#138834)
746697c275...0c2de1e884

2023-11-21 jonahwilliams@google.com [Impeller] preallocate command buffer to next power of two of entity list. (flutter/engine#48185)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 19:34:21 +00:00
engine-flutter-autoroll
ab721f935f
Roll Flutter Engine from 6da31e1bff67 to 746697c27569 (1 revision) (#138826)
6da31e1bff...746697c275

2023-11-21 30870216+gaaclarke@users.noreply.github.com [Impeller] implements gaussian "blur halo" (flutter/engine#48149)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 18:59:00 +00:00
Mahdi Bagheri
5ae1baeb97
Add mhbdev to AUTHORS (#138311)
Reference: [author:mhbdev](https://github.com/flutter/flutter/issues?q=author%3Amhbdev)
2023-11-21 17:36:53 +00:00
engine-flutter-autoroll
3cd723b496
Manual roll Flutter Engine from 70b1c7341255 to 6da31e1bff67 (10 revisions) (#138817)
Manual roll requested by zra@google.com

70b1c73412...6da31e1bff

2023-11-21 zanderso@users.noreply.github.com Revert Dart SDK to 3.3.0-152.0.dev (flutter/engine#48272)
2023-11-21 ditman@gmail.com [web] Add add/removeView JS methods. (flutter/engine#48106)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from c244996e79d6 to c6d971f87d12 (1 revision) (flutter/engine#48268)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from 516357c42907 to c244996e79d6 (1 revision) (flutter/engine#48266)
2023-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 99d9cf9bd05a to 5e7b22caba8a (1 revision) (flutter/engine#48264)
2023-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 64cbfa6c51e6 to 99d9cf9bd05a (1 revision) (flutter/engine#48261)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from 88a9e6328f93 to 516357c42907 (1 revision) (flutter/engine#48260)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from a26e5a5771c8 to 88a9e6328f93 (1 revision) (flutter/engine#48259)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from f8daeeb7f092 to a26e5a5771c8 (2 revisions) (flutter/engine#48258)
2023-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f1fd14505782 to 64cbfa6c51e6 (1 revision) (flutter/engine#48257)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 17:29:20 +00:00
Taha Tesser
e6d43ac6d4
Fix Chips with Tooltip throw an assertion when enabling or disabling (#138799)
fixes [Enabling or disabling a `Chip`/`RawChip` with a tooltip throws an exception](https://github.com/flutter/flutter/issues/138287) 

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    bool isEnabled = true;

    return MaterialApp(
      home: Material(
        child: Center(
          child: StatefulBuilder(
              builder: (BuildContext context, StateSetter setState) {
            return Column(
              mainAxisSize: MainAxisSize.min,
              children: [
                RawChip(
                  tooltip: 'This is a tooltip',
                  isEnabled: isEnabled,
                  label: const Text('RawChip'),
                  onPressed: isEnabled ? () {} : null,
                ),
                const SizedBox(height: 20),
                ElevatedButton(
                  onPressed: () {
                    setState(() {
                      isEnabled = !isEnabled;
                    });
                  },
                  child: Text('${isEnabled ? 'Disable' : 'Enable'} Chip'),
                )
              ],
            );
          }),
        ),
      ),
    );
  }
}
```

</details>
2023-11-21 17:00:06 +00:00
engine-flutter-autoroll
2a8eedf084
Roll Packages from c5443ad7e7e0 to c9933fc09a0b (2 revisions) (#138809)
c5443ad7e7...c9933fc09a

2023-11-20 engine-flutter-autoroll@skia.org Manual roll Flutter from 6cf9ab02baec to 9c9e0617b149 (15 revisions) (flutter/packages#5453)
2023-11-20 41930132+hellohuanlin@users.noreply.github.com Update CODEOWNERS (flutter/packages#5452)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 15:46:13 +00:00
engine-flutter-autoroll
b6ef78e955
Roll Flutter Engine from 3348fb0ca302 to 70b1c7341255 (1 revision) (#138774)
3348fb0ca3...70b1c73412

2023-11-21 33898039+designDo@users.noreply.github.com [PlatformView][Android]VirtualDisplay resize on Android31 and above (flutter/engine#47946)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 04:37:25 +00:00
engine-flutter-autoroll
2a216e334c
Roll Flutter Engine from f3e9b38a2588 to 3348fb0ca302 (1 revision) (#138772)
f3e9b38a25...3348fb0ca3

2023-11-21 matanlurey@users.noreply.github.com [Impeller] Try replacing `*desc` with value/is_valid checks. (flutter/engine#48194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 03:29:25 +00:00
engine-flutter-autoroll
889c08368c
Roll Flutter Engine from 39fb4581cff2 to f3e9b38a2588 (3 revisions) (#138770)
39fb4581cf...f3e9b38a25

2023-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from ee7aaca9adcc to f1fd14505782 (1 revision) (flutter/engine#48250)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from 3876e576a38e to f8daeeb7f092 (1 revision) (flutter/engine#48249)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from c9943f14039f to 3876e576a38e (3 revisions) (flutter/engine#48246)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 02:51:37 +00:00
Michael Goderbauer
24b99e5de8
Add dartdoc warnings (#138766)
Follow-up to https://github.com/flutter/flutter/pull/138760.
2023-11-21 01:02:00 +00:00
engine-flutter-autoroll
2e78cbce9c
Roll Flutter Engine from 6e8e55ef1a7f to 39fb4581cff2 (2 revisions) (#138765)
6e8e55ef1a...39fb4581cf

2023-11-20 matanlurey@users.noreply.github.com Make `runtime/...` and `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48158)
2023-11-20 63278936+hongeSunCoder@users.noreply.github.com Fix embedder glfw examples cmake subdirectory path error (flutter/engine#48013)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 00:18:26 +00:00
Mahdi Bagheri
1dafa400af
Added Features requested in #137530 (#137532)
This PR will add new parameters to `ExpansionTile` widget to manage `dense`, `visualDensity` and `enableFeedback` of the main ListTile.

Solves #137530 

It is not a breaking change.
2023-11-20 23:50:49 +00:00
Sam Rawlins
5350da6764
Bump dartdoc to 7.0.2 (#138760) 2023-11-20 23:43:08 +00:00
engine-flutter-autoroll
e002b2da73
Roll Flutter Engine from 7a31543b4630 to 6e8e55ef1a7f (4 revisions) (#138761)
7a31543b46...6e8e55ef1a

2023-11-20 matanlurey@users.noreply.github.com Silence a lint in `common/settings.h` in order to turn on `clang_tidy`. (flutter/engine#48239)
2023-11-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LnToEykA8o68jv58K... to Q3HcTitDF90ZOPWDa... (flutter/engine#48244)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 2bcc2e8682a6 to c9943f14039f (1 revision) (flutter/engine#48243)
2023-11-20 matanlurey@users.noreply.github.com Make `vulkan/...` compatible with `.clang_tidy`. (flutter/engine#48240)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LnToEykA8o68 to Q3HcTitDF90Z

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-20 23:39:06 +00:00
Taha Tesser
fc917c7184
[Reland] Introduce AnimationStyle (#138721)
This PR introduces `AnimationStyle`, it is used to override default
animation curves and durations in several widgets.

fixes [Add the ability to customize MaterialApp theme animation
duration](https://github.com/flutter/flutter/issues/78372)
fixes [Allow customization of showMenu transition animation curves and
duration](https://github.com/flutter/flutter/issues/135638)
fixes [`AnimationStyle.noAnimation` needs to replace `AnimatedTheme`
with just `Theme` in the
`MaterialApp`](https://github.com/flutter/flutter/issues/138618)

Here is an example where popup menu curve and transition duration is
overridden:

```dart
          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),
```

Set `AnimationStyle.noAnimation` to disable animation.
```dart
    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-11-20 15:24:41 -08:00
engine-flutter-autoroll
2c9d9665fa
Roll Flutter Engine from 337ab58e81f7 to 7a31543b4630 (2 revisions) (#138759)
337ab58e81...7a31543b46

2023-11-20 matanlurey@users.noreply.github.com [Impeller] Write a text-decoration test at the `dart:ui` layer (flutter/engine#48101)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 69213ba6f68a to 2bcc2e8682a6 (1 revision) (flutter/engine#48238)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-20 22:58:00 +00:00
Bruno Leroux
1a9e866f69
Reland update bottom navigation bar test for m3 (#137998)
This is a reland of https://github.com/flutter/flutter/pull/136624 which was reverted because one new M3 golden test failed. The failure was related to the ink sparkle animation.

Ink sparkle is the M3 default animation, it does not play well with golden because it introduces an element of randomness.
One way to avoid this randomness is to use the `InkSparkle.constantTurbulenceSeedSplashFactory`.

This PR has two commits:
- the first one is the original PR (https://github.com/flutter/flutter/pull/136624).
- the second one updates the failing test using `InkSparkle.constantTurbulenceSeedSplashFactory`.
2023-11-20 22:18:38 +00:00
engine-flutter-autoroll
9c9e0617b1
Roll Flutter Engine from 215853171cdc to 337ab58e81f7 (3 revisions) (#138751)
215853171c...337ab58e81

2023-11-20 reidbaker@google.com Protect sdk upload script from missing ndk, add documentation for checking write access, improve comments to add context (flutter/engine#47989)
2023-11-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 09bd5d71062d to ee7aaca9adcc (1 revision) (flutter/engine#48237)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 151d297efcf5 to 69213ba6f68a (2 revisions) (flutter/engine#48236)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-20 22:02:38 +00:00
engine-flutter-autoroll
5dbf7f30db
Roll Flutter Engine from 255f967a3938 to 215853171cdc (2 revisions) (#138746)
255f967a39...215853171c

2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from e9206d29ef07 to 151d297efcf5 (1 revision) (flutter/engine#48235)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 795a259c2f56 to e9206d29ef07 (3 revisions) (flutter/engine#48231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-20 21:18:09 +00:00
Chris Yang
f155db9b36
test owners: cyanglaz -> vashworth (#138726)
Temperarily transfer test owner to @vashworth 
Thank you Victoria!
2023-11-20 21:18:05 +00:00
Victoria Ashworth
e826c63aec
Fix file deletion crash in BuildIOSArchiveCommand.runCommand (#138734)
Fixes https://github.com/flutter/flutter/issues/138030
2023-11-20 19:25:17 +00:00