15202 Commits

Author SHA1 Message Date
Jonah Williams
8de62ab700
attempt to not skip coverage on post commit (#35246) 2019-06-28 11:09:36 -07:00
Tong Mu
94dbdcba73
benchmarkWidgets.semanticsEnabled default false. (#35280)
In order not to break existing benchmarks.
2019-06-28 11:03:16 -07:00
David Shuckerow
df6e4d4872
Make it possible to override the FLUTTER_TEST env variable (#34301)
* Make it possible to override the FLUTTER_TEST env variable without unsetting it.

* Switch to using platform instead of Platform.

* Document the bindings, and introduce tests that initialize multiple WidgetsBindings with different environments.

* Add tests for the flutter platform test.

* Add license headers

* Fix lints

* Remove trailing whitespace

* Respond to Jonahs comments

* Respond to Ians comments

* Mock out the HttpServer in flutter_platform_test

* Mock out the HttpServer in flutter_platform_test

* Explain why we mock out the HttpServer in flutter_platform_test
2019-06-28 10:37:27 -07:00
Todd Volkert
66273157f0
More preparation for HttpClientResponse implements Uint8List (#35245)
https://github.com/dart-lang/sdk/issues/36900
2019-06-28 09:58:15 -07:00
Todd Volkert
17c18da0c6
Revert "[Material] Support for hovered, focused, and pressed border color on OutlineButtons (#34872)" (#35276)
This reverts commit 3f9415998906a2465dc63a749cfe2fa05dad629c.
2019-06-28 09:18:30 -07:00
MH Johnson
3f94159989
[Material] Support for hovered, focused, and pressed border color on OutlineButtons (#34872)
* outline border implements material state property
2019-06-28 11:55:54 -04:00
hizzd
d780c2cff6 Fixed the LicensePage to close the page before loading the License causes an error (#34907) 2019-06-28 08:50:01 -07:00
engine-flutter-autoroll
fdcb57b69e
Roll engine 5c3c4336395d..98487198ba65 (2 commits) (#35266)
5c3c433639...98487198ba

git log 5c3c4336395def2a3d4b13fdd9d9bd846281be33..98487198ba65cc7c4031d1ed3effe1ec915e567a --no-merges --oneline
98487198b Roll fuchsia/sdk/core/linux-amd64 from DDMWCajukuC3EpOEXK31PCN2q7TWZHlaBiG1fZ6FkToC to hKK9H_q6Wr4qc_LULh6yowFyaqv8Ha-3JsuE05J4tpwC (flutter/engine#9574)
8024e7654 Roll src/third_party/skia b851469b8e96..afd2c10c989c (2 commits) (flutter/engine#9573)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-28 11:13:55 -04:00
engine-flutter-autoroll
e5e16406e5
5c3c43363 Roll fuchsia/sdk/core/mac-amd64 from 80DiQjMLrywJCY71q8_dXRFGwj8mszVpnwWHqqU1IZMC to jofgNhNmp-u51vpEXxTPuR89aL5DbLb-KNyK_Whh-ZAC (flutter/engine#9572) (#35264)
16578f76e5...5c3c433639

git log 16578f76e557e99d4b8e3ed430d4862838eafdc8..5c3c4336395def2a3d4b13fdd9d9bd846281be33 --no-merges --oneline
5c3c43363 Roll fuchsia/sdk/core/mac-amd64 from 80DiQjMLrywJCY71q8_dXRFGwj8mszVpnwWHqqU1IZMC to jofgNhNmp-u51vpEXxTPuR89aL5DbLb-KNyK_Whh-ZAC (flutter/engine#9572)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-28 09:27:55 -04:00
engine-flutter-autoroll
08a02fa9e9
16578f76e Roll fuchsia/sdk/core/linux-amd64 from N9HpdqEHzWZIcSV_3JN4PNlUNeoK-Pism-mc-a7L-IoC to DDMWCajukuC3EpOEXK31PCN2q7TWZHlaBiG1fZ6FkToC (flutter/engine#9571) (#35260)
5ed1414e56...16578f76e5

git log 5ed1414e564cf78a8026a1081e22dab5823dea4c..16578f76e557e99d4b8e3ed430d4862838eafdc8 --no-merges --oneline
16578f76e Roll fuchsia/sdk/core/linux-amd64 from N9HpdqEHzWZIcSV_3JN4PNlUNeoK-Pism-mc-a7L-IoC to DDMWCajukuC3EpOEXK31PCN2q7TWZHlaBiG1fZ6FkToC (flutter/engine#9571)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-28 07:09:55 -04:00
engine-flutter-autoroll
aee3a85c3d
5ed1414e5 Roll fuchsia/sdk/core/mac-amd64 from 6WJ2NCb9uaOzVw20XC4kJqNcD4EP2VxT-PBocGsA6JsC to 80DiQjMLrywJCY71q8_dXRFGwj8mszVpnwWHqqU1IZMC (flutter/engine#9569) (#35257)
4aaa1a9488...5ed1414e56

git log 4aaa1a948828bf2c322d10fb5c1bf4e954e1c228..5ed1414e564cf78a8026a1081e22dab5823dea4c --no-merges --oneline
5ed1414e5 Roll fuchsia/sdk/core/mac-amd64 from 6WJ2NCb9uaOzVw20XC4kJqNcD4EP2VxT-PBocGsA6JsC to 80DiQjMLrywJCY71q8_dXRFGwj8mszVpnwWHqqU1IZMC (flutter/engine#9569)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-28 06:05:55 -04:00
engine-flutter-autoroll
bbbd240635
Roll engine 185087a65f51..4aaa1a948828 (8 commits) (#35251)
185087a65f...4aaa1a9488

git log 185087a65f5104710399d107a5228636b558727c..4aaa1a948828bf2c322d10fb5c1bf4e954e1c228 --no-merges --oneline
4aaa1a948 Roll src/third_party/skia 842e92e29216..b851469b8e96 (6 commits) (flutter/engine#9568)
4e48fc47c Switched preprocessor logic for exporting symbols for testing. (NDEBUG (flutter/engine#9562)
50a8e7361 Has a binary messenger (flutter/engine#9419)
7483665e6 Re-enable embedder_unittests. (flutter/engine#9482)
773cf539f Roll fuchsia/sdk/core/linux-amd64 from SuKWYMSXAMq1uTo9eaIdIOQqBb7Ro-zLyNk01GPOiU8C to N9HpdqEHzWZIcSV_3JN4PNlUNeoK-Pism-mc-a7L-IoC (flutter/engine#9560)
c2fa689cd Roll src/third_party/skia d8f79a27b06b..842e92e29216 (108 commits) (flutter/engine#9558)
00c023b70 Roll fuchsia/sdk/core/mac-amd64 from dcGnduqJ5C8ozmUHeeboHC76nOv7s4XfCKIfefQlGkQC to 6WJ2NCb9uaOzVw20XC4kJqNcD4EP2VxT-PBocGsA6JsC (flutter/engine#9557)
7b9f59efd Run benchmarks on try jobs. (flutter/engine#9493)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-28 04:41:55 -04:00
Tong Mu
03ed06f44d
New benchmark: Gesture semantics (#35232)
* Add semanticsEnabled to widgetBenchmark
* Add button_matrix_app and gesture benchmark
2019-06-28 00:37:01 -07:00
Jonah Williams
95ca768976
Revert "Revert "Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066)" (#35237)" (#35242) 2019-06-27 22:58:54 -07:00
Jonah Williams
abc2923076
skip tools coverage on unrelated PRs (#35233) 2019-06-27 21:48:49 -07:00
Shi-Hao Hong
892043842e
child param doc update in Ink and Ink.image (#35211)
* Add doc suggesting Container for BoxDecorations that have no child widget
2019-06-27 19:37:20 -07:00
Jonah Williams
a1d3edc446
Twiggle bit to exclude dev and beta from desktop and web (#35221) 2019-06-27 19:04:02 -07:00
Jonah Williams
b43b8bab94
Revert "Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066)" (#35237) 2019-06-27 18:38:40 -07:00
Jonah Williams
3d77923b39
fix coverage collection to un-red build (#35231) 2019-06-27 17:47:20 -07:00
Gary Qian
9c01d3a9cc
Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066) 2019-06-27 15:37:13 -07:00
Todd Volkert
04e2f22650
Force-upgrade package deps (#35206) 2019-06-27 14:02:23 -07:00
Jonah Williams
c9b283386b
ensure test isolate is paused before collecting coverage (#35188) 2019-06-27 13:50:47 -07:00
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Zachary Anderson
31cf49a9c9
[flutter_tool] Update Fuchsia SDK (#35197) 2019-06-27 12:19:39 -07:00
engine-flutter-autoroll
62446badae
Roll engine 2bce4ed87a48..6f7700fc8382 (4 commits) (#35202)
2bce4ed87a...6f7700fc83

git log 2bce4ed87a48d3434ff19a39b1b70b5a94436d19..6f7700fc83827ef8adbd0966ed369a6cab549d9c --no-merges --oneline
6f7700fc8 fix FlutterOverlayView doesn't remove from superview in some cases (flutter/engine#9532)
f3cc37552 Roll fuchsia/sdk/core/mac-amd64 from XT8hP4vbTcjWCQU7H_kwgDtIt2lXCWVgJkMNU252lZ8C to dcGnduqJ5C8ozmUHeeboHC76nOv7s4XfCKIfefQlGkQC (flutter/engine#9538)
bc85f7302 Roll fuchsia/sdk/core/linux-amd64 from L_ORUWXyDEC29pSiSyKIwGqcFMQFsV91E3h_wPbUIUkC to SuKWYMSXAMq1uTo9eaIdIOQqBb7Ro-zLyNk01GPOiU8C (flutter/engine#9537)
bf3a3106c Roll fuchsia/sdk/core/mac-amd64 from Emw56Db0zg6Cnvgo7myIDZX0Lq-A6DFwEJHiPnr8K38C to XT8hP4vbTcjWCQU7H_kwgDtIt2lXCWVgJkMNU252lZ8C (flutter/engine#9531)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-27 15:18:56 -04:00
Jonah Williams
a0b2878e76
Make tool coverage collection resilient to sentinel coverage data (#35186) 2019-06-27 11:17:58 -07:00
engine-flutter-autoroll
24eabe1f91
Roll engine 0f9e297ad640..2bce4ed87a48 (2 commits) (#35171)
0f9e297ad6...2bce4ed87a

git log 0f9e297ad6400ef449df9ea7cc768f3e47b1a842..2bce4ed87a48d3434ff19a39b1b70b5a94436d19 --no-merges --oneline
2bce4ed87 Roll fuchsia/sdk/core/mac-amd64 from C8DMr5XY-F09ZBhT0lbvxOm5MtX3NMmFPKBO6fm40jEC to Emw56Db0zg6Cnvgo7myIDZX0Lq-A6DFwEJHiPnr8K38C (flutter/engine#9526)
264daccf9 Bump dart_resource_rev to f8e37558a1c4f54550aa463b88a6a831e3e33cd6 (flutter/engine#9518)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-27 13:56:39 -04:00
Jonah Williams
3cbb2d16b5
don't block any presubmit on coverage (#35192) 2019-06-27 10:10:37 -07:00
Yegor
c5f5b3c98a
Reuse matrix instance for transient transforms in _transformRect for fewer allocations (#35132) 2019-06-27 10:05:25 -07:00
rami-a
9166337698
Allow for customizing SnackBar's content TextStyle in its theme (#35075)
* Allow for customizing Snackbar's content TextStyle in its theme

* Address PR feedback

* Fix analyzer issues

* Address more PR feedback
2019-06-27 11:19:14 -04:00
Jonah Williams
8532f4d08e
Allow multi-root web builds (#34896)
* fix multiroot builds

* remove shout

* add basic test

* Update web_compilation_delegate.dart

* Address review feedback

* Update multiroot_asset_reader_test.dart

* Update multiroot_asset_reader_test.dart

* remove unpassable test

* fix for windows

* facepalm
2019-06-27 06:01:41 -07:00
Jonah Williams
92574d9572
Remove skip clause on tools coverage (#35157) 2019-06-27 06:00:25 -07:00
engine-flutter-autoroll
ef901c7a40
Roll engine f3761ba8d01f..0f9e297ad640 (2 commits) (#35165)
f3761ba8d0...0f9e297ad6

git log f3761ba8d01fc6213db44b702c3c38bfdc5c887a..0f9e297ad6400ef449df9ea7cc768f3e47b1a842 --no-merges --oneline
0f9e297ad Support image filter on paint (flutter/engine#9508)
f3ef1bd97 Roll fuchsia/sdk/core/mac-amd64 from ZZsO1TTl-976ngr5N8h6rRvXTbMO_3qyKDpbeOhE0dwC to C8DMr5XY-F09ZBhT0lbvxOm5MtX3NMmFPKBO6fm40jEC (flutter/engine#9516)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-27 04:02:39 -04:00
engine-flutter-autoroll
43b03127d4
Roll engine 8591bd32e6b6..f3761ba8d01f (4 commits) (#35154)
8591bd32e6...f3761ba8d0

git log 8591bd32e6b6cac4fe4e7487c3babdb907f459a3..f3761ba8d01fc6213db44b702c3c38bfdc5c887a --no-merges --oneline
f3761ba8d Roll fuchsia/sdk/core/mac-amd64 from pWygawI3vBzP9dYloEvKka8r1p0NpLLZzZQ-yMYI1UIC to ZZsO1TTl-976ngr5N8h6rRvXTbMO_3qyKDpbeOhE0dwC (flutter/engine#9510)
a83fe3e56 Roll Fuchsia SDK to latest (flutter/engine#9509)
63c2c3316 Improve caching limits for Skia (flutter/engine#9503)
8876f6e4b Revert Skia version to d8f79a27b06b5bce7a27f89ce2d43d39f8c058dc (flutter/engine#9507)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-26 23:27:39 -04:00
engine-flutter-autoroll
5e58628be2
8591bd32e Handle ambiguous directionality of final trailing whitespace in mixed bidi text (flutter/engine#9489) (#35148)
3aff2e3556...8591bd32e6

git log 3aff2e3556d24851e6c939e1daa4b733090e6a9f..8591bd32e6b6cac4fe4e7487c3babdb907f459a3 --no-merges --oneline
8591bd32e Handle ambiguous directionality of final trailing whitespace in mixed bidi text (flutter/engine#9489)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-26 21:22:39 -04:00
Kasper
b6349e7d9a Added onChanged property to TextFormField (#34932) 2019-06-26 18:13:53 -07:00
Todd Volkert
883d6eadcb
More HttpClientResponse implements Stream<Uint8List> fixes (#35149)
https://github.com/dart-lang/sdk/issues/36900
2019-06-26 16:56:10 -07:00
engine-flutter-autoroll
3ead8a402a
3aff2e355 [android] External textures must be rescaled to fill the canvas (flutter/engine#9501) (#35146)
238fc0f9f3...3aff2e3556

git log 238fc0f9f3423f3d64081d30f43ac45e857d4bd1..3aff2e3556d24851e6c939e1daa4b733090e6a9f --no-merges --oneline
3aff2e355 [android] External textures must be rescaled to fill the canvas (flutter/engine#9501)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-26 19:49:38 -04:00
Todd Volkert
d2c2f4c66b
More HttpClientResponse Uint8List fixes (#35143)
Follow-on change to https://github.com/flutter/flutter/pull/34863 (see that change
for context), whereby we ensure that we're properly dealing in `Uint8List`.

These necessary changes would have been caught by disabling implicit casts
in our analysis options.

dart-lang/sdk#36900
https://github.com/flutter/flutter/issues/13815
2019-06-26 16:11:04 -07:00
Jonah Williams
33ad5bac34
Attempt to enable tool coverage redux (#35074) 2019-06-26 16:02:49 -07:00
engine-flutter-autoroll
206d43de97
Roll engine 3f4f606105a8..238fc0f9f342 (11 commits) (#35135)
3f4f606105...238fc0f9f3

git log 3f4f606105a8f6217cfbe08e193aa9a54b19dbef..238fc0f9f3423f3d64081d30f43ac45e857d4bd1 --no-merges --oneline
238fc0f9f Roll src/third_party/skia 9dbbf887cee1..9acfb33ad8c6 (5 commits) (flutter/engine#9505)
e4ad3a2dc Roll src/third_party/skia 2c1662e24da7..9dbbf887cee1 (6 commits) (flutter/engine#9502)
d85599f03 Roll src/third_party/skia 4f35817f3c91..2c1662e24da7 (3 commits) (flutter/engine#9500)
9190a2284 Roll src/third_party/skia a7016ae7f03d..4f35817f3c91 (2 commits) (flutter/engine#9499)
2c8255f63 Roll src/third_party/skia 01cb2a422884..a7016ae7f03d (5 commits) (flutter/engine#9497)
da82361da Purge caches on low memory on iOS (flutter/engine#9491)
3122ecc62 Roll src/third_party/skia 0c4fbf1bbb93..01cb2a422884 (2 commits) (flutter/engine#9496)
2f1d4f03b fix build breakage on PlatformViews.mm (flutter/engine#9495)
1ab99fb35 fix a bug where the platform view&#39;s transform is not reset before set frame (flutter/engine#9490)
aa9b3a180 Reland &#34;IOS Platform view transform/clipping (#9075)&#34; and fix the breakage. (flutter/engine#9483)
d90573a9d Roll src/third_party/skia 69881fb0b5fb..0c4fbf1bbb93 (5 commits) (flutter/engine#9487)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-26 18:47:39 -04:00
miDeb
6cebd350f5 Remove duplicate error parts (#34919) 2019-06-26 14:56:09 -07:00
Dan Field
bb79ff3b49
More shards (#34877)
Shard tool_tests
2019-06-26 13:55:16 -07:00
Lau Ching Jun
cfe4d0d7b9
Add FlutterProjectFactory so that it can be overridden internally. (#35092)
Also update the comments since we don't return Future<FlutterProject>
anymore.
2019-06-26 13:29:53 -07:00
Dan Field
6d8a59c8ba
pass new users for release_smoke_tests (#35130) 2019-06-26 12:31:29 -07:00
Kate Lovett
f9118c0fd0
Preserving SafeArea : Part 2 (#34298)
* WIP

* Added tests and updated SafeArea implementation.

* Analyzer nits

* Review feedback

* Updated for SnackBar and PersistentFooterButton cases, added tests to check other potential spots.

* doc addition for SafeArea

* Typos
2019-06-26 12:29:50 -07:00
Lau Ching Jun
c8cefce300
Move findTargetDevices to DeviceManager (#35084)
This allows us to override the behavior internally.
2019-06-26 10:09:14 -07:00
Brian Egan
259151c39c
Add generated Icon diagram to api docs (#35046)
* Add generated Icon diagram to api docs
2019-06-26 18:16:16 +02:00
engine-flutter-autoroll
a644010eed
3f4f60610 Simplify loading of app bundles on Android (flutter/engine#9360) (#35087)
107fe82343...3f4f606105

git log 107fe823431a64302b63179ad5147e592d33a17f..3f4f606105a8f6217cfbe08e193aa9a54b19dbef --no-merges --oneline
3f4f60610 Simplify loading of app bundles on Android (flutter/engine#9360)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-06-26 11:43:39 -04:00
Danny Tuppeny
f3be1d9d95
Add emulatorID field to devices in daemon (#34794)
* Add emulatorId to Android and iOS emulator devices

* Update docs

* Review tweaks

* Add tests for AndroidConsole for getting avd names

* Remove unused import

* Remove duplicated header

* Fix imports
2019-06-26 16:39:23 +01:00