engine-flutter-autoroll
305a99501e
Roll engine ae8e6d9f4699..107fe823431a (6 commits) ( #35085 )
...
ae8e6d9f46...107fe82343#9075 )" (flutter/engine#9480 )
339001922 fix NPE when a touch event is sent to an unknown Android platform view (flutter/engine#9476 )
ebb5b909f IOS Platform view transform/clipping (flutter/engine#9075 )
13145e90c ios-unit-tests: Started using rsync instead of cp -R to copy frameworks. (flutter/engine#9471 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-06-25 18:20:39 -04:00
Josh Burton
577c2fc48c
Ensures flutter jar is added to all build types on plugin projects ( #34573 )
2019-06-25 10:40:55 -07:00
Alexandre Ardhuin
c7408be181
prepare for lint update of prefer_final_fields ( #35059 )
2019-06-25 19:39:34 +02:00
Emmanuel Garcia
2cf8213468
Break down flutter doctor validations and results ( #34624 )
2019-06-25 10:22:08 -07:00
Alexandre Ardhuin
b5ce06163c
enable lint use_full_hex_values_for_flutter_colors ( #35056 )
2019-06-25 17:58:19 +02:00
Alexandre Ardhuin
fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions ( #35055 )
2019-06-25 17:40:05 +02:00
Alexandre Ardhuin
9a3a7490c8
sync lint list ( #35017 )
2019-06-25 15:59:15 +02:00
engine-flutter-autoroll
1cf7b3e2c3
ae8e6d9f4 Removed unused imports in new embedding. (flutter/engine#9463) ( #35047 )
...
50b93f86be...ae8e6d9f46flutter/engine#9463 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-06-25 06:57:39 -04:00
engine-flutter-autoroll
e97b098ddd
Roll engine e29a1002888f..50b93f86beb0 (3 commits) ( #35043 )
...
e29a100288...50b93f86beflutter/engine#9472 )
2a7a355f1 Fixed logLevel filter bug so that filter now works as expected. (flutter/engine#9460 )
f76d664e5 Test cleanup geometry_test.dart (flutter/engine#9458 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-06-25 05:04:56 -04:00
engine-flutter-autoroll
0f2388e545
Roll engine b7dd1cdce95a..e29a1002888f (2 commits) ( #35037 )
...
b7dd1cdce9...e29a100288flutter/engine#9462 )
62acd7a44 Roll src/third_party/skia d8f79a27b06b..e2439cc929f9 (11 commits) (flutter/engine#9465 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-25 03:50:55 -04:00
LongCatIsLooong
326cd5e830
Add CupertinoTextField.onTap ( #34964 )
2019-06-24 21:02:53 -07:00
Jim Graham
f83fd9d467
Add test case for Flutter Issue #27677 as a benchmark. ( #34870 )
...
* Add test case for Flutter Issue #27677 as a benchmark.
See https://github.com/flutter/flutter/issues/27677
I got the following results running the test on a Moto E2 which
will help us determine how much we can gain by analyzing the
operations and eliminating unnecessary repaints based on
dirty rectangles/regions.
no blurs - avg 216.0 fps over 3 samples
blur the group - avg 22.9 fps over 3 samples
blur each txt - avg 3.4 fps over 3 samples
* Added the new benchmark to be tracked on the dashboard.
2019-06-24 20:53:22 -07:00
engine-flutter-autoroll
d5753ccd91
Roll engine b18847998196..b7dd1cdce95a (5 commits) ( #35029 )
...
b188479981...b7dd1cdce9flutter/engine#9469 )
a6e5b10f2 Forgot a usage of a variable in our script. (flutter/engine#9467 )
183a76b38 Added shebangs to ios unit test scripts. (flutter/engine#9464 )
56954457a Don't hang to a platform view's input connection after it's disposed (flutter/engine#9423 )
45ef6c8cf Remove unused/unimplemented shell constructor (flutter/engine#9459 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-24 23:30:55 -04:00
Shi-Hao Hong
ea4460df3c
OutlineInputBorder adjusts for borderRadius that is too large ( #34515 )
...
* Implement OutlineInputBorder BorderRadius scaling via RRect.scaleRadii
* Add regression test to test for border scaling
2019-06-24 15:40:32 -07:00
engine-flutter-autoroll
121eedb459
Roll engine 297cbd4b153b..b18847998196 (4 commits) ( #35020 )
...
297cbd4b15...b188479981flutter/engine#9403 )
a18403797 Send timings of the first frame without batching (flutter/engine#9424 )
215096cc2 Roll src/third_party/skia 91032f8cd7ea..d8f79a27b06b (16 commits) (flutter/engine#9457 )
52ebf4c42 Made sure that the run_tests script returns the right error code. (flutter/engine#9456 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-24 17:50:55 -04:00
Anthony
04bd87794d
[Material] Update slider gallery demo, including range slider ( #34597 )
...
Update the flutter_gallery Slider demo by aligning the text field in the first slider, adding range slider examples (including custom range thumbs), and separating single slider and range slider examples with tabs.
2019-06-24 17:10:11 -04:00
Anthony
a276ab3d6d
[Material] Properly call onChangeStart and onChangeEnd in Range Slider ( #34869 )
...
Fixes a bug in the Range Sider where the onChangeStart and onChangeEnd were not being called if the initial thumb selection came from a drag (rather than a tap).
2019-06-24 17:09:07 -04:00
engine-flutter-autoroll
afe790a7b7
Roll engine 4444c9cb6c9f..297cbd4b153b (4 commits) ( #35014 )
...
4444c9cb6c...297cbd4b15flutter/engine#9452 )
14d2954a5 Eliminate unused import in FlutterView (flutter/engine#9439 )
ccb5034d5 Generate weak pointers only in the platform thread (flutter/engine#9431 )
da29c0473 Roll src/third_party/skia 6ce447a4ec20..91032f8cd7ea (5 commits) (flutter/engine#9455 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-24 16:41:55 -04:00
Jonah Williams
25b5656969
Reland: rename web device ( #34885 )
2019-06-24 11:09:07 -07:00
Danny Tuppeny
8dbfc82bc7
Tweak the display name of emulators ( #34785 )
2019-06-24 11:41:02 +01:00
engine-flutter-autoroll
39597ce718
Roll engine 0f2ab22abb2c..4444c9cb6c9f (2 commits) ( #34970 )
...
0f2ab22abb...4444c9cb6cflutter/engine#9453 )
552a72932 Roll src/third_party/skia 38daf0be45e4..089f13f98286 (2 commits) (flutter/engine#9451 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-24 03:39:55 -04:00
engine-flutter-autoroll
5acfa81e00
0f2ab22ab Roll src/third_party/skia 8b5cf82dca37..38daf0be45e4 (1 commits) (flutter/engine#9448) ( #34961 )
...
1be3ee342c...0f2ab22abbflutter/engine#9448 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-24 02:28:56 -04:00
engine-flutter-autoroll
429726e391
Roll engine a41243dcac62..1be3ee342c8f (2 commits) ( #34960 )
...
a41243dcac...1be3ee342c#9447 )" (flutter/engine#9450 )
c29d3bae4 Revert "Roll fuchsia/sdk/core/linux-amd64 from udf6w2VmM5E8PyQm5ggugW_jjiEdWs-Xl6efeLf2JdkC to jQ8awqEtcZVdusV29crejq9iQikDKImqn-HGtb4h3dwC (#9443 )" (flutter/engine#9449 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-23 17:01:55 -04:00
Todd Volkert
bb6c3f8131
Remove flutter_tools support for old AOT snapshotting ( #34895 )
...
Android now exclusively uses ELF shared libraries, and
iOS uses assembly.
2019-06-22 19:30:24 -07:00
engine-flutter-autoroll
1a64e7650d
Roll engine 5429f40bf8c1..a41243dcac62 (3 commits) ( #34939 )
...
5429f40bf8...a41243dcacflutter/engine#9443 )
2a83c925f Roll fuchsia/sdk/core/mac-amd64 from Cx51FRV5TCoqQ9nfs4E2QMfYkJ1JWt7arQXhV01tr7cC to w-3t4XiGPWI6UnY7zV2vTMAbS83-U8is0P168iq230oC (flutter/engine#9447 )
044b2c2a7 Roll src/third_party/skia 641d2b6e62d9..8b5cf82dca37 (1 commits) (flutter/engine#9444 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-22 21:53:55 -04:00
engine-flutter-autoroll
347a9d38ee
Roll engine 4b391cbe7e0a..5429f40bf8c1 (2 commits) ( #34936 )
...
4b391cbe7e...5429f40bf8#9442 )" (flutter/engine#9446 )
38078dfcd Roll fuchsia/sdk/core/mac-amd64 from Cx51FRV5TCoqQ9nfs4E2QMfYkJ1JWt7arQXhV01tr7cC to e8sS_5Rpuo7cSjSWPCdxwTEAg2VbS9NPH2tjhBhPwsUC (flutter/engine#9442 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-22 20:39:55 -04:00
engine-flutter-autoroll
9a06a7b5e2
Roll engine c46d8c0a155a..4b391cbe7e0a (2 commits) ( #34923 )
...
c46d8c0a15...4b391cbe7eflutter/engine#9441 )
a98612600 Roll src/third_party/skia 6bbeb4ab7222..31d587474367 (1 commits) (flutter/engine#9440 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-22 10:59:55 -04:00
engine-flutter-autoroll
1696538101
c46d8c0a1 Update README.md for consistency with framework (flutter/engine#9428) ( #34910 )
...
5153075e5f...c46d8c0a15flutter/engine#9428 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-22 04:38:55 -04:00
engine-flutter-autoroll
c1562c9958
5153075e5 Roll src/third_party/skia f3881b278e69..6bbeb4ab7222 (1 commits) (flutter/engine#9438) ( #34903 )
...
d004bcd4d6...5153075e5fflutter/engine#9438 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-22 01:25:55 -04:00
engine-flutter-autoroll
d51fd86cdb
Roll engine fa16babc4537..d004bcd4d619 (5 commits) ( #34898 )
...
fa16babc45...d004bcd4d6#9406 )" (flutter/engine#9437 )
264d6d578 Reland Update harfbuzz to 2.5.2 (flutter/engine#9406 )
f6389583f Ios unit tests choose engine (flutter/engine#9432 )
8f20c1bd5 Roll src/third_party/skia 893403fb3896..f3881b278e69 (9 commits) (flutter/engine#9434 )
6d2d9c88f Resolves embedding log chattyness by gating verbose, debug, and info logs by level (#34876 ). (flutter/engine#9425 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-21 22:31:55 -04:00
engine-flutter-autoroll
4f4709c9e6
fa16babc4 Use goma-aware Fuchsia clang toolchain (flutter/engine#9430) ( #34893 )
...
e32307e9f1...fa16babc45flutter/engine#9430 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-21 21:21:55 -04:00
engine-flutter-autoroll
295bc0ada2
Roll engine a9a0b89b1c82..e32307e9f140 (7 commits) ( #34892 )
...
a9a0b89b1c...e32307e9f1#9406 )" (flutter/engine#9429 )
780343a22 Update harfbuzz to 2.5.2 (flutter/engine#9406 )
3757f1992 delegate checkInputConnectionProxy to the relevant platform view (flutter/engine#9426 )
d9dfad3b8 Roll src/third_party/skia 8676929c0a13..893403fb3896 (6 commits) (flutter/engine#9421 )
91e31dca5 Made the license check ignore the .vscode directory. (flutter/engine#9398 )
24c3f513f Roll src/third_party/skia a1d26a807798..8676929c0a13 (9 commits) (flutter/engine#9416 )
e33f83edb Roll src/third_party/skia e3beb99f39f0..a1d26a807798 (1 commits) (flutter/engine#9411 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-21 20:12:55 -04:00
Todd Volkert
e8270ff661
Prepare for HttpClientResponse Uint8List SDK change ( #34863 )
...
* Prepare for HttpClientResponse Uint8List SDK change
An upcoming change in the Dart SDK will change `HttpClientResponse`
from implementing `Stream<List<int>>` to instead implement
`Stream<Uint8List>`.
This forwards-compatible change to `_MockHttpClientResponse` is being
made to allow for a smooth rollout of that SDK breaking change. The
current structure of the class is as follows:
```dart
_MockHttpClientResponse extends Stream<List<int>> implements HttpClientResponse {
...
}
```
This structure would require that the Dart SDK change land atomically
a change to the class (`extends Stream<Uint8List>`). This atomic landing
requirement doesn't play well at all with Flutter's roll model vis-a-vis
the Dart SDK's roll model to Google's internal repo. As such, this commit
changes the structure of `_MockHttpClientResponse` to be:
```dart
_MockHttpClientResponse implements HttpClientResponse {
final Stream<Uint8List> _delegate;
...
}
```
Once the Dart SDK change has fully rolled out, we can simplify this class
back to its former structure.
https://github.com/dart-lang/sdk/issues/36900
* Review comment
2019-06-21 17:01:32 -07:00
Jonah Williams
d644015620
Revert "set web device name to Chrome ( #34856 )" ( #34884 )
2019-06-21 15:04:44 -07:00
Jonah Williams
19d7925f1f
set web device name to Chrome ( #34856 )
2019-06-21 14:26:25 -07:00
Dan Field
3630525673
Shard gradle tests ( #34857 )
2019-06-21 12:05:06 -07:00
Justin McCandless
63438b9244
Fix Vertical Alignment Regression ( #34859 )
...
Change the way outlined inputs vertically align their text to be more similar to how it used to be before a refactor. Fixes an edge case uncovered by a SCUBA test.
2019-06-21 11:24:54 -07:00
engine-flutter-autoroll
2dd1418cb6
a9a0b89b1 Roll src/third_party/skia 5549cb00a2cf..e3beb99f39f0 (4 commits) (flutter/engine#9410) ( #34845 )
...
9c5d08fc77...a9a0b89b1cflutter/engine#9410 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-21 06:00:55 -04:00
engine-flutter-autoroll
39f254d0b8
9c5d08fc7 Roll src/third_party/skia 0c64a545176a..5549cb00a2cf (1 commits) (flutter/engine#9408) ( #34832 )
...
950d4813b5...9c5d08fc77flutter/engine#9408 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-21 01:37:55 -04:00
Dan Field
2ee297b0d0
Fix source-links ( #34831 )
2019-06-20 22:08:52 -07:00
engine-flutter-autoroll
6dbd3f690e
950d4813b Clamp when overflowing z bounds (flutter/engine#9402) ( #34830 )
...
cd973f8aae...950d4813b5flutter/engine#9402 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-21 00:15:55 -04:00
engine-flutter-autoroll
7742572106
Roll engine 0c874c62d0ad..cd973f8aaeae (2 commits) ( #34828 )
...
0c874c62d0...cd973f8aae#34751 ). (flutter/engine#9391 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-20 23:09:55 -04:00
engine-flutter-autoroll
40a1db6bbe
Roll engine 3b52992902ee..0c874c62d0ad (3 commits) ( #34827 )
...
3b52992902...0c874c62d0flutter/engine#9343 )
605c63be9 Roll src/third_party/skia 384981be3dd2..0c64a545176a (11 commits) (flutter/engine#9404 )
7a5ec8d79 Remove build flags for dynamic patching (flutter/engine#9394 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-20 21:59:55 -04:00
Dan Field
1e05bb5b5d
Make docs do less work/be less flaky ( #34818 )
2019-06-20 17:59:37 -07:00
engine-flutter-autoroll
2e0d6f77a3
Roll engine 14c3c79f573d..3b52992902ee (2 commits) ( #34816 )
...
14c3c79f57...3b52992902flutter/engine#9395 )
7fc828d1a Workaround fix the platform view dismiss crash related to gl (flutter/engine#9377 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-20 17:36:56 -04:00
Dan Field
a0fc3f3150
Shard framework tests ( #34812 )
2019-06-20 14:35:33 -07:00
Jonah Williams
25a3121dfd
Prefer ephemeral devices from command line run ( #34802 )
2019-06-20 14:33:58 -07:00
engine-flutter-autoroll
4c56b66fce
Roll engine a82751503fa6..14c3c79f573d (3 commits) ( #34813 )
...
a82751503f...14c3c79f57flutter/engine#9376 )
e6d355221 [glfw] Implement SystemNavigator.pop (flutter/engine#9365 )
9b130a4bf Roll src/third_party/skia b520476ee6dc..4918bbcbfd54 (4 commits) (flutter/engine#9393 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-06-20 16:29:55 -04:00
Emily Fortuna
bd9c900fce
Added some Widgets of the Week Videos to documentation ( #34758 )
...
* Added some Widgets of the Week to documentation: AspectRatio and AnimatedIcon.
2019-06-20 12:58:41 -07:00
Dan Field
71b9d461c8
Fix inline text span semantics ( #34434 )
2019-06-20 12:26:06 -07:00
