Dan Field
5b2281e747
Make Flex only overflow on epsilon ( #31890 )
2019-05-01 17:28:33 -07:00
xster
b04d38be1b
Fix commit message UTF issue for deploy_gallery shard too ( #31885 )
2019-05-01 16:43:23 -07:00
engine-flutter-autoroll
11de99f4da
Roll engine 6280d4266983..beeb56b43dc8 (4 commits) ( #31937 )
...
6280d42669...beeb56b43dflutter/engine#8803 )
e5305f422 Roll src/third_party/skia 6c8f5b31ac49..6db27c28c61e (4 commits) (flutter/engine#8802 )
ed7d128d7 Reformat dart dependencies in DEPS. (flutter/engine#8800 )
ed912a01d Roll src/third_party/dart 5fbf7720f8..b6997deb3e (26 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-05-01 19:38:17 -04:00
Shi-Hao Hong
8959caa239
Update scrimDrawerColor with proper const format ( #31938 )
2019-05-01 15:18:08 -07:00
Dan Field
cfc3572572
make windows/mac consistent with linux ( #31936 )
2019-05-01 15:18:03 -07:00
Diego Velásquez López
d8bb880d08
added scrimColor property in Scaffold widget ( #31025 )
2019-05-01 14:50:52 -07:00
Shi-Hao Hong
7690bb47dc
Add Horizontal Padding to Constrained Chip Label Calculations ( #31861 )
...
* Add horizontal padding and properly constrain chip label calculations
* Added regression test for avatar, label and delete icon constraint
2019-05-01 13:46:36 -07:00
Dan Field
df669ab1ea
Avoid NPE for flutter attach mDNS ( #31926 )
2019-05-01 13:41:00 -07:00
Zachary Anderson
6a69f8c98c
[fuchsia] Add support for the 'device' command using the SDK ( #31910 )
2019-05-01 13:24:09 -07:00
Jonah Williams
06973f58a7
Revert "Revert "fix edge swiping and dropping back at starting point ( #31623 )" ( #31876 )" ( #31923 )
2019-05-01 12:53:04 -07:00
Shi-Hao Hong
0c871b8528
Improve RadioListTile Callback Behavior Consistency ( #31574 )
2019-05-01 12:52:52 -07:00
Greg Spencer
be75fb36c5
Change unfocus to unfocus the entire chain, Fix setFirstFocus ( #31909 )
...
In #31614 , I added an unfocus() to FocusNodes to allow giving up of focus, but it only worked on the primary focus. This changes that so that it will unfocus the entire chain, not just the primary focus. Now, if you call unfocus() on a FocusNode or FocusScopeNode, and their hasFocus returns true, then after calling unfocus(), it will return false. Before this change, it would only do that if hasPrimaryFocus was also true.
This also fixes a bug in the way setFirstFocus was implemented, making it conform more to the behavior of the previous implementation. It has simplified logic in reparent, and in when it requests focus for scope nodes that have had setFirstFocus called on them.
2019-05-01 12:20:41 -07:00
Jacob Richman
63aa5b3647
Refactor core uses of FlutterError. ( #30983 )
...
Make FlutterError objects more structured so they can be displayed better in debugging tools such as Dart DevTools.
2019-05-01 11:20:12 -07:00
engine-flutter-autoroll
f8dfa367c6
Roll engine 8768180a8871..6280d4266983 (2 commits) ( #31917 )
...
8768180a88...6280d42669flutter/engine#8796 )
c67870cfd Roll src/third_party/skia 08c79d61450b..6c8f5b31ac49 (4 commits) (flutter/engine#8799 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-05-01 14:17:17 -04:00
Todd Volkert
3d09f939ba
Make Gradle error message more specific ( #31850 )
2019-05-01 10:28:57 -07:00
Victor Maraccini
74c6237abc
Fix bundle id on iOS launch using flutter run ( #31039 )
2019-05-01 10:21:43 -07:00
rami-a
6a1468db16
Add BottomSheetTheme to enable theming color, elevation, shape of BottomSheet ( #31318 )
...
* Introduce BottomSheetTheme and shape support for bottom sheet
* Add bottom sheet theme to ThemeData. Use theme in bottom sheet build
* Expose color, elevation, shape to showModalBottomSheet helper
* Expose color, elevation, shape to showBottomSheet helper
* Address PR feedback
* Address PR feedback
* Address additional PR feedback
2019-05-01 13:10:50 -04:00
Jonah Williams
60a1b2b9ea
Revert "Redo: Add buttons to gestures ( #31819 )" ( #31912 )
...
This reverts commit fea2c7d671633fea21bfc93ccddbb57c4510752f.
2019-05-01 10:06:45 -07:00
engine-flutter-autoroll
df4dc7cd38
8768180a8 Roll src/third_party/skia e6a83e160860..08c79d61450b (1 commits) (flutter/engine#8797) ( #31887 )
...
2f11d3c4a2...8768180a88flutter/engine#8797 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-05-01 13:01:17 -04:00
Emmanuel Garcia
3e65bb060f
Fix #31764 : Show appropriate error message when fonts pubspec.yaml isn't iterable
...
Show appropriate error message when fonts isn't iterable
2019-05-01 09:49:39 -07:00
Dan Field
a8504405a8
Revert "Handle notification errors ( #31868 )" ( #31886 )
...
This reverts commit c0d5fd23ab85152575cd32190008d257bb11a3d4.
2019-04-30 23:27:30 -07:00
Jonah Williams
c82fc132a8
add stderr to log processor for desktop ( #31874 )
2019-04-30 19:18:15 -07:00
engine-flutter-autoroll
b5e206e520
Roll engine f2d21795be43..2f11d3c4a205 (2 commits) ( #31882 )
...
f2d21795be...2f11d3c4a2flutter/engine#8795 )
1219e5c7d Re-create texture from pixel buffer onGrContextCreate (flutter/engine#8792 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-30 20:42:52 -04:00
Gary Qian
4102486d63
Center iOS caret, remove constant offsets that do not scale ( #31687 )
2019-04-30 17:41:01 -07:00
engine-flutter-autoroll
785df2798f
Roll engine 59b91392e20a..f2d21795be43 (3 commits) ( #31877 )
...
59b91392e2...f2d21795beflutter/engine#8793 )
5e5705000 Roll src/third_party/skia 836ff5e40560..f808c5e3afa3 (11 commits) (flutter/engine#8791 )
5a9e87457 Roll src/third_party/skia 494aa3db9e78..836ff5e40560 (2 commits) (flutter/engine#8788 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-30 19:52:53 -04:00
chunhtai
e2dfd73c2e
only build asset when there is asset declared in pubspec ( #31804 )
2019-04-30 16:03:47 -07:00
Jonah Williams
514fb2c7c0
Revert "fix edge swiping and dropping back at starting point ( #31623 )" ( #31876 )
2019-04-30 15:44:09 -07:00
Dan Field
4bc35fc87a
Allow DSS to be dragged when its children do not fill extent ( #31832 )
...
* Allow DSS to be dragged when its children do not fill extent
* Fix when maxChildSize < 1.0
2019-04-30 15:42:42 -07:00
Dan Field
c0d5fd23ab
Handle notification errors ( #31868 )
2019-04-30 15:42:22 -07:00
Jonah Williams
5e77d6508e
Initial sketch of tools testbed ( #31765 )
2019-04-30 15:42:16 -07:00
Jonah Williams
48936d9a95
Remove deprecated commands ( #31759 )
2019-04-30 14:43:03 -07:00
liyuqian
fb87619143
Fix prefer_const_constructors ( #31860 )
...
This will fix our flutter build post-submit analyze test
Merge on red to fix flutter build
2019-04-30 10:38:26 -07:00
Tong Mu
fea2c7d671
Redo: Add buttons to gestures ( #31819 )
...
* Revert "Revert "Add buttons to gestures (#30339 )" (#31801 )"
This reverts commit 8fd7fa492aaad0d0d4aa062d71b1ecba8b0d4f44.
* Synthesise kPrimaryButton for unknown devices
* Change TestPointer to a better API
2019-04-30 09:56:24 -07:00
liyuqian
71a89a469a
Reland "Fix text field selection toolbar under Opacity ( #31097 )" ( #31802 )
...
This reverts commit 120a1fc47f7379de556e02d3eb5b49ccd78a28b6.
Updated the golden file
2019-04-30 09:47:32 -07:00
liyuqian
7cab6d5e1c
Support clipBehavior changes in hot reload ( #31761 )
...
## Description
Make `_RenderCustomClip`'s `clipBehavior` non-final so we can update it during `updateRenderObject`. This will support `clipBehavior` changes in hot reload.
## Related Issues
Fixes #30863
## Tests
I added the following tests:
* ClipRect updates clipBehavior in updateRenderObject
* ClipRRect updates clipBehavior in updateRenderObject
* ClipOval updates clipBehavior in updateRenderObject
* ClipPath updates clipBehavior in updateRenderObject
* PhysicalModel updates clipBehavior in updateRenderObject
* PhysicalShape updates clipBehavior in updateRenderObject
2019-04-30 09:46:38 -07:00
Keerti Parthasarathy
eae67f05df
Make const available for classes that override AssetBundle ( #31807 )
2019-04-30 09:10:04 -07:00
engine-flutter-autoroll
9937d3dfb1
59b91392e Roll src/third_party/skia a6d723f32f32..494aa3db9e78 (1 commits) (flutter/engine#8787) ( #31847 )
...
64b1d38081...59b91392e2flutter/engine#8787 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-30 10:40:53 -04:00
engine-flutter-autoroll
8e7c7fcbd4
64b1d3808 Roll src/third_party/skia 79e53712a05f..a6d723f32f32 (3 commits) (flutter/engine#8785) ( #31830 )
...
c0036315d4...64b1d38081flutter/engine#8785 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-30 06:30:38 -04:00
Greg Spencer
0245a29a04
Keycode generation doc fix ( #31493 )
...
Fixes a typo in the key generator readme.
Updated the examples in the readme to reflect that the examples were for physical key codes, where we're actually talking about logical key codes there.
2019-04-29 21:45:30 -07:00
engine-flutter-autoroll
bc9b56a35d
Roll engine 1ecf924ff861..c0036315d4ca (5 commits) ( #31823 )
...
1ecf924ff8...c0036315d4flutter/engine#8783 )
5aa5b6cbf VirtualDisplay size constraint - add a comment explaining the reason (flutter/engine#8780 )
ee3f04ac8 Roll src/third_party/skia 037884e5080b..bd425405f3aa (3 commits) (flutter/engine#8781 )
ab01d7396 Roll src/third_party/skia d425dee662d1..037884e5080b (10 commits) (flutter/engine#8778 )
a0bb23aad Fix header include guards for fml/thread_local.h (flutter/engine#8721 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-30 00:43:38 -04:00
Dan Field
eac2104bc6
remove assert for Flutter Driver ( #31815 )
2019-04-29 17:03:25 -07:00
Shi-Hao Hong
39712854fc
Fix ExpansionPanelList Duplicate Global Keys Exception ( #31228 )
...
- Move `setState` to only be invoked when guarded by `widget._allowMultiplePanelsOpen`, fixing the case for `ExpansionPanelList`
- Remove setting `_currentOpenPanel` to `widget.initialOpenPanelValue` in `didUpdateWidget`, since this should only occur on `initState` and not every time the widget is updated. This fixes the problem for `ExpansionPanelList.radio`
- Added a `didUpdateWidget` condition for when `ExpansionPanelList` changes into `ExpansionPanelList.radio` to open the panel at `widget.initialOpenPanelValue`
- Added test cases for regression, expansionCallback cases, and `didUpdateWidget` transitions between `ExpansionPanelList` and `ExpansionPanelList.radio`
2019-04-29 16:55:05 -07:00
Jonah Williams
37e25238a8
Attempt to reduce usage of runtimeType ( #31696 )
2019-04-29 16:44:50 -07:00
Dan Field
fe9512fa72
Re-enable const ( #31600 )
...
* Re-enable const
2019-04-29 16:02:42 -07:00
Jonah Williams
8fd7fa492a
Revert "Add buttons to gestures ( #30339 )" ( #31801 )
...
This reverts commit 727e7e829f4debf7a7aaaad3c37151b362ed4cba.
2019-04-29 12:59:30 -07:00
Jonah Williams
120a1fc47f
Revert "Fix text field selection toolbar under Opacity ( #31097 )" ( #31800 )
2019-04-29 12:57:35 -07:00
liyuqian
e427c2dd86
Fix text field selection toolbar under Opacity ( #31097 )
...
## Description
As we've introduced offset to the Opacity layer, we have to override
`applyTransform` to make Leader/FollowerLayer work correctly.
## Related Issues
Fixes https://github.com/flutter/flutter/issues/30587
Together with https://github.com/flutter/engine/pull/8585 ,
this test will also exercise test against
https://github.com/flutter/flutter/issues/30586 .
## Tests
I added the following tests:
* text field selection toolbar renders correctly inside opacity
2019-04-29 11:25:41 -07:00
xster
d12f359991
fix edge swiping and dropping back at starting point ( #31623 )
2019-04-29 11:05:24 -07:00
Tong Mu
727e7e829f
Add buttons to gestures ( #30339 )
...
* Callbacks of tap, long press, drag, and double tap GR respond to only primary events.
* Add "secondary" callbacks to tap.
* Recognizers only compete on events if there are any related callbacks.
* Add "kSecondaryButton" constant.
2019-04-29 10:46:33 -07:00
Jonah Williams
c1c15dd702
Revert "update packages and unpin build ( #31736 )" ( #31795 )
2019-04-29 09:56:55 -07:00
