firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,594 Commits 1 Branch 0 Tags
Commit Graph

27903 Commits

Author SHA1 Message Date
Srujan Gaddam
5ba4b01dfe Initial pass to cleanup dom.dart to use newer JS interop styles (flutter/engine#54093) 
This only addresses the following:

- Removes `JSVoid` in favor of `void`. `JSVoid`, which is just a
typedef, should be deprecated and removed eventually.
- Removes extra interop methods that were needed to make sure arity was
correct. These are no longer needed as interop methods are
invocation-sensitive and calls to them do not forward more arguments
than were passed by the user.
- Removes unnecessary annotations on extensions.

Still left to do (not comprehensive):

- Migrate to extension types.
- Remove forwarding methods that are only used to convert primitives in
favor of changing the interop method to include the Dart primitive type.
It might be a bit slower in dart2wasm to do this, but will need to
verify and fix it if that's the case.
- Remove usage of `js_util`.
- See if we can replace types with their `package:web` equivalent for
easier maintenance.
 2024-07-25 13:10:31 -07:00
Jonah Williams
d771655992 [iOS] enable FlutterMetalLayer. (flutter/engine#54121) 
Re-enabled now that the retain cycle is fixed.
 2024-07-25 20:06:17 +00:00
Matej Knopp
f0901b70fc Fix retain cycle in FlutterMetalLayer (flutter/engine#54119) 
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-25 19:00:19 +00:00
skia-flutter-autoroll
b0dfbbd8ef Roll Dart SDK from 3d584310ee21 to 529fda259fdf (1 revision) (flutter/engine#54117) 
https://dart.googlesource.com/sdk.git/+log/3d584310ee21..529fda259fdf

2024-07-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-82.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-25 18:34:20 +00:00
Robert Ancell
613b0b2fb2 Remove unused virtual methods (flutter/engine#54074) 2024-07-26 04:51:12 +12:00
skia-flutter-autoroll
3c471f7a62 Roll Skia from 75994403a8a4 to 529569ce068a (1 revision) (flutter/engine#54111) 
https://skia.googlesource.com/skia.git/+log/75994403a8a4..529569ce068a

2024-07-25 sunnyps@chromium.org graphite: Skip adding genID listeners for immutable bitmaps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-25 15:52:20 +00:00
skia-flutter-autoroll
c953a6c665 Roll Dart SDK from a9eb9553033c to 3d584310ee21 (1 revision) (flutter/engine#54110) 
https://dart.googlesource.com/sdk.git/+log/a9eb9553033c..3d584310ee21

2024-07-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-81.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-25 14:19:23 +00:00
skia-flutter-autoroll
83e0130143 Roll Dart SDK from 8389a7bb94f4 to a9eb9553033c (1 revision) (flutter/engine#54107) 
https://dart.googlesource.com/sdk.git/+log/8389a7bb94f4..a9eb9553033c

2024-07-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-80.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-25 09:35:25 +00:00
skia-flutter-autoroll
e66943f682 Roll Fuchsia Linux SDK from qA7S-DZ5FyMtcM7_J... to pkL7F9aPLbFBRhsoL... (flutter/engine#54103) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-25 08:32:22 +00:00
skia-flutter-autoroll
0552547379 Roll Skia from 746d444f3efd to 9942b4423e4d (4 revisions) (flutter/engine#54104) 
https://skia.googlesource.com/skia.git/+log/746d444f3efd..9942b4423e4d

2024-07-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b98c4d810794 to 4f498eaa1426 (7 revisions)
2024-07-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 90fdaa810322 to 39b828ef334f (17 revisions)
2024-07-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d77400c7282a to f5059dc8d77f (12 revisions)
2024-07-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d77400c7282a to f5059dc8d77f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-25 08:18:37 +00:00
Robert Ancell
385b900221 Allow creating views from an external engine (flutter/engine#54080) 
While only one view works at this point in the future this will allow a runner to create multiple views.
 2024-07-25 19:45:37 +12:00
Robert Ancell
12a4ffb403 Support multiple views in FlRenderer (flutter/engine#54072) 2024-07-25 19:44:52 +12:00
skia-flutter-autoroll
fa49d72914 Roll Dart SDK from 693848f200d7 to 8389a7bb94f4 (1 revision) (flutter/engine#54100) 
https://dart.googlesource.com/sdk.git/+log/693848f200d7..8389a7bb94f4

2024-07-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-25 05:20:24 +00:00
Yegor
7de2134117 [web] better class names for semantics (flutter/engine#54070) 
A few non-functional clean-ups in semantics:

* Rename `RoleManager` to `SemanticBehavior`.
* Rename `PrimaryRoleManager` to `SemanticRole`.
* Remove the `Role` enum. Move the enum docs into the respective classes.

## Why?

Previous naming was confusing. It's not clear what the difference is between a "role manager" and a "primary role manager". The word "manager" is a meaningless addition; the `Semantic*` prefix is much more meaningful. The `Role` enum was only used for tests, but tests can just use `SemanticRole.runtimeType`.

## New state of the world

After this PR the semantics system has "objects" (class `SemanticsObject`), "roles" (class `SemanticRole`), and "behaviors" (class `SemanticBehavior`).

- A semantic _object_ is an object attached to the framework-side `SemanticNode`. It lives as long as the semantic node does, and provides basic functionality that's common across all nodes.
- A semantic object has exactly one semantic _role_. This role is determined from the flags set on the semantic node. Flags can change, causing a semantic object to change its role, which is why these are two separate classes. If an object had just one permanent role, we could combine these classes into one (maybe one day we'll do it, as changing roles dynamically is weird, but that needs major changes in the framework).
- A semantic role may have zero or more semantic _behaviors_. A behavior supplies a piece of functionality, such as focusability, clickability/tappability, live regions, etc. A behavior can be shared by multiple roles. For example, both `Button` and `Checkable` roles use the `Tappable` behavior. This is why there's a many-to-many relationship between roles and behaviors.

Or in entity relationship terms:

```mermaid
---
title: Semantic object relationships
---
erDiagram
    SemanticsNode ||--|| SemanticsObject : managed-by
    SemanticsObject ||--o{ SemanticRole : has-a
    SemanticRole }o--o{ SemanticBehavior : has
```
 2024-07-25 02:42:05 +00:00
Jonah Williams
f4ca71ce57 Disable FlutterMetalLayer by default. (flutter/engine#54095) 
Backing textures aren't getting deallocated, which is causing memory leaks and crashing devicelab.
 2024-07-25 02:34:16 +00:00
skia-flutter-autoroll
dc9ff41cb8 Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 
https://dart.googlesource.com/sdk.git/+log/0b3c00feefb1..693848f200d7

2024-07-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-78.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-25 01:17:27 +00:00
Greg Spencer
b5648f9fb0 Remove incorrect line (flutter/engine#54021) 
## Description

Removes a line that shadows setting the device type correctly for keyboard events.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/151308
 2024-07-25 01:03:16 +00:00
Zachary Anderson
1bddf3416d [et] Better RBE defaults (flutter/engine#54059) 
This PR adopts some RBE configuration from the way that chromium uses RBE

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/refs/heads/main/reclient_helper.py

These changes should bias both local and CI builds more towards using the worker pool, which we recently expanded, and should help limit the bandwidth used, which is a bottleneck for build times on a slow connection.
 2024-07-24 23:15:56 +00:00
skia-flutter-autoroll
897f8dc11d Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 
https://skia.googlesource.com/skia.git/+log/55ecdde3a5fa..746d444f3efd

2024-07-24 johnstiles@google.com Avoid using optional<> for ModuleType.
2024-07-24 johnstiles@google.com Add Analysis::FindSpecializedArgumentsForCall helper function.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 23:12:03 +00:00
Jonah Williams
80fd1f7fbf [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 
For this to work, we need to provide our own capture scope otherwise the default scope won't capture our commands.

This is required as part of the work to switch to unmerged threads for PVs (https://github.com/flutter/engine/pull/53826), as I can confirm @knopp 's observations that the performance is much worse with the default CAMetalLayer.

Fixes https://github.com/flutter/flutter/issues/140901
 2024-07-24 23:10:11 +00:00
skia-flutter-autoroll
274cf5f243 Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) 
https://skia.googlesource.com/skia.git/+log/54d1434637a1..55ecdde3a5fa

2024-07-24 jvanverth@google.com Update comment in patheffects.cpp.
2024-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 52a246a737a2 to a6d9a7de5704
2024-07-24 robertphillips@google.com [graphite] Add comments to public API re Graphite-specific deprecations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 22:02:13 +00:00
Chris Bracken
c100e07c9e [iOS] Build universal gen_snapshots for iOS (flutter/engine#54009) 
This merges the macOS and iOS rules for creating the `gen_snapshot_arm64` and `gen_snapshot_x64` used to build for iOS devices, as well as for iOS simulators on both arm64 hosts (`gen_snapshot_arm64`) and x64 hosts (`gen_snapshot_x64`). The macOS rules have already been updated to generate universal binaries for each of these that can be run on both Apple Silicon and Intel Mac hosts.

This also updates `create_full_ios_framework.py` to bundle the newly-generated universal gen_snapshot binaries and produce the artifacts.zip archive that is uploaded via the build config in `mac_ios_engine.json`.

The `create_arm_gen_snapshot` rule remains until I'm 100% convinced it's not used for macOS host Android target builds.

Issue: https://github.com/flutter/flutter/issues/101138
Issue: https://github.com/flutter/flutter/issues/69157

This is stacked on top of https://github.com/flutter/engine/pull/54008.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-24 21:56:16 +00:00
Matan Lurey
c696d2cf7b Move testing/litetest to pub workspaces. (flutter/engine#54082) 
More incremental version of https://github.com/flutter/engine/pull/53997.
 2024-07-24 21:02:17 +00:00
skia-flutter-autoroll
c464074946 Roll Skia from 1561e2127c6f to 54d1434637a1 (2 revisions) (flutter/engine#54087) 
https://skia.googlesource.com/skia.git/+log/1561e2127c6f..54d1434637a1

2024-07-24 johnstiles@google.com Allow `writeFunctionCallArgument` to add multiple arguments.
2024-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8e90204125ac to 560809a2d33f (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 20:42:16 +00:00
Jim Graham
9078eeec8b [Impeller] Use new DisplayList SaveLayer unbounded flag (flutter/engine#54085) 
Impeller had been disabling a save layer bounds optimization under certain conditions that were meant to imply that the layer was unbounded.

The DisplayList now includes a flag indicating exactly when the layer is unbounded so we will now use that flag instead of an assumed implication to check for this condition.
 2024-07-24 19:48:04 +00:00
skia-flutter-autoroll
eebe1f4930 Roll Skia from c11932925658 to 1561e2127c6f (5 revisions) (flutter/engine#54084) 
https://skia.googlesource.com/skia.git/+log/c11932925658..1561e2127c6f

2024-07-24 johnstiles@google.com Add push_back_n and pop_back_n to FixedArray.
2024-07-24 nicolettep@google.com [Dawn] Add YCbCr conversion information to DawnTexture keys
2024-07-24 johnstiles@google.com Use swizzles to save space during code minification.
2024-07-24 jvanverth@google.com [graphite] Fix backend texture variants of surface tests.
2024-07-24 scroggo@google.com Mention Java requirement in Android build instructions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 19:24:32 +00:00
Matan Lurey
cfe0de9c8f Suggest a few common vscode extensions. (flutter/engine#53974) 
For example, without the markdown preview, files in `docs/**/*.md` don't all render.
 2024-07-24 18:49:05 +00:00
Robert Ancell
e0a1f3492a Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 18:20:19 +00:00
Jonah Williams
9d7ce06c95 share platform view slicing logic across iOS and Android. (flutter/engine#54010) 
This removes support for "unobstructed platform views" on iOS - instead prefering to use the Android strategy of minimizing overlay layers, as this is generally more performant.
 2024-07-24 18:02:09 +00:00
Jackson Gardner
851a3e5829 [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 
The occlusion rectangle for platform views was going through this `inverseMapRect` code path, which actually was giving us the wrong results. The operations should just be doing the normal transformation on the rectangles to get the right result. It actually turns out we don't need the inverse mapping function, so I removed it, and I renamed the somewhat confusingly named `cullRect` function to `mapRect` which I think makes a bit more sense.

This should resolve https://github.com/flutter/flutter/issues/152139
 2024-07-24 17:48:48 +00:00
skia-flutter-autoroll
f8d61bdc72 Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 
https://skia.googlesource.com/skia.git/+log/25f26f673502..c11932925658

2024-07-24 johnstiles@google.com Fix fuzzer-discovered issue with switch variable-hoisting.
2024-07-24 robertphillips@google.com Switch the Galaxy S24 Protected jobs from Ganesh to Graphite
2024-07-24 bungeman@google.com Update XCode 11.4.1 to 15.4
2024-07-24 johnstiles@google.com Remove unused 'fIsClone' from VarDeclaration.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 17:15:23 +00:00
Camille Simon
0619de0107 Upgrade Engine Android SDK to 35 (flutter/engine#53574) 
**REVIEW BUT DO NOT MERGE:** Will merge after https://github.com/flutter/buildroot/pull/870 lands.

1: Updates engine to use Android 35. Part of https://github.com/flutter/flutter/issues/150215.
Engine step of https://github.com/flutter/flutter/blob/master/docs/platforms/android/Upgrading-Engine's-Android-API-version.md.

2: Updates test runner AGP version to 8.5, engine Gradle version to 8.9 to accommodate update.

3: Fixes lint and suppresses deprecation warnings caused by the update. None of the deprecations are unknown by the team (they are handled in the code), but the tests emitted warnings.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-24 16:54:38 +00:00
Robert Ancell
102617432b Don't rely on the renderer accessing the engine through the view. (flutter/engine#54049) 
In the multi-view case there will be 0-N views, so instead hold a weak
reference on the engine.
 2024-07-25 02:41:31 +12:00
skia-flutter-autoroll
549a525563 Roll Skia from 0315e534d936 to a9b1043eb23e (1 revision) (flutter/engine#54076) 
https://skia.googlesource.com/skia.git/+log/0315e534d936..a9b1043eb23e

2024-07-24 kjlubick@google.com Remove legacy graphite image factories

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 12:26:32 +00:00
skia-flutter-autoroll
d9da7de57c Roll Dart SDK from f4f95688d5ca to 0b3c00feefb1 (1 revision) (flutter/engine#54075) 
https://dart.googlesource.com/sdk.git/+log/f4f95688d5ca..0b3c00feefb1

2024-07-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-77.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 10:14:09 +00:00
Robert Ancell
83dca15abd Rename FlBackingStoreProvider to FlFramebuffer (flutter/engine#54047) 
The name was confusing, as it only provided one type of backing store.
FlBackingStoreProvider sounds more like an interface that the
FlFramebuffer would implement if we had multiple backing stores.

Use OpenGL types for values.

Fix cases where this was sometimes called a texture.

Improve documentation.

Remove the use of GdkRectangle for dimensions - the framebuffer only has
a width and a height. There was code that was using the x,y values which
would always have been zero - this has now been removed.
 2024-07-24 18:55:36 +12:00
Robert Ancell
bc9c7efb58 Remove unnecessary double cast (flutter/engine#54044) 2024-07-24 18:54:42 +12:00
Robert Ancell
904a1ab58f Fix variable name (flutter/engine#54045) 2024-07-24 18:54:30 +12:00
skia-flutter-autoroll
7c9ee3bb53 Roll Skia from 3f1b4e98f65a to 7ad882fb5320 (4 revisions) (flutter/engine#54071) 
https://skia.googlesource.com/skia.git/+log/3f1b4e98f65a..7ad882fb5320

2024-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f211552c7990 to 8e90204125ac (2 revisions)
2024-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 64c6d0a7cb1f to d77400c7282a (8 revisions)
2024-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 74e2fbfd1765 to 90fdaa810322 (35 revisions)
2024-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 94d0b98eea9e to d77400c7282a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 06:52:29 +00:00
skia-flutter-autoroll
aab723ee0c Roll Dart SDK from e53beb039093 to f4f95688d5ca (1 revision) (flutter/engine#54068) 
https://dart.googlesource.com/sdk.git/+log/e53beb039093..f4f95688d5ca

2024-07-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-76.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 05:07:24 +00:00
Srujan Gaddam
0f69778e71 Change JSArray.length to return int (flutter/engine#54051) 
This is in preparation for
https://dart-review.googlesource.com/c/sdk/+/373884, which will add length to the extension type itself. This will shadow the extension member, so we should make sure the type signatures match.
 2024-07-24 01:12:19 +00:00
skia-flutter-autoroll
fa03262127 Roll Dart SDK from 17131486a2f7 to e53beb039093 (1 revision) (flutter/engine#54066) 
https://dart.googlesource.com/sdk.git/+log/17131486a2f7..e53beb039093

2024-07-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-75.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 01:00:17 +00:00
skia-flutter-autoroll
e582c6b5ee Roll Fuchsia Linux SDK from ZcBsXDojTYbriHD7_... to qA7S-DZ5FyMtcM7_J... (flutter/engine#54064) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-24 00:56:23 +00:00
Jim Graham
57d78e3da4 [DisplayList] Fix assertions on DisplayList verbose comparison tests (flutter/engine#54065) 
Fixes 2 problems recently uncovered in the DisplayList verbose comparison test mechanism:

- The verbose compare methods never asserted a test failure, relying on the caller to do so from their return value - but they also did not prompt the caller to check the return value. So a `[[nodiscard]]` is added to remind test writers that they need to assert on the return value
- As a result of the above, some bad tests were recently added to the tree that were failing but did not assert a test failure. Now that the `[[nodiscard]]` is added, they failed to compile and had to have asserts added.

A secondary problem is that those non-failing tests were inadvertently cherry-picked from a reverted PR that is being reintroduced in incremental sections so as to avoid large scale golden image failures. The tests depend on parts of that PR that haven't been pulled forward yet (but will soon be) so those tests shouldn't have been added in the first place (and were failing, but not causing a gtest failure because of their missing asserts). They remain here, but their results are reversed to indicate the current state of affairs (they assert that the missing functionality isn't in place yet). Their assertions will be reverted when/as the missing functionality is pulled forward in a more incremental (responsible) way.
 2024-07-24 00:18:05 +00:00
Chris Bracken
51706cd06f [iOS] Flush layer pool after platform view dispose (flutter/engine#54056) 
`FlutterPlatformViewLayerPool` is a pool of iOS layers used for rendering platform views on iOS. When layers are no longer needed, we currently mark them available for re-use but we never actually flush them and thus recover the memory associated with these layers once we know that the layers are no longer needed.

We now flush the layer pool on `SubmitFrame` if a previously-used layer is no longer used in the current frame. In theory, this could cause a performance regression in the case where an additional layer is needed every second or third frame, but we should keep it simple on the first pass and only complicate things later if warranted.

Fixes: https://github.com/flutter/flutter/issues/152053

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-23 23:55:04 +00:00
Chris Bracken
16455a2543 [iOS] Mark EmbeddedViewCount const (flutter/engine#54062) 
Since this method isn't mutating the pool, we should mark it const.

Cleanup spotted while working on https://github.com/flutter/engine/pull/54056.

No test because no semantic change. The compiler is the test.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-23 23:50:58 +00:00
skia-flutter-autoroll
e9d5c35bf1 Roll Skia from f4355cf73508 to 3f1b4e98f65a (1 revision) (flutter/engine#54060) 
https://skia.googlesource.com/skia.git/+log/f4355cf73508..3f1b4e98f65a

2024-07-23 michaelludwig@google.com [graphite] Use non-aa bounds renderer for pixel-aligned rects

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-23 23:47:36 +00:00
skia-flutter-autoroll
24151460a2 Roll Skia from 2d518b6a793a to f4355cf73508 (9 revisions) (flutter/engine#54058) 
https://skia.googlesource.com/skia.git/+log/2d518b6a793a..f4355cf73508

2024-07-23 jvanverth@google.com Disable path_text_clipped_uncached on Pixel4XL Vulkan configs
2024-07-23 johnstiles@google.com Mark samplers as explicitly-sampled when passing them to a function.
2024-07-23 michaelludwig@google.com Revert "[skif] Use src blending when possible"
2024-07-23 jamesgk@google.com Further limit F16 draw test
2024-07-23 bungeman@google.com Remove use of enable_skslc flag
2024-07-23 johnstiles@google.com Simplify control flow in css_hwb_to_srgb.
2024-07-23 chengyangyang-hf@loongson.cn [loong64] Optimize gauss blur imagefilter.
2024-07-23 nathanasanchez@google.com [SkSL] Change specialization mapping to expression
2024-07-23 jvanverth@google.com [graphite] Fix basic drawShadow functionality.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-23 22:02:25 +00:00
skia-flutter-autoroll
5a9f3da0be Roll Dart SDK from eeb2e4e409bf to 17131486a2f7 (1 revision) (flutter/engine#54055) 
https://dart.googlesource.com/sdk.git/+log/eeb2e4e409bf..17131486a2f7

2024-07-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-74.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-23 20:20:01 +00:00
skia-flutter-autoroll
85d9c4aa4a Roll Skia from a9019fddac28 to 2d518b6a793a (4 revisions) (flutter/engine#54052) 
https://skia.googlesource.com/skia.git/+log/a9019fddac28..2d518b6a793a

2024-07-23 jamesgk@google.com Don't test F16 draws with advanced blend modes
2024-07-23 bungeman@google.com Android SkFontMgr prioritize stated weight
2024-07-23 sharaks@google.com Merge 4 release notes into RELEASE_NOTES.md
2024-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5d0bdd3702f7 to f211552c7990 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-23 19:38:14 +00:00