15122 Commits

Author SHA1 Message Date
chunhtai
5df17acb1f
add ontap to textformfield (#37403) 2019-08-02 10:34:39 -07:00
Hans Muller
873de56228
Update constructor APIs TooltipTheme, ToggleButtonsTheme, PopupMenuTheme (#37338)
* Update constructor APIs TooltipTheme, ToggleButtonsTheme, PopupMenuTheme
The constructor signatures for TooltipTheme, ToggleButtonsTheme, PopupMenuTheme have been incompatibly changed. They now require just one theme data parameter.
2019-08-02 10:11:38 -07:00
Justin McCandless
954714c967
Hide text selection handle after entering text (#37436)
The text caret wasn't being hidden after entering text, this fixes it.
2019-08-02 10:10:39 -07:00
Chris Yang
9553f8daa7
Extract common PlatformView functionality: Painting and Semantics (#36955)
* painting and semantics

* more comments

* fixing ci

* review fixes

* add assert for id

* rename custom layer factory to layer builder

* review updates

* partial review fixes

* some doc updates

* more doc updates

* only expose getter for id in PlatformViewController

* doc updates/removing all the  references

* remove extra

* more doc updates

* some doc updates

* more doc fixes

* review fixes
2019-08-02 10:07:59 -07:00
engine-flutter-autoroll
99fe0d078b
26368225b Fix deprecation warnings in the Android embedding (flutter/engine#10424) (#37456)
git@github.com:flutter/engine.git/compare/eac7ef065dbd...26368225b5ec

git log eac7ef065dbd..26368225b5ec --no-merges --oneline
2019-08-02 jason-simmons@users.noreply.github.com Fix deprecation warnings in the Android embedding (flutter/engine#10424)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.
2019-08-02 13:07:44 -04:00
Liam Appelbe
0cf4033404
Switch iOS gen_snapshot from multi-arch binary to multiple binaries (#37445)
* Switch iOS gen_snapshot from multi-arch binary to multiple binaries

* Make snapshotterPath mutable
2019-08-02 07:43:07 -07:00
Dan Field
84fe2adedb
Nosuchmethod window (#37417) 2019-08-01 20:04:49 -07:00
engine-flutter-autoroll
18418dffda
Roll engine bf9288597586..eac7ef065dbd (4 commits) (#37448)
git@github.com:flutter/engine.git/compare/bf9288597586...eac7ef065dbd

git log bf9288597586..eac7ef065dbd --no-merges --oneline
2019-08-01 chris@bracken.jp Add copy_gen_snapshots.py tool (flutter/engine#10430)
2019-08-01 liama@google.com Fix mac gen_snapshot uploader (flutter/engine#10423)
2019-08-01 iska.kaushik@gmail.com Make kernel compiler use host toolchain (flutter/engine#10419)
2019-08-01 liama@google.com Use simarm_x64 when targeting arm (flutter/engine#10010)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.
2019-08-01 22:44:44 -04:00
Jenn Magder
af1bbc4374
Disable flaky test (#37442) 2019-08-01 17:22:17 -07:00
engine-flutter-autoroll
2a3f48011b
bf9288597 [fuchsia] Add kernel_compiler target in build_fuchsia script (flutter/engine#10403) (#37428)
git@github.com:flutter/engine.git/compare/b41c172bcd86...bf9288597586

git log b41c172bcd86..bf9288597586 --no-merges --oneline
2019-08-01 iska.kaushik@gmail.com [fuchsia] Add kernel_compiler target in build_fuchsia script (flutter/engine#10403)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.
2019-08-01 19:59:59 -04:00
stevemessick
93dd90fc1a
Add .android/Flutter/flutter.iml to module template. (#37405) 2019-08-01 15:47:00 -07:00
chunhtai
eddcc6bb25
reland Enable selection by default for password text field and expose api to turn on and off context menu options (#37324) 2019-08-01 14:19:04 -07:00
Yegor
58e507ba15
Change the value of kMaxUnsignedSMI for the Web (#37266)
* Sync the value kMaxUnsignedSMI for the Web

* update events.dart docs
2019-08-01 13:37:15 -07:00
Chinmay Garde
9ea78d4488
Revert "Remove multi-arch check in iOS builds (#37407)" (#37413)
This reverts commit 58092195091298b5112f4f935a743de2f77d1458.
2019-08-01 11:43:32 -07:00
Liam Appelbe
5809219509
Remove multi-arch check in iOS builds (#37407)
* Remove multi-arch check in iOS builds

* Manual roll of https://github.com/flutter/engine/pull/10010
2019-08-01 11:16:21 -07:00
Tong Mu
5bb8d8fcde
Split Mouse from Listener (#36217)
- Splits on{Enter,Hover,Exit} from Listener to MouseRegion. Deprecated API is kept for compatibility.
- Splits on{Enter,Hover,Exit} from RenderPointerListener to RenderMouseRegion.
2019-08-01 11:06:50 -07:00
GroovinChip
ced207836b Improve Windows build failure message (#36845)
* Improve Windows build failure message

* Undo dartfmt to match source formatting

* Removed prompt to file new issue per PR change request
2019-08-01 10:32:38 -07:00
Majid Hajian
7244cbb9b2 add line-length to flutter format commandline (#36679) 2019-08-01 10:27:41 -07:00
Jonah Williams
cf6613583d
only build macOS kernel in debug mode (#37365) 2019-08-01 09:23:40 -07:00
Zachary Anderson
2b03e2089d
[flutter_tool] Add missing toString() (#37331) 2019-08-01 09:23:05 -07:00
Yegor
ea32385162
Fix some tests now that the isMultiline flag is added to values (#37328) 2019-08-01 07:33:20 -07:00
Michael Goderbauer
e6dc6a8b5f
Animation API doc improvments (#35919) 2019-08-01 10:29:06 +02:00
engine-flutter-autoroll
8bcbc45e71
Roll engine f790c9ad7e76..b41c172bcd86 (2 commits) (#37368)
git@github.com:flutter/engine.git/compare/f790c9ad7e76...b41c172bcd86

git log f790c9ad7e76..b41c172bcd86 --no-merges --oneline
2019-08-01 iska.kaushik@gmail.com [fuchsia] Kernel compiler is now ready (flutter/engine#10309)
2019-08-01 cfontas@google.com Remove one last final call to AddPart() (flutter/engine#10273)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.
2019-08-01 04:23:59 -04:00
Zachary Anderson
2e183b6233
[flutter_tool] Include the local timezone in analytics timestamp (#37345) 2019-07-31 23:28:18 -07:00
engine-flutter-autoroll
0d6a962b7a
f790c9ad7 Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:2k-0epsqEV14oZvIxpS-jHkPhZa837aSNjEj14wd73MC to fuchsia/sdk/core/linux-amd64:R6MHyz58h4cLuv1Odwzf2JWJkrYee4D6QKR92VinTggC (flutter/engine#10305) (#37363)
git@github.com:flutter/engine.git/compare/59ac63d3e112...f790c9ad7e76

git log 59ac63d3e112..f790c9ad7e76 --no-merges --oneline
2019-08-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:2k-0epsqEV14oZvIxpS-jHkPhZa837aSNjEj14wd73MC to fuchsia/sdk/core/linux-amd64:R6MHyz58h4cLuv1Odwzf2JWJkrYee4D6QKR92VinTggC (flutter/engine#10305)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.
2019-08-01 01:33:00 -04:00
Jonah Williams
602f76ca00
fix errors caught by roll of macOS assemble (#37351) 2019-07-31 21:14:40 -07:00
engine-flutter-autoroll
e1746161ea
Roll engine a29ef660134f..59ac63d3e112 (17 commits) (#37357)
git@github.com:flutter/engine.git/compare/a29ef660134f...59ac63d3e112

git log a29ef660134f..59ac63d3e112 --no-merges --oneline
2019-07-31 jason-simmons@users.noreply.github.com Ensure that the SingleFrameCodec stays alive until the ImageDecoder invokes its callback (flutter/engine#10297)
2019-07-31 franciscojma@google.com [glfw] Enables replies on binary messenger in glfw embedder (flutter/engine#9948)
2019-07-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from fuchsia/sdk/core/mac-amd64:TAkpmqxKgauDvmpeaOTOAbYsnz1nWuqznTirppN0dGoC to fuchsia/sdk/core/mac-amd64:bswmziOk2a7sku7aG0fnZO7sQOFPK_XBy58QPcqsugwC (flutter/engine#10300)
2019-07-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia c876404e64d2..83d8a949ae22 (6 commits) (flutter/engine#10302)
2019-07-31 garyq@google.com Fix run.start -> run_start (flutter/engine#10295)
2019-07-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:E8lhQA7KKqhzZkfqaF8zKnqOMy88-Z3lf4uBnUNHa4AC to fuchsia/sdk/core/linux-amd64:2k-0epsqEV14oZvIxpS-jHkPhZa837aSNjEj14wd73MC (flutter/engine#10301)
2019-07-31 dnfield@google.com Make tree green for real this time, I promise. (flutter/engine#10303)
2019-07-31 dnfield@google.com Fix red build again (flutter/engine#10298)
2019-07-31 bkonyi@google.com Roll src/third_party/dart 80c4954d4d..bd049f5b53 (37 commits) (flutter/engine#10294)
2019-07-31 dnfield@google.com fix CI (flutter/engine#10296)
2019-07-31 iska.kaushik@gmail.com [fuchsia] Make cirrus build fuchsia artifacts (flutter/engine#10268)
2019-07-31 dnfield@google.com Add fuchsia.stamp for roller (flutter/engine#10293)
2019-07-31 franciscojma@google.com  [macos] Reland function refactor (flutter/engine#10189)
2019-07-31 sjindel@google.com Export FFI from sky_engine. (flutter/engine#10282)
2019-07-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6808e2d1faac..c876404e64d2 (6 commits) (flutter/engine#10292)
2019-07-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from fuchsia/sdk/core/mac-amd64:A4Ah4g0K30dWnbolQ7Z3zyXapbAyy3d9l4IeLGAG9YQC to fuchsia/sdk/core/mac-amd64:TAkpmqxKgauDvmpeaOTOAbYsnz1nWuqznTirppN0dGoC (flutter/engine#10291)
2019-07-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:6j9WXOOtqKZzSKIgQi-12GJ1MYzPDJvq-RLAtpJpGB0C to fuchsia/sdk/core/linux-amd64:E8lhQA7KKqhzZkfqaF8zKnqOMy88-Z3lf4uBnUNHa4AC (flutter/engine#10290)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.
2019-07-31 23:27:00 -04:00
Chris Yang
21d6d7efb2
Add comments to an Android Platform view gesture test case to explain the test (#37322) 2019-07-31 17:52:05 -07:00
Jonah Williams
2ab469952b
Flutter assemble for macos take 2! (#36987) 2019-07-31 16:19:22 -07:00
Jenn Magder
dd1fb3bcb7
Build number (part after +) is documented as optional, use entire app version if not present (#37036) 2019-07-31 16:18:09 -07:00
Justin McCandless
fb2f3e580e
iOS 13 scrollbar (#35829)
You can drag the cupertinoscrollbar if you pass an active scrollcontroller to the scrollbar.
2019-07-31 15:52:51 -07:00
Zachary Anderson
c7596da5a4
[flutter_tool] Re-try sending the first crash report (#37198) 2019-07-31 13:51:19 -07:00
Shi-Hao Hong
28dd0fde3b
Clamp Scaffold's max body height when extendBody is true (#37254) 2019-07-31 13:42:55 -07:00
Keerti Parthasarathy
f3674ccfd7
Update dartdoc to 28.4 (#37314) 2019-07-31 13:41:27 -07:00
Jim Graham
76d13ab318
Reland: Optimize the transformRect and transformPoint methods in matrix_utils. (#36396) (#37275)
Primarily these methods no longer allocate any objects other than their
return values.

Additionally, the math in the methods is reduced compared to the general
case math based on known input conditions.

Modified to no longer generate infinite values in some finite cases.
2019-07-31 13:25:45 -07:00
engine-flutter-autoroll
852bcba57c
Roll engine b43178e3d683ce7cacfda541837aca044e0ef5b4..a29ef660134f4d1656dfb4bddba6f577bb508747 (10 commits) (#37309)
b43178e3d6...a29ef66013

git log b43178e3d683..a29ef660134f --no-merges --oneline
a29ef6601 [fuchsia] Remove extraneous ShapeNodes (flutter/engine#10150)
8ef792f6c Roll src/third_party/skia a13c7744f154f434b5415688280b4e127a2ce8f5..6808e2d1faaccd6fc739f436c2470f199aa4d1a8 (2 commits) (flutter/engine#10281)
ca29c7206 Roll fuchsia/sdk/core/mac-amd64 from fuchsia/sdk/core/mac-amd64:vjX_DhfQqJjsX26pl5-vNNM3Lfb0Vwl9l09abYj-D1oC to fuchsia/sdk/core/mac-amd64:A4Ah4g0K30dWnbolQ7Z3zyXapbAyy3d9l4IeLGAG9YQC (flutter/engine#10280)
75970d77b Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:om5F-s2gIabc-Toen2VT6nnosnQvTKI1e6Nz2zg8P40C to fuchsia/sdk/core/linux-amd64:6j9WXOOtqKZzSKIgQi-12GJ1MYzPDJvq-RLAtpJpGB0C (flutter/engine#10279)
6a69cd591 Roll src/third_party/skia 6980c4e0aef8ab9546e25d8160c05a716f1c3ce3..a13c7744f154f434b5415688280b4e127a2ce8f5 (1 commits) (flutter/engine#10278)
7a7afab09 Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:MuVYOXXS9sxCbxvFCJDHfuF5pkWXIgS0uUlBFdIuQPsC to fuchsia/sdk/core/linux-amd64:om5F-s2gIabc-Toen2VT6nnosnQvTKI1e6Nz2zg8P40C (flutter/engine#10277)
02649bd27 Roll fuchsia/sdk/core/mac-amd64 from fuchsia/sdk/core/mac-amd64:kSzcB40iCqsXbCka_VUf4jB5iRl2G9gLM_xDbbGg5GwC to fuchsia/sdk/core/mac-amd64:vjX_DhfQqJjsX26pl5-vNNM3Lfb0Vwl9l09abYj-D1oC (flutter/engine#10276)
e8b19de50 Roll src/third_party/skia 6e86c1b05eeedc3b6be0e98001b7b5d6bab71b74..6980c4e0aef8ab9546e25d8160c05a716f1c3ce3 (4 commits) (flutter/engine#10275)
3be752389 Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:pGTb76UZ-PsJzdatSNkJIkEGLESaGa_S2wtZfgHPU5EC to fuchsia/sdk/core/linux-amd64:MuVYOXXS9sxCbxvFCJDHfuF5pkWXIgS0uUlBFdIuQPsC (flutter/engine#10274)
ed8e35c4c Remove get engine (flutter/engine#9747)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.
2019-07-31 15:48:00 -04:00
Jenn Magder
1bcaa15018
Make podhelper.rb a template to avoid passing in the module name (#37276) 2019-07-31 11:34:22 -07:00
liyuqian
e77237d6d3
Reland "Fix the first frame logic in tracing and driver (#35297)" (#37192)
This relands https://github.com/flutter/flutter/pull/35297

The followings have been done to fix the broken tests:
  1. Add `didSendFirstFrameRasterizedEvent` extension and its tests
  2. Wait for `didSendFirstFrameRasterizedEvent` instead of
     `didSendFirstFrameEvent` during start up tests
  3. Mark missed (probably newly added) start up tests as flaky
2019-07-31 11:01:52 -07:00
Darren Austin
f0957abcd0
Made the snackbar fallback theme include a full inverse colorScheme. (#37038) 2019-07-31 10:43:59 -07:00
Michael Goderbauer
6ab2445ef5
Fix Textfields in Semantics Debugger (#37158) 2019-07-31 17:33:38 +02:00
Justin McCandless
d82bca2a31
Fix selection menu not showing after clear (#37042)
This allows the text selection menu to be shown after deleting all text in a text field.
2019-07-31 08:01:15 -07:00
engine-flutter-autoroll
53a1f225ae
Roll engine c41bbc63d955cc7056a162957ac4eeeca6647dc2..b43178e3d683ce7cacfda541837aca044e0ef5b4 (14 commits) (#37274)
c41bbc63d9...b43178e3d6

git log c41bbc63d955..b43178e3d683 --no-merges --oneline
b43178e3d Roll fuchsia/sdk/core/mac-amd64 from fuchsia/sdk/core/mac-amd64:Z7vUHOlojg6n7o-K4Knm474YKdmi1a8pX7Klq_YmkpUC to fuchsia/sdk/core/mac-amd64:kSzcB40iCqsXbCka_VUf4jB5iRl2G9gLM_xDbbGg5GwC (flutter/engine#10270)
f8d122bfc Remove Dead Scenic Clipping Code Path. (flutter/engine#10242)
7436f693a Roll src/third_party/skia e9cb76221597ac9e9b0bf009ab1a843da8428d83..6e86c1b05eeedc3b6be0e98001b7b5d6bab71b74 (16 commits) (flutter/engine#10266)
6bd2f5319 [dart-roll] Roll dart sdk to 80c4954d4d1d2a257005793d83b601f3ff2997a2 (flutter/engine#10265)
4c6948a88 Android Embedding Refactor 38: Removed AssetManager from DartEntrypoint. (flutter/engine#10250)
b18105f57 Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:cYX6VeZcy3RWhV8mZIVF8MI5NvcUSgFRLRZMKpfWxTMC to fuchsia/sdk/core/linux-amd64:pGTb76UZ-PsJzdatSNkJIkEGLESaGa_S2wtZfgHPU5EC (flutter/engine#10264)
6834deb2b Roll fuchsia/sdk/core/mac-amd64 from fuchsia/sdk/core/mac-amd64:P-V-0DXgsN-0uCWtbyqNO-do3JScrAvZ3z1_Vj5xdagC to fuchsia/sdk/core/mac-amd64:Z7vUHOlojg6n7o-K4Knm474YKdmi1a8pX7Klq_YmkpUC (flutter/engine#10262)
b6fe15d60 [fuchsia] Bundle architecture specific gen_snapshots (flutter/engine#10261)
a6a7c8547 [fuchsia] Add arm64 builds for flutter and dart runner (flutter/engine#10260)
e77e4f0e0 [fuchsia] Update buildroot to support arm64 (flutter/engine#10240)
cf46f88e9 Roll src/third_party/skia 9dc0b9e2f86a..e9cb76221597 (12 commits) (flutter/engine#10259)
0d66b3251 [fuchsia] Start building dart_patched_sdk (flutter/engine#10246)
dfe68a0f2 Roll fuchsia/sdk/core/linux-amd64 from 7FSBCYS5vCVwpiozstnbIO6K7sCFQ87UYwo6NkeNrCIC to cYX6VeZcy3RWhV8mZIVF8MI5NvcUSgFRLRZMKpfWxTMC (flutter/engine#10258)
04c18c6f0 Roll fuchsia/sdk/core/mac-amd64 from rJ53P95WbHakJemuGkRE3VOdlvohKPI91VcydLL0n2MC to P-V-0DXgsN-0uCWtbyqNO-do3JScrAvZ3z1_Vj5xdagC (flutter/engine#10256)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.
2019-07-31 09:58:28 -04:00
Michael Goderbauer
9a01ed2a55
Revert "reland Enable selection by default for password text field and expose api to turn on and off context menu options (#34676) (#37183)" (#37295)
This reverts commit 7eb09a842e406f15dccb5ac1fac2ec7f511708fb.
2019-07-31 15:34:22 +02:00
Kate Lovett
9bb7142ef7
Removing leftover skips. (#37250) 2019-07-30 14:45:00 -07:00
Dan Field
a8fbe02a9d hide symbols from spotlight (#37217) 2019-07-30 14:24:58 -07:00
chunhtai
7eb09a842e
reland Enable selection by default for password text field and expose api to turn on and off context menu options (#34676) (#37183)
This reverts commit 48c7090f3c2faa20499d2ae8ccca563138d0c215.
2019-07-30 14:19:10 -07:00
Emmanuel Garcia
bd02e4f573
Test that modules built as AAR contain the right assets and artifacts (#37206) 2019-07-30 13:38:06 -07:00
xster
dfad03952f
do not strip symbols when building profile (#37210) 2019-07-30 13:09:40 -07:00
Zachary Anderson
d208ce2dff
[flutter_tool] Usage refactor cleanup (#37186) 2019-07-30 12:18:15 -07:00
Zachary Anderson
a9aea962ab
[flutter_tool] Catch ProcessException from 'adb devices' (#37196) 2019-07-30 12:17:10 -07:00