8871 Commits

Author SHA1 Message Date
Yegor
89d06450e1 FadeInImage: shows a placeholder while loading then fades in (#11371)
* FadeInImage: shows a placeholder while loading then fades in

* fix dartdoc quotes

* license headers; imports

* use ImageProvider; docs; constructors

* _resolveImage when placeholder changes

* address comments

* docs re ImageProvider changes; unsubscribe from placeholder

* rebase

* address comments
2017-08-02 09:44:27 -07:00
Devon Carew
c72381aa2d refactor commands_test to choose a free port for the service protocol (#11446)
* refactor commands_test to choose a free port for the service protocol

* discover the service protocol port

* add a todo
2017-08-02 08:29:44 -07:00
Jason Simmons
c80d2482f9 An API that prefetches an image into the cache (#11471) 2017-08-01 17:36:38 -07:00
Ian Hickson
3d5afb5a81 Revert "Skip AOT snapshot build if inputs are unchanged" (#11463)
* Revert "Support space- and backslash-escaped dependencies (#11090)"

This reverts commit e6bafd0bdb70108b9f0604798386fd9e644e7c8d.

* Revert "Skip AOT snapshot build if inputs are unchanged (#11084)"

This reverts commit b5e522e2002f1b616e689b5012c9a42bbc9321f4.
2017-08-01 16:46:24 -07:00
Michael Goderbauer
d68caaafcd post-alpha-release work (#11472) 2017-08-01 16:45:29 -07:00
Devon Carew
a7c3bf4849 perform the initial poll for devices quicker (#11356)
* perform the initial poll for devices quicker

* add a Poller class

* test the new Poller class
2017-08-01 15:29:54 -07:00
Michael Goderbauer
bbcfb8d51a prepare alpha release (#11464) 2017-08-01 14:50:29 -07:00
Ian Hickson
ae5c3d5f89 Revert "Revert "Always evaluate the finder in driver.waitFor*()" (#11451)" (#11462)
This reverts commit 5d9db106db23d14e22a9c326d97d50fb1fcdc4d7.
2017-08-01 14:23:44 -07:00
perlatus
d1b222bef6 PopupMenuButton: create IconButton if child is Icon (#10230)
* PopupMenuButton: create IconButton if child is Icon

Otherwise the resulting button has an abnormally small and rectangular
area. With multiple PopupMenuButton(child: Icon) they get squished
together in the AppBar.

* Add separate icon argument to PopupMenuButton

* Fix style issues and tweak dartdocs

* Add tests for icon argument to PopupMenuButton

* Group icon tests and fix broken test, analyzer warnings

* Test that the correct custom icon is present

* Apply De Morgan's to work around dart analyzer bug

see: https://github.com/dart-lang/sdk/issues/30288
2017-08-01 12:32:49 -07:00
Alexey Shamrin
cfcf6d4428 brew update is not needed any more: Homebrew/brew#679 (#11406) 2017-08-01 12:21:56 -07:00
Ian Hickson
5d9db106db Revert "Always evaluate the finder in driver.waitFor*()" (#11451)
* Revert "Make plugins add their repos to projects in the consuming app (#11447)"

This reverts commit abe1e2520bb117c3de06cd3c44ad2a8250000de8.

* Revert "Support for custom build types on Android (#11354)"

This reverts commit 87eec719e20dd1423891a851d94b504b2453bf29.

* Revert "add a profile() method (#11443)"

This reverts commit 561d17a87606f8cf118b57bfacccb1acf6b9b594.

* Revert "Fix documentation based on dartdoc's warnings (#11428)"

This reverts commit 6655074b370d39150d2ed28f67851e3bce7013ab.

* Revert "Improve some docs around WillPopScope. (#11429)"

This reverts commit 58a28a296579b39360cbbb4a5f8b4b575eeb218b.

* Revert "temporarily disable broken driver test in integration_ui (#11440)"

This reverts commit 764515ec780421272de40b6b6c399497a1b38876.

* Revert "style fix"

This reverts commit 00bfc86630661edbd670b7c473fe07b11c6eee7a.

* Revert "tests for waitFor/waitForAbsent"

This reverts commit 31d2ee9c0cf259bc607bfbcaf112d4b8c2c360c1.

* Revert "Always evaluate the finder in `driver.waitFor()` and `driver.waitForAbsent()`"

This reverts commit 11d7c79b9902f960e9541f9f7da2f8857e4aaef4.
2017-08-01 10:39:08 -07:00
xster
ead51eae68 Roll engine (#11457)
* roll

* no-op commit

* revert no-op
2017-07-31 16:29:50 -07:00
Jason Simmons
b7bf2cd528 roll engine (#11456) 2017-07-31 14:02:37 -07:00
Ian Hickson
d4beaf54f0 Audit use of saveLayer (#11442)
It has recently come to light that we may have been ordering saveLayer
calls and clip calls incorrectly.
2017-07-31 12:21:42 -07:00
Mikkel Nygaard Ravn
abe1e2520b Make plugins add their repos to projects in the consuming app (#11447) 2017-07-31 14:51:09 +02:00
Mikkel Nygaard Ravn
87eec719e2 Support for custom build types on Android (#11354) 2017-07-31 13:57:24 +02:00
Devon Carew
561d17a876 add a profile() method (#11443)
* add a profile() method

* add todos
2017-07-30 16:29:28 -07:00
Ian Hickson
6655074b37 Fix documentation based on dartdoc's warnings (#11428) 2017-07-28 15:44:38 -07:00
Ian Hickson
58a28a2965 Improve some docs around WillPopScope. (#11429)
...and break the navigator<->routes circular dependency.

This is a step towards fixing https://github.com/flutter/flutter/issues/9577 but doesn't yet do so.
2017-07-28 15:10:11 -07:00
Yegor
764515ec78 temporarily disable broken driver test in integration_ui (#11440) 2017-07-28 14:30:10 -07:00
Yegor Jbanov
00bfc86630 style fix 2017-07-28 13:10:03 -07:00
Yegor Jbanov
31d2ee9c0c tests for waitFor/waitForAbsent 2017-07-28 13:10:03 -07:00
Todd Volkert
11d7c79b99 Always evaluate the finder in driver.waitFor() and driver.waitForAbsent()
Fixes #11327
2017-07-28 13:10:03 -07:00
Devon Carew
ba5bb57a52 Revert "fire service protocol extension events for frames (#10966)" (#11430)
This reverts commit 4b4cabb761ec1cb7fb5f2e8ec6e850de29a03056.
2017-07-27 16:14:30 -07:00
Devon Carew
4b4cabb761 fire service protocol extension events for frames (#10966)
* fire service protocol extension events for frames

* start time in micros

* introduce a profile() function; only send frame events when in profile (or debug) modes

* moved the profile() function to foundation/profile.dart

* refactor to make the change more testable; test the change

* fire service protocol events by listening to onFrameInfo

* remove the frame event stream; add a devicelab test

* remove a todo

* final
2017-07-27 15:34:53 -07:00
Jason Simmons
22ccb74ef5 Check all possible output directories to find a locally built gen_snapshot (#11417)
The output location of gen_snapshot differs based on the engine's target
platform, and we don't know the target platform when building a
platform-independent FLX in JIT mode.
2017-07-27 14:22:21 -07:00
Ian Hickson
87445e5913 Increase the touch slop. (#11419)
It was 8.0. It's now arbitrarily 18.0.

Changing this required adjusting some tests. Adjusting the tests
required debugging the tests. Debugging the tests required some tools
to help debugging gesture recognizers and gesture arenas, so I added
some. It also required updating some toString() methods which resulted
in some changes to the tree diagnostics logic.

Also I cleaned up some docs while I was at it.
2017-07-27 14:01:06 -07:00
Devon Carew
990dae85eb remove the flutter view cache; fix the ability to quit the app after a full restart (#11420)
* remove the flutter view cache; fix the ability to quit the app after a full restart

* improve test

* update test
2017-07-27 11:47:33 -07:00
Jason Simmons
2225e21fc0 roll engine (#11422) 2017-07-26 20:55:16 -07:00
Devon Carew
1d8705f3db re-flow comments in the create template (#11413) 2017-07-26 11:44:50 -07:00
Jason Simmons
838bd63182 Control raster cache flags in CustomPaint widgets (#11398) 2017-07-25 16:39:03 -07:00
Jacob Richman
9f510ebdc9 Refactor RenderObject.toStringDeep and Widget.toStringDeep code to use DiagnosticsNode (#11359)
Refactor RenderObject.toStringDeep and Widget.toStringDeep code to use DiagnosticsNode.
2017-07-25 09:25:13 -07:00
Jason Simmons
5278588d80 roll engine (#11360) 2017-07-24 14:00:48 -07:00
Michael Goderbauer
e6f71555f6 Revert "Work around to fix appveyor build (#11295)" (#11297)
This reverts commit bc4a3f17034ab51693bc932a9b4eab0f3c23bae5.
2017-07-24 12:54:07 -07:00
Ian Hickson
f0dec6e305 Add a debug feature to the gestures library to dump hit test results (#11346) 2017-07-24 10:10:19 -07:00
Mehmet Fidanboylu
94ed7dce41 Support automaticallyImplyLeading param in AppBar (#11264)
* Support automaticallyImplyLeading param in AppBar

* Review fixes

* fix review comments
2017-07-22 06:12:42 -07:00
Devon Carew
a92a62706c ignore PausePostRequest when reloading (#11340)
* ignore postpauseevents when reloading

* Update run_hot.dart

comment changes to kick the appveyor bot
2017-07-21 16:57:33 -07:00
Ian Hickson
dd40d0e29c Modal barrier shouldn't paint when the route is offstage. (#11347)
Fixes https://github.com/flutter/flutter/issues/11323
2017-07-21 16:39:11 -07:00
Ian Hickson
8f56f6fdd1 Add documentation and clean up code. (#11330)
Mainly, this adds documentation to members that were previously
lacking documentation.

It also adds a big block of documentation about improving performance
of widgets.

This also removes some references to package:collection and adds
global setEquals and listEquals methods in foundation that we can use.
(setEquals in particular should be much faster than the
package:collection equivalent, though both should be faster as they
avoid allocating new objects.) All remaining references now qualify
the import so we know what our remaining dependencies are.

Also lots of code reordering in Flutter driver to make the code
consistent and apply the style guide more thoroughly.
2017-07-21 16:39:04 -07:00
Collin Jackson
e0f3001fde Fix physics with NestedScrollView (#11326)
* Fix physics with NestedScrollView

* Review feedback
2017-07-21 18:42:12 -04:00
Ian Hickson
1f08bda304 AnimatedCrossFade layout customisation (#11343)
* Optimise AnimatedSize for the tight case.
* Remove `default` from a switch statement over enum (so that analyzer will complain if we add enum values).
* Adopt the Size since we use it after the child may have changed (which would throw normally).
* AnimatedCrossFade.layoutBuilder
2017-07-21 15:23:55 -07:00
Phil Quitslund
f0c2d5eddc Flutter create widget test template. (#11304)
* Flutter create widget test template.

Running `flutter create —with-widget-test` produces a test/widget_test.dart sample widget test.

* Generate widget test bits in flutter create.

* Path fix.

* Added types.

* Skip shell testing on windows.

* formatting fixes

* Update test sample to test the sample app.

* Formatting tweak.
2017-07-21 15:11:59 -07:00
Phil Quitslund
c0e9809653 Bump Dart SDK to 1.25.0-dev.7.0. (#11342) 2017-07-21 11:43:30 -07:00
gspencergoog
e4860ef0eb Fix Navigator.pop for named routes. (#11289)
* Prefix and Suffix support for TextFields

* Adding Tests

* Removing spurious newline.

* Fixing a small problem with the test

* Code review changes

* Code Review Changes

* Review Changes

* Export the new StrokeJoin enum

* Added example for line styles, and enabled line join styles.

* Reverting inadvertent change to main.dart.

* Updated due to code review of engine code

* Removed example.

* Added arguments to named routes, with test.

* Fixing some formatting

* Fixing Navigator.pop for named routes.

* Fixing comment.

* Simplifying test.

* Fixing new -> const for Text object.

* Tiny text change (also to kick a new Travis build)

* Added a more realistic test case.

* Reverting unintentional iml changes.

* Fixing trailing newline

* Removing some changes that snuck in.
2017-07-21 11:12:21 -07:00
xster
aa096b50af iOS text selection (#11224)
Extract common text selection overlay logic from Material to Widget and create a Cupertino version of the overlays
2017-07-21 11:33:17 -04:00
Devon Carew
3b35c0c9fc copy the dart sdk directory when we're upgrading it (#11331) 2017-07-20 21:34:27 -07:00
Jason Simmons
9d901327a4 Do not call saveLayer for physical model layers whose bounds are simple rectangles (#11324)
This is similar to an optimization done in PhysicalModelLayer::Paint in the engine
2017-07-20 17:06:57 -07:00
Ian Hickson
48427cb77a Revert "Flutter analyze watch improvements (#11143)" (#11328)
This reverts commit e13e7806e37a28cfef766b72a6987593063b8d34.

Turns out that with this patch, we aren't actually catching all
errors. For example, `flutter analyze --flutter-repo --watch` didn't
report errors in `dev/devicelab/test/adb_test.dart`.
2017-07-20 14:47:36 -07:00
Michael Goderbauer
8e38848203 Fix sample code and update docs (#11257)
* fix sample code

* review comments

* review comments

* document other members for extra bonus points
2017-07-20 14:26:52 -07:00
Mary
bb15e346bb Add slider customizations (#11185)
* adds inactiveColor and showThumb to Slider

* add customizable color and showThumb tests

* remove showThumb, add negative tests
2017-07-20 11:15:22 -07:00