8871 Commits

Author SHA1 Message Date
Todd Volkert
56700930a5 Rev engine to 5fcfb995bbce72b5f1ee807121f51a3c0280c8b4 (#11318) 2017-07-19 21:26:35 -07:00
Carlo Bernaschina
e890ec5bb6 Fix 'reloadSources' service from Observatory (#11315)
Fixes https://github.com/flutter/flutter/issues/11314
2017-07-19 18:37:54 -07:00
Ian Hickson
194bf41ee8 Don't relayout a Text if only its color changed. (#11313) 2017-07-19 17:53:32 -07:00
Jason Simmons
6dbf2269f0 Create one listener that merges the leading and trailing glow controllers and use it in each paint (#11311)
If a new listener is created for each paint, then the leading and trailing
controllers will accumulate and invoke a list of all those listeners
2017-07-19 17:32:39 -07:00
Carlo Bernaschina
741598d848 Fix restart/reload benchmark synchronization (#11282)
Changes introduced in
8ba522eeae
has removed from the `_flutter.listViews` the thread synchronization
side effect used during benchmarks.

The thread synchronization is restored via the new
`_flutter.flushUIThreadTasks` RPC.

Fixes https://github.com/flutter/flutter/issues/11241

Related https://github.com/flutter/engine/pull/3898
2017-07-19 16:54:10 -07:00
Ian Hickson
0b392665bf More debug help. (#11308) 2017-07-19 16:51:16 -07:00
Carlo Bernaschina
05ccad7de0 Roll engine to 53c9a702821b154f137541d4a528fbd25f00ad1b (#11310)
Required for https://github.com/flutter/flutter/pull/11282
2017-07-19 16:49:40 -07:00
Michael Goderbauer
b5c461a917 a11y: implement new SemanticsAction "showOnScreen" (v2) (#11156)
* a11y: implement new SemanticsAction "showOnScreen" (v2)

This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen.

This requires engine rolled to flutter/engine#3856.

I am in the process of adding tests, but I'd like to get early feedback to see if this approach is OK.

* fix null check

* review comments

* review comments

* Add test

* fix analyzer warning
2017-07-19 16:40:24 -07:00
Hans Muller
d767ac0be5 Fixed a dartdoc sample code typo (#11306) 2017-07-19 16:33:55 -07:00
Yegor
669e13ebd4 AnimatedSize: state machine, tests, animate only when needed (#11305) 2017-07-19 15:53:28 -07:00
Yegor
02b65bc984 AnimatedCrossFade: shut off animations & semantics in faded out widgets (#11276)
* AnimatedCrossFade: shut off animations & semantics in faded out widgets

* address comments
2017-07-19 15:45:31 -07:00
Ryan Macnak
63b686709d Roll engine to "Speculatively disable GN argument 'enable_profiling' to test its effect on benchmarks." (#11303) 2017-07-19 14:18:30 -07:00
Ian Hickson
e1adc525d8 Option to enable the performance overlay from 'flutter run'. (#11288) 2017-07-19 12:57:22 -07:00
Ian Hickson
77b0c1dab0 Don't pass "null" to debugPrint. (#11265)
debugDumpLayerTree in particular was passing null in profile mode since debugLayer isn't available in profile mode.
2017-07-19 12:57:13 -07:00
Michael Goderbauer
1744e8e0aa Expose the currently available semantic scroll actions (#11286)
* Expose the currently available semantic scroll actions

* review comments

* add test

* refactor to set
2017-07-19 12:21:36 -07:00
Michael Goderbauer
bc4a3f1703 Work around to fix appveyor build (#11295)
* work around for appveyor connectivity issues

Unfortuantelly, this slows down our build :(

* review feedback
2017-07-19 12:05:30 -07:00
Todd Volkert
df5cb390e2 Rev engine to 488584f8b7cf188d4699880d7b55144cd48067bf (#11291) 2017-07-19 10:55:56 -07:00
Dan Rubel
e13e7806e3 Flutter analyze watch improvements (#11143)
* flutter analyze --watch auto detect if in flutter repo
* move isFlutterLibrary from AnalyzeOnce into AnalyzeBase for use by AnalyzeContinuously
* pass --flutter-repo to analysis server when analyzing the flutter repository
* enhance flutter analyze --watch to summarize public members lacking documentation
2017-07-19 07:22:38 -04:00
Devon Carew
c186d0df1c pass the value of the android sdk (#11268)
* pass the value of the android sdk

* swap flag

* allow the user to set the android-sdk location
2017-07-18 18:47:20 -07:00
Hans Muller
daa7860ef0 Add a ScrollController parameter to NestedScrollView (#11242) 2017-07-18 18:24:38 -07:00
Michael Goderbauer
5f9e5605a6 Fix analyzer errors (#11284) 2017-07-18 17:24:56 -07:00
Jeff Brown
9480a3e591 Use Fuchsia system compositor for physical model layers. (#11164)
On Fuchsia, the system compositor is responsible for drawing shadows
for physical model layers with non-zero elevation.

Also fixed a bug where _needsCompositing was not being cleared prior
to updating it.
2017-07-18 15:30:08 -07:00
Todd Volkert
c464dd5d2d Mark flutter_gallery__transition_perf_with_semantics as flaky (#11281) 2017-07-18 14:57:01 -07:00
Todd Volkert
46b2e88612 Roll engine to c757fc74512fe9039a31e194906bf3700b4c1319 (#11266)
Fixes https://github.com/flutter/flutter/issues/11238
2017-07-17 22:51:56 -07:00
Jason Simmons
71c374af7c Add a flag that controls autocorrect on text fields (#11180)
See https://github.com/flutter/flutter/issues/11168
2017-07-17 17:49:03 -07:00
najeira
898c19d753 add physics to TabBarView (#11150) 2017-07-17 16:59:43 -07:00
Michael Goderbauer
744921fa02 Ensure that a frame is scheduled when a RenderObject calls markNeedsSemanticsUpdate (#11207)
* Ensure that a frame is allways scheduled when a RenderObject marks itself as needing a semantics update

Fixes issue 2 described in https://github.com/flutter/flutter/issues/10971

Previously, an object could call `markNeedsSemanticsUpdate` and its wish would never be granted because no frame was scheduled that would actually update the semantics. This caused an issue during scrolling on Android where at the end of the scroll the `RenderIgnorePointer` would stop blocking the semantics of the scrolled view, call `markNeedsSemanticsUpdate`, but then no frame was scheduled to actually put the semantics of the scrolled view back into the semantics tree. That made the scrolled view unusable for a11y users.

At first I was a bit wary to call `requestVisualUpdate` within `markNeedsSemanticsUpdate` because technically the visual is fine, we only need the frame it schedules to update the semantics. However, it seems like we are using `requestVisualUpdate` for exactly that purpose in other places already where we just need an update to the semantics (e.g. 76a50fe0ca/packages/flutter/lib/src/rendering/object.dart (L2408)).

* add tests
2017-07-17 16:49:05 -07:00
Carlo Bernaschina
16037e33ec Register tools as a reloadSources service (#11258)
In
df8bf384eb
a new functionality of the Dart VM Service Protocol has been introduced.

Clients connected to the Service Protocol are now able to expose
services that other clients (e.g. Observatory) can invoke through the
Service Protocol itself.

With these changes Flutter Tools register them self as a `reloadSources`
(a.k.a. HotReload) capable client.
Observatory is already listening for the clients which expose this
functionality and uses by default the service based version of
`reloadSources` when available, so requesting a HotReload from
Observatory will trigger the full Flutter HotReload.

Related https://github.com/dart-lang/sdk/issues/30023
Related https://github.com/flutter/flutter/pull/11229
Related https://github.com/flutter/flutter/pull/11256
2017-07-17 15:13:24 -07:00
Ryan Macnak
1650420db5 Update --local-engine to account for changed host architecture of 32-bit Android debug builds. (#11263)
Roll engine to 03e642bc8940441bbad5c2fb7d3ca868c1fdad54.
2017-07-17 14:56:27 -07:00
Sarah Zakarias
c838c19e7f Fix ios doc url (#11262) 2017-07-17 23:42:13 +02:00
Ryan Macnak
fce76bcfd6 Revert "Update --local-engine to account for changed host architecture of 32-bit Android debug builds. (#11251)" (#11259)
This reverts commit 3f514fcfdf573c86378ae30c38bbfd21ec15b9f1.
2017-07-17 13:47:03 -07:00
Carlo Bernaschina
16ae29b56d Revert "Register tools as a reloadSources service (#11229)" (#11256)
This reverts commit 35c4989795b3b12d07d3f0be1f27878a5895ac5d.
2017-07-17 13:05:16 -07:00
Carlo Bernaschina
35c4989795 Register tools as a reloadSources service (#11229)
* Register tools as a reloadSources service

* Fix code style and comments

* Fix nits and Add documentation

* Format error message
2017-07-17 12:31:43 -07:00
Ryan Macnak
3f514fcfdf Update --local-engine to account for changed host architecture of 32-bit Android debug builds. (#11251)
Roll engine to 7480e32854606e554ae37f8bd241c050bdc565c4.
2017-07-17 12:20:14 -07:00
Todd Volkert
b7ababe68c Remove unused DevFsProgressReporter (#11249)
Discovered dead code during review of #10791
2017-07-17 09:30:56 -07:00
xster
5756d62931 Fix overscroll friction for small lists (#11243) 2017-07-14 18:33:20 -07:00
Michael Goderbauer
b619759133 Adds a RouteObserver (#11236)
* Adds a PageRouteObserver

Required for https://github.com/flutter/plugins/pull/174.
See also https://github.com/flutter/flutter/issues/11216.

* formatting fixes

* Make RouteObserver generic
2017-07-14 17:44:30 -07:00
Jason Simmons
e967b4b3c5 Improve the year selector UI in the date picker (#11214)
Fixes https://github.com/flutter/flutter/issues/10917
2017-07-14 15:08:10 -07:00
Michael Goderbauer
6ac0f61234 Gallery: remove unused code and a11y fix (#11209) 2017-07-14 14:44:11 -07:00
Siva Chandra
28d09d1614 Fix style issues introduced by dba29aa0fce684b201c6b03efc73ba607c7b507b (#11203) 2017-07-14 13:51:16 -07:00
Todd Volkert
535a364c2a Add more docs to OrientationBuilder (#11233) 2017-07-14 11:54:20 -07:00
Phil Quitslund
05562d5734 Quiet debug test runner output when in machine mode. (#11228)
* Quiet debug test runner output when in machine mode.

See: https://github.com/flutter/flutter-intellij/issues/1176

* json => machine
2017-07-14 11:20:50 -07:00
Todd Volkert
547708b327 Roll engine to f56da86f9807a7d4c924cdb5a28d77baad0537b1 (#11219) 2017-07-13 18:08:14 -07:00
Jason Simmons
38606a7db6 Update the docs for the flutter_tools tests (#11218) 2017-07-13 17:38:11 -07:00
Chris Bracken
862b33ec7a Declare missing dependencies in pubspec (#11217)
flutter_tools depends on cli_util, plugin, and stream_channel but hadn't
explicitly declared them as dependencies.
2017-07-13 17:29:52 -07:00
Todd Volkert
4196582708 Bump file,process,platform to newest versions (#11211) 2017-07-13 16:59:18 -07:00
Chris Bracken
cf96c7db4a Clean up orphaned Instruments processes (#11189)
In some cases, we've seen interactions between Instruments and the iOS
simulator that cause hung instruments and DTServiceHub processes. If
enough instances pile up, the host machine eventually becomes
unresponsive.

Until the underlying issue is resolved, manually kill any orphaned
instances (where the parent process has died and PPID is 1) before
launching another instruments run.
2017-07-13 16:19:11 -07:00
Devon Carew
bde8a5f5a6 move away froma deprecated method (#11215) 2017-07-13 16:18:40 -07:00
Jason Simmons
14648e9bae Suppress an analyzer warning about cli_util.getSdkDir deprecation (#11213) 2017-07-13 15:48:11 -07:00
Jason Simmons
803cc7bc6a Pin package versions used by devicelab to match other Flutter components (#11212) 2017-07-13 15:28:34 -07:00