1768 Commits

Author SHA1 Message Date
Chinmay Garde
6143492e6e Format trace file names so they are easier to organize 2015-10-08 11:50:51 -07:00
Hans Muller
3cfc9c4d95 Allow Stacks with no children or only poisitioned children 2015-10-08 11:09:41 -07:00
Adam Barth
6111301a9b Merge pull request #1540 from abarth/rm_button_state
Remove ButtonState
2015-10-08 10:29:32 -07:00
Adam Barth
67367974ef Merge pull request #1538 from abarth/fix_snackbar
SnackBar throws exception on creation
2015-10-08 10:27:58 -07:00
Adam Barth
3308ff0026 Remove ButtonState
Clients should just use a GestureDetector (or an InkWell) instead.
2015-10-08 10:26:34 -07:00
Hans Muller
09d26302cb IndexedStack
Added horizontal and vertical alignment properties to Stack so that the origin of non-positioned children can be specified. Currently all of the non-positioned children just end up with their top-left at 0,0. Now, for example, you can center the children by specifying verticalAlignment: 0.5, horizontalAlignment: 0.5.

Added IndexedStack which only paints the stack child specified by the index property. Since it's a Stack, it's as big as the biggest non-positioned child. This component will be essential for building mobile drop down menus.

Added a (likely temporary) example that demonstrates IndexedStack.
2015-10-08 10:21:24 -07:00
Adam Barth
6b1c85a8b0 SnackBar throws exception on creation
It was trying to grab the route's performance before it was created. Now we
create the performance eagerly again.
2015-10-08 10:17:19 -07:00
Adam Barth
2da0eb9769 Merge pull request #1500 from abarth/drawer_animate_back
The Drawer should animate out when popped off the navigator
2015-10-08 10:16:34 -07:00
Adam Barth
a8ea45f9e0 Merge pull request #1535 from abarth/button_highlight
FlatButton highlights but doesn't tap around edge
2015-10-08 10:14:40 -07:00
Viktor Lidholt
dd6d467657 Merge pull request #1526 from vlidholt/master
Adds support for applying forces and impulses to sprite physics
2015-10-08 10:13:58 -07:00
Hans Muller
da4f7b988a BoxConstraints.toString() should show closed intervals 2015-10-08 09:55:51 -07:00
Adam Barth
1cea4846bd FlatButton highlights but doesn't tap around edge
Now we trigger the highlight from the InkWell so that it matches the tap.

Fixes #1525
2015-10-08 09:45:29 -07:00
Adam Barth
d234ed932e Re-enable passing tests 2015-10-07 20:12:39 -07:00
Adam Barth
68acd2615d The Drawer should animate out when popped off the navigator
Now with more clear ownership over the Performance.
2015-10-07 20:09:45 -07:00
Hixie
d45bf1457c HomogeneousViewport support for Theme.of()
Previously, RenderObjectElements didn't support being marked dirty. This
is fine, except for MixedViewport and HomogeneousViewport, which have
builder functions to which they hand themselves as a BuildContext. If
those builder functions call, e.g., Theme.of(), then when the theme
changes, the Inherited logic tries to tell the RenderObjectElement
object that its dependencies changed and that doesn't go down well.

This patch fixes this by making RenderObjectElement a BuildableElement,
and making MixedViewport and HomogeneousViewport hook into that to
rebuild themselves appropriately.

Also, this was only found at all because ThemeData didn't implement
operator==, so we were aggressively marking the entire tree dirty all
the time. That's fixed here too.

Also, I changed card_collection.dart to have more features to make this
easier to test. This found bugs #1524, #1522, #1528, #1529, #1530, #1531.
2015-10-07 15:53:50 -07:00
Viktor Lidholt
020e749291 Fixes typo in sprite physics 2015-10-07 14:05:11 -07:00
Viktor Lidholt
c363133da3 Adds support for applying forces and impulses to sprite physics 2015-10-07 13:26:36 -07:00
Adam Barth
3eaefd812e Merge pull request #1518 from abarth/performance_route
Separate Route and PerformanceRoute
2015-10-07 13:08:33 -07:00
Chinmay Garde
9f8b53f47a Document StatisticsOverlay.rasterizerThreshold 2015-10-07 11:47:30 -07:00
Chinmay Garde
73dce01e87 Allow updating the rasterizer tracing threshold from Dart 2015-10-07 11:22:51 -07:00
Adam Barth
30d16e2426 Separate Route and PerformanceRoute
This patch prepares us to create routes that control their performances more
closely.
2015-10-07 09:58:01 -07:00
Mehmet Akin
90d47520fd Make checkbox widget to fit more closely to material design standard. Make changes to remove animation artefacts. 2015-10-07 01:01:54 +02:00
Hans Muller
cf17dd9687 Merge pull request #1509 from HansMuller/remove_popup_menu_margin
Remove PopupMenu margin

The margins make using showMenu's menuPosition argument difficult and they're not really needed.

I also made a few small gratuitous changes in navigator.dart.
2015-10-06 11:03:23 -07:00
Hans Muller
56d9d85f2a Remove PopupMenu margin
The margins make using showMenu's menuPosition argument difficult and they're not really needed.

I also made a few small gratuitous changes in navigator.dart.
2015-10-06 10:55:31 -07:00
Adam Barth
66c6ce3794 Merge pull request #1507 from abarth/image_decoding
NetworkImage occasionally does not grab the image
2015-10-06 10:51:21 -07:00
Viktor Lidholt
ebaa45c788 Merge pull request #1508 from vlidholt/master
Improvements to sprite physics
2015-10-06 10:44:47 -07:00
Viktor Lidholt
b6e12ca9aa Forwards physics body properties to box2d in sprite physics 2015-10-06 10:39:26 -07:00
Adam Barth
8b1effc544 NetworkImage occasionally does not grab the image
I haven't been able to reproduce this bug consistently, but my theory is that
the ImageDecoder was being garbage collected before it called its completion
callback. This patch prevents that by keeping a reference to the image decoder
while the callback is in flight.

Fixes #801
2015-10-06 10:37:55 -07:00
Adam Barth
2d0d1645be Merge pull request #1503 from abarth/simplify_scaffold
Simplify Scaffold
2015-10-06 10:09:35 -07:00
Adam Barth
932626aad1 Merge pull request #1504 from abarth/tab_shadow
ToolBar with a TabBar shouldn't have a shadow
2015-10-06 10:08:11 -07:00
Adam Barth
89a09822bf Simplify Scaffold
Rather than using a custom render object, we can just use a Stack.
2015-10-06 10:06:17 -07:00
Viktor Lidholt
5ac4d1ea28 Adds forwarding of properties to box2d in sprite physics 2015-10-06 09:59:16 -07:00
Viktor Lidholt
a07cb95ec2 Merge pull request #1506 from vlidholt/master
Fixes to demo game
2015-10-06 09:57:21 -07:00
Adam Barth
ee0c01c54c Merge pull request #1501 from abarth/initial_page
PageableList should take initialPage instead of initialScrollOffset
2015-10-06 09:51:35 -07:00
Adam Barth
7f6346789f Rev pub package 2015-10-06 09:51:00 -07:00
Adam Barth
6c30e01bef Make MimicableState public again
This state object has a public API.
2015-10-06 09:33:33 -07:00
Viktor Lidholt
018cef6160 Adds default text style 2015-10-06 09:28:05 -07:00
Adam Barth
6cf105fe3e ToolBar with a TabBar shouldn't have a shadow
This patch makes the level of the ToolBar configurable. I've also cleaned up
the Tab code slightly.

For some reason, there's still a hairline between the ToolBar and the TabBar.
We might need to rethink how we draw the background a bit here.

Fixes #1454
2015-10-05 23:41:14 -07:00
Adam Barth
922aece1d5 Mark most State subclasses private
In the vast majority of cases, folks should be interacting with the Widget
rather than its State.

Fixes #267
2015-10-05 21:54:33 -07:00
Adam Barth
7ac6ab6fc7 PageableList should take initialPage instead of initialScrollOffset
Fixes #900
2015-10-05 21:36:23 -07:00
Adam Barth
330af86bdc Delete AnimatedComponent
This class has no clients.
2015-10-05 17:35:51 -07:00
Ian Hickson
012c5d94a1 Merge pull request #1496 from Hixie/focus
Fix Focus
2015-10-05 17:32:52 -07:00
Adam Barth
5a359dce9f Merge pull request #1484 from abarth/snackbar_route
Use Navigator to drive SnackBar
2015-10-05 17:32:47 -07:00
Adam Barth
706b272eaf Create the Performance for a Route earlier
Instead of waiting until build(), we now create the performance for a route in
its constructor.
2015-10-05 17:20:08 -07:00
Adam Barth
2eec30111a Use Navigator to drive SnackBar
Now SnackBar is an ephemeral route that uses a Placeholder to put itself into
the Scaffold.

Fixes #673
2015-10-05 17:12:50 -07:00
Hixie
fbf8174c87 Fix Focus
Focus.at() and company should be on Focus, not FocusState.

_notifyDescendants() was using the wrong runtimeType.

Let InheritedWidget update the descendants during build.

When you setState() during build, assert that you're not
markNeedsBuild()ing someone who isn't a descendant.

Typo in Widget.toString().
2015-10-05 16:41:50 -07:00
Viktor Lidholt
ff3e636635 Makes physics bodies fixture elements settable 2015-10-05 16:13:32 -07:00
Ian Hickson
48142d6872 Merge pull request #1490 from Hixie/navigator-ensure-pop
Handle a route being dismissed before being popped
2015-10-05 13:59:59 -07:00
Ian Hickson
4913c4fc7d Merge pull request #1489 from Hixie/cleanup
Add more debugging information to Widgets.
2015-10-05 13:59:56 -07:00
Hixie
90a0f6300f Simplify the usage of Navigator's routes argument
(These are changes cherry-picked from in-flight branches since they are
more independent and could be helpful even without those changes.)

- Change RouteBuilder's signature to take a single argument in which the
  other fields are placed, so that we can keep iterating on those
  arguments without having to break compatibility each time. Also, this
  makes defining route builders much simpler (only one argument to
  ignore rather than a variable number).

- Expose the next performance to RouteBuilders, since sometimes the
  route itself might not be where it's used.

- Allow BuildContext to be used to walk children, just like it can for
  ancestors

- Allow BuildContext to be used to get the Widget of the current
  BuildContext

- Allow StatefulComponentElement to be referenced with a type
  specialisation so that you don't have to cast when you know what the
  type you're dealing with actually is.
2015-10-05 13:59:30 -07:00