Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) ( #120842 )
...
* lerp documentation
* Remove Note, Note That from repo
* Improve BorderSide documentation.
* apply review comments
2023-02-17 22:27:33 +00:00
Casey Hillers
298d8c76ba
Revert "Remove references to Observatory ( #118577 )" ( #120929 )
...
This reverts commit 2df140f40d8c771ecef4f21cbdf635ec1235b4ac.
2023-02-16 21:28:30 -08:00
Danny Tuppeny
cacef57b6e
[flutter_tools] Skip over "Resolving dependencies..." text in integration tests ( #120077 )
...
Sometimes when the integration tests run Flutter apps they get this output (perhaps based on timing of file modification times). Some of the tests want to verify strict output but not fail just based on these lines before the app starts.
See https://github.com/flutter/flutter/issues/120015 / https://github.com/flutter/flutter/pull/120016 .
2023-02-16 10:12:16 -08:00
Christopher Fujino
c6b636fa51
[flutter_tools] Replace Future.catchError() with Future.then(onError: ...) ( #120637 )
...
* wip run_local_linter.dart
* get run_local_linter.dart working
* slow working implementation
* speed up run_local_linter.dart
* fix run_local_linter.dart
* remove catchError
* another fix
* fix another
* fix
* more fixes
* fix moar
* fix moar
* fix
* finish
* fix tests
* clean up further
* code review
* delete run_local_linter.dart
2023-02-15 19:03:00 +00:00
Zachary Anderson
a664f08a56
In test of --(no-)fatal-infos analyzer flags, pin missing_return to info ( #120797 )
...
* In test of --(no-)fatal-infos analyzer flags, pin missing_return to info
* Remove trailing spaces
2023-02-15 17:21:49 +00:00
Jackson Gardner
4b8ad1b007
Temporarily disable info-based analyzer unit tests. ( #120753 )
...
We should address this more permanently:
https://github.com/flutter/flutter/issues/120750
2023-02-15 06:29:23 +00:00
Ben Konyi
2df140f40d
Remove references to Observatory ( #118577 )
...
Observatory is being deprecated for Dart 3.0 so it should no longer be
referenced in tooling messaging / flags.
See https://github.com/dart-lang/sdk/issues/50233
2023-02-13 14:29:30 -05:00
Mouad Debbar
d5dbcb7085
Revert "Revert "[web] Move JS content to its own .js files ( #117691 )" ( #120275 )" ( #120363 )
...
This reverts commit 0fb4406c30d6427044fa8322a6278b92982cc22b.
2023-02-10 21:24:08 +00:00
Jonah Williams
425ab5dca5
Remove test that verifies we can switch to stateless ( #120390 )
2023-02-09 20:58:57 +00:00
Michael Thomsen
c8c8621416
Clean up null safety messages ( #120350 )
2023-02-09 19:40:32 +01:00
Kevin Chisholm
0fb4406c30
Revert "[web] Move JS content to its own .js files ( #117691 )" ( #120275 )
...
This reverts commit e03029ef6a0c2040476bf6602da4e5d1271eb77d.
2023-02-08 18:17:29 -06:00
Mouad Debbar
e03029ef6a
[web] Move JS content to its own .js files ( #117691 )
2023-02-07 10:51:52 -05:00
Ben Konyi
47a0674651
Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119737 )
...
This reverts commit 254a796bc3f8a32d3e09c1416bce7b7b9f1ba33b.
2023-02-06 09:23:35 -05:00
Brandon DeRosier
f10e625eb2
De-flake adapter integration test ( #120016 )
2023-02-04 15:29:59 -08:00
Danny Tuppeny
8387c2388b
[flutter_tools] Use base DAP detach and ensure correct output ( #119076 )
2023-02-02 13:28:12 -08:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real ( #119673 )
...
* Make Flex,Row,Column const for real
* dart fix --apply
* fix snippets
* fix integration test
* add comment
2023-02-02 19:33:57 +00:00
Ian Hickson
4c99da6c56
Avoid printing blank lines between "Another exception was thrown:" messages. ( #119587 )
2023-02-01 23:57:54 +00:00
Zachary Anderson
254a796bc3
Revert "Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119529 )" ( #119729 )
...
This reverts commit 7477d7ac79debc06e92a72cec3f59178c74bc44d.
2023-02-01 09:19:48 -08:00
Ben Konyi
7477d7ac79
Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119529 )
...
* Reland "Add --serve-observatory flag to run, attach, and test (#118402 )"
This reverts commit 86ab01d2bd82333be7a0cd4957903f424de02104.
* Fix flaky failures
* Fix VM service disappearing failure
2023-01-30 21:00:18 +00:00
Zachary Anderson
86ab01d2bd
Revert "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119302 )
...
This reverts commit 6cd4fa45e2680bba871a7d65ddce4a59f68f6d72.
2023-01-26 16:43:39 -08:00
Ben Konyi
6cd4fa45e2
Add --serve-observatory flag to run, attach, and test ( #118402 )
...
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.
2023-01-25 12:46:08 -05:00
Michael Goderbauer
38630b6bd1
Remove unnecessary null checks in flutter_tool ( #118857 )
...
* dart fix --apply
* manual fixes
* fix after merge conflicts
* review
2023-01-23 21:43:08 +00:00
Danny Tuppeny
09bd0f6613
Support logging 'flutter run' communication to DAP clients ( #118674 )
...
* Support logging 'flutter run' communication to DAP clients
Fixes https://github.com/Dart-Code/Dart-Code/issues/4266 .
* Fix test
2023-01-19 23:50:33 +00:00
Alex Wallen
1dd7f45bfb
Add build macos --config-only option. ( #118649 )
...
Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-19 21:29:17 +00:00
Christopher Fujino
374f09e1a6
[flutter_tools] No more implicit --no-sound-null-safety ( #118491 )
...
* remove implicit no-sound-null-safety
* add test
* bump sdk constraint in test file
2023-01-18 20:46:09 +00:00
joshualitt
8f365a3bdc
[web] Update build to use generated JS runtime for Dart2Wasm. ( #118359 )
2023-01-12 13:46:39 -08:00
Vyacheslav Egorov
025ce117b7
Correctly propagate verbosity to subtasks in flutter.gradle ( #117897 )
...
* Correctly propagate verbosity to subtasks in flutter.gradle
* Add test
* Revert accidental changes
* Fix copyright year
* Fix imports
2023-01-04 09:54:21 +00:00
Ahmed Ashour
b9ead37244
Simplify null check. ( #117026 )
...
* Simplify null check.
* Simplify null check.
* Simplify null check.
* Fix.
2023-01-03 20:51:48 +00:00
Jesús S Guerrero
fe8dcf6631
[flutter_tools] timeline_test.dart flaky ( #116667 )
...
* contains name instead of remove last
* fix expect
* remove and expect on elements
* delete unused code
2023-01-03 20:44:53 +00:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints ( #117365 )
2022-12-20 16:03:21 -08:00
Jackson Gardner
9f2c5d8e21
Support flutter build web --wasm ( #117075 )
...
* Work in progress.
* Some fixes to the command line.
* Bootstrapping works.
* Change kickoff order to maximize concurrency.
* Fix analyzer errors and formatting issues.
* Fix doc comment.
* Added unit tests for some of the web targets.
* Format issue.
* Add an integration test that builds an app to wasm.
* Add a todo for depfiles.
* Formatting.
* Apparently the license header needs to say 2014.
* `file://` URIs confuse dart2wasm on Windows. Just use absolute paths.
* Update unit tests to match new path passing.
* Have a distinct build directory for wasm, and fixes for some upstream changes.
2022-12-19 20:09:02 +00:00
Jackson Gardner
ebeb491895
Use the name of errors, not the diagnostic messages. ( #117229 )
...
* Use the name of errors, not the diagnostic messages.
* Trailing comma.
2022-12-16 22:19:55 +00:00
Ian Hickson
9fdb64b7e7
Taboo the word "simply" from our API documentation. ( #116061 )
2022-12-11 22:43:22 +00:00
Siva
7c8e171320
Manual Roll of Flutter Engine from 67254d6e4b03 to 8d83b98c55b3 ( #116635 )
...
* Roll Flutter Engine from 67254d6e4b03 to 8d83b98c55b3
* Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0) (#38105 )
* Bump SDK versions.
* Bump Dart SDK version constraints
* Update shrine package to 2.0.1 (null safe version)
* Fix more tests.
* Include patches from Jason for min android sdk version
* Fix analyzer warning
2022-12-08 18:03:51 -08:00
Jackson Gardner
db1c3e208d
Platform binaries reland ( #115502 )
...
You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified.
This also uses precompiled platform kernel files for both ddc and dart2js
2022-12-02 14:13:40 -08:00
Nehal Patel
3b15d6a501
Removes retries from "dart pub get" and un-buffers its stdout/stderr output ( #115801 )
...
* Removes retries from "pub get" and proxies its stdout output
* Fix issue where ErrorHandlingProcessManager does not forward "mode" parameter to backing ProcessManager's "start" method
* Make "pub get" use ProcessStartMode.inheritStdio instead of forwarding bytes to stdout and stderr
* Fix tests
* Remove unused env var
* Add back 'Running "flutter pub get"...' status log
* Fix indent
* Add Pub.test() constructor which lets tests mock stdio
2022-12-01 19:30:17 +00:00
Gary Qian
6e8ebb3771
Reland "Upgrade targetSdkVersion and compileSdkVersion to 33" ( #116146 )
2022-12-01 07:12:47 -08:00
Sam Rawlins
f255390f4d
Remove redundant arguments passed to redirecting factory constructors ( #115497 )
2022-11-17 00:47:14 +00:00
Christopher Fujino
a2233eabed
[flutter_tools] remove all body_might_complete_normally_catch_error ignores ( #115184 )
...
* remove all body_might_complete_normally_catch_error ignores
* add a test
2022-11-16 18:20:45 +00:00
Elias Yishak
d7454d552a
removing default values for [reporter] and [timeout] in flutter test ( #115160 )
...
* removing default values for [reporter] and [timeout]]
* passing reporter arg to see tests pass
* added test to confirm TestCommand is not passing defaults
* add'l helper message for [reporter] arg
* default behavior for github actions + fixed tests
* removing github conditional for reporter + related test
* removing unused import
2022-11-16 18:20:42 +00:00
Jonah Williams
59ecc75748
[flutter_tools] add uint compilation test ( #115317 )
...
* [flutter_tools] add uint compilation test
* Update shader_compiler_test.dart
2022-11-15 01:39:59 +00:00
Danny Tuppeny
09a4f23467
Prevent tests from producing dill files alongside the test file ( #115075 )
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4243 .
2022-11-10 20:00:19 +00:00
Zachary Anderson
a84e369bd2
Revert "Allow Flutter golden file tests to be flaky ( #114450 )" ( #114902 )
...
This reverts commit 53e6876226a7729531be7be4fa7321363c5a3b30.
2022-11-08 09:26:55 -08:00
Kate Lovett
53e6876226
Allow Flutter golden file tests to be flaky ( #114450 )
...
* allow marking a golden check as flaky
* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib
* Pause
* ++
* ++
* Analyzer therapy
* Once more with feeling
* Nits
* Review feedback
* Silly oops
* Test progress
* More tests
* Finish
* Nits
* Analyzer
* Review feedback
Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
Jonah Williams
e4e902dced
[flutter_tools] add compilation failure tests for new cases added in impellerc ( #114757 )
2022-11-07 20:59:13 +00:00
Tae Hyung Kim
cef4c2aac8
ICU Message Syntax Parser ( #112390 )
...
* init
* code generation
* improve syntax error, add tests
* add tests and fix bugs
* code generation fix
* fix all tests :)
* fix bug
* init
* fix all code gen issues
* FIXED ALL TESTS :D
* add license
* remove trailing spaces
* remove print
* tests fix
* specify type annotation
* fix test
* lint
* fix todos
* fix subclass issues
* final fix; flutter gallery runs
* escaping for later pr
* fix comment
* address PR comments
* more
* more descriptive errors
* last fixes
2022-11-05 10:26:46 -07:00
Gary Qian
7ab2bf8ff7
Delete flutter_migrate code ( #114253 )
2022-10-31 17:52:05 +00:00
Jonah Williams
4f19a9fa46
[flutter_tools] Add support for compiling shaders to JSON bundle for web ( #114295 )
2022-10-31 16:52:09 +00:00
Lucas Britto
5d93894264
[flutter_tools] Decouple fatal-warnings check from fatal-infos ( #113748 )
2022-10-26 16:44:25 +00:00
Danny Tuppeny
3599b3a877
Add support for expression compilation when debugging integration tests ( #113481 )
...
Fixes #79439 .
2022-10-25 15:34:22 +01:00
