9268 Commits

Author SHA1 Message Date
Greg Spencer
67cf7918cf Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. (#12595)
Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences.

There were a number of differences with the Material Design spec, including
several different padding values and underline thickness.  This corrects
that so that the decorator is in line with the Material Design spec now.

Also, the decorator properly handles changes to the textScaleFactor, where
before it would not re-layout when needed, painting the cursor and
underline incorrectly.

The decorator also now properly animates helper, error, and hint text when
the textScaleFactor or input decoration properties change.

Helper text is now properly displayed in dense mode, as the spec shows.
Before this change, it was never displayed in dense mode.

Fixes #12485
2017-10-19 10:11:07 -07:00
Greg Spencer
7e09649c41 Override just the textScaleFactor (#12530)
Hixie pointed out that what I had before was resetting all of the MediaQuery values, not just textScaleFactor. This should fix that.
2017-10-19 09:24:05 -07:00
Alexander Aprelev
c05da1e29d Stop syncing dart source files when in --preview-dart-2. (#12597)
Syncing source files is not needed when host sends kernel file to the device.
2017-10-19 07:16:15 -07:00
Sarah Zakarias
f74cd91761 Update TextStyle doc and remove package field (#12577) 2017-10-19 10:14:38 +02:00
Sarah Zakarias
e4f53c3abd Add 'package' argument to IconData (#12560) 2017-10-19 09:38:54 +02:00
Alexandre Ardhuin
ce6f8d3a83 comment some lint exclusions (#12601) 2017-10-19 08:33:01 +02:00
Alexandre Ardhuin
700dc9f752 enable lint avoid_function_literals_in_foreach_calls (#12607) 2017-10-19 08:16:16 +02:00
Todd Volkert
79fbf8bb03 Split common matcher into its own file. (#12622)
This aids in running the tests internally in Google
since the libraries upon which tests depend and the
test files themselves are defined separately.
2017-10-18 20:55:00 -07:00
P.Y. Laligand
e938ceb086 Adjust to new location for the Dart project. (#12621) 2017-10-18 19:45:48 -07:00
Michael Goderbauer
a5a75e3d84 Fix tabs Semantics test (#12620)
Merge confliuct between #12605 and #12613
2017-10-18 17:11:50 -07:00
Michael Goderbauer
f8a2bd20e9 Redesign Semantic Tree Compilation Algorithm (#12605)
* Oct 12 10:12am

* implicit_semantics_test.dart passes

* refactoring

* works in nice

* minor rename

* more doc comments

* to be explicit check better

* fix test

* ++

* ++

* semantics_9_test (BlockSemantics) and implicit_semantics_test are passing

* doc updates

* tiny refactor

* fix static errors in tests

* fix gesture detector

* ++

* ++

* geometry

* ++

* remove noGeometry

* revert test

* +

* all tests but scrolling/clipping pass

* clipping works

* scrolling halfway

* sliver tests pass

* ALL TESTS PASS

* SemanticsNode changed

* docs and tiny fixes

* card test

* more doc comments

* remove missed print

* more tests

* make test pass on Linux

* remove changes to intellij proj file

* review comments
2017-10-18 16:28:24 -07:00
Collin Jackson
d47d268719 0.0.17 dev version (#12593) 2017-10-18 16:25:36 -07:00
Michael Goderbauer
9baca00119 Make Tab take a widget as child (#12613)
* Make Tab take a widget as child

This way you can override the semantics information of a Tab (see test).

Fixes https://github.com/flutter/flutter/issues/12432

* more tests

* review comments

* review comment

* doc nits

* style fix
2017-10-18 16:19:54 -07:00
Mihail Slavchev
af0afff111 Workaround a connection issue on iOS 11.0.x (#12444)
On iOS 11.0.x ideviceinfo fails with the following message
ERROR: Could not connect to lockdownd, error code -3

This workaround should also work for #12330
2017-10-18 15:25:49 -07:00
Jason Simmons
264cbf6145 libtxt: adapt a selection rectangle test (#12612)
libtxt's implementation of Paragraph.getBoxesForRange returns the full line
height for all characters in a line.  Blink had been returning a tighter
enclosing rectangle for each individual character.
2017-10-18 14:48:20 -07:00
Adam Barth
f847272fc7 Make FLX construction atomic (#12604)
This patch also makes it possible to create FLX files with no extension.
Previously, the zip tool would add the ".zip" extension if the output file
lacked an extension.
2017-10-18 13:46:17 -07:00
Ian Hickson
0790891600 BoxDecoration.borderRadius and RoundedRectangleBorder.borderRadius RTL (#12603) 2017-10-18 11:24:54 -07:00
Sarah Zakarias
f6135107bc Copy snapshot file into assets (#12523) 2017-10-18 14:52:36 +02:00
xster
822084b235 Add a rootNavigator option to Navigator.of (#12580) 2017-10-18 01:31:29 -07:00
xster
964a138d80 nav bar font styles are special, do not inherit (#12578) 2017-10-18 01:30:43 -07:00
Ian Hickson
d920fdd11a RoundedRectangleBorder (#12591) 2017-10-17 17:58:04 -07:00
Jason Simmons
d8380201bd libtxt: update a test for differences in rounding when calculating line heights (#12572) 2017-10-17 17:45:20 -07:00
Jason Simmons
1f531595cf Use non-whitespace contents in a button padding test (#12568)
libtxt has different policies than Blink for trimming whitespace.  This change
will make the test results consistent in both text renderers.
2017-10-17 17:45:11 -07:00
Collin Jackson
e8aa40eddd release 0.0.17 (#12590) 2017-10-17 15:42:40 -07:00
Ian Hickson
0e34c7f28c CircleBorder (#12570) 2017-10-17 13:38:06 -07:00
Alexander Aprelev
52fbcefed6 Link platform.dill only into app kernel file used for build aot. (#12571)
gen_snapshot loads all packages from single app kernel file.
2017-10-17 13:30:32 -07:00
Ian Hickson
1f82733a3b Make BoxDecoration lerp gradients (#12451)
This still is very limited in what it can lerp, but it sets the stage for arbitrary lerps later.
2017-10-17 13:10:10 -07:00
Adam Barth
a13320253c Don't attempt to draw invisible overflow indicator (#12534)
If the flex is empty, there's no space in which to draw the overflow indicator,
so we shouldn't bother trying to draw it.

Fixes #12532
2017-10-17 11:17:08 -07:00
amirh
3d7a4eed44 Short circuit _checkUp if tap callbacks were triggered by resolve. (#12521) 2017-10-17 10:29:29 -07:00
Hans Muller
bd3e91ed98 AssetImage.obtainKey handles devicePixelRatio == null (#12564) 2017-10-17 09:27:04 -07:00
xster
9ce3ba314e Add Cupertino icon fonts helper and dependency for default template (#12559)
* add CupertinoIcons

* Use new font name convention

* review
2017-10-16 18:59:28 -07:00
P.Y. Laligand
ad72c78342 Fix testing on Fuchsia. (#12563) 2017-10-16 10:58:39 -07:00
Alexander Aprelev
fea1129921 Roll engine to pick up iOS resource bundle fix. (#12558) 2017-10-16 09:39:30 -07:00
Alexander Aprelev
e20bff4d79 Add benchmark score keys to the hot mode test report. (#12547)
This is follow-up to be1467e0cdb233a528077f1db962c46f28bb5820.
2017-10-14 11:29:37 -07:00
Greg Spencer
e697e5523f Add large text switching to Gallery app. (#12443)
This lets us preview widgets in the gallery using small, normal, large, and HUGE text.

Added selections to the main drawer for these options. Defaults to "normal", obviously.
2017-10-13 21:44:24 -07:00
Alexander Aprelev
c2dfa6a186 Change pattern triggering next step. (#12543)
Previously chosen pattern was generated in the output not quite at the end of the hot reload process.
2017-10-13 21:14:51 -07:00
Alexander Aprelev
be1467e0cd Restructure hot mode test so it runs interactively. (#12519)
* Restructure hot mode test so it runs interactively.

This allows to add a benchmark for hot reload after actual source code change.

* Add curly braces, refactory copyRecursive
2017-10-13 20:06:35 -07:00
P.Y. Laligand
0999fca99d Update references to the engine project. (#12515) 2017-10-13 17:16:33 -07:00
Chris Bracken
17db2d2335 Fix nextMonthTooltip Japanese translation (#12540) 2017-10-13 16:38:24 -07:00
Greg Spencer
25ac924e01 Modify the MaterialButton to expand when text is scaled. (#12431)
This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint.

Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols.

Addresses #12311
2017-10-13 16:07:05 -07:00
Alexander Aprelev
6c6d08b9ee Keep incremental compiler state through full restart. (#12535)
* Keep incremental compiler state through full restart.

* Add todo

* Add todo
2017-10-13 15:18:24 -07:00
amirh
3616ebbd30 Emphasize the behavior property in GestureDetector's class doc. (#12536) 2017-10-13 13:33:39 -07:00
Devon Carew
00c4c7b023 de-emphasize the footer of the generated docs (#12514) 2017-10-13 13:31:32 -07:00
Michael Goderbauer
4ffa801cb1 Remove parentSemantics from semantics tree compliation (#12479) 2017-10-13 12:27:23 -07:00
amirh
32c038ee3f Add missing curly braces in icon.dart (#12529)
(post-merge followup for #12516)
2017-10-13 10:20:22 -07:00
gspencergoog
e316956888 Make tooltips scale with textScaleFactor (#12498)
Fixes #12480
2017-10-12 16:44:21 -07:00
gspencergoog
ba0618d35d Make material slider respect textScaleFactor (#12511)
Make material slider respect textScaleFactor

Fixes #5938
2017-10-12 16:43:28 -07:00
Alexander Aprelev
3470c682f4 Make flag out of '--all' option (#12510) 2017-10-12 16:08:29 -07:00
Ryan Macnak
07a4b4c426 Reapply "When parts of the program are changed in a hot reload, but not executed during the reassemble, warn that a restart may be needed." (#12490)
This reverts commit 5e7bcbacf80875730b2002973b5d82cf5331c2a3.

`flutter run --benchmark` was triggering a different quick bailout path in the VM than `flutter run`. The failure has been fixed upstream.
2017-10-12 15:58:40 -07:00
Alexander Aprelev
85e4f0526b Fix restart flow for preview-dart-2 mode. (#12496)
* Fix restart flow for preview-dart-2 mode.

Restart in preview-dart-2 needs to use kernel file and it has to be complete, rather than incremental kernel file.

* Add curly braces

* Do full compile on restart

* Roll engine to pick up changes to hot reload for preview-dart-2
2017-10-12 14:48:37 -07:00