7572 Commits

Author SHA1 Message Date
Alexandre Ardhuin
69b6bb87d1 prefer_is_empty and prefer_is_not_empty (#8474) 2017-03-01 22:17:30 -08:00
Ian Hickson
2f002885cc Allow two shrine order pages to be on the screen at the same time. (#8507)
This happens when, for instance, you go back then forward quickly.
2017-03-01 22:07:37 -08:00
Chris Bracken
5271546794 Better defaulting for scroll view primary-ness (#8506)
* Improved defaults for scroll view primary-ness

* Vertical scroll views default to primary:true.
* Horizontal scroll views default to primary:false.
* If a scroll view is primary and it got a non-null inherited primary
  scroll controller, it introduces a primary scroll controller inherited
  with a value of null for its descendants.

ScrollController now multiplexes writes to all registered positions;
reads of position continue to assert that only one position is
registered. Reads still require a single position.
2017-03-01 16:13:09 -08:00
xster
a76c352d57 Add Cupertino to gallery and add CupertinoButton and many yak friends (#8411)
* Add cupertino to gallery and add CupertinoButto

* Use single quotes

* Add disabled state

* Some review notes

* Make button animation more responsive and tweak timing

* Renamed things Cupertino

* Button with background, move cupertino demos, move material demos

* Move 2 level list too

* Refactor various demo route names

* Some review notes

* More reviews and add test

* Linter as

* Move private constant up
2017-03-01 16:06:48 -08:00
Todd Volkert
9dec5f9016 Change to use mockito_no_mirrors.dart (#8511)
This got missed in the last sweep due to concurrent PRs
2017-03-01 15:34:59 -08:00
Michael Goderbauer
99ca38e988 make use of Dart's new capability to print Unicode on Windows (#8505) 2017-03-01 13:15:48 -08:00
Michael Goderbauer
46f2542b3f Update DArt SDK to 1.23.0-dev.2.0 (#8504)
This one comes with sweet Unicode support for Windows!
2017-03-01 12:59:28 -08:00
Chris Bracken
9f92f7928e Add tests for ScrollController assertions (#8499)
Ensure that read and write operations fail on ScrollControllers
associated with a number of positions other than 1.
2017-03-01 11:18:43 -08:00
Adam Barth
0b7845a5ac Recommend using AlwaysScrollableScrollPhysics with RefreshIndicator (#8498)
Using these physics avoids a problem whereby the scroll view isn't scrollable
due to lack of content and therefore cannot trigger the refresh indicator.

Fixes #8432
2017-03-01 11:04:42 -08:00
Adam Barth
fcf6740851 Factor BackButton out of AppBar (#8491)
This widget is useful on its own. This patch factors it out of AppBar so
folks can use it separately.

Fixes #8489
2017-03-01 10:45:44 -08:00
Michael Goderbauer
17057bb44b [devFS] Use URI to represent paths on device (#8446)
* [devFS] Use URI to represent paths on device

Previosuly, regular file paths in the format of the host platform were used to represent paths on device. That works when host and device share the same (POSIX) file path format. With a Windows host, this breaks. URIs are the solution as they are platform independent and the VM service on the device already interpreted the file paths as URIs anyways.

* review comments

* switch to file paths

* fix tests on Windows

* review comments
2017-03-01 10:11:56 -08:00
Yegor
5ce67b084a driver: remove obsolete TODO (#8494)
This TODO was fixed by the transition to `Finder` objects.
2017-03-01 10:10:39 -08:00
Chris Bracken
297a0341a6 Update scroll tests to use pumpUntilNoTransientCallbacks (#8495)
This ensures that both timer/microtask queues are cleared out rather
than assuming that all work is completed in a specified amount of time.
2017-03-01 10:09:29 -08:00
Michael Thomsen
34c63aff84 Update platform-services to new APIs (#8488) 2017-03-01 17:36:07 +01:00
Michael Thomsen
1b52d46b0e Add missing IntelliJ metadata files to platform_services (#8487) 2017-03-01 15:43:47 +01:00
Mikkel Nygaard Ravn
390993d070 PlatformXxxChannel concepts added to support Flutter/platform interop (#8394)
New concepts: PlatformMessageChannel (basic message send/receive superseding some existing  PlatformMessages methods), PlatformMethodChannel (method invocation and event streams), pluggable codecs for messages and method calls: unencoded binary, string, json, and 'standard' flutter binary encoding.
2017-03-01 14:35:41 +01:00
Jakob Andersen
41d81132f9 Don't print stacktraces from ToolExit errors during flutter run. (#8453)
Instead, actually exit the tool.

Fixes #8363.
2017-03-01 13:15:31 +01:00
Michael Goderbauer
2a9fc2e70e Remove self-package import (#8483)
This is apperently breaking some customers.

If this gets submitted, we should investigate why self-package imports
don't work for certain customers.
2017-02-28 19:45:29 -08:00
Michael Goderbauer
d7d73a302f fix analyzer warning (#8484) 2017-02-28 19:45:22 -08:00
Adam Barth
a9e9e3fde6 CustomSingleChildLayout should support listenable (#8470) 2017-02-28 19:09:58 -08:00
Michael Goderbauer
65835af4e6 Roll forward #8467 (#8477)
* Revert "Revert "Simplify path handling logic in dependency checker and devFS (#8414)" (#8467)"

This reverts commit 96ba7f76d26ed4e3eb81f30032303fbab9b28aef.

* Intentionally use a self-package URI in flutter_gallery

* tests to catch problems with self-package imports
2017-02-28 17:21:17 -08:00
Jason Simmons
6571b41f40 Roll engine (#8480) 2017-02-28 17:09:11 -08:00
Adam Barth
ecb6efa926 Generalize AnimatedWidget to work with any Listenable (#8469) 2017-02-28 16:40:41 -08:00
Alexandre Ardhuin
18ad3eb557 avoid // ignore: prefer_const_constructors (#8419)
* avoid // ignore: prefer_const_constructors

* address review comments
2017-02-28 16:40:10 -08:00
Yegor
bfef36f710 add waitUntilNoTransientCallbacks to driver API (#8475) 2017-02-28 15:58:28 -08:00
Jason Simmons
c7695b4ad4 Render the Material widget with the physical model layer (#8471) 2017-02-28 15:50:10 -08:00
Adam Barth
9a83659d78 Add ValueNotifier (#8463)
It's common to have a ChangeNotifier that wraps a single value. This class
makes that easy by providing a generic implementation.
2017-02-28 11:25:23 -08:00
Michael Goderbauer
96ba7f76d2 Revert "Simplify path handling logic in dependency checker and devFS (#8414)" (#8467)
This reverts commit e7bde11cc3a68b27c17ef8b18258cd384d043fb8.

Reason: broke hot reload when using "package:" style imports for sources
within the same project.
2017-02-28 11:17:26 -08:00
Michael Thomsen
0533ffc020 Upgrade build tools to latest Android Studio default (#8461) 2017-02-28 18:25:28 +01:00
Michael Thomsen
601b800325 Add solution to gradle-dir doctor warning (#8458)
* Add solution to gradle-dir doctor warning

* Review feedback + properly format strings
2017-02-28 16:01:23 +01:00
Jakob Andersen
81a7fb48dd Catch file system exception while looking for Android Studio on macOS. (#8457)
Fixes #8395.
2017-02-28 15:57:47 +01:00
Todd Volkert
0324923119 Add courtesy notice about bug reports containing sensitive info (#8447) 2017-02-28 06:54:04 -08:00
Devon Carew
e85d3792f0 fix a doctor check for webstorm (#8450)
* fix a doctor check for webstorm

* fix a missing reference
2017-02-28 06:27:30 -08:00
Michael Goderbauer
9a9a3ffd11 Fix flutter logs on Windows (#8442) 2017-02-27 18:01:21 -08:00
Chris Bracken
6491cbf7a3 Ensure PrimaryScrollController is returned when primary: true (#8440)
Also a small formatting fix.
2017-02-27 17:17:29 -08:00
Jason Simmons
af03ed1c79 Roll engine (#8441) 2017-02-27 17:11:13 -08:00
Chris Bracken
c8c37fcc85 Primary scroll view support for SingleChildScrollView (#8437) 2017-02-27 16:10:57 -08:00
Todd Volkert
f60410fa9d Add --bug-report flag (#8435)
This adds support for a `--bug-report` flag, which is a recording
that:
  - includes the arguments that were passed to the command runner
  - is zipped up for easy attachment in Guthub issues
2017-02-27 15:38:47 -08:00
Hans Muller
97083ac6aa Export DecorationPosition, use it in ListItem (#8427) 2017-02-27 12:24:02 -08:00
Mike Hoolehan
09b63e2c93 Ignore HTML in flutter_markdown content without error (#8420)
* Gracefully ignore html content

* Test for less than, consolidate table tests

* Specify missing type annotation

* Add Mike Hoolehan to AUTHORS
2017-02-27 12:13:24 -08:00
Michael Goderbauer
e7bde11cc3 Simplify path handling logic in dependency checker and devFS (#8414)
* Simplify path handling logic in dependency checker and devFS

Simplification will make it easier to port this to Windows.

* Roll Engine to 0a7b177c330367904597a6129b3eb653d29dfca0
2017-02-27 11:01:14 -08:00
Devon Carew
adf3b90df2 check installed IDES for webstorm (#8422) 2017-02-27 07:53:41 -08:00
Adam Barth
932f7cef0c Scaffold shouldn't assert with large bottom padding (#8415)
Fixes #8413
2017-02-25 23:48:23 -08:00
Luke
87f1487e56 Adds un/selected text styles to the TabBar widget (#8417)
* Adds un/selected text styles to the TabBar widget

* Adding documentation on fallback values. Modified fallback on unselectedLabelStyle.
2017-02-25 23:39:22 -08:00
Chris Bracken
6b97757b6d Ensure packages up-to-date on iOS build (#8412)
iOS builds rely on package dependencies and associated build artifacts
(pubspec.lock, .packages files) to be up-to-date.
2017-02-24 17:47:29 -08:00
Michael Goderbauer
2d4e4dd6dc Fix timestamp comparison in BAT file (#8407) 2017-02-24 15:26:36 -08:00
Chris Bracken
b880dff349 Roll engine to 335daf19304ffbbf96c1e1ff840e546f17ce50d6 (#8404) 2017-02-24 13:37:42 -08:00
Adam Barth
f20c3d1032 Add a color argument to Container. (#8396)
It's common to just want a simple colored box. Simple thing should be simple,
so this patch adds a convenience argument to Continer for creating a box
decoration that is just a color.

Fixes #5555
2017-02-24 12:25:48 -08:00
Adam Barth
76394630ac Add barrierDismissable argument to showDialog (#8397)
In some situations, dialogs don't want the barrier to be dismissable.

Fixes #8354
2017-02-24 12:25:33 -08:00
Jason Simmons
b592868249 Roll the engine (#8402) 2017-02-24 12:20:22 -08:00