4285 Commits

Author SHA1 Message Date
Hans Muller
fcfcfd56d2 Support an empty PageableList 2015-12-10 10:11:54 -08:00
Adam Barth
a9f0044e29 Merge pull request #854 from floitschG/nitpicking
Minor modifs.
2015-12-10 00:20:01 -08:00
Ian Hickson
d8a3ed3efc Use hashValues instead of hard-coded hashCode getters 2015-12-09 22:10:33 -08:00
Ian Hickson
43d9766806 Merge pull request #856 from Hixie/onPopRoute
Remove last traces of onEvent.
2015-12-09 21:59:38 -08:00
Ian Hickson
928c6290e0 Remove last traces of onEvent. 2015-12-09 21:07:06 -08:00
Florian Loitsch
b5aba60147 Minor modifs. 2015-12-09 17:07:51 -08:00
Hans Muller
5ddbc03b80 Merge pull request #850 from HansMuller/reset_scroll_behavior
Fix PageableList demo

PageableList's scrollBehavior depends on its itemsWrap property.

Also: deleted some commented out code that I'd forgotten to delete.
2015-12-09 16:32:43 -08:00
Hans Muller
03e893927f Fix PageableList demo 2015-12-09 16:19:53 -08:00
krisgiesing
37f685b4ad Merge pull request #843 from krisgiesing/activity_service
Use explicit service name for activity service
2015-12-09 15:18:46 -08:00
Adam Barth
ac0aed5ae7 Merge pull request #846 from abarth/text_decoration
Update to the new TextDecoration API
2015-12-09 15:17:14 -08:00
Adam Barth
ab89d2e499 Update to the new TextDecoration API
Now with fewer lists.
2015-12-09 15:11:34 -08:00
Adam Barth
dbf6149a51 Merge pull request #848 from abarth/active_color
Let clients of Checkbox, Radio, Slider, and Switch customize the activeColor
2015-12-09 15:11:21 -08:00
Adam Barth
5f29d95018 Let clients of Checkbox, Radio, Slider, and Switch customize the activeColor
We might want to let folks customize the inactive color too, but customizing
the active color is a good place to start.
2015-12-09 14:49:32 -08:00
Hans Muller
3b3d59834e Merge pull request #820 from HansMuller/pageable_list
Revised PageableList et al

An itemExtent-computing SizeObserver is no longer needed to use PageableList. The PageableList just uses its own size as the itemExtent.

Added the itemsSnapAlignment property to PageableList which enables snapping scrolls to an adjacent item (the default), or any item boundary no not at all.

PageableList scrollOffsets now vary from 0.0 to itemCount instead of 0.0 to itemExtent * itemCount. Using logical coordinates instead of pixel coordinates means that the scroll position is insensitive to changes in the PageablList's size.

Added HomogenousPageViewport which is used by PageableList. HomogenousPageViewport scrollOffsets are defined as for PageableList.

Factored the (substantial) common parts of HomogenousViewport HomogenousPageViewport into a file private _ViewportBase class.

Removed PageableWidgetList. PageableList now just extends Scrollable. Moved PageableList into its own file.

Removed the pixel dependencies from ScrollBehavior. ScrollBehavior.createFlingSimulation() no longer sets the simulation's tolerance. The caller must do this instead.

Scrollable now uses pixelToScrollOffset() to convert from input gesture positions and velocities to scrollOffsets.

Fixes #710
2015-12-09 14:16:36 -08:00
Hans Muller
c1d42a2fde Revised PageableList 2015-12-09 14:10:14 -08:00
Kris Giesing
70ea4b2cc7 Use explicit service name for activity service 2015-12-09 13:15:54 -08:00
Adam Barth
4f22f3ecde Merge pull request #838 from abarth/cleanup_global_scope
Cleanup the global scope a bit:
2015-12-09 12:44:27 -08:00
Adam Barth
13f9e91f63 Cleanup the global scope a bit:
- Remove unused FocusChanged typedef.
- Remove unused centerOfAttentionHeroTag.
- Modernize static functions for interacting with Scrollable by moving them
  into the Scrollable class.
2015-12-09 11:12:12 -08:00
Hans Muller
b42ac4e6ab Merge pull request #824 from HansMuller/save_tabs_selection
Make the StockHome TabBar selection persistent

Fixes #671
2015-12-09 09:57:36 -08:00
Adam Barth
f58c3d2bc5 Merge pull request #836 from abarth/update_docs
Update documentation based on comments in previous patch
2015-12-09 09:49:19 -08:00
Adam Barth
5d6d258533 Update documentation based on comments in previous patch 2015-12-09 09:48:22 -08:00
Hans Muller
4eeddab959 Make the StockHome TabBar selection persistent 2015-12-09 09:17:40 -08:00
Adam Barth
8be3a4fd7a Merge pull request #832 from abarth/widget_docs
Add some more dartdoc to widgets
2015-12-09 00:03:33 -08:00
Adam Barth
36c387318a Merge pull request #831 from abarth/scroll_tolerance
Improve tolerance for ending scroll animations
2015-12-09 00:03:07 -08:00
Adam Barth
95fc98108f Improve tolerance for ending scroll animations
We had the units wrong on the tolerances. Previously we multiplied by the
device pixel ratio, which meant we got larger tolerances as we got more
resolution. Also, simplify logic in Newton for applying the tolerances.

Fixes #828
2015-12-08 23:54:43 -08:00
Adam Barth
e55858411f Add some more dartdoc to widgets 2015-12-08 23:42:34 -08:00
Adam Barth
11da9b02ab Merge pull request #830 from Hixie/BoxConstraints
Catch un-normalized BoxConstraints
2015-12-08 21:52:31 -08:00
Ian Hickson
1a049c14e5 Catch un-normalized BoxConstraints
Add BoxConstraints.isNormalized feature.

Use this feature in asserts in all the intrinsic dimension methods, in
various relevant BoxConstraints methods, and in layout().

Wrap the _DebugSize logic in BoxConstraints.constrain() in an assert
block to avoid a branch in release mode.

Remove the logic in BoxConstraints.isSatisfiedBy() that dealt with
non-normalized values.

Add BoxConstraints.normalize().

Make RenderCustomOneChildLayoutBox.performLayout() only set
parentUsesSize on the child if the constraints aren't tight.
2015-12-08 21:35:39 -08:00
Adam Barth
23ab08ad14 Merge pull request #816 from flutter/testing_updates
Update testing instructions per abarths' feedback
2015-12-08 20:12:20 -08:00
Adam Barth
d1e907f3fa Merge pull request #826 from abarth/gesture_dartdoc
Add some dartdoc for GestureDetector
2015-12-08 19:54:54 -08:00
Adam Barth
25da2cf09c Add some dartdoc for GestureDetector
... just a start.
2015-12-08 19:49:02 -08:00
Eric Seidel
2f4864efbb Merge pull request #825 from eseidelGoogle/locale_test
Add a test to stocks for changing the locale
2015-12-08 16:34:53 -08:00
Eric Seidel
09894ec50b Add a test to stocks for changing the locale
I had to add a setLocale method to WidgetTester and
split the code in FlutterBinding which handled locale
changes to allow me to dispatch a locale change w/o actually
changing what the c++ code reports as the locale.

Also added the test to Travis.

@abarth @jason-simmons
2015-12-08 16:16:24 -08:00
Adam Barth
003ecb6751 Merge pull request #819 from abarth/travis_artifacts
Switch over to the Travis-built artifacts
2015-12-08 16:12:41 -08:00
Todd Volkert
5cdfb2d7ea Merge pull request #818 from tvolkert/payouts
Make AssetImage constructor const
2015-12-08 15:24:48 -08:00
Todd Volkert
56197d4353 Merge commit '1e3a85fe73c032ac656d363a60ff5fc6800e9869' into HEAD 2015-12-08 15:19:40 -08:00
Todd Volkert
d84412d116 Make AssetImage constructor const 2015-12-08 15:13:56 -08:00
Adam Barth
2b6b781c7a Switch over to the Travis-built artifacts
We've been bulding these binaries using Travis for a while. We can start using
them now.
2015-12-08 15:01:44 -08:00
Eric Seidel
b55acb4b16 Update CONTRIBUTING.md 2015-12-08 14:38:03 -08:00
Seth Ladd
0d8541ebdf Merge pull request #817 from sethladd/sethladd-patch-1
use async / await
2015-12-08 14:37:09 -08:00
Todd Volkert
1e3a85fe73 Make AssetImage constructor const 2015-12-08 14:25:52 -08:00
Seth Ladd
2666628b12 use async / await 2015-12-08 14:16:14 -08:00
Eric Seidel
723e5f790b Update testing instructions per abarths' feedback
724388d24f
2015-12-08 14:09:47 -08:00
Eric Seidel
724388d24f Update Contributing.md to document testing
@abarth
2015-12-08 13:51:05 -08:00
Adam Barth
c130dfff5f Merge pull request #812 from abarth/check_material
Widgets that depend on Material should assert that
2015-12-08 13:50:02 -08:00
Adam Barth
c0f068ce5a Merge pull request #814 from abarth/rm_event_recorder
Remove unused EventRecorder
2015-12-08 13:49:53 -08:00
Collin Jackson
56818d186d Merge pull request #801 from collinjackson/fix_dynamic_hero
Fix hero transition when using dynamic routes
2015-12-08 13:48:45 -08:00
Ian Hickson
b1448e0f6d Merge pull request #810 from Hixie/pointers
Clean up pointer handling.
2015-12-08 13:47:38 -08:00
Ian Hickson
8083c2d424 Merge pull request #815 from Hixie/rev
rev engine
2015-12-08 13:46:54 -08:00
Hixie
304ca57b53 rev engine 2015-12-08 13:45:59 -08:00