38647 Commits

Author SHA1 Message Date
Christopher Fujino
6edbce9e07
Manual pub roll pinning web socket channel (#141040)
Work around https://github.com/flutter/flutter/issues/141032

Otherwise a re-land of https://github.com/flutter/flutter/pull/140979

Fixes https://github.com/flutter/flutter/issues/137163 & https://github.com/flutter/flutter/issues/139181
2024-01-05 22:29:58 +00:00
Andrew Kolos
e90e4888b8
in flutter run, throw tool exit when --flavor is provided but is not supported on the target device (#139045)
Fixes https://github.com/flutter/flutter/issues/134197
2024-01-05 21:47:58 +00:00
Andrew Kolos
8c11aa030d
add flavor-conditional asset bundling support to flutter test (#140944)
Fixes https://github.com/flutter/flutter/issues/140932
2024-01-05 21:47:55 +00:00
engine-flutter-autoroll
1a8de105cf
Roll Flutter Engine from f3496a7185c2 to 3fd9c4ee4fc0 (4 revisions) (#141037)
f3496a7185...3fd9c4ee4f

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 548827f77466 to 9ec012033c2b (1 revision) (flutter/engine#49564)
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from a006922df1c5 to 548827f77466 (1 revision) (flutter/engine#49561)
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 52be1b25c3a2 to a006922df1c5 (4 revisions) (flutter/engine#49559)
2024-01-05 dnfield@google.com Allow spawning additional UI isolates in flutter_tester (flutter/engine#48706)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 21:30:11 +00:00
TabooSun
e8436970e6
Gen l10n add named argument option (#138663)
Add an option to use named argument for generated method.

Fix #116308
2024-01-05 21:28:08 +00:00
Luke Hutchison
0d6927cb61
Fix refresh cancelation (#139535)
Changes drag release logic so that an armed refresh is only canceled if the user has scrolled back up beyond the point where the refresh indicator was armed. (Fixes https://github.com/flutter/flutter/issues/138848.)

This is the minimal change I found could be made to restore something like the behavior that I would expect.

This may still need a bit of work, because it only masks the second issue I mentioned, that releasing a drag can cause the scroll position to be animated back up from the release point. There is actually a bug about that: https://github.com/flutter/flutter/issues/6052. I would like to see that bug fixed too. This PR doesn't address that, but makes it harder to hit that issue.

@Piinks this is a recreation of #139015 (since I couldn't figure out some issue with a git detached branch, so I fixed the PR and I'm re-submitting it). This version includes one line that was somehow accidentally dropped from the original PR. This will hopefully fix the test failures.

However, I don't have a clue how to write a test for a Flutter UI widget. I'll try to figure that out, but also I don't have a lot of time to work on this. I would appreciate at least some user testing to verify that the new behavior is much more intuitive than the old behavior.

- [?] All existing and new tests are passing.
2024-01-05 21:28:07 +00:00
auto-submit[bot]
c2286a7642
Reverts "manual pub roll to pick up dds fixes" (#141033)
Reverts flutter/flutter#140979
Initiated by: loic-sharma
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/137163
Fixes https://github.com/flutter/flutter/issues/139181
2024-01-05 19:10:19 +00:00
engine-flutter-autoroll
e33ad05595
Roll Flutter Engine from ec987365e63c to f3496a7185c2 (1 revision) (#141027)
ec987365e6...f3496a7185

2024-01-05 zoujunhua86@gmail.com Add build dependencies for Android Embedder (flutter/engine#48397)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 18:28:06 +00:00
Zachary Anderson
f111459632
Shift some macOS Android tests from Moto G4 to Pixel 7 Pro (#140912)
Related https://github.com/flutter/flutter/issues/140893
2024-01-05 08:20:49 -08:00
engine-flutter-autoroll
344fcda9e7
Roll Flutter Engine from c3189d767194 to ec987365e63c (1 revision) (#141023)
c3189d7671...ec987365e6

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 75e2f75aaa20 to 52be1b25c3a2 (2 revisions) (flutter/engine#49556)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 16:14:16 +00:00
engine-flutter-autoroll
1fb12a1361
Roll Packages from 31fc7b5dd000 to b9b6d38e012b (8 revisions) (#141021)
31fc7b5dd0...b9b6d38e01

2024-01-05 engine-flutter-autoroll@skia.org Manual roll Flutter from 11def8eff455 to cc40425ddcef (118 revisions) (flutter/packages#5806)
2024-01-05 magder@google.com [ci] Run 'flutter build --config-only for iOS and macOS during fetch deps (flutter/packages#5804)
2024-01-05 amirpanahandeh@yahoo.com [image_picker] Remove input element after completion (flutter/packages#5654)
2024-01-05 stuartmorgan@google.com [video_player] Fix initial frame on macOS (flutter/packages#5781)
2024-01-05 tarrinneal@gmail.com [pigeon] java non null void (flutter/packages#5786)
2024-01-04 10687576+bparrishMines@users.noreply.github.com [file_selector_android] Attempt to close system dialogs before integration tests run (flutter/packages#5805)
2024-01-04 stuartmorgan@google.com [tool] Handle Flutter dev dependencies (flutter/packages#5775)
2024-01-04 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter (flutter/packages#5758)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 15:55:20 +00:00
engine-flutter-autoroll
81ae08df6f
Roll Flutter Engine from 7e6348640940 to c3189d767194 (2 revisions) (#141016)
7e63486409...c3189d7671

2024-01-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0Q4I0x-Kt7T6DOE1b... to l0zn1BQFRjNyaZb-v... (flutter/engine#49552)
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from bdd1e88f3b83 to 75e2f75aaa20 (4 revisions) (flutter/engine#49551)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 0Q4I0x-Kt7T6 to l0zn1BQFRjNy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 13:24:24 +00:00
Taha Tesser
88016c11b4
Fix scrollable TabBar expands to full width when the divider is removed (#140963)
fixes [TabBar Expands to full width of the screen isScrollable: true after upgrading to flutter 3.16.4](https://github.com/flutter/flutter/issues/140338)

---

## Description

Fixes the scrollable `TabBar` width when the divider is removed. (when the divider height is set to `0` or divider color is set to `Colors.transparent`)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    const int tabsCount = 2;

    return MaterialApp(
      home: DefaultTabController(
        initialIndex: 1,
        length: tabsCount,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('TabBar Sample'),
            bottom: PreferredSize(
              preferredSize: const Size.fromHeight(48.0),
              child: ColoredBox(
                color: Theme.of(context).colorScheme.secondaryContainer,
                child:  TabBar(
                  // dividerColor: Theme.of(context).colorScheme.onSurface,
                  dividerColor: Colors.transparent, // remove divider
                  // dividerHeight: 0, // remove divider
                  isScrollable: true,
                  tabAlignment: TabAlignment.center,
                  tabs: <Widget>[
                    for (int i = 0; i < tabsCount; i++)
                      Tab(
                        text: 'Tab $i',
                      ),
                  ],
                ),
              ),
            ),
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before
![Simulator Screenshot - iPhone 15 Pro - 2024-01-04 at 15 16 15](https://github.com/flutter/flutter/assets/48603081/b776e7e6-e5f0-49df-8a79-55032eaad631)

### After
![Simulator Screenshot - iPhone 15 Pro - 2024-01-04 at 15 16 23](https://github.com/flutter/flutter/assets/48603081/9ad13793-43a9-4ae8-977e-7cf84cb59bb1)
2024-01-05 08:33:26 +00:00
engine-flutter-autoroll
89809bef71
Roll Flutter Engine from 8c951851b14f to 7e6348640940 (1 revision) (#141004)
8c951851b1...7e63486409

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from da75878a3aea to bdd1e88f3b83 (1 revision) (flutter/engine#49547)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 05:15:24 +00:00
engine-flutter-autoroll
43016dd155
Roll Flutter Engine from f2f00a438e40 to 8c951851b14f (1 revision) (#140997)
f2f00a438e...8c951851b1

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from dab831e8dcec to da75878a3aea (1 revision) (flutter/engine#49546)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 02:08:52 +00:00
engine-flutter-autoroll
4ff2396b86
Roll Flutter Engine from f60d9a9a3395 to f2f00a438e40 (1 revision) (#140995)
f60d9a9a33...f2f00a438e

2024-01-04 flar@google.com [Impeller] RenderPass now provides the Orthographic matrix (flutter/engine#49544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 01:23:28 +00:00
engine-flutter-autoroll
cc40425ddc
Roll Flutter Engine from 0bbb4d61ce82 to f60d9a9a3395 (1 revision) (#140993)
0bbb4d61ce...f60d9a9a33

2024-01-04 30870216+gaaclarke@users.noreply.github.com [Impeller] migrate blur to calculating coefficients on the cpu (flutter/engine#49512)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 00:30:14 +00:00
engine-flutter-autoroll
4db3bbe203
Roll Flutter Engine from b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) (#140990)
b2a9ce88a1...0bbb4d61ce

2024-01-04 58190796+MitchellGoodwin@users.noreply.github.com Get the correct iOS system font for each weight (flutter/engine#48937)
2024-01-04 43054281+camsim99@users.noreply.github.com [Android] Re-land "Re-land  'Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34'" (flutter/engine#49101)
2024-01-04 godofredoc@google.com Use Mac M1s or x86 wherever possible. (flutter/engine#49540)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 23:44:01 +00:00
Yegor
1fb95ba41b
[web] Fix and unskip a few more CanvasKit tests (#140821)
Fix and unskip the following CanvasKit tests:

- `test/painting/decoration_test.dart`
- `test/rendering/layers_test.dart`
- `test/widgets/app_overrides_test.dart`
2024-01-04 23:26:38 +00:00
engine-flutter-autoroll
4593e70338
Roll Flutter Engine from bd175aa5e0b6 to b2a9ce88a19e (1 revision) (#140986)
bd175aa5e0...b2a9ce88a1

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from 48ba1246efdf to dab831e8dcec (1 revision) (flutter/engine#49538)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 22:57:33 +00:00
Danny Tuppeny
2d3166b7f9
Pin package:vm_service (#140972)
vm_service 14 should not be used yet (see
https://github.com/flutter/flutter/pull/140916#issuecomment-1877383354)
but when trying to unpin pkg:test it was upgraded. This pins it to
v13.0.0.
2024-01-04 21:10:44 +00:00
Qun Cheng
be8a1eac73
Add scrollbar for menus (#140941)
Fixes #140162

This PR is to add a scrollbar for MenuAnchor and DropdownMenu for all platforms when height is limited. Previously, a scrollbar only shows on desktop platforms. This PR also disabled scrollbar's overscroll for MenuAnchor and DropdownMenu.

<img src="https://github.com/flutter/flutter/assets/36861262/9ca3d4d0-415f-43bf-9d2b-df96a42db620" width="250"/><img src="https://github.com/flutter/flutter/assets/36861262/18da8d02-586b-4aa4-b647-927691542429" width="350"/>
2024-01-04 21:09:31 +00:00
Christopher Fujino
e256d49117
manual pub roll to pick up dds fixes (#140979)
Fixes https://github.com/flutter/flutter/issues/137163
Fixes https://github.com/flutter/flutter/issues/139181
2024-01-04 19:43:06 +00:00
engine-flutter-autoroll
690b19c904
Roll Flutter Engine from b81023eb71c9 to bd175aa5e0b6 (2 revisions) (#140980)
b81023eb71...bd175aa5e0

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from e8e426f1429a to 48ba1246efdf (2 revisions) (flutter/engine#49537)
2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from 9c2e9a2b06f3 to e8e426f1429a (11 revisions) (flutter/engine#49536)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 19:37:57 +00:00
Polina Cherkasova
b2f53e0cde
Temporarily remove env variable for leak tracking bots. (#140978)
For some reasons there are [failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8759809744202981089/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/test_stdout) in leak tracking bots, that do not relate to leak tracking. 

There are two differences between leak tracking bots and 'normal' windows framework bots: 

1. The flag "LEAK_TRACKING": "true". First failures happened before consumption of the flag "LEAK_TRACKING": "true" by testWidgets. Hypothesis: the failures may be caused by mechanisms that sets the env variable. This mechanism is used only by leak tracking bots.
2. bringup: true. 

This PR removes the leak tracking env variable to isolate the first difference and verify if the bots will start passing.
2024-01-04 19:32:17 +00:00
Casey Hillers
49edbc7491
Add Flutter CI status to README (#140513)
https://github.com/flutter/flutter/issues/140460

Follow up to https://github.com/flutter/flutter/pull/140461
2024-01-04 18:26:48 +00:00
Polina Cherkasova
3ed0399663
Reland "integrate testWidgets with leak tracking" (#140521) (#140928) 2024-01-04 10:20:36 -08:00
Victoria Ashworth
c9f23d056c
Run half of iOS devicelab tests with Xcode 15 (#140927)
Since 50% of devicelab bots are on macOS 13, we can upgrade 50% of devicelab tests to Xcode 15.

There are 52 Mac_ios non-bringup tests, this PR updates 26 of them.

There are 4 Mac_arm64_ios non-bringup tests, this PR updates 2 of them.

Part of https://github.com/flutter/flutter/issues/140975
2024-01-04 18:11:07 +00:00
Sharabiddin Ahmayev
2ae39c0cc0
Fix SegmentedButton states update logic (#140772)
This PR fixes: #140746

Desc: Style state update logic fix on SegmentedButton
2024-01-04 17:57:06 +00:00
engine-flutter-autoroll
9ad475858f
Roll Flutter Engine from f539acfb8c5a to b81023eb71c9 (1 revision) (#140973)
f539acfb8c...b81023eb71

2024-01-04 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7e9f7eab80d3 to 7f2523c2fa9a (3 revisions) (flutter/engine#49534)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 17:42:10 +00:00
Tirth
64a732740d
[Fix] Consistency in ButtonStyleButton related Tests (#140610)
[Fix] Consistency in ButtonStyleButton related Tests:
- Replaced the usage of ElevatedButton with FilledButton in FilledButton's test.
- Replaced the usage of TextButton.styleFrom with FilledButton.styleFrom in FilledButton's test.
- Replaced the usage of TextButton.styleFrom with ElevatedButton.styleFrom in ElevatedButton's test.
2024-01-04 17:03:58 +00:00
engine-flutter-autoroll
6ad032b758
Roll Packages from bbb41347518e to 31fc7b5dd000 (6 revisions) (#140967)
bbb4134751...31fc7b5dd0

2024-01-04 christopherfujino@gmail.com bump mockito across repo to 5.4.4 (flutter/packages#5794)
2024-01-03 goderbauer@google.com [various] Sync lints with flutter/flutter (flutter/packages#5717)
2024-01-03 ditman@gmail.com [pointer_interceptor_web] Update package APIs and tests. (flutter/packages#5785)
2024-01-03 stuartmorgan@google.com [google_sign_in] Correct method channel `clearAuthCache` declaration (flutter/packages#5787)
2024-01-03 stuartmorgan@google.com [google_sign_in] Correct clearAuthCache declarations (flutter/packages#5693)
2024-01-03 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/packages#5683)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 15:54:17 +00:00
stuartmorgan
24e06232a7
Fix local engine use in macOS plugins (#140222)
Currently podhelper.rb will always point plugin builds at the cached engine artifacts, even when using `--local-engine`. In most cases this is fine, since when the final build actually runs it will be using the engine bundled into the app build, which will be the correct local engine build. When trying to test a local engine build with API additions against a local plugin modified to use those additions to ensure that they are working as expected, however, compilation will fail, because the new APIs won't be present in the plugin build.

This fixes that for macOS, and adds a TODO for iOS (which is more complicated to fix due to the host vs target build distinction).

macOS portion of https://github.com/flutter/flutter/issues/132228
2024-01-04 15:40:08 +00:00
engine-flutter-autoroll
a703582924
Roll Flutter Engine from 7d5a120a601b to f539acfb8c5a (2 revisions) (#140959)
7d5a120a60...f539acfb8c

2024-01-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Wgogr8K1YZdo7yOnn... to 0Q4I0x-Kt7T6DOE1b... (flutter/engine#49529)
2024-01-04 mbrase@google.com [fuchsia] Remove LoggingSocketTest.UseSyslogOnFuchsia test (flutter/engine#49524)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Wgogr8K1YZdo to 0Q4I0x-Kt7T6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 12:58:19 +00:00
engine-flutter-autoroll
da62d4a86d
Roll Flutter Engine from 1ff3cb885842 to 7d5a120a601b (1 revision) (#140946)
1ff3cb8858...7d5a120a60

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from 14378602a81f to 9c2e9a2b06f3 (1 revision) (flutter/engine#49518)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 05:57:26 +00:00
engine-flutter-autoroll
451d3c8d18
Roll Flutter Engine from c8bf51f0d4cd to 1ff3cb885842 (1 revision) (#140943)
c8bf51f0d4...1ff3cb8858

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from aa1b0074a1b5 to 14378602a81f (2 revisions) (flutter/engine#49516)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 04:43:22 +00:00
engine-flutter-autoroll
fb7cb0fa00
Roll Flutter Engine from bfd2d8a100ec to c8bf51f0d4cd (2 revisions) (#140939)
bfd2d8a100...c8bf51f0d4

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from 81c8c425a050 to aa1b0074a1b5 (1 revision) (flutter/engine#49514)
2024-01-04 chillers@google.com Add Flutter CI status to README (flutter/engine#49330)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 03:48:25 +00:00
engine-flutter-autoroll
0139d5f947
Roll Flutter Engine from 28ae9e35c331 to bfd2d8a100ec (1 revision) (#140937)
28ae9e35c3...bfd2d8a100

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from dd4077962cd5 to 81c8c425a050 (1 revision) (flutter/engine#49513)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 02:55:17 +00:00
engine-flutter-autoroll
cc109a8f43
Roll Flutter Engine from ab4098c742f8 to 28ae9e35c331 (1 revision) (#140936)
ab4098c742...28ae9e35c3

2024-01-04 jonnywang@google.com [fuchsia] Add libbackend_fuchsia_globals.so to common_libs (flutter/engine#49484)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from CGyrUgA1M1yF to Wgogr8K1YZdo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 02:08:22 +00:00
engine-flutter-autoroll
295762e9fa
Roll Flutter Engine from e169f3677008 to ab4098c742f8 (2 revisions) (#140933)
e169f36770...ab4098c742

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from e32d4d4f71eb to dd4077962cd5 (1 revision) (flutter/engine#49510)
2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 7d73dd415ae9 to e32d4d4f71eb (3 revisions) (flutter/engine#49508)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 01:21:13 +00:00
engine-flutter-autoroll
1082342f8d
Roll Flutter Engine from 7c2adb811059 to e169f3677008 (1 revision) (#140929)
7c2adb8110...e169f36770

2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 1ce1aa1f90fa to 7d73dd415ae9 (3 revisions) (flutter/engine#49506)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-03 23:47:10 +00:00
Jenn Magder
5d4f5f77b8
Remove deprecated bitcode stripping from tooling (#140903)
Bitcode has been removed https://github.com/flutter/flutter/issues/107887, clean up the leftover commands.
2024-01-03 23:15:23 +00:00
keyonghan
fedf9ece4c
Add Windows leak tracking targets (#140423)
https://github.com/flutter/flutter/issues/140414
2024-01-03 23:09:02 +00:00
Xilai Zhang
f0e616e2b1
[github actions] refactor and fix cherry pick actions (#140499)
This PR makes the following changes:

1. Remove dependency on [peters/evans package](https://github.com/marketplace/actions/create-pull-request)<br>
The market place action introduces overheads that don't properly consume tokens. e.g. :[failed workflow that says token is not supplied](https://github.com/flutter/flutter/actions/runs/7282529195/job/19845096943)
This PR changes the market place action to git commands that we have full control over, provides better error msg for debug, and properly consumes token.

2. Align usage of tokens:<br>
All tokens in the workflow now uses flutter actions bot PAT token. From experiments, a mixed usage of different tokens in different steps sometimes cause the workflow to fail on authentication.

Tested: Tested with [a similar workflow on my personal repository](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml), and it produces the [expected cherry pick PR as end result](https://github.com/flutter/flutter/pull/140497)
2024-01-03 23:08:59 +00:00
Jenn Magder
076cb8a328
Migrate Xcode projects last version checks to Xcode 15.1 (#140256)
Change the following in the `flutter create` templates.  I didn't make any auto-migrations for existing apps because none seem that critical:
1. Turn on `ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS` in iOS and macOS.
1. Turn on `BuildIndependentTargetsInParallel` in macOS template.  https://github.com/flutter/flutter/pull/125827/files#r1181817619 
1. Turn on `DEAD_CODE_STRIPPING` in macOS template. 
1. Set `ENABLE_USER_SCRIPT_SANDBOXING=NO` in iOS and macOS template.  `flutter` scripts don't work with this on.  This might require a migration in the future to explicitly turn this one off. However at least for now if the setting isn't present it defaults to `NO`.

Add migration for `LastUpgradeVersion` so users won't see these validation issues in Xcode.

Run migrator on all the example apps.  A few aren't Flutter apps so I edited them in Xcode.

Fixes https://github.com/flutter/flutter/issues/140253
See also https://github.com/flutter/flutter/issues/125817 and https://github.com/flutter/flutter/pull/90304.
2024-01-03 23:05:46 +00:00
engine-flutter-autoroll
d0f3777f2b
Roll Flutter Engine from bf232c4da241 to 7c2adb811059 (3 revisions) (#140920)
bf232c4da2...7c2adb8110

2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 063e339bedfc to 1ce1aa1f90fa (6 revisions) (flutter/engine#49503)
2024-01-03 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: limit uvs to blur region (flutter/engine#49299)
2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 1144b7950404 to 063e339bedfc (7 revisions) (flutter/engine#49500)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-03 23:01:59 +00:00
Michael Goderbauer
ae4fb0ca7c
fix typo and reflow (#140925)
Fixes "differenet" => "different" and reflows the doc to 80 char line length.
2024-01-03 23:01:57 +00:00
auto-submit[bot]
253dc6f847
Reverts "Re-land integrate testWidgets with leak tracking." (#140926)
Reverts flutter/flutter#140521
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Original PR: https://github.com/flutter/flutter/pull/138057
Revert: https://github.com/flutter/flutter/pull/140502
Issue: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_test_performance/12787/overview
Exception: flutter test rendered unexpected output (1 bad lines)
Explanation: leak tracker adds tear down even when there is no leak tracking, because at the moment of adding tear down it is unclear if leak tracking will be used for some tests.
Fix: add enabling flag for leak tracker and make creation of tear down conditional.
Prerequisites:
2024-01-03 22:36:17 +00:00
engine-flutter-autoroll
d9024dc0a3
Roll Flutter Engine from bf979d220283 to bf232c4da241 (1 revision) (#140915)
bf979d2202...bf232c4da2

2024-01-03 30870216+gaaclarke@users.noreply.github.com [Impeller] pulled out the path unit tests to their own file (flutter/engine#49499)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-03 21:48:42 +00:00
yim
0d4eb5eaa0
Changes the regular cursor to a floating cursor when a long press occurs. (#138479)
This PR changes the regular cursor to a floating cursor when a long press occurs.

This is a new feature. Fixes  #89228
2024-01-03 21:45:07 +00:00