engine-flutter-autoroll
6fe56362e5
Roll Flutter Engine from 6883f7313da0 to 5bf8b94505a4 (2 revisions) ( #146152 )
...
6883f7313d...5bf8b94505#51843 )" (flutter/engine#51847 )
2024-04-02 matanlurey@users.noreply.github.com Replace `WindowInsetsController...` with `adb shell` commands (flutter/engine#51843 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 21:04:54 +00:00
Bruno Leroux
0ed26dc81d
Fix border color is wrong for a focused and hovered TextField ( #146127 )
...
## Description
This PRs fixes the active indicator color for a filled text field and the border color for an outlined text field.
Previously, when a text field was focused and hovered, the hover color was used. With this PR the focus color is used.
Screenshots for a focused and hovered text field:
| Before | After |
|--------|--------|
|  | |
</details>
## Related Issue
Fixes https://github.com/flutter/flutter/issues/145897
## Tests
Adds 4 tests.
2024-04-02 20:08:11 +00:00
Michael Goderbauer
e41881ade2
Sync lints and enable annotate_redeclares ( #146144 )
...
Now that extension types are being used in this repository, `annotate_redeclares` seems useful.
2024-04-02 20:01:23 +00:00
LongCatIsLooong
fd98a2f70b
Implements RenderBox.computeDryBaseline for material render boxes ( #146027 )
...
`RenderChip` and `RenderInputDecorator` changes are larger so they are not included.
2024-04-02 18:37:05 +00:00
engine-flutter-autoroll
06106901d4
Roll Flutter Engine from 523fc953ebc8 to 6883f7313da0 (2 revisions) ( #146140 )
...
523fc953eb...6883f7313dkjlubick@users.noreply.github.com Use moved GrBackendTexture factories for Skia's Metal backend (flutter/engine#51828 )
2024-04-02 skia-flutter-autoroll@skia.org Roll Dart SDK from aa6544b48523 to e6e6d5fe3fb0 (1 revision) (flutter/engine#51837 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 17:28:59 +00:00
Taha Tesser
8d9dcc48ec
Fix MenuItemButton overflow ( #143932 )
...
fixes [MenuItemButton does not constrain its child](https://github.com/flutter/flutter/issues/129439 )
fixes [DropdownMenuEntry Text Overflow when width of DropdownMenu is not specified](https://github.com/flutter/flutter/issues/140596 )
### Description
- This PR continues the fix from https://github.com/flutter/flutter/pull/141314#issuecomment-1945804640 and adds controlled widths for the `MenuBar` children to fix the unbounded width issue which blocked the PR earlier. (Widgets with non-zero flex value cannot be laid out in a horizontal scroll view which is created by `MenuBar` widget)
- Added tests coverage.
- Added documentation.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
MenuController menuController = MenuController();
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Padding(
padding: const EdgeInsets.all(16.0),
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: [
DropdownMenu<int>(
expandedInsets: EdgeInsets.zero,
dropdownMenuEntries: <DropdownMenuEntry<int>>[
DropdownMenuEntry<int>(
value: 0,
label:
'This is a long text that is multiplied by 10. ' * 10,
style: const ButtonStyle(
textStyle: MaterialStatePropertyAll(
TextStyle(overflow: TextOverflow.ellipsis),
),
),
),
],
),
SizedBox(
width: 200,
child: MenuItemButton(
onPressed: () {},
leadingIcon: const Icon(Icons.menu),
trailingIcon: const Icon(Icons.arrow_forward_ios),
child: const Text(
'This is a very long text that will wrap to the multiple lines.',
maxLines: 1,
overflow: TextOverflow.ellipsis,
),
),
),
// MenuBar(
// children: [
// MenuItemButton(
// onPressed: () {
// },
// child: Text('Short Text Menu'),
// ),
// MenuItemButton(
// onPressed: () {},
// child: Text('Very very very very very long text menu'),
// ),
// ],
// ),
],
),
),
),
);
}
}
```
</details>
### Before
### After
2024-04-02 17:27:26 +00:00
engine-flutter-autoroll
174e0b1ac6
Roll Packages from d5aff1980bc8 to 83f3842c27b5 (4 revisions) ( #146134 )
...
d5aff1980b...83f3842c27engine-flutter-autoroll@skia.org Manual roll Flutter from 9d32f07e34c3 to 7fa932be5c12 (19 revisions) (flutter/packages#6448 )
2024-04-01 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20231013 to 20240303 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#6241 )
2024-04-01 reidbaker@google.com [camera_android_camerax] Move integration_test dependency to tests (flutter/packages#6445 )
2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter from d12ba5c270d8 to 9d32f07e34c3 (3 revisions) (flutter/packages#6441 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 15:44:15 +00:00
engine-flutter-autoroll
a418568a64
Roll Flutter Engine from decca6b8bf45 to 523fc953ebc8 (1 revision) ( #146118 )
...
decca6b8bf...523fc953ebflutter/engine#51841 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 08:31:26 +00:00
engine-flutter-autoroll
3b2652b735
Roll Flutter Engine from 370e325098fb to decca6b8bf45 (1 revision) ( #146111 )
...
370e325098...decca6b8bfskia-flutter-autoroll@skia.org Roll Skia from fe64c32d7f2e to cd75e4672719 (1 revision) (flutter/engine#51833 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 04:37:23 +00:00
engine-flutter-autoroll
d7e408ab23
Roll Flutter Engine from 9a513de65251 to 370e325098fb (1 revision) ( #146109 )
...
9a513de652...370e325098matanlurey@users.noreply.github.com Move scenario_app integration tests back to `max_attempts: 2`. (flutter/engine#51838 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 03:29:25 +00:00
engine-flutter-autoroll
0ee25923ae
Manual roll Flutter Engine from e6f19409b613 to 9a513de65251 (12 revisions) ( #146108 )
...
Manual roll requested by jacksongardner@google.com
Cannot build log URL because revision "9a513de65251" is invalid: Luci builds of "Linux linux_android_emulator_skia_tests" for 9a513de65251f83a43d979bb0b2d4c8ee2f8c417 was FAILURE
2024-04-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Avoid loading redundant Vulkan extensions. (#51818 )" (flutter/engine#51835 )
2024-04-01 matanlurey@users.noreply.github.com Run and record `adb shell screenrecord` during Android scenario app (flutter/engine#51832 )
2024-04-01 skia-flutter-autoroll@skia.org Roll Skia from 0b0ed6ca101b to fe64c32d7f2e (4 revisions) (flutter/engine#51831 )
2024-04-01 matanlurey@users.noreply.github.com Run the `DrawSolidBlueScreenTest` 5x in a row in bringup builds. (flutter/engine#51829 )
2024-04-01 matanlurey@users.noreply.github.com Remove tests related to StrictMode that were never running on CI. (flutter/engine#51827 )
2024-04-01 jonahwilliams@google.com [Impeller] Ignore warnign about shader stages not consuming outputs. (flutter/engine#51822 )
2024-04-01 jacksongardner@google.com [Skwasm] Forward text height from paragraph height to default text style (flutter/engine#51819 )
2024-04-01 matanlurey@users.noreply.github.com Remove log statements that did not help. (flutter/engine#51825 )
2024-04-01 skia-flutter-autoroll@skia.org Roll Skia from 40c436a785fa to 0b0ed6ca101b (6 revisions) (flutter/engine#51823 )
2024-04-01 jason-simmons@users.noreply.github.com [Impeller] Add a TextureGLES API for wrapping a framebuffer and use it to implement OpenGL FBO targets in the embedder library (flutter/engine#51269 )
2024-04-01 matanlurey@users.noreply.github.com Remove `testing/android_background_image` which does not run/exist on CI. (flutter/engine#51815 )
2024-04-01 chinmaygarde@google.com [Impeller] Avoid loading redundant Vulkan extensions. (flutter/engine#51818 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 01:22:29 +00:00
auto-submit[bot]
38b2c5bf41
Reverts "Roll Flutter Engine from e6f19409b613 to ea93c5d91b12 (3 revisions) ( #146100 )" ( #146106 )
...
Reverts: flutter/flutter#146100
Initiated by: LongCatIsLooong
Reason for reverting: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20hello_world_impeller/3118/overview
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
e6f19409b6...ea93c5d91bjason-simmons@users.noreply.github.com [Impeller] Add a TextureGLES API for wrapping a framebuffer and use it to implement OpenGL FBO targets in the embedder library (flutter/engine#51269 )
2024-04-01 matanlurey@users.noreply.github.com Remove `testing/android_background_image` which does not run/exist on CI. (flutter/engine#51815 )
2024-04-01 chinmaygarde@google.com [Impeller] Avoid loading redundant Vulkan extensions. (flutter/engine#51818 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 22:54:49 +00:00
engine-flutter-autoroll
7fa932be5c
Roll Flutter Engine from e6f19409b613 to ea93c5d91b12 (3 revisions) ( #146100 )
...
e6f19409b6...ea93c5d91bjason-simmons@users.noreply.github.com [Impeller] Add a TextureGLES API for wrapping a framebuffer and use it to implement OpenGL FBO targets in the embedder library (flutter/engine#51269 )
2024-04-01 matanlurey@users.noreply.github.com Remove `testing/android_background_image` which does not run/exist on CI. (flutter/engine#51815 )
2024-04-01 chinmaygarde@google.com [Impeller] Avoid loading redundant Vulkan extensions. (flutter/engine#51818 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 21:50:46 +00:00
Jesse
f8a06f6418
Refactor realm_checker ( #145905 )
...
Refactor realm_checker suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing realm_checker tests
Part of https://github.com/flutter/flutter/issues/145482
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-04-01 21:49:19 +00:00
Kallen Tu
9fd9f042fc
Add info strings to code blocks. ( #146085 )
...
In preparation to add the lint
`missing_code_block_language_in_doc_comment`, added info strings to a
bunch of fenced code blocks.
Related to issue: https://github.com/dart-lang/linter/issues/4904
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-01 14:05:16 -07:00
Kostia Sokolovskyi
5850651d60
Add test for animated_container.0.dart API example. ( #145995 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds test for `examples/api/test/widgets/implicit_animations/animated_container.0_test.dart`
2024-04-01 20:25:40 +00:00
engine-flutter-autoroll
1e20714e78
Roll Flutter Engine from 8dff6b833fe2 to e6f19409b613 (2 revisions) ( #146093 )
...
8dff6b833f...e6f19409b6skia-flutter-autoroll@skia.org Roll Skia from dacd62255b8d to 40c436a785fa (3 revisions) (flutter/engine#51817 )
2024-04-01 matanlurey@users.noreply.github.com Remove unused and untested timeline data branch for `scenario_app` (flutter/engine#51816 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 20:25:38 +00:00
engine-flutter-autoroll
8c3575d610
Roll Flutter Engine from d33666d90916 to 8dff6b833fe2 (3 revisions) ( #146087 )
...
d33666d909...8dff6b833fjason-simmons@users.noreply.github.com Use the stripped Vulkan validation library in Android engine builds by default (flutter/engine#51628 )
2024-04-01 jason-simmons@users.noreply.github.com [Impeller] Set RGBA8888 as the default Vulkan color format before the app acquires a surface (flutter/engine#51770 )
2024-04-01 matanlurey@users.noreply.github.com Never panic in `finally { ... }`, check output logs on success only. (flutter/engine#51814 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 19:13:39 +00:00
Kate Lovett
6d7922f3f5
Fix SliverMainAxisGroup layout in reverse ( #145572 )
...
Fixes https://github.com/flutter/flutter/issues/145068
The original tests for SliverMainAxisGroup did not actually check where the child was painted (#126596 ).
Followed the same pattern in RenderSliverMultiBoxAdaptor:
11c034f037/packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart (L666)
2024-04-01 19:06:07 +00:00
engine-flutter-autoroll
bd909542a3
Roll Flutter Engine from dd4f5cd5c9d5 to d33666d90916 (3 revisions) ( #146083 )
...
dd4f5cd5c9...d33666d909skia-flutter-autoroll@skia.org Roll Skia from da4cd3390be9 to dacd62255b8d (1 revision) (flutter/engine#51813 )
2024-04-01 zanderso@users.noreply.github.com Roll buildroot to dcd71b5b237e1e58f2ad8a7e51bead0c2a3755a9 (flutter/engine#51812 )
2024-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from b735974580e7 to aa6544b48523 (1 revision) (flutter/engine#51810 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 18:25:50 +00:00
engine-flutter-autoroll
181b69b06e
Roll Packages from 51faaa156b61 to d5aff1980bc8 (3 revisions) ( #146081 )
...
51faaa156b...d5aff1980bengine-flutter-autoroll@skia.org Roll Flutter from 85288818b59e to d12ba5c270d8 (21 revisions) (flutter/packages#6440 )
2024-03-29 engine-flutter-autoroll@skia.org Roll Flutter from 89ea49204b37 to 85288818b59e (11 revisions) (flutter/packages#6436 )
2024-03-29 katelovett@google.com [two_dimensional_scrollables] Infinite TableView (flutter/packages#6411 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 18:05:13 +00:00
Dimil Kalathiya
a187cc7255
Fixes some gesture recognizers are not disposed. ( #146072 )
2024-04-01 09:50:59 -07:00
Bartek Pacia
ec82f0d895
Flutter Gradle Plugin: add versionName and versionCode to FlutterExtension ( #146044 )
...
This PR is a follow-up of a previous PR of mine:
https://github.com/flutter/flutter/pull/141417 . It was unfinished, i.e.
I only implemented it and used it in `examples/hello_world`. No "flutter
create" templates were modified.
This change is theoretically breaking, but in practice, I am pretty sure
nobody uses this. It was not accounced anywhere, the only app using it
is `examples/hello_world`. I did not do that (that=update docs and
templates) because I wanted a solution that is idiomatic in both Gradle
and Kotlin, and only now I found time to do this.
### Without this change
```groovy
defaultConfig {
applicationId = "io.flutter.examples.hello_world"
minSdk = flutter.minSdkVersion
targetSdk = flutter.targetSdkVersion
versionCode = flutter.versionCode()
versionName = flutter.versionName()
}
```
### With this change
```groovy
defaultConfig {
applicationId = "io.flutter.examples.hello_world"
minSdk = flutter.minSdkVersion
targetSdk = flutter.targetSdkVersion
versionCode = flutter.versionCode
versionName = flutter.versionName
}
```
Idiomatic getter - yay! It's consistent between assignment of all four
props.
### Issue
fixes https://github.com/flutter/flutter/issues/146067
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Reid Baker <reidbaker@google.com>
2024-04-01 18:09:13 +02:00
engine-flutter-autoroll
888cf95cfe
Roll Flutter Engine from bf348cd73d49 to dd4f5cd5c9d5 (1 revision) ( #146071 )
...
bf348cd73d...dd4f5cd5c9skia-flutter-autoroll@skia.org Roll Skia from 3093d7c90fb2 to da4cd3390be9 (1 revision) (flutter/engine#51811 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 15:56:17 +00:00
engine-flutter-autoroll
5537688dca
Roll Flutter Engine from 984a78b04671 to bf348cd73d49 (1 revision) ( #146065 )
...
984a78b046...bf348cd73dskia-flutter-autoroll@skia.org Roll Skia from 45e4d2cbdd4f to 3093d7c90fb2 (1 revision) (flutter/engine#51807 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 14:15:41 +00:00
Taha Tesser
e85340e1e4
Deprecate ButtonBar, ButtonBarThemeData, and ThemeData.buttonBarTheme ( #145523 )
...
fixes [Deprecate `ButtonBar`](https://github.com/flutter/flutter/issues/127955 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
buttonBarTheme: const ButtonBarThemeData(
alignment: MainAxisAlignment.spaceEvenly,
),
),
home: Scaffold(
body: ButtonBar(
alignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
TextButton(
onPressed: () {},
child: const Text('Button 1'),
),
TextButton(
onPressed: () {},
child: const Text('Button 2'),
),
TextButton(
onPressed: () {},
child: const Text('Button 3'),
),
],
),
),
);
}
}
```
</details>
## Data driven fix
### Before executing `dart fix --apply`
```dart
return MaterialApp(
theme: ThemeData(
buttonBarTheme: const ButtonBarThemeData(
alignment: MainAxisAlignment.spaceEvenly,
),
),
home: Scaffold(
body: ButtonBar(
alignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
TextButton(
onPressed: () {},
child: const Text('Button 1'),
),
TextButton(
onPressed: () {},
child: const Text('Button 2'),
),
TextButton(
onPressed: () {},
child: const Text('Button 3'),
),
],
),
),
);
```
### After executing `dart fix --apply`
```dart
return MaterialApp(
theme: ThemeData(
),
home: Scaffold(
body: OverflowBar(
alignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
TextButton(
onPressed: () {},
child: const Text('Button 1'),
),
TextButton(
onPressed: () {},
child: const Text('Button 2'),
),
TextButton(
onPressed: () {},
child: const Text('Button 3'),
),
],
),
),
);
```
2024-04-01 11:39:48 +00:00
Taha Tesser
40dda2b4bb
Add DataColumn.headingRowAlignment for DataTable ( #144006 )
...
fixes [[`DataTable`] Unable to center the label of a DataColumn without side effects](https://github.com/flutter/flutter/issues/143340 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: MaterialApp(
home: Material(
child: DataTable(
columns: <DataColumn>[
DataColumn(
headingRowAlignment: MainAxisAlignment.center,
onSort: (int columnIndex, bool ascending) {},
label: const Text('Header'),
),
],
sortColumnIndex: 0,
rows: const <DataRow>[
DataRow(
cells: <DataCell>[
DataCell(Center(child: Text('Data'))),
],
),
],
),
),
),
);
}
}
```
</details>
### Center `DataColumn.mainAxisAlignment` without sort arrow
### Center `DataColumn.mainAxisAlignment` with sort arrow
2024-04-01 09:42:51 +00:00
engine-flutter-autoroll
984c69a86f
Roll Flutter Engine from e9d35f8bfbe2 to 984a78b04671 (2 revisions) ( #146062 )
...
e9d35f8bfb...984a78b046skia-flutter-autoroll@skia.org Roll Skia from b9d078716d40 to 45e4d2cbdd4f (2 revisions) (flutter/engine#51806 )
2024-04-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TXxMINUq7JduIRX8K... to 5W6KVvHCGwWHBjm2m... (flutter/engine#51805 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from TXxMINUq7Jdu to 5W6KVvHCGwWH
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 08:54:18 +00:00
engine-flutter-autoroll
0753f22353
Roll Flutter Engine from 4f6b832c8e33 to e9d35f8bfbe2 (1 revision) ( #146060 )
...
4f6b832c8e...e9d35f8bfbskia-flutter-autoroll@skia.org Roll Skia from c61843470d89 to b9d078716d40 (1 revision) (flutter/engine#51804 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 07:50:49 +00:00
engine-flutter-autoroll
fd8561a917
Roll Flutter Engine from 9689390986b7 to 4f6b832c8e33 (1 revision) ( #146055 )
...
9689390986...4f6b832c8ezanderso@users.noreply.github.com Prefix non-local build config names with ci/ (flutter/engine#51474 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 21:12:24 +00:00
engine-flutter-autoroll
b1cdd0f99b
Roll Flutter Engine from 34081fea4d59 to 9689390986b7 (1 revision) ( #146053 )
...
34081fea4d...9689390986matanlurey@users.noreply.github.com Finish clangd testing. (flutter/engine#51786 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 18:52:23 +00:00
engine-flutter-autoroll
9d32f07e34
Roll Flutter Engine from 2decefb00d1e to 34081fea4d59 (1 revision) ( #146048 )
...
2decefb00d...34081fea4dskia-flutter-autoroll@skia.org Roll Skia from 0970776d543a to c61843470d89 (1 revision) (flutter/engine#51802 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 09:17:33 +00:00
engine-flutter-autoroll
2c7749f6a8
Roll Flutter Engine from 3588d31a98f6 to 2decefb00d1e (1 revision) ( #146047 )
...
3588d31a98...2decefb00dskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wrbGDfD0BEOBXEGMK... to TXxMINUq7JduIRX8K... (flutter/engine#51801 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wrbGDfD0BEOB to TXxMINUq7Jdu
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 07:38:23 +00:00
LongCatIsLooong
ff284c51bd
Implement computeDryBaseline for cupertino RenderBoxes ( #145951 )
...
The `_debugVerifyDryBaselines` method verifies that dry baseline implementation is consistent with the wet baseline method at the current constraints.
2024-03-30 21:38:24 +00:00
engine-flutter-autoroll
d12ba5c270
Roll Flutter Engine from 08eb5ad6e498 to 3588d31a98f6 (1 revision) ( #146031 )
...
08eb5ad6e4...3588d31a98skia-flutter-autoroll@skia.org Roll Dart SDK from 572de60e008a to b735974580e7 (2 revisions) (flutter/engine#51799 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 08:22:23 +00:00
engine-flutter-autoroll
57a711fce5
Roll Flutter Engine from df581c316485 to 08eb5ad6e498 (2 revisions) ( #146028 )
...
df581c3164...08eb5ad6e4skia-flutter-autoroll@skia.org Roll Skia from 7dc399e01f98 to 0970776d543a (1 revision) (flutter/engine#51796 )
2024-03-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3vgfbp1vjXkdMZ09m... to wrbGDfD0BEOBXEGMK... (flutter/engine#51797 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3vgfbp1vjXkd to wrbGDfD0BEOB
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 06:12:25 +00:00
engine-flutter-autoroll
664393f897
Roll Flutter Engine from 5df1042cd927 to df581c316485 (1 revision) ( #146025 )
...
5df1042cd9...df581c3164skia-flutter-autoroll@skia.org Roll Skia from ab0f4a038cec to 7dc399e01f98 (2 revisions) (flutter/engine#51795 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 04:21:14 +00:00
engine-flutter-autoroll
423f985e6d
Roll Flutter Engine from dce6ce366c74 to 5df1042cd927 (2 revisions) ( #146024 )
...
dce6ce366c...5df1042cd9skia-flutter-autoroll@skia.org Roll Dart SDK from 52b05146758e to 572de60e008a (1 revision) (flutter/engine#51794 )
2024-03-30 matanlurey@users.noreply.github.com Add more Java and Dart logging to `scenario_app` (for now) (flutter/engine#51789 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 03:30:03 +00:00
engine-flutter-autoroll
bdc0bab824
Roll Flutter Engine from 221b49ae4a82 to dce6ce366c74 (1 revision) ( #146023 )
...
221b49ae4a...dce6ce366cskia-flutter-autoroll@skia.org Roll Skia from 7338f5521e05 to ab0f4a038cec (1 revision) (flutter/engine#51793 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 02:38:23 +00:00
engine-flutter-autoroll
c831350544
Roll Flutter Engine from 0a751669e722 to 221b49ae4a82 (1 revision) ( #146022 )
...
0a751669e7...221b49ae4askia-flutter-autoroll@skia.org Roll Skia from df005a80da32 to 7338f5521e05 (11 revisions) (flutter/engine#51791 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 01:11:05 +00:00
engine-flutter-autoroll
e8fdeff28b
Roll Flutter Engine from 8ec35b6d63ba to 0a751669e722 (2 revisions) ( #146020 )
...
8ec35b6d63...0a751669e7skia-flutter-autoroll@skia.org Roll Skia from a12e40efacea to df005a80da32 (1 revision) (flutter/engine#51777 )
2024-03-29 737941+loic-sharma@users.noreply.github.com [Windows] Fix EGL surface destruction race (flutter/engine#51781 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 00:14:27 +00:00
engine-flutter-autoroll
d48d19733b
Roll Flutter Engine from 4b6836f8ef00 to 8ec35b6d63ba (3 revisions) ( #146014 )
...
4b6836f8ef...8ec35b6d6330870216+gaaclarke@users.noreply.github.com [Impeller] removed old blur detritus (flutter/engine#51779 )
2024-03-29 matanlurey@users.noreply.github.com Implement `Paint.from(other)` for `dart:ui`. (flutter/engine#51110 )
2024-03-29 skia-flutter-autoroll@skia.org Roll Dart SDK from bb65648e20e2 to 52b05146758e (3 revisions) (flutter/engine#51783 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 23:35:09 +00:00
engine-flutter-autoroll
a844de5cfd
Roll Flutter Engine from 4c079a6ff502 to 4b6836f8ef00 (3 revisions) ( #146010 )
...
4c079a6ff5...4b6836f8efmatanlurey@users.noreply.github.com Rename `Mac clangd` to `Linux mac_clangd` (flutter/engine#51785 )
2024-03-29 matanlurey@users.noreply.github.com Fix the `clangd` builders, and make Linux non-bringup. (flutter/engine#51765 )
2024-03-29 magder@google.com Remove _dartobservatory._tcp legacy DNS registration type (flutter/engine#51635 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 22:40:21 +00:00
Nate
a17d4b34f0
Implementing switch expressions in flutter_tools/ ( #145632 )
...
This pull request is step 12 in the journey to make this entire repository more readable.
(previous PRs: #139048 , #139882 , #141591 , #142279 , #142634 , #142793 , #143293 , #143496 , #143634 , #143812 , #144580 )
We're getting close to the end! ð
2024-03-29 22:31:19 +00:00
godofredoc
7f6685658c
Generate test metrics consistently. ( #145943 )
...
Starts creating metric files consistently for web, dart and flutter runners. It also starts creating the files in the temp folder instead of the checkout one.
Bug: https://github.com/flutter/flutter/issues/145793
2024-03-29 22:18:20 +00:00
engine-flutter-autoroll
caddea09a2
Roll Flutter Engine from 32c9dab552f0 to 4c079a6ff502 (3 revisions) ( #146007 )
...
32c9dab552...4c079a6ff5matanlurey@users.noreply.github.com Remove the tests for `rotate` and `crop` from the Android `scenario_app`. (flutter/engine#51769 )
2024-03-29 30870216+gaaclarke@users.noreply.github.com [Impeller] split out aiks blend tests (flutter/engine#51780 )
2024-03-29 dkwingsmt@users.noreply.github.com [macOS] Move to new present callback (flutter/engine#51436 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 21:56:24 +00:00
Ian Hickson
887bdcfb6b
Add flutter_goldens README ( #145278 )
...
This is part 5 of a broken down version of the #140101 refactor.
This PR adds a README to flutter_goldens with breadcrumbs to other sources of documentation.
2024-03-29 21:20:58 +00:00
Ian Hickson
16ec1a8434
Remove state shared across tests ( #145281 )
...
This is part 6 of a broken down version of the #140101 refactor.
This change tries to be as minimal as possible to make review as easy as possible. We can further simplify this file in future PRs. This change allows us to re-enable test order randomization for these tests.
2024-03-29 21:19:47 +00:00
engine-flutter-autoroll
1c0eb6804b
Roll Flutter Engine from 8480145cc39d to 32c9dab552f0 (1 revision) ( #146005 )
...
8480145cc3...32c9dab55231859944+LongCatIsLooong@users.noreply.github.com Turn struct half leading in canvaskit kitchensink test back on (flutter/engine#50707 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 21:15:44 +00:00
Bruno Leroux
49183c256c
InputDecorator M3 tests migration - Step7 - container ( #145583 )
...
## Description
This PRs adds a test group for the input decorator container, this group is organised similarly to the M3 spec, see https://m3.material.io/components/text-fields/specs .
It is step 7 for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
Step 3: https://github.com/flutter/flutter/pull/143520
Step 4: https://github.com/flutter/flutter/pull/144169
Step 5: https://github.com/flutter/flutter/pull/144932
Step 6: https://github.com/flutter/flutter/pull/145213
## Related Issue
Related to https://github.com/flutter/flutter/issues/139076
@justinmc The diff is not very readable. The tests added by this PR are from line 298 to line 975. Other changes are due to moving some existing tests to this new 'container' group.
2024-03-29 20:48:49 +00:00
