Andrew Kolos
295a9a2031
provide command to FakeCommand::onRun ( #142206 )
...
Part of work on [#101077 ](https://github.com/flutter/flutter/pull/141194 ). This is done as a separate PR to avoid a massive diff.
## Context
1. The `FakeCommand` class accepts a list of patterns that's used to match a command given to its `FakeProcessManager`. Since `FakeCommand` can match a list of patterns, not just specifically strings, it can be used to match commands where the exact value of some arguments can't (easily) known ahead of time. For example, a part of the tool may invoke a command with an argument that is the path of a temporarily file that has a randomly-generated basename.
2. The `FakeCommand` class provides on `onRun` parameter, which is a callback that is run when the `FakeProcessManager` runs a command that matches the `FakeCommand` in question.
## Issue
In the event that a `FakeCommand` is constructed using patterns, the test code can't know the exact values used for arguments in the command. This PR proposes changing the type of `onRun` from `VoidCallback?` to `void Function(List<String>)?`. When run, the value `List<String>` parameter will be the full command that the `FakeCommand` matched.
Example:
```dart
FakeCommand(
command: <Pattern>[
artifacts.getArtifactPath(Artifact.engineDartBinary),
'run',
'vector_graphics_compiler',
RegExp(r'--input=/.*\.temp'),
RegExp(r'--output=/.*\.temp'),
],
onRun: (List<String> command) {
final outputPath = (() {
// code to parse `--output` from `command`
})();
testFileSystem.file(outputPath).createSync(recursive: true);
},
)
```
2024-01-25 07:51:25 +00:00
godofredoc
f18e61a5e8
Remove codesign command from conductor. ( #141044 )
...
Codesigning is now automated and the codesigning tests have been migrated to shard tests.
2024-01-06 00:45:26 +00:00
Casey Hillers
d9634155ab
[conductor] Remove PublishChannel and use MPA command ( #135884 )
...
Move more of the playbook into conductor. The MPA command inputs are prone to human error.
2023-10-09 21:13:55 +00:00
Michael Goderbauer
b0a90aee17
Enable strict-inference ( #135043 )
...
Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
2023-09-20 19:59:08 +00:00
Sam Rawlins
9f53df559f
Correct a few import sortings ( #130435 )
...
Move a few import directives to be in correct order. Fixes https://github.com/flutter/flutter/issues/130434
2023-07-13 15:33:07 +00:00
Christopher Fujino
b89bfd8e37
re-enable "Linux packages_autoroller" ( #130088 )
...
Fixes https://github.com/flutter/flutter/issues/129744
This change:
1. re-enables the Linux packages_autoroller
2. ensures we redact the token from appearing in any logs (in local testing I realized some failure logs might still expose the token)
What actually fixed authentication however was creating and uploading a new GitHub personal access token, not this change.
It's currently failing post-submit because being marked `bringup` it is running in the try pool, which does not have permissions to access the cloud KMS. However, I ran a LED build in the prod pool that succeeded:
3a8f128c35/+/build.proto
2023-07-10 19:32:56 +00:00
Christopher Fujino
67b7aa22c2
Change pub roller bot to push to flutter-pub-roller-bot/flutter.git ( #129844 )
...
Fixes https://github.com/flutter/flutter/issues/129744
Part of https://github.com/flutter/flutter/issues/129847
Migrate the packages_autoroller script to push to
flutter-pub-roller-bot/flutter.git, rather than
fluttergithubbot/flutter.git.
2023-06-30 16:28:00 -07:00
Christopher Fujino
0d2772238e
migrate the package_autoroller from querying by label to title ( #128066 )
...
Fixes https://github.com/flutter/flutter/issues/128067
2023-06-01 22:16:50 +00:00
Phil Quitslund
5bf6318688
Update collection-fors to prefer final (as per updated prefer_final_in_for_each) ( #127511 )
...
The newly updated lint will soon flag for-each in collections.
See discussion: https://github.com/dart-lang/linter/pull/4383
/cc @goderbauer
2023-05-26 23:34:36 +00:00
Casey Hillers
22e33275b5
[conductor] Roll engine->flutter whenever version is out of date ( #121502 )
...
[conductor] Roll engine whenever version is out of date
2023-03-03 18:10:09 +00:00
Casey Hillers
d193f050b5
[conductor] Remove cherrypick option ( #121405 )
...
[conductor] Remove cherrypick option
2023-02-27 15:00:26 +00:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) ( #120842 )
...
* lerp documentation
* Remove Note, Note That from repo
* Improve BorderSide documentation.
* apply review comments
2023-02-17 22:27:33 +00:00
Casey Hillers
65fd924d84
[conductor] Remove CiYaml model ( #120458 )
...
* [conductor] Remove CiYaml model
* Remove package:yaml
* Update pubspec checksum
2023-02-10 20:29:31 +00:00
Casey Hillers
b2e37c6592
[conductor] Tag engine versions ( #120419 )
...
* [conductor] Tag engine versions
* Move tag to repository
2023-02-10 19:01:04 +00:00
Kevin Chisholm
484d881f27
[conductor] update console link ( #118338 )
...
* update console link
* update test to include new console link
2023-02-01 14:05:45 -06:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints ( #117365 )
2022-12-20 16:03:21 -08:00
Xilai Zhang
30efcf406b
[flutter_conductor] Conductor should stop mirroring beta releases to dev ( #100716 )
2022-09-21 16:19:20 +00:00
Kevin Chisholm
c49531f02c
[Conductor] Prefer ssh over https ( #110591 )
2022-08-30 17:07:13 +00:00
Kevin Chisholm
21d3c3f255
replace engine and framework mirror args with github username arg ( #109239 )
2022-08-10 21:03:32 +00:00
Christopher Fujino
3ce2ab9159
Auto-submit pub packages autoroll PRs ( #108635 )
2022-07-29 19:53:05 +00:00
Christopher Fujino
aac5e95ae5
[flutter_tools] refactor packages_autoroller.dart script ( #106580 )
2022-06-27 14:09:10 -07:00
Christopher Fujino
a30012b275
Add update packages roller ( #100982 )
2022-06-22 17:04:07 -07:00
Casey Hillers
0bcdd8d89d
[conductor] Fix branch version to use framework branch ( #103381 )
2022-05-11 17:59:09 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Christopher Fujino
462427d53c
[flutter_conductor] fix conductor codesign --upstream flag ( #101782 )
2022-04-13 10:39:05 -07:00
Michael Goderbauer
ca2d60e8e2
Prepare more of dev for use_super_parameters ( #101073 )
2022-03-30 14:05:05 -07:00
Christopher Fujino
4aed5b13f6
extend timeout for codesign_integration_test ( #100940 )
2022-03-29 09:18:15 -07:00
Casey Hillers
a3d8026993
[flutter_conductor] Add candidate branch version to releases ( #100781 )
2022-03-25 12:28:57 -07:00
Christopher Fujino
0adf9671f8
[flutter_conductor] clone from remote upstream, and not local filesystem ( #100335 )
2022-03-18 11:20:15 -07:00
Christopher Fujino
7a60b6eea6
[flutter_conductor] Fix conductor start branch point ( #100170 )
2022-03-15 19:20:17 -07:00
Christopher Fujino
38dbbb17f8
[flutter_conductor] deprecate increment ( #99189 )
2022-03-01 12:11:22 -08:00
Christopher Fujino
fac90f44ba
[flutter_conductor] log to stderr but do not crash conductor if branch name validation fails ( #99181 )
2022-02-25 15:26:16 -08:00
Christopher Fujino
74881c12bd
[flutter_conductor] fix auto-tagging branch point ( #98618 )
2022-02-18 16:19:25 -08:00
Christopher Fujino
4575a69d97
[flutter_conductor] fix initialref to explicitly include remote name ( #96481 )
2022-01-12 22:30:21 -08:00
Christopher Fujino
8b70641c11
[flutter_conductor] support commits past tagged stable release ( #95349 )
...
* support commits past tagged stable release
* make better expectations
2021-12-15 12:47:55 -08:00
Christopher Fujino
481dfec00e
[flutter_conductor] Support publishing to multiple channels ( #94770 )
2021-12-07 09:39:04 -08:00
Christopher Fujino
eea6c54dc2
[flutter_conductor] catch and warn when pushing working branch to mirror ( #94506 )
2021-12-06 16:59:05 -08:00
Alex
326ed7d747
[conductor] add global constants and startContext checkoutpath getter ( #93877 )
2021-11-23 11:22:34 -08:00
Christopher Fujino
31ee09f6bf
make .prompt() async ( #94067 )
2021-11-22 19:53:04 -08:00
Christopher Fujino
d37a80d405
[flutter_conductor] Conductor prompt refactor ( #93896 )
2021-11-20 11:03:04 -08:00
Christopher Fujino
ce1acf5dc0
[flutter_conductor] implement requiredLocalBranches ( #93580 )
2021-11-19 13:03:08 -08:00
Christopher Fujino
764577f89a
[flutter_conductor] allow --force to override validations on start sub-command ( #93514 )
2021-11-12 18:31:03 -08:00
Christopher Fujino
2107fef430
[flutter_conductor] ensure release branch point is always tagged ( #93082 )
2021-11-08 15:28:07 -08:00
Alex
9c1a87e627
added cleanContext ( #93264 )
...
* added cleanContext
* using async
* added one more test
2021-11-08 17:34:03 -05:00
Christopher Fujino
45f438071a
[flutter_conductor] Lift rev parse in conductor ( #92594 )
...
* lift git-rev-parse in conductor start
* remove localFlutterRoot from globals.dart
* make localFlutterRoot getter private
* fix analysis
2021-10-28 08:29:16 -07:00
Christopher Fujino
e593a863eb
[flutter_conductor] validate git parsed version and release branch match ( #92064 )
2021-10-20 13:43:02 -07:00
Christopher Fujino
5d587f9528
[flutter_conductor] Refactor next command ( #91768 )
2021-10-14 11:04:40 -07:00
Christopher Fujino
1bf621ba03
[flutter_conductor] Refactor conductor core ( #91694 )
2021-10-13 13:10:27 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
