firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40,119 Commits 1 Branch 0 Tags
Commit Graph

5147 Commits

Author SHA1 Message Date
Chris Bracken
e3247a3629
Revert "Eliminate build aot --interpreter flag (#17025)" (#17032) 
Requires a fix to xcode_backend.sh. Will followup momentarily with that
fix.

This reverts commit 8c4f0c0d215ca3219923c60fce2cd7c7528acf9b.
 2018-04-26 16:30:16 -07:00
Chris Bracken
8c4f0c0d21
Eliminate build aot --interpreter flag (#17025) 
This is required for iOS debug builds, but unused otherwise. In theory,
Android debug builds could be run in this mode, but this is historically
untested and adds unnecessary complexity to the code. If ad-hoc testing
is required, it can be patched in when necessary.
 2018-04-26 16:07:10 -07:00
Chris Bracken
82f969ff05
Move AOT snapshotting to Snapshotter class (#17015) 
This moves AOT snapshotting out of build_aot.dart and into the
Snapshotter class. It also adds unit tests for iOS debug, profile, and
release builds.
 2018-04-26 14:37:39 -07:00
Chris Bracken
b45a260534
Make FakeGenSnapshot's outputs mutable for tests (#16976) 
This simplifies tests by allowing the test author to express the outputs
they'd like the snapshotter to generate without creating a whole new
instance and context with the additional overrides.

Also sets the default set of outputs to none, setting them instead in
the setUp function for script snapshotting.
 2018-04-25 20:50:33 -07:00
josephmr
7f9bf5ade9 Introduce DoctorValidatorsProvider to improve extensibility of flutter_tools (#16918) 
DoctorValidatorsProvider is injected into Doctor to allow
overriding of DoctorValidators without needing to override
the whole Doctor instance.
 2018-04-24 19:01:53 -07:00
Chris Bracken
f570e046c9
Inline buildScriptSnapshot calls (#16940) 2018-04-24 16:07:14 -07:00
Chris Bracken
993f3947da
Generalise FakeGenSnapshot output generation (#16938) 
Pre-factoring for addition of AOT snapshotting unit tests, which emit a
different set of expected outputs.
 2018-04-24 15:51:10 -07:00
Chris Bracken
7ffcd3d22d
Extract KernelCompiler class (#16937) 
Wraps the compile function in a class injected via the global context,
which makes it easier to mock in unit tests -- specifically tests for
AOT snapshotting, which already require pretty significant amounts of
mock inputs.
 2018-04-24 14:03:41 -07:00
Chris Bracken
de8a53c55b
Rename buildSnapshot to buildScriptSnapshot (#16905) 
Renames buildSnapshot to build buildScriptSnapshot in preparation for
AOT snapshot tests.
 2018-04-23 16:51:34 -07:00
PJ Essien
fd7222eea8 Fix error with 'flutter packages get' in package projects (#16861) 
Package projects were erroneously being treated as apps
 2018-04-22 18:03:46 -07:00
Devon Carew
36cf1158ec
add the full path to a flutter command (#16720) 
* add the full path to a flutter command

* remove an unused import

* review comments
 2018-04-20 17:39:32 -07:00
Todd Volkert
12bbaba9ae
Do exponential backoff for all exceptions in VMService::defaultOpenChannel. (#16785) 
We were trying to only catch WebSocketException, but in fact
SocketException can be thrown as well.
 2018-04-19 23:36:15 -07:00
Yegor
85473d0941 retry VMService connection; expect missing PRODUCT_BUNDLE_IDENTIFIER (#16770) 
Fixes #13655
 2018-04-19 18:29:49 -07:00
Chris Bracken
cf5778810b
Move script snapshot argumtents to Snapshotter (#16722) 
This moves --vm_snapshot_data and --isolate_snapshot_data argument
hardcoding from GenSnapshot (a minimal wrapper around gen_snapshot
invocations) to Snapshotter.buildScriptSnapshot(). These arguments are
present in both AOT and script snapshots, but differ semantically: for
script snapshots they're inputs from the host engine artifacts
directory, for AOT snapshots they're outputs to the build directory.
 2018-04-19 16:03:07 -07:00
Todd Volkert
c83d24d547
Always add a DevFS asset entry for the font manifest (#16650) 
The engine expects it to always be there.
 2018-04-16 21:48:21 -07:00
jcollins-g
85be28d36b
Add catch for SocketException and tests for exception handling on fetchUrl. (#16569) 2018-04-16 14:02:07 -07:00
Alexander Aprelev
e0cd42e4ad Roll engine to 76cb311d9c33720dcd19274228b39ecdbad8d9af (with rolled dart) (#16518) 
* Handle error count reported by frontend.

Extend compilation result from single string to a structure(string filename and integer error count).

* Use ?.

* Include engine roll with dart sdk roll.

* parse(onError) -> tryParse

* Make '?? throw' more readable and avoid issue with analyzer

* Fix test so it mocks compiler output including errors count
 2018-04-12 16:28:01 -07:00
Devon Carew
a561722b2b
fix a test flake on appveyor (#16479) 
* fix a test flake on appveyor

* only catch FileSystemExceptions
 2018-04-12 15:07:51 -07:00
Devon Carew
071485258f
Revert "re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server (#16281)" (#16482) 
This reverts commit 2f41ea546f98a2bacabcd2444ca7ce4127a4360a.
 2018-04-11 16:49:38 -07:00
Devon Carew
2f41ea546f
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server (#16281) 
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
 2018-04-11 14:50:36 -07:00
Konstantin Scheglov
cf500bf6cd
Integration test for FlutterTesterDevice. (#16424) 2018-04-11 08:52:17 -07:00
Todd Volkert
f408bb06f9
Update dependencies (#16442) 2018-04-10 14:27:53 -07:00
Konstantin Scheglov
38970f5f75
Add a new Device backed by flutter_tester. (#16405) 2018-04-10 09:37:16 -07:00
Sam Rawlins
2329cb7ec8 Bump mockito to 3.0.0-alpha+3 (#16306) 
* Bump mockito to 3.0.0-alpha+3

* Type annotation
 2018-04-09 12:43:31 -07:00
Todd Volkert
d9a3ced9db
Check whether we can run sdkmanager in AndroidWorkflow.licensesAccepted (#16343) 
Fixes https://github.com/flutter/flutter/issues/16332
 2018-04-09 08:57:11 -07:00
Konstantin Scheglov
d121cbc80d
Make IntelliJPlugins tests use MemoryFileSystem. (#16341) 2018-04-08 09:46:11 -07:00
xster
bdc06194fb
Prompt a solution message when flutter tools network fail in China (#16244) 2018-04-06 18:44:05 -07:00
Jason Simmons
24bfbeb246
Handle whitespace in entry values in the AAPT badging parser (#16245) 
Fixes https://github.com/flutter/flutter/issues/16200
 2018-04-05 10:24:05 -07:00
Konstantin Scheglov
4658ec0f9c
Extract checking IntelliJ packages into a helper and use for Android Studio. (#16198) 2018-04-04 10:48:46 -07:00
xster
48478b5952
Remove DevToolsSecurity check from initial flutter doctor (#16007) 2018-04-04 10:35:38 -07:00
Jonah Williams
0c89920069
Update logic for parsing sdk version number (#15918) 
* add logic to parse 11.3 sim runtime major version

* add null aware and bump group number

* add comment describing version
 2018-04-01 17:35:05 -07:00
Jason Simmons
b4274ef685
URL encode asset paths to support reserved characters in paths (#16046) 
Fixes https://github.com/flutter/flutter/issues/14864
 2018-03-29 13:47:35 -07:00
Todd Volkert
f69d125954
Move Cache.flutterRoot initialization up sooner (#16057) 
It's required to be set before we detect local engine.

Was broken by #15984
 2018-03-29 09:16:34 -07:00
Todd Volkert
2c898f6813
Remove writelnStderr (#16058) 
Paying off technical debt...
 2018-03-29 05:55:32 -07:00
xster
4565395693
Let iOS auto-signing tool handle Googler scenario (#16010) 
* Let iOS auto-signing tool handle Googler scenario

* Forgot to update tests
 2018-03-28 18:58:06 -07:00
Todd Volkert
f8058d7fb2
Make AppContext API not be prone to Future oddities (#16034) 
Follow-up comments to #15984
 2018-03-28 15:17:29 -07:00
Alexander Aprelev
bffae21571
Again move mockito to 300plus2 (#15981) 
* Revert "Revert "Move mockito to 3.0.0-alpha. (#15949)" (#15979)"

This reverts commit e59651f925917ed44a9bf27c37e80fc9992c0890.

* More thenReturn to thenAnswer when mocking Futures

* Revert "More thenReturn to thenAnswer when mocking Futures"

This reverts commit 194d2cf41754ad171efd6bb5898cf73bce5a75ab as we are reverting engine roll.

* Revert "Revert "More thenReturn to thenAnswer when mocking Futures""

This reverts commit 52c9e96b304b220f66d78a252fccea0c8e0ef24c.

* Add dependency override

* Fix issue
 2018-03-28 12:07:12 -07:00
Todd Volkert
8d11f5c763
Make AppContext immutable and race-free (#15984) 
This updates AppContext per the recommendations in #15352

Fixes #15352
 2018-03-28 10:58:28 -07:00
Alexander Aprelev
e59651f925
Revert "Move mockito to 3.0.0-alpha. (#15949)" (#15979) 
This reverts commit a7e6225820719eec08ae3c79ce73ebeb8ec33523 as there are failing tests.
 2018-03-27 10:38:20 -07:00
Alexander Aprelev
a7e6225820
Move mockito to 3.0.0-alpha. (#15949) 
* Move mockito to 3.0.0-alpha.

This is needed so it matches mockito version used internally.

* Pick up +2 for the fixes

* Fix whenReturn in fuchsia_remote_debug_protocol

* more thenReturn becomes thenAnswer

* more thenReturn becomes thenAnswer

* more thenReturn becomes thenAnswer
 2018-03-27 10:05:16 -07:00
Alexandre Ardhuin
217b2bdaa1
add new lints of linter-0.1.44 and enable unnecessary_parenthesis (#15585) 2018-03-21 07:10:14 +01:00
Jonah Williams
ad9506d25a
Traverse dependencies and dev dependencies separately (#15581) 
* traverse dependencies and dev dependencies separately

* separate dev and reg deps

* update pubspecs

* add checksum string and update transitive dep string.  Add additional verify command to check checksum

* cleanup comments

* add missing space, quote, run verify-onlu from bot script

* rerun tool with fixed string

* ensure correct working directory and bump versions

* flutter not flutterRoot
 2018-03-20 20:03:32 -07:00
Victor Choueiri
7edd5c8d6c Allow null flutter schema in pubspec (#15690) 2018-03-19 14:55:54 -07:00
Matan Lurey
81070893be
Fix Dart2 compatibility with flutter_tools' tests. (#15699) 2018-03-19 11:45:44 -07:00
Jason Simmons
1c04f951c8
Warn about missing host build binaries when compiling with a local engine (#15626) 
Fixes https://github.com/flutter/flutter/issues/15361
 2018-03-19 11:29:20 -07:00
Alexander Aprelev
43284d70d9
Reland filesystem options support with fix for Windows test. (#15655) 
* Revert "Revert "Reland pass filesystem options (#15622)" (#15651)"

This reverts commit 0f3eada0664e208bb8c65a5aa02daec38997e8b9.

* Fix for windows failing test

* !isEmpty -> isNotEmpty
 2018-03-17 12:47:40 -07:00
Jonah Williams
298f4efc54
Fail ios workflow when simctl does not work (#15628) 
* fail ios workflow when simctl does not work

* missed rename commit

* address comments
 2018-03-17 10:57:51 -07:00
Alexander Aprelev
0f3eada066
Revert "Reland pass filesystem options (#15622)" (#15651) 
This reverts commit bbcf55a5b086559dc992c0657bcde0d95c1bc26e as it breaks hot reload on Windows.
 2018-03-17 08:11:52 -07:00
Alexander Aprelev
bbcf55a5b0
Reland pass filesystem options (#15622) 
* Revert "Revert "Pass filesystem-root, filesystem-scheme options through `flutter run, build` and gradle. (#15592)" (#15621)"

This reverts commit c663e3367da7c6b8b6571e7fcbf3b1050c805c78.

* Check whether filesystem-root is emtpy.

* Restore broken merge

* Fix windows test

* Adjust regex in test. Invalidate files by file path.
 2018-03-17 06:49:15 -07:00
Vyacheslav Egorov
71b2cfb2a0
Turn Dart 2 mode by default. (#15565) 2018-03-16 20:29:38 +01:00