zijiehe@
70b7664ba2
[fuchsia] enable assets_unittests ( #164019 )
...
It is an easy fix.
http://b/394632376
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-25 17:51:36 +00:00
Matej Knopp
940fb3c8b1
[Embedder] Wire view focus event and focus request ( #163930 )
...
This wires `PlatformDispatcher.onViewFocusChange` and
`PlatformDispatches.requestViewFocusChange` through embedder API.
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I readand followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Matthew Kosarek <matt.kosarek@canonical.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-02-25 17:37:06 +00:00
engine-flutter-autoroll
289993ab83
Roll Skia from 521c27acf504 to 3ce6f25dc13e (1 revision) ( #164105 )
...
https://skia.googlesource.com/skia.git/+log/521c27acf504..3ce6f25dc13e
2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 34a782c7af2d to 7ee45b04303c (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-25 17:24:21 +00:00
John McDole
be1938aa1c
Enable luci_flags for faster builds ( #164069 )
...
Experiment enable turning on faster builds.
1. Moves collecting of builds till after we setup the orchestrator bot
2. Downloads drone artifacts in parallel.
See: https://flutter-review.googlesource.com/c/recipes/+/63800
2025-02-25 16:18:56 +00:00
Jonah Williams
73b518d0c3
[iOS] increase backdrop cached task limit. ( #164036 )
...
Partial workaround for https://github.com/flutter/flutter/issues/161142
. Since this was an arbitrary number anyway we can increase it a bit.
2025-02-25 15:41:47 +00:00
Matan Lurey
5a8f23c3dc
Fix and test an edge case in findPackageConfigFile. ( #163902 )
...
Closes https://github.com/flutter/flutter/issues/163901 .
I'm not aware of a case where this causes user crashes, but it could,
and seems easy to fix/test.
2025-02-25 15:01:51 +00:00
Matej Knopp
641765e283
[Windows] Use enum to configure UI thread policy ( #163727 )
...
https://github.com/flutter/flutter/pull/162935 added a boolean setting
to allow merged platform and UI thread. Using boolean doesn't allow for
opting out of the behavior once we enable it by default, which is
something we will likely want to allow, at least for a period of time.
This PR replaces the boolean with following enum:
```cpp
// Configures the thread policy for running the UI isolate.
typedef enum {
// Default value. Currently will run the UI isolate on separate thread,
// later will be changed to running the UI isolate on platform thread.
Default,
// Run the UI isolate on platform thread.
RunOnPlatformThread,
// Run the UI isolate on a separate thread.
RunOnSeparateThread,
} FlutterDesktopUIThreadPolicy;
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-02-25 12:33:27 +00:00
engine-flutter-autoroll
ebd80b701b
Roll Skia from a141a3ceef87 to 521c27acf504 (8 revisions) ( #164083 )
...
https://skia.googlesource.com/skia.git/+log/a141a3ceef87..521c27acf504
2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from f09a19cebdaf to 25a22decd766 (9 revisions)
2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 2407a54c9b29 to c12c13839d68 (2 revisions)
2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d20125b786b1 to ce93f1f3a1f4 (11 revisions)
2025-02-25 michaelludwig@google.com Reland "[graphite] Remove
TextureInfoData and TextureSpec in TextureInfo"
2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 90cce021a3ec to 34a782c7af2d (10 revisions)
2025-02-24 kjlubick@google.com Fix ninepatch size calculations when
dealing with fractional radii
2025-02-24 robertphillips@google.com [graphite] Add user-defined known
runtime effect API
2025-02-24 robertphillips@google.com [graphite] Add user-defined known
runtime effects to ShaderCodeDictionary
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com ,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-25 09:31:06 +00:00
Taha Tesser
8cf41e9b4f
Fix RangeSlider renders track when track colors are transparent ( #162386 )
...
### Description
Fixes [`Slider` with transparent track colors and custom `trackHeight`
cannot reach the extreme
ends](https://github.com/flutter/flutter/issues/161210 ) but for
`RangeSlider`.
### Code Sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
RangeValues _values = const RangeValues(0, 100);
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Column(
spacing: 20,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
SliderTheme(
data: const SliderThemeData(
trackHeight: 100,
activeTrackColor: Colors.transparent,
inactiveTrackColor: Colors.transparent,
),
child: RangeSlider(
values: _values,
max: 100,
onChanged: (RangeValues values) {
setState(() {
_values = values;
});
},
),
),
],
),
),
),
);
}
}
```
</details>
### Before
<img width="755" alt="Screenshot 2025-02-12 at 15 56 21"
src="https://github.com/user-attachments/assets/e8c88bd8-3c87-46e2-9f29-b945128ae93a "
/>
### After
<img width="755" alt="Screenshot 2025-02-12 at 15 56 09"
src="https://github.com/user-attachments/assets/5f9244e8-4d51-40f3-a3fc-afdf9dff9b35 "
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-25 07:32:03 +00:00
Walid Ashik
271cb8c8c5
Add BorderRadiusGeometry to Divider Widget for Customisable Border Radius ( #163414 )
...
This PR fixes #162239 . Now, you can add border radius to divider. It is
needed when you have a thick divider and almost all the thick dividers
need a radius.
Example Usage:
```diff
Divider(
height: 20,
thickness: 5,
color: Colors.blue,
+ radius: BorderRadius.all(Radius.circular(20)),
);
```
```diff
VerticalDivider(
height: 20,
thickness: 5,
color: Colors.blue,
+ radius: BorderRadius.all(Radius.circular(20)),
);
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-02-25 07:22:04 +00:00
yim
4e39d13a6f
SliverMainAxisGroup multiple PinnedHeaderSliver children ( #163528 )
...
Fixes : #155758
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-25 05:53:03 +00:00
Matan Lurey
7535cb10bc
Move AndroidRenderingApi from common to shell/platform/android ( #163796 )
...
Towards https://github.com/flutter/flutter/issues/163792 .
Major changes:
- `enum class AndroidRenderingAPI` physically moves to
`shell/platform/android`
- Store in `FlutterMain` (as a result of `::init`), instead of in
`Settings`
---------
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2025-02-25 02:40:29 +00:00
engine-flutter-autoroll
ebc7d244d3
Roll Skia from 994168b1ba10 to a141a3ceef87 (1 revision) ( #164023 )
...
https://skia.googlesource.com/skia.git/+log/994168b1ba10..a141a3ceef87
2025-02-24 jvanverth@google.com [graphite] Add back some validation for
clip atlas.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com ,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-24 22:30:25 +00:00
Polina Cherkasova
e1cce0b8b2
Shorten method signature to make invokations fit one line. ( #163822 )
...
Contributes to https://github.com/flutter/flutter/issues/137435 .
2025-02-24 22:09:56 +00:00
Jason Simmons
a4a5a33cfa
Roll .ci.yaml changes into the LUCI configuration only when the master branch is updated ( #163897 )
...
The .ci.yaml on a release branch may be missing builders that are active
on the latest master version of .ci.yaml. If a configuration based on
the release branch is pushed to LUCI, then CI will fail to schedule
those builders when run for a master branch PR.
2025-02-24 20:54:51 +00:00
Jonas Uekötter
a8d1b62382
Reland "Make Flutter version information accessible at runtime ( #140783 )" ( #163761 )
...
Reverts https://github.com/flutter/flutter/pull/163753
Relands https://github.com/flutter/flutter/pull/140783
Original PR description below
------
This makes various Flutter version information available at runtime.
It's basically the same as executing `flutter --version`. This is
especially useful for tools like Crashlytics or Sentry (see for example
https://github.com/getsentry/sentry-dart/issues/416 ).
Usage example:
```dart
FlutterVersion.version; // 3.16.5
FlutterVersion.channel; // stable
FlutterVersion.gitUrl; // https://github.com/flutter/flutter.git
FlutterVersion.frameworkRevision; // 78666c8dc5
FlutterVersion.engineRevision; // 3f3e560236
FlutterVersion.dartVersion; // 3.2.3
```
This approach has prior art as seen in #134179 .
Fixes https://github.com/flutter/flutter/issues/61814
<!-- *If you had to change anything in the [flutter/tests] repo, include
a link to the migration guide as per the [breaking change policy].* -->
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2025-02-24 20:17:08 +00:00
Devon Carew
2bf32d855e
[deps] update dep references from older repos to newer (current SOT) repos ( #163891 )
...
Update dep references from older repos to newer (current SOT) repos:
- package:markdown is now part of the dart-lang/tools monorepo
- package:glob is now part of the dart-lang/tools monorepo
- package:web_socket_channel is now in dart-lang/http
- package:intl moved (quite a while ago) to the dart-lang/i18n monorepo
- package:gcloud moved (a while ago) to dart-lang/labs
I didn't have to update any references to package:intl as part of this;
I suspect that means that its not actually used here.
I was not able to update package:gcloud to the most recent commit; I had
to stop short of that because the package is now referencing
package:retry - in google/dart-neats - and there's no mirror for that.
Generally, it would be useful to have a process to update older
references here and / or garbage collect the dep'd in repos.
Done as the last bit of https://github.com/dart-lang/sdk/issues/56591 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-24 20:13:03 +00:00
Mouad Debbar
6b5b468a60
[web] Actual removal of HTML code ( #164003 )
...
All usages of this code have been cleaned up. There's nothing using this
code at this point.
Closes https://github.com/flutter/flutter/issues/145954
2025-02-24 19:32:13 +00:00
Jonah Williams
a488d104f2
[iOS] switch iOS to slimpeller variant. ( #163808 )
...
Now that skia can no longer be used on both iOS devices and Simulators,
we can switch the iOS engine to the "slimpeller" variant which removes
some (not all!) of the Skia dependencies. This should reduce binary size
and build time.
I also did some cleanups as some tests we're still opting into Skia
behaviors (though not actually running skia) and we now flag these as
errors.
2025-02-24 19:05:21 +00:00
Jonah Williams
1e2583eff2
[ui] Fix ImageFilter.shader equality to consider uniform values. ( #163348 )
...
Fixes https://github.com/flutter/flutter/issues/163302
Framework widgets check for ImageFIlter.== to determine whether to mark
themselves dirty. The filter obejct needs to delegate its equality to
the underlying native filter so that uniform values are considered.
2025-02-24 19:01:55 +00:00
engine-flutter-autoroll
35eaaaa3d0
Roll Skia from 322bb2226654 to 994168b1ba10 (3 revisions) ( #164007 )
...
https://skia.googlesource.com/skia.git/+log/322bb2226654..994168b1ba10
2025-02-24 kjlubick@google.com Remove extra multiplication from rrect GM
2025-02-24 kjlubick@google.com Revert "Remove transform_scanline
functions from SkJpegEncoderImpl"
2025-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 02cb40cbb578 to 90cce021a3ec (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com ,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-24 18:27:54 +00:00
Yegor
de72d1c642
[web] retry safaridriver session creation ( #163791 )
...
Speculatively retry when WebDriver session fails with a timed out
Safari. It is hard enough to get `safaridriver` to open a local port, so
one we have that going, it might be good to give a chance to connect to
the browser 🤷
Fixes https://github.com/flutter/flutter/issues/163790
2025-02-24 16:50:26 +00:00
Reid Baker
e2c4ba31b8
pure_android_host_apps android versions update ( #163617 )
...
- **update pure_android_host_apps/android_custom_host_app to
compileSdk/targetSdk 35, newest stable agp and gradle versions, update
source compatibility to java 17, updated dependencies**
- **Update documentation and migrate compileSdkVersion to compileSdk**
- **Update gitignore to ignore specific module folder name and
local.properties repo wide**
Related to #149836
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-24 16:47:12 +00:00
Jonah Williams
0102da95cd
[Impeller] Disable text cache. ( #163906 )
...
I forgot to make a master branch version of the cherry pick here:
https://github.com/flutter/flutter/pull/163754
2025-02-24 16:26:01 +00:00
engine-flutter-autoroll
9a13fd785f
Roll Packages from 5a721da76766 to 5498d4d2eb48 (2 revisions) ( #164001 )
...
5a721da767...5498d4d2eb15619084+vashworth@users.noreply.github.com Redistribute iOS
plugin owners (flutter/packages#8664 )
2025-02-21 git@reb0.org [video_player] Fixes mechanism to detect
identifier in multiline WebVTT captions (flutter/packages#8555 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-24 16:00:26 +00:00
engine-flutter-autoroll
39dd5a0897
Roll Skia from 28017200173a to 322bb2226654 (1 revision) ( #163987 )
...
https://skia.googlesource.com/skia.git/+log/28017200173a..322bb2226654
2025-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from be98f841ec88 to f09a19cebdaf (15 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com ,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-24 10:02:32 +00:00
engine-flutter-autoroll
16592066d7
Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) ( #163981 )
...
https://skia.googlesource.com/skia.git/+log/3dfb3fee52e1..28017200173a
2025-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 5070f7af1ee9 to d20125b786b1 (15 revisions)
2025-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 490d58c9b7d7 to 02cb40cbb578 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com ,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-24 07:18:29 +00:00
Mikhail Novoseltsev
937965ffae
Add integration test for Gradle-initiated android builds with flavors ( #163737 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This request is a subset of #157871 and follows up #162907 .
#162907 actually fixed behaviour of building with native tooling not
only for iOS/macOS, but also for Android builds too: now on master, if
you start build with `gradle` instead of `flutter build ...` – you also
get the correct behaviour and `appFlavor` won't be null in runtime.
Tests in this PR will check exactly this behavior.
Another diff is the change in the method of obtaining flavor at runtime
inside test project. Before this change, method channels were used for
this, after – `appFlavor` constant. Both methods do more or less the
same thing right now, but they may diverge in future, so I guess this is
the right way to check correctness here. Also, this change was requested
and approved by Andrew in
https://github.com/flutter/flutter/pull/157871#discussion_r1931153339
issue for checklist: #155951
New test was tested here:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20flavors_test/63/overview
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-24 04:40:29 +00:00
engine-flutter-autoroll
10644396b8
Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) ( #163959 )
...
https://skia.googlesource.com/skia.git/+log/72f949950adb..3dfb3fee52e1
2025-02-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com ,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-23 14:03:41 +00:00
engine-flutter-autoroll
4973143100
Roll Skia from 4bee660601de to 72f949950adb (1 revision) ( #163948 )
...
https://skia.googlesource.com/skia.git/+log/4bee660601de..72f949950adb
2025-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2289455859d2 to 490d58c9b7d7 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jacksongardner@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-23 06:27:25 +00:00
engine-flutter-autoroll
ff3b708e0f
Roll Skia from cca9328df6ca to 4bee660601de (1 revision) ( #163927 )
...
https://skia.googlesource.com/skia.git/+log/cca9328df6ca..4bee660601de
2025-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a256e0e7f2a6 to 2289455859d2 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jacksongardner@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-22 16:51:25 +00:00
engine-flutter-autoroll
7f447ea98c
Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) ( #163912 )
...
https://dart.googlesource.com/sdk.git/+log/bad289580d9b..aea6fff33f06
2025-02-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-132.0.dev
2025-02-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-131.0.dev
2025-02-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-130.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-22 06:42:38 +00:00
engine-flutter-autoroll
f7be00358a
Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) ( #163910 )
...
https://skia.googlesource.com/skia.git/+log/1d884bab8593..cca9328df6ca
2025-02-21 kjlubick@google.com Revert "[graphite] Require colorspaces
for precomp color xform objects"
2025-02-21 robertphillips@google.com [graphite] Allow unit tests to get
access to TestOptions
2025-02-21 michaelludwig@google.com Revert "[graphite] Remove
TextureInfoData and TextureSpec in TextureInfo"
2025-02-21 kjlubick@google.com Add missing dependencies to jpeg_helpers
target
2025-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 126c9b378eb7 to a256e0e7f2a6 (17 revisions)
2025-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 80093a7d8f85 to be98f841ec88 (9 revisions)
2025-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from d7ed113c66ec to 2407a54c9b29 (3 revisions)
2025-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from be5b722c82af to 5070f7af1ee9 (17 revisions)
2025-02-20 jamesgk@google.com [graphite] Require colorspaces for precomp
color xform objects
2025-02-20 danieldilan@google.com Remove transform_scanline functions
from SkJpegEncoderImpl
2025-02-20 lokokung@google.com [dawn][headers] Use ifdefs for flattening
of wgpu::*Limits.
2025-02-20 kjlubick@google.com Add gm to highlight differences in
codepaths to draw blurry rrects
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jacksongardner@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-22 05:32:17 +00:00
zijiehe@
645e9f17a7
[fuchsia] include more tests in the fuchsia builders ( #163800 )
...
This change includes 5 more test suites, and another 5 disabled test
suites. Fixing tests would be performed separately later.
http://b/394632376
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-22 04:25:27 +00:00
Tong Mu
5b7a3c8b20
[Engine] Add RoundSuperellipse to drawing OP ( #160883 )
...
This PR adds support for clipping round superellipse to the engine.
For what a rounded superellipse is, see [this design
doc](https://docs.google.com/document/d/1CJXULKJGQt22FOFsrlm2TKVjKBtif1yU4U50cMfL6Kc/edit?tab=t.0 ).
Video demos can be found at https://github.com/flutter/engine/pull/56726
and https://github.com/flutter/flutter/pull/161409 .
Only impeller can actually render it. On Skia and Web, this shape falls
back to `RRect`.
Part of https://github.com/flutter/flutter/issues/139321 and
https://github.com/flutter/flutter/issues/13914 , also related to
https://github.com/flutter/flutter/issues/91523 .
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-21 23:58:26 +00:00
Gray Mackall
7d23780c7f
[remake] Restore old back handling for FlutterFragmentActivity ( #161545 )
...
Remake of https://github.com/flutter/engine/pull/56565 . Quoting from an
old comment, slightly edited:
------------
https://github.com/flutter/engine/pull/52302 seems to have
unintentionally had the effect of not allowing people to "opt out" of
predictive back. This is actually aligned with what the android docs say
should happen:
https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture
> Note: OnBackPressedCallback is always called regardless of the value
of android:enableOnBackInvokedCallback. In other words, disabling the
system animation doesn't affect your app's back handling logic if it
uses OnBackPressedCallback.
But this wasn't actually true for flutter apps before
https://github.com/flutter/engine/pull/52302 , because we were not
calling `super`, and `FlutterFragmentActivity` extends a
`FragmentActivity` which in turn extends a `ComponentActivity`, which
uses the old `onBackPressed` to [invoke the new back
handling](https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:activity/activity/src/main/java/androidx/activity/ComponentActivity.kt;l=587?q=ComponentActivity ):
```kotlin
override fun onBackPressed() {
onBackPressedDispatcher.onBackPressed()
}
```
So while the docs imply that removing the `onBackPressed` in
`FlutterFragmentActivity` shouldn't have had an effect, that wasn't true
because in our case we were consuming the back event and ignoring the
warning
```java
@Override
@SuppressWarnings("MissingSuperCall")
public void onBackPressed() {
flutterFragment.onBackPressed();
}
```
What all this means is that apps that _aren't_ opting in to predictive
back had their back handling migrated to the new code path
automatically. FlutterFragmentActivity was uniquely is forced into the
new back handling codepath by
https://github.com/flutter/engine/pull/52302 , which this PR fixes.
------------
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-02-21 22:22:24 +00:00
Jenn Magder
57c13944e6
Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" ( #163878 )
...
Reverts flutter/flutter#162365
The timeouts looked like infra issues, but it's no longer flaking.
Fixes https://github.com/flutter/flutter/issues/162364
2025-02-21 21:41:56 +00:00
Jenn Magder
1586b35c21
Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" ( #163880 )
...
Reverts flutter/flutter#159541
This is no longer flaking.
Fixes https://github.com/flutter/flutter/issues/159540
2025-02-21 21:41:56 +00:00
engine-flutter-autoroll
401ab831ee
Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) ( #163885 )
...
https://dart.googlesource.com/sdk.git/+log/c5e582f15b6c..bad289580d9b
2025-02-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-129.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-21 21:41:55 +00:00
Jenn Magder
b1f94c66b8
Revert "Marks Windows_mokey native_assets_android to be flaky" ( #163881 )
...
Reverts flutter/flutter#156064
Should have marked https://github.com/flutter/flutter/issues/156063
fixed but it was already closed.
2025-02-21 21:31:52 +00:00
Jenn Magder
93aca4d43f
Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup ( #163883 )
...
platform_views_hcpp_scroll_perf__timeline_summary is happily passing
https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20platform_views_hcpp_scroll_perf__timeline_summary/255/overview
Introduced in https://github.com/flutter/flutter/pull/163018 .
2025-02-21 21:30:14 +00:00
engine-flutter-autoroll
c6573749d0
Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) ( #163789 )
...
Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions)
https://skia.googlesource.com/skia.git/+log/6da10829d017..1d884bab8593
2025-02-20 jlavrova@google.com Drawing hanging whitespaces in Paragraph
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 26efdfb4f31d to 126c9b378eb7 (5 revisions)
2025-02-20 nscobie@google.com Update SkQPTestCases enforcement for
202504 vendor API bump (Android 16)
2025-02-20 jamesgk@google.com Split format calculation out of
SkWorkingFormatColorFilter
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 7c51661ea28c to 7b44b80c0fac
2025-02-20 michaelludwig@google.com [graphite] Remove TextureInfoData
and TextureSpec in TextureInfo
2025-02-20 nicolettep@google.com [graphite] Prepend input attachment
descriptor set to all Vulkan pipelines layouts
2025-02-20 nicolettep@google.com [graphite] Allow backends to define
resource set/group indices for SkSL generation
2025-02-20 bungeman@google.com [pdf] Developer build dump of input
structure tree
2025-02-20 jvanverth@google.com [graphite] Use linked list for
ClipAtlasManager.
2025-02-20 patrto@microsoft.com Bump golang.org/x/crypto and
golang.org/x/net
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from c77cb9bbcd29 to be5b722c82af (26 revisions)
2025-02-20 borenet@google.com [infra] Update to go 1.22.0 in go.mod
2025-02-20 rop@google.com Updating license IDs to be spdx compliant
2025-02-20 jamesgk@google.com [graphite] Fix precomp tests involving
picture shaders
2025-02-20 nscobie@google.com [graphite] Re-enable BackendTextureTest on
Vulkan (& fix protectedness)
2025-02-20 egdaniel@google.com Revert "[Graphite] Add dawn
disable_lazy_clear_for_mapped_at_creation_buffer toggle"
2025-02-20 robertphillips@google.com [graphite] Update known runtime
effect constants for user-defined known runtime effects
2025-02-20 vmiura@google.com [graphite] Prevent default zero
initializaiton for DrawList members.
2025-02-20 michaelludwig@google.com [skif] Add build flag to avoid slow
small sigma CPU blurs
2025-02-20 robertphillips@google.com [graphite] Shore up snippet ID
error handling in preparation for user-defined known runtime effects
2025-02-20 robertphillips@google.com [graphite] Tinker w/ serialized
pipeline keys a bit
2025-02-20 kjlubick@google.com Reland "Decouple PDF backend and JPEG
encoding/decoding"
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from bace6371e325 to 80093a7d8f85 (14 revisions)
2025-02-20 kjlubick@google.com Reland "Add some checks to avoid
asserting deep in ImageFilter code"
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 65cf97632f2a to c77cb9bbcd29 (16 revisions)
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 720189cae847 to d7ed113c66ec (2 revisions)
2025-02-19 lukasza@chromium.org [rust png] Add a new
`SkCodec::isAnimated` API.
2025-02-19 borenet@google.com [infra] Update Go to 1.24.0
2025-02-19 borenet@google.com [infra] Use SkiaIOS pool for iOS devices
2025-02-19 michaelludwig@google.com [skif] Relax assert in
srcRelativeOutput
2025-02-19 kjlubick@google.com Revert "Decouple PDF backend and JPEG
encoding/decoding"
2025-02-19 kjlubick@google.com Revert "[graphite] Enable
BackendTextureTest on Vulkan"
2025-02-19 kjlubick@google.com Revert "Add some checks to avoid
asserting deep in ImageFilter code"
2025-02-18 robertphillips@google.com [graphite] Move
PipelineCallbackHandler to skiatools for reuse
2025-02-18 kjlubick@google.com Add some checks to avoid asserting deep
in ImageFilter code
2025-02-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5d08bc0b0e23 to 26efdfb4f31d (8 revisions)
2025-02-18 nscobie@google.com [SkQP] Create new AllSkQPTestCases module
for Android framework builds
2025-02-18 nscobie@google.com [graphite] Enable BackendTextureTest on
Vulkan
2025-02-18 kjlubick@google.com Decouple PDF backend and JPEG
encoding/decoding
2025-02-18 drott@chromium.org [Fontations] Match FreeType antialiasing
on unknown pixel geometry
2025-02-18 kjlubick@google.com Use SkSpans in BlurMask and related
classes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
...
Co-authored-by: Jackson Gardner <jacksongardner@google.com>
2025-02-21 21:20:06 +00:00
Matan Lurey
ad76af2327
Enable linux_android_emulator_tests on presubmit. ( #163879 )
...
Finalizes https://github.com/flutter/flutter/issues/163742 .
It passed the last ~10 builds on postsubmit.
2025-02-21 21:09:48 +00:00
Jenn Magder
404655aae1
Update gradle memory properties in example and test projects ( #163798 )
...
Match the example and integration test apps to the the properties in the
`flutter create` template, updated in
https://github.com/flutter/flutter/pull/156201 .
We discussed perhaps making this an auto-migration for existing Flutter
apps (if they've never edited the template from the old values), but it
probably makes sense for devs to manage this themselves depending on how
beefy the machine they are running on is.
Filed https://github.com/flutter/flutter/issues/163801 to show a nicer
message when the user hits this so they can manage
`java.lang.OutOfMemoryError: Java heap space` errors themselves.
Speculatively hoping this helps with the `Java heap space` build test
flakes
https://github.com/flutter/flutter/issues/163121#issuecomment-2665783740
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-21 21:08:20 +00:00
Justin McCandless
df65e46f94
Secure paste milestone 2 ( #159013 )
...
Implements the framework side of secure paste milestone 2, where the iOS
system context menu items can be customized.
Depends on PR https://github.com/flutter/flutter/pull/161103 . Currently
I've merged that PR into this one for testing, but I think that PR
should merge separately first.
### Widget API (most users)
```dart
TextField(
contextMenuBuilder: (BuildContext context, EditableTextState editableTextState) {
return SystemContextMenu.editableText(
editableTextState: editableTextState,
// items is optional
items: <IOSSystemContextMenuItem>[
const IOSSystemContextMenuItemCut(),
constIOS SystemContextMenuItemCopy(),
const IOSSystemContextMenuItemPaste(),
const IOSSystemContextMenuItemSelectAll(),
const IOSSystemContextMenuItemSearchWeb(
title: 'Search!', // title is optional for this button, defaults to localized string
),
// Milestone 3:
IOSSystemContextMenuItemCustom(
// title and onPressed are required
title: 'custom button',
onPressed: () {
print('pressed the custom button.');
}
),
],
);
},
),
```
### Raw Controller API
```dart
_systemContextMenuController.show(
widget.anchor,
<IOSSystemContextMenuItemData>[
// Notice these are different classes than those used for the widget. That's
// mainly because I can't provide localized defaults here, so the titles are
// required in the classes that have titles.
const IOSSystemContextMenuItemDataCut(),
const IOSSystemContextMenuItemDataCopy(),
const IOSSystemContextMenuItemDataPaste(),
const IOSSystemContextMenuItemDataSelectAll(),
const IOSSystemContextMenuItemDataSearchWeb(
title: 'Search!', // title is required.
),
// Milestone 3:
IOSSystemContextMenuItemDataCustom(
// title and onPressed are required as before.
title: 'custom button',
onPressed: () {
print('pressed the custom button.');
}
),
],
);
```
<details>
<summary>Json format</summary>
```dart
return _channel.invokeMethod<Map<String, dynamic>>(
'ContextMenu.showSystemContextMenu',
<String, dynamic>{
'targetRect': <String, double>{
'x': targetRect.left,
'y': targetRect.top,
'width': targetRect.width,
'height': targetRect.height,
},
'items': <dynamic>[
<String, dynamic>{
'type': 'default',
'action': 'paste',
},
<String, dynamic>{
'type': 'default',
'action': 'copy',
},
<String, dynamic>{
'type': 'default',
'title': 'Crazy Title',
'action': 'share',
},
],
},
);
```
</summary>
</details>
### Localization changes
This change requires the SystemContextMenu widget in the widgets library
to be able to look up the default localized label for several context
menu buttons like "Copy", etc. Those strings previously resided in
MaterialLocalizations and CupertinoLocalizations, but not in
WidgetsLocalizations, so I have copied the necessary strings into
WidgetsLocalizations.
---------
Co-authored-by: Huan Lin <hellohuanlin@gmail.com>
2025-02-21 20:48:25 +00:00
Matan Lurey
043b71954c
Enable --explicit-package-dependencies by default. ( #160289 )
...
Closes https://github.com/flutter/flutter/issues/160257 .
~~This will sit on CI for a bit and give me a better idea of how much
work there is to do.~~ Done!
## IMPORTANT: Do **not** revert on 1-2 isolated post-submit failures.
While I've spent the last several weeks getting this passing all
presubmit tests, and some integration tests I suspected might be
affected, it is possible that there are 1-2 integration tests that will
fail as a result of landing this PR. I'll disable the flag
(`--no-explicit-package-dependencies`) if the failures look obvious
enough, otherwise I'll revert.
2025-02-21 19:25:16 +00:00
Moshe Dicker
4d50910b8a
Adds support for applying delta/factor transformations for TextTheme height, letter and word spacing ( #158103 )
...
Closes https://github.com/flutter/flutter/issues/158102
The text theme has the `apply` method which does bulk operations on
multiple text styles. It supports delta/factor ajustements for font
size. This is very helpful for changing all the font sizes at once using
a ratio or a simple delta.
This PR add support for height, letter spacing and and word spacing too.
### Why is this so useful?
Adjusting these in bulk is really helpful for using custom fonts. The
Material font comes which its own default text styes and they're usually
great. But many times they need to be nudged tighter.
### Doc Comment
`apply` has no doc comments for `fontSizeFactor`/`fontSizeDelta` so i
did not add any for the new `letterSpacingFactor`,
`letterSpacingDelta`... either. If we want to add it, I'll do it.
### Tests
Done!
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-02-21 18:40:05 +00:00
Jenn Magder
bb306c53a3
Suppress stderr during Xcode command line installation check ( #163785 )
...
Xcode is in some kind of half-installed state (missing a cert? unknown)
on some devicelab Macs https://github.com/flutter/flutter/issues/161655 .
As of https://github.com/flutter/flutter/pull/163685 Xcode cipd
installation isn't requested as part of the builder configuration, so it
seems like Xcode is just hanging out on that devicelab bot
quasi-installed, unrelated to the recipe.
In any case, the tool is actually doing the right thing and detecting
that Xcode isn't in a good state and continuing as if it isn't
installed, but is logging a wall of error text about it to stderr, which
that Android test doesn't like. Instead of updating the test to allow
stderr, instead swap the Xcode installation path to `exitsHappySync` to
only check the exit code (or exception), which is the original intention
behind the Xcode command line checks.
e6730613c9/packages/flutter_tools/lib/src/base/process.dart (L596-L601)https://github.com/flutter/flutter/issues/161655
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-21 18:36:35 +00:00
Brandon DeRosier
911aa7547e
Remove legacy scenec stuff from flutter_tool ( #163569 )
...
o7
Removes the legacy scenec logic from flutter_tool. We removed scenec
from the engine/shipped artifacts long ago. Originally added in
https://github.com/flutter/flutter/pull/118157 . This has since been
replaced by
[flutter_scene_importer](https://pub.dev/packages/flutter_scene_importer/versions )!
2025-02-21 17:41:02 +00:00
zijiehe@
6018856ece
[fuchsia] reorder tests in test_suites.yaml and update the comment ( #163799 )
...
This is a no-op change to avoid bloating
https://github.com/flutter/flutter/tree/zijiehe-google-com/more-tests .
The change reorders the test_suites.yaml alphabetically and removes the
unused run_with_dart_aot field.
The change should test itself, no extra tests are needed.
http://b/394632376
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-21 17:02:24 +00:00
