fzyzcjy
742a1b49e9
Fix that flutter test
does not understand concurrency
( #125942 )
...
Close https://github.com/flutter/flutter/issues/125940
I will add tests if this PR looks roughly OK :)
The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument.
p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.
2023-05-08 20:25:00 +00:00
Alex Li
6b756ab5ff
Improve the format in asset_bundle.dart
( #126229 )
...
Just found these extra intents and the very long line which might be improved.
Related git blame: https://github.com/flutter/flutter/blame/master/packages/flutter/lib/src/services/asset_bundle.dart#L337 .
2023-05-08 19:13:24 +00:00
fzyzcjy
431dfc8326
Tiny cleanup for Navigator code (without introducing dependency) ( #125628 )
...
Close https://github.com/flutter/flutter/issues/125724
> The `navigator.dart` has ~10 repeats of things like:
>
> ```dart
> final _RouteEntry? currentRouteEntry = _navigator!._history.cast<_RouteEntry?>().lastWhere(
> (_RouteEntry? e) => e != null && _RouteEntry.isPresentPredicate(e),
> orElse: () => null,
> );
> ```
>
> while it can be greatly simplified as:
>
> ```dart
> final _RouteEntry? currentRouteEntry = _navigator!._history.lastWhereOrNull(_RouteEntry.isPresentPredicate);
> ```
>
> Thus, it seems that we can beautify the code a little bit.
Same as https://github.com/flutter/flutter/pull/125099 , but without external dependency
For more detailed explanation why it does not introduce external dependency: https://github.com/flutter/flutter/pull/125099#discussion_r1174230502
2023-05-08 19:03:06 +00:00
Yu
e11a2213e2
[Refactor] Fix style in example ( #126191 )
...
Replaces #125616
I just fixed "IMAGES" to "images" in examples/image_list.
Currently, "PREFER uses the lower case of the constant name ".
2023-05-08 18:57:06 +00:00
engine-flutter-autoroll
bbe6ed2dce
Roll Flutter Engine from a8e9ac63fd95 to d9184ce4ffa0 (2 revisions) ( #126279 )
...
a8e9ac63fd...d9184ce4ff
2023-05-08 godofredoc@google.com Linux fuchsia engine v2 config. (flutter/engine#41759 )
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 5f7e572995b1 to 64ba57381c94 (1 revision) (flutter/engine#41814 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-08 17:35:50 +00:00
Loïc Sharma
472a0ab314
[Tool] Output help on 'flutter pub' ( #126211 )
...
This change makes `flutter pub` show the help usage:
```
PS > flutter pub
Commands for managing Flutter packages.
Global options:
-h, --help Print this usage information.
-v, --verbose Noisy logging, including all shell commands executed.
If used with "--help", shows hidden options. If used with "flutter
doctor", shows additional diagnostic information. (Use "-vv" to force
verbose logging in those cases.)
-d, --device-id Target device id or name (prefixes allowed).
--version Reports the version of this tool.
--suppress-analytics Suppress analytics reporting for the current CLI invocation.
--disable-telemetry Disable telemetry reporting when this command runs.
Usage: flutter pub <subcommand> [arguments]
-h, --help Print this usage information.
Available subcommands:
add Add a dependency to pubspec.yaml.
cache Work with the Pub system cache.
deps Print package dependencies.
downgrade Downgrade packages in a Flutter project.
get Get the current package's dependencies.
global Work with Pub global packages.
login Log into pub.dev.
logout Log out of pub.dev.
outdated Analyze dependencies to find which ones can be upgraded.
pub Pass the remaining arguments to Dart's "pub" tool.
publish Publish the current package to pub.dartlang.org.
remove Removes a dependency from the current package.
run Run an executable from a package.
test Run the "test" package.
token Manage authentication tokens for hosted pub repositories.
upgrade Upgrade the current package's dependencies to latest versions.
uploader Manage uploaders for a package on pub.dev.
version Print Pub version.
Run "flutter help" to see global options.
```
Previously it showed an error message:
```
PS > flutter pub
Missing subcommand for "flutter pub".
Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
```
Addresses https://github.com/flutter/flutter/issues/110025
2023-05-08 17:22:10 +00:00
Jackson Gardner
4439fd41d9
Always use --concurrency=1
for web tests. ( #126179 )
...
This should fix https://github.com/flutter/flutter/issues/126178
When we don't pass a `--concurrency` flag to the test package, it uses a default based on the number of cores that are on the machine. However, the web test platform itself serializes all these requests anyway, which can lead to the test package timing out. This is because from the test package's perspective, it has already started the loading process on a number of suites which are simply waiting for other test suites to compile and run. The ones that wait the longest can run up against the test packages 12 minute timeout for loading a given suite, even though they haven't actually started to try to load.
Instead, we should always pass `--concurrency=1` to the test package so that it doesn't attempt to start loads concurrently in the first place.
2023-05-08 16:33:15 +00:00
Elias Yishak
38cac91057
Add --verbose
flags for flakey tests ( #126162 )
...
Related to:
- https://github.com/flutter/flutter/issues/125512
Adding verbose flags to get printed out on error to help debug the cause of the flakey test
2023-05-08 15:59:28 +00:00
engine-flutter-autoroll
c6f61ef378
Roll Packages from a0f8fd89af1a to 4800d6512ebb (2 revisions) ( #126269 )
...
a0f8fd89af...4800d6512e
2023-05-08 102626803+drewroengoogle@users.noreply.github.com Update .cirrus.yml (flutter/packages#3916 )
2023-05-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) (flutter/packages#3922 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-08 15:53:24 +00:00
Reid Baker
0fdddd67f9
Test AGP 8.0 using java 17 ( #125323 )
...
- Update Gradle/AGP version and add namespace plus dependencies.
https://github.com/flutter/flutter/issues/125181
2023-05-08 15:02:31 +00:00
engine-flutter-autoroll
4ed1c92303
Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) ( #126265 )
...
c42dd23e29...a8e9ac63fd
2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from ab64c4a56e2c to 855e2764c295 (1 revision) (flutter/engine#41813 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-08 14:49:24 +00:00
Elias Yishak
0d5875274b
Clearer text about what happens with --disable-telemetry
+ enable-telemetry command ( #125995 )
...
Fixes:
- https://github.com/flutter/flutter/issues/124411
This PR is cleaning up the `--disable-telemetry` help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag `--enable-telemetry` which will enable telemetry collection
2023-05-08 13:01:25 +00:00
engine-flutter-autoroll
6db4162a9b
Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) ( #126262 )
...
23f730efbf...c42dd23e29
2023-05-08 goderbauer@google.com Fix doc to fix engine roll (flutter/engine#41812 )
2023-05-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.2 to 2.3.3 (flutter/engine#41811 )
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 802eb7f66fc5 to 5f7e572995b1 (1 revision) (flutter/engine#41809 )
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from f9bef8f7bdb5 to 802eb7f66fc5 (1 revision) (flutter/engine#41807 )
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 148ebc0596b7 to f9bef8f7bdb5 (1 revision) (flutter/engine#41806 )
2023-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VD0zJZ-ezOAfA9O1s... to KZrdNPIOcs5m2MqV_... (flutter/engine#41805 )
2023-05-07 skia-flutter-autoroll@skia.org Roll Skia from 642ba306e140 to 148ebc0596b7 (1 revision) (flutter/engine#41804 )
2023-05-07 skia-flutter-autoroll@skia.org Roll Skia from 8a93b289c2ed to 642ba306e140 (1 revision) (flutter/engine#41802 )
2023-05-07 skia-flutter-autoroll@skia.org Roll ICU from d8daa943f64c to a2961dc659b4 (2 revisions) (flutter/engine#41801 )
2023-05-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from k4NzlntuagXZIlCJg... to VD0zJZ-ezOAfA9O1s... (flutter/engine#41800 )
2023-05-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from FFOWihz4lzOeDHmNj... to k4NzlntuagXZIlCJg... (flutter/engine#41799 )
2023-05-06 skia-flutter-autoroll@skia.org Roll Dart SDK from d04e8b571819 to ab64c4a56e2c (1 revision) (flutter/engine#41798 )
2023-05-06 dnfield@google.com Add a `Display` API to dart:ui that reports the physical size, DPR, and refresh rate of the main display (flutter/engine#41685 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from FFOWihz4lzOe to KZrdNPIOcs5m
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-08 12:23:27 +00:00
Michael Goderbauer
9b230d239a
Fix leaks ( #126144 )
...
Fixes https://github.com/flutter/flutter/issues/126096 .
Fixes https://github.com/flutter/flutter/issues/126097 .
Fixes https://github.com/flutter/flutter/issues/126102 .
Fixes https://github.com/flutter/flutter/issues/126098 .
Fixes https://github.com/flutter/flutter/issues/126147 .
Work towards https://github.com/flutter/flutter/issues/126100 .
Does not fix the OverlyEntry/ModalRoute leak (https://github.com/flutter/flutter/issues/126100 ).
2023-05-08 09:11:23 +00:00
Pierre-Louis
65dfb555c0
Update packages ( #126140 )
...
In particular, update pin for `material_color_utilities` to `0.5.0`.
2023-05-08 09:51:28 +02:00
Tirth
835b892d7f
[ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget ( #123971 )
...
Adds `materialGapSize` property to `ExpansionPanelList` widget.
| `materialGapSize: 0` | `materialGapSize: 16` (default) | `materialGapSize: 30` |
| --- | --- | --- |
|  |  |  |
|  |  |  |
|  |  |  |
|  |  |  |
Fixes : #118167
2023-05-06 20:00:22 +00:00
engine-flutter-autoroll
61cdb08a4a
Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) ( #126199 )
...
eedcee66a7...23f730efbf
2023-05-06 skia-flutter-autoroll@skia.org Roll Skia from e7de10e25736 to 8a93b289c2ed (1 revision) (flutter/engine#41796 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 17:20:34 +00:00
engine-flutter-autoroll
4ca3cafd10
Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) ( #126198 )
...
393b5649e7...eedcee66a7
2023-05-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from S3gPFEsS1wP40ivwV... to FFOWihz4lzOeDHmNj... (flutter/engine#41795 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from S3gPFEsS1wP4 to FFOWihz4lzOe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 16:06:42 +00:00
engine-flutter-autoroll
43fa2c01c3
Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) ( #126195 )
...
876968833e...393b5649e7
2023-05-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 8695bed2bc58 to d04e8b571819 (1 revision) (flutter/engine#41793 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 09:02:29 +00:00
林洵锋
7c356d047d
[ios] fix hold and drag spacebar does not move cursor when obscureTex… ( #122383 )
...
Fixes #122139 with engine pr [flutter/engine#40216 ](https://github.com/flutter/engine/pull/40216 )
2023-05-06 04:22:11 +00:00
engine-flutter-autoroll
3bf4acb013
Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) ( #126192 )
...
d9116d94a1...876968833e
2023-05-06 skia-flutter-autoroll@skia.org Roll Skia from 2e622658996c to e7de10e25736 (1 revision) (flutter/engine#41791 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 04:20:42 +00:00
engine-flutter-autoroll
4476c54c8c
Roll Flutter Engine from 332f53219c4c to d9116d94a111 (1 revision) ( #126190 )
...
332f53219c...d9116d94a1
2023-05-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Z3O1yYOsNgkQ6b0o3... to S3gPFEsS1wP40ivwV... (flutter/engine#41790 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Z3O1yYOsNgkQ to S3gPFEsS1wP4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 03:20:35 +00:00
engine-flutter-autoroll
615a2d6510
Roll Flutter Engine from b7c79b41b9d4 to 332f53219c4c (3 revisions) ( #126188 )
...
b7c79b41b9...332f53219c
2023-05-06 skia-flutter-autoroll@skia.org Roll Skia from bc0197405951 to 2e622658996c (1 revision) (flutter/engine#41789 )
2023-05-05 jonahwilliams@google.com [Impeller] remove SDF code paths. (flutter/engine#41754 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jbpFz7qSikrKiRanC... to leCRDVJ8szOS2LsPV... (flutter/engine#41788 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jbpFz7qSikrK to leCRDVJ8szOS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 02:16:31 +00:00
Alex Li
62a4643e4f
✨ Add rect
argument to _ArcPaintPredicate
for tests ( #125953 )
...
As preparation for #125945 .
The PR improves tests itself which allows the `arc` method to be available to check whether corresponding rects are drawn during tests.
2023-05-06 02:10:36 +00:00
engine-flutter-autoroll
45cd2afc5f
Roll Flutter Engine from 758cbadfac1f to b7c79b41b9d4 (4 revisions) ( #126187 )
...
758cbadfac...b7c79b41b9
2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from aa52cd1afae2 to bc0197405951 (3 revisions) (flutter/engine#41787 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Dart SDK from bb9f17a8f0c3 to 8695bed2bc58 (1 revision) (flutter/engine#41786 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from d6149a13d696 to aa52cd1afae2 (3 revisions) (flutter/engine#41783 )
2023-05-05 zanderso@users.noreply.github.com Roll impeller-cmake-example to 270e648f8c00aa900d2d16ef8a347938652d17fb (flutter/engine#41758 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-06 01:23:12 +00:00
Loïc Sharma
a47a754539
Add Windows and Linux support to the 'layers' example ( #126105 )
...
Enables running the `layers` example on Linux and Windows.
Part of https://github.com/flutter/flutter/issues/126033
2023-05-06 00:45:19 +00:00
Kevin Moore
43ac23b4c7
targets/web.dart - fix typo ( #126114 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-05-05 23:53:23 +00:00
engine-flutter-autoroll
a9053fbc6c
Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) ( #126175 )
...
6b467df16e...758cbadfac
2023-05-05 jason-simmons@users.noreply.github.com [Impeller] Do not free a Vulkan command buffer if its command pool has already been destroyed (flutter/engine#41761 )
2023-05-05 dkwingsmt@users.noreply.github.com Remove single window assumption from SceneBuilder (flutter/engine#41559 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 22:05:36 +00:00
Viren Khatri
d5df458684
add tests for dominant bottom sheet in scaffold ( #124472 )
...
while debugging https://github.com/flutter/flutter/issues/123882 found out that below lines were untested. although they'll change due to the issue above, but the tests will remain.
e0045d04f7/packages/flutter/lib/src/material/scaffold.dart (L3169-L3180)
2023-05-05 20:51:14 +00:00
Patrick Lindsay
37f348b006
Added CupertinoDatepicker monthYear mode (flutter#93508) ( #125603 )
...
This PR adds a month and year mode to the CupertinoDatePicker. The monthYear mode is the date mode without the day of the month.

This feature was added at the request of:
[Proposal] CupertinoDatePicker with month and year. #93508
One thing that I was unsure of was the use of the DatePickerDateOrder to determine the monthYear order. It could be considered a workaround since the DatePickerDateOrder is intended to order day, month, and year. This means that a developer could use the DatePickerDateOrder.dmy (day, month, year) or DatePickerDateOrder.mdy (month, day, year) to get the same result.
At first I intended to add a DatePickerMonthYearOrder enum to the localizations, in addition to a new parameter for the CupertinoDatePicker for monthYearOrder, but I ended up reverting these changes (1c61f1084e
) because I had not considered the effects of adding values to the localizations.
I decided it may be better to not add an additional parameter (monthYearOrder) that would go mostly unused. I am very open to feedback or ideas on this matter.
2023-05-05 20:49:34 +00:00
Qun Cheng
c1c2513ac9
Add Switch.trackOutlineWidth
property ( #125848 )
2023-05-05 13:34:08 -07:00
chunhtai
78ed142f30
Rename iosdeeplinksettings to iosuniversallinksettings ( #126173 )
...
as title
2023-05-05 20:02:27 +00:00
engine-flutter-autoroll
be0aa01b18
Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) ( #126174 )
...
f3efe11f44...6b467df16e
2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from 1a1c7db436e4 to d6149a13d696 (6 revisions) (flutter/engine#41779 )
2023-05-05 godofredoc@google.com Replace legacy linux unopt with engine v2. (flutter/engine#41757 )
2023-05-05 godofredoc@google.com Allow default out_dir for fuchsia symbols upload. (flutter/engine#41776 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 19:58:24 +00:00
Alberto Azinar
4d4b3cf2f7
improvement : removed required kotlin dependency ( #125002 )
...
This PR removed the non-necessary required Koltin dependency. This is because the Kotlin Gradle adds the dependency on the standard library automatically.
Fixes #98212
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy]. *
2023-05-05 19:47:22 +00:00
ChenRenJie
dbcff31ed0
Fix incorrect assert hint in flutter.groovy ( #125283 )
...
When I include flutter in my exist android project by
`include_flutter.groovy`, it hint me:
```
Project :app doesn't exist. To custom the host app project name, set `org.gradle.project.flutter.hostAppProjectName=<project-name>` in gradle.properties.
```
But set `org.gradle.project.flutter.hostAppProjectName` has no effect,
acutally need to set `flutter.hostAppProjectName`.
This pr is to fix this incorrect hint.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-05 15:34:54 -04:00
Drew Roen
676be36651
Update .cirrus.yml ( #126166 )
...
The previous key expires in 5 days: https://github.com/flutter/flutter/issues/126072
2023-05-05 19:16:55 +00:00
Kevin Moore
f9d455134a
tool: replace top-level functions with enum properties ( #126167 )
2023-05-05 19:10:07 +00:00
Jackson Gardner
201f7311f7
Use direct dart API from dart:ui_web
rather than JS shim. ( #123443 )
...
This is based off (and dependent on) these changes in the web engine that expose web-specific APIs: https://github.com/flutter/engine/pull/40608
2023-05-05 18:17:21 +00:00
Istiak Ahmed
042eaf6b90
Add sample code for SliverAppBar ( #125785 )
...
This PR adds an another example for SliverAppBar, showing the use of stretch and onStretchTrigger
https://user-images.githubusercontent.com/68919043/235420973-2bfb9871-9e05-4d87-9538-941d43178c76.mp4
Fixes #125651
### Adds sample code for SliverAppBar [stretch, onStretchTrigger]
This PR adds an another simple and easily understandable example code for SliverAppBar.
2023-05-05 18:09:25 +00:00
engine-flutter-autoroll
f57d38f7f2
Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) ( #126163 )
...
cef0e9d1a9...f3efe11f44
2023-05-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 07016e96b9ed to bb9f17a8f0c3 (1 revision) (flutter/engine#41773 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from d71ece9f9f1a to 1a1c7db436e4 (1 revision) (flutter/engine#41772 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from de2Eqw0IsOzTq15m3... to Z3O1yYOsNgkQ6b0o3... (flutter/engine#41771 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from de2Eqw0IsOzT to Z3O1yYOsNgkQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 17:02:15 +00:00
Bruno Leroux
de2615462c
Add a ReorderableListView example with cards + cleanup existing tests ( #126155 )
...
## Description
This PR adds one `ReorderableListView` example to demonstrate how `proxyDecorator` can be used to animate cards elevation.
https://user-images.githubusercontent.com/840911/236468570-d2b33ab3-6b6d-4f8d-90de-778dcf1ad8ce.mp4
For motivation, see https://github.com/flutter/flutter/issues/124729#issuecomment-1521524190 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/124729
## Tests
Adds 1 tests.
This PR also moves some misplaced example tests from `examples/api/test/reorderable_list` to `examples/api/test/material/reorderable_list` (and replaces two existing ones).
2023-05-05 16:39:11 +00:00
engine-flutter-autoroll
e24de32760
Roll Packages from 6bd59cdb8fb5 to a0f8fd89af1a (4 revisions) ( #126161 )
...
6bd59cdb8f...a0f8fd89af
2023-05-05 tarrinneal@gmail.com tree fix (flutter/packages#3910 )
2023-05-05 tarrinneal@gmail.com manual roll and fix (flutter/packages#3903 )
2023-05-04 stuartmorgan@google.com [file_selector] Add `getDirectoryPaths` (flutter/packages#3871 )
2023-05-04 75943909+TheUltimateOptimist@users.noreply.github.com [go_router_builder] fixed typo in README (flutter/packages#3835 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 15:59:07 +00:00
Drew Roen
9de9a81b80
Bring back the failing build_test's ( #126014 )
...
https://github.com/flutter/flutter/issues/125897
The issue has been resolved, so bringing the tests out of bringup
2023-05-05 15:54:43 +00:00
Mouad Debbar
28f3037758
[web] Use plain platform views in benchmarks ( #126080 )
...
Removing the dependency between web benchmarks and `url_launcher`'s `Link` widget.
2023-05-05 14:17:34 +00:00
Taha Tesser
ad009fb7ac
Fix Material 3 tab indicator weight and position ( #125883 )
...
fixes https://github.com/flutter/flutter/issues/123112
### Description
1. Add proper M3 indicator height aka`IndictorWeight` from the M3 specs for the primary tab bar with label indicator size.
db6074ade4/dev/tools/gen_defaults/data/navigation_tab_primary.json (L9)
(this was held due to `indicatorWeight` having a hard-coded value)
and added a secondary tab bar indicator height.
2. Set a minimum value for the rounded indicator to maintain the indicator shape.
3. With proper indicator height, the rounded indicator position is also fixed.
4. Fix round indicator is shown for the primary tab bar with tab indicator size.
5. Above changes fix https://github.com/flutter/flutter/issues/123112 .
6. Fix the `startOffset` const value from https://github.com/flutter/flutter/pull/125036 to match docs and move it to a variable.
2023-05-05 14:09:18 +00:00
engine-flutter-autoroll
9d9ad2d52f
Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) ( #126150 )
...
b0f53e7751...cef0e9d1a9
2023-05-05 skia-flutter-autoroll@skia.org Roll Dart SDK from eff8f62a7bc7 to 07016e96b9ed (1 revision) (flutter/engine#41770 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 13:33:50 +00:00
engine-flutter-autoroll
5120a0df62
Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) ( #126148 )
...
6f26066144...b0f53e7751
2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from edc4ee2e286e to d71ece9f9f1a (2 revisions) (flutter/engine#41768 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m0-fwGyFnoDVAvxgk... to jbpFz7qSikrKiRanC... (flutter/engine#41769 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from m0-fwGyFnoDV to jbpFz7qSikrK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 11:47:37 +00:00
engine-flutter-autoroll
d3f2fc79d1
Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) ( #126141 )
...
764991e046...6f26066144
2023-05-05 skia-flutter-autoroll@skia.org Roll Dart SDK from afeed9f8701e to eff8f62a7bc7 (2 revisions) (flutter/engine#41764 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 09:49:01 +00:00
engine-flutter-autoroll
9ddba1be35
Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) ( #126137 )
...
e7cd29153a...764991e046
2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from bf4217c3f0da to edc4ee2e286e (1 revision) (flutter/engine#41763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 08:44:25 +00:00
engine-flutter-autoroll
59c1ac4103
Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) ( #126135 )
...
a885ed472e...e7cd29153a
2023-05-05 dkwingsmt@users.noreply.github.com [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 07:55:09 +00:00