firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4,579 Commits 1 Branch 0 Tags
Commit Graph

4579 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ian Hickson
7544514484 Merge pull request #2566 from Hixie/avoid_empty_else_lint 
Remove the _EquationMember.hashCode override
 2016-03-10 21:35:12 -08:00
Ian Hickson
167c433a56 Merge pull request #2520 from Hixie/TextSpan.toString 
Fix crash when dumping the app if it uses RichText
 2016-03-10 21:33:07 -08:00
Ian Hickson
7cf2dbdf37 Fix crash when dumping the app if it uses RichText 
Specifically:

* Handle null styles in TextSpan without crashing in toString().

* Handle null children in TextSpan child lists without crashing in
  toString().

* Handle entirely empty TextSpans in toString() explicitly.

* Assert that TextSpans don't contain nulls in various places. This is
  done more often than one might think necessary, because it turns out
  that TextSpan takes a (mutable) List for one of its arguments, so
  who knows what it will contain at any given time. By asserting all
  over the place, hopefully we'll catch it near the change if they do
  change it.

* Add a RichText example to Stocks to exercise RichText and TextSpans.

See also: https://github.com/flutter/flutter/issues/2514, https://github.com/flutter/flutter/issues/2519
 2016-03-10 20:48:50 -08:00
Adam Barth
3dc22dce58 Merge pull request #2599 from abarth/rebuild_render_object_widget 
Prepare to make RenderObjectElement buildable
 2016-03-10 20:45:32 -08:00
Adam Barth
0327141c37 Prepare to make RenderObjectElement buildable 
This patch prepares us to pass a BuildContext to RenderObjectWidgets, which
will make it possible to rebuild RenderObjectElements:

 * Delay creation of the render object until mount(). That will let us pass
   `this` to createRenderObject and have the inherited elements be initialized.

 * Cleanup widgets that take builder closures to prepare for their
   RenderObjectElement to be rebuilt more often.

 * Add a test for the interaction between inherited widgets and
   MixedViewport.

Related to #2598
 2016-03-10 20:18:37 -08:00
Adam Barth
945d6b0126 Merge pull request #2596 from abarth/rm_closure 
Use a member function instead of an anonymous closure
 2016-03-10 18:55:31 -08:00
Hixie
1d03522857 Remove the _EquationMember.hashCode override 
Since we removed our operator== overload, we can now allow people to put
these in collections again.

Also, turn on two more analyzer lints: avoid_empty_else and hash_and_equals.
 2016-03-10 17:27:02 -08:00
Chinmay Garde
48fc37f914 Merge pull request #2595 from chinmaygarde/master 
Update engine revision to pick up fixes for precompilation variants
 2016-03-10 16:32:55 -08:00
Chinmay Garde
425aeaf403 Update engine revision to pick up fixes for precompilation variants 2016-03-10 16:32:16 -08:00
Adam Barth
7f5d6a9913 Use a member function instead of an anonymous closure 
It's slightly more efficient.
 2016-03-10 16:31:43 -08:00
Adam Barth
fd8695b64a Merge pull request #2593 from abarth/more_dots 
Use the .. pattern more in updateRenderObject
 2016-03-10 16:03:12 -08:00
Adam Barth
10591730f5 Use the .. pattern more in updateRenderObject 2016-03-10 15:34:53 -08:00
Viktor Lidholt
b054234495 Merge pull request #2585 from vlidholt/master 
Initial support for links in markdown
 2016-03-10 14:46:17 -08:00
Devon Carew
83caeb35ed Merge pull request #2584 from devoncarew/redux_analysis_options 
move the analysis_options to a file
 2016-03-10 14:37:58 -08:00
Eric Seidel
c62ce87cf5 Merge pull request #2588 from flutter/revert-2506-device_port_forward 
Revert "Add DevicePortForwarder"
 2016-03-10 14:23:56 -08:00
Eric Seidel
37f0b5dd98 Revert "Add DevicePortForwarder" 2016-03-10 14:23:39 -08:00
Devon Carew
b9fafc1765 adjust a regex for intl files 2016-03-10 14:21:23 -08:00
Yegor
96db7c0a5a Merge pull request #2580 from yjbanov/lower-xcode-version-requirement 
[ios] reduce xcode version requirement to 7.0
 2016-03-10 14:08:48 -08:00
Viktor Lidholt
800e2558ba Initial support for links in markdown 2016-03-10 14:08:32 -08:00
Adam Barth
d76857aa96 Merge pull request #2583 from abarth/update_engine 
Update engine
 2016-03-10 13:54:47 -08:00
Devon Carew
780e4e6212 move the analysis_options to a file 2016-03-10 13:47:20 -08:00
Adam Barth
a9f72633c4 Update engine 2016-03-10 13:39:20 -08:00
John McCutchan
5fcaebbf51 Merge pull request #2506 from johnmccutchan/device_port_forward 
Add DevicePortForwarder
 2016-03-10 13:23:40 -08:00
Yegor Jbanov
23e634a613 [ios] reduce xcode version requirement to 7.0 
Build bots only have 7.0.
 2016-03-10 13:08:58 -08:00
John McCutchan
131359f4bc Add DevicePortForwarder 2016-03-10 12:49:07 -08:00
Jason Simmons
3b5fba4022 Merge pull request #2578 from jason-simmons/flx_working_dir 
Add an option to specify a working directory for the FLX builder
 2016-03-10 12:43:35 -08:00
Yegor
c2b175d1db Merge pull request #2575 from yjbanov/ios-device-discovery 
[ios] look for the best available devicetype/runtime when booting
 2016-03-10 11:25:56 -08:00
Matt Perry
df7de98635 Merge pull request #2558 from mpcomplete/text.demo 
Add a basic Text Fields demo to Material Gallery app.
 2016-03-10 14:04:35 -05:00
Yegor Jbanov
9383466dd5 [ios] look for the best available devicetype/runtime when booting 2016-03-10 11:04:02 -08:00
Matt Perry
0da63e4c2b Add a basic Text Fields demo to Material Gallery app. 
BUG=https://github.com/flutter/flutter/issues/1547
 2016-03-10 13:56:43 -05:00
Eric Seidel
3d8176ed16 Merge pull request #2571 from eseidelGoogle/run_pub_fail 
`flutter run` should fail if `pub get` fails.
 2016-03-10 09:53:14 -08:00
Eric Seidel
3e2a4d9b4d flutter run should fail if pub get fails. 
Previously we were ignoring the return code and continuing.

@devoncarew
 2016-03-10 09:36:09 -08:00
Hans Muller
8f603800ba Merge pull request #2532 from HansMuller/scaffold 
Scaffold saves and restores scrollable state, etc
 2016-03-10 09:33:35 -08:00
Hans Muller
9536c418fc Scaffold saves and restores scrollable state, etc 2016-03-10 09:19:04 -08:00
Adam Barth
6d646860d4 Merge pull request #2570 from abarth/rev_engine 
Update engine
 2016-03-10 08:50:37 -08:00
Adam Barth
86ff7b99a5 Update engine 
Fixes #2569
 2016-03-10 08:39:15 -08:00
Ian Hickson
b6ff67cc2c Merge pull request #2568 from Hixie/always_declare_return_types 
Enable always_declare_return_types lint
 2016-03-09 20:49:14 -08:00
Hixie
c7339de6bc Enable always_declare_return_types lint 
And fix a zillion omissions this uncovered.
 2016-03-09 17:57:39 -08:00
Yegor
bdc8388699 Merge pull request #2567 from yjbanov/engine-version-f2d8d75897a5aadcd9be0067a78fce1cea677fd6 
[engine] bump version to f2d8d75897a5aadcd9be0067a78fce1cea677fd6
 2016-03-09 17:56:35 -08:00
Ian Hickson
c8b9b945e5 Merge pull request #2563 from Hixie/dependencies 
Make flutter analyze useful for package conflicts
 2016-03-09 17:41:20 -08:00
Hixie
8950d3ccc4 Make flutter analyze useful for package conflicts 
Also, resolve our package conflict, since reflectable has been fixed.
 2016-03-09 17:41:05 -08:00
yjbanov
670b79c923 [engine] bump version to f2d8d75897a5aadcd9be0067a78fce1cea677fd6 2016-03-09 17:40:57 -08:00
Ian Hickson
292d5aab51 Merge pull request #2550 from Hixie/not-as 
Not as
 2016-03-09 15:18:09 -08:00
Hixie
5810cd80bd Avoid 'as' keyword 
It has performance implications in release mode.

We'll enable the lint once https://github.com/dart-lang/linter/issues/195 is fixed.
 2016-03-09 15:00:55 -08:00
Jason Simmons
5108a6cc58 Add an option to specify a working directory for the FLX builder 
This allows building an FLX without leaving any temporary files in the app's
source directory
 2016-03-09 14:59:40 -08:00
Adam Barth
778c3a05b1 Merge pull request #2530 from abarth/to_string 
Improve InputValue#toString
 2016-03-09 13:56:53 -08:00
Adam Barth
77dd3eba7d Merge pull request #2521 from abarth/test_animation_leaks 
Test harness should check for running Timers and AnimationControllers
 2016-03-09 13:48:29 -08:00
Adam Barth
0d7b0f9ec1 Test harness should check for running Timers and AnimationControllers 
After running a widget test, we now clear out the widget tree and check that we
didn't leak any timers or animations.

Also, fix several bugs that this addtional check revealed.

Fixes #2481
 2016-03-09 13:37:24 -08:00
Viktor Lidholt
59bba072d4 Merge pull request #2496 from vlidholt/markdown 
Adds initial version of Markdown renderer
 2016-03-09 13:17:07 -08:00
Viktor Lidholt
48c7a04f1f Adds initial version of Markdown renderer 2016-03-09 13:07:36 -08:00