philipfranchi
77201fdf71
Adds semanticsLabel to MenuItemButton ( #145846 )
...
This PR adds a `semanticsLabel` field to the MenuItemButton, letting users pass in a Semantics Label if they have issues with the way a ScreenReader reads the generated text.
fixes: [142939: Screen Readers won't read punctuation characters in Shortcuts](https://github.com/flutter/flutter/issues/142939 )
2024-04-04 21:19:45 +00:00
auto-submit[bot]
23ecc37ed2
Reverts "Bump to AGP 8.1/Gradle 8.3 (almost) everywhere ( #146181 )" ( #146305 )
...
Reverts: flutter/flutter#146181
Initiated by: LongCatIsLooong
Reason for reverting: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20flavors_test_win/11086/overview
Original PR Author: gmackall
Reviewed By: {reidbaker, christopherfujino}
This change reverts the following previous change:
Bump almost all tests to AGP 8.1 and Gradle 8.3
Flutter gallery is excluded, because it uses discontinued plugins that in turn use old Gradle versions, and that prevents upgrading. Will take some extra work to figure out what to do there.
Should bump templates next
Entire PR generated with the lockfile generation script, except for:
1. changes within `dev/integration_tests/gradle_deprecated_settings/android/`, which must be done manually (and exclusion of the gallery for reason mentioned above).
2. Changes to many `AndroidManifest.xml` files to remove the `package` attribute and instead set that same value in the `build.gradle`, in the `namespace` attribute of the `android` closure (corresponds to an AGP behavior change, see https://d.android.com/r/tools/upgrade-assistant/set-namespace ).
3. Removes the use of the `battery` plugin in `android_embedding_v2_smoke_test` because the plugin is discontinued, unused, and blocks upgrading the AGP version for that app because the discontinued plugin itself uses a very old AGP version.
2024-04-04 21:07:17 +00:00
engine-flutter-autoroll
3c29c123b0
Roll Flutter Engine from 918c72b803cc to fa4d97e363ff (2 revisions) ( #146299 )
...
918c72b803...fa4d97e363john@johnmccutchan.com Expand understanding of build targets in et (flutter/engine#51868 )
2024-04-04 skia-flutter-autoroll@skia.org Roll Skia from 8caa3e2592d5 to d58a6dbaaadb (1 revision) (flutter/engine#51909 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 20:15:23 +00:00
Gray Mackall
ab520c9849
Bump to AGP 8.1/Gradle 8.3 (almost) everywhere ( #146181 )
...
Bump almost all tests to AGP 8.1 and Gradle 8.3
Flutter gallery is excluded, because it uses discontinued plugins that in turn use old Gradle versions, and that prevents upgrading. Will take some extra work to figure out what to do there.
Should bump templates next
Entire PR generated with the lockfile generation script, except for:
1. changes within `dev/integration_tests/gradle_deprecated_settings/android/`, which must be done manually (and exclusion of the gallery for reason mentioned above).
2. Changes to many `AndroidManifest.xml` files to remove the `package` attribute and instead set that same value in the `build.gradle`, in the `namespace` attribute of the `android` closure (corresponds to an AGP behavior change, see https://d.android.com/r/tools/upgrade-assistant/set-namespace ).
3. Removes the use of the `battery` plugin in `android_embedding_v2_smoke_test` because the plugin is discontinued, unused, and blocks upgrading the AGP version for that app because the discontinued plugin itself uses a very old AGP version.
2024-04-04 20:11:09 +00:00
engine-flutter-autoroll
dd9ca773b5
Roll Flutter Engine from 03cd54d4285a to 918c72b803cc (2 revisions) ( #146296 )
...
03cd54d428...918c72b803skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5W6KVvHCGwWHBjm2m... to TAr6MCirveGvhZFHK... (flutter/engine#51842 )
2024-04-04 skia-flutter-autoroll@skia.org Roll Skia from 4a9e0d0eaa9e to 8caa3e2592d5 (2 revisions) (flutter/engine#51906 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5W6KVvHCGwWH to TAr6MCirveGv
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 19:22:10 +00:00
Taha Tesser
7c72a089e1
Fix InputDecorator suffix and prefix IconButtons ignore IconButtonTheme ( #145473 )
...
fixes [DropdownMenu TrailingIcon can't be styled through providing an IconButtonTheme](https://github.com/flutter/flutter/issues/145081 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: IconButtonTheme(
data: IconButtonThemeData(
style: IconButton.styleFrom(
foregroundColor: const Color(0xffff0000),
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.circular(10.0),
),
),
),
child: SizedBox(
width: 300,
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
const Text('IconButton'),
IconButton(onPressed: () {}, icon: const Icon(Icons.search)),
const Text('TextField'),
TextField(
decoration: InputDecoration(
prefixIcon: IconButton(
onPressed: () {},
icon: const Icon(Icons.search),
),
suffixIcon: IconButton(
onPressed: () {},
icon: const Icon(Icons.search),
),
),
),
],
),
),
),
),
),
);
}
}
```
</details>
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/69b5966b-c95d-4934-b867-3262d1377f70 " /> | <img src="https://github.com/flutter/flutter/assets/48603081/0064db2b-0379-4424-a5bf-39bdc5441fe8 " /> |
2024-04-04 19:20:30 +00:00
Gray Mackall
1d89ae3f65
Give generate_gradle_lockfiles.dart functionality to exclude certain subdirectories ( #146228 )
...
Fixes https://github.com/flutter/flutter/issues/146216 .
2024-04-04 18:40:07 +00:00
Victor Sanni
226546b640
Update documentation to discourage using the TextEditingController.text setter ( #146151 )
...
Fixes #129272
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-04 10:51:56 -07:00
engine-flutter-autoroll
3691b0974a
Roll Flutter Engine from b2ceabf7acce to 03cd54d4285a (1 revision) ( #146292 )
...
b2ceabf7ac...03cd54d428skia-flutter-autoroll@skia.org Roll Skia from 3844fc48802d to 4a9e0d0eaa9e (1 revision) (flutter/engine#51904 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 17:36:11 +00:00
engine-flutter-autoroll
3646977130
Roll Flutter Engine from b435a8a87df0 to b2ceabf7acce (1 revision) ( #146283 )
...
b435a8a87d...b2ceabf7acskia-flutter-autoroll@skia.org Roll Skia from 02b2800d216e to 3844fc48802d (3 revisions) (flutter/engine#51903 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 17:00:08 +00:00
engine-flutter-autoroll
e9446d4006
Roll Flutter Engine from bd51ee80d74b to b435a8a87df0 (1 revision) ( #146279 )
...
bd51ee80d7...b435a8a87djason-simmons@users.noreply.github.com Generate only one "Frame Request Pending" event for each pending call to BeginFrame (flutter/engine#51857 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 16:13:13 +00:00
engine-flutter-autoroll
a70452afe6
Roll Packages from 0e848facdb53 to dce6f0c91fcf (4 revisions) ( #146276 )
...
0e848facdb...dce6f0c91fflutter/packages#6459 )
2024-04-03 tarrinneal@gmail.com [pigeon] Allow multi instance support with message channel name suffix (flutter/packages#6224 )
2024-04-03 reidbaker@google.com [Tool] Add ability to check dependencies independently of dev-dependencies, exclude integration_test from dependencies (flutter/packages#6446 )
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter from a418568a6498 to e868e2b3834f (34 revisions) (flutter/packages#6455 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 15:46:45 +00:00
Daco Harkes
ef826ec50b
Flutter templates example app Gradle memory settings ( #146275 )
...
Tries to address: https://github.com/flutter/flutter/issues/146236
2024-04-04 15:43:52 +00:00
engine-flutter-autoroll
2c832bb8ed
Roll Flutter Engine from 4303dc0d7a73 to bd51ee80d74b (2 revisions) ( #146273 )
...
4303dc0d7a...bd51ee80d7skia-flutter-autoroll@skia.org Roll Skia from 2cead39756d8 to 02b2800d216e (1 revision) (flutter/engine#51901 )
2024-04-04 skia-flutter-autoroll@skia.org Roll Skia from bef4d9b44369 to 2cead39756d8 (1 revision) (flutter/engine#51899 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 15:33:24 +00:00
engine-flutter-autoroll
ac2ca9347c
Roll Flutter Engine from aadf522e3c98 to 4303dc0d7a73 (1 revision) ( #146262 )
...
aadf522e3c...4303dc0d7askia-flutter-autoroll@skia.org Roll Skia from 5fdc2b47dfa4 to bef4d9b44369 (1 revision) (flutter/engine#51895 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 09:09:20 +00:00
engine-flutter-autoroll
502af830e7
Roll Flutter Engine from c57c8665b4eb to aadf522e3c98 (1 revision) ( #146261 )
...
c57c8665b4...aadf522e3cskia-flutter-autoroll@skia.org Roll Skia from 57bc01affec1 to 5fdc2b47dfa4 (1 revision) (flutter/engine#51894 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 08:21:20 +00:00
engine-flutter-autoroll
f54c3567e9
Roll Flutter Engine from ca7596642cfd to c57c8665b4eb (1 revision) ( #146259 )
...
ca7596642c...c57c8665b4skia-flutter-autoroll@skia.org Roll Skia from 094de1a7c3cf to 57bc01affec1 (1 revision) (flutter/engine#51892 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 07:14:23 +00:00
engine-flutter-autoroll
6a0573dbdd
Roll Flutter Engine from 83c037c449b5 to ca7596642cfd (1 revision) ( #146258 )
...
83c037c449...ca7596642cskia-flutter-autoroll@skia.org Roll Skia from 83f4b7bbb91d to 094de1a7c3cf (1 revision) (flutter/engine#51891 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 05:52:25 +00:00
engine-flutter-autoroll
53f3f65460
Roll Flutter Engine from 614154012e93 to 83c037c449b5 (1 revision) ( #146255 )
...
614154012e...83c037c449jonahwilliams@google.com [Impeller] dont inc shared_ptr count for every command/pipeline in render_pass_vk (flutter/engine#51874 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 04:11:23 +00:00
engine-flutter-autoroll
7b62d2a696
Roll Flutter Engine from 41da00ac46bc to 614154012e93 (1 revision) ( #146250 )
...
41da00ac46...614154012eskia-flutter-autoroll@skia.org Roll Skia from fdbdb26b7029 to 83f4b7bbb91d (1 revision) (flutter/engine#51888 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 02:03:25 +00:00
engine-flutter-autoroll
95aaf0e4bd
Roll Flutter Engine from 18fdcad40332 to 41da00ac46bc (6 revisions) ( #146246 )
...
18fdcad403...41da00ac46jonahwilliams@google.com [Impeller] cleanup auto usage in host_buffer (flutter/engine#51875 )
2024-04-03 skia-flutter-autoroll@skia.org Roll Skia from 82ae8ae5d3fb to fdbdb26b7029 (1 revision) (flutter/engine#51886 )
2024-04-03 matanlurey@users.noreply.github.com Remove the bringup 20x emulator config. (flutter/engine#51885 )
2024-04-03 skia-flutter-autoroll@skia.org Roll Skia from 7d6dce620e46 to 82ae8ae5d3fb (2 revisions) (flutter/engine#51883 )
2024-04-03 jonahwilliams@google.com [scenarios] Use adb to take screenshot, block on screenshot operation. (flutter/engine#51879 )
2024-04-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 85adde7d4b5a to 5b812b9ec220 (2 revisions) (flutter/engine#51884 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 01:10:24 +00:00
flutter-pub-roller-bot
7db25fe30f
Roll pub packages ( #146245 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-04-04 00:27:34 +00:00
Kostia Sokolovskyi
8101f13a35
Add tests for theme_extension.1.dart API example. ( #145819 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds tests for `examples/api/lib/material/theme/theme_extension.1.dart`
2024-04-03 23:39:17 +00:00
engine-flutter-autoroll
1d0081feaf
Roll Flutter Engine from 349608d2b008 to 18fdcad40332 (6 revisions) ( #146240 )
...
349608d2b0...18fdcad403skia-flutter-autoroll@skia.org Roll Skia from 8d7482b998d0 to 7d6dce620e46 (1 revision) (flutter/engine#51878 )
2024-04-03 jacksongardner@google.com Be slightly more lenient about the assertion, as it differs on different backends. (flutter/engine#51877 )
2024-04-03 skia-flutter-autoroll@skia.org Roll Skia from afa233bb1979 to 8d7482b998d0 (2 revisions) (flutter/engine#51876 )
2024-04-03 chinmaygarde@google.com [Impeller] Enable logging a warning when the user opts out of using Impeller. (flutter/engine#51849 )
2024-04-03 jonahwilliams@google.com [Impeller] delete unused code. (flutter/engine#51871 )
2024-04-03 jonahwilliams@google.com [Impeller] eliminate sub-render pass for blended color + texture vertices. (flutter/engine#51778 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 23:10:26 +00:00
Kallen Tu
2c976b48d4
Add missing_code_block_language_in_doc_comment lint. ( #145354 )
...
Adds this Dartdoc lint to the flutter repository, in replacement of the
warning it used to have.
Lint Proposal: https://github.com/dart-lang/linter/issues/4904
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-03 16:00:25 -07:00
Ian Hickson
13bec286bd
Magnifier cleanup ( #143558 )
...
- Introduces the ability to control whether RawMagnifier uses a clip on
its decoration. (It still has to use a clip for its magnified image.)
- Uses `BlurStyle.outer` to remove the clip for CupertinoMagnifier.
- Many changes to the documentation around magnifiers and shadows.
- Implements `BoxShadow.copyWith` which somehow we had never needed
before.
- Makes `debugDisableShadows` handle `BlurStyle.outer` correctly.
- Adds `MagnifierInfo.toString`.
- Aligns various `operator ==`s with the style guide.
- Makes MagnifierDecoration a separate concept from Decoration, since
it's not actually compatible anywhere.
- Removes some dead code and makes other minor code simplifications.
- Uses double syntax rather than integer syntax for various double
literals for clarity.
I expect one minor golden image change (antialiasing change on
Cupertino's magnifier test).
2024-04-03 15:49:38 -07:00
Gray Mackall
29ed214e7f
Set up Kotlin linting step in ci with ktlint ( #143478 )
...
Adds a kotlin linting step to the linux analyze check, using a version of [ktlint](https://github.com/pinterest/ktlint ) hosted on [CIPD](https://chrome-infra-packages.appspot.com/p/flutter/ktlint/linux-amd64/+/version_1_1_1 ).
Configured to disallow trailing commas, because of (and now acting as a test for) https://github.com/flutter/flutter/pull/145718 . Because of this configuration the PR also removes some trailing commas in some kotlin files.
Also checks in a baseline file.
2024-04-03 21:21:00 +00:00
engine-flutter-autoroll
64af93b707
Roll Flutter Engine from 1a9e48ab1c9a to 349608d2b008 (1 revision) ( #146230 )
...
1a9e48ab1c...349608d2b0skia-flutter-autoroll@skia.org Roll Skia from 67f7b4d08d1f to afa233bb1979 (5 revisions) (flutter/engine#51872 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 20:43:07 +00:00
keyonghan
309d40940b
Update ownership to GitHub handles ( #146221 )
...
Fixes: https://github.com/flutter/flutter/issues/146220
2024-04-03 20:22:02 +00:00
engine-flutter-autoroll
df86f7f956
Roll Flutter Engine from d065763b1a63 to 1a9e48ab1c9a (1 revision) ( #146226 )
...
d065763b1a...1a9e48ab1cskia-flutter-autoroll@skia.org Roll Skia from 1d9340cf193e to 67f7b4d08d1f (1 revision) (flutter/engine#51865 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 19:47:17 +00:00
Jesse
b304740076
Refactor fuchsia_precache ( #145978 )
...
Refactor fuchsia_precache suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing fuchsia_precache tests
Part of https://github.com/flutter/flutter/issues/145482
2024-04-03 18:49:07 +00:00
engine-flutter-autoroll
a9eff9f4f4
Roll Flutter Engine from b1c23addaec5 to d065763b1a63 (1 revision) ( #146218 )
...
b1c23addae...d065763b1ajonahwilliams@google.com [scenarios] dont do a weird invalidate on TextView. (flutter/engine#51866 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 18:49:05 +00:00
LongCatIsLooong
ef7019e801
computeDryBaseline for rendering / widgets RenderBoxes (#146143 )
...
RenderWrap, Table, Overlay / Stack are not included
2024-04-03 18:36:19 +00:00
engine-flutter-autoroll
99874c1c57
Roll Flutter Engine from 7b28ae1d15cb to b1c23addaec5 (1 revision) ( #146214 )
...
7b28ae1d15...b1c23addaeskia-flutter-autoroll@skia.org Roll Skia from 5f6223a01ba4 to 1d9340cf193e (1 revision) (flutter/engine#51864 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 18:03:19 +00:00
Leo Farias
2759ec2563
Fix TextStyle.lerp() to properly interpolate text shadows ( #145666 )
...
Currently, `TextStyle.lerp()` does not properly interpolate the shadows property between two TextStyle instances. This PR addresses the issue by using ui.Shadow.lerpList() to interpolate the shadow lists, ensuring that the individual shadow properties (blur radius, color, and offset) are correctly lerped.
The changes include:
- Updating the `TextStyle.lerp()` method to use `ui.Shadow.lerpList()` for the shadows property.
- Adding a new test case in `text_style_test.dart` to verify the correct interpolation of text shadows.
Here is a snippet showing the comparison, when using `ui.Shadow.lerpList()`
https://dartpad.dev/?id=799c4bec8b791b74580193174759b93d
Closes #145665
2024-04-03 17:49:58 +00:00
LongCatIsLooong
a81729c68e
Renderflex cross intrinsic size with baseline alignment ( #146185 )
2024-04-03 17:41:50 +00:00
engine-flutter-autoroll
5aaee98b75
Roll Flutter Engine from 56fa2c33a5f7 to 7b28ae1d15cb (1 revision) ( #146208 )
...
56fa2c33a5...7b28ae1d15skia-flutter-autoroll@skia.org Roll Skia from ce3b5e8eb59b to 5f6223a01ba4 (1 revision) (flutter/engine#51863 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 17:01:00 +00:00
Jesse
113013bb07
Refactor customer_testing ( #145911 )
...
Refactor customer_testing suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing customer_testing tests
Part of https://github.com/flutter/flutter/issues/145482
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-04-03 16:32:54 +00:00
Taha Tesser
80d774d8dc
Add DropdownMenu cursor behavior sample ( #146133 )
...
fixes [Add `DropdownMenu` cursor behavior sample to `DropdownMenu.enabled` & `DropdownMenu.requestFocusOnTap` docs](https://github.com/flutter/flutter/issues/146131 )
### Preview
2024-04-03 16:31:06 +00:00
Furkan Acar
e868e2b383
Add SegmentedButton expand feature ( #142804 )
...
fix #139486
The `expandedInsets` property enhancement for the `SegmentedButton` widget introduces flexibility in button layout design within Flutter applications. When `expandedInsets` is not null, this property allows the `SegmentedButton` to expand, filling the available horizontal space of its parent container and also have the specified insets, thus ensuring a uniform distribution of segment widths across the button. Conversely, with `expandedInsets` is null, the widget sizes itself based on the intrinsic sizes of its segments, preserving the natural width of each segment. This addition enhances the adaptability of the `SegmentedButton` to various UI designs, enabling developers to achieve both expansive and compact button layouts seamlessly.
### Setting expandedInsets = null
<img width="724" alt="image" src="https://github.com/flutter/flutter/assets/65075121/f173b327-a34b-49f0-a7b1-a212a376c5e3 ">
### Setting expandedInsets = EdgeInsets.zero
<img width="724" alt="image" src="https://github.com/flutter/flutter/assets/36861262/f141a3d3-80e3-4aeb-b7c8-d56ca77ca049 ">
2024-04-03 16:16:52 +00:00
engine-flutter-autoroll
b63196def2
Roll Flutter Engine from e36b9b10c36f to 56fa2c33a5f7 (1 revision) ( #146205 )
...
e36b9b10c3...56fa2c33a5skia-flutter-autoroll@skia.org Roll Dart SDK from 36b6628190e2 to 85adde7d4b5a (1 revision) (flutter/engine#51862 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 16:10:06 +00:00
engine-flutter-autoroll
4077984ead
Roll Packages from 83f3842c27b5 to 0e848facdb53 (3 revisions) ( #146201 )
...
83f3842c27...0e848facdbstuartmorgan@google.com [in_app_purchase] Mostly convert to Android Pigeon (flutter/packages#6262 )
2024-04-02 goderbauer@google.com [various] Remove all traces of the `_ambiguate` workaround (flutter/packages#6449 )
2024-04-02 engine-flutter-autoroll@skia.org Roll Flutter from 7fa932be5c12 to a418568a6498 (5 revisions) (flutter/packages#6450 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 16:06:18 +00:00
Ian Hickson
950ec1c405
Enhance ColorScheme.fromSeed with a new variant parameter ( #144805 )
...
Fixes #144649
This PR is to add an enhancement for `ColorScheme.fromSeed()`. When we input a brighter color with a high chroma and we want the resulting `ColorScheme` respects the source color, we can achieve this by setting
```dart
ColorScheme.fromSeed(
seedColor: sourceColor,
variant: Variant.fidelity,
...
)
```
Here is a demo for `ColorScheme` constructed by all 9 variants:
2024-04-03 15:54:34 +00:00
engine-flutter-autoroll
a46ed4ee07
Roll Flutter Engine from 0280de5be276 to e36b9b10c36f (1 revision) ( #146200 )
...
0280de5be2...e36b9b10c3skia-flutter-autoroll@skia.org Roll Skia from a247f8cc2a66 to ce3b5e8eb59b (24 revisions) (flutter/engine#51861 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 15:24:08 +00:00
Bruno Leroux
1326c8ee53
Fix typos in bottom_sheet.dart ( #146188 )
...
This PR fixes some typos in material/bottom_sheet.dart file.
2024-04-03 15:18:06 +00:00
engine-flutter-autoroll
bd4c17155d
Roll Flutter Engine from 979030d81f8d to 0280de5be276 (2 revisions) ( #146199 )
...
979030d81f...0280de5be2skia-flutter-autoroll@skia.org Roll Skia from cd75e4672719 to a247f8cc2a66 (1 revision) (flutter/engine#51840 )
2024-04-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 892ec6169844 to 36b6628190e2 (1 revision) (flutter/engine#51860 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 14:25:53 +00:00
engine-flutter-autoroll
394e2a9bae
Roll Flutter Engine from bef3bbe3f74e to 979030d81f8d (1 revision) ( #146186 )
...
bef3bbe3f7...979030d81fskia-flutter-autoroll@skia.org Roll Dart SDK from 091dd9120d35 to 892ec6169844 (3 revisions) (flutter/engine#51859 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 08:16:09 +00:00
engine-flutter-autoroll
434451c107
Roll Flutter Engine from 5fc83bc24b2e to bef3bbe3f74e (1 revision) ( #146183 )
...
5fc83bc24b...bef3bbe3f7matanlurey@users.noreply.github.com Use non-deprecated replacements for Android JUnit and test instrumentation (flutter/engine#51854 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 06:18:11 +00:00
engine-flutter-autoroll
8761788442
Roll Flutter Engine from 0da1b2eb370a to 5fc83bc24b2e (1 revision) ( #146180 )
...
0da1b2eb37...5fc83bc24bjonahwilliams@google.com [Impeller] make color source a variant instead of a closure. (flutter/engine#51853 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 05:29:30 +00:00
LongCatIsLooong
3295a48f17
Avoid calling TextPainter.plainText for simple static text ( #146084 )
...
`InlineSpan.toPlainText` is surprisingly expensive even for a simple `TextSpan` like `TextSpan(text: 'AAA', children: [TextSpan(text: char * 10), TextSpan(text: char * 20)])`
2024-04-03 05:22:56 +00:00
