37539 Commits

Author SHA1 Message Date
engine-flutter-autoroll
78b754e592
Roll Flutter Engine from d46933e6772e to b27e1b38375b (9 revisions) (#136982)
d46933e677...b27e1b3837

2023-10-20 47866232+chunhtai@users.noreply.github.com Add link support in web accessibility (flutter/engine#46117)
2023-10-20 mdebbar@google.com [web] Support `flutterViewId` in platform view messages (flutter/engine#46891)
2023-10-20 jacksongardner@google.com Fix async image loading issues in skwasm. (flutter/engine#47117)
2023-10-20 flar@google.com Add option to save Impeller failure images in rendertests (flutter/engine#47142)
2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from b960e9140f56 to 9ffd5ef9a9ed (3 revisions) (flutter/engine#47167)
2023-10-20 chris@bracken.jp [macOS] Eliminate extraneous loadView calls (flutter/engine#47166)
2023-10-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ba96a157a8eb to 53fee35b299f (1 revision) (flutter/engine#47165)
2023-10-20 jonahwilliams@google.com [Impeller] GPU Tracer for GLES. (flutter/engine#47080)
2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from de628929015d to b960e9140f56 (2 revisions) (flutter/engine#47164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 21:13:38 +00:00
flutter-pub-roller-bot
d7c82888c3
Roll pub packages (#136924)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-10-20 20:36:29 +00:00
Kevin Chisholm
f68612e770
[docs] Expand categories for automated release notes (#136967)
Updates release.yml to expand categories for automated release notes utilizing updated labels. 

For more information on automated release notes see: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

CC: @MaryaBelanger @atsansone
2023-10-20 20:33:15 +00:00
engine-flutter-autoroll
6b78b72618
Roll Flutter Engine from 21b5c3771ee1 to d46933e6772e (3 revisions) (#136973)
21b5c3771e...d46933e677

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 461218cee44c to de628929015d (1 revision) (flutter/engine#47161)
2023-10-20 mdebbar@google.com [web] Make HotRestartCacheHandler standalone (flutter/engine#46906)
2023-10-20 mdebbar@google.com [web] Attach pointer event listeners in the bubble phase (flutter/engine#47121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 20:27:15 +00:00
Jonah Williams
841cc675b3
[Impeller] add OpenGL GPU tracing to devicelab tests. (#136974)
Adds the metadata key required to enable OpenGLES GPU tracing. This is off by default because the API crashes on some GPU models, but it should be safe on the Pixel 7 (others TBD based on testing results).
2023-10-20 20:23:25 +00:00
engine-flutter-autoroll
abd9374feb
Roll Flutter Engine from f9d1dbc39f4c to 21b5c3771ee1 (1 revision) (#136969)
f9d1dbc39f...21b5c3771e

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 04a9f72abd87 to 461218cee44c (1 revision) (flutter/engine#47160)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 17:41:27 +00:00
Daco Harkes
0a18aa4667
Default NativeAssets Darwin and IOS target archs if missing (#136948)
Make the `NativeAssets` target consistent with `build_info.dart`'s
documentation on missing `IosArchs` or `DarwinArchs`.

Bug:

* https://github.com/flutter/flutter/issues/136931

Also, updates the doc to reflect that MacOS is by default built for both
x64 and arm64. The PR making universal binaries the default didn't
update the doc comment.

* https://github.com/flutter/flutter/pull/100271

Please note that these defines are handled inconsistently in
`flutter_tools`. In some places they default to what's specified in the
doc-comment. In other places a `MissingDefineException` is thrown. I
believe the code around `build_info.dart` and the `environment` could
benefit from a wrapping so that defaults or missing definitions are
handled consistently in the code base.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-20 09:28:52 -07:00
engine-flutter-autoroll
ddbf09c21c
Roll Flutter Engine from 6d1e9eec0841 to f9d1dbc39f4c (1 revision) (#136966)
6d1e9eec08...f9d1dbc39f

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 24abc105675c to 04a9f72abd87 (1 revision) (flutter/engine#47159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 16:26:26 +00:00
engine-flutter-autoroll
6366c1f69c
Roll Flutter Engine from 9b88ff83fd82 to 6d1e9eec0841 (2 revisions) (#136965)
9b88ff83fd...6d1e9eec08

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from e836c3aa2b98 to 24abc105675c (1 revision) (flutter/engine#47156)
2023-10-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jkQctnDMmHydahKfZ... to VTlSkkxOaJrlxj_vv... (flutter/engine#47155)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from jkQctnDMmHyd to VTlSkkxOaJrl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 15:43:17 +00:00
engine-flutter-autoroll
0883cb2e96
Roll Packages from 09c6b1152070 to be915be92708 (6 revisions) (#136964)
09c6b11520...be915be927

2023-10-20 737941+loic-sharma@users.noreply.github.com [ci] Finalize migration to x64 specific Windows platform (flutter/packages#5174)
2023-10-19 15619084+vashworth@users.noreply.github.com [image_picker_ios] Update UITests for Xcode 15/iOS 17 (flutter/packages#5176)
2023-10-19 stuartmorgan@google.com [ci] Add emulator tests on older Android version (flutter/packages#4616)
2023-10-19 engine-flutter-autoroll@skia.org Roll Flutter from 189196d104e2 to c2bd2c1175f5 (11 revisions) (flutter/packages#5183)
2023-10-19 stuartmorgan@google.com [tool] Fix `filter-packages-to` when everything is changed (flutter/packages#5182)
2023-10-19 tarrinneal@gmail.com [pigeon] add flutter api protocol (flutter/packages#5181)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 15:38:15 +00:00
engine-flutter-autoroll
483ac618b6
Roll Flutter Engine from de780872533c to 9b88ff83fd82 (4 revisions) (#136959)
de78087253...9b88ff83fd

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 17f05db514c3 to e836c3aa2b98 (1 revision) (flutter/engine#47154)
2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 5291f485514f to 17f05db514c3 (4 revisions) (flutter/engine#47151)
2023-10-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eKYGl_wBcnT-n0J8n... to tcVA-iW-vOHPnwh_P... (flutter/engine#47149)
2023-10-20 skia-flutter-autoroll@skia.org Roll Dart SDK from aadeeb497dbe to ba96a157a8eb (1 revision) (flutter/engine#47147)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from eKYGl_wBcnT- to tcVA-iW-vOHP

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 13:43:25 +00:00
engine-flutter-autoroll
72e454d913
Roll Flutter Engine from 1e107c21328a to de780872533c (1 revision) (#136952)
1e107c2132...de78087253

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 1d63da5da8e8 to 5291f485514f (3 revisions) (flutter/engine#47143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 11:55:26 +00:00
engine-flutter-autoroll
f33b82e528
Roll Flutter Engine from fd33e7e75eac to 1e107c21328a (1 revision) (#136949)
fd33e7e75e...1e107c2132

2023-10-20 skia-flutter-autoroll@skia.org Roll Dart SDK from f71ddbe0a500 to aadeeb497dbe (1 revision) (flutter/engine#47141)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 11:12:44 +00:00
engine-flutter-autoroll
8b2c643c96
Roll Flutter Engine from 9dd59f7fcff9 to fd33e7e75eac (1 revision) (#136942)
9dd59f7fcf...fd33e7e75e

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 4c1ee6935b7b to 1d63da5da8e8 (1 revision) (flutter/engine#47140)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 10:31:18 +00:00
engine-flutter-autoroll
eefafdacdb
Roll Flutter Engine from cc3356c0e68f to 9dd59f7fcff9 (1 revision) (#136935)
cc3356c0e6...9dd59f7fcf

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from e5c37860c792 to 4c1ee6935b7b (1 revision) (flutter/engine#47136)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 04:06:34 +00:00
engine-flutter-autoroll
07042fa27c
Roll Flutter Engine from 504a99d93f42 to cc3356c0e68f (2 revisions) (#136934)
504a99d93f...cc3356c0e6

2023-10-19 matanlurey@users.noreply.github.com Remove unused `fbo` parameter in GLES `SetAsFramebufferAttachment()`. (flutter/engine#47133)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 0hLSNJ_DCTzRvTVJe... to jkQctnDMmHydahKfZ... (flutter/engine#47132)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 0hLSNJ_DCTzR to jkQctnDMmHyd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-20 00:16:27 +00:00
engine-flutter-autoroll
84db74c9b1
Roll Flutter Engine from 503b84295462 to 504a99d93f42 (3 revisions) (#136930)
503b842954...504a99d93f

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from b540ed3ba8e7 to e5c37860c792 (2 revisions) (flutter/engine#47126)
2023-10-19 chris@bracken.jp [macOS] Fail early when no a11y notification (flutter/engine#47129)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z2mOZ5cuPJWvKn22P... to eKYGl_wBcnT-n0J8n... (flutter/engine#47128)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Z2mOZ5cuPJWv to eKYGl_wBcnT-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 23:16:17 +00:00
engine-flutter-autoroll
bfe174bb1d
Roll Flutter Engine from 3b0469b0c718 to 503b84295462 (1 revision) (#136928)
3b0469b0c7...503b842954

2023-10-19 dkwingsmt@users.noreply.github.com Reland 2 (part 2): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47095)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 22:43:16 +00:00
Kate Lovett
548843b9f9
Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" (#136905)
Reverts flutter/flutter#132291

We have found this introduced flakiness in many of our tests.

Fixes https://github.com/flutter/flutter/issues/135728
2023-10-19 22:10:14 +00:00
Christopher Fujino
fd1604666e
[flutter_tools] move build_preview_test from commands/permeable to integration shard (#136912)
Fixes https://github.com/flutter/flutter/issues/136907 by moving the test to the tools integration shard, which DOES have VS code installed.
2023-10-19 22:03:04 +00:00
engine-flutter-autoroll
27cf404da4
Roll Flutter Engine from b40042ebb95b to 3b0469b0c718 (2 revisions) (#136922)
b40042ebb9...3b0469b0c7

2023-10-19 jason-simmons@users.noreply.github.com [Impeller] Use a weak pointer factory in GPUSurfaceGLImpeller that supports the raster thread merger (flutter/engine#47081)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from ea86103e06b1 to f71ddbe0a500 (1 revision) (flutter/engine#47124)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 21:58:21 +00:00
Andrew Kolos
25bed918b8
do not include entries from --dart-define-from-file files in the gradle config or environment during build (#136865)
Fixes https://github.com/flutter/flutter/issues/130599 and https://github.com/flutter/flutter/issues/136444
2023-10-19 21:01:51 +00:00
engine-flutter-autoroll
b5d8d77e5f
Roll Flutter Engine from bfd2ffb9a8bc to b40042ebb95b (2 revisions) (#136915)
bfd2ffb9a8...b40042ebb9

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 04449cda5a0a to b540ed3ba8e7 (4 revisions) (flutter/engine#47118)
2023-10-19 jiahaog@users.noreply.github.com Fix use of nested designators (flutter/engine#45869)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 21:01:50 +00:00
engine-flutter-autoroll
bbdcaea61e
Roll Flutter Engine from 9d49175618f5 to bfd2ffb9a8bc (2 revisions) (#136910)
9d49175618...bfd2ffb9a8

2023-10-19 ychris@google.com [iOS] Load additional Cupertino system fonts (flutter/engine#46857)
2023-10-19 jiahaog@users.noreply.github.com Add missing import (flutter/engine#47083)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 19:03:18 +00:00
Qun Cheng
40776d01f1
Allow users to customize search algorithm in DropdownMenu (#136848)
Fixes #136735

This PR is to add a searchCallback to allow users to customize the search algorithm. This feature is used to fix b/305662376 which needs an exact match algorithm.
2023-10-19 18:32:50 +00:00
Elliott Brooks
01eef7ca13
Upgrade Flutter deps to pull in latest vm_service and dwds (#136734)
Generated by running `flutter update-packages --force-upgrade`

Updates vm_service to [12.0.0](https://pub.dev/packages/vm_service/versions/12.0.0) and dwds to [22.0.0](https://pub.dev/packages/dwds/versions/22.0.0)

The changes to `packages/flutter_tools/lib/src/isolated/devfs_web.dart` are for the new interface of DWDS introduced in https://github.com/dart-lang/webdev/pull/2243

FYI @bkonyi
2023-10-19 18:29:02 +00:00
Victoria Ashworth
3c3d414e7c
[Reland] Skip injecting Bonjour settings when port publication is disabled (#136842)
Reland https://github.com/flutter/flutter/pull/136751 with fixes.
2023-10-19 17:38:52 +00:00
Kostia Sokolovskyi
9fa9fd365c
_DefaultTabControllerState should dispose all created TabContoller instances. (#136608) 2023-10-19 10:38:19 -07:00
Greg Spencer
0abb017cfd
Reland: "Add code for updating focusedChild when removing grandchildren from scope" (#136899) 2023-10-19 10:22:46 -07:00
engine-flutter-autoroll
f82299ef91
Roll Flutter Engine from 418dce4feaf7 to 9d49175618f5 (1 revision) (#136901)
418dce4fea...9d49175618

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from b31b189be018 to 04449cda5a0a (1 revision) (flutter/engine#47105)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 17:22:04 +00:00
Gray Mackall
f8c00983d6
Unmark linux_android platform_channels_benchmarks as flaky (#136838)
Unmarking this test as flaky in favor of a fix for the [underlying issue](https://github.com/flutter/flutter/issues/135035). None of the other impacted tests have been marked as flaky, so I think it is better for this one to not be treated differently.
2023-10-19 17:09:13 +00:00
engine-flutter-autoroll
ced0e7417b
Roll Packages from 14aa69e2e54c to 09c6b1152070 (4 revisions) (#136896)
14aa69e2e5...09c6b11520

2023-10-19 engine-flutter-autoroll@skia.org Manual roll Flutter from 6eea6e277e56 to 189196d104e2 (44 revisions) (flutter/packages#5178)
2023-10-18 47866232+chunhtai@users.noreply.github.com [go_router] adds ability to dynamically update routing table. (flutter/packages#5079)
2023-10-18 devoncarew@google.com [flutter_lints] rev flutter_lints to 3.0; increase dep on package:lints (flutter/packages#5177)
2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2f708eb8396e to 6c4930c4ac86 (1 revision) (flutter/packages#5173)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 15:45:27 +00:00
engine-flutter-autoroll
f9bec6cfb9
Roll Flutter Engine from 28cb2508b8e0 to 418dce4feaf7 (2 revisions) (#136895)
28cb2508b8...418dce4fea

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 8cf64b0795af to b31b189be018 (1 revision) (flutter/engine#47103)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b425a25a6dd to ea86103e06b1 (1 revision) (flutter/engine#47101)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 15:30:07 +00:00
auto-submit[bot]
c2bd2c1175
Reverts "Fixes ability to call nextFocus() on a node to focus its descendant" (#136894)
Reverts flutter/flutter#136773
Initiated by: itsjustkevin
This change reverts the following previous change:
Original Description:
fixes https://github.com/flutter/flutter/issues/134854
2023-10-19 14:38:26 +00:00
engine-flutter-autoroll
8ab876702f
Roll Flutter Engine from d0d7b4d61265 to 28cb2508b8e0 (1 revision) (#136878)
d0d7b4d612...28cb2508b8

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 62acc1e162cc to 8cf64b0795af (2 revisions) (flutter/engine#47097)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 12:08:32 +00:00
engine-flutter-autoroll
136249f2d6
Roll Flutter Engine from 8d51b64e9440 to d0d7b4d61265 (13 revisions) (#136872)
8d51b64e94...d0d7b4d612

2023-10-19 flar@google.com Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094)
2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 64c5de6663a4 to 62acc1e162cc (1 revision) (flutter/engine#47093)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from eb3fb9a13e16 to 1b425a25a6dd (1 revision) (flutter/engine#47092)
2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 85971b25cf4b to 64c5de6663a4 (2 revisions) (flutter/engine#47091)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PxJM5ivbnbYoVkqBg... to 0hLSNJ_DCTzRvTVJe... (flutter/engine#47090)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from d9b1e60fe442 to eb3fb9a13e16 (1 revision) (flutter/engine#47084)
2023-10-18 chinmaygarde@google.com Update buildroot to ab76ccba2ca4ce4. (flutter/engine#47078)
2023-10-18 fujino@google.com migrate const_finder to use the implementation from package:kernel (flutter/engine#47077)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d561b276b5d9 to 85971b25cf4b (1 revision) (flutter/engine#47076)
2023-10-18 jason-simmons@users.noreply.github.com [Impeller] Guard execution of ReactorGLES operations with a mutex (flutter/engine#47068)
2023-10-18 chinmaygarde@google.com [Impeller] Document ReactorGLES. (flutter/engine#47070)
2023-10-18 matej.knopp@gmail.com [web] Ensure handled key event is not propagated to IME (flutter/engine#46829)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2HSBpWikGWvP to Z2mOZ5cuPJWv
  fuchsia/sdk/core/mac-amd64 from PxJM5ivbnbYo to 0hLSNJ_DCTzR

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-19 07:59:57 +00:00
auto-submit[bot]
cbf50a953b
Reverts "Add code for updating focusedChild when removing grandchildren from scope" (#136862)
Reverts flutter/flutter#136771
Initiated by: gspencergoog
This change reverts the following previous change:
Original Description:
## Description

This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/136758

## Tests
 - Added regression test.
2023-10-19 03:13:25 +00:00
auto-submit[bot]
c881808ed2
Reverts "Use Layer.toImage for golden tests on CanvasKit" (#136860)
Reverts flutter/flutter#135249
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
2023-10-19 02:20:19 +00:00
Michael Goderbauer
571039f6ee
Bump flutter_lints to 3.0 (#136841)
Follow-up to https://github.com/flutter/packages/pull/5177
2023-10-18 23:53:08 +00:00
Greg Spencer
2492242593
Add code for updating focusedChild when removing grandchildren from scope (#136771)
## Description

This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/136758

## Tests
 - Added regression test.
2023-10-18 23:44:40 +00:00
Harry Terkelsen
747128ff7a
Use Layer.toImage for golden tests on CanvasKit (#135249)
Changes golden tests on CanvasKit to use Layer.toImage instead of
browser APIs for screenshots. This brings it more in line with other
platforms and should also fix some async timing bugs with tests.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-18 16:39:27 -07:00
engine-flutter-autoroll
9391a88b18
Roll Flutter Engine from b67edb05d3f7 to 8d51b64e9440 (4 revisions) (#136846)
b67edb05d3...8d51b64e94

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d46a3697d3c5 to d561b276b5d9 (1 revision) (flutter/engine#47074)
2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from b423d5753fdc to d9b1e60fe442 (1 revision) (flutter/engine#47073)
2023-10-18 dkwingsmt@users.noreply.github.com Reland 2 (part 1): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47062)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ef0e93524e7d to d46a3697d3c5 (2 revisions) (flutter/engine#47072)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 23:09:37 +00:00
engine-flutter-autoroll
d9fdbd3df4
Roll Flutter Engine from 6caee3236d37 to b67edb05d3f7 (5 revisions) (#136844)
6caee3236d...b67edb05d3

2023-10-18 31859944+LongCatIsLooong@users.noreply.github.com [iOS TextInputPlugin] adjust the markedTextRange when replacing text. (flutter/engine#46603)
2023-10-18 zanderso@users.noreply.github.com Reland: Remove the frontend server wrapper (flutter/engine#47010)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 9880c4006735 to ef0e93524e7d (1 revision) (flutter/engine#47069)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 523f04f1a898 to 9880c4006735 (1 revision) (flutter/engine#47067)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ccd07c6f5042 to 523f04f1a898 (1 revision) (flutter/engine#47065)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 22:25:47 +00:00
Sam Rawlins
25d2cdaab7
Null-assert the value given to a Completer expecting a non-null value (#136776)
The code with out the null assertion is legal as per the type signature, but will throw a runtime exception if the nullable value is null. To make this exception more explicit, the value must be null-checked before completing the completer with the value.

The analyzer will soon enforce such checks. See https://github.com/dart-lang/sdk/issues/53253.

Fixes https://github.com/flutter/flutter/issues/136775
2023-10-18 22:19:18 +00:00
engine-flutter-autoroll
189196d104
Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) (#136834)
ab86c53c19...6caee3236d

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from b8c989df901a to ccd07c6f5042 (3 revisions) (flutter/engine#47063)
2023-10-18 matanlurey@users.noreply.github.com Add `--lint-all=<regex>` as an option for `clang_tidy`, refactor lint targets (flutter/engine#46522)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 21:27:10 +00:00
auto-submit[bot]
c32ffa65c9
Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" (#136839)
Reverts flutter/flutter#136751
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
2023-10-18 20:33:17 +00:00
Greg Spencer
13a0d475f5
Convert menus to use OverlayPortal (#130534)
## Description

This converts the `MenuAnchor` class to use `OverlayPortal` instead of directly using the overlay.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/124830

## Tests
 - No tests yet (hence it is a draft)
2023-10-18 20:13:08 +00:00
Victoria Ashworth
1599cbebc3
[Reland] Skip injecting Bonjour settings when port publication is disabled (#136751)
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
2023-10-18 20:08:19 +00:00
engine-flutter-autoroll
697242c9f1
Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) (#136832)
0eff5d1918...ab86c53c19

2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from da48c75b73b1 to b423d5753fdc (5 revisions) (flutter/engine#47061)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 19:39:07 +00:00
chunhtai
24530b8021
Fixes ability to call nextFocus() on a node to focus its descendant (#136773)
fixes https://github.com/flutter/flutter/issues/134854
2023-10-18 19:00:53 +00:00